t of 4. kfree(NULL) is perfectly legal.
I believe pdev could potentially be NULL, so it's the dereference
that is the problem.
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
Mor
that it's not very pretty.
Now that Uwe solved the issue regarding converting the function to
platform_device_register_full(), I will look into sending a second patch
that would remove these lines.
Thank you!
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hello Uwe,
I was to quick to resend the patch, sorry.
On Sat, May 17, 2014 at 09:18:21PM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> On Sat, May 17, 2014 at 08:40:33PM +0200, Emil Goode wrote:
> > If we fail to allocate struct platform_device pdev we
> > dereference it
Hello Uwe,
On Sat, May 17, 2014 at 09:05:46PM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> On Sat, May 17, 2014 at 05:35:40PM +0200, Emil Goode wrote:
> > On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
> > > On Fri, May 16, 2014 at 01:49:10PM +
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode
---
v3: Made subject line more specific.
v2: Changed to return -ENOMEM instead of ret
Hello Uwe,
On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
> Hello Walter,
>
> On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
> > Am 16.05.2014 13:16, schrieb Emil Goode:
> > > Hello Walter,
> > >
> > > On Fri, May
Hello Uwe,
On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
Hello Walter,
On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
Am 16.05.2014 13:16, schrieb Emil Goode:
Hello Walter,
On Fri, May 16, 2014 at 12:40:19PM +0200, walter harms wrote:
Am
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v3: Made subject line more specific.
v2: Changed to return
Hello Uwe,
On Sat, May 17, 2014 at 09:05:46PM +0200, Uwe Kleine-König wrote:
Hello Emil,
On Sat, May 17, 2014 at 05:35:40PM +0200, Emil Goode wrote:
On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
Am
Hello Uwe,
I was to quick to resend the patch, sorry.
On Sat, May 17, 2014 at 09:18:21PM +0200, Uwe Kleine-König wrote:
Hello Emil,
On Sat, May 17, 2014 at 08:40:33PM +0200, Emil Goode wrote:
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err
);
3 out of 4 of the lines are bad.
I agree that it's not very pretty.
Now that Uwe solved the issue regarding converting the function to
platform_device_register_full(), I will look into sending a second patch
that would remove these lines.
Thank you!
Best regards,
Emil Goode
that is the problem.
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
gt;
> On Fri, May 16, 2014 at 11:54:05AM +0200, Emil Goode wrote:
> > If we fail to allocate struct platform_device pdev we
> > dereference it after the goto label err.
> >
> > I have rearranged the error handling a bit to fix the issue
> > and also mak
> to be buggy like a swamp picnic.
Thank you for the colorful reply, I guess there is no need for me to
further defend my choice of labels :)
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hello Walter,
On Fri, May 16, 2014 at 12:40:19PM +0200, walter harms wrote:
>
>
> Am 16.05.2014 11:54, schrieb Emil Goode:
> > If we fail to allocate struct platform_device pdev we
> > dereference it after the goto label err.
> >
> > I have rearranged the erro
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode
---
v2: Changed to return -ENOMEM instead of ret where possible and
updated
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2: Changed to return -ENOMEM instead of ret where possible
Hello Walter,
On Fri, May 16, 2014 at 12:40:19PM +0200, walter harms wrote:
Am 16.05.2014 11:54, schrieb Emil Goode:
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also
in the middle of the success handling. Whenever I see new creative
error handling like this it drives me nuts because obviously it's going
to be buggy like a swamp picnic.
Thank you for the colorful reply, I guess there is no need for me to
further defend my choice of labels :)
Best regards,
Emil
, 2014 at 11:54:05AM +0200, Emil Goode wrote:
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2
Hello Dan,
Thanks for the review and sorry for the late reply.
On Thu, May 15, 2014 at 11:32:13PM +0300, Dan Carpenter wrote:
> On Thu, May 15, 2014 at 09:24:30PM +0200, Emil Goode wrote:
> > If we fail to allocate struct platform_device pdev we
> > dereference it after the
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode
---
arch/arm/mach-imx/devices/platform-ipu-core.c | 22 +-
1
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I have rearranged the error handling a bit to fix the issue
and also make it more clear.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/arm/mach-imx/devices/platform-ipu-core.c | 22
Hello Dan,
Thanks for the review and sorry for the late reply.
On Thu, May 15, 2014 at 11:32:13PM +0300, Dan Carpenter wrote:
On Thu, May 15, 2014 at 09:24:30PM +0200, Emil Goode wrote:
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
I
:1.0 (unregistered net_device):
Failed to write reg index 0x0001: -19
Signed-off-by: Emil Goode
---
drivers/net/usb/ax88179_178a.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 054e59c..fe20ca8 100644
:1.0 (unregistered net_device):
Failed to write reg index 0x0001: -19
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/net/usb/ax88179_178a.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 054e59c
In the cas_lock_tx function we acquire multiple locks in a loop and
need to use nested lock annotation to prevent lockdep warnings.
Reported-by: Meelis Roos
Signed-off-by: Emil Goode
---
drivers/net/ethernet/sun/cassini.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In the cas_lock_tx function we acquire multiple locks in a loop and
need to use nested lock annotation to prevent lockdep warnings.
Reported-by: Meelis Roos mr...@linux.ee
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/net/ethernet/sun/cassini.c |2 +-
1 file changed, 1 insertion
The following commit left some unused variables behind.
commit 80db2734acbc78db12798cfb611d6acc7fe389e6
Author: Fredrick John Berchmans
Date: Fri May 2 19:50:15 2014 -0700
staging: lustre use kernel socket sockopt apis
Signed-off-by: Emil Goode
---
drivers/staging/lustre/lustre/libcfs
The following commit left some unused variables behind.
commit 80db2734acbc78db12798cfb611d6acc7fe389e6
Author: Fredrick John Berchmans fredrickprasha...@gmail.com
Date: Fri May 2 19:50:15 2014 -0700
staging: lustre use kernel socket sockopt apis
Signed-off-by: Emil Goode emilgo
in .start() callback")
This patch fixes the bug by removing the call to brcms_remove()
and moves the brcms_request_fw() call to the top of the .start
callback to not initiate anything unless firmware is installed.
Signed-off-by: Emil Goode
---
drivers/net/wireless/brcm80211/brcm
The brcms_attach function is defined as static but the comment is
saying that it should not be static or gcc will issue a warning.
I believe we can remove the comment as I don't se a problem with
this function being defined as static.
Signed-off-by: Emil Goode
---
drivers/net/wireless/brcm80211
)
This patch fixes the bug by removing the call to brcms_remove()
and moves the brcms_request_fw() call to the top of the .start
callback to not initiate anything unless firmware is installed.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 14
The brcms_attach function is defined as static but the comment is
saying that it should not be static or gcc will issue a warning.
I believe we can remove the comment as I don't se a problem with
this function being defined as static.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/net
time from within
the rx_process function in the usbnet module.
Signed-off-by: Emil Goode
Reported-by: Bjørn Mork
---
drivers/net/usb/asix_devices.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 9765a7d
On Thu, Feb 13, 2014 at 04:56:58PM +, David Laight wrote:
> From: Of Emil Goode
> > This patch removes a generic hard_header_len check from the usbnet
> > module that is causing dropped packages under certain circumstances
> > for devices that send rx packets that
one list to queue skbs for cleanup.
The changes place full responsibility on the rx_fixup callback
functions that clone skbs to only pass valid skbs to the
usbnet_skb_return function.
Signed-off-by: Emil Goode
Reported-by: Igor Gnatenko
---
v2: Added a comment in the changelog about the remo
On Thu, Feb 13, 2014 at 10:05:39AM +0100, Bjørn Mork wrote:
> Emil Goode writes:
>
> > This patch removes a generic hard_header_len check from the usbnet
> > module that is causing dropped packages under certain circumstances
> > for devices that send rx packets t
On Thu, Feb 13, 2014 at 10:05:39AM +0100, Bjørn Mork wrote:
Emil Goode emilgo...@gmail.com writes:
This patch removes a generic hard_header_len check from the usbnet
module that is causing dropped packages under certain circumstances
for devices that send rx packets that cross urb
list to queue skbs for cleanup.
The changes place full responsibility on the rx_fixup callback
functions that clone skbs to only pass valid skbs to the
usbnet_skb_return function.
Signed-off-by: Emil Goode emilgo...@gmail.com
Reported-by: Igor Gnatenko i.gnatenko.br...@gmail.com
---
v2: Added
On Thu, Feb 13, 2014 at 04:56:58PM +, David Laight wrote:
From: Of Emil Goode
This patch removes a generic hard_header_len check from the usbnet
module that is causing dropped packages under certain circumstances
for devices that send rx packets that cross urb boundaries.
One
time from within
the rx_process function in the usbnet module.
Signed-off-by: Emil Goode emilgo...@gmail.com
Reported-by: Bjørn Mork bj...@mork.no
---
drivers/net/usb/asix_devices.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net
that clone skbs to only pass valid skbs to the
usbnet_skb_return function.
Signed-off-by: Emil Goode
Reported-by: Igor Gnatenko
---
An alternative solution is to add the ETH_HLEN check to
usbnet_skb_return() and add short skbs to the skb->done
list to be cleaned up in rx_process().
drivers/
that clone skbs to only pass valid skbs to the
usbnet_skb_return function.
Signed-off-by: Emil Goode emilgo...@gmail.com
Reported-by: Igor Gnatenko i.gnatenko.br...@gmail.com
---
An alternative solution is to add the ETH_HLEN check to
usbnet_skb_return() and add short skbs to the skb-done
list
On Mon, Feb 10, 2014 at 02:05:20PM +0100, Bjørn Mork wrote:
> Oliver Neukum writes:
> > On Mon, 2014-02-10 at 13:00 +0100, Emil Goode wrote:
> >> On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote:
> >
> >> > Well, then how about simply removin
On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote:
> On Mon, 2014-02-10 at 00:06 +0100, Emil Goode wrote:
> > The AX88772B occasionally send rx packets that cross urb boundaries
> > and the remaining partial packet is sent with no hardware header.
> > When the
On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote:
On Mon, 2014-02-10 at 00:06 +0100, Emil Goode wrote:
The AX88772B occasionally send rx packets that cross urb boundaries
and the remaining partial packet is sent with no hardware header.
When the buffer with a partial packet
On Mon, Feb 10, 2014 at 02:05:20PM +0100, Bjørn Mork wrote:
Oliver Neukum oli...@neukum.org writes:
On Mon, 2014-02-10 at 13:00 +0100, Emil Goode wrote:
On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote:
Well, then how about simply removing the check?
It seems to have
is discarding
small skbs, which I believe has caused some confusion.
Signed-off-by: Emil Goode
Reported-by: Igor Gnatenko
---
v2: This patch solves the bug by introducing a new flag instead of
setting hard_header_len to 0. I realize that there are already
a lot of flags but hard_header_len
time from within
the rx_process function in the usbnet module.
Signed-off-by: Emil Goode
Reported-by: Bjørn Mork
---
drivers/net/usb/asix_devices.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 7ced4ed
time from within
the rx_process function in the usbnet module.
Signed-off-by: Emil Goode emilgo...@gmail.com
Reported-by: Bjørn Mork bj...@mork.no
---
drivers/net/usb/asix_devices.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb
is discarding
small skbs, which I believe has caused some confusion.
Signed-off-by: Emil Goode emilgo...@gmail.com
Reported-by: Igor Gnatenko i.gnatenko.br...@gmail.com
---
v2: This patch solves the bug by introducing a new flag instead of
setting hard_header_len to 0. I realize
On Fri, Feb 07, 2014 at 10:38:04AM +0100, Bjørn Mork wrote:
> Emil Goode writes:
> > On Thu, Feb 06, 2014 at 03:28:13PM +, David Laight wrote:
> >> From: Igor Gnatenko
> >> > On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote:
> >> > > The AX88772
On Fri, Feb 07, 2014 at 10:38:04AM +0100, Bjørn Mork wrote:
Emil Goode emilgo...@gmail.com writes:
On Thu, Feb 06, 2014 at 03:28:13PM +, David Laight wrote:
From: Igor Gnatenko
On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote:
The AX88772B occasionally send rx packets that cross
On Thu, Feb 06, 2014 at 03:28:13PM +, David Laight wrote:
> From: Igor Gnatenko
> > On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote:
> > > The AX88772B occasionally send rx packets that cross urb boundaries
> > > and the remaining partial packet is sent
Hello David,
Thank's for the review.
On Thu, Feb 06, 2014 at 01:37:12PM +, David Laight wrote:
> From: Emil Goode
> > The AX88772B occasionally send rx packets that cross urb boundaries
> > and the remaining partial packet is sent with no header.
> > When the buffer
packages and error messages
in dmesg.
This can be reproduced by using ping with a packet size
between 1965-1976.
The bug has been reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=29082
Signed-off-by: Emil Goode
---
drivers/net/usb/asix_devices.c |1 +
1 file changed, 1 insertion
packages and error messages
in dmesg.
This can be reproduced by using ping with a packet size
between 1965-1976.
The bug has been reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=29082
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/net/usb/asix_devices.c |1 +
1 file
Hello David,
Thank's for the review.
On Thu, Feb 06, 2014 at 01:37:12PM +, David Laight wrote:
From: Emil Goode
The AX88772B occasionally send rx packets that cross urb boundaries
and the remaining partial packet is sent with no header.
When the buffer with a partial packet is of less
On Thu, Feb 06, 2014 at 03:28:13PM +, David Laight wrote:
From: Igor Gnatenko
On Thu, 2014-02-06 at 13:56 +0100, Emil Goode wrote:
The AX88772B occasionally send rx packets that cross urb boundaries
and the remaining partial packet is sent with no header.
When the buffer
tree parser
Signed-off-by: Emil Goode
---
drivers/acpi/thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 1fd21ad..8349a55 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -861,7 +861,7
thermal: introduce device tree parser
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/acpi/thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 1fd21ad..8349a55 100644
--- a/drivers/acpi/thermal.c
+++ b
This patch adds missing unlocks on error paths in the
xhci_free_streams and xhci_configure_endpoint functions.
Signed-off-by: Emil Goode
---
drivers/usb/host/xhci.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 6779c92..2c49f00
This patch adds missing unlocks on error paths in the
xhci_free_streams and xhci_configure_endpoint functions.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/usb/host/xhci.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
This patch removes a double assignment of .start in struct hc_driver
ehci_msp_hc_driver and also makes the code look more tidy.
Signed-off-by: Emil Goode
---
drivers/usb/host/ehci-pmcmsp.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-pmcmsp.c b
This patch removes a double assignment of .start in struct hc_driver
ehci_msp_hc_driver and also makes the code look more tidy.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/usb/host/ehci-pmcmsp.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb
In struct snd_soc_card zylonite .owner is assigned THIS_MODULE
twice, remove one of them.
Signed-off-by: Emil Goode
---
sound/soc/pxa/zylonite.c |1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
index ceb6566..db8aadf 100644
--- a/sound
In struct snd_soc_card zylonite .owner is assigned THIS_MODULE
twice, remove one of them.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
sound/soc/pxa/zylonite.c |1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
index ceb6566..db8aadf
Thank you Dan! That's right, It's of course not NULL after freed.
Yes the code looks strange here, I'm not sure what was intended.
Best regards,
Emil
On Wed, Jun 12, 2013 at 08:08:17AM -0700, Dan Carpenter wrote:
> 1) This patch doesn't do anything. "dcd_key" points to freed memory
> but it's
We free dcd_key on line 897 and then dereference it a few lines below.
This patch adds a NULL check to make sure we can use dcd_key.
Signed-off-by: Emil Goode
---
drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
We free dcd_key on line 897 and then dereference it a few lines below.
This patch adds a NULL check to make sure we can use dcd_key.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Thank you Dan! That's right, It's of course not NULL after freed.
Yes the code looks strange here, I'm not sure what was intended.
Best regards,
Emil
On Wed, Jun 12, 2013 at 08:08:17AM -0700, Dan Carpenter wrote:
1) This patch doesn't do anything. dcd_key points to freed memory
but it's not
nday, June 10, 2013 9:01 AM, Emil Goode wrote:
> >
> > This patch fixes some issues in the error handling and simplifies
> > the code by converting to devm* functions.
> >
> > If the kzalloc call fails it is unnecessary to use the label no_res
> > and pass a NULL
, 2013 9:01 AM, Emil Goode wrote:
This patch fixes some issues in the error handling and simplifies
the code by converting to devm* functions.
If the kzalloc call fails it is unnecessary to use the label no_res
and pass a NULL pointer to kfree. If the devm_kzalloc call fails on
line 110
remove the NULL check after the platform_get_resource call.
Signed-off-by: Emil Goode
---
This patch is only build tested
v2: Fix change log typo and remove error messages for kzalloc calls
drivers/mtd/nand/orion_nand.c | 49 +
1 file changed, 15 insertions
Hello,
Sorry for not responding earlier, I was away from my computer.
Thanks for the review, I will send a second version that applies
on top of Andy's patch and fix that typo in the change log.
Best regards,
Emil
On Mon, Jun 10, 2013 at 12:15:22AM +0300, Andy Shevchenko wrote:
> On Sun, Jun
remove the NULL check after the platform_get_resource call.
Signed-off-by: Emil Goode
---
The patch is only build tested
drivers/mtd/nand/orion_nand.c | 39 +++
1 file changed, 11 insertions(+), 28 deletions(-)
diff --git a/drivers/mtd/nand/orion_nand.c b
remove the NULL check after the platform_get_resource call.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
The patch is only build tested
drivers/mtd/nand/orion_nand.c | 39 +++
1 file changed, 11 insertions(+), 28 deletions(-)
diff --git a/drivers/mtd/nand
Hello,
Sorry for not responding earlier, I was away from my computer.
Thanks for the review, I will send a second version that applies
on top of Andy's patch and fix that typo in the change log.
Best regards,
Emil
On Mon, Jun 10, 2013 at 12:15:22AM +0300, Andy Shevchenko wrote:
On Sun, Jun 9,
remove the NULL check after the platform_get_resource call.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
This patch is only build tested
v2: Fix change log typo and remove error messages for kzalloc calls
drivers/mtd/nand/orion_nand.c | 49 +
1 file
In function pruss_probe we free gdev and try to use
it on the next line. I have moved the dereference to
above the kfree of gdev.
Signed-off-by: Emil Goode
---
drivers/uio/uio_pruss.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/uio/uio_pruss.c b/drivers/uio
In function pruss_probe we free gdev and try to use
it on the next line. I have moved the dereference to
above the kfree of gdev.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/uio/uio_pruss.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/uio
It's not necessary to free memory allocated with devm_kzalloc
in a remove function and using kfree leads to a double free.
Signed-off-by: Emil Goode
---
drivers/video/omap2/displays/panel-picodlp.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/omap2/displays/panel
Hello David,
I'm sorry, the patch applies to the linux-next tree.
In the future I will be very careful about sending patches that fix
problems related to the merging of different trees.
Best regards,
Emil Goode
On Tue, Jun 04, 2013 at 05:14:56PM -0700, David Miller wrote:
> From: Emil Go
Hello David,
I'm sorry, the patch applies to the linux-next tree.
In the future I will be very careful about sending patches that fix
problems related to the merging of different trees.
Best regards,
Emil Goode
On Tue, Jun 04, 2013 at 05:14:56PM -0700, David Miller wrote:
From: Emil Goode
It's not necessary to free memory allocated with devm_kzalloc
in a remove function and using kfree leads to a double free.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/video/omap2/displays/panel-picodlp.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/omap2
dd IPv6 support to the ping socket.")
Sparse output:
net/ipv6/ping.c: In function ‘pingv6_init’:
net/ipv6/ping.c:87:27: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode
---
include/net/ping.h |2 +-
net/ipv6/ping.c|2 +-
2 files c
socket.)
Sparse output:
net/ipv6/ping.c: In function ‘pingv6_init’:
net/ipv6/ping.c:87:27: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
include/net/ping.h |2 +-
net/ipv6/ping.c|2 +-
2 files
Maybe wait and see if %pa gets more usage and if the discussion comes up again.
Best regards,
Emil
On Sat, Jun 01, 2013 at 04:22:18PM -0700, Joe Perches wrote:
> On Sun, 2013-06-02 at 01:06 +0200, Emil Goode wrote:
> > Maybe there should be another format specifier %da an
Maybe wait and see if %pa gets more usage and if the discussion comes up again.
Best regards,
Emil
On Sat, Jun 01, 2013 at 04:22:18PM -0700, Joe Perches wrote:
On Sun, 2013-06-02 at 01:06 +0200, Emil Goode wrote:
Maybe there should be another format specifier %da and Randy's
clarifying
Hello Joe and Randy,
Maybe there should be another format specifier %da and Randy's
clarifying comment
can be added there to the documentation?
Best regards,
Emil Goode
On Sat, Jun 01, 2013 at 03:16:00PM -0700, Joe Perches wrote:
> On Sat, 2013-06-01 at 14:56 -0700, Randy Dunlap wr
w lines below. I have moved this code up and pass the variable buf to
dev_dbg.
Signed-off-by: Emil Goode
---
v2: Remove 0x from string as it will print as 0x0x
This applies on top of commit 43d5ad743c6f
("usb: musb: host: fix build warning")
I also added braces to the else statement for
I see, will send a second version.
Thank's
Emil
On Sat, Jun 01, 2013 at 11:29:10AM -0700, Joe Perches wrote:
> On Sat, 2013-06-01 at 20:02 +0200, Emil Goode wrote:
> > This patch makes use of the new format specifier %pa that was introduced
> > by the f
w lines below. I have moved this code up and pass the variable buf to
dev_dbg.
Signed-off-by: Emil Goode
---
I also added braces to the else statement for consistency.
(Didn't want to send a separate patch for that)
drivers/usb/musb/musb_host.c | 12 +---
1 file changed, 5 insertions
Hello,
Thank's for your pointers.
I will send a patch that applies on top of Felipe's patch.
Best regards,
Emil Goode
On Sat, Jun 01, 2013 at 04:15:03PM +0300, Andy Shevchenko wrote:
> On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote:
> > On 05/31/13 15:34, Andy Shevche
Hello,
Thank's for your pointers.
I will send a patch that applies on top of Felipe's patch.
Best regards,
Emil Goode
On Sat, Jun 01, 2013 at 04:15:03PM +0300, Andy Shevchenko wrote:
On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap rdun...@infradead.org wrote:
On 05/31/13 15:34, Andy Shevchenko
have moved this code up and pass the variable buf to
dev_dbg.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
I also added braces to the else statement for consistency.
(Didn't want to send a separate patch for that)
drivers/usb/musb/musb_host.c | 12 +---
1 file changed, 5 insertions
I see, will send a second version.
Thank's
Emil
On Sat, Jun 01, 2013 at 11:29:10AM -0700, Joe Perches wrote:
On Sat, 2013-06-01 at 20:02 +0200, Emil Goode wrote:
This patch makes use of the new format specifier %pa that was introduced
by the following commit
have moved this code up and pass the variable buf to
dev_dbg.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2: Remove 0x from string as it will print as 0x0x
This applies on top of commit 43d5ad743c6f
(usb: musb: host: fix build warning)
I also added braces to the else statement for consistency
Hello Joe and Randy,
Maybe there should be another format specifier %da and Randy's
clarifying comment
can be added there to the documentation?
Best regards,
Emil Goode
On Sat, Jun 01, 2013 at 03:16:00PM -0700, Joe Perches wrote:
On Sat, 2013-06-01 at 14:56 -0700, Randy Dunlap wrote:
It's
101 - 200 of 270 matches
Mail list logo
