riable buf to
dev_dbg.
Sparse output:
drivers/usb/musb/musb_host.c:1761:4: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 6 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode
---
v2: Added missing braces according to Doc/CodingStyle
drivers/us
riable buf to
dev_dbg.
Sparse output:
drivers/usb/musb/musb_host.c:1761:4: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 6 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode
---
drivers/usb/musb/musb_host.c | 11 ---
1 file chan
to
dev_dbg.
Sparse output:
drivers/usb/musb/musb_host.c:1761:4: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 6 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/usb/musb/musb_host.c | 11 ---
1 file
to
dev_dbg.
Sparse output:
drivers/usb/musb/musb_host.c:1761:4: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 6 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2: Added missing braces according to Doc/CodingStyle
The ltq_mtd_probe function is missing some error handling for
memory allocation failure. This patch fixes that and simplifies
the code by converting to devm_kzalloc.
Signed-off-by: Emil Goode
---
drivers/mtd/maps/lantiq-flash.c | 31 +++
1 file changed, 15
The ltq_mtd_probe function is missing some error handling for
memory allocation failure. This patch fixes that and simplifies
the code by converting to devm_kzalloc.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/mtd/maps/lantiq-flash.c | 31 +++
1 file
This patch makes the following improvements to the error handling
in the ceph_mdsmap_decode function:
- Add a NULL check for return value from kcalloc
- Make use of the variable err
Signed-off-by: Emil Goode
---
fs/ceph/mdsmap.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
This patch makes the following improvements to the error handling
in the ceph_mdsmap_decode function:
- Add a NULL check for return value from kcalloc
- Make use of the variable err
Signed-off-by: Emil Goode emilgo...@gmail.com
---
fs/ceph/mdsmap.c |4 +++-
1 file changed, 3 insertions
(incompatible argument 2
(different address spaces))
drivers/staging/speakup/devsynth.c:63:18:
expected long ( *write )( ... )
drivers/staging/speakup/devsynth.c:63:18:
got long ( static [toplevel] * )( ... )
Signed-off-by: Emil Goode
---
drivers/staging/speakup
)( ... )
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/staging/speakup/devsynth.c | 10 +-
drivers/staging/speakup/speakup_soft.c |8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/speakup/devsynth.c
b/drivers/staging/speakup/devsynth.c
vers/block/nvme-core.c:483:19: warning:
assignment from incompatible pointer type [enabled by default]
drivers/block/nvme-core.c:484:19: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode
---
This patch applies to the -mm tree.
dri
I see, I will resend and include Andrew Morton.
Thanks,
Emil
On Fri, May 17, 2013 at 10:45:26AM -0400, Matthew Wilcox wrote:
> On Fri, May 17, 2013 at 04:09:40PM +0200, Emil Goode wrote:
> > Commit 6a4d55146334 ("block: prep work for batch completion")
> > adde
vers/block/nvme-core.c:483:19: warning:
assignment from incompatible pointer type [enabled by default]
drivers/block/nvme-core.c:484:19: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode
---
drivers/block/nvme-core.c |3 ++-
1 file
-core.c:483:19: warning:
assignment from incompatible pointer type [enabled by default]
drivers/block/nvme-core.c:484:19: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/block/nvme-core.c |3
I see, I will resend and include Andrew Morton.
Thanks,
Emil
On Fri, May 17, 2013 at 10:45:26AM -0400, Matthew Wilcox wrote:
On Fri, May 17, 2013 at 04:09:40PM +0200, Emil Goode wrote:
Commit 6a4d55146334 (block: prep work for batch completion)
added a struct batch_complete * as a third
-core.c:483:19: warning:
assignment from incompatible pointer type [enabled by default]
drivers/block/nvme-core.c:484:19: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
This patch applies to the -mm tree
for ‘bcache_ops.release’) [enabled by default]
Signed-off-by: Emil Goode
---
drivers/md/bcache/super.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 76c7f6c..938bbff 100644
--- a/drivers/md/bcache/super.c
+++ b
initialization for ‘bcache_ops.release’) [enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/md/bcache/super.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 76c7f6c..938bbff 100644
--- a/drivers/md
cludes drm/drm.h instead.
Best regards,
Emil Goode
On Fri, Apr 26, 2013 at 09:22:08PM +0200, Thierry Reding wrote:
> On Fri, Apr 26, 2013 at 07:49:51PM +0200, Emil Goode wrote:
> > Include definitions of used types by including drm/drm.h
> >
> > Sparse output:
>
/drm.h instead.
Best regards,
Emil Goode
On Fri, Apr 26, 2013 at 09:22:08PM +0200, Thierry Reding wrote:
On Fri, Apr 26, 2013 at 07:49:51PM +0200, Emil Goode wrote:
Include definitions of used types by including drm/drm.h
Sparse output:
/usr/include/drm/tegra_drm.h:21:
found __[us
Include definitions of used types by including drm/drm.h
Sparse output:
/usr/include/drm/tegra_drm.h:21:
found __[us]{8,16,32,64} type without
#include
Signed-off-by: Emil Goode
---
include/uapi/drm/tegra_drm.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/include
Include definitions of used types by including drm/drm.h
Sparse output:
/usr/include/drm/tegra_drm.h:21:
found __[us]{8,16,32,64} type without
#include linux/types.h
Signed-off-by: Emil Goode emilgo...@gmail.com
---
include/uapi/drm/tegra_drm.h |2 ++
1 file changed, 2
/amplc_dio200_pci.c:315:25: warning:
obsolete array initializer, use C99 syntax
Signed-off-by: Emil Goode
---
drivers/staging/comedi/drivers/amplc_dio200_pci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_dio200_pci.c
b
/amplc_dio200_pci.c:315:25: warning:
obsolete array initializer, use C99 syntax
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/staging/comedi/drivers/amplc_dio200_pci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers
The struct rsxx_dma pointer tmp is not used, we can remove it.
Introduced by: c95246c3a2ac
("Adding in EEH support to the IBM FlashSystem 70/80 device driver")
Sparse gives a warning:
drivers/block/rsxx/dma.c:1050:19: warning:
unused variable ‘tmp’ [-Wunused-variable]
Signed-of
: In function ‘__raid56_parity_recover’:
fs/btrfs/raid56.c:2013:18: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode
---
fs/btrfs/raid56.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/raid56.c b/fs/btrfs
: In function ‘__raid56_parity_recover’:
fs/btrfs/raid56.c:2013:18: warning:
assignment from incompatible pointer type [enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
fs/btrfs/raid56.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs
The struct rsxx_dma pointer tmp is not used, we can remove it.
Introduced by: c95246c3a2ac
(Adding in EEH support to the IBM FlashSystem 70/80 device driver)
Sparse gives a warning:
drivers/block/rsxx/dma.c:1050:19: warning:
unused variable ‘tmp’ [-Wunused-variable]
Signed-off-by: Emil
variable ‘node_tmp’ [-Wunused-variable]
Signed-off-by: Emil Goode
---
This patch applies to the linux-next tree.
v2: Added complete hash and message of dependant commit.
net/batman-adv/originator.c |1 -
1 file changed, 1 deletion(-)
diff --git a/net/batman-adv/originator.c b/net/batman
06, 2013 at 06:55:53 +0100, Emil Goode wrote:
> > Hi Antonio,
> >
> > The commit ed242d01 is in the linux-next tree and my patch depends on
> > that commit.
> >
>
> Yes, you are right. I was not aware of this commit, because the author
> did not CC us (neither
/lpc_ich.c:881:36:got unsigned long
Signed-off-by: Emil Goode
---
drivers/mfd/lpc_ich.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index a0cfdf9..3af8590 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
Hi Antonio,
The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.
Best regards, Emil
On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
> Hi Emil,
>
> On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
> > The commit ed242d01
The commit ed242d01 removed a node parameter from iterators.
This patch removes a hlist_node struct that is no longer used.
Sparse gives a warning:
net/batman-adv/originator.c:411:21: warning:
unused variable ‘node_tmp’ [-Wunused-variable]
Signed-off-by: Emil Goode
---
net/batman-adv
The commit ed242d01 removed a node parameter from iterators.
This patch removes a hlist_node struct that is no longer used.
Sparse gives a warning:
net/batman-adv/originator.c:411:21: warning:
unused variable ‘node_tmp’ [-Wunused-variable]
Signed-off-by: Emil Goode emilgo...@gmail.com
Hi Antonio,
The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.
Best regards, Emil
On Wed, 2013-02-06 at 18:22 +0100, Antonio Quartulli wrote:
Hi Emil,
On Wed, Feb 06, 2013 at 05:37:41 +0100, Emil Goode wrote:
The commit ed242d01 removed a node parameter
/lpc_ich.c:881:36:got unsigned long
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/mfd/lpc_ich.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index a0cfdf9..3af8590 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers
:55:53 +0100, Emil Goode wrote:
Hi Antonio,
The commit ed242d01 is in the linux-next tree and my patch depends on
that commit.
Yes, you are right. I was not aware of this commit, because the author
did not CC us (neither netdev) even if he changed the code we maintain.
As far as I
variable ‘node_tmp’ [-Wunused-variable]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
This patch applies to the linux-next tree.
v2: Added complete hash and message of dependant commit.
net/batman-adv/originator.c |1 -
1 file changed, 1 deletion(-)
diff --git a/net/batman-adv
The first patch in this series changes the return type of function
kvm_para_available to bool. In the function snd_intel8x0_inside_vm
we now need to check it's return value before assigning a value to
the result variable.
Signed-off-by: Emil Goode
---
sound/pci/intel8x0.c |2 +-
1 file
The first patch in this series changed the kvm_para_available
function to return bool. We can now simplify the kvm_detect function
by directly returning the return value of kvm_para_available.
Signed-off-by: Emil Goode
---
arch/x86/kernel/kvm.c |4 +---
1 file changed, 1 insertion(+), 3
by default]
arch/x86/kernel/kvm.c:508:2: warning:
(near initialization for ‘x86_hyper_kvm.x2apic_available’)
[enabled by default]
Signed-off-by: Emil Goode
---
arch/x86/include/asm/kvm_para.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86
[enabled by default]
arch/x86/kernel/kvm.c:508:2: warning:
(near initialization for ‘x86_hyper_kvm.x2apic_available’)
[enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/x86/include/asm/kvm_para.h |8
1 file changed, 4 insertions(+), 4 deletions
The first patch in this series changed the kvm_para_available
function to return bool. We can now simplify the kvm_detect function
by directly returning the return value of kvm_para_available.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/x86/kernel/kvm.c |4 +---
1 file changed, 1
The first patch in this series changes the return type of function
kvm_para_available to bool. In the function snd_intel8x0_inside_vm
we now need to check it's return value before assigning a value to
the result variable.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
sound/pci/intel8x0.c
warning:
drivers/media/pci/ngene/ngene-cards.c:333:12: warning:
‘tuner_attach_dtt7520x’ defined but not used [-Wunused-function]
Signed-off-by: Emil Goode
---
This patch is a guess at what was intended. I'm not familiar with this code
and I don't have the hardware to test it.
drivers
warning:
drivers/media/pci/ngene/ngene-cards.c:333:12: warning:
‘tuner_attach_dtt7520x’ defined but not used [-Wunused-function]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
This patch is a guess at what was intended. I'm not familiar with this code
and I don't have the hardware
/wlan-ng/cfg80211.c:736:2: warning:
initialization from incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:736:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.get_tx_power’)
[enabled by default]
Signed-off-by: Emil Goode
---
drivers
]
drivers/staging/wlan-ng/cfg80211.c:736:2: warning:
initialization from incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:736:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.get_tx_power’)
[enabled by default]
Signed-off-by: Emil Goode
argument of type ‘unsigned int’,
but argument 5 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode
---
drivers/remoteproc/remoteproc_core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers/remoteproc
argument of type ‘unsigned int’,
but argument 5 has type ‘dma_addr_t’ [-Wformat]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/remoteproc/remoteproc_core.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b
Smatch is warning about a dereference before we check for NULL.
This patch moves the dereference to after the NULL check.
Smatch warning:
drivers/staging/wlan-ng/cfg80211.c:345 prism2_scan() warn:
variable dereferenced before check 'request' (see line 332)
Signed-off-by: Emil Goode
Smatch is warning about a dereference before we check for NULL.
This patch moves the dereference to after the NULL check.
Smatch warning:
drivers/staging/wlan-ng/cfg80211.c:345 prism2_scan() warn:
variable dereferenced before check 'request' (see line 332)
Signed-off-by: Emil Goode
-declarations]
Signed-off-by: Emil Goode
---
drivers/hid/hid-picolcd_fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index 0008a51..eb00357 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b/drivers/hid/hid
-declarations]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/hid/hid-picolcd_fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index 0008a51..eb00357 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b
This patch solves problems with the error handling by
introducing labels for proper error paths and it also
frees resources that where missed.
Signed-off-by: Emil Goode
---
drivers/video/hpfb.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git
This patch solves problems with the error handling by
introducing labels for proper error paths and it also
frees resources that where missed.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/video/hpfb.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions
we want to get the return value from it.
- Change the lable names to improve readability.
Signed-off-by: Emil Goode
---
drivers/infiniband/hw/cxgb4/qp.c | 62 +++---
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4
we want to get the return value from it.
- Change the lable names to improve readability.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/infiniband/hw/cxgb4/qp.c | 62 +++---
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/drivers
There is no reason to explicitly call devm_kfree
in probe or remove functions.
Signed-off-by: Emil Goode
---
drivers/tty/serial/max310x.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
index 06ff5ad..2bc28a5 100644
:
ignoring return value of ‘gpiochip_remove’,
declared with attribute warn_unused_result
[-Wunused-result]
Signed-off-by: Emil Goode
---
drivers/tty/serial/max310x.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers
:
ignoring return value of ‘gpiochip_remove’,
declared with attribute warn_unused_result
[-Wunused-result]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/tty/serial/max310x.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial
There is no reason to explicitly call devm_kfree
in probe or remove functions.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/tty/serial/max310x.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
index 06ff5ad
n from incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.scan’)
[enabled by default]
Signed-off-by: Emil Goode
---
This patch depends on the commit fd014284 which is now
in the staging tree so
incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.scan’)
[enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
This patch depends on the commit fd014284 which is now
’ qualifier
from pointer target type [enabled by default]
Signed-off-by: Emil Goode
---
drivers/media/video/coda.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c
index 0d6e0a0..6908514 100644
--- a/drivers
’ qualifier
from pointer target type [enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/media/video/coda.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/coda.c b/drivers/media/video/coda.c
index 0d6e0a0..6908514 100644
n from incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.scan’)
[enabled by default]
Signed-off-by: Emil Goode
---
Hello Johannes,
Your commit fd014284 introduced the sparse warnings that
this
incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.scan’)
[enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
Hello Johannes,
Your commit fd014284 introduced the sparse
n from incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.scan’)
[enabled by default]
Signed-off-by: Emil Goode
---
drivers/staging/wlan-ng/cfg80211.c |4 ++--
1 file changed, 2 insertions
incompatible pointer type [enabled by default]
drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
(near initialization for ‘prism2_usb_cfg_ops.scan’)
[enabled by default]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/staging/wlan-ng/cfg80211.c |4 ++--
1 file changed
201 - 270 of 270 matches
Mail list logo
