Re: systemd-rfkill regression on 5.11 and later kernels

2021-03-18 Thread Emmanuel Grumbach
Hi, On Thu, Mar 18, 2021 at 10:31 AM Takashi Iwai wrote: > > Hi, > > we've received a bug report about rfkill change that was introduced in > 5.11. While the systemd-rfkill expects the same size of both read and > write, the kernel rfkill write cuts off to the old 8 bytes while read > gives 9 by

Re: [BUG] iwlwifi: card unusable after firmware crash

2020-12-10 Thread Emmanuel Grumbach
Hi, > Hi, again, > > I haven't tested any patch or bisected, but I have another data point. > I built and tested Linux 5.8.18, with the same firmware, and it is > working correctly. I reduced the test case to just rfkilling the > connection, which showed the register dump immediately (before that

Re: [BUG] iwlwifi: card unusable after firmware crash

2020-12-09 Thread Emmanuel Grumbach
On Wed, Dec 9, 2020 at 10:47 PM Emmanuel Grumbach wrote: > > On Wed, Dec 9, 2020 at 10:40 PM Rui Salvaterra wrote: > > > > Hi, Emmanuel, > > > > On Wed, 9 Dec 2020 at 20:32, Emmanuel Grumbach wrote: > > > > > > Rui, I looked at the register du

Re: [BUG] iwlwifi: card unusable after firmware crash

2020-12-09 Thread Emmanuel Grumbach
On Wed, Dec 9, 2020 at 10:40 PM Rui Salvaterra wrote: > > Hi, Emmanuel, > > On Wed, 9 Dec 2020 at 20:32, Emmanuel Grumbach wrote: > > > > Rui, I looked at the register dump and looks like you're using AMT on > > your system? > > Can you confirm? > >

Re: [BUG] iwlwifi: card unusable after firmware crash

2020-12-09 Thread Emmanuel Grumbach
On Wed, Dec 9, 2020 at 10:32 PM Emmanuel Grumbach wrote: > > On Wed, Dec 9, 2020 at 7:19 PM Jakub Kicinski wrote: > > > > On Tue, 8 Dec 2020 23:17:48 + Rui Salvaterra wrote: > > > Hi, Luca, > > > > > > On Tue, 8 Dec 2020 at 16:27, Coelho, Luciano

Re: [BUG] iwlwifi: card unusable after firmware crash

2020-12-09 Thread Emmanuel Grumbach
On Wed, Dec 9, 2020 at 7:19 PM Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 23:17:48 + Rui Salvaterra wrote: > > Hi, Luca, > > > > On Tue, 8 Dec 2020 at 16:27, Coelho, Luciano > > wrote: > > > On Tue, 2020-12-08 at 11:27 +, Rui Salvaterra wrote: > > > > > > > > [ 3174.003910] iwlwifi 000

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-21 Thread Emmanuel Grumbach
> > On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach > wrote: > > So I believe we already have this uevent, it is the devcoredump. All > > we need is to add the unique id. > > I think there are a few reasons that devcoredump doesn't satisfy what > eith

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-19 Thread Emmanuel Grumbach
Hi all, Since I have been involved quite a bit in the firmware debugging features in iwlwifi, I think I can give a few insights here. But before this, we need to understand that there are several sources of issues: 1) the firmware may crash but the bus is still alive, you can still use the bus

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2019-01-09 Thread Emmanuel Grumbach
Hello, > > > > > > > > our hardware teams from the Bluetooth and WiFi side really need to look > > > > at this. > > > > Were you able to get attention from the hardware teams with the logs > > I've provided? Are there any news or an idea of when / if we can > > expect this to be fixed in firmware

Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important

2017-06-11 Thread Emmanuel Grumbach
On Mon, Jun 12, 2017 at 12:30 AM, Emil Lenngren wrote: > 2017-06-11 22:48 GMT+02:00 Emmanuel Grumbach : >> On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote: >>> >>> On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote: >>> > "Jason A. Donenfeld" w

Re: [PATCH 0/6] Constant Time Memory Comparisons Are Important

2017-06-11 Thread Emmanuel Grumbach
On Sun, Jun 11, 2017 at 4:36 PM, Kees Cook wrote: > > On Sun, Jun 11, 2017 at 1:13 AM, Kalle Valo wrote: > > "Jason A. Donenfeld" writes: > > > >> Whenever you're comparing two MACs, it's important to do this using > >> crypto_memneq instead of memcmp. With memcmp, you leak timing information, >

Re: Intel Wireless 7260 failed to work

2016-12-28 Thread Emmanuel Grumbach
On Wed, Dec 28, 2016 at 10:10 AM, Peter Xu wrote: > On Wed, Dec 28, 2016 at 09:27:15AM +0200, Luca Coelho wrote: > > [...] > >> > > > Is this a known issue? Please let me know if anyone wants more info or >> > > > logs, since this error triggers easily (everytime I boot). >> > > >> > > The error m

Re: [PATCH RESEND] iwlwifi, Do not implement thermal zone unless ucode is loaded

2016-07-11 Thread Emmanuel Grumbach
are check to iwl_mvm_thermal_zone_register() and > stops the thermal zone from being created if the ucode hasn't been loaded. > > Signed-off-by: Prarit Bhargava > Cc: Johannes Berg > Cc: Emmanuel Grumbach > Cc: Luca Coelho > Cc: Intel Linux Wireless > Cc: Kalle Va

Re: [GIT] Networking

2016-05-17 Thread Emmanuel Grumbach
On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds wrote: > On Tue, May 17, 2016 at 12:11 PM, David Miller wrote: >> >> Highlights: > > Lowlights: > > 1) the iwlwifi driver seems to be broken > > My laptop that uses the intel 7680 iwlwifi module no longer connects > to the network. It fails with a

Re: [PATCH] wlcore: spi: add wl18xx support

2016-03-30 Thread Emmanuel Grumbach
On Wed, Mar 30, 2016 at 3:58 PM, Eyal Reizer wrote: > > From: Eyal Are you trying to hide or something? :) > > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init c

Re: iwlwifi A-MSDU tx

2015-12-04 Thread Emmanuel Grumbach
On Fri, Dec 4, 2015 at 9:35 AM, Emmanuel Grumbach wrote: > Hi, > > On Fri, Dec 4, 2015 at 12:05 AM, Stefan Sperling wrote: >> Hi Emmanuel, >> >> As part of implementing 802.11n support in OpenBSD I'm looking for >> an AP which sends A-MSDUs. Preferrably

Re: iwlwifi A-MSDU tx

2015-12-03 Thread Emmanuel Grumbach
Hi, On Fri, Dec 4, 2015 at 12:05 AM, Stefan Sperling wrote: > Hi Emmanuel, > > As part of implementing 802.11n support in OpenBSD I'm looking for > an AP which sends A-MSDUs. Preferrably under software control rather > than firmware. > > I found your iwlwifi A-MSDU patches at > http://marc.info/?

Re: [PATCH v2 10/27] iwlwifi: move under intel vendor directory

2015-11-18 Thread Emmanuel Grumbach
Hi Kalle, On Wed, Nov 18, 2015 at 4:45 PM, Kalle Valo wrote: > > Part of reorganising wireless drivers directory and Kconfig. > I am sorry but I'd prefer to wait with this. We have a big machinery of scripts / builds and alike that will break. I did give a heads up a while ago to the people in c

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-08-24 Thread Emmanuel Grumbach
> > > > I'll try to come up with a patch that is easier for me to read, but I > > am really busy right now. Ping me in a week if you have heard from me > > earlier. > > So how it is going with this patch? > > In hindsight, I would use a different name for the macro parameter here: > > #define IWL_R

Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-07-29 Thread Emmanuel Grumbach
On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui wrote: > Enable wiphy device to suspend/resume asynchronously. This can improve > system suspend/resume speed. > How will that impact the timing with respect to the suspend call coming from the bus? I think that a few drivers rely on the suspend call

Re: iwlwifi: Microcode SW error detected. Restarting 0x2000000.

2015-07-18 Thread Emmanuel Grumbach
Emmanuel Grumbach egrumb...@gmail.com On Fri, Jul 17, 2015 at 5:06 PM, Toralf Förster wrote: > On 07/14/2015 08:43 AM, Emmanuel Grumbach wrote: >> You are not using the latest firmware. Please upgrade to 25.17.12.0. > > At least with this firmware the issue is self-healing afte

Re: iwlwifi: Microcode SW error detected. Restarting 0x2000000.

2015-07-15 Thread Emmanuel Grumbach
On Wed, Jul 15, 2015 at 10:20 PM, Toralf Förster wrote: > On 07/15/2015 07:48 PM, Emmanuel Grumbach wrote: >> Can you reproduce easily? >> > Unfortunately not, it happens sometimes gtwice a day, and then I do have 5 or > more daays in a row w/o any problems. > >>

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-15 Thread Emmanuel Grumbach
On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko wrote: > On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov > wrote: >>> +#define IWL_READ_WRITE(static_inline) \ >>> +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ >>> +{ \ >>> + trace_iwlwifi_dev_iowrite8(trans->dev

Re: iwlwifi: Microcode SW error detected. Restarting 0x2000000.

2015-07-15 Thread Emmanuel Grumbach
>> >> On Tue, Jul 14, 2015 at 12:53 AM, Toralf Förster >> wrote: >>> At a Gentoo (hardened) I experienced - starting with hardened kernel >>> 4.0.6-r1 - the (attached) hickup of the "03:00.0 Network controller: Intel >>> Corporation Wireless 7260 (rev 83)" at a ThinkPad T440s. The network stuck

Re: iwlwifi: Microcode SW error detected. Restarting 0x2000000.

2015-07-13 Thread Emmanuel Grumbach
Hi, On Tue, Jul 14, 2015 at 12:53 AM, Toralf Förster wrote: > At a Gentoo (hardened) I experienced - starting with hardened kernel 4.0.6-r1 > - the (attached) hickup of the "03:00.0 Network controller: Intel Corporation > Wireless 7260 (rev 83)" at a ThinkPad T440s. The network stucks till I do

Re: [PATCH] mac80211: Use kstrdup to simplify code

2015-07-08 Thread Emmanuel Grumbach
The subject is wrong. You are not patch mac80211, but bcrmsmac. On Wed, Jul 8, 2015 at 10:32 PM, Christophe JAILLET wrote: > Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve > readability. > > Signed-off-by: Christophe JAILLET > --- > drivers/net/wireless/brcm80211/brcmsmac

Re: [PATCH] iwlwifi: Move each system tracepoints to their own header

2015-04-13 Thread Emmanuel Grumbach
it's me again. On Mon, Apr 13, 2015 at 9:22 AM, Emmanuel Grumbach wrote: > On Sun, Apr 12, 2015 at 8:37 PM, Emmanuel Grumbach > wrote: >> On Wed, Apr 8, 2015 at 10:44 AM, Johannes Berg >> wrote: >>> On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote: >&

Re: [PATCH] iwlwifi: Move each system tracepoints to their own header

2015-04-12 Thread Emmanuel Grumbach
On Sun, Apr 12, 2015 at 8:37 PM, Emmanuel Grumbach wrote: > On Wed, Apr 8, 2015 at 10:44 AM, Johannes Berg > wrote: >> On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote: >>> Every tracing file must have its own TRACE_SYSTEM defined. >>> The iwlwifi tracepoint

Re: [PATCH] iwlwifi: Move each system tracepoints to their own header

2015-04-12 Thread Emmanuel Grumbach
On Wed, Apr 8, 2015 at 10:44 AM, Johannes Berg wrote: > On Tue, 2015-04-07 at 12:13 -0400, Steven Rostedt wrote: >> Every tracing file must have its own TRACE_SYSTEM defined. >> The iwlwifi tracepoint header broke this and added in the middle >> of the file: > [...] >> Unfortunately, this broke ne

Re: linux-next: Tree for Mar 5 (iwlwifi/mvm)

2015-03-06 Thread Emmanuel Grumbach
On Fri, Mar 6, 2015 at 1:41 AM, Randy Dunlap wrote: > On 03/04/15 19:34, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20150304: >> > > on i386, when IWLWIFI_DEBUGFS is not enabled: > > > ../drivers/net/wireless/iwlwifi/mvm/phy-ctxt.c:179:38: error: 'struct > iwl_mvm' has no member named

Re: [PATCH] iwlwifi: mvm: check time event is over before disconnecting

2015-02-28 Thread Emmanuel Grumbach
On Sat, Feb 28, 2015 at 1:10 AM, Filip Ayazi wrote: > On the 7260 time event was often ended before end_time and connections failed > with "No association and the time event is over already...". > This checks that the time event is actually over before disconnecting. > > Signed-off-by: Filip Ayazi

Re: iwlwifi-driver card doesn't work with 3.19-rc2+

2014-12-30 Thread Emmanuel Grumbach
On Tue, Dec 30, 2014 at 3:33 PM, Jiri Kosina wrote: > > Hi, > > I just booted current Linus' tree (5faa0154fe33) on my x200s thinkpad, and > wifi doesn't work. iwconfig is telling me that wlan0 interface has no > wireless extensions. > So why do you used them? They have been deprecated for a coup

Re: [patch] iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()

2014-10-29 Thread Emmanuel Grumbach
On Wed, Oct 29, 2014 at 6:08 PM, Dan Carpenter wrote: > The shift operation is higher precedence so the code is wrong and it > sets of a static checker warning. But it doesn't affect real life > because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op. > > I have re-written it in nor

pull request: iwlwifi 2014-03-19

2014-03-18 Thread Emmanuel Grumbach
ub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git for-john for you to fetch changes up to 192c80a2499cf2571924081c646262036d841484: iwlwifi: mvm: add missing include (2014-03-19 08:25:05 +0200) ---- Emmanuel Grumbach (1): iwlwifi: m

Re: [PATCH 4/11] use ether_addr_equal_64bits

2013-12-30 Thread Emmanuel Grumbach
On Tue, Dec 31, 2013 at 1:13 AM, Johannes Berg wrote: > > On Mon, 2013-12-30 at 19:57 -0200, Henrique de Moraes Holschuh wrote: > > On Mon, 30 Dec 2013, Johannes Berg wrote: > > > On Mon, 2013-12-30 at 20:58 +0100, Julia Lawall wrote: > > > > > Is there any way we could catch (sparse, or some othe

Re: [PATCHv2.1] net: wireless: iwlwifi: remove minor dead code

2013-11-11 Thread Emmanuel Grumbach
On 11/12/2013 02:01 AM, Michal Nazarewicz wrote: > inta is checked to be zero in a IRQ_NONE branch so afterwards it > cannot be zero as it is never modified. > > Signed-off-by: Michal Nazarewicz > --- > drivers/net/wireless/iwlwifi/pcie/rx.c | 24 +--- > 1 file changed, 9 i

Re: [v3.9.x stable regression, bisected] iwlwifi/iwldvm has a 30s delay in EAP authentication

2013-05-22 Thread Emmanuel Grumbach
>> >> Thanks for the bisection. Can you please try the patch in >> https://bugzilla.kernel.org/show_bug.cgi?id=58341 and report? >> Thanks >> > > I can confirm that the patch in this bugzilla entry does indeed get > rid of the delay in EAP authentication. > Thanks for the testing - patch on the wa

Re: [v3.9.x stable regression, bisected] iwlwifi/iwldvm has a 30s delay in EAP authentication

2013-05-22 Thread Emmanuel Grumbach
t c30f37f8f1f8d06c142d67ba74955fd48b5cf5a4 > Author: Emmanuel Grumbach > Date: Wed Apr 17 09:47:00 2013 +0300 > > iwlwifi: dvm: don't send zeroed LQ cmd > > commit 63b77bf489881747c5118476918cc8c29378ee63 upstream. > > When the stations are being restored

Re: is L1 really disabled in iwlwifi

2013-05-16 Thread Emmanuel Grumbach
> > I couldn't imagine that silently ignoring the request to disable ASPM > would be the right thing, but I spent a long time experimenting with > Windows on qemu, and I think you're right. Windows 7 also seems to > ignore the "PciASPMOptOut" directive when we don't have permission > to manage ASP

Re: Bisected 3.9 regression for iwl4965 connection problem to 1672c0e3

2013-05-07 Thread Emmanuel Grumbach
>> > > But if so, I would also see >> > > the breakage on my setup, but I don't - it works quite well here. >> > >> > Are you testing on a passive channel? Try with a large beacon interval. >> >> I think most likely what happens is that it's on a passive channel, and >> the firmware drops the TX pa