Re: [Ksummit-discuss] RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

Konstantin Ryabitsev wrote: > On Tue, Mar 23, 2021 at 09:30:33AM -0700, James Bottomley wrote: > > > I think the bulk of user issues are going to be regressions. Although > > > you may be in a better position to know for sure, but at least for > > > me, wearing my "user" hat, the thing that gets

Re: RFC: create mailing list "linux-issues" focussed on issues/bugs and regressions

James Bottomley wrote: > On Mon, 2021-03-22 at 13:16 -0400, Konstantin Ryabitsev wrote: > > On Mon, Mar 22, 2021 at 04:18:14PM +0100, Thorsten Leemhuis wrote: > > > Note, there is a second reason why ksummit-discuss is CCed: another > > > reason why I want to create this new list is making it

Re: Why the edge-triggered mode doesn't work for epoll file descriptor?

Heiher wrote: > Hello, > > I've added a pipe file descriptor (fd1) to an epoll (fd3) with > EPOLLOUT in edge-triggered mode, and then added the fd3 to another > epoll (fd4) with EPOLLIN in edge-triggered too. > > Next, waiting for fd4 without timeout. When fd1 to be writable, i > think

Re: [PATCH v4 00/14] epoll: support pollable epoll from userspace

Andrew Morton wrote: > On Tue, 11 Jun 2019 16:54:44 +0200 Roman Penyaev wrote: > > In order to measure polling from userspace libevent was modified [1] and > > bench_http benchmark (client and server) was used: > > > > o EPOLLET, original epoll: > > > > 2 requests in 0.551306 sec.

Re: [PATCH v5 13/14] epoll: implement epoll_create2() syscall

Roman Penyaev wrote: > epoll_create2() is needed to accept EPOLL_USERPOLL flags > and size, i.e. this patch wires up polling from userspace. Instead of adding a new syscall, is setting size (and/or even the EPOLL_USEREPOLL flag) something that could be done via ioctl? There's no race like

Re: [PATCH v5 00/14] epoll: support pollable epoll from userspace

Roman Penyaev wrote: > Hi all, +cc Jason Baron > ** Limitations > 4. No support for EPOLLEXCLUSIVE > If device does not pass pollflags to wake_up() there is no way to > call poll() from the context under spinlock, thus special work is > scheduled to offload polling. In this

Re: [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask()

Linus Torvalds wrote: > On Tue, Jun 4, 2019 at 6:41 AM Oleg Nesterov wrote: > > > > This is the minimal fix for stable, I'll send cleanups later. > > Ugh. I htink this is correct, but I wish we had a better and more > intuitive interface. I had the same thoughts, but am not a regular kernel

Re: [PATCH] signal: remove the wrong signal_pending() check in restore_user_sigmask()

by set_user_sigmask() can > be delivered even if the caller returns success or timeout. > > Change restore_user_sigmask() to accept the additional "interrupted" > argument which should be used instead of signal_pending() check, and > update

Re: pselect/etc semantics

"Eric W. Biederman" wrote: > Frankly the only reason this appears to be worth touching is that we > have a userspace regression. Otherwise I would call the current > behavior more correct and desirable than ignoring the signal longer. > > If I am reading sitaution properly I suggest we go back

Re: pselect/etc semantics (Was: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask())

David Laight wrote: > From: Oleg Nesterov > > Sent: 29 May 2019 17:12 > > Al, Linus, Eric, please help. > > > > The previous discussion was very confusing, we simply can not understand > > each > > other. > > > > To me everything looks very simple and clear, but perhaps I missed something > >

Re: [PATCH 1/1] signal: Adjust error codes according to restore_user_sigmask()

Andrew Morton wrote: > On Tue, 21 May 2019 09:25:51 +0000 Eric Wong wrote: > > > Deepa Dinamani wrote: > > > For all the syscalls that receive a sigmask from the userland, > > > the user sigmask is to be in effect through the syscall execution. > &

Re: [PATCH 1/1] signal: Adjust error codes according to restore_user_sigmask()

a signal and an error > like EINVAL, the syscalls return -EINVAL rather than the interrupted > error codes. > > The sys_io_uring_enter() seems to be returning success when there is > a signal and the queue is not empty. This seems to be a bug. I will > fol

Re: [PATCH v3 05/13] epoll: offload polling to a work in case of epfd polled from userspace

Roman Penyaev wrote: > diff --git a/fs/eventpoll.c b/fs/eventpoll.c > index 81da4571f1e0..9d3905c0afbf 100644 > --- a/fs/eventpoll.c > +++ b/fs/eventpoll.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -185,6 +186,9 @@ struct epitem { > >

Re: [PATCH] signal: Adjust error codes according to restore_user_sigmask()

Deepa Dinamani wrote: > Sorry, I was trying a new setup at work. I should have tested it. > My bad, I've checked this one. Thanks. This is good w.r.t. epoll_pwait and ppoll when applied to 5.0.11 (no fs/io_uring.c). Can't think of anything which uses pselect or aio on my system; but it looks

Re: Strange issues with epoll since 5.0

Deepa Dinamani wrote: > Eric, > Can you please help test this? Nope, that was _really_ badly whitespace-damaged. (C'mon, it's not like you're new to this)

Re: Strange issues with epoll since 5.0

Deepa Dinamani wrote: > So here is my analysis: > So the 854a6ed56839a40f6 seems to be better than the original code in > that it detects the signal. OTOH, does matter to anybody that a signal is detected slightly sooner than it would've been, otherwise? > But, the problem is that it doesn't

Re: Strange issues with epoll since 5.0

Eric Wong wrote: > (didn't test AIO, but everything else seems good) "seems" != "is" Now that I understand the fix for epoll, the fs/select.c changes would hit the same problem and not return -EINTR when it should. I'll let you guys decide how to fix this, but there's de

Re: Strange issues with epoll since 5.0

Eric Wong wrote: > Deepa Dinamani wrote: > > I'm not sure what the hang in the userspace is about. Is it because > > the syscall did not return an error or the particular signal was > > blocked etc. > > Uh, ok; that's less comforting. Nevermind, I think I

Re: Strange issues with epoll since 5.0

Deepa Dinamani wrote: > I was also not able to reproduce this. > Arnd and I were talking about this today morning. Here is something > Arnd noticed: > > If there was a signal after do_epoll_wait(), we never were not > entering the if (err = -EINTR) at all before. I'm not sure which `if'

Re: Strange issues with epoll since 5.0

Davidlohr Bueso wrote: > On Sun, 28 Apr 2019, Eric Wong wrote: > > > Just running one test won't trigger since it needs a busy > > machine; but: > > > > make test/mgmt_auto_adjust.log > > (and "rm make test/mgmt_auto_adjust.log" if you want

Re: Strange issues with epoll since 5.0

Deepa Dinamani wrote: > I tried to replicate the failure on qemu. > I do not see the failure with N=32. > Does it work for N < 32? Depends on number of cores you have; I have 4 cores, 8 threads with HT; so I needed to have a lot of load on the machine to get it to fail (it takes about 1

Re: Strange issues with epoll since 5.0

Eric Wong wrote: > Omar Kilani wrote: > > Hi there, > > > > I’m still trying to piece together a reproducible test that triggers > > this, but I wanted to post in case someone goes “hmmm... change X > > might have done this”. > > Maybe Davidlohr

Re: Strange issues with epoll since 5.0

Omar Kilani wrote: > Hi there, > > I’m still trying to piece together a reproducible test that triggers > this, but I wanted to post in case someone goes “hmmm... change X > might have done this”. Maybe Davidlohr knows, since he's responsible for most of the epoll changes in 5.0. > Basically,

Re: [RFC] LKML Archive in Maildir Format

Bjorn Helgaas wrote: > On Tue, Mar 5, 2019 at 5:26 PM Eric Wong wrote: > > Bjorn Helgaas wrote: > > > > Any pointers? I guess there's no mutt backend that can read a > > > public-inbox archive directly? > > > > There's mutt patches to su

Re: [RFC] LKML Archive in Maildir Format

Bjorn Helgaas wrote: > OK, so I understand how to clone archives from lore.kernel.org and how > to convert a git archive to a maildir (thanks, Konstantin!) > > What I *don't* understand is how to effectively read this locally. > Ideally I'd like to run mutt, possibly with notmuch for indexing.

Re: [PATCH][RESEND] wistron_btns needs executable BIOS image

Jakub Bogusz wrote: > Let's try once again... (take 3) > > First time I sent this patch when I prepared it in 2013 for Linux 3.12, > the second time after update for Linux 4.12 in 2017... > And it still applies to Linux 4.20. Adding Dmitry Torokhov and linux-input to Cc: (that's what

[PATCH] iommu/intel: quirk to disable DMAR for QM57 igfx

Joonas Lahtinen wrote: > Quoting Eric Wong (2019-01-04 03:06:26) > > Yeah, so the Debian bpo 4.17(.17) kernel did not set > > CONFIG_INTEL_IOMMU_DEFAULT_ON, so I didn't encounter problems. > > My self-built kernels all set CONFIG_INTEL_IOMMU_DEFAULT_ON. > > So it'

Re: [PATCH] rtc: cmos: ignore bogus century byte

Alexandre Belloni wrote: > Does this mean that it is set to an invalid value and that in is not > getting updated properly in mc146818_set_time? It seems to be set/updated without trouble while the machine is on. It's only on a cold boot (from poweroff or hibernate) that the value is invalid.

[PATCH] rtc: cmos: ignore bogus century byte

xes: 3c217e51d8a272b9 ("rtc: cmos: century support") Cc: Alexandre Belloni Cc: Alessandro Zummo Cc: Sylvain Chouleur Cc: Patrick McDermott Cc: linux-...@vger.kernel.org Signed-off-by: Eric Wong --- drivers/rtc/rtc-mc146818-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [RFC] LKML Archive in Maildir Format

Joey Pabalinas wrote: > My only comment on the public-mailbox choice is that the documentation > is very sparse and erratic. Myself and a couple other people just > couldn't figure out how to convert that format to Maildir or some other > format you could feed into a reader like neomutt. Sorry,

Re: iommu_intel or i915 regression in 4.18, 4.19.12 and drm-tip

Joonas Lahtinen wrote: > Quoting Eric Wong (2018-12-27 13:49:48) > > I just got a used Thinkpad X201 (Core i5 M 520, Intel QM57 > > chipset) and hit some kernel panics while trying to view > > image/animation-intensive stuff in Firefox (X11) unless I use >

iommu_intel or i915 regression in 4.18, 4.19.12 and drm-tip

I just got a used Thinkpad X201 (Core i5 M 520, Intel QM57 chipset) and hit some kernel panics while trying to view image/animation-intensive stuff in Firefox (X11) unless I use "iommu_intel=igfx_off". With Debian stable backport kernels, "linux-image-4.17.0-0.bpo.3-amd64" (4.17.17-1~bpo9+1) has

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

Roman Penyaev wrote: > On 2018-12-06 00:46, Eric Wong wrote: > > Roman Penyaev wrote: > > > Hi all, > > > > > > The goal of this patch is to reduce contention of ep_poll_callback() > > > which > > > can be called concurrently from differen

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

Roman Penyaev wrote: > On 2018-12-06 00:46, Eric Wong wrote: > > Roman Penyaev wrote: > > > Hi all, > > > > > > The goal of this patch is to reduce contention of ep_poll_callback() > > > which > > > can be called concurrently from differen

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

Roman Penyaev wrote: > Hi all, > > The goal of this patch is to reduce contention of ep_poll_callback() which > can be called concurrently from different CPUs in case of high events > rates and many fds per epoll. Problem can be very well reproduced by > generating events (write to pipe or

Re: [RFC PATCH 1/1] epoll: use rwlock in order to reduce ep_poll_callback() contention

Roman Penyaev wrote: > Hi all, > > The goal of this patch is to reduce contention of ep_poll_callback() which > can be called concurrently from different CPUs in case of high events > rates and many fds per epoll. Problem can be very well reproduced by > generating events (write to pipe or

[PATCH] platform/x86: thinkpad_acpi: add adaptive_kbd_modes parameter

15 = Control_L NoSymbol Control_L keycode 151 = Escape NoSymbol Escape add Control = Control_L Signed-off-by: Eric Wong --- Documentation/laptops/thinkpad-acpi.txt | 11 + drivers/platform/x86/thinkpad_acpi.c| 79 ++--- 2 files changed, 64 inse

[PATCH] platform/x86: thinkpad_acpi: add adaptive_kbd_modes parameter

15 = Control_L NoSymbol Control_L keycode 151 = Escape NoSymbol Escape add Control = Control_L Signed-off-by: Eric Wong --- Documentation/laptops/thinkpad-acpi.txt | 11 + drivers/platform/x86/thinkpad_acpi.c| 79 ++--- 2 files changed, 64 inse

[RFC] pipe: prevent compiler reordering in pipe_poll

ade by Paolo. Signed-off-by: Eric Wong Cc: Paolo Bonzini --- fs/pipe.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 39d6f431da83..1a904d941cf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -509,7 +509,7 @@ static l

[RFC] pipe: prevent compiler reordering in pipe_poll

ade by Paolo. Signed-off-by: Eric Wong Cc: Paolo Bonzini --- fs/pipe.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 39d6f431da83..1a904d941cf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -509,7 +509,7 @@ static l

Re: [PATCH 2/2] send-email: supply a --send-delay=1 by default

Ævar Arnfjörð Bjarmason wrote: > Good point. I also see that (via git log --author=Ævar --grep='^\[PATCH > ') that this series itself arrived out of order (0 -> 2 -> 1), but I > don't know to what extent public-inbox itself might be batching things. public-inbox doesn't batch,

Re: [PATCH 2/2] send-email: supply a --send-delay=1 by default

Ævar Arnfjörð Bjarmason wrote: > Good point. I also see that (via git log --author=Ævar --grep='^\[PATCH > ') that this series itself arrived out of order (0 -> 2 -> 1), but I > don't know to what extent public-inbox itself might be batching things. public-inbox doesn't batch, aside from when

Re: blog.cloudflare.com/the-sad-state-of-linux-socket-balancing/

Hi Marek, I'm replying to http://blog.cloudflare.com/the-sad-state-of-linux-socket-balancing/ via email so Jason and linux-kernel see it. I also don't believe in using centralized, proprietary messaging like Disqus for discussing Open Source, nor do I deal with JavaScript. I still believe the

Re: blog.cloudflare.com/the-sad-state-of-linux-socket-balancing/

Hi Marek, I'm replying to http://blog.cloudflare.com/the-sad-state-of-linux-socket-balancing/ via email so Jason and linux-kernel see it. I also don't believe in using centralized, proprietary messaging like Disqus for discussing Open Source, nor do I deal with JavaScript. I still believe the

Re: BUG in git diff-index

Marc Herbert wrote: > PS: I used NNTP and http://dir.gmane.org/gmane.comp.version-control.git > to quickly find this old thread (what could we do without NNTP?). Then > I googled for a web archive of this thread and Google could only find > this one: >

Re: BUG in git diff-index

Marc Herbert wrote: > PS: I used NNTP and http://dir.gmane.org/gmane.comp.version-control.git > to quickly find this old thread (what could we do without NNTP?). Then > I googled for a web archive of this thread and Google could only find > this one: >

Re: epoll_wait inaccurate timeout

+Cc folks who may know about timer stuff on epoll. Dmitry Banschikov wrote: > Hi! > > I have a problem caused by inaccurate timeouts in epoll_wait(2). > Here are some parts of strace -tt output: Which kernel version are you using? > 22578 09:33:46.959791 epoll_wait(5, >

Re: epoll_wait inaccurate timeout

+Cc folks who may know about timer stuff on epoll. Dmitry Banschikov wrote: > Hi! > > I have a problem caused by inaccurate timeouts in epoll_wait(2). > Here are some parts of strace -tt output: Which kernel version are you using? > 22578 09:33:46.959791 epoll_wait(5, > 22578

Re: BYD TouchPad driver (4.8.1) misdetects a Logitech mouse

Sorry for the late response, forwarding to Dmitry and linux-input. I haven't dealt with input in years... Michael Shell wrote: > > Not a big deal, but something nonetheless ... > > I recently upgraded my kernel from 4.3 to 4.8.1 (this is a Linux From > Scratch build).

Re: BYD TouchPad driver (4.8.1) misdetects a Logitech mouse

Sorry for the late response, forwarding to Dmitry and linux-input. I haven't dealt with input in years... Michael Shell wrote: > > Not a big deal, but something nonetheless ... > > I recently upgraded my kernel from 4.3 to 4.8.1 (this is a Linux From > Scratch build). There was only one

Re: patch mail rejected by vger.kernel.org

Zhouyi Zhou wrote: > Hi, > Yesterday, I cced 5 patches to linux-kernel@vger.kernel.org using > send-email, but all of them were > rejected by mail server at vger.kernel.org as follows: > "Dear yizhouz...@ict.ac.cn, Your message to linux-kernel@vger.kernel.org > was

Re: patch mail rejected by vger.kernel.org

Zhouyi Zhou wrote: > Hi, > Yesterday, I cced 5 patches to linux-kernel@vger.kernel.org using > send-email, but all of them were > rejected by mail server at vger.kernel.org as follows: > "Dear yizhouz...@ict.ac.cn, Your message to linux-kernel@vger.kernel.org > was rejected by the

Re: [ANNOUNCE] git-series: track changes to a patch series over time

Josh Triplett wrote: > On August 9, 2016 11:37:31 PM HST, Richard Ipsum > wrote: > > >Maybe there's a better solution to this problem than git-candidate > >then, > >maybe we can just invent some wonderful new subcommand that fetches > >a

Re: [ANNOUNCE] git-series: track changes to a patch series over time

Josh Triplett wrote: > On August 9, 2016 11:37:31 PM HST, Richard Ipsum > wrote: > > >Maybe there's a better solution to this problem than git-candidate > >then, > >maybe we can just invent some wonderful new subcommand that fetches > >a mailing list archive into a git repo, for those that

Re: [ANNOUNCE] git-series: track changes to a patch series over time

Josh Triplett <j...@joshtriplett.org> wrote: > On Mon, Aug 01, 2016 at 07:55:54AM +0000, Eric Wong wrote: > > Christian Couder <christian.cou...@gmail.com> wrote: > > > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum > > > <richard.ip...@codethink.co.uk&

Re: [ANNOUNCE] git-series: track changes to a patch series over time

Josh Triplett wrote: > On Mon, Aug 01, 2016 at 07:55:54AM +0000, Eric Wong wrote: > > Christian Couder wrote: > > > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum > > > wrote: > > > > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: >

Re: [ANNOUNCE] git-series: track changes to a patch series over time

Christian Couder wrote: > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum > wrote: > > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: > > [snip] > >> > >> I'd welcome any feedback, whether on the interface and workflow,

Re: [ANNOUNCE] git-series: track changes to a patch series over time

Christian Couder wrote: > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum > wrote: > > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: > > [snip] > >> > >> I'd welcome any feedback, whether on the interface and workflow, the > >> internals and collaboration, ideas on presenting

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

+cc Jason Baron since he might be able to provide more insight into epoll. Mathias Krause wrote: > Hi, > > this is an attempt to resurrect the thread initially started here: > > http://thread.gmane.org/gmane.linux.network/353003 > > As that patch fixed the issue for the mentioned

Re: List corruption on epoll_ctl(EPOLL_CTL_DEL) an AF_UNIX socket

+cc Jason Baron since he might be able to provide more insight into epoll. Mathias Krause wrote: > Hi, > > this is an attempt to resurrect the thread initially started here: > > http://thread.gmane.org/gmane.linux.network/353003 > > As that patch fixed the issue for

Re: epoll and multiple processes - eliminate unneeded process wake-ups

Madars Vitolins wrote: > Hi Folks, > > I am developing kind of open systems application, which uses > multiple processes/executables where each of them monitors some set > of resources (in this case POSIX Queues) via epoll interface. For > example when 10 processes on same queue are in state of

Re: epoll and multiple processes - eliminate unneeded process wake-ups

Madars Vitolins m...@silodev.com wrote: Hi Folks, I am developing kind of open systems application, which uses multiple processes/executables where each of them monitors some set of resources (in this case POSIX Queues) via epoll interface. For example when 10 processes on same queue are in

[PATCH] ALSA: usb-audio: don't try to get Outlaw RR2150 sample rate

-off-by: Eric Wong Cc: Joe Turner Cc: Takashi Iwai --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 32631a8..2ea5b33 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1118,6 +1118,7 @@ bool

[PATCH] ALSA: usb-audio: don't try to get Outlaw RR2150 sample rate

-off-by: Eric Wong normalper...@yhbt.net Cc: Joe Turner j...@oampo.co.uk Cc: Takashi Iwai ti...@suse.de --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 32631a8..2ea5b33 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c

[RFC] net: support SOCK_DONTWAIT for non-blocking accept4

SOCK_NONBLOCK, this does not affect the accepted socket, nor does it change the file status flag of the listen socket for other calls. Signed-off-by: Eric Wong --- RFC since this seems a bit esoteric, and I'm not sure if it'd be useful to others. I've certainly wished I've had it a few times along

[RFC] net: support SOCK_DONTWAIT for non-blocking accept4

SOCK_NONBLOCK, this does not affect the accepted socket, nor does it change the file status flag of the listen socket for other calls. Signed-off-by: Eric Wong normalper...@yhbt.net --- RFC since this seems a bit esoteric, and I'm not sure if it'd be useful to others. I've certainly wished I've had

[RFC] ALSA: usb-audio: reduce "cannot get freq at ep" spew

Eric Wong wrote: > I also had another generic patch prepared before I noticed Joe's > quirk addition for the MS Lifecam HD-5000. This is the generic patch I prepared before I noticed Joe's quirk addition (applies cleanly to 3.19 and 4.0-rc6): -

[PATCH] ALSA: usb-audio: don't try to get Benchmark DAC1 sample rate

Pre" variant. Signed-off-by: Eric Wong Cc: Joe Turner Cc: Takashi Iwai --- I also had another generic patch prepared before I noticed Joe's quirk addition for the MS Lifecam HD-5000. sound/usb/quirks.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/

[RFC] ALSA: usb-audio: reduce cannot get freq at ep spew

Eric Wong normalper...@yhbt.net wrote: I also had another generic patch prepared before I noticed Joe's quirk addition for the MS Lifecam HD-5000. This is the generic patch I prepared before I noticed Joe's quirk addition (applies cleanly to 3.19 and 4.0-rc6

[PATCH] ALSA: usb-audio: don't try to get Benchmark DAC1 sample rate

-by: Eric Wong normalper...@yhbt.net Cc: Joe Turner j...@oampo.co.uk Cc: Takashi Iwai ti...@suse.de --- I also had another generic patch prepared before I noticed Joe's quirk addition for the MS Lifecam HD-5000. sound/usb/quirks.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

Re: [PATCH v2 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Jason Baron wrote: > On 02/18/2015 12:51 PM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > >>> [...] However, I think the userspace API change is less > >>> clear since epoll_wait() doesn't currently have an > >>> 'input' events argument as epoll_ctl() does. > >> ... but the change would

Re: [PATCH v2 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Jason Baron jba...@akamai.com wrote: On 02/18/2015 12:51 PM, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: [...] However, I think the userspace API change is less clear since epoll_wait() doesn't currently have an 'input' events argument as epoll_ctl() does. ... but the

Re: [PATCH v2 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > [...] However, I think the userspace API change is less > > > clear since epoll_wait() doesn't currently have an > > > 'input' events argument as epoll_ctl() does. > > > > ... but the change would be a bit clearer and somewhat > > more

Re: [PATCH v2 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Ingo Molnar mi...@kernel.org wrote: * Ingo Molnar mi...@kernel.org wrote: [...] However, I think the userspace API change is less clear since epoll_wait() doesn't currently have an 'input' events argument as epoll_ctl() does. ... but the change would be a bit clearer and

Re: [PATCH 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Jason Baron wrote: > On 02/09/2015 11:49 PM, Eric Wong wrote: > > Do you have a userland use case to share? > > I've been trying to describe the use case, maybe I haven't been doing a good > job :( Sorry, I meant if you had any public code. Anyways, I've restarted work on ano

Re: [PATCH 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Jason Baron jba...@akamai.com wrote: On 02/09/2015 11:49 PM, Eric Wong wrote: Do you have a userland use case to share? I've been trying to describe the use case, maybe I haven't been doing a good job :( Sorry, I meant if you had any public code. Anyways, I've restarted work on another

Re: [PATCH 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Jason Baron wrote: > On 02/09/2015 05:45 PM, Andy Lutomirski wrote: > > On Mon, Feb 9, 2015 at 1:32 PM, Jason Baron wrote: > >> On 02/09/2015 03:18 PM, Andy Lutomirski wrote: > >>> On 02/09/2015 12:06 PM, Jason Baron wrote: > Epoll file descriptors that are added to a shared wakeup source

Re: [PATCH 2/2] epoll: introduce EPOLLEXCLUSIVE and EPOLLROUNDROBIN

Jason Baron jba...@akamai.com wrote: On 02/09/2015 05:45 PM, Andy Lutomirski wrote: On Mon, Feb 9, 2015 at 1:32 PM, Jason Baron jba...@akamai.com wrote: On 02/09/2015 03:18 PM, Andy Lutomirski wrote: On 02/09/2015 12:06 PM, Jason Baron wrote: Epoll file descriptors that are added to a

Re: [RFC PATCH 5/5] epoll: introduce epoll connected components (remove the epmutex)

Jason Baron wrote: > I've done a bit of performance evaluation on a dual socket, 10 core, hyper > threading enabled box: Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz. For the > simple epfdN->epfdN->pipefdN topology case where each thread has its > own unique files and is doing EPOLL_CTL_ADD and

Re: [RFC PATCH 5/5] epoll: introduce epoll connected components (remove the epmutex)

Jason Baron jba...@akamai.com wrote: I've done a bit of performance evaluation on a dual socket, 10 core, hyper threading enabled box: Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz. For the simple epfdN-epfdN-pipefdN topology case where each thread has its own unique files and is doing

Re: [PATCH] eventpoll: fix uninitialized variable in epoll_ctl

quot;epoll_ctl(op=EPOLL_CTL_DEL)") > > Remove use of epds in epoll_ctl when op == EPOLL_CTL_DEL. > > Fixes: 4d7e30d98939 ("epoll: Add a flag, EPOLLWAKEUP, to prevent suspend > while epoll events are ready") > Signed-off-by: Nicolas Iooss Looks good t

Re: [PATCH] eventpoll: fix uninitialized variable in epoll_ctl

: 4d7e30d98939 (epoll: Add a flag, EPOLLWAKEUP, to prevent suspend while epoll events are ready) Signed-off-by: Nicolas Iooss nicolas.iooss_li...@m4x.org Looks good to me. Tested without regressions on several of my (non-EPOLLWAKEUP) projects. Adding a few more folks to the Cc: list. Acked-by: Eric

Re: Does anyone know when FUTEX_WAIT can fail with EAGAIN?

Steven Stewart-Gallus wrote: > I'm trying to debug a hangup where my program loops with FUTEX_WAIT (actually > FUTEX_WAIT_PRIVATE but same thing) endlessly erring out with EAGAIN. I would > like to know if anyone on the mailing list knows when FUTEX_WAIT can fail with > EAGAIN. FUTEX_WAIT fails

Re: Does anyone know when FUTEX_WAIT can fail with EAGAIN?

Steven Stewart-Gallus sstewartgallu...@mylangara.bc.ca wrote: I'm trying to debug a hangup where my program loops with FUTEX_WAIT (actually FUTEX_WAIT_PRIVATE but same thing) endlessly erring out with EAGAIN. I would like to know if anyone on the mailing list knows when FUTEX_WAIT can fail

Re: eventpoll __list_del_entry corruption

Sasha Levin wrote: > On 05/15/2014 02:11 PM, Peter Zijlstra wrote: > > On Mon, May 12, 2014 at 11:42:33AM -0400, Sasha Levin wrote: > >> Hi all, > >> > >> While fuzzing with trinity inside a KVM tools guest running the latest > >> -next > >> kernel I've stumbled on the following spew. Maybe

Re: eventpoll __list_del_entry corruption

Sasha Levin sasha.le...@oracle.com wrote: On 05/15/2014 02:11 PM, Peter Zijlstra wrote: On Mon, May 12, 2014 at 11:42:33AM -0400, Sasha Levin wrote: Hi all, While fuzzing with trinity inside a KVM tools guest running the latest -next kernel I've stumbled on the following spew. Maybe

Re: [RFC PATCH for-next 2/4] epoll: epoll() syscall declaration

Nathaniel Yazdani wrote: > On Sun, Feb 23, 2014 at 9:32 PM, Eric Wong wrote: > > Nathaniel Yazdani wrote: > >> +asmlinkage long sys_epoll(int ep, struct epoll __user *in, > >> + unsigned int inc, struct epoll __user *out, > >> +

Re: [RFC PATCH for-next 4/4] epoll: epoll() syscall definition

Nathaniel Yazdani wrote: > + * stores triggered eventpoll entries in the 'out' array. The input array is > + * _not_ read-only, because the resulting event mask gets written back to > each > + * entry's ->ep_events field. When successful, this will be the same as > before > + * (plus EPOLLERR &

Re: [RFC PATCH for-next 4/4] epoll: epoll() syscall definition

Nathaniel Yazdani n1ght.4nd@gmail.com wrote: + * stores triggered eventpoll entries in the 'out' array. The input array is + * _not_ read-only, because the resulting event mask gets written back to each + * entry's -ep_events field. When successful, this will be the same as before + *

Re: [RFC PATCH for-next 2/4] epoll: epoll() syscall declaration

Nathaniel Yazdani n1ght.4nd@gmail.com wrote: On Sun, Feb 23, 2014 at 9:32 PM, Eric Wong normalper...@yhbt.net wrote: Nathaniel Yazdani n1ght.4nd@gmail.com wrote: +asmlinkage long sys_epoll(int ep, struct epoll __user *in, + unsigned int inc, struct epoll __user

Re: [RFC PATCH for-next 2/4] epoll: epoll() syscall declaration

Nathaniel Yazdani wrote: > +asmlinkage long sys_epoll(int ep, struct epoll __user *in, > + unsigned int inc, struct epoll __user *out, > + unsigned int outc, int timeout); I can understand using the new struct for 'in', but 'out' could just be "struct

Re: [RFC PATCH for-next 1/4] epoll: struct epoll userspace definiton

Nathaniel Yazdani wrote: > +++ b/include/uapi/linux/eventpoll.h > @@ -61,6 +61,12 @@ struct epoll_event { > __u64 data; > } EPOLL_PACKED; > > +struct epoll { > + int ep_fildes; /* file descriptor */ > + int ep_events; /* triggering events */ > + long long ep_ident; /* entry

Re: [RFC PATCH for-next 1/4] epoll: struct epoll userspace definiton

Nathaniel Yazdani n1ght.4nd@gmail.com wrote: +++ b/include/uapi/linux/eventpoll.h @@ -61,6 +61,12 @@ struct epoll_event { __u64 data; } EPOLL_PACKED; +struct epoll { + int ep_fildes; /* file descriptor */ + int ep_events; /* triggering events */ + long long

Re: [RFC PATCH for-next 2/4] epoll: epoll() syscall declaration

Nathaniel Yazdani n1ght.4nd@gmail.com wrote: +asmlinkage long sys_epoll(int ep, struct epoll __user *in, + unsigned int inc, struct epoll __user *out, + unsigned int outc, int timeout); I can understand using the new struct for 'in', but 'out'

Re: [RFC PATCH 0/3] epoll: read(),write(),ioctl() interface

Andy Lutomirski wrote: > >> On 02/02/2014 06:17 PM, Nathaniel Yazdani wrote: > > So are you saying that those features you mentioned are specifically sought > > after for the kernel? If so I'd like to take a crack at some of them, > > may as well > > get some use out of my new knowledge of epoll

Re: [RFC PATCH 0/3] epoll: read(),write(),ioctl() interface

Andy Lutomirski l...@amacapital.net wrote: On 02/02/2014 06:17 PM, Nathaniel Yazdani wrote: So are you saying that those features you mentioned are specifically sought after for the kernel? If so I'd like to take a crack at some of them, may as well get some use out of my new knowledge

Re: epoll oops.

Oleg Nesterov wrote: > Yes. Before that 971316f0503a hack epoll can't even know if the task > which did signalfd_poll() exits and frees the active signalfd_wqh. > If for example that task forked a child before exit. > > And the whole RCU logic is only needed if exit/ep_remove_wait_queue >

Re: epoll oops.

Oleg Nesterov o...@redhat.com wrote: Yes. Before that 971316f0503a hack epoll can't even know if the task which did signalfd_poll() exits and frees the active signalfd_wqh. If for example that task forked a child before exit. And the whole RCU logic is only needed if

Re: [PATCH 09/11] epoll: Remove unnecessary error path

Andi Kleen wrote: > From: Andi Kleen > > A static checker was pointing out that nothing can possible set > nwait < 0 in this path. The comment and the check appears to be > outdated. Remove it. I don't think so... > Cc: v...@zeniv.linux.org.uk > Signed-off-by: Andi Kleen > --- >

Re: [PATCH 09/11] epoll: Remove unnecessary error path

Andi Kleen a...@firstfloor.org wrote: From: Andi Kleen a...@linux.intel.com A static checker was pointing out that nothing can possible set nwait 0 in this path. The comment and the check appears to be outdated. Remove it. I don't think so... Cc: v...@zeniv.linux.org.uk Signed-off-by:

  1   2   3   4   >