Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-23 Thread Erik Stromdahl
On 05/22/2018 11:15 PM, Niklas Cassel wrote: Earlier we observed performance issues in calling push_pending from each tx completion. IMHO this change may introduce the same problem again. I prefer functional TX over performance issues, but I agree that it is unfortunate that SDIO doesn't

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-23 Thread Erik Stromdahl
On 05/22/2018 11:15 PM, Niklas Cassel wrote: Earlier we observed performance issues in calling push_pending from each tx completion. IMHO this change may introduce the same problem again. I prefer functional TX over performance issues, but I agree that it is unfortunate that SDIO doesn't

[PATCH] ath10k: sdio: fix compile warning

2017-07-08 Thread Erik Stromdahl
ss/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function ... drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_irq_handler’: drivers/net/wireless/ath/ath10k/sdio.c:1331: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: Erik St

[PATCH] ath10k: sdio: fix compile warning

2017-07-08 Thread Erik Stromdahl
ss/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function ... drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_irq_handler’: drivers/net/wireless/ath/ath10k/sdio.c:1331: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: Erik Stromda

Re: ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Erik Stromdahl
With gcc 4.1.2: drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_mbox_rxmsg_pending_handler’: drivers/net/wireless/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function + + *done = true; + + /* Copy the lookahead obtained from the HTC

Re: ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Erik Stromdahl
With gcc 4.1.2: drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_mbox_rxmsg_pending_handler’: drivers/net/wireless/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function + + *done = true; + + /* Copy the lookahead obtained from the HTC

[PATCH 0/2] scripts: show_delta: additional features

2017-04-22 Thread Erik Stromdahl
(and not the combination of absolute and delta time stamps which is the default behavior of show_delta) also makes it easier to diff logs from different test runs. Erik Stromdahl (2): scripts: show_delta: add time stamp rounding option scripts: show_delta: add --delta-only option scripts/show_delta

[PATCH 0/2] scripts: show_delta: additional features

2017-04-22 Thread Erik Stromdahl
(and not the combination of absolute and delta time stamps which is the default behavior of show_delta) also makes it easier to diff logs from different test runs. Erik Stromdahl (2): scripts: show_delta: add time stamp rounding option scripts: show_delta: add --delta-only option scripts/show_delta

[PATCH 2/2] scripts: show_delta: add --delta-only option

2017-04-22 Thread Erik Stromdahl
the output from two different test runs could potentially (and likely) make the diff tool detect a lot of irrelevant differences. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- scripts/show_delta | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/s

[PATCH 2/2] scripts: show_delta: add --delta-only option

2017-04-22 Thread Erik Stromdahl
the output from two different test runs could potentially (and likely) make the diff tool detect a lot of irrelevant differences. Signed-off-by: Erik Stromdahl --- scripts/show_delta | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/scripts/show_delta b/scripts/show_delta

[PATCH 1/2] scripts: show_delta: add time stamp rounding option

2017-04-22 Thread Erik Stromdahl
An additional feature for show_delta: -r With this option the delta time stamps are rounded to the closest microsecond specified by the -r option. Rationale: Make it easier to diff kernel logs when looking for timing issues (less irrelevant diffs detected by a diff tool). Signed-off-by: Erik

[PATCH 1/2] scripts: show_delta: add time stamp rounding option

2017-04-22 Thread Erik Stromdahl
An additional feature for show_delta: -r With this option the delta time stamps are rounded to the closest microsecond specified by the -r option. Rationale: Make it easier to diff kernel logs when looking for timing issues (less irrelevant diffs detected by a diff tool). Signed-off-by: Erik

[PATCH] scripts: show_delta: remove deprecated functions

2017-04-20 Thread Erik Stromdahl
Replaced deprecated string functions with newer versions compatible with Python 3.6. These functions also work with Python 2 as well. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- scripts/show_delta | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/s

[PATCH] scripts: show_delta: remove deprecated functions

2017-04-20 Thread Erik Stromdahl
Replaced deprecated string functions with newer versions compatible with Python 3.6. These functions also work with Python 2 as well. Signed-off-by: Erik Stromdahl --- scripts/show_delta | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/show_delta b/scripts