Re: [PATCH v2 3/7] gpio: separate gpio driver from pinctrl-rockchip driver

2021-04-11 Thread Ezequiel Garcia
Hi Johan, On Sun, 11 Apr 2021 at 14:57, Heiko Stübner wrote: > > Hi Johan, > > Am Sonntag, 11. April 2021, 19:51:52 CEST schrieb Johan Jonker: > > Hi, > > > > When I check "rockchip,gpio-bank" with YAML it turns out that > > rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property. > > It is

[PATCH] dt-bindings: pinctrl: rockchip: add RK3568 SoC support

2021-04-10 Thread Ezequiel Garcia
Add RK3568/RK3566 SoC support to pinctrl. Signed-off-by: Ezequiel Garcia --- Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt b/Documentation/devicetree/bindings

Re: [PATCH RESEND 0/7] gpio-rockchip driver

2021-04-10 Thread Ezequiel Garcia
Hi Jianqun, I tried applying this on top of "pinctrl: rockchip: add support for rk3568", but I got some conflicts. If you could add some information about how patches should be applied to the cover letter, that'd be really helpful :-) Also, I've noticed several of these GPIOs patches, is this

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

2021-04-09 Thread Ezequiel Garcia
On Fri, 2021-04-09 at 19:25 +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, ascordeiro wrote: > > > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > > > Hi Aline, > > > > Hi Ezequiel, > > > > > > On Fri

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

2021-04-09 Thread Ezequiel Garcia
On Fri, 2021-04-09 at 14:00 -0300, ascordeiro wrote: > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > > Hi Aline, > > Hi Ezequiel, > > > > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote: > > > Rewrite macros resembling f

Re: [Outreachy kernel][PATCH 1/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

2021-04-09 Thread Ezequiel Garcia
Hi Aline, On Fri, 2021-04-09 at 09:24 -0300, Aline Santana Cordeiro wrote: > Aligns line break with the remaining function arguments > to the open parenthesis. Issue found by checkpatch. > > Signed-off-by: Aline Santana Cordeiro > --- > Changes since v2: >  - Rename the commit messages properly

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

2021-04-09 Thread Ezequiel Garcia
Hi Aline, On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote: > Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE > and #define HANTRO_PP_RED_WRITE_S in lower case, according with > code style. > Where is this written in the Coding Style? Thanks! Ezequiel >

Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

2021-04-08 Thread Ezequiel Garcia
Ola Aline, Welcome to the kernel community. Hope you enjoy some of this Outreachy adventures. Normally, when you submit a v2, we want to know what changed between the first submission and v2. If you are subscribed to linux-media, you can read some of the series with a vN+1 and look how it's

[PATCH v5 10/10] media: uapi: move MPEG-2 stateless controls out of staging

2021-04-03 Thread Ezequiel Garcia
-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec-stateless.rst | 218 + .../media/v4l/ext-ctrls-codec.rst | 219 -- .../media/v4l/pixfmt-compressed.rst | 10 +- .../media/v4l/vidioc-g-ext-ctrls.rst | 12 + drivers/media/v4l2-core

[PATCH v5 09/10] media: uapi: Move the MPEG-2 stateless control type out of staging

2021-04-03 Thread Ezequiel Garcia
Move the MPEG-2 stateless control types out of staging, and re-number it to avoid any confusion. Signed-off-by: Ezequiel Garcia --- include/media/mpeg2-ctrls.h| 4 include/uapi/linux/videodev2.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/media

[PATCH v5 08/10] media: controls: Log MPEG-2 stateless control in .std_log

2021-04-03 Thread Ezequiel Garcia
Simply print the type of the control. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 575553ee7e4a..722a208c647e 100644

[PATCH v5 07/10] media: uapi: mpeg2: Remove V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS

2021-04-03 Thread Ezequiel Garcia
compatibility. Note that this would mean introducing a enumerator control to specify the decoding mode (see V4L2_CID_STATELESS_H264_DECODE_MODE). Signed-off-by: Ezequiel Garcia Co-developed-by: Nicolas Dufresne Signed-off-by: Nicolas Dufresne --- .../media/v4l/ext-ctrls-codec.rst | 35

[PATCH v5 06/10] media: hantro/cedrus: Remove unneeded slice size and slice offset

2021-04-03 Thread Ezequiel Garcia
in a picture (with either frame or field structure) to be contained in the OUTPUT buffer, which means the slice size and offset shouldn't be used. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c | 4 ++-- drivers/staging/media/hantro

[PATCH v5 05/10] media: uapi: mpeg2: Move reference buffer fields

2021-04-03 Thread Ezequiel Garcia
The forward and backwards references are specified per-picture and not per-slice. Move it to V4L2_CID_MPEG_VIDEO_MPEG2_PICTURE. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec.rst | 28 +-- .../media/hantro/hantro_g1_mpeg2_dec.c| 6

[PATCH v5 04/10] media: uapi: mpeg2: Split sequence and picture parameters

2021-04-03 Thread Ezequiel Garcia
it clashes with existing ones. This is not really an issue since they will be re-defined when the controls are moved out of staging. Signed-off-by: Ezequiel Garcia Tested-by: Jonas Karlman --- .../media/v4l/ext-ctrls-codec.rst | 47 ++--- .../media/v4l/pixfmt-compressed.rst

[PATCH v5 03/10] media: uapi: mpeg2: Cleanup flags

2021-04-03 Thread Ezequiel Garcia
Our current MPEG-2 uAPI uses 1-byte fields for MPEG-2 boolean syntax elements. Clean these by adding a 'flags' field and flag macro for each boolean syntax element. A follow-up change will refactor this uAPI so we don't need to add padding fields just yet. Signed-off-by: Ezequiel Garcia Tested

[PATCH v5 02/10] media: uapi: mpeg2: rework quantisation matrices semantics

2021-04-03 Thread Ezequiel Garcia
lized by the V4L2 control core to their reset default value, and applications are expected to reset their values as specified. The quantisation control is therefore optional, and used to load bitstream-defined values in the quantisation matrices. Signed-off-by: Ezequiel Garcia Co-developed-by

[PATCH v5 01/10] media: uapi: mpeg2: Rename "quantization" to "quantisation"

2021-04-03 Thread Ezequiel Garcia
The MPEG-2 specification refers to the quantisation matrices using the word "quantisation". Make the V4L2 interface more ergonomic by matching the MPEG-2 spec. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec.rst | 16 ++-- .../media/v4l/pixfmt-comp

[PATCH v5 00/10] MPEG-2 stateless API cleanup and destaging

2021-04-03 Thread Ezequiel Garcia
ion in a flag, which was fortunately reported by 0day bot. Ezequiel Garcia (10): media: uapi: mpeg2: Rename "quantization" to "quantisation" media: uapi: mpeg2: rework quantisation matrices semantics media: uapi: mpeg2: Cleanup flags media: uapi: mpeg2: Split seque

Re: [PATCH v4 1/9] media: uapi: mpeg2: Rework quantization matrices semantics

2021-04-03 Thread Ezequiel Garcia
Hi Nicolas, On Mon, 2021-03-29 at 16:53 -0400, Nicolas Dufresne wrote: > Le lundi 29 mars 2021 à 15:13 -0300, Ezequiel Garcia a écrit : > > As stated in the MPEG-2 specification, section 6.3.7 "Quant matrix > > extension": > > > >   Each quantisation mat

Re: [PATCH v8 09/13] media: uapi: Add a control for HANTRO driver

2021-04-02 Thread Ezequiel Garcia
Hi Benjamin, Thanks for the patch. On Thu, 2021-04-01 at 17:59 +0200, Benjamin Gaignard wrote: > The HEVC HANTRO driver needs to know the number of bits to skip at > the beginning of the slice header. > That is a hardware specific requirement so create a dedicated control > that this purpose. >

Re: [PATCH v7 12/13] media: hantro: IMX8M: add variant for G2/HEVC codec

2021-03-29 Thread Ezequiel Garcia
Benjamin Gaignard > Reviewed-by: Philipp Zabel Reviewed-by: Ezequiel Garcia > --- > version 7: >  - Add Philipp Reviewed-by tag. > > version 5: >  - remove useless postproc fields for G2 > > version 2: > - remove useless clocks > >  drivers/staging/media/hantro

Re: [PATCH v7 10/13] media: hantro: handle V4L2_PIX_FMT_HEVC_SLICE control

2021-03-29 Thread Ezequiel Garcia
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote: > Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2 > of the driver. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia > --- >  drivers/staging/media/hantro/hantro_v4l2.c | 1 + &g

Re: [PATCH v7 08/13] media: hantro: Only use postproc when post processed formats are defined

2021-03-29 Thread Ezequiel Garcia
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote: > If the variant doesn't offert postprocessed formats make sure it will > be ok. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia > --- >  drivers/staging/media/hantro/hantro.h  |  8 +

Re: [PATCH v7 07/13] media: hantro: Define HEVC codec profiles and supported features

2021-03-29 Thread Ezequiel Garcia
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote: > Define which HEVC profiles (up to level 5.1) and features > (no scaling, no 10 bits) are supported by the driver. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia > --- >  drivers/staging/med

Re: [PATCH v7 06/13] media: hantro: change hantro_codec_ops run prototype to return errors

2021-03-29 Thread Ezequiel Garcia
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote: > Change hantro_codec_ops run prototype from 'void' to 'int'. > This allow to cancel the job if an error occur while configuring > the hardware. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia &g

Re: [PATCH v7 05/13] media: hevc: Add decode params control

2021-03-29 Thread Ezequiel Garcia
rence picture set". > > Adapt Cedrus driver to these changes. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia > --- > version 7: >  - rebased on top of media_tree/master branch > > version 6: >  - fix compilation errors >

Re: [PATCH v7 04/13] media: hevc: Add fields and flags for hevc PPS

2021-03-29 Thread Ezequiel Garcia
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote: > Add fields and flags as they are defined in > 7.4.3.3.1 "General picture parameter set RBSP semantics of the > H.265 ITU specification. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Ezequiel Garcia > -

[PATCH v4 9/9] media: uapi: Move MPEG-2 stateless controls out of staging

2021-03-29 Thread Ezequiel Garcia
-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec-stateless.rst | 218 + .../media/v4l/ext-ctrls-codec.rst | 219 -- .../media/v4l/pixfmt-compressed.rst | 10 +- .../media/v4l/vidioc-g-ext-ctrls.rst | 12 + drivers/media/v4l2-core

[PATCH v4 7/9] media: controls: Log MPEG-2 stateless control in .std_log

2021-03-29 Thread Ezequiel Garcia
Simply print the type of the control. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 28657f2f679b..063a373c8965 100644

[PATCH v4 6/9] media: uapi: mpeg2: Remove V4L2_CID_MPEG_VIDEO_MPEG2_SLICE_PARAMS

2021-03-29 Thread Ezequiel Garcia
compatibility. Note that this would mean introducing a enumerator control to specify the decoding mode (see V4L2_CID_STATELESS_H264_DECODE_MODE). Signed-off-by: Ezequiel Garcia Co-developed-by: Nicolas Dufresne Signed-off-by: Nicolas Dufresne --- .../media/v4l/ext-ctrls-codec.rst | 35

[PATCH v4 8/9] media: uapi: Move the MPEG-2 stateless control type out of staging

2021-03-29 Thread Ezequiel Garcia
Move the MPEG-2 stateless control types out of staging, and re-number it to avoid any confusion. Signed-off-by: Ezequiel Garcia --- include/media/mpeg2-ctrls.h| 4 include/uapi/linux/videodev2.h | 4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/media

[PATCH v4 4/9] media: uapi: mpeg2: Move reference buffer fields

2021-03-29 Thread Ezequiel Garcia
The forward and backwards references are specified per-picture and not per-slice. Move it to V4L2_CID_MPEG_VIDEO_MPEG2_PICTURE. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec.rst | 28 +-- .../media/hantro/hantro_g1_mpeg2_dec.c| 6

[PATCH v4 5/9] media: hantro/cedrus: Remove unneeded slice size and slice offset

2021-03-29 Thread Ezequiel Garcia
in a picture (with either frame or field structure) to be contained in the OUTPUT buffer, which means the slice size and offset shouldn't be used. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c | 4 ++-- drivers/staging/media/hantro

[PATCH v4 3/9] media: uapi: mpeg2: Split sequence and picture parameters

2021-03-29 Thread Ezequiel Garcia
it clashes with existing ones. This is not really an issue since they will be re-defined when the controls are moved out of staging. Signed-off-by: Ezequiel Garcia Tested-by: Jonas Karlman --- .../media/v4l/ext-ctrls-codec.rst | 47 ++--- .../media/v4l/pixfmt-compressed.rst

[PATCH v4 2/9] media: uapi: mpeg2: Cleanup flags

2021-03-29 Thread Ezequiel Garcia
Our current MPEG-2 uAPI uses 1-byte fields for MPEG-2 boolean syntax elements. Clean these by adding a 'flags' field and flag macro for each boolean syntax element. A follow-up change will refactor this uAPI so we don't need to add padding fields just yet. Signed-off-by: Ezequiel Garcia Tested

[PATCH v4 1/9] media: uapi: mpeg2: Rework quantization matrices semantics

2021-03-29 Thread Ezequiel Garcia
lized by the V4L2 control core to their reset default value, and applications are expected to reset their values as specified. The quantization control is therefore optional, and used to load bitstream-defined values in the quantization matrices. Signed-off-by: Ezequiel Garcia Co-developed-by

[PATCH v4 0/9] MPEG-2 stateless API cleanup and destaging

2021-03-29 Thread Ezequiel Garcia
boilerplate fixes for the new controls to be properly exposed, initialized and validated. v2: * Fixed bad use of boolean negation in a flag, which was fortunately reported by 0day bot. Ezequiel Garcia (9): media: uapi: mpeg2: Rework quantization matrices semantics media: uapi: mpeg2: Cleanup

Re: [PATCH v6 13/13] arm64: dts: imx8mq: Add node to G2 hardware

2021-03-26 Thread Ezequiel Garcia
On Fri, 2021-03-26 at 15:33 +0100, Benjamin Gaignard wrote: > > Le 26/03/2021 à 15:24, Philipp Zabel a écrit : > > On Thu, Mar 18, 2021 at 09:20:46AM +0100, Benjamin Gaignard wrote: > > > Split VPU node in two: one for G1 and one for G2 since they are > > > different hardware blocks. > > > Add

Re: [PATCH v4 07/11] media: hantro: Introduce G2/HEVC decoder

2021-03-16 Thread Ezequiel Garcia
On Tue, 2021-03-16 at 21:19 +0100, Benjamin Gaignard wrote: > > Le 16/03/2021 à 19:46, Ezequiel Garcia a écrit : > > Hi Benjamin, > > > > The series is looking really good. Some comments below. > > > > On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard

Re: [PATCH v4 07/11] media: hantro: Introduce G2/HEVC decoder

2021-03-16 Thread Ezequiel Garcia
Hi Benjamin, The series is looking really good. Some comments below. On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote: > Implement all the logic to get G2 hardware decoding HEVC frames. > It support up level 5.1 HEVC stream. > It doesn't support yet 10 bits formats or scaling feature.

Re: [PATCH v3 06/15] media: mtk-vcodec: vdec: support stateless H.264 decoding

2021-03-15 Thread Ezequiel Garcia
Hi Alex, On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot wrote: > > Hi Ezequiel, > > On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia > wrote: > > > > Hi Alex, > > > > Thanks for the patch. > > > > On Fri, 26 Feb 2021 at 07:06, Alexandre

Re: [PATCH v3 05/15] media: mtk-vcodec: vdec: support stateless API

2021-03-15 Thread Ezequiel Garcia
Hi Alexandre, On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot wrote: > > Hi Ezequiel, thanks for the feedback! > > On Thu, Mar 4, 2021 at 6:30 AM Ezequiel Garcia > wrote: > > > > Hello Alex, > > > > Thanks for the patch. > > > > On Fri,

[PATCH v3 0/8] V4L2 stateless VP8 de-staging

2021-03-04 Thread Ezequiel Garcia
1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/ [2] https://gitlab.freedesktop.org/ezequielgarcia/gst-plugins-bad/-/tree/vp8-api-update [3] https://github.com/fluendo/fluster Ezequiel Garcia (8): media: uapi: vp8: Remove "header" from symbol names and mac

[PATCH v3 8/8] media: uapi: move VP8 stateless controls out of staging

2021-03-04 Thread Ezequiel Garcia
, and now that the API is able to support Cedrus and Hantro G1, we can consider this ready. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec-stateless.rst | 334 + .../media/v4l/ext-ctrls-codec.rst | 339 -- .../media/v4l/pixfmt

[PATCH v3 3/8] media: uapi: vp8: Add proper kernel-doc documentation

2021-03-04 Thread Ezequiel Garcia
In preparation for making the interface public, document all the structures. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 99 +++ 1 file changed, 99 insertions(+) diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h index

[PATCH v3 5/8] media: uapi: Move the VP8 stateless control type out of staging

2021-03-04 Thread Ezequiel Garcia
Move the VP8 stateless control types out of staging, and re-number it to avoid any confusion. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 1 - include/uapi/linux/videodev2.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/media/vp8-ctrls.h b

[PATCH v3 7/8] media: vp8: Rename V4L2 VP8 specific macro to V4L2_VP8_

2021-03-04 Thread Ezequiel Garcia
Before we move the VP8 controls to a stable public header, rename this macro so it's clearly V4L2-specific. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro_g1_vp8_dec.c | 6 +++--- drivers/staging/media/hantro/rk3399_vpu_hw_vp8_dec.c | 6 +++--- drivers/staging

[PATCH v3 2/8] media: uapi: vp8: Rename v4l2_vp8_loopfilter to v4l2_vp8_loop_filter

2021-03-04 Thread Ezequiel Garcia
Rename to struct v4l2_vp8_loop_filter, which is closer to the VP8 syntax. This change is only cosmetics, but since this API is exposed to userspace, it's worth the trouble to get it consistent. Signed-off-by: Ezequiel Garcia --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 12

[PATCH v3 6/8] media: controls: Log VP8 stateless control in .std_log

2021-03-04 Thread Ezequiel Garcia
Simply print the type of the control. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 49bbc06d2bb3..658621b961d5 100644 --- a/drivers

[PATCH v3 4/8] media: uapi: Move parsed VP8 pixel format out of staging

2021-03-04 Thread Ezequiel Garcia
Since we are ready to stabilize the VP8 stateless API, move the parsed VP8 pixel format. Signed-off-by: Ezequiel Garcia --- Documentation/userspace-api/media/v4l/pixfmt-compressed.rst | 5 - include/media/vp8-ctrls.h | 2 -- include/uapi/linux/videodev2.h

[PATCH v3 1/8] media: uapi: vp8: Remove "header" from symbol names and macros

2021-03-04 Thread Ezequiel Garcia
It doesn't seem to add any clarity to have a "header" suffix in controls, struct names and flags. Since this just makes names too long without any benefit, just drop it. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec.rst | 80 +++ .../media/

Re: [PATCH v3 05/15] media: mtk-vcodec: vdec: support stateless API

2021-03-03 Thread Ezequiel Garcia
Hello Alex, Thanks for the patch. On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot wrote: > > From: Yunfei Dong > > Support the stateless codec API that will be used by MT8183. > > Signed-off-by: Yunfei Dong > [acourbot: refactor, cleanup and split] > Co-developed-by: Alexandre Courbot >

Re: [PATCH v3 06/15] media: mtk-vcodec: vdec: support stateless H.264 decoding

2021-03-03 Thread Ezequiel Garcia
Hi Alex, Thanks for the patch. On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot wrote: > > From: Yunfei Dong > > Add support for H.264 decoding using the stateless API, as supported by > MT8183. This support takes advantage of the V4L2 H.264 reference list > builders. > > Signed-off-by: Yunfei

Re: [PATCH v4 03/11] media: hantro: change hantro_codec_ops run prototype to return errors

2021-03-03 Thread Ezequiel Garcia
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote: > Change hantro_codec_ops run prototype from 'void' to 'int'. > This allow to cancel the job if an error occur while configuring > the hardware. > > Signed-off-by: Benjamin Gaignard > --- >  drivers/staging/media/hantro/hantro_drv.c

Re: [PATCH v4 05/11] media: hantro: Add a field to distinguish the hardware versions

2021-03-03 Thread Ezequiel Garcia
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote: > Decoders hardware blocks could exist in multiple versions: add > a field to distinguish them at runtime. > G2 hardware block doesn't have postprocessor hantro_needs_postproc > function should always returns false in for this hardware. >

Re: [PATCH v4 09/11] media: hantro: IMX8M: add variant for G2/HEVC codec

2021-03-03 Thread Ezequiel Garcia
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote: > Add variant to IMX8M to enable G2/HEVC codec. > Define the capabilities for the hardware up to 3840x2160. > Retrieve the hardware version at init to distinguish G1 from G2. > > Signed-off-by: Benjamin Gaignard > --- > version 2: > -

[PATCH v2 8/8] media: uapi: move VP8 stateless controls out of staging

2021-03-03 Thread Ezequiel Garcia
, and now that the API is able to support Cedrus and Hantro G1, we can consider this ready. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec-stateless.rst | 318 + .../media/v4l/ext-ctrls-codec.rst | 323 -- .../media/v4l/pixfmt

[PATCH v2 7/8] media: vp8: Rename V4L2 VP8 specific macro to V4L2_VP8_

2021-03-03 Thread Ezequiel Garcia
Before we move the VP8 controls to a stable public header, rename this macro so it's clearly V4L2-specific. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/hantro/hantro_g1_vp8_dec.c | 6 +++--- drivers/staging/media/hantro/rk3399_vpu_hw_vp8_dec.c | 6 +++--- drivers/staging

[PATCH v2 6/8] media: controls: Log VP8 stateless control in .std_log

2021-03-03 Thread Ezequiel Garcia
Simply print the type of the control. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 1a683f4fa978..0fc7180a47e9 100644 --- a/drivers

[PATCH v2 5/8] media: uapi: Move the VP8 stateless control type out of staging

2021-03-03 Thread Ezequiel Garcia
Move the VP8 stateless control types out of staging, and re-number it to avoid any confusion. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 1 - include/uapi/linux/videodev2.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/media/vp8-ctrls.h b

[PATCH v2 4/8] media: uapi: Move parsed VP8 pixel format out of staging

2021-03-03 Thread Ezequiel Garcia
Since we are ready to stabilize the VP8 stateless API, move the parsed VP8 pixel format. Signed-off-by: Ezequiel Garcia --- Documentation/userspace-api/media/v4l/pixfmt-compressed.rst | 5 - include/media/vp8-ctrls.h | 2 -- include/uapi/linux/videodev2.h

[PATCH v2 3/8] media: uapi: vp8: Add proper kernel-doc documentation

2021-03-03 Thread Ezequiel Garcia
In preparation for making the interface public, document all the structures. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 99 +++ 1 file changed, 99 insertions(+) diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h index

[PATCH v2 1/8] media: uapi: vp8: Remove "header" from symbol names and macros

2021-03-03 Thread Ezequiel Garcia
It doesn't seem to add any clarity to have a "header" suffix in controls, struct names and flags. Since this just makes names too long without any benefit, just drop it. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec.rst | 80 +++ .../media/

[PATCH v2 2/8] media: uapi: vp8: Rename v4l2_vp8_loopfilter to v4l2_vp8_loop_filter

2021-03-03 Thread Ezequiel Garcia
Rename to struct v4l2_vp8_loop_filter, which is closer to the VP8 syntax. This change is only cosmetics, but since this API is exposed to userspace, it's worth the trouble to get it consistent. Signed-off-by: Ezequiel Garcia --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 12

[PATCH v2 0/8] V4L2 stateless VP8 de-staging

2021-03-03 Thread Ezequiel Garcia
as-is. This was tested with GStreamer v4l2codec element and Fluster [2] conformance test, on a Hantro G1 device. Changelog: v2: * Rename VP8_FRAME_IS_KEY_FRAME [1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/ [2] https://github.com/fluendo/fluster Ezequiel Garcia (8

[PATCH 6/7] media: controls: Log VP8 stateless control in .std_log

2021-03-02 Thread Ezequiel Garcia
Simply print the type of the control. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 1a683f4fa978..0fc7180a47e9 100644 --- a/drivers

[PATCH 7/7] media: uapi: move VP8 stateless controls out of staging

2021-03-02 Thread Ezequiel Garcia
, and now that the API is able to support Cedrus and Hantro G1, we can consider this ready. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec-stateless.rst | 318 + .../media/v4l/ext-ctrls-codec.rst | 323 -- .../media/v4l/pixfmt

[PATCH 3/7] media: uapi: vp8: Add proper kernel-doc documentation

2021-03-02 Thread Ezequiel Garcia
In preparation for making the interface public, document all the structures. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 99 +++ 1 file changed, 99 insertions(+) diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h index

[PATCH 2/7] media: uapi: vp8: Rename v4l2_vp8_loopfilter to v4l2_vp8_loop_filter

2021-03-02 Thread Ezequiel Garcia
Rename to struct v4l2_vp8_loop_filter, which is closer to the VP8 syntax. This change is only cosmetics, but since this API is exposed to userspace, it's worth the trouble to get it consistent. Signed-off-by: Ezequiel Garcia --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 12

[PATCH 5/7] media: uapi: Move the VP8 stateless control type out of staging

2021-03-02 Thread Ezequiel Garcia
Move the VP8 stateless control types out of staging, and re-number it to avoid any confusion. Signed-off-by: Ezequiel Garcia --- include/media/vp8-ctrls.h | 1 - include/uapi/linux/videodev2.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/media/vp8-ctrls.h b

[PATCH 4/7] media: uapi: Move parsed VP8 pixel format out of staging

2021-03-02 Thread Ezequiel Garcia
Since we are ready to stabilize the VP8 stateless API, move the parsed VP8 pixel format. Signed-off-by: Ezequiel Garcia --- Documentation/userspace-api/media/v4l/pixfmt-compressed.rst | 5 - include/media/vp8-ctrls.h | 2 -- include/uapi/linux/videodev2.h

[PATCH 0/7] V4L2 stateless VP8 de-staging

2021-03-02 Thread Ezequiel Garcia
as-is. This was tested with GStreamer v4l2codec element and Fluster [2] conformance test, on a Hantro G1 device. [1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/ [2] https://github.com/fluendo/fluster Ezequiel Garcia (7): media: uapi: vp8: Remove "header" f

[PATCH 1/7] media: uapi: vp8: Remove "header" from symbol names and macros

2021-03-02 Thread Ezequiel Garcia
It doesn't seem to add any clarity to have a "header" suffix in controls, struct names and flags. Since this just makes names too long without any benefit, just drop it. Signed-off-by: Ezequiel Garcia --- .../media/v4l/ext-ctrls-codec.rst | 80 +++ .../media/

Re: [PATCH 4/7] misc: Add driver for DAB IP found on Renesas R-Car devices

2021-03-02 Thread Ezequiel Garcia
Hello everyone, On Mon, 1 Mar 2021 at 14:36, Fabrizio Castro wrote: > > Hi Arnd, > > Thanks for your feedback! > > > From: Arnd Bergmann > > Sent: 26 February 2021 10:38 > > Subject: Re: [PATCH 4/7] misc: Add driver for DAB IP found on Renesas R- > > Car devices > > > > On Thu, Feb 25, 2021 at

Re: [PATCH v3 5/9] media: hantro: Introduce G2/HEVC decoder

2021-02-26 Thread Ezequiel Garcia
On Fri, 2021-02-26 at 10:47 +0100, Benjamin Gaignard wrote: > > Le 25/02/2021 à 18:55, Ezequiel Garcia a écrit : > > Hi Benjamin, > > > > Thanks for the good work! > > I mostly have two concerns with this implementation, > > the tiled output and the

Re: [PATCH] media: hantro: Auto generate the AXI ID to avoid conflicts

2021-02-25 Thread Ezequiel Garcia
Hi Enric, Thanks a lot for the patch. On Thu, 25 Feb 2021 at 09:08, Enric Balletbo i Serra wrote: > > The AXI ID is an AXI bus configuration for improve bus performance. If > read and write operations use different ID the operations can be > paralleled, whereas when they have the same ID the

Re: [PATCH v3 5/9] media: hantro: Introduce G2/HEVC decoder

2021-02-25 Thread Ezequiel Garcia
Hi Benjamin, Thanks for the good work! I mostly have two concerns with this implementation, the tiled output and the allocation path. More below. On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote: > Implement all the logic to get G2 hardware decoding HEVC frames. > It support up level

Re: Re: [PATCH v3 1/9] media: hevc: Modify structures to follow H265 ITU spec

2021-02-25 Thread Ezequiel Garcia
Hey Jernej, On Thu, 2021-02-25 at 18:01 +0100, Jernej Škrabec wrote: > Hi Ezequiel, > > Dne četrtek, 25. februar 2021 ob 14:09:52 CET je Ezequiel Garcia napisal(a): > > Hi Benjamin, > > > > Thanks for the good work. > > > > On Mon, 2021-02-22

Re: [PATCH v3 4/9] media: uapi: Add a control for HANTRO driver

2021-02-25 Thread Ezequiel Garcia
Hi Benjamin, On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote: > The HEVC HANTRO driver needs to know the number of bits to skip at s/HANTRO/Hantro > the beginning of the slice header. As discussed in a different thread, we should describe exactly what the hardware is expecting, so

Re: [PATCH v3 1/9] media: hevc: Modify structures to follow H265 ITU spec

2021-02-25 Thread Ezequiel Garcia
Hi Benjamin, Thanks for the good work. On Mon, 2021-02-22 at 13:23 +0100, Benjamin Gaignard wrote: > The H.265 ITU specification (section 7.4) define the general > slice segment header semantics. > Modified/added fields are: > - video_parameter_set_id: (7.4.3.1) identifies the VPS for >

Re: [PATCH v3 2/9] media: hantro: Define HEVC codec profiles and supported features

2021-02-24 Thread Ezequiel Garcia
On Mon, 2021-02-22 at 13:23 +0100, Benjamin Gaignard wrote: > Define which HEVC profiles (up to level 5.1) and features > (no scaling, no 10 bits) are supported by the driver. > > Signed-off-by: Benjamin Gaignard > --- >  drivers/staging/media/hantro/hantro.h |  2 + >  

Re: [PATCH v3 0/9] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-02-24 Thread Ezequiel Garcia
tags. commit 494adacd844e5656b570895a82bc343438b23023 Author: Adrian Ratiu Date: Thu Feb 18 12:17:37 2021 +0100 media: hantro: Introduce G2/HEVC decoder ... Signed-off-by: Adrian Ratiu Co-developed-by: Ezequiel Garcia Signed-off-by: Ezequiel Garcia Co-developed-by: Benj

Re: [PATCH v3 8/9] dt-bindings: media: nxp,imx8mq-vpu: Update bindings

2021-02-23 Thread Ezequiel Garcia
Hi Rob, On Tue, 2021-02-23 at 08:31 -0600, Rob Herring wrote: > On Tue, Feb 23, 2021 at 2:04 AM Benjamin Gaignard > wrote: > > > > > > Le 23/02/2021 à 01:34, Rob Herring a écrit : > > > On Mon, Feb 22, 2021 at 01:24:05PM +0100, Benjamin Gaignard wrote: > > > > The current bindings seem to make

Re: [PATCH v2 4/9] media: uapi: Add a control for HANTRO driver

2021-02-22 Thread Ezequiel Garcia
On Mon, 2021-02-22 at 17:28 +0100, Benjamin Gaignard wrote: > > Le 22/02/2021 à 17:16, John Cox a écrit : > > > The HEVC HANTRO driver needs to know the number of bits to skip at > > > the beginning of the slice header. > > > That is a hardware specific requirement so create a dedicated control >

Re: [PATCH] drm/panel: kd35t133: allow using non-continuous dsi clock

2021-02-19 Thread Ezequiel Garcia
ot;drm/bridge/synopsys: dsi: add support for non-continuous HS clock") Cc: sta...@vger.kernel.org # 5.10+ With this fix, my Odroid Go2 has display. Tested-by: Ezequiel Garcia Thanks, Ezequiel > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 3 ++- &g

Re: [PATCH v1 13/18] media: hantro: Introduce G2/HEVC decoder

2021-02-17 Thread Ezequiel Garcia
rom the stream that only the userland knows so let it > provide the correct value to the driver. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/staging/media/hantro/Makefile |   2 + >  dri

Re: [PATCH v1 18/18] arm64: dts: imx8mq: Add node to G2 hardware

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: > Split VPU node in two: one for G1 and one for G2 since they are > different hardware blocks. > > Signed-off-by: Benjamin Gaignard > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 43 +-- >  1 file changed, 33

Re: [PATCH v1 11/18] media: hantro: Add helper function for auxiliary buffers allocation

2021-02-17 Thread Ezequiel Garcia
ff-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/staging/media/hantro/hantro.h | 24 >  1 file changed, 24 insertions(+) > > diff --git a/drivers/staging/media/hantro/hantro.h > b/driver

Re: [PATCH v1 10/18] media: hantro: Add helper functions for buffer information

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Add help functions to retrieve buffer address and size. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/staging/media

Re: [PATCH v1 07/18] media: hantro: Add a field to distinguish the hardware versions

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Decoders hardware blocks could exist in multiple versions: add > a field to distinguish them at runtime. > Keep the default behavoir to be G1 hardware. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequie

Re: [PATCH v1 15/18] media: hantro: handle V4L2_PIX_FMT_HEVC_SLICE control

2021-02-17 Thread Ezequiel Garcia
On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote: > Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2 > of the driver. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  driv

Re: [PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set

2021-02-17 Thread Ezequiel Garcia
drop this patch. Thanks, Ezequiel > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/staging/media/hantro/hantro_drv.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging

Re: [PATCH v1 05/18] media: controls: Add control for HEVC codec

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Add HEVC decode params and scaling matrix controls. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia > Signed-off-by: Adrian Ratiu > --- >  drivers/media/v4l2-c

Re: [PATCH v1 04/18] media: hevc: add structures for hevc codec

2021-02-17 Thread Ezequiel Garcia
w structures > So this commit description needs some more information. See commit d9358563179a7f01f9020ebbe201c7e54ba3af48 Author: Ezequiel Garcia Date: Tue Aug 25 05:52:36 2020 +0200 media: uapi: h264: Clean slice invariants syntax elements which explains why it's OK to move some fields o

Re: [PATCH v1 03/18] arm64: dts: imx8mq-evk: add reserve memory node for CMA region

2021-02-17 Thread Ezequiel Garcia
Hi Benjamin, On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Define allocation range for the default CMA region. > > Signed-off-by: Benjamin Gaignard > Signed-off-by: Ezequiel Garcia Despite it seems like I signed-off this one... > Signed-off-by: Adrian Ratiu

Re: [PATCH v1 02/18] media: hantro: Define HEVC codec profiles and supported features

2021-02-17 Thread Ezequiel Garcia
Hello Benjamin, Thanks a lot for the patch. On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote: > Define which HEVC profiles (up to level 5.1) and features > (no scaling, no 10 bits) are supported by the driver. > > Signed-off-by: Benjamin Gaignard > Signed-off-by:

Re: linux-next: build warning after merge of the v4l-dvb tree

2021-02-08 Thread Ezequiel Garcia
On Mon, 2021-02-08 at 18:40 +0100, Mauro Carvalho Chehab wrote: > Em Mon, 08 Feb 2021 13:57:56 -0300 > Ezequiel Garcia escreveu: > > > On Mon, 2021-02-08 at 18:46 +0200, Sakari Ailus wrote: > > > Hi Ezequiel, > > > > > > Thanks for addressing this.

Re: linux-next: build warning after merge of the v4l-dvb tree

2021-02-08 Thread Ezequiel Garcia
On Mon, 2021-02-08 at 18:46 +0200, Sakari Ailus wrote: > Hi Ezequiel, > > Thanks for addressing this. > > On Mon, Feb 08, 2021 at 01:42:21PM -0300, Ezequiel Garcia wrote: > > Hi Stephen, > > > > On Mon, 2021-02-08 at 23:37 +1100, Stephen Rothwell wrote: > &g

Re: linux-next: build warning after merge of the v4l-dvb tree

2021-02-08 Thread Ezequiel Garcia
Hi Stephen, On Mon, 2021-02-08 at 23:37 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the v4l-dvb tree, today's linux-next build (htmldocs) > produced this warning: > > include/media/v4l2-async.h:178: warning: expecting prototype for > v4l2_async_notifier_add_fwnode_subdev().

  1   2   3   4   5   6   7   8   9   10   >