Hi Johan,
On Sun, 11 Apr 2021 at 14:57, Heiko Stübner wrote:
>
> Hi Johan,
>
> Am Sonntag, 11. April 2021, 19:51:52 CEST schrieb Johan Jonker:
> > Hi,
> >
> > When I check "rockchip,gpio-bank" with YAML it turns out that
> > rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property.
> > It is
Add RK3568/RK3566 SoC support to pinctrl.
Signed-off-by: Ezequiel Garcia
---
Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt
b/Documentation/devicetree/bindings
Hi Jianqun,
I tried applying this on top of "pinctrl: rockchip: add support for rk3568",
but I got some conflicts. If you could add some information about
how patches should be applied to the cover letter, that'd be really helpful :-)
Also, I've noticed several of these GPIOs patches, is this
On Fri, 2021-04-09 at 19:25 +0200, Julia Lawall wrote:
>
>
> On Fri, 9 Apr 2021, ascordeiro wrote:
>
> > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu:
> > > Hi Aline,
> >
> > Hi Ezequiel,
> > >
> > > On Fri
On Fri, 2021-04-09 at 14:00 -0300, ascordeiro wrote:
> Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu:
> > Hi Aline,
>
> Hi Ezequiel,
> >
> > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote:
> > > Rewrite macros resembling f
Hi Aline,
On Fri, 2021-04-09 at 09:24 -0300, Aline Santana Cordeiro wrote:
> Aligns line break with the remaining function arguments
> to the open parenthesis. Issue found by checkpatch.
>
> Signed-off-by: Aline Santana Cordeiro
> ---
> Changes since v2:
> - Rename the commit messages properly
Hi Aline,
On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote:
> Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE
> and #define HANTRO_PP_RED_WRITE_S in lower case, according with
> code style.
>
Where is this written in the Coding Style?
Thanks!
Ezequiel
>
Ola Aline,
Welcome to the kernel community. Hope you enjoy some of this
Outreachy adventures.
Normally, when you submit a v2, we want to know what changed
between the first submission and v2.
If you are subscribed to linux-media, you can read some
of the series with a vN+1 and look how it's
-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec-stateless.rst | 218 +
.../media/v4l/ext-ctrls-codec.rst | 219 --
.../media/v4l/pixfmt-compressed.rst | 10 +-
.../media/v4l/vidioc-g-ext-ctrls.rst | 12 +
drivers/media/v4l2-core
Move the MPEG-2 stateless control types out of staging,
and re-number it to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/mpeg2-ctrls.h| 4
include/uapi/linux/videodev2.h | 4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/media
Simply print the type of the control.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 575553ee7e4a..722a208c647e 100644
compatibility.
Note that this would mean introducing a enumerator control to
specify the decoding mode (see V4L2_CID_STATELESS_H264_DECODE_MODE).
Signed-off-by: Ezequiel Garcia
Co-developed-by: Nicolas Dufresne
Signed-off-by: Nicolas Dufresne
---
.../media/v4l/ext-ctrls-codec.rst | 35
in a picture
(with either frame or field structure) to be contained in
the OUTPUT buffer, which means the slice size and offset shouldn't be used.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c | 4 ++--
drivers/staging/media/hantro
The forward and backwards references are specified per-picture
and not per-slice. Move it to V4L2_CID_MPEG_VIDEO_MPEG2_PICTURE.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 28 +--
.../media/hantro/hantro_g1_mpeg2_dec.c| 6
it clashes with existing ones. This is not really an issue
since they will be re-defined when the controls are moved
out of staging.
Signed-off-by: Ezequiel Garcia
Tested-by: Jonas Karlman
---
.../media/v4l/ext-ctrls-codec.rst | 47 ++---
.../media/v4l/pixfmt-compressed.rst
Our current MPEG-2 uAPI uses 1-byte fields for MPEG-2
boolean syntax elements. Clean these by adding a 'flags'
field and flag macro for each boolean syntax element.
A follow-up change will refactor this uAPI so we don't need
to add padding fields just yet.
Signed-off-by: Ezequiel Garcia
Tested
lized by the V4L2 control core to their
reset default value, and applications are expected to reset
their values as specified.
The quantisation control is therefore optional, and used to
load bitstream-defined values in the quantisation matrices.
Signed-off-by: Ezequiel Garcia
Co-developed-by
The MPEG-2 specification refers to the quantisation matrices
using the word "quantisation". Make the V4L2 interface more
ergonomic by matching the MPEG-2 spec.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 16 ++--
.../media/v4l/pixfmt-comp
ion in a flag, which
was fortunately reported by 0day bot.
Ezequiel Garcia (10):
media: uapi: mpeg2: Rename "quantization" to "quantisation"
media: uapi: mpeg2: rework quantisation matrices semantics
media: uapi: mpeg2: Cleanup flags
media: uapi: mpeg2: Split seque
Hi Nicolas,
On Mon, 2021-03-29 at 16:53 -0400, Nicolas Dufresne wrote:
> Le lundi 29 mars 2021 à 15:13 -0300, Ezequiel Garcia a écrit :
> > As stated in the MPEG-2 specification, section 6.3.7 "Quant matrix
> > extension":
> >
> > Each quantisation mat
Hi Benjamin,
Thanks for the patch.
On Thu, 2021-04-01 at 17:59 +0200, Benjamin Gaignard wrote:
> The HEVC HANTRO driver needs to know the number of bits to skip at
> the beginning of the slice header.
> That is a hardware specific requirement so create a dedicated control
> that this purpose.
>
Benjamin Gaignard
> Reviewed-by: Philipp Zabel
Reviewed-by: Ezequiel Garcia
> ---
> version 7:
> - Add Philipp Reviewed-by tag.
>
> version 5:
> - remove useless postproc fields for G2
>
> version 2:
> - remove useless clocks
>
> drivers/staging/media/hantro
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2
> of the driver.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> drivers/staging/media/hantro/hantro_v4l2.c | 1 +
&g
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> If the variant doesn't offert postprocessed formats make sure it will
> be ok.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> drivers/staging/media/hantro/hantro.h | 8 +
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Define which HEVC profiles (up to level 5.1) and features
> (no scaling, no 10 bits) are supported by the driver.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> drivers/staging/med
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Change hantro_codec_ops run prototype from 'void' to 'int'.
> This allow to cancel the job if an error occur while configuring
> the hardware.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
&g
rence picture set".
>
> Adapt Cedrus driver to these changes.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> ---
> version 7:
> - rebased on top of media_tree/master branch
>
> version 6:
> - fix compilation errors
>
On Mon, 2021-03-29 at 08:57 +0200, Benjamin Gaignard wrote:
> Add fields and flags as they are defined in
> 7.4.3.3.1 "General picture parameter set RBSP semantics of the
> H.265 ITU specification.
>
> Signed-off-by: Benjamin Gaignard
Reviewed-by: Ezequiel Garcia
> -
-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec-stateless.rst | 218 +
.../media/v4l/ext-ctrls-codec.rst | 219 --
.../media/v4l/pixfmt-compressed.rst | 10 +-
.../media/v4l/vidioc-g-ext-ctrls.rst | 12 +
drivers/media/v4l2-core
Simply print the type of the control.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 28657f2f679b..063a373c8965 100644
compatibility.
Note that this would mean introducing a enumerator control to
specify the decoding mode (see V4L2_CID_STATELESS_H264_DECODE_MODE).
Signed-off-by: Ezequiel Garcia
Co-developed-by: Nicolas Dufresne
Signed-off-by: Nicolas Dufresne
---
.../media/v4l/ext-ctrls-codec.rst | 35
Move the MPEG-2 stateless control types out of staging,
and re-number it to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/mpeg2-ctrls.h| 4
include/uapi/linux/videodev2.h | 4
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/media
The forward and backwards references are specified per-picture
and not per-slice. Move it to V4L2_CID_MPEG_VIDEO_MPEG2_PICTURE.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 28 +--
.../media/hantro/hantro_g1_mpeg2_dec.c| 6
in a picture
(with either frame or field structure) to be contained in
the OUTPUT buffer, which means the slice size and offset shouldn't be used.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c | 4 ++--
drivers/staging/media/hantro
it clashes with existing ones. This is not really an issue
since they will be re-defined when the controls are moved
out of staging.
Signed-off-by: Ezequiel Garcia
Tested-by: Jonas Karlman
---
.../media/v4l/ext-ctrls-codec.rst | 47 ++---
.../media/v4l/pixfmt-compressed.rst
Our current MPEG-2 uAPI uses 1-byte fields for MPEG-2
boolean syntax elements. Clean these by adding a 'flags'
field and flag macro for each boolean syntax element.
A follow-up change will refactor this uAPI so we don't need
to add padding fields just yet.
Signed-off-by: Ezequiel Garcia
Tested
lized by the V4L2 control core to their
reset default value, and applications are expected to reset
their values as specified.
The quantization control is therefore optional, and used to
load bitstream-defined values in the quantization matrices.
Signed-off-by: Ezequiel Garcia
Co-developed-by
boilerplate fixes for the new
controls to be properly exposed, initialized and validated.
v2:
* Fixed bad use of boolean negation in a flag, which
was fortunately reported by 0day bot.
Ezequiel Garcia (9):
media: uapi: mpeg2: Rework quantization matrices semantics
media: uapi: mpeg2: Cleanup
On Fri, 2021-03-26 at 15:33 +0100, Benjamin Gaignard wrote:
>
> Le 26/03/2021 à 15:24, Philipp Zabel a écrit :
> > On Thu, Mar 18, 2021 at 09:20:46AM +0100, Benjamin Gaignard wrote:
> > > Split VPU node in two: one for G1 and one for G2 since they are
> > > different hardware blocks.
> > > Add
On Tue, 2021-03-16 at 21:19 +0100, Benjamin Gaignard wrote:
>
> Le 16/03/2021 à 19:46, Ezequiel Garcia a écrit :
> > Hi Benjamin,
> >
> > The series is looking really good. Some comments below.
> >
> > On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard
Hi Benjamin,
The series is looking really good. Some comments below.
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote:
> Implement all the logic to get G2 hardware decoding HEVC frames.
> It support up level 5.1 HEVC stream.
> It doesn't support yet 10 bits formats or scaling feature.
Hi Alex,
On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot wrote:
>
> Hi Ezequiel,
>
> On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia
> wrote:
> >
> > Hi Alex,
> >
> > Thanks for the patch.
> >
> > On Fri, 26 Feb 2021 at 07:06, Alexandre
Hi Alexandre,
On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot wrote:
>
> Hi Ezequiel, thanks for the feedback!
>
> On Thu, Mar 4, 2021 at 6:30 AM Ezequiel Garcia
> wrote:
> >
> > Hello Alex,
> >
> > Thanks for the patch.
> >
> > On Fri,
1]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/
[2]
https://gitlab.freedesktop.org/ezequielgarcia/gst-plugins-bad/-/tree/vp8-api-update
[3] https://github.com/fluendo/fluster
Ezequiel Garcia (8):
media: uapi: vp8: Remove "header" from symbol names and mac
, and now
that the API is able to support Cedrus and Hantro G1,
we can consider this ready.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec-stateless.rst | 334 +
.../media/v4l/ext-ctrls-codec.rst | 339 --
.../media/v4l/pixfmt
In preparation for making the interface public,
document all the structures.
Signed-off-by: Ezequiel Garcia
---
include/media/vp8-ctrls.h | 99 +++
1 file changed, 99 insertions(+)
diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h
index
Move the VP8 stateless control types out of staging,
and re-number it to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/vp8-ctrls.h | 1 -
include/uapi/linux/videodev2.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/media/vp8-ctrls.h b
Before we move the VP8 controls to a stable public header,
rename this macro so it's clearly V4L2-specific.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro_g1_vp8_dec.c | 6 +++---
drivers/staging/media/hantro/rk3399_vpu_hw_vp8_dec.c | 6 +++---
drivers/staging
Rename to struct v4l2_vp8_loop_filter, which is closer to the
VP8 syntax. This change is only cosmetics, but since this API
is exposed to userspace, it's worth the trouble to get it consistent.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 12
Simply print the type of the control.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 49bbc06d2bb3..658621b961d5 100644
--- a/drivers
Since we are ready to stabilize the VP8 stateless API,
move the parsed VP8 pixel format.
Signed-off-by: Ezequiel Garcia
---
Documentation/userspace-api/media/v4l/pixfmt-compressed.rst | 5 -
include/media/vp8-ctrls.h | 2 --
include/uapi/linux/videodev2.h
It doesn't seem to add any clarity to have a "header" suffix in controls,
struct names and flags.
Since this just makes names too long without any benefit, just drop it.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 80 +++
.../media/
Hello Alex,
Thanks for the patch.
On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot wrote:
>
> From: Yunfei Dong
>
> Support the stateless codec API that will be used by MT8183.
>
> Signed-off-by: Yunfei Dong
> [acourbot: refactor, cleanup and split]
> Co-developed-by: Alexandre Courbot
>
Hi Alex,
Thanks for the patch.
On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot wrote:
>
> From: Yunfei Dong
>
> Add support for H.264 decoding using the stateless API, as supported by
> MT8183. This support takes advantage of the V4L2 H.264 reference list
> builders.
>
> Signed-off-by: Yunfei
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote:
> Change hantro_codec_ops run prototype from 'void' to 'int'.
> This allow to cancel the job if an error occur while configuring
> the hardware.
>
> Signed-off-by: Benjamin Gaignard
> ---
> drivers/staging/media/hantro/hantro_drv.c
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote:
> Decoders hardware blocks could exist in multiple versions: add
> a field to distinguish them at runtime.
> G2 hardware block doesn't have postprocessor hantro_needs_postproc
> function should always returns false in for this hardware.
>
On Wed, 2021-03-03 at 12:39 +0100, Benjamin Gaignard wrote:
> Add variant to IMX8M to enable G2/HEVC codec.
> Define the capabilities for the hardware up to 3840x2160.
> Retrieve the hardware version at init to distinguish G1 from G2.
>
> Signed-off-by: Benjamin Gaignard
> ---
> version 2:
> -
, and now
that the API is able to support Cedrus and Hantro G1,
we can consider this ready.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec-stateless.rst | 318 +
.../media/v4l/ext-ctrls-codec.rst | 323 --
.../media/v4l/pixfmt
Before we move the VP8 controls to a stable public header,
rename this macro so it's clearly V4L2-specific.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro_g1_vp8_dec.c | 6 +++---
drivers/staging/media/hantro/rk3399_vpu_hw_vp8_dec.c | 6 +++---
drivers/staging
Simply print the type of the control.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 1a683f4fa978..0fc7180a47e9 100644
--- a/drivers
Move the VP8 stateless control types out of staging,
and re-number it to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/vp8-ctrls.h | 1 -
include/uapi/linux/videodev2.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/media/vp8-ctrls.h b
Since we are ready to stabilize the VP8 stateless API,
move the parsed VP8 pixel format.
Signed-off-by: Ezequiel Garcia
---
Documentation/userspace-api/media/v4l/pixfmt-compressed.rst | 5 -
include/media/vp8-ctrls.h | 2 --
include/uapi/linux/videodev2.h
In preparation for making the interface public,
document all the structures.
Signed-off-by: Ezequiel Garcia
---
include/media/vp8-ctrls.h | 99 +++
1 file changed, 99 insertions(+)
diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h
index
It doesn't seem to add any clarity to have a "header" suffix in controls,
struct names and flags.
Since this just makes names too long without any benefit, just drop it.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 80 +++
.../media/
Rename to struct v4l2_vp8_loop_filter, which is closer to the
VP8 syntax. This change is only cosmetics, but since this API
is exposed to userspace, it's worth the trouble to get it consistent.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 12
as-is.
This was tested with GStreamer v4l2codec element and Fluster [2]
conformance test, on a Hantro G1 device.
Changelog:
v2: * Rename VP8_FRAME_IS_KEY_FRAME
[1]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/
[2] https://github.com/fluendo/fluster
Ezequiel Garcia (8
Simply print the type of the control.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 1a683f4fa978..0fc7180a47e9 100644
--- a/drivers
, and now
that the API is able to support Cedrus and Hantro G1,
we can consider this ready.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec-stateless.rst | 318 +
.../media/v4l/ext-ctrls-codec.rst | 323 --
.../media/v4l/pixfmt
In preparation for making the interface public,
document all the structures.
Signed-off-by: Ezequiel Garcia
---
include/media/vp8-ctrls.h | 99 +++
1 file changed, 99 insertions(+)
diff --git a/include/media/vp8-ctrls.h b/include/media/vp8-ctrls.h
index
Rename to struct v4l2_vp8_loop_filter, which is closer to the
VP8 syntax. This change is only cosmetics, but since this API
is exposed to userspace, it's worth the trouble to get it consistent.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/ext-ctrls-codec.rst | 12
Move the VP8 stateless control types out of staging,
and re-number it to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/vp8-ctrls.h | 1 -
include/uapi/linux/videodev2.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/media/vp8-ctrls.h b
Since we are ready to stabilize the VP8 stateless API,
move the parsed VP8 pixel format.
Signed-off-by: Ezequiel Garcia
---
Documentation/userspace-api/media/v4l/pixfmt-compressed.rst | 5 -
include/media/vp8-ctrls.h | 2 --
include/uapi/linux/videodev2.h
as-is.
This was tested with GStreamer v4l2codec element and Fluster [2]
conformance test, on a Hantro G1 device.
[1]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2614338/21/
[2] https://github.com/fluendo/fluster
Ezequiel Garcia (7):
media: uapi: vp8: Remove "header" f
It doesn't seem to add any clarity to have a "header" suffix in controls,
struct names and flags.
Since this just makes names too long without any benefit, just drop it.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 80 +++
.../media/
Hello everyone,
On Mon, 1 Mar 2021 at 14:36, Fabrizio Castro
wrote:
>
> Hi Arnd,
>
> Thanks for your feedback!
>
> > From: Arnd Bergmann
> > Sent: 26 February 2021 10:38
> > Subject: Re: [PATCH 4/7] misc: Add driver for DAB IP found on Renesas R-
> > Car devices
> >
> > On Thu, Feb 25, 2021 at
On Fri, 2021-02-26 at 10:47 +0100, Benjamin Gaignard wrote:
>
> Le 25/02/2021 à 18:55, Ezequiel Garcia a écrit :
> > Hi Benjamin,
> >
> > Thanks for the good work!
> > I mostly have two concerns with this implementation,
> > the tiled output and the
Hi Enric,
Thanks a lot for the patch.
On Thu, 25 Feb 2021 at 09:08, Enric Balletbo i Serra
wrote:
>
> The AXI ID is an AXI bus configuration for improve bus performance. If
> read and write operations use different ID the operations can be
> paralleled, whereas when they have the same ID the
Hi Benjamin,
Thanks for the good work!
I mostly have two concerns with this implementation,
the tiled output and the allocation path.
More below.
On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote:
> Implement all the logic to get G2 hardware decoding HEVC frames.
> It support up level
Hey Jernej,
On Thu, 2021-02-25 at 18:01 +0100, Jernej Škrabec wrote:
> Hi Ezequiel,
>
> Dne četrtek, 25. februar 2021 ob 14:09:52 CET je Ezequiel Garcia napisal(a):
> > Hi Benjamin,
> >
> > Thanks for the good work.
> >
> > On Mon, 2021-02-22
Hi Benjamin,
On Mon, 2021-02-22 at 13:24 +0100, Benjamin Gaignard wrote:
> The HEVC HANTRO driver needs to know the number of bits to skip at
s/HANTRO/Hantro
> the beginning of the slice header.
As discussed in a different thread, we should describe exactly
what the hardware is expecting, so
Hi Benjamin,
Thanks for the good work.
On Mon, 2021-02-22 at 13:23 +0100, Benjamin Gaignard wrote:
> The H.265 ITU specification (section 7.4) define the general
> slice segment header semantics.
> Modified/added fields are:
> - video_parameter_set_id: (7.4.3.1) identifies the VPS for
>
On Mon, 2021-02-22 at 13:23 +0100, Benjamin Gaignard wrote:
> Define which HEVC profiles (up to level 5.1) and features
> (no scaling, no 10 bits) are supported by the driver.
>
> Signed-off-by: Benjamin Gaignard
> ---
> drivers/staging/media/hantro/hantro.h | 2 +
>
tags.
commit 494adacd844e5656b570895a82bc343438b23023
Author: Adrian Ratiu
Date: Thu Feb 18 12:17:37 2021 +0100
media: hantro: Introduce G2/HEVC decoder
...
Signed-off-by: Adrian Ratiu
Co-developed-by: Ezequiel Garcia
Signed-off-by: Ezequiel Garcia
Co-developed-by: Benj
Hi Rob,
On Tue, 2021-02-23 at 08:31 -0600, Rob Herring wrote:
> On Tue, Feb 23, 2021 at 2:04 AM Benjamin Gaignard
> wrote:
> >
> >
> > Le 23/02/2021 à 01:34, Rob Herring a écrit :
> > > On Mon, Feb 22, 2021 at 01:24:05PM +0100, Benjamin Gaignard wrote:
> > > > The current bindings seem to make
On Mon, 2021-02-22 at 17:28 +0100, Benjamin Gaignard wrote:
>
> Le 22/02/2021 à 17:16, John Cox a écrit :
> > > The HEVC HANTRO driver needs to know the number of bits to skip at
> > > the beginning of the slice header.
> > > That is a hardware specific requirement so create a dedicated control
>
ot;drm/bridge/synopsys: dsi: add support for
non-continuous HS clock")
Cc: sta...@vger.kernel.org # 5.10+
With this fix, my Odroid Go2 has display.
Tested-by: Ezequiel Garcia
Thanks,
Ezequiel
> Signed-off-by: Heiko Stuebner
> ---
> drivers/gpu/drm/panel/panel-elida-kd35t133.c | 3 ++-
&g
rom the stream that only the userland knows so let it
> provide the correct value to the driver.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> drivers/staging/media/hantro/Makefile | 2 +
> dri
On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote:
> Split VPU node in two: one for G1 and one for G2 since they are
> different hardware blocks.
>
> Signed-off-by: Benjamin Gaignard
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 43 +--
> 1 file changed, 33
ff-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> drivers/staging/media/hantro/hantro.h | 24
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/staging/media/hantro/hantro.h
> b/driver
Hi Benjamin,
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote:
> Add help functions to retrieve buffer address and size.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> drivers/staging/media
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote:
> Decoders hardware blocks could exist in multiple versions: add
> a field to distinguish them at runtime.
> Keep the default behavoir to be G1 hardware.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequie
On Wed, 2021-02-17 at 09:03 +0100, Benjamin Gaignard wrote:
> Make sure that V4L2_PIX_FMT_HEVC_SLICE is correctly handle by v4l2
> of the driver.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> driv
drop this patch.
Thanks,
Ezequiel
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> drivers/staging/media/hantro/hantro_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging
Hi Benjamin,
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote:
> Add HEVC decode params and scaling matrix controls.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
> Signed-off-by: Adrian Ratiu
> ---
> drivers/media/v4l2-c
w structures
>
So this commit description needs some more information.
See commit d9358563179a7f01f9020ebbe201c7e54ba3af48
Author: Ezequiel Garcia
Date: Tue Aug 25 05:52:36 2020 +0200
media: uapi: h264: Clean slice invariants syntax elements
which explains why it's OK to move some fields o
Hi Benjamin,
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote:
> Define allocation range for the default CMA region.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by: Ezequiel Garcia
Despite it seems like I signed-off this one...
> Signed-off-by: Adrian Ratiu
Hello Benjamin,
Thanks a lot for the patch.
On Wed, 2021-02-17 at 09:02 +0100, Benjamin Gaignard wrote:
> Define which HEVC profiles (up to level 5.1) and features
> (no scaling, no 10 bits) are supported by the driver.
>
> Signed-off-by: Benjamin Gaignard
> Signed-off-by:
On Mon, 2021-02-08 at 18:40 +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 08 Feb 2021 13:57:56 -0300
> Ezequiel Garcia escreveu:
>
> > On Mon, 2021-02-08 at 18:46 +0200, Sakari Ailus wrote:
> > > Hi Ezequiel,
> > >
> > > Thanks for addressing this.
On Mon, 2021-02-08 at 18:46 +0200, Sakari Ailus wrote:
> Hi Ezequiel,
>
> Thanks for addressing this.
>
> On Mon, Feb 08, 2021 at 01:42:21PM -0300, Ezequiel Garcia wrote:
> > Hi Stephen,
> >
> > On Mon, 2021-02-08 at 23:37 +1100, Stephen Rothwell wrote:
> &g
Hi Stephen,
On Mon, 2021-02-08 at 23:37 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the v4l-dvb tree, today's linux-next build (htmldocs)
> produced this warning:
>
> include/media/v4l2-async.h:178: warning: expecting prototype for
> v4l2_async_notifier_add_fwnode_subdev().
1 - 100 of 1882 matches
Mail list logo