Re: [PATCH v2 1/4] arm64: dts: rockchip: Split out common nodes for Rock960 based boards

2018-09-11 Thread Ezequiel Garcia
st>; }; Also, I believe it would be good to have some more details in this commit log. The information on the cover letter is great, so I'd just repeat some of that here. Other than that, for the ficus bits: Reviewed-by: Ezequiel Garcia Thanks very much for this work! Ezequiel > Signed

Re: [PATCH v2 1/4] arm64: dts: rockchip: Split out common nodes for Rock960 based boards

2018-09-11 Thread Ezequiel Garcia
st>; }; Also, I believe it would be good to have some more details in this commit log. The information on the cover letter is great, so I'd just repeat some of that here. Other than that, for the ficus bits: Reviewed-by: Ezequiel Garcia Thanks very much for this work! Ezequiel > Signed

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-28 Thread Ezequiel Garcia
On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote: > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only

Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

2018-08-28 Thread Ezequiel Garcia
On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote: > This introduces the Cedrus VPU driver that supports the VPU found in > Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only

Re: [PATCH v1] arm64: dts: rockchip: add support for ROC-RK3399-PC board

2018-07-26 Thread Ezequiel Garcia
On Thu, 2018-07-26 at 15:13 +0800, d...@t-chip.com.cn wrote: > From: Levin Du > > ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board > computer with USB 3.0 and Gigabit Ethernet in a form factor > compatible with the Raspberry Pi. It is based on the Rockchip > RK3399 SoC, powered by the

Re: [PATCH v1] arm64: dts: rockchip: add support for ROC-RK3399-PC board

2018-07-26 Thread Ezequiel Garcia
On Thu, 2018-07-26 at 15:13 +0800, d...@t-chip.com.cn wrote: > From: Levin Du > > ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board > computer with USB 3.0 and Gigabit Ethernet in a form factor > compatible with the Raspberry Pi. It is based on the Rockchip > RK3399 SoC, powered by the

Re: [PATCH v3] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-06-22 Thread Ezequiel Garcia
Hey Akhil, On Fri, 2018-06-22 at 12:33 +0530, Akhil P Oommen wrote: > On 6/22/2018 6:41 AM, Ezequiel Garcia wrote: > > Hey Enric, > > > > On Fri, 2018-06-22 at 00:04 +0200, Enric Balletbo i Serra wrote: > > > When the devfreq driver and the governor dri

Re: [PATCH v3] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-06-22 Thread Ezequiel Garcia
Hey Akhil, On Fri, 2018-06-22 at 12:33 +0530, Akhil P Oommen wrote: > On 6/22/2018 6:41 AM, Ezequiel Garcia wrote: > > Hey Enric, > > > > On Fri, 2018-06-22 at 00:04 +0200, Enric Balletbo i Serra wrote: > > > When the devfreq driver and the governor dri

Re: [PATCH v3] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-06-21 Thread Ezequiel Garcia
Hey Enric, On Fri, 2018-06-22 at 00:04 +0200, Enric Balletbo i Serra wrote: > When the devfreq driver and the governor driver are built as modules, > the call to devfreq_add_device() or governor_store() fails because > the > governor driver is not loaded at the time the devfreq driver loads. >

Re: [PATCH v3] PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.

2018-06-21 Thread Ezequiel Garcia
Hey Enric, On Fri, 2018-06-22 at 00:04 +0200, Enric Balletbo i Serra wrote: > When the devfreq driver and the governor driver are built as modules, > the call to devfreq_add_device() or governor_store() fails because > the > governor driver is not loaded at the time the devfreq driver loads. >

Re: [PATCH v8 03/14] iommu/rockchip: Request irqs in rk_iommu_probe()

2018-05-24 Thread Ezequiel Garcia
Hey Jeffy, Robin: Some odd issues to report here. On 23 March 2018 at 04:38, Jeffy Chen wrote: > Move request_irq to the end of rk_iommu_probe(). > > Suggested-by: Robin Murphy > Signed-off-by: Jeffy Chen > Acked-by:

Re: [PATCH v8 03/14] iommu/rockchip: Request irqs in rk_iommu_probe()

2018-05-24 Thread Ezequiel Garcia
Hey Jeffy, Robin: Some odd issues to report here. On 23 March 2018 at 04:38, Jeffy Chen wrote: > Move request_irq to the end of rk_iommu_probe(). > > Suggested-by: Robin Murphy > Signed-off-by: Jeffy Chen > Acked-by: Robin Murphy > --- > > Changes in v8: None > Changes in v7: None > Changes

Re: [PATCH v10 08/16] v4l: mark unordered formats

2018-05-23 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 13:55 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > > mark the appropriate formats. >

Re: [PATCH v10 08/16] v4l: mark unordered formats

2018-05-23 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 13:55 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > > mark the appropriate formats. > > > > v2: Set unordered

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 18:48 +0200, Hans Verkuil wrote: > On 22/05/18 18:22, Ezequiel Garcia wrote: > > > > @@ -1615,7 +1762,12 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) > > > > return; > > > > > > &

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 18:48 +0200, Hans Verkuil wrote: > On 22/05/18 18:22, Ezequiel Garcia wrote: > > > > @@ -1615,7 +1762,12 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) > > > > return; > > > > > > &

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 14:37 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the bu

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-22 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 14:37 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queu

Re: [PATCH v10 11/16] vb2: add explicit fence user API

2018-05-22 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 14:05 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Turn the reserved2 field into fence_fd that we will use to send > > an in-fence to the kernel or re

Re: [PATCH v10 11/16] vb2: add explicit fence user API

2018-05-22 Thread Ezequiel Garcia
On Tue, 2018-05-22 at 14:05 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Turn the reserved2 field into fence_fd that we will use to send > > an in-fence to the kernel or return an out-fence from the kernel to

[PATCH v10 03/16] hackrf: group device capabilities

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE everywhere, set device_caps earlier with these values. Signed-off-by: Gustavo Padovan --- drivers/media/usb/hackrf/hackrf.c | 11 --- 1 file

[PATCH v10 03/16] hackrf: group device capabilities

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE everywhere, set device_caps earlier with these values. Signed-off-by: Gustavo Padovan --- drivers/media/usb/hackrf/hackrf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH v10 04/16] omap3isp: group device capabilities

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps earlier with this value. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v10 04/16] omap3isp: group device capabilities

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps earlier with this value. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan --- drivers/media/platform/omap3isp/ispvideo.c | 10 ++ 1 file changed, 6

[PATCH v10 06/16] vb2: add is_unordered callback for drivers

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Explicit synchronization benefits a lot from ordered queues, they fit better in a pipeline with DRM for example so create a opt-in way for drivers notify videobuf2 that the queue is unordered. Drivers don't need implement it if the queue is

[PATCH v10 06/16] vb2: add is_unordered callback for drivers

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Explicit synchronization benefits a lot from ordered queues, they fit better in a pipeline with DRM for example so create a opt-in way for drivers notify videobuf2 that the queue is unordered. Drivers don't need implement it if the queue is ordered. v5: rename it to

[PATCH v10 11/16] vb2: add explicit fence user API

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used when sending an in-fence to

[PATCH v10 11/16] vb2: add explicit fence user API

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used when sending an in-fence to the kernel to be waited on, and

[PATCH v10 10/16] vb2: mark codec drivers as unordered

2018-05-21 Thread Ezequiel Garcia
rivers as unordered (Nicolas and Hans) Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/media/platform/coda/coda-common.c | 1 + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1 + drivers/media/p

[PATCH v10 10/16] vb2: mark codec drivers as unordered

2018-05-21 Thread Ezequiel Garcia
) Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/platform/coda/coda-common.c | 1 + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1 + drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 1 + drivers/media/platform/qcom/venus/vdec.c | 1

[PATCH v10 13/16] vb2: add out-fence support to QBUF

2018-05-21 Thread Ezequiel Garcia
e pending (Hans) - call fd_install() after vb2_core_qbuf() (Hans) - clean up fence if vb2_core_qbuf() fails (Hans) - add list to store sync_file and fence for the next queued buffer v2: check if the queue is ordered. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Si

[PATCH v10 13/16] vb2: add out-fence support to QBUF

2018-05-21 Thread Ezequiel Garcia
l() after vb2_core_qbuf() (Hans) - clean up fence if vb2_core_qbuf() fails (Hans) - add list to store sync_file and fence for the next queued buffer v2: check if the queue is ordered. Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/common/videobuf2/videobu

[PATCH v10 15/16] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-21 Thread Ezequiel Garcia
rycap. v9: Add in the core. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/media/platform/exynos-gsc/gsc-m2m.c| 3 ++- drivers/media/platform/m2m-deinterlace.c | 3 ++- drivers/m

[PATCH v10 15/16] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-21 Thread Ezequiel Garcia
off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/platform/exynos-gsc/gsc-m2m.c| 3 ++- drivers/media/platform/m2m-deinterlace.c | 3 ++- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 3 ++- .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c |

[PATCH v10 16/16] v4l: Document explicit synchronization behavior

2018-05-21 Thread Ezequiel Garcia
(Hans) - Note what happens when the IN_FENCE is not set (Hans) v2: - mention that fences are files (Hans) - rework for the new API Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- Documentation/media/uapi/v

[PATCH v10 16/16] v4l: Document explicit synchronization behavior

2018-05-21 Thread Ezequiel Garcia
the IN_FENCE is not set (Hans) v2: - mention that fences are files (Hans) - rework for the new API Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- Documentation/media/uapi/v4l/vidioc-qbuf.rst | 53 +++- Documentation/media/uapi/v4l/vidioc-querybuf.rst | 12

[PATCH v10 14/16] v4l: introduce the fences capability

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers capable of using fences (vb2 drivers) should report the V4L2_CAP_FENCES to userspace, so add this flag to the uapi. v2: minor doc/english fix (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v10 14/16] v4l: introduce the fences capability

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers capable of using fences (vb2 drivers) should report the V4L2_CAP_FENCES to userspace, so add this flag to the uapi. v2: minor doc/english fix (Hans Verkuil) Signed-off-by: Gustavo Padovan --- Documentation/media/uapi/v4l/vidioc-querycap.rst | 3 +++

[PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-21 Thread Ezequiel Garcia
queueing, start from the first ready buffer - handle queue cancel Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/media/common/videobuf2/Kconfig | 1 + drivers/media/common/video

[PATCH v10 12/16] vb2: add in-fence support to QBUF

2018-05-21 Thread Ezequiel Garcia
dy buffer - handle queue cancel Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/common/videobuf2/Kconfig | 1 + drivers/media/common/videobuf2/videobuf2-core.c | 224 drivers/media/common/videobuf2/videobuf2-v4l2.c | 37 +++-

[PATCH v10 09/16] cobalt: add .is_unordered() for cobalt

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan <gustavo.pado...@collabora.com> The cobalt driver may reorder the capture buffers so we need to report it as such. v3: set formats as unordered v2: use vb2_ops_set_unordered() helper Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-

[PATCH v10 09/16] cobalt: add .is_unordered() for cobalt

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan The cobalt driver may reorder the capture buffers so we need to report it as such. v3: set formats as unordered v2: use vb2_ops_set_unordered() helper Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/pci/cobalt/cobalt-v4l2.c | 4 1

[PATCH v10 08/16] v4l: mark unordered formats

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan <gustavo.pado...@collabora.com> Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, mark the appropriate formats. v2: Set unordered flag before calling the driver callback. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-

[PATCH v10 08/16] v4l: mark unordered formats

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, mark the appropriate formats. v2: Set unordered flag before calling the driver callback. Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ioctl.c | 74

[PATCH v10 05/16] vb2: move vb2_ops functions to videobuf2-core.[ch]

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the wrong file. Signed-off-by: Gustavo Padovan --- drivers/media/common/videobuf2/videobuf2-core.c | 14 ++

[PATCH v10 05/16] vb2: move vb2_ops functions to videobuf2-core.[ch]

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the wrong file. Signed-off-by: Gustavo Padovan --- drivers/media/common/videobuf2/videobuf2-core.c | 14 ++ drivers/media/common/videobuf2/videobuf2-v4l2.c | 14 --

[PATCH v10 07/16] v4l: add unordered flag to format description ioctl

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan For explicit synchronization it important for userspace to know if the format being used by the driver can deliver the buffers back to userspace in the same order they were queued with QBUF. Ordered streams fits nicely in a pipeline with DRM

[PATCH v10 07/16] v4l: add unordered flag to format description ioctl

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan For explicit synchronization it important for userspace to know if the format being used by the driver can deliver the buffers back to userspace in the same order they were queued with QBUF. Ordered streams fits nicely in a pipeline with DRM for example, where ordered

[PATCH v10 02/16] xilinx: regroup caps on querycap

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan To better organize the code we concentrate the setting of V4L2_CAP_STREAMING in one place. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v10 02/16] xilinx: regroup caps on querycap

2018-05-21 Thread Ezequiel Garcia
From: Gustavo Padovan To better organize the code we concentrate the setting of V4L2_CAP_STREAMING in one place. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan --- drivers/media/platform/xilinx/xilinx-dma.c | 10 ++ 1 file changed, 6

[PATCH v10 01/16] videobuf2: Make struct vb2_buffer refcounted

2018-05-21 Thread Ezequiel Garcia
contexts. Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/media/common/videobuf2/videobuf2-core.c | 27 ++--- include/media/videobuf2-core.h | 7 +-- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/media/

[PATCH v10 01/16] videobuf2: Make struct vb2_buffer refcounted

2018-05-21 Thread Ezequiel Garcia
contexts. Signed-off-by: Ezequiel Garcia --- drivers/media/common/videobuf2/videobuf2-core.c | 27 ++--- include/media/videobuf2-core.h | 7 +-- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b

[PATCH v10 00/16] V4L2 Explicit Synchronization

2018-05-21 Thread Ezequiel Garcia
NCES check. * Minor documentation changes. Ezequiel Garcia (1): videobuf2: Make struct vb2_buffer refcounted Gustavo Padovan (15): xilinx: regroup caps on querycap hackrf: group device capabilities omap3isp: group device capabilities vb2: move vb2_ops functions to videobuf2-core.[ch]

[PATCH v10 00/16] V4L2 Explicit Synchronization

2018-05-21 Thread Ezequiel Garcia
NCES check. * Minor documentation changes. Ezequiel Garcia (1): videobuf2: Make struct vb2_buffer refcounted Gustavo Padovan (15): xilinx: regroup caps on querycap hackrf: group device capabilities omap3isp: group device capabilities vb2: move vb2_ops functions to videobuf2-core.[ch]

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 17:33 +0100, Brian Starkey wrote: > On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: > > On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > > > Hi Ezequiel, > > > > > > On Fri, May 04, 2018 at 05:06:07PM -0300,

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 17:33 +0100, Brian Starkey wrote: > On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: > > On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > > > Hi Ezequiel, > > > > > > On Fri, May 04, 2018 at 05:06:07PM -0300,

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 17:33 +0100, Brian Starkey wrote: > On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: > > On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > > > Hi Ezequiel, > > > > > > On Fri, May 04, 2018 at 05:06:07PM -0300,

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 17:33 +0100, Brian Starkey wrote: > On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: > > On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > > > Hi Ezequiel, > > > > > > On Fri, May 04, 2018 at 05:06:07PM -0300,

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, > > void *pb) > > b->timestamp = ns_to_timeval(vb->timestamp); > > b->timecode = vbuf->timecode; > > b->sequence = vbuf->sequence; > > -

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, > > void *pb) > > b->timestamp = ns_to_timeval(vb->timestamp); > > b->timecode = vbuf->timecode; > > b->sequence = vbuf->sequence; > > -

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > Hi Ezequiel, > > On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Turn the reserved2 field into fence_fd that we

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > Hi Ezequiel, > > On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Turn the reserved2 field into fence_fd that we will use to send > > an in-fence to the k

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-08 Thread Ezequiel Garcia
On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the bu

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-08 Thread Ezequiel Garcia
On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queu

[PATCH v9 04/15] vb2: move vb2_ops functions to videobuf2-core.[ch]

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the wrong file. Signed-off-by: Gustavo Padovan --- drivers/media/common/videobuf2/videobuf2-core.c | 14 ++

[PATCH v9 04/15] vb2: move vb2_ops functions to videobuf2-core.[ch]

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan vb2_ops_wait_prepare() and vb2_ops_wait_finish() were in the wrong file. Signed-off-by: Gustavo Padovan --- drivers/media/common/videobuf2/videobuf2-core.c | 14 ++ drivers/media/common/videobuf2/videobuf2-v4l2.c | 14 --

[PATCH v9 07/15] v4l: mark unordered formats

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, mark the appropriate formats. Signed-off-by: Gustavo Padovan --- drivers/media/v4l2-core/v4l2-ioctl.c | 55 1

[PATCH v9 07/15] v4l: mark unordered formats

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, mark the appropriate formats. Signed-off-by: Gustavo Padovan --- drivers/media/v4l2-core/v4l2-ioctl.c | 55 1 file changed, 30 insertions(+), 25 deletions(-) diff --git

[PATCH v9 01/15] xilinx: regroup caps on querycap

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan To better organize the code we concentrate the setting of V4L2_CAP_STREAMING in one place. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v9 01/15] xilinx: regroup caps on querycap

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan To better organize the code we concentrate the setting of V4L2_CAP_STREAMING in one place. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan --- drivers/media/platform/xilinx/xilinx-dma.c | 10 ++ 1 file changed, 6

[PATCH v9 02/15] hackrf: group device capabilities

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE everywhere, set device_caps earlier with these values. Signed-off-by: Gustavo Padovan --- drivers/media/usb/hackrf/hackrf.c | 11 --- 1 file

[PATCH v9 02/15] hackrf: group device capabilities

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE everywhere, set device_caps earlier with these values. Signed-off-by: Gustavo Padovan --- drivers/media/usb/hackrf/hackrf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH v9 08/15] cobalt: set queue as unordered

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan <gustavo.pado...@collabora.com> The cobalt driver may reorder the capture buffers so we need to report it as such. v3: set unordered as a property v2: use vb2_ops_set_unordered() helper Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-

[PATCH v9 08/15] cobalt: set queue as unordered

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan The cobalt driver may reorder the capture buffers so we need to report it as such. v3: set unordered as a property v2: use vb2_ops_set_unordered() helper Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/pci/cobalt/cobalt-v4l2.c | 1 + 1

[PATCH v9 09/15] vb2: mark codec drivers as unordered

2018-05-04 Thread Ezequiel Garcia
nstead of callback v2: mark only codec drivers as unordered (Nicolas and Hans) Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 2 ++ drivers/media/platform/mtk-vcodec/mt

[PATCH v9 09/15] vb2: mark codec drivers as unordered

2018-05-04 Thread Ezequiel Garcia
as unordered (Nicolas and Hans) Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 2 ++ drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 1 + drivers/media/platform/qcom/venus/venc.c | 2 ++ drivers/media/platform

[PATCH v9 13/15] v4l: introduce the fences capability

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers capable of using fences (vb2 drivers) should report the V4L2_CAP_FENCES to userspace, so add this flag to the uapi. v2: minor doc/english fix (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v9 13/15] v4l: introduce the fences capability

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers capable of using fences (vb2 drivers) should report the V4L2_CAP_FENCES to userspace, so add this flag to the uapi. v2: minor doc/english fix (Hans Verkuil) Signed-off-by: Gustavo Padovan --- Documentation/media/uapi/v4l/vidioc-querycap.rst | 3 +++

[PATCH v9 15/15] v4l: Document explicit synchronization behavior

2018-05-04 Thread Ezequiel Garcia
s when the IN_FENCE is not set (Hans) v2: - mention that fences are files (Hans) - rework for the new API Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- Documentation/media/uapi/v4l/vidioc

[PATCH v9 15/15] v4l: Document explicit synchronization behavior

2018-05-04 Thread Ezequiel Garcia
: - mention that fences are files (Hans) - rework for the new API Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- Documentation/media/uapi/v4l/vidioc-qbuf.rst | 54 +++- Documentation/media/uapi/v4l/vidioc-querybuf.rst | 12 -- 2 files changed, 62

[PATCH v9 14/15] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan <gustavo.pado...@collabora.com> Drivers that use videobuf2 are capable of using fences and should report that to userspace. v9: Add in the core. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ..

[PATCH v9 14/15] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Drivers that use videobuf2 are capable of using fences and should report that to userspace. v9: Add in the core. Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ioctl.c | 8 include/media/v4l2-fh.h

[PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
store sync_file and fence for the next queued buffer v2: check if the queue is ordered. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora.com> --- drivers/media/common/videobuf2/videobuf2-core.c | 95

[PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
- remove check for VB2_MEMORY_DMABUF only (Javier) - check num of ready buffers to start streaming - when queueing, start from the first ready buffer - handle queue cancel Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Ezequiel Garcia <ezequ...@collabora

[PATCH v9 06/15] v4l: add unordered flag to format description ioctl

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan For explicit synchronization it important for userspace to know if the format being used by the driver can deliver the buffers back to userspace in the same order they were queued with QBUF. Ordered streams fits nicely in a pipeline with DRM

[PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
xt queued buffer v2: check if the queue is ordered. Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/common/videobuf2/videobuf2-core.c | 95 +++-- drivers/media/common/videobuf2/videobuf2-v4l2.c | 22 +- drivers/media/dvb-core/

[PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-04 Thread Ezequiel Garcia
y (Javier) - check num of ready buffers to start streaming - when queueing, start from the first ready buffer - handle queue cancel Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- drivers/media/common/videobuf2/videobuf2-core.c | 197 drivers/med

[PATCH v9 06/15] v4l: add unordered flag to format description ioctl

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan For explicit synchronization it important for userspace to know if the format being used by the driver can deliver the buffers back to userspace in the same order they were queued with QBUF. Ordered streams fits nicely in a pipeline with DRM for example, where ordered

[PATCH v9 05/15] vb2: add unordered vb2_queue property for drivers

2018-05-04 Thread Ezequiel Garcia
operty for the unordered property. v4: rename it to vb2_ops_is_unordered() (Hans Verkuil) v3: - make it bool (Hans) - create vb2_ops_set_unordered() helper v2: improve comments for is_unordered flag (Hans Verkuil) Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> Signed-off-by: Eze

[PATCH v9 10/15] vb2: add explicit fence user API

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used when sending an in-fence to

[PATCH v9 05/15] vb2: add unordered vb2_queue property for drivers

2018-05-04 Thread Ezequiel Garcia
it to vb2_ops_is_unordered() (Hans Verkuil) v3: - make it bool (Hans) - create vb2_ops_set_unordered() helper v2: improve comments for is_unordered flag (Hans Verkuil) Signed-off-by: Gustavo Padovan Signed-off-by: Ezequiel Garcia --- include/media/videobuf2-core.h | 3 +++ 1 file changed, 3

[PATCH v9 10/15] vb2: add explicit fence user API

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used when sending an in-fence to the kernel to be waited on, and

[PATCH v9 03/15] omap3isp: group device capabilities

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps earlier with this value. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan ---

[PATCH v9 03/15] omap3isp: group device capabilities

2018-05-04 Thread Ezequiel Garcia
From: Gustavo Padovan Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps earlier with this value. v2: move cap->capabilities assignment down (Hans Verkuil) Signed-off-by: Gustavo Padovan --- drivers/media/platform/omap3isp/ispvideo.c | 10 ++ 1 file changed, 6

[PATCH v9 00/15] V4L2 Explicit Synchronization

2018-05-04 Thread Ezequiel Garcia
Hi all, Gustavo has asked to me to take care of the final issues with this series. I'm working on adding some fences tests to v4l2-compliance, which I'll be posting shortly. So, here's a new version of the "video4linux meet fences" series. This new round hopefully addresses all the feedback

[PATCH v9 00/15] V4L2 Explicit Synchronization

2018-05-04 Thread Ezequiel Garcia
Hi all, Gustavo has asked to me to take care of the final issues with this series. I'm working on adding some fences tests to v4l2-compliance, which I'll be posting shortly. So, here's a new version of the "video4linux meet fences" series. This new round hopefully addresses all the feedback

Re: [PATCH v8 10/13] [media] vb2: add out-fence support to QBUF

2018-04-30 Thread Ezequiel Garcia
Hi guys, I've a couple questions. On 9 March 2018 at 14:49, Gustavo Padovan wrote: > From: Gustavo Padovan > > If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create > an out_fence and send its fd to userspace on the fence_fd

Re: [PATCH v8 10/13] [media] vb2: add out-fence support to QBUF

2018-04-30 Thread Ezequiel Garcia
Hi guys, I've a couple questions. On 9 March 2018 at 14:49, Gustavo Padovan wrote: > From: Gustavo Padovan > > If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create > an out_fence and send its fd to userspace on the fence_fd field as a > return arg for the QBUF call. > > The

Re: [PATCH v8 09/13] [media] vb2: add in-fence support to QBUF

2018-04-25 Thread Ezequiel Garcia
On 14 March 2018 at 12:55, Hans Verkuil wrote: > On 03/09/2018 09:49 AM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Receive in-fence from userspace and add support for waiting on them >> before queueing the buffer to the driver.

Re: [PATCH v8 09/13] [media] vb2: add in-fence support to QBUF

2018-04-25 Thread Ezequiel Garcia
On 14 March 2018 at 12:55, Hans Verkuil wrote: > On 03/09/2018 09:49 AM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Receive in-fence from userspace and add support for waiting on them >> before queueing the buffer to the driver. Buffers can't be queued to the >> driver before its

<    2   3   4   5   6   7   8   9   10   11   >