[PATCH V2 4/5 net-next] vxlan: check rtnl_configure_link return code correctly

2020-09-25 Thread Fabian Frederick
rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxla

[PATCH V2 5/5 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

2020-09-25 Thread Fabian Frederick
Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++

[PATCH V2 2/5 net-next] vxlan: add unlikely to vxlan_remcsum check

2020-09-25 Thread Fabian Frederick
small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/drivers

[PATCH V2 3/5 net-next] vxlan: move encapsulation warning

2020-09-25 Thread Fabian Frederick
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers

[PATCH V2 1/5 net-next] vxlan: don't collect metadata if remote checksum is wrong

2020-09-25 Thread Fabian Frederick
call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c

[PATCH V2 0/5 net-next] vxlan: clean-up

2020-09-25 Thread Fabian Frederick
This small patchet does some clean-up on vxlan. Second version removes VXLAN_NL2FLAG macro relevant patches as suggested by Michal and David I hope to have some feedback/ACK from vxlan developers. Fabian Frederick (5): vxlan: don't collect metadata if remote checksum is wrong vxlan: add

[PATCH 7/7 net-next] vxlan: fix vxlan_find_sock() documentation for l3mdev

2020-08-27 Thread Fabian Frederick
Since commit aab8cc3630e32 ("vxlan: add support for underlay in non-default VRF") vxlan_find_sock() also checks if socket is assigned to the right level 3 master device when lower device is not in the default VRF. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 5 +++

[PATCH 6/7 net-next] vxlan: merge VXLAN_NL2FLAG use in vxlan_nl2conf()

2020-08-27 Thread Fabian Frederick
Sort flag assignment to add readability. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e9b561b9d23e1..1501a5633a97e 100644 --- a/drivers

[PATCH 5/7 net-next] vxlan: add VXLAN_NL2FLAG macro

2020-08-27 Thread Fabian Frederick
Replace common flag assignment with a macro. This could yet be simplified with changelink/supported but it would remove clarity Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 113 +--- include/net/vxlan.h | 10 2 files changed, 23

[PATCH 4/7 net-next] vxlan: check rtnl_configure_link return code correctly

2020-08-27 Thread Fabian Frederick
rtnl_configure_link is always checked if < 0 for error code. Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 14f903d09c010..1e9ab1002281c 100644 --- a/drivers/net/vxla

[PATCH 3/7 net-next] vxlan: move encapsulation warning

2020-08-27 Thread Fabian Frederick
vxlan_xmit_one() was only called from vxlan_xmit() without rdst and info was already tested. Emit warning in that function instead Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers

[PATCH 2/7 net-next] vxlan: add unlikely to vxlan_remcsum check

2020-08-27 Thread Fabian Frederick
small optimization around checking as it's being done in all receptions Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 47c762f7f5b11..cc904f003f158 100644 --- a/drivers

[PATCH 1/7 net-next] vxlan: don't collect metadata if remote checksum is wrong

2020-08-27 Thread Fabian Frederick
call vxlan_remcsum() before md filling in vxlan_rcv() Signed-off-by: Fabian Frederick --- drivers/net/vxlan.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index b9fefe27e3e89..47c762f7f5b11 100644 --- a/drivers/net/vxlan.c

[PATCH 3/7 linux-next] coda: use SIZE() for stat

2018-10-19 Thread Fabian Frederick
max_t expression was already defined in coda sources Signed-off-by: Fabian Frederick --- fs/coda/upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c index d0d0fed..1323793 100644 --- a/fs/coda/upcall.c +++ b/fs/coda/upcall.c @@ -553,7

[PATCH 5/7 linux-next] coda: remove sysctl object from module when unused

2018-10-19 Thread Fabian Frederick
Inspired by NFS sysctl process Signed-off-by: Fabian Frederick --- fs/coda/Makefile | 3 ++- fs/coda/coda_int.h | 10 ++ fs/coda/coda_linux.h | 4 fs/coda/sysctl.c | 11 --- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/coda/Makefile b/fs

[PATCH 6/7 linux-next] coda: remove sb test in coda_fid_to_inode()

2018-10-19 Thread Fabian Frederick
coda_fid_to_inode() is only called by coda_downcall() where sb is already being tested. Signed-off-by: Fabian Frederick --- fs/coda/cnode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/coda/cnode.c b/fs/coda/cnode.c index 845b5a6..c42d340 100644 --- a/fs/coda/cnode.c +++ b/fs/coda

[PATCH 3/7 linux-next] coda: use SIZE() for stat

2018-10-19 Thread Fabian Frederick
max_t expression was already defined in coda sources Signed-off-by: Fabian Frederick --- fs/coda/upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c index d0d0fed..1323793 100644 --- a/fs/coda/upcall.c +++ b/fs/coda/upcall.c @@ -553,7

[PATCH 5/7 linux-next] coda: remove sysctl object from module when unused

2018-10-19 Thread Fabian Frederick
Inspired by NFS sysctl process Signed-off-by: Fabian Frederick --- fs/coda/Makefile | 3 ++- fs/coda/coda_int.h | 10 ++ fs/coda/coda_linux.h | 4 fs/coda/sysctl.c | 11 --- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/coda/Makefile b/fs

[PATCH 6/7 linux-next] coda: remove sb test in coda_fid_to_inode()

2018-10-19 Thread Fabian Frederick
coda_fid_to_inode() is only called by coda_downcall() where sb is already being tested. Signed-off-by: Fabian Frederick --- fs/coda/cnode.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/coda/cnode.c b/fs/coda/cnode.c index 845b5a6..c42d340 100644 --- a/fs/coda/cnode.c +++ b/fs/coda

[PATCH 2/7 linux-next] coda: destroy mutex in put_super()

2018-10-19 Thread Fabian Frederick
we can safely destroy vc_mutex at the end of umount process. Signed-off-by: Fabian Frederick --- fs/coda/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/coda/inode.c b/fs/coda/inode.c index dd819c1..69bb64d 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c @@ -244,6 +244,7

[PATCH 7/7 linux-next] coda: ftoc validity check integration

2018-10-19 Thread Fabian Frederick
This patch moves cfi check in coda_ftoc() instead of repeating it in the wild. Module size textdata bss dec hex filename 282971040 700 300377555 fs/coda/coda.ko.before 28263 980 700 2994374f7 fs/coda/coda.ko.after Signed-off-by: Fabian Frederick

[PATCH 2/7 linux-next] coda: destroy mutex in put_super()

2018-10-19 Thread Fabian Frederick
we can safely destroy vc_mutex at the end of umount process. Signed-off-by: Fabian Frederick --- fs/coda/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/coda/inode.c b/fs/coda/inode.c index dd819c1..69bb64d 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c @@ -244,6 +244,7

[PATCH 7/7 linux-next] coda: ftoc validity check integration

2018-10-19 Thread Fabian Frederick
This patch moves cfi check in coda_ftoc() instead of repeating it in the wild. Module size textdata bss dec hex filename 282971040 700 300377555 fs/coda/coda.ko.before 28263 980 700 2994374f7 fs/coda/coda.ko.after Signed-off-by: Fabian Frederick

[PATCH 0/7 linux-next] coda: fs clean-up

2018-10-19 Thread Fabian Frederick
This small patchset applies some sparse clean-up / optimizations Fabian Frederick (7): coda: remove CODA_FREE coda: destroy mutex in put_super() coda: use SIZE() for stat coda: add __init to init_coda_psdev() coda: remove sysctl object from module when unused coda: remove sb test

[PATCH 4/7 linux-next] coda: add __init to init_coda_psdev()

2018-10-19 Thread Fabian Frederick
init_coda_psdev() was only called by __init function. Signed-off-by: Fabian Frederick --- fs/coda/psdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index cbdddf4..6d1c95f 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c @@ -352,7

[PATCH 0/7 linux-next] coda: fs clean-up

2018-10-19 Thread Fabian Frederick
This small patchset applies some sparse clean-up / optimizations Fabian Frederick (7): coda: remove CODA_FREE coda: destroy mutex in put_super() coda: use SIZE() for stat coda: add __init to init_coda_psdev() coda: remove sysctl object from module when unused coda: remove sb test

[PATCH 4/7 linux-next] coda: add __init to init_coda_psdev()

2018-10-19 Thread Fabian Frederick
init_coda_psdev() was only called by __init function. Signed-off-by: Fabian Frederick --- fs/coda/psdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c index cbdddf4..6d1c95f 100644 --- a/fs/coda/psdev.c +++ b/fs/coda/psdev.c @@ -352,7

[PATCH 1/7 linux-next] coda: remove CODA_FREE

2018-10-19 Thread Fabian Frederick
Since commit 1d5cfdb07628 ("tree wide: use kvfree() than conditional kfree()/vfree()") size in CODA_FREE is no longer used and that macro hides nothing more than kvfree() Signed-off-by: Fabian Frederick --- fs/coda/coda_linux.h | 2 -- fs/coda/psdev.c | 8 fs/cod

[PATCH 1/7 linux-next] coda: remove CODA_FREE

2018-10-19 Thread Fabian Frederick
Since commit 1d5cfdb07628 ("tree wide: use kvfree() than conditional kfree()/vfree()") size in CODA_FREE is no longer used and that macro hides nothing more than kvfree() Signed-off-by: Fabian Frederick --- fs/coda/coda_linux.h | 2 -- fs/coda/psdev.c | 8 fs/cod

[tip:efi/core] efi/capsule: Remove NULL test on kmap()

2017-06-05 Thread tip-bot for Fabian Frederick
Commit-ID: 171fd0222957abe28e6d78de667f457376f45cf1 Gitweb: http://git.kernel.org/tip/171fd0222957abe28e6d78de667f457376f45cf1 Author: Fabian Frederick <f...@skynet.be> AuthorDate: Fri, 2 Jun 2017 13:52:01 + Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Mon, 5 Ju

[tip:efi/core] efi/capsule: Remove NULL test on kmap()

2017-06-05 Thread tip-bot for Fabian Frederick
Commit-ID: 171fd0222957abe28e6d78de667f457376f45cf1 Gitweb: http://git.kernel.org/tip/171fd0222957abe28e6d78de667f457376f45cf1 Author: Fabian Frederick AuthorDate: Fri, 2 Jun 2017 13:52:01 + Committer: Ingo Molnar CommitDate: Mon, 5 Jun 2017 17:50:40 +0200 efi/capsule: Remove NULL

Re: [PATCH 00/11 linux-next] super magic values consolidation

2017-05-28 Thread Fabian Frederick
> On 28 May 2017 at 11:34 Christoph Hellwig <h...@infradead.org> wrote: > > > On Sun, May 21, 2017 at 05:39:47PM +0200, Fabian Frederick wrote: > > This small patchset reorganizes magic.h and fixes filesystems > > which defined locally super magic values. >

Re: [PATCH 00/11 linux-next] super magic values consolidation

2017-05-28 Thread Fabian Frederick
> On 28 May 2017 at 11:34 Christoph Hellwig wrote: > > > On Sun, May 21, 2017 at 05:39:47PM +0200, Fabian Frederick wrote: > > This small patchset reorganizes magic.h and fixes filesystems > > which defined locally super magic values. > > And what's the point?

[PATCH 11/11 linux-next] hfsplus: export super magic value

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/hfsplus/hfsplus_raw.h | 1 - include/uapi/linux/magic.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/hfsplus

[PATCH 11/11 linux-next] hfsplus: export super magic value

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/hfsplus/hfsplus_raw.h | 1 - include/uapi/linux/magic.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/hfsplus_raw.h b/fs/hfsplus

[PATCH 10/11 linux-next] fs: define hfs super magic values globally

2017-05-21 Thread Fabian Frederick
hfs values were defined twice (in hfs and hfsplus) This patch exports values globally and include magic.h in hfs.h and hfsplus_raw.h where other magic are going to be exported as well. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/hfs/hfs.h | 4 ++-- fs/h

[PATCH 09/11 linux-next] freevxfs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/freevxfs/vxfs.h | 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/freevxfs/

[PATCH 08/11 linux-next] fuse: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/fuse/control.c | 3 +-- fs/fuse/inode.c| 3 +-- include/uapi/linux/magic.h | 2 ++ 3 files changed, 4 insertions(+), 4 del

[PATCH 10/11 linux-next] fs: define hfs super magic values globally

2017-05-21 Thread Fabian Frederick
hfs values were defined twice (in hfs and hfsplus) This patch exports values globally and include magic.h in hfs.h and hfsplus_raw.h where other magic are going to be exported as well. Signed-off-by: Fabian Frederick --- fs/hfs/hfs.h | 4 ++-- fs/hfsplus/hfsplus_raw.h | 1 + fs

[PATCH 09/11 linux-next] freevxfs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/freevxfs/vxfs.h | 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/freevxfs/vxfs.h b/fs/freevxfs

[PATCH 08/11 linux-next] fuse: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/fuse/control.c | 3 +-- fs/fuse/inode.c| 3 +-- include/uapi/linux/magic.h | 2 ++ 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 05/11 linux-next] ubifs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/ubifs/ubifs.h | 4 +--- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/ubi

[PATCH 07/11 linux-next] ocfs2: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/ocfs2/ocfs2_fs.h| 5 ++--- include/uapi/linux/magic.h | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/ocfs

[PATCH 05/11 linux-next] ubifs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/ubifs/ubifs.h | 4 +--- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h

[PATCH 07/11 linux-next] ocfs2: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/ocfs2/ocfs2_fs.h| 5 ++--- include/uapi/linux/magic.h | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2

[PATCH 06/11 linux-next] jfs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/jfs/jfs_incore.h| 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/

[PATCH 06/11 linux-next] jfs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/jfs/jfs_incore.h| 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/jfs/jfs_incore.h b/fs/jfs

[PATCH 04/11 linux-next] orangefs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/orangefs/protocol.h | 3 +-- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/or

[PATCH 04/11 linux-next] orangefs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/orangefs/protocol.h | 3 +-- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/orangefs/protocol.h b/fs/orangefs

[PATCH 03/11 linux-next] ceph: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/ceph/super.h| 4 +--- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ceph/super.

[PATCH 03/11 linux-next] ceph: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/ceph/super.h| 4 +--- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ceph/super.h b/fs/ceph/super.h

[PATCH 01/11 linux-next] uapi: reorganize magic.h

2017-05-21 Thread Fabian Frederick
-Sort magic.h in alphabetical order as there were no real logic in this file. -Replace all spaces with tabs -Remove excessive comments for reiserfs Signed-off-by: Fabian Frederick <f...@skynet.be> --- include/uapi/linux/magic.h | 92 -- 1 file c

[PATCH 01/11 linux-next] uapi: reorganize magic.h

2017-05-21 Thread Fabian Frederick
-Sort magic.h in alphabetical order as there were no real logic in this file. -Replace all spaces with tabs -Remove excessive comments for reiserfs Signed-off-by: Fabian Frederick --- include/uapi/linux/magic.h | 92 -- 1 file changed, 40 insertions

[PATCH 02/11 linux-next] exofs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/exofs/common.h | 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/exofs/co

[PATCH 02/11 linux-next] exofs: use magic.h

2017-05-21 Thread Fabian Frederick
Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition. Signed-off-by: Fabian Frederick --- fs/exofs/common.h | 6 +- include/uapi/linux/magic.h | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/exofs/common.h b/fs/exofs

[PATCH 00/11 linux-next] super magic values consolidation

2017-05-21 Thread Fabian Frederick
This small patchset reorganizes magic.h and fixes filesystems which defined locally super magic values. Fabian Frederick (11): uapi: reorganize magic.h exofs: use magic.h ceph: use magic.h orangefs: use magic.h ubifs: use magic.h jfs: use magic.h ocfs2: use magic.h fuse: use

[PATCH 00/11 linux-next] super magic values consolidation

2017-05-21 Thread Fabian Frederick
This small patchset reorganizes magic.h and fixes filesystems which defined locally super magic values. Fabian Frederick (11): uapi: reorganize magic.h exofs: use magic.h ceph: use magic.h orangefs: use magic.h ubifs: use magic.h jfs: use magic.h ocfs2: use magic.h fuse: use

[PATCH linux-next] fs: remove void * casting in init_once()

2017-05-16 Thread Fabian Frederick
See Documentation/process/coding-style.rst: "Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language." This will stop copy/paste cascade warnings. Signed-off-by: Fabian Fr

[PATCH linux-next] fs: remove void * casting in init_once()

2017-05-16 Thread Fabian Frederick
See Documentation/process/coding-style.rst: "Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language." This will stop copy/paste cascade warnings. Signed-off-by: Fabian

[PATCH 3/3 linux-next] fs/affs: stat: return block number

2017-05-15 Thread Fabian Frederick
stat doesn't give any block number as it's filesystem specific. Add getattr wrapper to return i_blkcnt calculated during affs_iget() Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/affs/affs.h | 2 ++ fs/affs/file.c | 1 + fs/affs/inode.c | 11 +++ 3 files chang

[PATCH 3/3 linux-next] fs/affs: stat: return block number

2017-05-15 Thread Fabian Frederick
stat doesn't give any block number as it's filesystem specific. Add getattr wrapper to return i_blkcnt calculated during affs_iget() Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 2 ++ fs/affs/file.c | 1 + fs/affs/inode.c | 11 +++ 3 files changed, 14 insertions(+) diff

[PATCH 2/3 linux-next] fs/affs: remove affs_set_blocksize()

2017-05-15 Thread Fabian Frederick
That function was only calling sb_set_blocksize() Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/affs/affs.h | 5 - fs/affs/super.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 87b17b5..fd99f28 100644 --- a/f

[PATCH 2/3 linux-next] fs/affs: remove affs_set_blocksize()

2017-05-15 Thread Fabian Frederick
That function was only calling sb_set_blocksize() Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 5 - fs/affs/super.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 87b17b5..fd99f28 100644 --- a/fs/affs/affs.h +++ b/fs

[PATCH 1/3 linux-next] fs/affs: normalize inode function prototypes

2017-05-15 Thread Fabian Frederick
Use the same style as other function blocks Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/affs/affs.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 773749b..87b17b5 100644 --- a/fs/affs/affs.h +++ b/f

[PATCH 1/3 linux-next] fs/affs: normalize inode function prototypes

2017-05-15 Thread Fabian Frederick
Use the same style as other function blocks Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 773749b..87b17b5 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h @@ -179,14

[PATCH 0/3 linux-next] fs/affs: add blocknumber to stat

2017-05-15 Thread Fabian Frederick
stat doesn't give any block number as it's filesystem specific. This small patchset adds getattr wrapper to return i_blkcnt calculated during affs_iget() and does some clean-up in affs.h Fabian Frederick (3): fs/affs: normalize inode function prototypes fs/affs: remove affs_set_blocksize

[PATCH 0/3 linux-next] fs/affs: add blocknumber to stat

2017-05-15 Thread Fabian Frederick
stat doesn't give any block number as it's filesystem specific. This small patchset adds getattr wrapper to return i_blkcnt calculated during affs_iget() and does some clean-up in affs.h Fabian Frederick (3): fs/affs: normalize inode function prototypes fs/affs: remove affs_set_blocksize

[PATCH linux-next] device-dax: fix BLOCK dependency

2017-05-13 Thread Fabian Frederick
laration of function 'get_start_sect' [-Werror=implicit-function-declaration] Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/dax/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig index b79aa8f..1806628 100644 --- a/drivers/dax/Kconfig

[PATCH linux-next] device-dax: fix BLOCK dependency

2017-05-13 Thread Fabian Frederick
laration of function 'get_start_sect' [-Werror=implicit-function-declaration] Signed-off-by: Fabian Frederick --- drivers/dax/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig index b79aa8f..1806628 100644 --- a/drivers/dax/Kconfig +++ b/drivers/dax/

[PATCH linux-next] jffs2: reduce stack usage in jffs2_build_xattr_subsystem()

2017-05-09 Thread Fabian Frederick
dynamic,bounded Also update definition when CONFIG_JFFS2_FS_XATTR is not enabled Tested with an MTD mount point and some user set/getfattr. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/jffs2/build.c | 5 - fs/jffs2/xattr.c | 14 ++ fs/jffs2/xattr.h | 4 ++-- 3

[PATCH linux-next] jffs2: reduce stack usage in jffs2_build_xattr_subsystem()

2017-05-09 Thread Fabian Frederick
dynamic,bounded Also update definition when CONFIG_JFFS2_FS_XATTR is not enabled Tested with an MTD mount point and some user set/getfattr. Signed-off-by: Fabian Frederick --- fs/jffs2/build.c | 5 - fs/jffs2/xattr.c | 14 ++ fs/jffs2/xattr.h | 4 ++-- 3 files changed, 16 insertions

[PATCH 2/2 linux-next] fs/affs: add rename exchange

2017-05-05 Thread Fabian Frederick
Process RENAME_EXCHANGE in affs_rename2() adding static affs_xrename() based on affs_rename(). We remove headers from respective directories then affect bh to other inode directory entries for swapping. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/affs/namei.

[PATCH 2/2 linux-next] fs/affs: add rename exchange

2017-05-05 Thread Fabian Frederick
Process RENAME_EXCHANGE in affs_rename2() adding static affs_xrename() based on affs_rename(). We remove headers from respective directories then affect bh to other inode directory entries for swapping. Signed-off-by: Fabian Frederick --- fs/affs/namei.c | 58

[PATCH 1/2 linux-next] fs/affs: add rename2 to prepare multiple methods

2017-05-05 Thread Fabian Frederick
Currently AFFS only supports RENAME_NOREPLACE. This patch isolates that method to a static function to prepare RENAME_EXCHANGE addition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/affs/affs.h | 2 +- fs/affs/dir.c | 2 +- fs/affs/namei.c | 25 - 3

[PATCH 1/2 linux-next] fs/affs: add rename2 to prepare multiple methods

2017-05-05 Thread Fabian Frederick
Currently AFFS only supports RENAME_NOREPLACE. This patch isolates that method to a static function to prepare RENAME_EXCHANGE addition. Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 2 +- fs/affs/dir.c | 2 +- fs/affs/namei.c | 25 - 3 files changed, 18

[PATCH linux-next RESEND] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-05-04 Thread Fabian Frederick
This script removes NULL check on kmap() and all process involved (OOM message ...) Thanks to Jan Kara for explanations. Acked-by: Julia Lawall <julia.law...@lip6.fr> Signed-off-by: Fabian Frederick <f...@skynet.be> --- scripts/coccinelle/misc/kma

[PATCH linux-next RESEND] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-05-04 Thread Fabian Frederick
This script removes NULL check on kmap() and all process involved (OOM message ...) Thanks to Jan Kara for explanations. Acked-by: Julia Lawall Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc/kmap.cocci | 43 ++ 1 file changed, 43 insertions

[PATCH V3 linux-next] nfs: use kmap/kunmap directly

2017-05-03 Thread Fabian Frederick
subsequent error checks were removed as well as unused labels. Signed-off-by: Fabian Frederick <f...@skynet.be> --- V3: -Remove nfs_readdir_get_array()/release_array() (suggested by Trond Myklebust) -Remove subsequent checks V2: -Remove ptr and return kmap(page) di

[PATCH V3 linux-next] nfs: use kmap/kunmap directly

2017-05-03 Thread Fabian Frederick
subsequent error checks were removed as well as unused labels. Signed-off-by: Fabian Frederick --- V3: -Remove nfs_readdir_get_array()/release_array() (suggested by Trond Myklebust) -Remove subsequent checks V2: -Remove ptr and return kmap(page) directly (suggested by Anna

[PATCH 2/2 linux-next] gfs2: remove unused flags parameter

2017-05-03 Thread Fabian Frederick
We already assumed rename flags when calling gfs2_exchange() Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/gfs2/inode.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9698796..b5858a3 100644 --- a/fs/gfs2/inode.c

[PATCH 2/2 linux-next] gfs2: remove unused flags parameter

2017-05-03 Thread Fabian Frederick
We already assumed rename flags when calling gfs2_exchange() Signed-off-by: Fabian Frederick --- fs/gfs2/inode.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9698796..b5858a3 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c

[PATCH 1/2 linux-next] gfs2: check rename2 flags at once

2017-05-03 Thread Fabian Frederick
There's no need to update flags in gfs2_rename2() This will ease whiteout addition. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/gfs2/inode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9f605ea..9698796 100644 --

[PATCH 1/2 linux-next] gfs2: check rename2 flags at once

2017-05-03 Thread Fabian Frederick
There's no need to update flags in gfs2_rename2() This will ease whiteout addition. Signed-off-by: Fabian Frederick --- fs/gfs2/inode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9f605ea..9698796 100644 --- a/fs/gfs2/inode.c

[PATCH V2 linux-next] nfs: kmap can't fail

2017-04-26 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick <f...@skynet.be> --- V2: Remove ptr and return kmap(page) directly (Suggested by Anna Schumaker) fs/nfs/dir.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3a188cb..12

[PATCH V2 linux-next] nfs: kmap can't fail

2017-04-26 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- V2: Remove ptr and return kmap(page) directly (Suggested by Anna Schumaker) fs/nfs/dir.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3a188cb..12ed806b 100644 --- a/fs

[PATCH V2 linux-next] staging: media: atomisp: kmap() can't fail

2017-04-26 Thread Fabian Frederick
There's no need to check kmap() return value because it won't fail. If it's highmem mapping, it will receive virtual address or a new one; if it's lowmem, all kernel pages are already being mapped. (Thanks to Jan Kara for explanations) Signed-off-by: Fabian Frederick <f...@skynet.be>

[PATCH V2 linux-next] staging: media: atomisp: kmap() can't fail

2017-04-26 Thread Fabian Frederick
There's no need to check kmap() return value because it won't fail. If it's highmem mapping, it will receive virtual address or a new one; if it's lowmem, all kernel pages are already being mapped. (Thanks to Jan Kara for explanations) Signed-off-by: Fabian Frederick --- V2: Verbose description

[PATCH 1/1 linux-next] btrfs: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/btrfs/check-integrity.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index ab14c2e..496eb00 100644 --- a/fs/btrfs

[PATCH 1/1 linux-next] btrfs: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- fs/btrfs/check-integrity.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index ab14c2e..496eb00 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs

[PATCH 1/1 linux-next] nfs: kmap can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/nfs/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3a188cb..f89e54c 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -179,8 +179,6 @@ struct nfs_cache

[PATCH 1/1 linux-next] nfs: kmap can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- fs/nfs/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 3a188cb..f89e54c 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -179,8 +179,6 @@ struct nfs_cache_array *nfs_readdir_get_array

[PATCH 1/1 linux-next] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-04-25 Thread Fabian Frederick
This script removes NULL check on kmap() and all process involved (OOM message ...) Thanks to Jan Kara for explanations. Signed-off-by: Fabian Frederick <f...@skynet.be> --- scripts/coccinelle/misc/kmap.cocci | 43 ++ 1 file changed, 43 insertions(+)

[PATCH 1/1 linux-next] scripts/coccinelle/misc: Warn about NULL check on kmap()

2017-04-25 Thread Fabian Frederick
This script removes NULL check on kmap() and all process involved (OOM message ...) Thanks to Jan Kara for explanations. Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc/kmap.cocci | 43 ++ 1 file changed, 43 insertions(+) create mode 100644

[PATCH 1/1 linux-next] efi/capsule: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/firmware/efi/capsule-loader.c | 5 - drivers/firmware/efi/capsule.c| 4 2 files changed, 9 deletions(-) diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/c

[PATCH 1/1 linux-next] efi/capsule: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- drivers/firmware/efi/capsule-loader.c | 5 - drivers/firmware/efi/capsule.c| 4 2 files changed, 9 deletions(-) diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c index

[PATCH 1/1 linux-next] staging: media: atomisp: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/s

[PATCH 1/1 linux-next] staging: media: atomisp: kmap() can't fail

2017-04-25 Thread Fabian Frederick
Remove NULL test on kmap() Signed-off-by: Fabian Frederick --- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c b/drivers/staging/media/atomisp/pci

[PATCH 2/2 linux-next] fs/affs: bugfix: Write files greater than page size on OFS

2017-04-24 Thread Fabian Frederick
-by: Fabian Frederick <f...@skynet.be> --- fs/affs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index e5c5de6..196ee7f 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -679,7 +679,7 @@ static int affs_write_end_ofs(struct file *file,

[PATCH 2/2 linux-next] fs/affs: bugfix: Write files greater than page size on OFS

2017-04-24 Thread Fabian Frederick
-by: Fabian Frederick --- fs/affs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index e5c5de6..196ee7f 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -679,7 +679,7 @@ static int affs_write_end_ofs(struct file *file, struct address_space

[PATCH 1/2 linux-next] fs/affs: bugfix: enable writes on OFS disks

2017-04-24 Thread Fabian Frederick
found here: https://bugzilla.kernel.org/show_bug.cgi?id=114961 Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/affs/file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index 0deec9c..e5c5de6 100644 --- a/fs/affs/file.c +++

  1   2   3   4   5   6   7   8   9   10   >