[PATCH 7/8 net-next] irda: litelink-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/litelink-sir.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/net/irda/litelink-sir.c b/drivers/net/irda/litelink-sir.c

[PATCH 6/8 net-next] irda: old_belkin-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/old_belkin-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/old_belkin-sir.c b/drivers/net/irda/old_belkin-sir.c

[PATCH 3/8 net-next] irda: mcp2120-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/mcp2120-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/mcp2120-sir.c b/drivers/net/irda/mcp2120-sir.c index 2e33f91..0

[PATCH 8/8 net-next] irda: ma600-sir: use module_sirdev_driver() helper

Avoid using generic init/empty functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/ma600-sir.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/irda/ma600-sir.c b/drivers/net/irda/ma600-sir.c index a764817..a8c4c29 100644

[PATCH 7/8 net-next] irda: litelink-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/litelink-sir.c | 28 ++-- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/net/irda/litelink-sir.c b/drivers/net/irda/litelink-sir.c index 8eefcb4..541fe7c

[PATCH 6/8 net-next] irda: old_belkin-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/old_belkin-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/old_belkin-sir.c b/drivers/net/irda/old_belkin-sir.c index a7c2e99..b15157c

[PATCH 3/8 net-next] irda: mcp2120-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/mcp2120-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/mcp2120-sir.c b/drivers/net/irda/mcp2120-sir.c index 2e33f91..015d434 100644

[PATCH 1/8 net-next] irda: sir-dev: add module_sirdev_driver() helper

Based on module_driver() to avoid generic functions. See include/linux/device.h/module_driver comments for further details. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/sir-dev.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/irda/sir-d

[PATCH 2/8 net-next] irda: actl200l-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/act200l-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/act200l-sir.c b/drivers/net/irda/act200l-sir.c index e891751..b

[PATCH 4/8 net-next] irda: esi-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/esi-sir.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/esi-sir.c b/drivers/net/irda/esi-sir.c index 019a3e8..65470e4

[PATCH 2/8 net-next] irda: actl200l-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/act200l-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/act200l-sir.c b/drivers/net/irda/act200l-sir.c index e891751..bb58c6e 100644

[PATCH 4/8 net-next] irda: esi-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/esi-sir.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/esi-sir.c b/drivers/net/irda/esi-sir.c index 019a3e8..65470e4 100644 --- a/drivers/net

[PATCH 1/8 net-next] irda: sir-dev: add module_sirdev_driver() helper

Based on module_driver() to avoid generic functions. See include/linux/device.h/module_driver comments for further details. Signed-off-by: Fabian Frederick --- drivers/net/irda/sir-dev.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/irda/sir-dev.h b/drivers/net/irda/sir

[PATCH 0/8 net-next] irda: use module_driver in a new helper

/module_driver() for further details). Note: compiled but untested. Fabian Frederick (8): irda: sir-dev: add module_sirdev_driver() helper irda: actl200l-sir: use module_sirdev_driver() helper irda: mcp2120-sir: use module_sirdev_driver() helper irda: esi-sir: use module_sirdev_driver() helper

[PATCH 5/8 net-next] irda: girbil-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/net/irda/girbil-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/girbil-sir.c b/drivers/net/irda/girbil-sir.c index 7e0a5b8..a

[PATCH 0/8 net-next] irda: use module_driver in a new helper

/module_driver() for further details). Note: compiled but untested. Fabian Frederick (8): irda: sir-dev: add module_sirdev_driver() helper irda: actl200l-sir: use module_sirdev_driver() helper irda: mcp2120-sir: use module_sirdev_driver() helper irda: esi-sir: use module_sirdev_driver() helper

[PATCH 5/8 net-next] irda: girbil-sir: use module_sirdev_driver() helper

Avoid using generic init/exit functions. Signed-off-by: Fabian Frederick --- drivers/net/irda/girbil-sir.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/irda/girbil-sir.c b/drivers/net/irda/girbil-sir.c index 7e0a5b8..a0bc4ac 100644

[PATCH 1/1 linux-next] drbd: remove __packed definition

__packed is already defined in compiler-gcc.h under __GNUC__ (see include/linux/compiler.h) Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_protocol.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/block/drbd/drbd_protocol.h b/drivers/bloc

[PATCH 1/1 linux-next] drbd: remove __packed definition

__packed is already defined in compiler-gcc.h under __GNUC__ (see include/linux/compiler.h) Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_protocol.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/block/drbd/drbd_protocol.h b/drivers/block/drbd/drbd_protocol.h

[RFC 1/1] treewide: replace obsolete _refok by __ref

efinitions) Signed-off-by: Fabian Frederick <f...@skynet.be> --- arch/alpha/kernel/machvec_impl.h | 2 +- arch/arc/mm/init.c | 2 +- arch/arm/mach-integrator/impd1.c | 4 ++-- arch/arm/mach-mv78xx0/common.c | 2 +- arch/blackfin/mm/init.c

[RFC 1/1] treewide: replace obsolete _refok by __ref

efinitions) Signed-off-by: Fabian Frederick --- arch/alpha/kernel/machvec_impl.h | 2 +- arch/arc/mm/init.c | 2 +- arch/arm/mach-integrator/impd1.c | 4 ++-- arch/arm/mach-mv78xx0/common.c | 2 +- arch/blackfin/mm/init.c | 2 +- arch/

[PATCH 1/1 linux-next] ACPI / extlog: avoid null pointer dereference

extlog_l1_addr was checked after assigning flags attribute. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/acpi/acpi_extlog.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index b3842ff..1

[PATCH 1/1 linux-next] ACPI / extlog: avoid null pointer dereference

extlog_l1_addr was checked after assigning flags attribute. Signed-off-by: Fabian Frederick --- drivers/acpi/acpi_extlog.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/acpi_extlog.c b/drivers/acpi/acpi_extlog.c index b3842ff..183b7b2 100644 --- a/drivers

[PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h

ecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared (first use in this function) Including gpio/consumer.h declares minimal functions in that case. Signed-off-by: Fabian Frederick <f...@skynet.be> --- V2: Add in alphabetical order (suggested by Nicolin Chen) sound/soc/codecs/cs53

[PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h

ecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared (first use in this function) Including gpio/consumer.h declares minimal functions in that case. Signed-off-by: Fabian Frederick --- V2: Add in alphabetical order (suggested by Nicolin Chen) sound/soc/codecs/cs53l30.c | 1 + 1 fi

[PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h

ecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared (first use in this function) Including gpio/consumer.h declares minimal functions in that case. Signed-off-by: Fabian Frederick <f...@skynet.be> --- sound/soc/codecs/cs53l30.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc

[PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h

ecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared (first use in this function) Including gpio/consumer.h declares minimal functions in that case. Signed-off-by: Fabian Frederick --- sound/soc/codecs/cs53l30.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/cs53l30.

[PATCH V2 net-next] drivers/net: fix eisa_driver probe section mismatch

Some eisa_driver structures used __init probe functions which generates a warning and could crash if function is called after being deleted. Signed-off-by: Fabian Frederick --- V2: -Remove scsi occurence for net-next(suggested by David S. Miller) -Fix checkpatch warnings(space

[PATCH V2 net-next] drivers/net: fix eisa_driver probe section mismatch

Some eisa_driver structures used __init probe functions which generates a warning and could crash if function is called after being deleted. Signed-off-by: Fabian Frederick <f...@skynet.be> --- V2: -Remove scsi occurence for net-next(suggested by David S. Miller) -Fix chec

[PATCH 1/1] fs.h: import umode to DT conversion

The same umode -> DT calculation existed in different filesystems. Signed-off-by: Fabian Frederick --- fs/configfs/dir.c | 8 +--- fs/kernfs/dir.c| 8 +--- fs/libfs.c | 9 ++--- fs/logfs/dir.c | 4 ++-- fs/logfs/logfs.h | 5 - fs/nfs/internal.h

[PATCH 1/1] fs.h: import umode to DT conversion

The same umode -> DT calculation existed in different filesystems. Signed-off-by: Fabian Frederick <f...@skynet.be> --- fs/configfs/dir.c | 8 +--- fs/kernfs/dir.c| 8 +--- fs/libfs.c | 9 ++--- fs/logfs/dir.c | 4 ++-- fs/logfs/logfs.h | 5 - fs/nfs/i

[PATCH 12/21] drbd: use true/false for bool

Fix 4 coccinelle warnings Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_receiver.c | 4 ++-- drivers/block/drbd/drbd_worker.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index

[PATCH 16/21] drbd: fix maybe_pull_ahead() locking comments

maybe_pull_ahead() calls rcu_read_lock() itself and is only called within req_lock (locked by drbd_send_and_submit() Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers

[PATCH 14/21] drbd: clean-up receive_SyncParam()

Initialize header_size then data_size once. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_receiver.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index ad9b99b..3ca6516

[PATCH 15/21] drbd: introduce peer state union

Add peer structure and propagate in conn_khelper() instead of hardcoded values. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_nl.c | 13 +++-- include/linux/drbd.h | 8 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/block/drbd

[PATCH 13/21] drbd: fix drbd_bm_init() comments

Function is also called by drbd_create_device() so original comment is now obsolete. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_bitmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c

[PATCH 21/21] drbd: replace if/BUG by BUG_ON

Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_state.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c index a7631a3..5f16a11 100644 --- a/drivers/block/drbd/drbd_state.c +++ b/drivers/block

[PATCH 20/21] drbd: remove unused definitions

div_ceil/div_floor are no longer used Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_int.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index c898947..365eb4c 100644 --- a/drivers/block/drbd/drbd_int.h +++ b

[PATCH 19/21] drbd: remove bm_vk_free()

Commit 51fa48018a12 ("tree wide: use kvfree() than conditional kfree()/vfree()") simplified bm_vk_free() to one single call. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_bitmap.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/

[PATCH 18/21] drbd: remove redundant declarations

both drbd_conn_str() and drbd_role_str() were already declared extern in drbd_strings.h included in drbd_int.h Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_int.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h

[PATCH 11/21] drbd: use | for bitmask combination

Fix coccinelle warning: "sum of probable bitmasks, consider |" Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c ind

[PATCH 17/21] drbd: use bool for growing

growing is used for true/false in drbd_bm_resize() Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_bitmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c index aa2ced7..17e5e60 100644

[PATCH 06/21] drbd: use const char * const for drbd strings

Be more strict with constant arrays Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_strings.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_strings.c b/drivers/block/drbd/drbd_strings.c index 80b0f63..0eeab14 100644

[PATCH 10/21] drbd: fix typo

s/reqest/request Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_state.h b/drivers/block/drbd/drbd_state.h index bd98953..6c9d5d4 100644 --- a/drivers/block/drbd/drbd_state.h +++ b

[PATCH 08/21] drbd: use unsigned for one bit fields

Fix sparse warnings and limit comments to fit in 80 columns Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_interval.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/block/drbd/drbd_interval.h b/drivers/block/drbd/drbd_interval.h index

[PATCH 07/21] drbd: kerneldoc warning fix in w_e_end_data_req()

device in not passed to that function. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_worker.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index eff716c..e47bde9 100644 --- a/drivers/block/drbd/drbd_worker.c

[PATCH 09/21] drbd: use bool for peer is_ states

is_write and is_discard are used as boolean. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index e47bde9..e427ba0 100644

[PATCH 01/21] drbd: debugfs: constify drbd_version_fops

drbd_version_fops is used in debugfs_create_file() as const Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_debugfs.c b/drivers/block/drbd/drbd_debugfs.c index 96a0107..abccffa

[PATCH 03/21] drbd: use seq_put instead of seq_print where possible

seq_putc/seq_puts give the following improvements: text data bssdec hex filename 4661 0 8 4669123d drivers/block/drbd/drbd_proc.o 4603 0 8 46111203 drivers/block/drbd/drbd_proc-after.o Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_proc.c

[PATCH 04/21] drbd: include linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_main.c | 2 +- drivers/block/drbd/drbd_proc.c | 2 +- drivers/block/drbd/drbd_receiver.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c

[PATCH 05/21] drbd: rework is_valid_state()

Remove empty condition to avoid semantic warnings Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_state.c | 86 ++--- 1 file changed, 38 insertions(+), 48 deletions(-) diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c

[PATCH 02/21] drbd: simplify drbd_md_set_sector_offsets()

Some metadata informations were duplicated in layout switch. Signed-off-by: Fabian Frederick --- drivers/block/drbd/drbd_nl.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index c055c5e

[PATCH 00/21] drbd: clean-up patchset

This small patchset does some code clean-up in drivers/block/drbd tree. Fabian Frederick (21): drbd: debugfs: constify drbd_version_fops drbd: simplify drbd_md_set_sector_offsets() drbd: use seq_put instead of seq_print where possible drbd: include linux/uaccess.h instead of asm/uaccess.h

[PATCH 12/21] drbd: use true/false for bool

Fix 4 coccinelle warnings Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_receiver.c | 4 ++-- drivers/block/drbd/drbd_worker.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/bloc

[PATCH 14/21] drbd: clean-up receive_SyncParam()

Initialize header_size then data_size once. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_receiver.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c

[PATCH 15/21] drbd: introduce peer state union

Add peer structure and propagate in conn_khelper() instead of hardcoded values. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_nl.c | 13 +++-- include/linux/drbd.h | 8 2 files changed, 15 insertions(+), 6 deletions(-) diff

[PATCH 13/21] drbd: fix drbd_bm_init() comments

Function is also called by drbd_create_device() so original comment is now obsolete. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_bitmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/bloc

[PATCH 16/21] drbd: fix maybe_pull_ahead() locking comments

maybe_pull_ahead() calls rcu_read_lock() itself and is only called within req_lock (locked by drbd_send_and_submit() Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_req.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bloc

[PATCH 05/21] drbd: rework is_valid_state()

Remove empty condition to avoid semantic warnings Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_state.c | 86 ++--- 1 file changed, 38 insertions(+), 48 deletions(-) diff --git a/drivers/block/drbd/drbd_state.c b/drivers

[PATCH 00/21] drbd: clean-up patchset

This small patchset does some code clean-up in drivers/block/drbd tree. Fabian Frederick (21): drbd: debugfs: constify drbd_version_fops drbd: simplify drbd_md_set_sector_offsets() drbd: use seq_put instead of seq_print where possible drbd: include linux/uaccess.h instead of asm/uaccess.h

[PATCH 02/21] drbd: simplify drbd_md_set_sector_offsets()

Some metadata informations were duplicated in layout switch. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_nl.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/bloc

[PATCH 04/21] drbd: include linux/uaccess.h instead of asm/uaccess.h

Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_main.c | 2 +- drivers/block/drbd/drbd_proc.c | 2 +- drivers/block/drbd/drbd_receiver.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/bloc

[PATCH 17/21] drbd: use bool for growing

growing is used for true/false in drbd_bm_resize() Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_bitmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c index a

[PATCH 10/21] drbd: fix typo

s/reqest/request Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_state.h b/drivers/block/drbd/drbd_state.h index bd98953..6c9d5d4 100644 --- a/drivers/bloc

[PATCH 19/21] drbd: remove bm_vk_free()

Commit 51fa48018a12 ("tree wide: use kvfree() than conditional kfree()/vfree()") simplified bm_vk_free() to one single call. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_bitmap.c | 13 - 1 file changed, 4 insertions(+), 9 deletion

[PATCH 20/21] drbd: remove unused definitions

div_ceil/div_floor are no longer used Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_int.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h index c898947..365eb4c 100644 --- a/drivers/bloc

[PATCH 11/21] drbd: use | for bitmask combination

Fix coccinelle warning: "sum of probable bitmasks, consider |" Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_receiver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd

[PATCH 21/21] drbd: replace if/BUG by BUG_ON

Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_state.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c index a7631a3..5f16a11 100644 --- a/drivers/block/drbd/drbd_state.c

[PATCH 06/21] drbd: use const char * const for drbd strings

Be more strict with constant arrays Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_strings.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_strings.c b/drivers/block/drbd/drbd_strings.c index 80b0f63..0

[PATCH 18/21] drbd: remove redundant declarations

both drbd_conn_str() and drbd_role_str() were already declared extern in drbd_strings.h included in drbd_int.h Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_int.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/drbd/drbd_int.h b/drivers

[PATCH 01/21] drbd: debugfs: constify drbd_version_fops

drbd_version_fops is used in debugfs_create_file() as const Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_debugfs.c b/drivers/block/drbd/drbd_debugfs.c

[PATCH 03/21] drbd: use seq_put instead of seq_print where possible

seq_putc/seq_puts give the following improvements: text data bssdec hex filename 4661 0 8 4669123d drivers/block/drbd/drbd_proc.o 4603 0 8 46111203 drivers/block/drbd/drbd_proc-after.o Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/bloc

[PATCH 08/21] drbd: use unsigned for one bit fields

Fix sparse warnings and limit comments to fit in 80 columns Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_interval.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/block/drbd/drbd_interval.h b/drivers/bloc

[PATCH 07/21] drbd: kerneldoc warning fix in w_e_end_data_req()

device in not passed to that function. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_worker.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index eff716c..e47bde9 100644 --- a/drivers

[PATCH 09/21] drbd: use bool for peer is_ states

is_write and is_discard are used as boolean. Signed-off-by: Fabian Frederick <f...@skynet.be> --- drivers/block/drbd/drbd_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c index e47bde9..e

Re: [PATCH 4.1 54/56] fs/ufs: restore s_lock mutex

Hello Greg,                 Here's the complete list of linux-next/UFS patches needed to stop regressions in write mode: 13b987ea2758 fs/ufs: revert "ufs: fix deadlocks introduced by sb mutex merge" cdd9eefdf905 fs/ufs: restore s_lock mutex 12ecbb4b1d76 ufs: Fix warning from

Re: [PATCH 4.1 54/56] fs/ufs: restore s_lock mutex

Hello Greg,                 Here's the complete list of linux-next/UFS patches needed to stop regressions in write mode: 13b987ea2758 fs/ufs: revert ufs: fix deadlocks introduced by sb mutex merge cdd9eefdf905 fs/ufs: restore s_lock mutex 12ecbb4b1d76 ufs: Fix warning from unlock_new_inode()

[PATCH 1/1 linux-next] fs/ufs: restore s_lock mutex_init()

Add last missing line in commit "cdd9eefdf905" ("fs/ufs: restore s_lock mutex") Signed-off-by: Fabian Frederick --- Second part of the patch with 2 fixes was not applied. Meanwhile, Al already fixed remount(). fs/ufs/super.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH 1/1 linux-next] fs/ufs: restore s_lock mutex_init()

Add last missing line in commit cdd9eefdf905 (fs/ufs: restore s_lock mutex) Signed-off-by: Fabian Frederick f...@skynet.be --- Second part of the patch with 2 fixes was not applied. Meanwhile, Al already fixed remount(). fs/ufs/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ufs

[RFC 1/1 linux-next] tools/lguest: update variables to avoid setreg(eax, eax)

eax is used for offset calculation but is also a local variable used to store register value. Use val for value and defval for default value to remove this ambiguity. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- tools/lguest/lguest.c | 26

[PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

Don't opencode sg_init_one() Signed-off-by: Fabian Frederick --- net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c index b5408e8..fee3c15 100644

[PATCH 1/1 linux-next] mmc: omap: use for_each_sg() for scatterlist parsing

See Documentation/DMA-API.txt - Part Id Signed-off-by: Fabian Frederick --- This is untested. drivers/mmc/host/omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 68dd6c7..70dcf07 100644 --- a/drivers/mmc/host

[PATCH V2 net-next] net: rds: use for_each_sg() for scatterlist parsing

This patch also renames sg to sglist and aligns function parameters. See Documentation/DMA-API.txt - Part Id for scatterlist details Signed-off-by: Fabian Frederick --- This is untested. V2: reorder variables (suggested by David S. Miller) net/rds/ib.h | 22 ++ 1 file

[PATCH V2 net-next] net: rds: use for_each_sg() for scatterlist parsing

This patch also renames sg to sglist and aligns function parameters. See Documentation/DMA-API.txt - Part Id for scatterlist details Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. V2: reorder variables (suggested by David S. Miller) net/rds/ib.h | 22

[PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq_key()

Don't opencode sg_init_one() Signed-off-by: Fabian Frederick f...@skynet.be --- net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c index b5408e8..fee3c15

[RFC 1/1 linux-next] tools/lguest: update variables to avoid setreg(eax, eax)

eax is used for offset calculation but is also a local variable used to store register value. Use val for value and defval for default value to remove this ambiguity. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick f...@skynet.be --- tools/lguest

[PATCH 1/1 linux-next] mmc: omap: use for_each_sg() for scatterlist parsing

See Documentation/DMA-API.txt - Part Id Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. drivers/mmc/host/omap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 68dd6c7..70dcf07 100644

[PATCH 1/1 net-next] net: rds: use for_each_sg() for scatterlist parsing

This patch also renames sg to sglist and aligns function parameters. See Documentation/DMA-API.txt - Part Id for scatterlist details Signed-off-by: Fabian Frederick --- This is untested. net/rds/ib.h | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[PATCH 1/1 net-next] net: rds: use for_each_sg() for scatterlist parsing

This patch also renames sg to sglist and aligns function parameters. See Documentation/DMA-API.txt - Part Id for scatterlist details Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. net/rds/ib.h | 22 ++ 1 file changed, 14 insertions(+), 8 deletions

Re: [PATCH 1/1 linux-next] fs/hfsplus/options.c: use standard option prefix

> On 06 June 2015 at 15:31 Richard Weinberger > wrote: > > > On Fri, Jun 5, 2015 at 9:40 PM, Fabian Frederick wrote: > > All filesystems use Opt_ prefix for match_table_t enums > > And needs hfsplus this patch? > It should not matter whether a filesystem is usi

Re: [PATCH 1/1 linux-next] fs/hfsplus/options.c: use standard option prefix

On 06 June 2015 at 15:31 Richard Weinberger richard.weinber...@gmail.com wrote: On Fri, Jun 5, 2015 at 9:40 PM, Fabian Frederick f...@skynet.be wrote: All filesystems use Opt_ prefix for match_table_t enums And needs hfsplus this patch? It should not matter whether a filesystem

Re: [PATCH 1/1 linux-next] pnfs/flexfiles: use swap() in ff_layout_sort_mirrors()

> On 12 June 2015 at 19:17 Joe Perches wrote: > > > On Fri, 2015-06-12 at 18:58 +0200, Fabian Frederick wrote: > > Use kernel.h macro definition. > > A lot of these conversions seem to be for bubble sorts. > Maybe it'd be useful to add a generic one somewhere

Re: [PATCH 1/1 linux-next] pnfs/flexfiles: use swap() in ff_layout_sort_mirrors()

On 12 June 2015 at 19:17 Joe Perches j...@perches.com wrote: On Fri, 2015-06-12 at 18:58 +0200, Fabian Frederick wrote: Use kernel.h macro definition. A lot of these conversions seem to be for bubble sorts. Maybe it'd be useful to add a generic one somewhere. Of course but those swap

[PATCH 1/1 linux-next] ALSA: gus: use swap() in snd_ics_put_double()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- sound/isa/gus/gus_mixer.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/isa/gus/gus_mixer.c b/sound/isa/gus/gus_mixer.c index 0dd4341

[PATCH 1/1 linux-next] ocfs2: use swap() in swap_refcount_rec()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- fs/ocfs2/refcounttree.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c index 6f66268..c8e1dce

[PATCH 1/1 linux-next] sound: oss/sb_audio: use swap() in sb_audio_close()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- sound/oss/sb_audio.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c index 048439a..dc91072 100644

[PATCH 1/1 linux-next] pnfs/flexfiles: use swap() in ff_layout_sort_mirrors()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- fs/nfs/flexfilelayout/flexfilelayout.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs

[PATCH 1/1 linux-next] ext4: use swap() in mext_page_double_lock()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- fs/ext4/move_extent.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 370420b..8c04afb

[PATCH 1/1 linux-next] ocfs2: use swap() in ocfs2_double_lock()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- fs/ocfs2/namei.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index a150748..af9c4c8 100644

[PATCH 1/1 linux-next] nfsd: use swap() in sort_pacl_range()

Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick --- fs/nfsd/nfs4acl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c index 7e10e2a..eb5accf 100644 --- a/fs

<    1   2   3   4   5   6   7   8   9   10   >