[PATCH 1/1 linux-next] irda: add __init to irlan_open

2014-09-30 Thread Fabian Frederick
irlan_open is only called by __init irlan_init in same module. Signed-off-by: Fabian Frederick --- net/irda/irlan/irlan_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/irda/irlan/irlan_common.c b/net/irda/irlan/irlan_common.c index 1bc49ed..5a2d0a6 100644

[PATCH 1/1 linux-next] libceph: remove redundant declaration

2014-09-30 Thread Fabian Frederick
ceph_release_page_vector was defined twice in libceph.h Signed-off-by: Fabian Frederick --- include/linux/ceph/libceph.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h index 279b0af..07bc359 100644 --- a/include/linux/ceph

[PATCH 1/1] fs/affs/super.c: remove unused variable

2014-09-29 Thread Fabian Frederick
key is set in affs_fill_super but never used. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/affs/super.c b/fs/affs/super.c index 51f1a95..a67dc72 100644 --- a/fs/affs/super.c +++ b/fs/affs/super.c

[PATCH 1/1] fs/affs/inode.c: remove unused variable

2014-09-29 Thread Fabian Frederick
head is set to AFFS_HEAD(bh) but never used. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index bec2d1a..930aac3 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c @@ -20,7 +20,6

[PATCH 1/1] fs/ufs/balloc.c: remove unused variable

2014-09-29 Thread Fabian Frederick
ucg is defined and set in ufs_bitmap_search but never used. Cc: Evgeniy Dushistov Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/ufs/balloc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ufs/balloc.c b/fs/ufs/balloc.c index 7bc2080..2c10360 100644 --- a/fs/ufs/balloc.c

[PATCH V2 resend] FS/OMFS: block number sanity check during fill_super operation

2014-09-29 Thread Fabian Frederick
This patch defines maximum block number to 2^31. It also converts bitmap_size and array_size to unsigned int in omfs_get_imap Suggested-By: Linus Torvalds Suggested-By: Bob Copeland Cc: Linus Torvalds Cc: Bob Copeland Cc: Andrew Morton Signed-off-by: Fabian Frederick --- This is untested

[PATCH 1/1] fat: remove redundant sys_tz declaration

2014-09-29 Thread Fabian Frederick
sys_tz is already declared extern struct in include/linux/time.h Cc: Andrew Morton Cc: OGAWA Hirofumi Signed-off-by: Fabian Frederick --- fs/fat/misc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/fat/misc.c b/fs/fat/misc.c index 628e22a..d8da2d2 100644 --- a/fs/fat/misc.c +++ b/fs

[PATCH 1/1] fs/affs/file.c: fix shadow warnings

2014-09-29 Thread Fabian Frederick
4 functions declared variables twice resulting in shadow warnings. This patch renames internal variables and adds blank line after declarations. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/file.c | 39 --- 1 file changed, 24 insertions

Re: [PATCH 1/1 linux-next] ACPI / SBS: fix sparse warning

2014-09-29 Thread Fabian Frederick
> On 29 September 2014 at 07:40 Sudip Mukherjee > wrote: > > > On Sun, Sep 28, 2014 at 08:44:47PM +0200, Fabian Frederick wrote: > > Adding parentheses around expression to avoid: > > drivers/acpi/sbs.c:444:28: warning: dubious: !x & y > >

[PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock

2014-09-28 Thread Fabian Frederick
fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock Suggested-by: Brian Norris Suggested-by: Josh Triplett Signed-off-by: Fabian Frederick --- V2: use __must_hold instead of __releases / __acquires (suggested by Brian Norris and Jos

[PATCH 1/1 linux-next] ACPI / SBS: fix sparse warning

2014-09-28 Thread Fabian Frederick
Adding parentheses around expression to avoid: drivers/acpi/sbs.c:444:28: warning: dubious: !x & y Signed-off-by: Fabian Frederick --- drivers/acpi/sbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c index 32aecea..a7a3edd 10

[PATCH 1/1 linux-next] goldfish: fix sparse warnings

2014-09-28 Thread Fabian Frederick
drivers/tty/goldfish.c:160:46: warning: Using plain integer as NULL pointer drivers/tty/goldfish.c:320:22: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick --- drivers/tty/goldfish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty

[PATCH 1/1 linux-next] fs/hfs/hfs_fs.h: remove redundant sys_tz declaration

2014-09-27 Thread Fabian Frederick
sys_tz is already declared in include/linux/time.h Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/hfs/hfs_fs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/hfs/hfs_fs.h b/fs/hfs/hfs_fs.h index 0524cda..95d2552 100644 --- a/fs/hfs/hfs_fs.h +++ b/fs/hfs/hfs_fs.h @@ -242,8

[PATCH 1/1 linux-next] udf: remove redundant sys_tz declaration

2014-09-27 Thread Fabian Frederick
sys_tz is already declared in include/linux/time.h Cc: Jan Kara Signed-off-by: Fabian Frederick --- fs/udf/udftime.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/udf/udftime.c b/fs/udf/udftime.c index 1f11483..77c331f 100644 --- a/fs/udf/udftime.c +++ b/fs/udf/udftime.c @@ -81,8

[PATCH 1/1 linux-next] fs/ncpfs/dir.c: remove redundant sys_tz declaration

2014-09-27 Thread Fabian Frederick
sys_tz is already declared in include/linux/time.h Cc: Petr Vandrovec Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/ncpfs/dir.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 08b8ea8..1beb761 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs

[PATCH 1/1 linux-next] fs/affs: remove redundant sys_tz declarations

2014-09-27 Thread Fabian Frederick
sys_tz is already declared in include/linux/time.h Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/amigaffs.c | 2 -- fs/affs/inode.c| 1 - fs/affs/super.c| 2 -- 3 files changed, 5 deletions(-) diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index 406b298..abc8539

Re: [PATCH 1/1] jffs2: fix sparse warning: unexpected unlock

2014-09-27 Thread Fabian Frederick
> On 27 September 2014 at 01:17 j...@joshtriplett.org wrote: > > > On Mon, Sep 22, 2014 at 11:12:50AM -0700, Brian Norris wrote: > > + linux-sparse > > > > On Thu, Sep 18, 2014 at 08:46:16PM +0200, Fabian Frederick wrote: > > > fs/jffs2/summary

Re: [PATCH V2 1/2] brcm80211: use container_of to resolve brcms_phy from brcms_phy_pub

2014-09-27 Thread Fabian Frederick
> On 26 September 2014 at 19:46 "John W. Linville" > wrote: > > > These two patches don't seem to apply on wireless-next, and I don't > have time at the moment to fix them up.  Feel free to repost... Hello John,         No problem, you already pushed the 2 same patches from the first (too gene

[PATCH 1/1 linux-next] Btrfs: remove redundant btrfs_verify_qgroup_counts declaration.

2014-09-25 Thread Fabian Frederick
Do like disk-io function declared under CONFIG_BTRFS_FS_RUN_SANITY_TESTS and keep prototype in qgroup.h only Signed-off-by: Fabian Frederick --- fs/btrfs/ctree.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 089f6da..67ef9d1 100644 --- a/fs/btrfs

[PATCH 1/1 linux-next] btrfs: fix shadow warning on cmp

2014-09-25 Thread Fabian Frederick
cmp was declared twice in btrfs_compare_trees resulting in a shadow warning. This patch renames second internal variable. Signed-off-by: Fabian Frederick --- Compiled but untested. fs/btrfs/ctree.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/ctree.c b

[PATCH 1/1 linux-next] Btrfs: fix compilation errors under DEBUG

2014-09-24 Thread Fabian Frederick
bi_sector and bi_size moved to bi_iter since commit 4f024f3797c4 ("block: Abstract out bvec iterator") Signed-off-by: Fabian Frederick --- fs/btrfs/volumes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 5b5a5c

[PATCH 1/1 linux-next] nfs: fix duplicate proc entries

2014-09-24 Thread Fabian Frederick
fs/volumes = /proc/fs/nfsfs/servers Signed-off-by: Fabian Frederick --- fs/nfs/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/client.c b/fs/nfs/client.c index 8052020..f9f4845 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c @@ -1320,7 +1320,7 @@ static int nf

Re: [PATCH 1/1] checkpatch: check for subject uniqueness in git repository.

2014-09-20 Thread Fabian Frederick
> On 16 September 2014 at 18:31 Joe Perches wrote: > > > On Tue, 2014-09-16 at 18:15 +0200, Fabian Frederick wrote: > > > On 16 September 2014 at 05:22 Joe Perches wrote: > > > On Mon, 2014-09-15 at 20:43 +0200, Fabian Frederick wrote: > > > >

Re: [PATCH V3 RESEND] SYSV: logging update

2014-09-20 Thread Fabian Frederick
> On 20 September 2014 at 01:00 Andrew Morton wrote: > > > On Sat, 13 Sep 2014 23:12:36 +0200 Fabian Frederick wrote: > > > -use current logging functions > > -replace no level printk by pr_err > > -add debug.c / sysv_err function to include sb-&g

[PATCH 1/1] fs/cachefiles: add missing \n to kerror conversions

2014-09-20 Thread Fabian Frederick
commit 0227d6abb378 ("fs/cachefiles: replace kerror by pr_err") didn't include newline featuring in original kerror definition Reported-by: David Howells Cc: David Howells Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/cachefiles/bind.c | 8 fs/cach

Re: [PATCH 1/1 linux-next] jbd2: Fix sparse context imbalance warning

2014-09-20 Thread Fabian Frederick
> On 18 September 2014 at 22:44 Theodore Ts'o wrote: > > > On Thu, Sep 18, 2014 at 08:29:34PM +0200, Fabian Frederick wrote: > > spin_unlock after spin_lock only. > > > > This fixes the following sparse warning: > > fs/jbd2/transaction.c:1

[PATCH 1/1] jffs2: fix sparse warning: unexpected unlock

2014-09-18 Thread Fabian Frederick
fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock Signed-off-by: Fabian Frederick --- fs/jffs2/summary.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c index c522d09..a0bac7b 10064

[PATCH 1/1 linux-next] jbd2: Fix sparse context imbalance warning

2014-09-18 Thread Fabian Frederick
spin_unlock after spin_lock only. This fixes the following sparse warning: fs/jbd2/transaction.c:1102:20: warning: context imbalance in 'jbd2_journal_get_create_access' - different lock contexts for basic block Signed-off-by: Fabian Frederick --- fs/jbd2/transaction.c | 3 ++- 1 fi

[PATCH 1/1] fs/reiserfs/journal.c: fix sparse context imbalance warning

2014-09-18 Thread Fabian Frederick
Merge conditional unlock/lock in the same condition to avoid sparse warning: fs/reiserfs/journal.c:703:36: warning: context imbalance in 'add_to_chunk' - unexpected unlock Cc: reiserfs-de...@vger.kernel.org Cc: Jeff Mahoney Cc: Andrew Morton Signed-off-by: Fabian Frederick --- f

[PATCH 1/1] fs/cachefiles: fix sparse context imbalance warning

2014-09-18 Thread Fabian Frederick
Annotate cachefiles_uncache_page to avoid the following sparse warning: fs/cachefiles/rdwr.c:972:20: warning: context imbalance in 'cachefiles_uncache_page' - unexpected unlock Signed-off-by: Fabian Frederick --- fs/cachefiles/rdwr.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/1 RESEND] lib: rhashtable: remove second linux/log2.h inclusion

2014-09-17 Thread Fabian Frederick
linux/log2.h was included twice. Signed-off-by: Fabian Frederick --- lib/rhashtable.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index a2c7881..7b36e4d 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -23,7 +23,6 @@ #include #include

[PATCH 1/6] video: fbdev: stifb.c: use container_of to resolve stifb_info from fb_info

2014-09-17 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- PARISC cross-compiled but untested. drivers/video/fbdev/stifb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c

[PATCH 4/6] video: fbdev: cyber2000fb.c: use container_of to resolve cfb_info from fb_info

2014-09-17 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/video/fbdev/cyber2000fb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev

[PATCH 3/6] video: fbdev: controlfb.c: use container_of to resolve fb_info_control from fb_info

2014-09-17 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- PPC32 cross-compiled but untested. drivers/video/fbdev/controlfb.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/controlfb.c b/drivers

[PATCH 5/6] video: fbdev: pxafb.c: use container_of to resolve pxafb_info/layer from fb_info

2014-09-17 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- ARM-PXA cross-compiled but untested. drivers/video/fbdev/pxafb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers

[PATCH 6/6] video: fbdev: valkyriefb.c: use container_of to resolve fb_info_valkyrie from fb_info

2014-09-17 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- PPC32 cross-compiled but untested. drivers/video/fbdev/valkyriefb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video

[PATCH 2/6] video: fbdev: sa1100fb.c: use container_of to resolve sa1100fb_info from fb_info

2014-09-17 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- ARM/SA1100 cross-compiled but untested. drivers/video/fbdev/sa1100fb.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/sa1100fb.c b

[PATCH 0/6] video: fbdev: use container_of where possible

2014-09-17 Thread Fabian Frederick
Small patchset using container_of instead of casting on first structure member address. Fabian Frederick (6): video: fbdev: stifb.c: use container_of to resolve stifb_info from fb_info video: fbdev: sa1100fb.c: use container_of to resolve sa1100fb_info from fb_info video: fbdev

[PATCH 1/1 linux-next] ptrace: remove linux/compat.h inclusion under CONFIG_COMPAT

2014-09-16 Thread Fabian Frederick
Commit 84c751bd4aeb ("ptrace: add ability to retrieve signals without removing from a queue (v4)") includes globally in ptrace.c This patch removes inclusion under if defined CONFIG_COMPAT. Signed-off-by: Fabian Frederick --- kernel/ptrace.c | 1 - 1 file changed, 1 deletion(-) di

[PATCH 1/1 linux-next] ASoC: cs35l32: remove second linux/slab.h inclusion

2014-09-16 Thread Fabian Frederick
linux/slab.h was included twice. Signed-off-by: Fabian Frederick --- sound/soc/codecs/cs35l32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 76f628b..c125925 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs

[PATCH 1/1 linux-next] m68k/coldfire: remove second asm/mcfclk.h inclusion in m54xx.c

2014-09-16 Thread Fabian Frederick
asm/mcfclk.h was included twice. Signed-off-by: Fabian Frederick --- arch/m68k/coldfire/m54xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/m68k/coldfire/m54xx.c b/arch/m68k/coldfire/m54xx.c index eec7f71..075aaab 100644 --- a/arch/m68k/coldfire/m54xx.c +++ b/arch/m68k/coldfire

[PATCH 1/1] lib: rhashtable: remove second linux/log2.h inclusion

2014-09-16 Thread Fabian Frederick
linux/log2.h was included twice. Signed-off-by: Fabian Frederick --- lib/rhashtable.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index a2c7881..7b36e4d 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -23,7 +23,6 @@ #include #include

[PATCH 1/1] xfs: remove second xfs_quota.h inclusion in xfs_icache.c

2014-09-16 Thread Fabian Frederick
xfs_quota.h was included twice. Signed-off-by: Fabian Frederick --- fs/xfs/xfs_icache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c index 981b2cf..b45f7b2 100644 --- a/fs/xfs/xfs_icache.c +++ b/fs/xfs/xfs_icache.c @@ -33,7 +33,6 @@ #include

Re: [PATCH 1/1] checkpatch: check for subject uniqueness in git repository.

2014-09-16 Thread Fabian Frederick
> On 16 September 2014 at 05:22 Joe Perches wrote: > > > On Mon, 2014-09-15 at 20:43 +0200, Fabian Frederick wrote: > > Adding patch subject uniqueness check in checkpatch --strict mode. > > See Documentation/SubmittingPatches/globally-unique identifier. > &g

[PATCH 2/2] brcm80211: use container_of to resolve dma_info from dma_pub

2014-09-15 Thread Fabian Frederick
Use container_of instead of casting first structure member. Acked-by: Arend van Spriel Signed-off-by: Fabian Frederick --- Compiled but untested. V2: 2 separate patches for brcm80211 (suggested by Arend van Spriel) drivers/net/wireless/brcm80211/brcmsmac/dma.c | 38

[PATCH V2 1/2] brcm80211: use container_of to resolve brcms_phy from brcms_phy_pub

2014-09-15 Thread Fabian Frederick
Use container_of instead of casting first structure member. Acked-by: Arend van Spriel Signed-off-by: Fabian Frederick --- Compiled but untested. V2: 2 separate patches for brcm80211 (suggested by Arend van Spriel) .../net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c | 122

[PATCH 1/1] checkpatch: check for subject uniqueness in git repository.

2014-09-15 Thread Fabian Frederick
Adding patch subject uniqueness check in checkpatch --strict mode. See Documentation/SubmittingPatches/globally-unique identifier. Inspired-by: Andrew Morton Cc: Andrew Morton Cc: Joe Perches Signed-off-by: Fabian Frederick --- scripts/checkpatch.pl | 14 ++ 1 file changed, 14

Re: [PATCH 0/9 linux-next] drivers/gpu/drm: use container_of where possible

2014-09-15 Thread Fabian Frederick
> On 15 September 2014 at 01:13 One Thousand Gnomes > wrote: > > > On Sun, 14 Sep 2014 18:40:13 +0200 > Fabian Frederick wrote: > > > Small patchset using container_of instead of casting on first structure > > member address. > > Why. Container_of is

[PATCH 5/9 linux-next] drm/nouveau: use container_of to resolve nouveau_plane from drm_plane

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/nouveau/dispnv04/overlay.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b

[PATCH 2/9 linux-next] drm/mgag200: use container_of to resolve mga_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/mgag200/mgag200_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag200

[PATCH 3/9 linux-next] drm/radeon: use container_of to resolve radeon_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/radeon/radeon_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon

[PATCH 4/9 linux-next] drm/nouveau: use container_of to resolve nouveau_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm

[PATCH 9/9 linux-next] drm/udl: use container_of to resolve udl_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/udl/udl_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c index d1da339

[PATCH 7/9 linux-next] drm/gma500: use container_of to resolve psb_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/gma500/framebuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500

[PATCH 0/9 linux-next] drivers/gpu/drm: use container_of where possible

2014-09-14 Thread Fabian Frederick
Small patchset using container_of instead of casting on first structure member address. Fabian Frederick (9): drm/cirrus: use container_of to resolve cirrus_fbdev from drm_fb_helper drm/mgag200: use container_of to resolve mga_fbdev from drm_fb_helper drm/radeon: use container_of to

[PATCH 8/9 linux-next] drm/ast: use container_of to resolve ast_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/ast/ast_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c index cba45c7

[PATCH 6/9 linux-next] drm/qxl: use container_of to resolve qxl_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/qxl/qxl_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c index df56788

[PATCH 1/9 linux-next] drm/cirrus: use container_of to resolve cirrus_fbdev from drm_fb_helper

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpu/drm/cirrus/cirrus_fbdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b/drivers/gpu/drm/cirrus

[PATCH 1/1 linux-next] gpio: use container_of to resolve cs5535_gpio_chip from gpio_chip

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/gpio/gpio-cs5535.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c index 92ec58f

[PATCH 1/1 linux-next] ACPI: processor: use container_of to resolve acpi_madt_local_apic/sapic/x2apic from acpi_subtable_header

2014-09-14 Thread Fabian Frederick
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick --- Compiled but untested. drivers/acpi/processor_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index

[PATCH V3 RESEND] SYSV: logging update

2014-09-13 Thread Fabian Frederick
[sysv]: msg Cc: Christoph Hellwig Cc: Joe Perches Cc: Andrew Morton Signed-off-by: Fabian Frederick --- V3: Suggestions by Joe Perches: -use builtin function(0) instead of __func__ -use const sb in sysv_err -use standard KBUILD_MODNAME ": " fmt -remove \n from sysv_err V2: add sb->

[PATCH 4/4 linux-next] brcm80211: use container_of to resolve dma_info from dma_pub

2014-09-13 Thread Fabian Frederick
Use container_of instead of casting first structure member. Compiled but untested. Signed-off-by: Fabian Frederick --- drivers/net/wireless/brcm80211/brcmsmac/dma.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/net/wireless/brcm80211

[PATCH 3/4 linux-next] brcm80211: use container_of to resolve brcms_phy from brcms_phy_pub

2014-09-13 Thread Fabian Frederick
Use container_of instead of casting first structure member. Compiled but untested. Signed-off-by: Fabian Frederick --- .../net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c | 122 ++--- .../net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c | 6 +- .../net/wireless/brcm80211

[PATCH 2/4 linux-next] bna: use container_of to resolve bufdesc_ex from bufdesc

2014-09-13 Thread Fabian Frederick
Use container_of instead of casting first structure member. Compiled but untested. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/brocade/bna/bna_enet.c | 9 ++--- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCH 1/4 linux-next] net: fec: use container_of to resolve bufdesc_ex from bufdesc

2014-09-13 Thread Fabian Frederick
Use container_of instead of casting first structure member. ARM cross-compiled but untested. Signed-off-by: Fabian Frederick --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b

[PATCH 0/4 linux-next] drivers/net: use container_of where possible

2014-09-13 Thread Fabian Frederick
Small patchset using container_of instead of casting on first structure member address. Fabian Frederick (4): net: fec: use container_of to resolve bufdesc_ex from bufdesc bna: use container_of to resolve bufdesc_ex from bufdesc brcm80211: use container_of to resolve brcms_phy from

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-08-18 Thread Fabian Frederick
> On 05 August 2014 at 23:32 Zach Brown wrote: > > > > > > Hello Zach, > > > > > > > >     Here's an untested patch which > > > > > > Try testing it.  It's easy with virtualization and xfstests. > > > > > > You'll find that sending to a file fails because each individual file > > > write call th

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-08-05 Thread Fabian Frederick
> On 04 August 2014 at 20:31 Zach Brown wrote: > > > On Sat, Aug 02, 2014 at 02:24:49PM +0200, Fabian Frederick wrote: > > On Thu, 17 Jul 2014 12:01:52 -0700 > > Zach Brown wrote: > > > > > > > > @@ -515,7 +515,8 @@ static int write_bu

[PATCH 1/1 linux-next] ext4: fix comment in evict_inode()

2014-08-04 Thread Fabian Frederick
commit 91b0abe36a7b ("mm + fs: store shadow entries in page cache") replaced truncate_inode_pages by truncate_inode_pages_final Signed-off-by: Fabian Frederick --- fs/ext4/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/ino

[PATCH V3] SYSV: logging update

2014-08-02 Thread Fabian Frederick
sv]: msg Signed-off-by: Fabian Frederick --- V3: Suggestions by Joe Perches: -use builtin function(0) instead of __func__ -use const sb in sysv_err -use standard KBUILD_MODNAME ": " fmt -remove \n from sysv_err V2: add sb->s_id in logging (suggested by Christoph Hellwig) fs/s

Re: [PATCH 1/1] Btrfs: fix sparse warning

2014-08-02 Thread Fabian Frederick
On Thu, 17 Jul 2014 12:01:52 -0700 Zach Brown wrote: > > > > @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void > > > > *buf, > > > > u32 len, loff_t *off) > > > > > > Though this probably wants to be rewritten in terms of kernel_write(). > > > That'd give an opportunity to g

[RFC 1/1] fs/befs/linuxvfs.c: check superblock before dump operation

2014-08-01 Thread Fabian Frederick
need to call it before brelse(bh) but I don't know why befs_check_sb was called after brelse. Another thing I don't understand is why this problem appears now). Reported-By: Fengguang Wu Cc: Fengguang Wu Cc: Andrew Morton Cc: Joe Perches Signed-off-by: Fabian Frederick --- fs/b

Re: [befs] BUG: unable to handle kernel paging request at cfc07000

2014-08-01 Thread Fabian Frederick
_fmt and remove redundant prefixes >      - convert befs_() to va_format (based on patch by Joe Perches) >      - remove non standard %Lu >      - use __func__ for all debugging >      >     [a...@linux-foundation.org: fix printk warnings, reported by Fengguang] >     Sig

Re: [befs] BUG: unable to handle kernel paging request at cfc07000

2014-08-01 Thread Fabian Frederick
_fmt and remove redundant prefixes >      - convert befs_() to va_format (based on patch by Joe Perches) >      - remove non standard %Lu >      - use __func__ for all debugging >      >     [a...@linux-foundation.org: fix printk warnings, reported by Fengguang] >     Sig

SH 7619 CHCR values

2014-07-31 Thread Fabian Frederick
Hello,  Could you tell me where I could find SH 7619 CHCR values in order to solve the following errors ?      arch/sh/drivers/dma/dma-sh.c: In function 'calc_xmit_shift': arch/sh/drivers/dma/dma-sh.c:97:21: error: 'CHCR_TS_LOW_MASK' undeclared (first use in this function) arch/sh/drivers/dma/dma

Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

2014-07-28 Thread Fabian Frederick
> On 25 July 2014 at 00:02 Greg Kroah-Hartman > wrote: > > > On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote: > > Fix following sh-allmodconfig errors reported on kisskb > > " > > drivers/built-in.o: In function `ion_vm_fault': >

Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

2014-07-24 Thread Fabian Frederick
> On 24 July 2014 at 13:37 Oliver Neukum wrote: > > > On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote: > > Small patchset addressing break redundancy on drivers/usb branch > > (suggested by Joe Perches). > > Frankly, that is not a good idea. Somebody wil

[PATCH 10/10 linux-next] USB: microtek: remove unnecessary break after goto

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/image/microtek.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c index 37b44b0..5cf2111 100644 --- a/drivers/usb/image/microtek.c +++ b/drivers/usb/image/microtek.c @@ -294,7 +294,6

[PATCH 01/10 linux-next] USB: iowarrior: remove unnecessary break after goto

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/misc/iowarrior.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index c6bfd13..17ce9a4 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -381,7 +381,6

[PATCH 03/10 linux-next] usb: dcw3: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/dwc3/ep0.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index 21a3520..927dad3 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -422,7 +422,6 @@ static int

[PATCH 04/10 linux-next] usb: gadget: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/gadget/legacy/tcm_usb_gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/legacy/tcm_usb_gadget.c b/drivers/usb/gadget/legacy/tcm_usb_gadget.c index 6cdb7a5..fb7cbb4 100644 --- a/drivers/usb/gadget/legacy

[PATCH 07/10 linux-next] usb: storage: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/storage/freecom.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/storage/freecom.c b/drivers/usb/storage/freecom.c index ef16068..e6f8c1f 100644 --- a/drivers/usb/storage/freecom.c +++ b/drivers/usb/storage/freecom.c @@ -417,7

[PATCH 08/10 linux-next] USB: serial: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/serial/iuu_phoenix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c index 5ad4a0f..705e9dd 100644 --- a/drivers/usb/serial/iuu_phoenix.c +++ b/drivers/usb/serial

[PATCH 06/10 linux-next] xhci: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/host/xhci-mem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 8056d90..aa5eb64 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -1129,7 +1129,6 @@ int

[PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return

2014-07-24 Thread Fabian Frederick
Small patchset addressing break redundancy on drivers/usb branch (suggested by Joe Perches). Fabian Frederick (10): USB: iowarrior: remove unnecessary break after goto USB: usblcd: remove unnecessary break after return usb: dcw3: remove unnecessary break after return usb: gadget: remove

[PATCH 09/10 linux-next] USB: ftdi_sio: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/serial/ftdi_sio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index b9035c3..bb45c71 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -2414,7

[PATCH 02/10 linux-next] USB: usblcd: remove unnecessary break after return

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/misc/usblcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index 1184390..5085d69 100644 --- a/drivers/usb/misc/usblcd.c +++ b/drivers/usb/misc/usblcd.c @@ -190,7 +190,6 @@ static long

[PATCH 05/10 linux-next] usb: gadget: remove unnecessary break after goto

2014-07-24 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/usb/gadget/function/f_hid.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index a95290a..21c4b9c 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb

[PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

2014-07-23 Thread Fabian Frederick
e to `zap_page_range' make: *** [vmlinux] Error 1 " Signed-off-by: Fabian Frederick --- This is untested. drivers/staging/android/ion/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig

Re: [PATCH V2] SYSV: logging update

2014-07-23 Thread Fabian Frederick
> On 23 July 2014 at 17:07 Joe Perches wrote: > > > On Wed, 2014-07-23 at 16:50 +0200, Fabian Frederick wrote: > > -use current logging functions > > -replace no level printk by pr_err > > -add debug.c / sysv_err function to include sb->s_id > > -standard

[PATCH V2] SYSV: logging update

2014-07-23 Thread Fabian Frederick
-use current logging functions -replace no level printk by pr_err -add debug.c / sysv_err function to include sb->s_id -standardize prefix: "sysv (sb id): " and remove sb id from various logging at different places. -use __func__ -coalesce formats Signed-off-by: Fabian Frederick --

[RFC PATCH 1/1] add makepatch script

2014-07-21 Thread Fabian Frederick
sion 3 Of course it's only an RFC which would need more specifications... Inspired-By: Joe Perches Signed-off-by: Fabian Frederick --- Documentation/SubmittingPatches | 2 +- scripts/makepatch.pl| 133 2 files changed, 134 insertions

Re: Patch priority in subjects ?

2014-07-21 Thread Fabian Frederick
> On 21 July 2014 at 13:33 Richard Weinberger > wrote: > > > On Sun, Jul 20, 2014 at 7:36 PM, Joe Perches wrote: > > On Sun, 2014-07-20 at 19:13 +0200, Fabian Frederick wrote: > >> I was reading all those "friendly" messages around checkpatch -f lately

Re: [PATCH 14/30] ath6kl: remove unnecessary break after return

2014-07-21 Thread Fabian Frederick
> On 21 July 2014 at 10:17 Kalle Valo wrote: > > > Fabian Frederick writes: > > > Signed-off-by: Fabian Frederick > > Acked-by: Kalle Valo > > Who is taking this patch? Please let me know if I should apply it to my > tree. Thanks Kalle, David Miller alrea

Re: [PATCH 00/30] drivers/net: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
> On 21 July 2014 at 06:31 David Miller wrote: > > > From: Fabian Frederick > Date: Sun, 20 Jul 2014 16:16:08 +0200 > > > Second patchset after "remove unnecessary break after goto" addressing break > > redundancy on drivers/net branch > > (sugges

[PATCH 14/30] ath6kl: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/wireless/ath/ath6kl/init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index d5ef211..8ee7097 100644 --- a/drivers/net/wireless/ath/ath6kl/init.c +++ b/drivers

[PATCH 11/30] prism54: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/wireless/prism54/oid_mgt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/prism54/oid_mgt.c b/drivers/net/wireless/prism54/oid_mgt.c index 47b34bf..3a8d2db 100644 --- a/drivers/net/wireless/prism54/oid_mgt.c +++ b/drivers

[PATCH 12/30] cw1200: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/wireless/cw1200/fwio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/cw1200/fwio.c b/drivers/net/wireless/cw1200/fwio.c index e23d67e..6f1b9aa 100644 --- a/drivers/net/wireless/cw1200/fwio.c +++ b/drivers/net/wireless

[PATCH 23/30] bna: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/brocade/bna/cna_fwimg.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/cna_fwimg.c b/drivers/net/ethernet/brocade/bna/cna_fwimg.c index 6a68e8d..6f72771 100644 --- a/drivers/net/ethernet/brocade

[PATCH 30/30] ps3_gelic: remove unnecessary break after return

2014-07-20 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c index d568af1..1205472 100644 --- a/drivers/net

<    4   5   6   7   8   9   10   11   12   13   >