Re: [PATCH V2 2/3] arm64: dts: imx8mm-evk: Add i2c3 support

2019-10-07 Thread Fabio Estevam
Hi Anson, On Mon, Oct 7, 2019 at 10:28 PM Anson Huang wrote: > > Enable i2c3 for i.MX8MM EVK board. > > Signed-off-by: Anson Huang You could combine this patch with 3/3.

Re: [RFC PATCH v1 3/3] usb: phy: mxs: optimize disconnect line condition

2019-10-07 Thread Fabio Estevam
Hi Igor, On Mon, Oct 7, 2019 at 9:47 AM Igor Opaniuk wrote: > > From: Igor Opaniuk > > We only have below cases to disconnect line when suspend: > 1. Device mode without connection to any host/charger(no vbus). > 2. Device mode connect to a charger, usb suspend when > system is entering suspend.

Re: [PATCH] tty: serial: fsl_lpuart: Fix lpuart_flush_buffer()

2019-10-04 Thread Fabio Estevam
uart: Flush HW FIFOs in > .flush_buffer") > Signed-off-by: Andrey Smirnov Reviewed-by: Fabio Estevam

Re: [PATCH] media: i2c: adv7180: fix adv7280 BT.656-4 compatibility

2019-09-27 Thread Fabio Estevam
Hi Tim, On Wed, Sep 25, 2019 at 9:22 PM Tim Harvey wrote: > Have you looked at this yet? Without this patch the ADV7280A does not > output proper BT.656. We tested this on a Gateworks Ventana GW5404-G > which uses the ADV7280A connected to the IMX6 CSI parallel bus. I'm > hoping to see this get

Re: [PATCH 2/2] clk: imx: disable i.mx7ulp composite clock during initialization

2019-09-26 Thread Fabio Estevam
Hi Anson, On Mon, Aug 5, 2019 at 11:25 PM Anson Huang wrote: > > Hi, Stephen > I think we should resume this thread, without this patch, mainline > kernel boot up will cause mmc timeout all the time. If it is NOT good to > disabling those peripheral devices' clock in i.MX7ULP's clock dr

Re: [PATCH v9 11/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

2019-09-25 Thread Fabio Estevam
Hi Dan, On Wed, Sep 25, 2019 at 2:41 PM Dan Murphy wrote: > > chan0 { This should be chan@0 > chan-name = "R"; > led-cur = /bits/ 8 <0x20>; > max-cur = /bits/ 8 <0x60>; > + reg = <0>;

Re: [PATCH 5/5] arm64: dts: imx8mq: add DCSS node

2019-09-23 Thread Fabio Estevam
On Mon, Sep 23, 2019 at 2:01 PM Lucas Stach wrote: > No, they are not. Those are imx-irqsteer IRQs, this controller has 0 > irq cells, so the description in this patch is correct. Good point, thanks!

Re: [PATCH 5/5] arm64: dts: imx8mq: add DCSS node

2019-09-23 Thread Fabio Estevam
Hi Laurentiu, On Mon, Sep 23, 2019 at 11:14 AM Laurentiu Palcu wrote: > + > + dcss: dcss@0x32e0 { Node names should be generic, so: dcss: display-controller@32e0 > + #address-cells = <1>; > + #size-cells

Re: [PATCH v3 1/3] dmaengine: imx-sdma: fix buffer ownership

2019-09-19 Thread Fabio Estevam
Hi Philipp, On Thu, Sep 19, 2019 at 7:45 AM Philipp Puschmann wrote: > > BD_DONE flag marks ownership of the buffer. When 1 SDMA owns the > buffer, when 0 ARM owns it. When processing the buffers in > sdma_update_channel_loop the ownership of the currently processed > buffer was set to SDMA again

Re: [PATCH v2 0/3] Fix UART DMA freezes for i.MX SOCs

2019-09-19 Thread Fabio Estevam
Hi Philipp, On Thu, Sep 19, 2019 at 7:23 AM Philipp Puschmann wrote: > Philipp Puschmann (3): > dmaengine: imx-sdma: fix buffer ownership > dmaengine: imx-sdma: fix dma freezes These two fixes deserve a Fixes tag so that they could be backported to the stable tree. Thanks

Re: [PATCH 0/4] Fix UART DMA freezes for iMX6

2019-09-16 Thread Fabio Estevam
Hi Philipp, On Mon, Sep 16, 2019 at 10:55 AM Philipp Puschmann wrote: > Thanks for the hints. I will apply them if the contentual feedback is > positive. > > p.s. Did you forget to add Andy? I don't see a Andy in the to- and cc-list. Andy's e-mail is fugang.d...@nxp.com, which I added on Cc.

Re: [PATCH 0/4] Fix UART DMA freezes for iMX6

2019-09-12 Thread Fabio Estevam
Hi Philipp, Thanks for submitting these fixes. On Wed, Sep 11, 2019 at 11:50 AM Philipp Puschmann wrote: > > For some years and since many kernel versions there are reports that > RX UART DMA channel stops working at one point. So far the usual workaround > was > to disable RX DMA. This patches

Re: [PATCH 0/4] Fix UART DMA freezes for iMX6

2019-09-12 Thread Fabio Estevam
[Adding Robin and Andy] On Wed, Sep 11, 2019 at 11:50 AM Philipp Puschmann wrote: > > For some years and since many kernel versions there are reports that > RX UART DMA channel stops working at one point. So far the usual workaround > was > to disable RX DMA. This patches try to fix the underlyi

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Fabio Estevam
Adding Jon and Baruch On Tue, Sep 10, 2019 at 12:55 PM tinywrkb wrote: > > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. > > Since commit 5502b218e001 ("net: phy: use phy_resolve_aneg_linkmode in > ge

Re: [PATCH v3] gpio/mpc8xxx: change irq handler from chained to normal

2019-09-09 Thread Fabio Estevam
Hi Song, On Mon, Sep 9, 2019 at 11:12 AM Hui Song wrote: > static void mpc8xxx_irq_unmask(struct irq_data *d) > @@ -409,8 +409,14 @@ static int mpc8xxx_probe(struct platform_device *pdev) > if (devtype->gpio_dir_in_init) > devtype->gpio_dir_in_init(gc); > > - irq_s

Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-02 Thread Fabio Estevam
Hi Anson, On Mon, Sep 2, 2019 at 11:05 PM Anson Huang wrote: > + ret = input_register_device(input); > + if (ret < 0) { > + dev_err(&pdev->dev, "failed to register input device\n"); > + return ret; > + } > + > + pdata->input = input; > +

Re: [PATCH] ASoC: fsl_ssi: Fix clock control issue in master mode

2019-08-28 Thread Fabio Estevam
Hi Shengjiu, On Wed, Aug 28, 2019 at 2:21 AM Shengjiu Wang wrote: > > The test case is > arecord -Dhw:0 -d 10 -f S16_LE -r 48000 -c 2 temp.wav & > aplay -Dhw:0 -d 30 -f S16_LE -r 48000 -c 2 test.wav > > There will be error after end of arecord: > aplay: pcm_write:2051: write error: Input/output e

Re: [PATCH 1/2] mfd: rave-sp: Bump command timeout to 5 seconds

2019-08-11 Thread Fabio Estevam
Hi Lee, On Sat, Aug 10, 2019 at 12:42 PM Fabio Estevam wrote: > > From: Andrey Smirnov > > Command to erase application firmware on RAVE SP takes longer than one > second (it takes ~3s). Bump command timeout duration to 5 seconds in > order to avoid bogus timeouts

[PATCH 2/2] mfd: rave-sp: Add support for firmware update

2019-08-10 Thread Fabio Estevam
n RDU1 and RDU2 device, but should support any board that has RAVE SP MCU. Signed-off-by: Andrey Smirnov [fabio: Fixed checkpatch warnings] Signed-off-by: Fabio Estevam --- drivers/mfd/rave-sp.c | 406 include/linux/mfd/rave-sp.h | 4 + 2 files ch

[PATCH 1/2] mfd: rave-sp: Bump command timeout to 5 seconds

2019-08-10 Thread Fabio Estevam
by: Andrey Smirnov Signed-off-by: Fabio Estevam --- drivers/mfd/rave-sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c index 26c7b63e008a..546763d8a3e5 100644 --- a/drivers/mfd/rave-sp.c +++ b/drivers/mfd/rave-sp.c @@ -371,7 +37

Re: [PATCH] net: fec: Allow the driver to be built for ARM64 SoCs such as i.MX8

2019-08-07 Thread Fabio Estevam
Hi Frieder, On Wed, Aug 7, 2019 at 9:04 AM Schrempf Frieder wrote: > > From: Frieder Schrempf > > The FEC ethernet controller is used in some ARM64 SoCs such as i.MX8. > To make use of it, append ARM64 to the list of dependencies. ARCH_MXC is also used by i.MX8, so there is no need for such cha

Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-07 Thread Fabio Estevam
Hi Philippe, On Wed, Aug 7, 2019 at 5:26 AM Philippe Schenker wrote: > > From: Stefan Agner > > Add pinmuxing and do not specify voltage restrictions for the usdhc > instance available on the modules edge connector. This allows to use > SD-cards with higher transfer modes if supported by the car

Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

2019-08-02 Thread Fabio Estevam
ly, it is ipuv3-crtc.o that is built via imxdrm-objs, not imx-ipuv3-crtc.o. Apart from that: Reviewed-by: Fabio Estevam

Re: [PATCH] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib

2019-08-01 Thread Fabio Estevam
t; > Signed-off-by: Frieder Schrempf Looks good to me: Reviewed-by: Fabio Estevam Also adding Geert on Cc as the patch touches sh-sci. Thanks > --- > drivers/tty/serial/serial_mctrl_gpio.c | 3 +++ > drivers/tty/serial/serial_mctrl_gpio.h | 6 +++--- > drivers/tty/serial/sh-sci.c

Re: [PATCH] ARM: imx: Drop imx_anatop_init()

2019-07-31 Thread Fabio Estevam
affected > i.MX6 SoCs. > > NOTE: Imx_anatop_init() was also called for i.MX7D, but looking at its > datasheet it appears to have a different USB PHY IP block, so > executing i.MX6 charger disable configuration seems unnecessary. > > Signed-off-by: Andrey Smirnov > Cc: Chris Hea

Re: [PATCH v2 00/23] LPUART fixes and improvements

2019-07-31 Thread Fabio Estevam
Hi Andrey, On Wed, Jul 31, 2019 at 2:53 PM Andrey Smirnov wrote: > > Everyone: > > This series contains fixes/improvements to LPUART dirver I came up > with recently as well as fixes picked up from Toradex and NXP Vybrid > repos. > > Feedback is welcome! > > Changes since [v1]: Greg has already

Re: [PATCH 3/3] drm/bridge: Add NWL MIPI DSI host controller support

2019-07-31 Thread Fabio Estevam
Hi Guido, On Wed, Jul 31, 2019 at 11:35 AM Guido Günther wrote: > The idea is to have > > "%sabling platform clocks", enable ? "en" : "dis"); > > depending whether clocks are enabled/disabled. Yes, I understood the idea, but this would print: ensabling or dissabling :-) > > Same here. Ple

Re: [PATCH v2] ARM: dts: vf610-bk4: Fix qspi node description

2019-07-31 Thread Fabio Estevam
0 > <1>: Bus A, CS 1 > <2>: Bus B, CS 0 > <3>: Bus B, CS 1" > > According to above with new driver the second SPI-NOR memory shall > have reg=<2> as it is connected to Bus B, CS 0. > > Signed-off-by: Lukasz Majewski > Suggested-by: Fabio Estev

Re: [PATCH v2 07/20] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-07-31 Thread Fabio Estevam
On Wed, Jul 31, 2019 at 9:38 AM Philippe Schenker wrote: > > From: Stefan Agner > > Add pinmuxing and do not specify voltage restrictions in the > module level device tree. It would be nice to explain the reason for doing this. > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker

Re: [PATCH v2 08/20] ARM: dts: imx7-colibri: Add touch controllers

2019-07-31 Thread Fabio Estevam
On Wed, Jul 31, 2019 at 9:38 AM Philippe Schenker wrote: > > Add atmel mxt multitouch controller and TouchRevolution multitouch You missed to updated the commit log ;-)

Re: [PATCH 14/22] ARM: dts: apalis-imx6: Add some example I2C devices

2019-07-30 Thread Fabio Estevam
On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker wrote: > &backlight { > @@ -204,6 +228,77 @@ > */ > &i2c3 { > status = "okay"; > + > + adv7280: adv7280@21 { > + compatible = "adv7280"; > + reg = <0x21>; > + pinctrl-names = "default";

Re: [PATCH 12/22] ARM: dts: imx6: Add touchscreens used on Toradex eval boards

2019-07-30 Thread Fabio Estevam
On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker wrote: > + /* Atmel maxtouch controller */ > + atmel_mxt_ts: atmel_mxt_ts@4a { Generic node names, please: touchscreen@4a > + compatible = "atmel,maxtouch"; > + pinctrl-names = "default"; > +

Re: [PATCH 15/22] ARM: dts: apalis-imx6: Add some optional I2C devices

2019-07-30 Thread Fabio Estevam
Hi Philippe, On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker wrote: > +&mipi_csi { > + ipu_id = <0>; > + csi_id = <1>; > + v_channel = <0>; > + lanes = <2>; None of these properties are valid upstream.

Re: [PATCH v3 2/2] ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards

2019-07-30 Thread Fabio Estevam
; - compatible : Should be ",", and generic value "atmel,at25". >Example "," values: > +"anvo,anv32e61w" This usually comes as a separate patch, but anyway: Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board

2019-07-30 Thread Fabio Estevam
Hi Lukasz, On Tue, Jul 30, 2019 at 12:53 PM Lukasz Majewski wrote: > Shall I refer to the original commit (which added this DTS)? Or the > original issue posted to linux-mtd [1] ? You can add a Fixes tag like this: Fixes: a67d2c52a82f ("ARM: dts: Add support for Liebherr's BK4 device (vf610 ba

Re: [PATCH] ARM: DTS: vybrid: Update qspi node description for VF610 BK4 board

2019-07-30 Thread Fabio Estevam
ected to Bus B, CS 0. I am glad you got it working! This looks very familiar with the suggestion I sent yesterday: http://lists.infradead.org/pipermail/linux-mtd/2019-July/090655.html It is a good practice to give some credit to someone who has helped in finding the solution of your problem. Adding a Suggested-by: Fabio Estevam would be nice here. This also needs a Fixes tag.

Re: [PATCH V2 4/4] thermal: qoriq: Add clock operations

2019-07-29 Thread Fabio Estevam
Hi Anson, On Tue, Jul 30, 2019 at 12:00 AM Anson Huang wrote: > Shawn already applied the patch, and Abel has the AHB clock patch to fix that, > so just wait for the AHB clock patch in instead of revert the TMU clock patch? Sorry, I don't understand Abel's patch as there is not a proper descrip

Re: [PATCH] ARM: dts: imx25-pdk: native-mode is part of display-timings

2019-07-29 Thread Fabio Estevam
it's located outside of display-timings, the native-mode setting is > ignored and the first display timing is used (which is a problem only if > someone adds another display timing). > > Signed-off-by: Martin Kaiser Reviewed-by: Fabio Estevam

Re: [PATCH v2] clk: imx8mq: Mark AHB clock as critical

2019-07-29 Thread Fabio Estevam
Hi Abel, On Mon, Jul 29, 2019 at 12:07 PM Abel Vesa wrote: > Please have a the explanation here: > > https://lkml.org/lkml/2019/7/28/306 I read that and it is still not clear for me: which hang exactly are you referring to in your comment below the --- line? Reading the commit log it is not cl

Re: [PATCH] dt-bindings: imx: i.MX8MN: Use space instead of tab

2019-07-29 Thread Fabio Estevam
Hi Guido, On Sat, Jul 27, 2019 at 8:29 AM Guido Günther wrote: > > This fixes 'make dt_binding_check' > > Signed-off-by: Guido Günther Thanks for the patch, but Anson has already submitted a fix for this issue: https://patchwork.kernel.org/patch/11057815/

Re: [PATCH V2 4/4] thermal: qoriq: Add clock operations

2019-07-29 Thread Fabio Estevam
Hi Anson, On Mon, Jul 29, 2019 at 6:04 AM wrote: > > From: Anson Huang > > Some platforms like i.MX8MQ has clock control for this module, > need to add clock operations to make sure the driver is working > properly. I haven't seen this series earlier, and I have sent a similar patch for Guido t

Re: [PATCH V2 3/4] dt-bindings: thermal: qoriq: Add optional clocks property

2019-07-29 Thread Fabio Estevam
Hi Anson, On Mon, Jul 29, 2019 at 6:04 AM wrote: > > From: Anson Huang > > Some platforms have clock control for TMU, add optional > clocks property to the binding doc. Please add a note that this is needed for i.MX8M.

Re: [PATCH v2] clk: imx8mq: Mark AHB clock as critical

2019-07-29 Thread Fabio Estevam
Hi Abel, On Mon, Jul 29, 2019 at 4:23 AM Abel Vesa wrote: > > Keep the AHB clock always on since there is no driver to control it and > all the other clocks that use it as parent rely on it being always enabled. > > Signed-off-by: Abel Vesa > Tested-by: Daniel Baluta > --- > > Changes since v1:

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-28 Thread Fabio Estevam
Hi Guido, On Sun, Jul 28, 2019 at 4:59 AM Guido Günther wrote: > Yes, this fixes it for me, thanks! Thanks for testing it. I will send a formal patch tomorrow. Regards, Fabio Estevam

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-27 Thread Fabio Estevam
e, shouldn't it do so? Yes, I think you are right. I don't have access to a imx8mq board at the moment, but something like below would probably help: http://code.bulix.org/pd88jp-812381 If it helps, I can send it as a formal patch. Regards, Fabio Estevam

Re: [PATCH] ARM: dts: imx: Cleanup style around assignment operator

2019-07-27 Thread Fabio Estevam
Hi Krzysztof, On Sat, Jul 27, 2019 at 11:26 AM Krzysztof Kozlowski wrote: > > Use a space before and after assignment operator to have consistent > style. > > Signed-off-by: Krzysztof Kozlowski Thanks for doing this cleanup: Reviewed-by: Fabio Estevam

Re: [PATCH v2 2/2] ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards

2019-07-26 Thread Fabio Estevam
Hi Krzysztof, On Fri, Jul 26, 2019 at 3:17 AM Krzysztof Kozlowski wrote: > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > index 7294ac36f4c0..afb61a55e26f 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Docu

Re: [PATCH 1/2] bus: imx-weim: optionally enable burst clock mode

2019-07-25 Thread Fabio Estevam
; Any feedback on this patch, positive or negative? Looks good to me: Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-07-25 Thread Fabio Estevam
On Thu, Jul 25, 2019 at 10:56 AM Dafna Hirschfeld wrote: > > From: Gary Bisson > > i.MX 8Quad is a quad (4x) Cortex-A53 processor with powerful > graphic and multimedia features. Instead of describing the SoC, it would be better to describe the i.MX8M nitrogen board instead.

Re: [PATCH v2 1/2] dt-bindings: arm: imx: add imx8mq nitrogen support

2019-07-25 Thread Fabio Estevam
Hi Dafna, On Thu, Jul 25, 2019 at 10:56 AM Dafna Hirschfeld wrote: > > From: Gary Bisson > > i.MX 8Quad is a quad (4x) Cortex-A53 processor with powerful > graphic and multimedia features. > This patch adds Nitrogen8M board support. > > Signed-off-by: Gary Bisson > Signed-off-by: Troy Kisky >

Re: [PATCH 2/2] arm64: dts: imx: Add i.mx8mq nitrogen8m basic dts support

2019-07-25 Thread Fabio Estevam
Hi Dafna, On Wed, Jul 24, 2019 at 2:51 PM Dafna Hirschfeld wrote: > > From: dafna > > Add basic dts support for i.MX8MQ NITROGEN8M. > > Signed-off-by: Gary Bisson > Signed-off-by: Dafna Hirschfeld Your From and Signed-off-by tags do not match. > --- > arch/arm64/boot/dts/freescale/Makefile

Re: [PATCH v5 1/2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M

2019-07-20 Thread Fabio Estevam
interrupts = <3 GPIO_ACTIVE_LOW>; but here you use gpio1 3 instead, so there is a mismatch. Please check against the schematics and pick the correct one. I would suggest removing the: /* PMIC BD71837 PMIC_nINT GPIO1_IO12 */ comment entirely. For the next version you can: Reviewed-by: Fabio Estevam Thanks

Re: [PATCH v4 1/2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M

2019-07-19 Thread Fabio Estevam
Hi Andra, On Fri, Jul 19, 2019 at 7:48 AM andradanciu1997 wrote: > + pmic: pmic@4b { > + reg = <0x4b>; > + compatible = "rohm,bd71837"; > + /* PMIC BD71837 PMIC_nINT GPIO1_IO12 */ > + pinctrl-names = "default"; > + pinct

Re: [PATCH v3 1/2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M

2019-07-18 Thread Fabio Estevam
Hi Andra, On Thu, Jul 18, 2019 at 9:16 AM Andra Danciu wrote: > > From: Richard Hu Please put a few words about the board and a link to its webpage, if available. > The current level of support yields a working console and is able to boot > userspace from NFS or init ramdisk. > > Additional su

Re: [PATCH] net: fec: generate warning when using deprecated phy reset

2019-07-18 Thread Fabio Estevam
On Thu, Jul 18, 2019 at 1:49 PM Lucas Stach wrote: > > Am Donnerstag, den 18.07.2019, 10:34 -0400 schrieb Sven Van Asbroeck: > > Allowing the fec to reset its PHY via the phy-reset-gpios > > devicetree property is deprecated. To improve developer > > awareness, generate a warning whenever the depr

Re: [PATCH v4 6/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-07-17 Thread Fabio Estevam
> Reviewed-by: Marcel Ziswiler > Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam

Re: [PATCH v4 5/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-07-17 Thread Fabio Estevam
er > Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam

Re: [PATCH v4 4/6] ASoC: sgtl5000: add ADC mute control

2019-07-17 Thread Fabio Estevam
On Wed, Jul 17, 2019 at 1:30 PM Oleksandr Suvorov wrote: > > This control mute/unmute the ADC input of SGTL5000 > using its CHIP_ANA_CTRL register. > > Signed-off-by: Oleksandr Suvorov > Reviewed-by: Marcel Ziswiler > Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam

Re: [PATCH v4 3/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-07-17 Thread Fabio Estevam
On Wed, Jul 17, 2019 at 1:30 PM Oleksandr Suvorov wrote: > > SGTL5000_SMALL_POP is a bit mask, not a value. Usage of > correct definition makes device probing code more clear. > > Signed-off-by: Oleksandr Suvorov > Reviewed-by: Marcel Ziswiler > Reviewed-by: Igor Opaniuk

Re: [PATCH v4 2/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-07-17 Thread Fabio Estevam
y pops/clicks, > the outputs should be muted during input/output > routing changes. > > [1] https://www.nxp.com/docs/en/data-sheet/SGTL5000.pdf > > Signed-off-by: Oleksandr Suvorov > Reviewed-by: Marcel Ziswiler > Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 cod

Re: [PATCH v4 1/6] ASoC: Define a set of DAPM pre/post-up events

2019-07-17 Thread Fabio Estevam
On Wed, Jul 17, 2019 at 1:30 PM Oleksandr Suvorov wrote: > > Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to > reduce coming code size and make it more readable. > > Signed-off-by: Oleksandr Suvorov > Reviewed-by: Marcel Ziswiler > Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam

Re: [PATCH v3 0/6] VAG power control improvement for sgtl5000 codec

2019-07-15 Thread Fabio Estevam
Hi Oleksandr, Your series looks good, thanks. I only have one suggestion. On Fri, Jul 12, 2019 at 11:56 AM Oleksandr Suvorov wrote: > > > VAG power control is improved to fit the manual [1]. This patchset fixes as > minimum one bug: if customer muxes Headphone to Line-In right after boot, > the

Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path

2019-07-05 Thread Fabio Estevam
On Fri, Jul 5, 2019 at 10:09 AM Sven Van Asbroeck wrote: > You are of course right, I was looking at the wrong if. > > Apologies for the confusion, I did try to look at what you > changed, but your git repo listed in MAINTAINERS appears > unresponsive for me? Works fine here: https://git.kernel.

Re: [Linux-kernel-mentee, PATCH] media: dvb_frontend.h: Fix shifting signed 32-bit value problem

2019-07-04 Thread Fabio Estevam
Hi Luke, On Thu, Jul 4, 2019 at 3:22 PM Luke Nowakowski-Krijger wrote: > > Fix DVBFE_ALGO_RECOVERY and DVBFE_ALGO_SEARCH_ERROR to use U cast which > fixes undefined behavior error by certain compilers. > > Signed-off-by: Luke Nowakowski-Krijger > --- > include/media/dvb_frontend.h | 4 ++-- > 1

Re: [EXT] [BUG BISECT] Net boot fails on VF50 after "dmaengine: fsl-edma: support little endian for edma driver"

2019-07-04 Thread Fabio Estevam
Hi Peng, On Wed, Jul 3, 2019 at 11:10 PM Peng Ma wrote: > So we need this patch, I make some changes,Please help me to test attatchment > on VF50 board, You need to change the Subject to something like: Subject: [PATCH] dmaengine: fsl-edma: Add support for LS1028A Also, in the commit log, pl

Re: [BUG BISECT] Net boot fails on VF50 after "dmaengine: fsl-edma: support little endian for edma driver"

2019-07-02 Thread Fabio Estevam
On Tue, Jul 2, 2019 at 10:11 AM Krzysztof Kozlowski wrote: > No, unfortunately it does not help. Just looked at "dmaengine: fsl-edma: support little endian for edma driver" more closely and this one assumes that there wasn't little-endian support originally, which is incorrect. Vybryd, i.MX7ULP

Re: [BUG BISECT] Net boot fails on VF50 after "dmaengine: fsl-edma: support little endian for edma driver"

2019-07-02 Thread Fabio Estevam
Hi Krzysztof, On Tue, Jul 2, 2019 at 9:13 AM Krzysztof Kozłowski wrote: > > Hi, > > Bisect pointed commit: > commit 002905eca5bedab08bafd9e32541670c7712 > Author: Peng Ma > Date: Thu Jun 13 10:27:08 2019 + > dmaengine: fsl-edma: support little endian for edma driver > > as a reason

Re: [PATCH] thermal: imx: skip registering legacy cooling on i.MX7

2019-06-18 Thread Fabio Estevam
Hi Andrey, On Fri, Jun 14, 2019 at 4:41 AM Andrey Smirnov wrote: > > i.MX7 doesn't have a mainline cpufreq driver, so i.MX7 uses the generic cpufreq-dt driver since commit: commit e3526f004a35e5f324b1c835bca056f4df05bff0 Author: Bai Ping Date: Tue Nov 24 18:25:16 2015 +0800 ARM: imx: en

Re: [PATCH v2 1/2] ARM: dts: Add ZII support for ZII i.MX7 RMU2 board

2019-06-17 Thread Fabio Estevam
On Mon, Jun 17, 2019 at 12:30 PM Andrey Smirnov wrote: > > Add support for ZII's i.MX7 based Remote Modem Unit 2 (RMU2) board. > > Signed-off-by: Andrey Smirnov Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] ARM: dts: Add ZII support for ZII i.MX7 RMU2 board

2019-06-16 Thread Fabio Estevam
Hi Andrey, On Fri, Jun 14, 2019 at 5:03 AM Andrey Smirnov wrote: > + mdio { > + fec1_phy: phy@0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet1_phy_reset>, > + <&pinctrl_enet1_phy_i

Re: [PATCH 2/2] dt-bindings: arm: fsl: Add support for ZII i.MX7 RMU2 board

2019-06-16 Thread Fabio Estevam
oard > + - zii,imx7d-rmu2# ZII RMU2 Board Nit: Please keep the entries in alphabetical order. Other than that: Reviewed-by: Fabio Estevam

Re: iMX6 5.2-rc3 boot failure due to "PCI: imx6: Allow asynchronous probing"

2019-06-14 Thread Fabio Estevam
Hi Robert, On Tue, Jun 11, 2019 at 8:05 PM Robert Hancock wrote: > Based on some tests, it appears that may help - however it is hard to be > conclusive since the behavior is somewhat random, it doesn't fail every > time. The first few times I booted this version, I didn't see the > problem, but

Re: [PATCH 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-14 Thread Fabio Estevam
On Fri, Jun 14, 2019 at 8:53 AM Robert Chiras wrote: > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > Signed-off-by: Robert Chiras > --- > .../bindings/display/panel/raydium,rm67191.txt | 42 > ++ > 1 file changed, 42 insertions(+) > create mode 1006

Re: iMX6 5.2-rc3 boot failure due to "PCI: imx6: Allow asynchronous probing"

2019-06-11 Thread Fabio Estevam
Hi Robert, On Tue, Jun 11, 2019 at 4:02 PM Robert Hancock wrote: > > [ 13.193578] imx6q-pcie 1ffc000.pcie: host bridge /soc/pcie@1ffc000 > > ranges: > > [ 13.200635] imx6q-pcie 1ffc000.pcie:IO 0x01f8..0x01f8 -> > > 0x > > [ 13.201454] imx-sdma 20ec000.sdma: loaded firmw

Re: [PATCH 2/3] rtc: imx-sc: Make compatible string more generic

2019-06-11 Thread Fabio Estevam
Hi Anson, On Tue, Jun 11, 2019 at 3:31 AM wrote: > > From: Anson Huang > > i.MX system controller RTC driver can support all i.MX SoCs > with system controller inside, this patch makes the compatible > string more generic to support other i.MX SoCs with system > controller inside, such as i.MX8Q

Re: linux-next: Tree for Jun 5 (staging/media/imx/)

2019-06-05 Thread Fabio Estevam
Hi Randy, On Wed, Jun 5, 2019 at 4:37 PM Randy Dunlap wrote: > on x86_64: > > ld: drivers/staging/media/imx/imx-media-internal-sd.o: in function > `imx_media_register_ipu_internal_subdevs': > imx-media-internal-sd.c:(.text+0xd1): undefined reference to `ipu_get_num' Thanks for reporting this p

Re: [PATCH] arm64: dts: imx8mm: Fix build warnings

2019-06-02 Thread Fabio Estevam
Hi Anson, On Sun, Jun 2, 2019 at 9:46 PM wrote: > > From: Anson Huang > > This patch fixes below build warning with "W=1": I have already sent patches to fix these warnings.

Re: [PATCH 2/3] arm64: dts: freescale: Add i.MX8MN dtsi support

2019-05-31 Thread Fabio Estevam
On Thu, May 30, 2019 at 6:45 AM wrote: > + gpio1: gpio@3020 { > + compatible = "fsl,imx8mn-gpio", > "fsl,imx35-gpio"; > + reg = <0x3020 0x1>; > + interrupts = , > +

[PATCH] dt-bindings: reset: imx7: Fix the spelling of 'indices'

2019-05-24 Thread Fabio Estevam
The correct spelling is 'indices', so fix it accordingly. Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/reset/fsl,imx7-src.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt b/Doc

[PATCH] nvmem: Broaden the selection of NVMEM_SNVS_LPGPR

2019-05-22 Thread Fabio Estevam
The SNVS LPGR IP block is also found on other i.MX SoCs that are not covered by the current SOC_IMX6 || SOC_IMX7D logic. One example is the i.MX7ULP. To avoid keep expanding the SoC logic selection, make it broader by using the more generic ARCH_MXC symbol instead. Signed-off-by: Fabio Estevam

Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-05-20 Thread Fabio Estevam
On Mon, May 20, 2019 at 7:12 AM Daniel Baluta wrote: > > > > Shengjiu, > > Can you help me with this? Specifically: I couldn't find the schematic > showing the > exact connection pins between SAI and wm8524 codec. > > I looked into our internal tree and the wm8524 codec always handles > CLK_SAIX_

Re: [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes

2019-05-20 Thread Fabio Estevam
On Thu, May 16, 2019 at 3:33 PM Fabio Estevam wrote: > > Hi Daniel, > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > > i.MX8MM has 5 SAI instances with the following base > > addresses according to RM. > > > > SAI1 base address: 30

Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-05-20 Thread Fabio Estevam
On Thu, May 16, 2019 at 3:35 PM Fabio Estevam wrote: > > On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > > + simple-audio-card,codec { > > + sound-dai = <&wm8524>; > > +

Re: [PATCH] staging: iio: adis16240: add device to module device table

2019-05-18 Thread Fabio Estevam
Hi Lucas, On Sat, May 18, 2019 at 6:01 PM Lucas Oshiro wrote: > > Add a of_device_id struct and MODULE_DEVICE_TABLE call. Please provide an explanation as to why you are doing this. Thanks

Re: [PATCH] staging: media: imx: fix Unneeded variable: "ret". Return "0"

2019-05-18 Thread Fabio Estevam
On Sat, May 18, 2019 at 2:38 PM Hariprasad Kelam wrote: > > fix below warning reported by coccichec > > drivers/staging/media/imx/imx-media-capture.c:617:5-8: Unneeded > variable: "ret". Return "0" on line 630 > > Signed-off-by: Hariprasad Kelam Reviewed-by: Fabio Estevam Thanks

Re: [PATCH V2] clk: imx: imx8mm: fix int pll clk gate

2019-05-17 Thread Fabio Estevam
On Fri, May 17, 2019 at 4:27 AM Peng Fan wrote: > > Fixes: ba5625c3e27 ("clk: imx: Add clock driver support for imx8mm") > To Frac pll, the gate shift is 13, however to Int PLL the gate shift > is 11. > > Cc: The Fixes tag should go here instead. > Signed-off-by:

Re: [PATCH v3 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-05-16 Thread Fabio Estevam
On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > + simple-audio-card,codec { > + sound-dai = <&wm8524>; > + clocks = <&clk IMX8MM_CLK_SAI3_ROOT>; IMX8MM_CLK_SAI3_ROOT is the internal clock that drives the SAI3 interface, not an ext

Re: [PATCH v3 1/2] arm64: dts: imx8mm: Add SAI nodes

2019-05-16 Thread Fabio Estevam
Hi Daniel, On Wed, May 15, 2019 at 11:42 AM Daniel Baluta wrote: > > i.MX8MM has 5 SAI instances with the following base > addresses according to RM. > > SAI1 base address: 3001_h > SAI2 base address: 3002_h > SAI3 base address: 3003_h > SAI5 base address: 3005_h > SAI6 base addre

Re: [alsa-devel] [PATCH] ASoC: AK4458: add regulator for ak4458

2019-05-16 Thread Fabio Estevam
On Thu, May 16, 2019 at 10:02 AM Viorel Suman wrote: > + for (i = 0; i < ARRAY_SIZE(ak4458->supplies); i++) > + ak4458->supplies[i].supply = ak4458_supply_names[i]; > + > + ret = devm_regulator_bulk_get(ak4458->dev, > ARRAY_SIZE(ak4458->supplies), > +

Re: [alsa-devel] [PATCH V5] ASoC: cs42xx8: add reset-gpios in binding document

2019-05-16 Thread Fabio Estevam
VLC-supply = <®_audio>; > + reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_LOW>; Reviewed-by: Fabio Estevam

Re: [alsa-devel] [PATCH V4] ASoC: cs42xx8: add reset-gpios in binding document

2019-05-16 Thread Fabio Estevam
On Thu, May 16, 2019 at 8:36 AM S.j. Wang wrote: > cs42888: codec@48 { > @@ -25,4 +30,5 @@ cs42888: codec@48 { > VD-supply = <®_audio>; > VLS-supply = <®_audio>; > VLC-supply = <®_audio>; > + reset-gpios = <&pca9557_b 1 1>; reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_

Re: [alsa-devel] [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

2019-05-16 Thread Fabio Estevam
On Thu, May 16, 2019 at 8:25 AM S.j. Wang wrote: > cs42888: codec@48 { > @@ -25,4 +30,5 @@ cs42888: codec@48 { > VD-supply = <®_audio>; > VLS-supply = <®_audio>; > VLC-supply = <®_audio>; > + reset-gpio = <&pca9557_b 1 1>; Please use GPIO_ACTIVE_LOW instead as it m

Re: [PATCH] spi: spidev: Add dhcom-board to compatibility list [Klartext]

2019-05-16 Thread Fabio Estevam
Hi Christoph, It seems that the [Klartext] string is added in the Subject by mistake? On Thu, May 16, 2019 at 8:23 AM Christoph Niedermaier wrote: > > Prepare to use devices on the external SPI interface > on a DH electronics Development Board. > > Signed-off-by: Christoph Niedermaier

Re: [PATCH] clk: imx: imx8mm: fix int pll clk gate

2019-05-16 Thread Fabio Estevam
Hi Peng, On Thu, May 16, 2019 at 6:08 AM Peng Fan wrote: > > To Frac pll, the gate shift is 13, however to Int PLL the gate shift > is 11. > > Signed-off-by: Peng Fan > Reviewed-by: Jacky Bai Reviewed-by: Fabio Estevam Please add a Fixes tag and Cc stable. Thanks

Re: [PATCH v11 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-14 Thread Fabio Estevam
e : > > - Both USB ports > - SD card socket > - WiFi usdhc > - WWAN modem > - GNSS > - GPIO keys > - LEDs > - gyro > - magnetometer > - touchscreen > - pwm > - backlight > - haptic motor > > Signed-off-by: Angus Ainslie (Purism) Reviewed-by: Fabio Estevam

Re: [PATCH v11 1/4] MAINTAINERS: add an entry for for arm63 imx devicetrees

2019-05-14 Thread Fabio Estevam
On Mon, May 13, 2019 at 5:23 PM Angus Ainslie (Purism) wrote: > > Add an explicit reference to imx* devicetrees > > Signed-off-by: Angus Ainslie (Purism) There is a typo in the Subject: "arm63" --> "arm64". Reviewed-by: Fabio Estevam

Re: [PATCH v10 1/4] MAINTAINERS: add an entry for for arm64 imx devicetrees

2019-05-13 Thread Fabio Estevam
On Mon, May 13, 2019 at 2:41 PM Angus Ainslie (Purism) wrote: > > Add an explicit reference to imx* devicetrees > > Signed-off-by: Angus Ainslie (Purism) > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7707c28628b9..0871a21a5bbb 1006

Re: [PATCH 2/2] ARM: dts: vf610-zii-dev: Add QSPI node

2019-05-13 Thread Fabio Estevam
Hi Andrey, On Mon, May 13, 2019 at 12:59 AM Andrey Smirnov wrote: > +&qspi0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_qspi0>; > + status = "okay"; > + > + /* > +* Attached MT25QL02 can go up to 90Mhz in DTR and 166 in SDR > +* modes, so we

Re: [PATCH RESEND 1/2] soc: imx: Add SCU SoC info driver support

2019-05-12 Thread Fabio Estevam
On Sun, May 12, 2019 at 11:59 PM Anson Huang wrote: > + soc_dev = soc_device_register(soc_dev_attr); > + if (IS_ERR(soc_dev)) { > + kfree(soc_dev_attr->revision); > + return -ENODEV; This should return PTR_ERR(soc_dev) instead.

Re: [PATCH v8 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-11 Thread Fabio Estevam
Hi Angus, This looks good. Only minor issues: On Wed, May 1, 2019 at 7:57 PM Angus Ainslie (Purism) wrote: > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -0,0 +1,823 @@ > +/* SPDX-License-Identifier: GPL-2.0+ This should be // SPDX-License-Identifier: GPL-2.0+ as pointed

<    1   2   3   4   5   6   7   8   9   10   >