Re: [alsa-devel] [PATCH v2 5/5] ASoC: imx-spdif: don't print EPROBE_DEFER as error

2019-01-18 Thread Fabio Estevam
EPROBE_DEFER case likely > would get missed. > > Signed-off-by: Stefan Agner > Reviewed-by: Daniel Baluta > Acked-by: Nicolin Chen Reviewed-by: Fabio Estevam

Re: [alsa-devel] [PATCH v2 1/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails

2019-01-18 Thread Fabio Estevam
r > Reviewed-by: Daniel Baluta > Acked-by: Nicolin Chen Thanks for the re-ordering: Reviewed-by: Fabio Estevam

Re: [alsa-devel] [PATCH v2 3/5] ASoC: imx-sgtl5000: don't print EPROBE_DEFER as error

2019-01-18 Thread Fabio Estevam
On Fri, Jan 18, 2019 at 7:07 AM Stefan Agner wrote: > > Probe deferral is to be expected during normal operation, so avoid > printing an error when it is encountered. > > Signed-off-by: Stefan Agner > Reviewed-by: Daniel Baluta > Acked-by: Nicolin Chen Reviewed-by: Fabio Estevam

Re: [alsa-devel] [PATCH v2 2/5] ASoC: imx-sgtl5000: lower log level for potential probe deferral cases

2019-01-18 Thread Fabio Estevam
On Fri, Jan 18, 2019 at 7:07 AM Stefan Agner wrote: > > Not finding the codec/SSI instance can be due to probe deferral. > Do not print error messages in those cases. > > Signed-off-by: Stefan Agner > Reviewed-by: Daniel Baluta > Acked-by: Nicolin Chen Reviewed-by: Fabio Estevam

Re: [patch 3/9] crypto: morus - Cleanup license mess

2019-01-17 Thread Fabio Estevam
On Thu, Jan 17, 2019 at 9:17 PM Thomas Gleixner wrote: > --- a/include/crypto/morus1280_glue.h > +++ b/include/crypto/morus1280_glue.h > @@ -1,15 +1,10 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ Shouldn't this be: /* SPDX-License-Identifier:

Re: [PATCH v2] media: imx-csi: Input connections to CSI should be optional

2019-01-17 Thread Fabio Estevam
imx-ipuv3 280.ipu: driver could not parse port@0/endpoint@0 (-22) [3.472120] imx-ipuv3-csi: probe of imx-ipuv3-csi.4 failed with error -22 Tested-by: Fabio Estevam

Re: [PATCH 1/2] media: imx: csi: Disable CSI immediately after last EOF

2019-01-17 Thread Fabio Estevam
Hi Steve, On Thu, Jan 17, 2019 at 6:15 PM Steve Longerbeam wrote: > > Disable the CSI immediately after receiving the last EOF before stream > off (and thus before disabling the IDMA channel). > > This fixes a complete system hard lockup on the SabreAuto when streaming > from the ADV7180, by

Re: [alsa-devel] [PATCH 4/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails

2019-01-17 Thread Fabio Estevam
Hi Stefan, On Thu, Jan 17, 2019 at 7:07 AM Stefan Agner wrote: > > Make sure to properly put the of node in case finding the codec > fails. > > Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000") > Signed-off-by: Stefan Agner Looks good. I would suggest making this

Re: linux-next: Fixes tag needs some work in the clk tree

2019-01-16 Thread Fabio Estevam
On Wed, Jan 16, 2019 at 10:44 PM Stephen Boyd wrote: > Ok sure. Does this matter to scripts? Is it documented in > Documentation/process/submitting-patches.rst? I've seen both types, one >From Documentation/process/submitting-patches.rst" "If your patch fixes a bug in a specific commit, e.g.

Re: [PATCH] arm64: dts: imx: Fix MU4_INT number

2019-01-16 Thread Fabio Estevam
2. It would be nice to add a Fixes tag Reviewed-by: Fabio Estevam

Re: [PATCH] dma: ixm-dma: fix warning comparison of distinct pointer types

2019-01-14 Thread Fabio Estevam
en(sg)); > ^~~ > > Rework so that we use min_t and pass in the size_t that returns the > minimum of two values, using the specified type. > > Signed-off-by: Anders Roxell There is a typo in the Subject: s/ixm/imx/ and the prefix should be dmaengine instead: dmaengine: imx-dma: fix warning comparison of distinct pointer types With that fixed: Reviewed-by: Fabio Estevam

Re: Regression: i.MX6: pinctrl: fsl: add scu based pinctrl support

2019-01-14 Thread Fabio Estevam
Hi Mika, On Mon, Jan 14, 2019 at 3:17 PM Mika Penttilä wrote: > I am merging mainline and this regression is present in 5.0-rc2 so it should > have the mentioned patch applied. Merging mainline? Could you test this against a clean mainline tree? > Obviously I had to revert them both

Re: Regression: i.MX6: pinctrl: fsl: add scu based pinctrl support

2019-01-14 Thread Fabio Estevam
Hi Mika, On Mon, Jan 14, 2019 at 8:21 AM Mika Penttilä wrote: > > Hello, > > > The patch titled "pinctrl: fsl: add scu based pinctrl support" causes > regression on i.MX6. Tested on a custom board based on > i.MX6Q and sgtl5000 codec, there is no sound, tested with simple wav > playing. > >

Re: [PATCH 08/10] drm/mxsfb: Update mxsfb to support LCD reset

2019-01-10 Thread Fabio Estevam
Hi Robert, On Thu, Jan 10, 2019 at 6:34 AM Robert Chiras wrote: > > The eLCDIF controller has control pin for the external LCD reset pin. > Add support for it and assert this pin in enable and de-assert it in > disable. > Also, correct the pm_runtime_enable call, since it was made too early in >

Re: [PATCH v2] ARM: dts: imx: Add Y Soft IOTA Draco, Hydra and Ursa boards

2018-12-28 Thread Fabio Estevam
Hi Vokáč, On Tue, Dec 18, 2018 at 12:42 PM Vokáč Michal wrote: > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_enet>; > + phy-mode = "rgmii-id"; > + phy-reset-gpios = < 25 GPIO_ACTIVE_HIGH>; Are you sure this is active high? The FEC driver ignores the polarity

Re: [PATCH] pinctrl: freescale: Break dependency on SOC_IMX8MQ for i.MX8MQ

2018-12-26 Thread Fabio Estevam
On Sun, Dec 23, 2018 at 2:38 PM Abel Vesa wrote: > > The CONFIG_SOC_IMX8MQ will go away, so the dependency can be based on > ARCH_MXC && ARM64. > > Signed-off-by: Abel Vesa Reviewed-by: Fabio Estevam

Re: [REGRESSION] imx_v6_v7_defconfig: undefined reference to `__hyp_stub_vectors'

2018-12-19 Thread Fabio Estevam
Hi Daniel, On Wed, Dec 19, 2018 at 11:32 AM Daniel Baluta wrote: > > On Wed, Dec 19, 2018 at 3:17 PM Daniel Baluta wrote: > > > > > > On Wed, 2018-12-19 at 12:42 +, Marcel Ziswiler wrote: > > > Hi there > > > > > > I noticed that at least today's and yesterdays -next won't build with > > >

Re: [alsa-devel] [PATCH] ASoC: eukrea-tlv320: Do not enable on ARM64

2018-12-18 Thread Fabio Estevam
Hi Andrey, On Tue, Dec 18, 2018 at 8:58 PM Andrey Smirnov wrote: > > ARCH_MXC is also used by i.MX8/AArch64 SoC, building the driver for > that platform results in: > > sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such > file or directory > #include >

Re: [PATCH] clk: imx: add CLK_GET_RATE_NOCACHE flag for i.MX8M composite clock

2018-12-18 Thread Fabio Estevam
Hi Anson, On Tue, Dec 18, 2018 at 12:56 AM Anson Huang wrote: > > On i.MX8M, some of the bus clocks' rate could be changed in TF-A, Do you mean ATF (ARM Trusted Firmware) instead?

Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

2018-12-12 Thread Fabio Estevam
Hi Anson, On Wed, Dec 12, 2018 at 10:49 AM Anson Huang wrote: > Since the datasheet of isl29018 states the vdda and vddd MUST be > shorted externally, and the later chips even remove vdda, ONLY has vdd one > supply, so I think adding vdda does NOT make enough sense. Looks like the vcc

Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

2018-12-12 Thread Fabio Estevam
Hi Anson, On Wed, Dec 12, 2018 at 4:17 AM Anson Huang wrote: > > Hi, Fabio > Obviously, some of the dts files (such as > arch/arm/boot/dts/exynos5420-peach-pit.dts) using "vcc" as isl29018's power > supply name, they are NOT matched with datasheet, so should we update those > dts

Re: [PATCH V2 2/2] iio: accell: mma8452: add optional vdd/vddio regulator operation support

2018-12-10 Thread Fabio Estevam
On Mon, Dec 10, 2018 at 5:25 AM Anson Huang wrote: > @@ -1533,6 +1536,27 @@ static int mma8452_probe(struct i2c_client *client, > data->client = client; > mutex_init(>lock); > data->chip_info = match->data; > + data->vdd_reg = devm_regulator_get_optional(>dev,

Re: [PATCH V2] iio: magnetometer: mag3110: add optional vdd/vddio regulator operation support

2018-12-10 Thread Fabio Estevam
Hi Anson, On Mon, Dec 10, 2018 at 5:17 AM Anson Huang wrote: > + data->vdd_reg = devm_regulator_get_optional(>dev, "vdd"); > + if (!IS_ERR(data->vdd_reg)) { > + ret = regulator_enable(data->vdd_reg); > + if (ret) { > + dev_err(>dev,

Re: [PATCH v4 4/5] ARM: dts: imx5: add gpu nodes

2018-12-07 Thread Fabio Estevam
r 128KiB GMEM size. > > Signed-off-by: Jonathan Marek Reviewed-by: Fabio Estevam

Re: [PATCH] iio: light: isl29018: add optional vcc regulator operation support

2018-12-07 Thread Fabio Estevam
Hi Anson, On Thu, Dec 6, 2018 at 1:17 AM Anson Huang wrote: > > The light sensor's power supply could be controlled by regulator > on some platforms, such as i.MX6Q-SABRESD board, the light sensor > isl29023's power supply is controlled by a GPIO fixed regulator, > need to make sure the

Re: [PATCH] iio: light: isl29018: add optional vcc regulator operation support

2018-12-07 Thread Fabio Estevam
Hi Anson, On Thu, Dec 6, 2018 at 1:17 AM Anson Huang wrote: > > The light sensor's power supply could be controlled by regulator > on some platforms, such as i.MX6Q-SABRESD board, the light sensor > isl29023's power supply is controlled by a GPIO fixed regulator, > need to make sure the

Re: [PATCH] iio: magnetometer: mag3110: add optional vcc regulator operation support

2018-12-07 Thread Fabio Estevam
Hi Anson, On Thu, Dec 6, 2018 at 3:05 AM Anson Huang wrote: > static int mag3110_request(struct mag3110_data *data) > @@ -469,17 +471,27 @@ static int mag3110_probe(struct i2c_client *client, > struct iio_dev *indio_dev; > int ret; > > + indio_dev =

Re: [PATCH] iio: magnetometer: mag3110: add optional vcc regulator operation support

2018-12-07 Thread Fabio Estevam
Hi Anson, On Thu, Dec 6, 2018 at 3:05 AM Anson Huang wrote: > static int mag3110_request(struct mag3110_data *data) > @@ -469,17 +471,27 @@ static int mag3110_probe(struct i2c_client *client, > struct iio_dev *indio_dev; > int ret; > > + indio_dev =

Re: [PATCH 2/2] iio: accell: mma8452: add optional vcc regulator operation support

2018-12-07 Thread Fabio Estevam
Hi Anson, On Thu, Dec 6, 2018 at 4:25 AM Anson Huang wrote: > @@ -1533,6 +1535,14 @@ static int mma8452_probe(struct i2c_client *client, > data->client = client; > mutex_init(>lock); > data->chip_info = match->data; > + data->vcc_reg =

Re: [PATCH 2/2] iio: accell: mma8452: add optional vcc regulator operation support

2018-12-07 Thread Fabio Estevam
Hi Anson, On Thu, Dec 6, 2018 at 4:25 AM Anson Huang wrote: > @@ -1533,6 +1535,14 @@ static int mma8452_probe(struct i2c_client *client, > data->client = client; > mutex_init(>lock); > data->chip_info = match->data; > + data->vcc_reg =

Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-12-06 Thread Fabio Estevam
Hi Lukasz, On Thu, Dec 6, 2018 at 11:08 AM Lukasz Majewski wrote: > I will check this latter this week... Reading the spi dt-binding it states that the spi slave node is optional. If I remove it like this, then the warning is gone: --- a/arch/arm/boot/dts/vf610-bk4.dts +++

Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-12-06 Thread Fabio Estevam
Hi Lukasz, On Thu, Dec 6, 2018 at 11:08 AM Lukasz Majewski wrote: > I will check this latter this week... Reading the spi dt-binding it states that the spi slave node is optional. If I remove it like this, then the warning is gone: --- a/arch/arm/boot/dts/vf610-bk4.dts +++

Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-12-06 Thread Fabio Estevam
On Thu, Dec 6, 2018 at 6:23 AM Lukasz Majewski wrote: > At the time of development - I've checked my NXP related patches with > W=1 passed to make. No warnings observed then. In linux-next the warning happens without W=1.

Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-12-06 Thread Fabio Estevam
On Thu, Dec 6, 2018 at 6:23 AM Lukasz Majewski wrote: > At the time of development - I've checked my NXP related patches with > W=1 passed to make. No warnings observed then. In linux-next the warning happens without W=1.

Re: [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support

2018-12-05 Thread Fabio Estevam
tor > operation currently, they are all controlled by this > regulator, so this patch also adds the fixed regulator > support and make it always on. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH V2 2/4] ARM: dts: imx6qdl-sabresd: add light sensor support

2018-12-05 Thread Fabio Estevam
tor > operation currently, they are all controlled by this > regulator, so this patch also adds the fixed regulator > support and make it always on. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-12-05 Thread Fabio Estevam
Hi Lukasz/Rob, On Tue, Oct 9, 2018 at 7:50 AM Lukasz Majewski wrote: > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_dspi3>; > + bus-num = <3>; > + status = "okay"; > + spi-slave; > + > + slave@0 { > + compatible = "lwn,bk4"; > +

Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)

2018-12-05 Thread Fabio Estevam
Hi Lukasz/Rob, On Tue, Oct 9, 2018 at 7:50 AM Lukasz Majewski wrote: > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_dspi3>; > + bus-num = <3>; > + status = "okay"; > + spi-slave; > + > + slave@0 { > + compatible = "lwn,bk4"; > +

Re: [PATCH 1/3] ARM: dts: imx6qdl-sabresd: add light sensor support

2018-12-05 Thread Fabio Estevam
Hi Anson, On Wed, Dec 5, 2018 at 10:15 AM Fabio Estevam wrote: > I know that you followed the existing pattern for regulators in this > file, but it is not recommended to put regulators under "simple-bus". > > I would suggest you to make a first patch of the ser

Re: [PATCH 1/3] ARM: dts: imx6qdl-sabresd: add light sensor support

2018-12-05 Thread Fabio Estevam
Hi Anson, On Wed, Dec 5, 2018 at 10:15 AM Fabio Estevam wrote: > I know that you followed the existing pattern for regulators in this > file, but it is not recommended to put regulators under "simple-bus". > > I would suggest you to make a first patch of the ser

Re: [PATCH 3/3] ARM: dts: imx6qdl-sabresd: add accelerometer sensor support

2018-12-05 Thread Fabio Estevam
On Wed, Dec 5, 2018 at 7:20 AM Anson Huang wrote: > > Add accelerometer sensor mma8451 support on i2c1 bus. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH 3/3] ARM: dts: imx6qdl-sabresd: add accelerometer sensor support

2018-12-05 Thread Fabio Estevam
On Wed, Dec 5, 2018 at 7:20 AM Anson Huang wrote: > > Add accelerometer sensor mma8451 support on i2c1 bus. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH 2/3] ARM: dts: imx6qdl-sabresd: add magnetometer sensor support

2018-12-05 Thread Fabio Estevam
On Wed, Dec 5, 2018 at 7:20 AM Anson Huang wrote: > > Add magnetometer sensor mag3110 support on i2c3 bus. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH 2/3] ARM: dts: imx6qdl-sabresd: add magnetometer sensor support

2018-12-05 Thread Fabio Estevam
On Wed, Dec 5, 2018 at 7:20 AM Anson Huang wrote: > > Add magnetometer sensor mag3110 support on i2c3 bus. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH V2] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus

2018-12-05 Thread Fabio Estevam
On Tue, Dec 4, 2018 at 11:14 PM Anson Huang wrote: > > Add egalax touch screen support on i2c2 bus, it is connected > to LVDS0, while the existing one on i2c3 bus is connected to > LVDS1. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH V2] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus

2018-12-05 Thread Fabio Estevam
On Tue, Dec 4, 2018 at 11:14 PM Anson Huang wrote: > > Add egalax touch screen support on i2c2 bus, it is connected > to LVDS0, while the existing one on i2c3 bus is connected to > LVDS1. > > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH 1/3] ARM: dts: imx6qdl-sabresd: add light sensor support

2018-12-05 Thread Fabio Estevam
Hi Anson, On Wed, Dec 5, 2018 at 7:20 AM Anson Huang wrote: > > Add isl29023 light sensor support on i2c3 bus, the light > sensor's power is controlled by a fixed regulator, since > the isl29023 driver and most of other sensors on same > board like mag3110 and mma8451 do NOT support regulator >

Re: [PATCH 1/3] ARM: dts: imx6qdl-sabresd: add light sensor support

2018-12-05 Thread Fabio Estevam
Hi Anson, On Wed, Dec 5, 2018 at 7:20 AM Anson Huang wrote: > > Add isl29023 light sensor support on i2c3 bus, the light > sensor's power is controlled by a fixed regulator, since > the isl29023 driver and most of other sensors on same > board like mag3110 and mma8451 do NOT support regulator >

[PATCH v2] ARM: dts: vf610-zii-scu4-aib: Add HI8435 support

2018-12-05 Thread Fabio Estevam
On the vf610-zii-scu4-aib board there is a hi8435 (32-channel discrete-to-digital SPI sensor device) in the DSPI0 bus. Add support for it. Signed-off-by: Fabio Estevam Reviewed-by: Chris Healy --- Changes since v1: - Put status as the last propert - Use a generic node name arch/arm/boot/dts

[PATCH v2] ARM: dts: vf610-zii-scu4-aib: Add HI8435 support

2018-12-05 Thread Fabio Estevam
On the vf610-zii-scu4-aib board there is a hi8435 (32-channel discrete-to-digital SPI sensor device) in the DSPI0 bus. Add support for it. Signed-off-by: Fabio Estevam Reviewed-by: Chris Healy --- Changes since v1: - Put status as the last propert - Use a generic node name arch/arm/boot/dts

Re: [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus

2018-12-04 Thread Fabio Estevam
Hi Anson, On Tue, Dec 4, 2018 at 6:54 AM Anson Huang wrote: > > Add egalax touch screen support on i2c2 bus. Please improve the commit log saying that this newly introduced touchscreen controller is connected to LVDS0 and the existing one on I2C3 is connected to LVDS1. Thanks

Re: [PATCH] ARM: dts: imx6qdl-sabresd: add egalax touch screen support on i2c2 bus

2018-12-04 Thread Fabio Estevam
Hi Anson, On Tue, Dec 4, 2018 at 6:54 AM Anson Huang wrote: > > Add egalax touch screen support on i2c2 bus. Please improve the commit log saying that this newly introduced touchscreen controller is connected to LVDS0 and the existing one on I2C3 is connected to LVDS1. Thanks

Re: [PATCH] ARM: imx: update the cpu power up timing setting

2018-12-03 Thread Fabio Estevam
On Mon, Dec 3, 2018 at 9:42 AM Fabio Estevam wrote: > > On Mon, Dec 3, 2018 at 12:45 AM Anson Huang wrote: > > > > The sw2iso count should cover ARM LDO ramp-up time, > > the MAX ARM LDO ramp-up time may be up to more than > > 100us on some boards, this patch

Re: [PATCH] ARM: imx: update the cpu power up timing setting

2018-12-03 Thread Fabio Estevam
On Mon, Dec 3, 2018 at 9:42 AM Fabio Estevam wrote: > > On Mon, Dec 3, 2018 at 12:45 AM Anson Huang wrote: > > > > The sw2iso count should cover ARM LDO ramp-up time, > > the MAX ARM LDO ramp-up time may be up to more than > > 100us on some boards, this patch

Re: [PATCH] ARM: imx: update the cpu power up timing setting

2018-12-03 Thread Fabio Estevam
to cover different boards, since we have > observed that some customer boards failed with current > setting of 0x2. > > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx") > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: imx: update the cpu power up timing setting

2018-12-03 Thread Fabio Estevam
to cover different boards, since we have > observed that some customer boards failed with current > setting of 0x2. > > Fixes: 05136f0897b5 ("ARM: imx: support arm power off in cpuidle for i.mx6sx") > Signed-off-by: Anson Huang Reviewed-by: Fabio Estevam

Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-03 Thread Fabio Estevam
Hi Krzysztof, On Mon, Dec 3, 2018 at 9:13 AM Krzysztof Hałasa wrote: > > Signed-off-by: Krzysztof Halasa Please provide a commit log, giving some context to your fix. Is this a regression?

Re: [PATCH] ARM i.MX: Fix a kernel panic in i2c_imx_clk_notifier_call().

2018-12-03 Thread Fabio Estevam
Hi Krzysztof, On Mon, Dec 3, 2018 at 9:13 AM Krzysztof Hałasa wrote: > > Signed-off-by: Krzysztof Halasa Please provide a commit log, giving some context to your fix. Is this a regression?

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-03 Thread Fabio Estevam
Hi Lukasz, On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > + 72xx165@0 { > > > > Please use a generic name for the node. > > This is a bit tricky. What about using 'gpio@0' like described in Documentation/devicetree/bindings/gpio/gpio-pisosr.txt ?

Re: [PATCH] ARM: dts: Provide support for reading ID code from MVB device (BK4)

2018-12-03 Thread Fabio Estevam
Hi Lukasz, On Mon, Dec 3, 2018 at 7:33 AM Lukasz Majewski wrote: > > > + 72xx165@0 { > > > > Please use a generic name for the node. > > This is a bit tricky. What about using 'gpio@0' like described in Documentation/devicetree/bindings/gpio/gpio-pisosr.txt ?

Re: [PATCH v2 3/3] PCI: imx6: limit DBI register length

2018-11-27 Thread Fabio Estevam
Hi Andrey, On Tue, Nov 27, 2018 at 10:57 PM Andrey Smirnov wrote: > Could this be a regression? Prior to 415b6185c541 ("PCI: imx6: Fix > config read timeout handling") all of the imprecise aborts were caught > and handled via no-op handler. I did an experiment on i.MX6Q board > that I have (ZII

Re: [PATCH v2 3/3] PCI: imx6: limit DBI register length

2018-11-27 Thread Fabio Estevam
Hi Andrey, On Tue, Nov 27, 2018 at 10:57 PM Andrey Smirnov wrote: > Could this be a regression? Prior to 415b6185c541 ("PCI: imx6: Fix > config read timeout handling") all of the imprecise aborts were caught > and handled via no-op handler. I did an experiment on i.MX6Q board > that I have (ZII

Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node

2018-11-26 Thread Fabio Estevam
On Mon, Nov 26, 2018 at 12:22 PM Govind Singh wrote: > + > + wifi: wifi@0A00 { Please remove the leading zero. Building with W=1 would warn you about that.

Re: [PATCH] arm64: dts: qcom: qcs404: Add WCN3990 WLAN module device node

2018-11-26 Thread Fabio Estevam
On Mon, Nov 26, 2018 at 12:22 PM Govind Singh wrote: > + > + wifi: wifi@0A00 { Please remove the leading zero. Building with W=1 would warn you about that.

Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND

2018-11-25 Thread Fabio Estevam
Hi Otavio, On Sun, Nov 25, 2018 at 6:49 PM Otavio Salvador wrote: > In fact, was removed and now selected. Yes, correct. In 4.20-rc1 this option is automatically selected. > I changed the commit log as: > > ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable > > CONFIG_ARM_UNWIND is

Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND

2018-11-25 Thread Fabio Estevam
Hi Otavio, On Sun, Nov 25, 2018 at 6:49 PM Otavio Salvador wrote: > In fact, was removed and now selected. Yes, correct. In 4.20-rc1 this option is automatically selected. > I changed the commit log as: > > ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable > > CONFIG_ARM_UNWIND is

Re: [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES

2018-11-25 Thread Fabio Estevam
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador wrote: > > From: Andreas Müller > > This is very helpful debugging USB issues. > > Signed-off-by: Andreas Müller > Signed-off-by: Otavio Salvador Reviewed-by: Fabio Estevam

Re: [PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable USB_ANNOUNCE_NEW_DEVICES

2018-11-25 Thread Fabio Estevam
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador wrote: > > From: Andreas Müller > > This is very helpful debugging USB issues. > > Signed-off-by: Andreas Müller > Signed-off-by: Otavio Salvador Reviewed-by: Fabio Estevam

Re: [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP

2018-11-25 Thread Fabio Estevam
scite-som bluetoothd[281]: System does not > support network plugin > > Signed-off-by: Andreas Müller > Signed-off-by: Otavio Salvador Reviewed-by: Fabio Estevam

Re: [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable BT_BNEP

2018-11-25 Thread Fabio Estevam
scite-som bluetoothd[281]: System does not > support network plugin > > Signed-off-by: Andreas Müller > Signed-off-by: Otavio Salvador Reviewed-by: Fabio Estevam

Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND

2018-11-25 Thread Fabio Estevam
t it is still selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. With the reworded commit log: Reviewed-by: Fabio Estevam

Re: [PATCH 1/3] ARM: imx_v6_v7_defconfig: Remove CONFIG_ARM_UNWIND

2018-11-25 Thread Fabio Estevam
t it is still selected by the Kconfig logic. This is done in preparation to making further changes to this defconfig cleaner. With the reworded commit log: Reviewed-by: Fabio Estevam

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-12 Thread Fabio Estevam
Hi Dong, On Mon, Nov 12, 2018 at 1:04 PM A.s. Dong wrote: > Thanks for reporting this issue. > The original code intended to save 3 common lines for both SCU and MMIO pads, > but it did change the code logic a bit which resulted in a regression > specificly > for NO_PAD_CTL cases used on a few

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-12 Thread Fabio Estevam
Hi Dong, On Mon, Nov 12, 2018 at 1:04 PM A.s. Dong wrote: > Thanks for reporting this issue. > The original code intended to save 3 common lines for both SCU and MMIO pads, > but it did change the code logic a bit which resulted in a regression > specificly > for NO_PAD_CTL cases used on a few

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-10 Thread Fabio Estevam
er only if a new map was > created. > > Fixes: b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support") > Cc: A.s. Dong > Signed-off-by: Martin Kaiser Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [PATCH] pinctrl: imx: make sure that maps are fully initialized

2018-11-10 Thread Fabio Estevam
er only if a new map was > created. > > Fixes: b96eea718bf6 ("pinctrl: fsl: add scu based pinctrl support") > Cc: A.s. Dong > Signed-off-by: Martin Kaiser Thanks for the fix: Reviewed-by: Fabio Estevam

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-10 Thread Fabio Estevam
Hi Matheus, On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino wrote: > Got it, thanks for the explanation! I'll correct this in v2. One more suggestion: in v2 you could also consider to remove the legal text that says GPL v2, as you are adding the SPDX tag.

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-10 Thread Fabio Estevam
Hi Matheus, On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino wrote: > Got it, thanks for the explanation! I'll correct this in v2. One more suggestion: in v2 you could also consider to remove the legal text that says GPL v2, as you are adding the SPDX tag.

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Fabio Estevam
Hi Matheus, On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares wrote: > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > which solves the checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > Signed-off-by: Matheus Tavares > ---

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Fabio Estevam
Hi Matheus, On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares wrote: > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > which solves the checkpatch.pl warning: > "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". > > Signed-off-by: Matheus Tavares > ---

Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

2018-11-08 Thread Fabio Estevam
Hi Anson, On Thu, Nov 8, 2018 at 12:30 AM Anson Huang wrote: > Thanks for pointing out this issue, I made a mistake when doing the search in > git repo.. > So, if we have to assert a GPIO, there is no common way in pinctrl driver? > Have to > do it in driver itself? Like this case, we have to

Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

2018-11-08 Thread Fabio Estevam
Hi Anson, On Thu, Nov 8, 2018 at 12:30 AM Anson Huang wrote: > Thanks for pointing out this issue, I made a mistake when doing the search in > git repo.. > So, if we have to assert a GPIO, there is no common way in pinctrl driver? > Have to > do it in driver itself? Like this case, we have to

Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

2018-11-07 Thread Fabio Estevam
Hi Anson, On Wed, Nov 7, 2018 at 11:24 PM Anson Huang wrote: > Regarding the fec2 settings in imx7d-sdb.dts, originally it uses Rev-A board > (but some nodes are > using Rev-B board), in this patch, I clean up all the settings in > imx7d-sdb.dts using Rev-B board, > so below is added to

Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

2018-11-07 Thread Fabio Estevam
Hi Anson, On Wed, Nov 7, 2018 at 11:24 PM Anson Huang wrote: > Regarding the fec2 settings in imx7d-sdb.dts, originally it uses Rev-A board > (but some nodes are > using Rev-B board), in this patch, I clean up all the settings in > imx7d-sdb.dts using Rev-B board, > so below is added to

Re: [PATCH v2 4/9] arm64: defconfig: Drop USB_ULPI_BUS and USB_CHIPIDEA_ULPI

2018-11-07 Thread Fabio Estevam
On Wed, Nov 7, 2018 at 9:17 PM Marc Gonzalez wrote: > > Commit a930d8bd94d8 ("usb: chipidea: Always build ULPI code") made > USB_CHIPIDEA select USB_ULPI_BUS, and removed USB_CHIPIDEA_ULPI. > > Signed-off-by: Marc Gonzalez Reviewed-by: Fabio Estevam

Re: [PATCH v2 4/9] arm64: defconfig: Drop USB_ULPI_BUS and USB_CHIPIDEA_ULPI

2018-11-07 Thread Fabio Estevam
On Wed, Nov 7, 2018 at 9:17 PM Marc Gonzalez wrote: > > Commit a930d8bd94d8 ("usb: chipidea: Always build ULPI code") made > USB_CHIPIDEA select USB_ULPI_BUS, and removed USB_CHIPIDEA_ULPI. > > Signed-off-by: Marc Gonzalez Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

2018-11-07 Thread Fabio Estevam
Hi Anson, On Wed, Nov 7, 2018 at 3:19 AM Anson Huang wrote: > + { > + pinctrl-0 = <_enet2>; > + /delete-property/pinctrl-assert-gpios; "pinctrl-assert-gpios" does not exist in mainline, so not sure why you are deleting it.

Re: [PATCH] ARM: dts: imx7d-sdb: add rev-a board support

2018-11-07 Thread Fabio Estevam
Hi Anson, On Wed, Nov 7, 2018 at 3:19 AM Anson Huang wrote: > + { > + pinctrl-0 = <_enet2>; > + /delete-property/pinctrl-assert-gpios; "pinctrl-assert-gpios" does not exist in mainline, so not sure why you are deleting it.

Re: [PATCH] ARM: dts: imx: Add dummy PHYs for HSIC-only USB controllers

2018-10-25 Thread Fabio Estevam
; dummy PHYs. > > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: dts: imx: Add dummy PHYs for HSIC-only USB controllers

2018-10-25 Thread Fabio Estevam
; dummy PHYs. > > Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam

Re: [PATCH V1 3/3] ARM: dts: sabreauto: Add flexcan support

2018-10-24 Thread Fabio Estevam
Hi Joakim, On Wed, Oct 24, 2018 at 8:15 AM Joakim Zhang wrote: > diff --git a/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts > b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts > new file mode 100644 > index ..963e0b559d60 > --- /dev/null > +++

Re: [PATCH V1 3/3] ARM: dts: sabreauto: Add flexcan support

2018-10-24 Thread Fabio Estevam
Hi Joakim, On Wed, Oct 24, 2018 at 8:15 AM Joakim Zhang wrote: > diff --git a/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts > b/arch/arm/boot/dts/imx6dl-sabreauto-flexcan1.dts > new file mode 100644 > index ..963e0b559d60 > --- /dev/null > +++

Re: [PATCH V2 4/5] spi: lpspi: enable runtime pm for lpspi

2018-10-24 Thread Fabio Estevam
Hi Clark, On Wed, Oct 24, 2018 at 5:01 AM Clark Wang wrote: > > Enable the runtime pm for lpspi module > > BuildInfo: > - U-Boot 2018.03-imx_4.14.y This buildinfo piece is not very helpful in upstream. Please drop it. > Signed-off-by: Han Xu > Reviewed-by: Frank Li > Signed-off-by:

Re: [PATCH V2 4/5] spi: lpspi: enable runtime pm for lpspi

2018-10-24 Thread Fabio Estevam
Hi Clark, On Wed, Oct 24, 2018 at 5:01 AM Clark Wang wrote: > > Enable the runtime pm for lpspi module > > BuildInfo: > - U-Boot 2018.03-imx_4.14.y This buildinfo piece is not very helpful in upstream. Please drop it. > Signed-off-by: Han Xu > Reviewed-by: Frank Li > Signed-off-by:

Re: [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller

2018-10-22 Thread Fabio Estevam
On Mon, Oct 22, 2018 at 7:34 AM Alex Gonzalez wrote: Please add a commit log. > Signed-off-by: Alex Gonzalez > --- > arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 19 +++ > arch/arm/configs/imx_v6_v7_defconfig| 1 + Please split this into two patches: one for the dts

Re: [PATCH 2/2] ARM: dts: ccimx6ulsbcpro: Add support for Goodix touch controller

2018-10-22 Thread Fabio Estevam
On Mon, Oct 22, 2018 at 7:34 AM Alex Gonzalez wrote: Please add a commit log. > Signed-off-by: Alex Gonzalez > --- > arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 19 +++ > arch/arm/configs/imx_v6_v7_defconfig| 1 + Please split this into two patches: one for the dts

Re: [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display

2018-10-22 Thread Fabio Estevam
Hi Alex, On Mon, Oct 22, 2018 at 7:34 AM Alex Gonzalez wrote: > + g101evn010: display@0 { > + bits-per-pixel = <16>; > + bus-width = <18>; > + > + display-timings { > + native-mode = <>; > + timing0:

Re: [PATCH 1/2] ARM: dts: ccimx6ulsbcpro: Add support for AUO G101EVN010 display

2018-10-22 Thread Fabio Estevam
Hi Alex, On Mon, Oct 22, 2018 at 7:34 AM Alex Gonzalez wrote: > + g101evn010: display@0 { > + bits-per-pixel = <16>; > + bus-width = <18>; > + > + display-timings { > + native-mode = <>; > + timing0:

Re: [PATCH v1] ARM: dts: imx6ul: ccimx6ulsom: Add support for wireless SOM variant

2018-10-22 Thread Fabio Estevam
cted through the SDIO interface on usdhc1 and the > Bluetooth is connected via uart1. > > Signed-off-by: Alex Gonzalez Reviewed-by: Fabio Estevam

Re: [PATCH v1] ARM: dts: imx6ul: ccimx6ulsom: Add support for wireless SOM variant

2018-10-22 Thread Fabio Estevam
cted through the SDIO interface on usdhc1 and the > Bluetooth is connected via uart1. > > Signed-off-by: Alex Gonzalez Reviewed-by: Fabio Estevam

<    1   2   3   4   5   6   7   8   9   10   >