flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi
Acked-by: Noralf Trønnes
---
drivers/staging/fbtft/flexfb.c | 232 -
1 file changed, 136 insertions(+), 96 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index
On Sun, Aug 02, 2015 at 07:54:48PM +0200, Noralf Trønnes wrote:
>
> Seems I wasn't clear enough, you could use my ack if you put
> struct flexfb_lcd_controller inside the driver and not in
> fbtft.h
>
>
> Noralf.
>
>
Sorry Noralf, I misunderstood your review.
I will modify the patch and send
flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi
Acked-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft.h | 20
drivers/staging/fbtft/flexfb.c | 203 ++---
2 files changed, 127 insertions(+), 96 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h
flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Acked-by: Noralf Trønnes nor...@tronnes.org
---
drivers/staging/fbtft/fbtft.h | 20
drivers/staging/fbtft/flexfb.c | 203 ++---
2 files changed, 127 insertions(+), 96 deletions
flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Acked-by: Noralf Trønnes nor...@tronnes.org
---
drivers/staging/fbtft/flexfb.c | 232 -
1 file changed, 136 insertions(+), 96 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b
On Sun, Aug 02, 2015 at 07:54:48PM +0200, Noralf Trønnes wrote:
Seems I wasn't clear enough, you could use my ack if you put
struct flexfb_lcd_controller inside the driver and not in
fbtft.h
Noralf.
Sorry Noralf, I misunderstood your review.
I will modify the patch and send an
Avoid duplicating code to verify gpios.dc and call
flexfb_verify_gpios_dc instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index
flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/fbtft.h | 20
drivers/staging/fbtft/flexfb.c | 212 ++---
2 files changed, 136 insertions(+), 96 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft
This patch removes some unnecessary multiple blank lines to fix the
following checkpatch errors:
CHECK:LINE_SPACING at lines 29, 67, 131, 287, 299, 312, 326, 351 and
364.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 11 ---
1 file changed, 11 deletions(-)
diff
Use a helper function to choose which set_addr_win implementation to
use, based on the value of the setaddrwin module parameter.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 47 +-
1 file changed, 28 insertions(+), 19 deletions
No newline is needed since checkpatch doesn't complain about line longer
than 80 characters for string literals.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging
This patch fixes the following checkpatch.pl error:
CHECK:SPACING at line 318.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index b161050
This patch fixes the following checkpatch.pl error:
CHECK:PARENTHESIS_ALIGNMENT at line 217.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft
Remove paragraph about writing to the Free Software Foundation's
mailing address from GPL notice.
This patch fixes the following checkpatch error:
CHECK:FSF_MAILING_ADDRESS at line 17.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 4
1 file changed, 4 deletions(-)
diff
.
CHECK:PARENTHESIS_ALIGNMENT at line 459.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 154 +
1 file changed, 94 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index dae092a..1b833f9 100644
This patchset aims to refactor the code in flexfb.c, making it more
readable and maintanable.
Various checkpatch.pl issues are fixed.
These patches are created on top of greg-kh's linux-staging tree,
staging-testing branch.
Fabio Falzoi (10):
Staging: fbtft: Remove paragraph about writing
Use a helper function to set the correct write_register function, based
on the width of the registers.
Signed-off-by: Fabio Falzoi
---
drivers/staging/fbtft/flexfb.c | 36 ++--
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/fbtft
This patchset aims to refactor the code in flexfb.c, making it more
readable and maintanable.
Various checkpatch.pl issues are fixed.
These patches are created on top of greg-kh's linux-staging tree,
staging-testing branch.
Fabio Falzoi (10):
Staging: fbtft: Remove paragraph about writing
Use a helper function to set the correct write_register function, based
on the width of the registers.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 36 ++--
1 file changed, 22 insertions(+), 14 deletions(-)
diff --git
Remove paragraph about writing to the Free Software Foundation's
mailing address from GPL notice.
This patch fixes the following checkpatch error:
CHECK:FSF_MAILING_ADDRESS at line 17.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 4
1 file
.
CHECK:PARENTHESIS_ALIGNMENT at line 459.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 154 +
1 file changed, 94 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft/flexfb.c
index
Use a helper function to choose which set_addr_win implementation to
use, based on the value of the setaddrwin module parameter.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 47 +-
1 file changed, 28 insertions
flexfb_lcd_controller struct.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/fbtft.h | 20
drivers/staging/fbtft/flexfb.c | 212 ++---
2 files changed, 136 insertions(+), 96 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b
This patch removes some unnecessary multiple blank lines to fix the
following checkpatch errors:
CHECK:LINE_SPACING at lines 29, 67, 131, 287, 299, 312, 326, 351 and
364.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 11 ---
1 file changed, 11
This patch fixes the following checkpatch.pl error:
CHECK:PARENTHESIS_ALIGNMENT at line 217.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b
No newline is needed since checkpatch doesn't complain about line longer
than 80 characters for string literals.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft
Avoid duplicating code to verify gpios.dc and call
flexfb_verify_gpios_dc instead.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging
This patch fixes the following checkpatch.pl error:
CHECK:SPACING at line 318.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/fbtft/flexfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/flexfb.c b/drivers/staging/fbtft
Fix CHANGE_LINK_STATE value when card_exist is true.
Fixes: a9b693cd77d7 ("Staging: rts5208: helper function to manage delink
states")
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
Fix CHANGE_LINK_STATE value when card_exist is true.
This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b
Fix CHANGE_LINK_STATE value when card_exist is true.
Fixes: a9b693cd77d7 (Staging: rts5208: helper function to manage delink
states)
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix CHANGE_LINK_STATE value when card_exist is true.
This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Use a helper function to manage delink states
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 141 ++--
1 file changed, 72 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208
Use a helper function to manage lun modes when SUPPORT_OCP is defined
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 97 -
1 file changed, 53 insertions(+), 44 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers
Use a helper function to manage ss_counter
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 66 ++---
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208/rtsx_chip.c
Use a helper function to check if power off is needed.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208
Use a helper function to manage aspm mode
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 51 ++---
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208/rtsx_chip.c
rtsx_polling_func is a big function that manage a lot of independent
tasks.
This patch aims to refactor the code using a series of helper functions,
to make it more readable.
Plus, the following checkpatch warning is corrected:
* PARENTHESIS_ALIGNMENT at row 1246
Fabio Falzoi (7):
Staging
Use a helper function to manage idle state
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 45 -
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208/rtsx_chip.c
Use a helper function to manage SD erase status when SUPPORT_SD_LOCK is
defined
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 38 -
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b
Use a helper function to check if power off is needed.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b
Use a helper function to manage delink states
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 141 ++--
1 file changed, 72 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers
Use a helper function to manage lun modes when SUPPORT_OCP is defined
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 97 -
1 file changed, 53 insertions(+), 44 deletions(-)
diff --git a/drivers/staging/rts5208
Use a helper function to manage ss_counter
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 66 ++---
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers
Use a helper function to manage aspm mode
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 51 ++---
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers
Use a helper function to manage SD erase status when SUPPORT_SD_LOCK is
defined
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 38 -
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/drivers/staging
rtsx_polling_func is a big function that manage a lot of independent
tasks.
This patch aims to refactor the code using a series of helper functions,
to make it more readable.
Plus, the following checkpatch warning is corrected:
* PARENTHESIS_ALIGNMENT at row 1246
Fabio Falzoi (7):
Staging
Use a helper function to manage idle state
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 45 -
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code.
Signed-off-by: Fabio Falzoi
Reviewed-by: Dan Carpenter
---
drivers/staging/rts5208/rtsx_chip.c | 95 +++--
1 file changed, 48 insertions(+), 47 deletions(-)
diff --git
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the PARENTHESIS_ALIGNMENT checkpatch
warnings.
Signed-off-by: Fabio Falzoi
Reviewed-by: Dan Carpenter
---
drivers/staging/rts5208/rtsx_chip.c | 70 +
1 file changed
another
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Changes in v3:
* rebased against master branch of linux-next tree
Changes in v2:
* rebased against staging-testing branch of staging driver development
tree
Fabio Falzoi (2):
Staging: rts5208: helper
another
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Changes in v3:
* rebased against master branch of linux-next tree
Changes in v2:
* rebased against staging-testing branch of staging driver development
tree
Fabio Falzoi (2):
Staging: rts5208: helper
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the PARENTHESIS_ALIGNMENT checkpatch
warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Reviewed-by: Dan Carpenter dan.carpe...@oracle.com
---
drivers/staging/rts5208/rtsx_chip.c | 70
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Reviewed-by: Dan Carpenter dan.carpe...@oracle.com
---
drivers/staging/rts5208/rtsx_chip.c | 95 +++--
1 file changed, 48
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi
Reviewed-by: Dan Carpenter
---
drivers/staging/rts5208/rtsx_chip.c | 95 +++--
1 file changed, 48
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi
Reviewed-by: Dan Carpenter
---
drivers/staging/rts5208/rtsx_chip.c | 70 +
1 file changed, 39
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Changes in v2:
* rebased against staging-testing branch of staging driver development
tree
Fabio Falzoi (2):
Staging: rts5208: helper function to manage aspm during reset
Staging: rts5208: helper
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Changes in v2:
* rebased against staging-testing branch of staging driver development
tree
Fabio Falzoi (2):
Staging: rts5208: helper function to manage aspm during reset
Staging: rts5208: helper
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Reviewed-by: Dan Carpenter dan.carpe...@oracle.com
---
drivers/staging/rts5208/rtsx_chip.c | 95
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Reviewed-by: Dan Carpenter dan.carpe...@oracle.com
---
drivers/staging/rts5208/rtsx_chip.c | 70
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 70 +
1 file changed, 39 insertions(+), 31 deletions
and 351
This patch is inspired by the following post on LKML regarding another
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Changes in v2:
* rebased against staging-testing branch of staging driver development
tree
Fabio Falzoi (2):
Staging: rts5208
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 95 +++--
1 file changed, 48 insertions(+), 47 deletions
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 96 ++---
1 file changed, 48 insertions(+), 48 deletions
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx_chip.c | 72 -
1 file changed, 39 insertions(+), 33 deletions
and 351
This patch is inspired by the following post on LKML regarding another
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Fabio Falzoi (2):
Staging: rts5208: helper function to manage aspm during reset
Staging: rts5208: helper function to enable
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 72 -
1 file changed, 39 insertions
and 351
This patch is inspired by the following post on LKML regarding another
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Fabio Falzoi (2):
Staging: rts5208: helper function to manage aspm during reset
Staging: rts5208: helper function to enable
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 96 ++---
1 file changed, 48
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 70 +
1 file changed, 39 insertions
and 351
This patch is inspired by the following post on LKML regarding another
clean up for rts5208 module:
http://www.spinics.net/lists/linux-driver-devel/msg55038.html
Changes in v2:
* rebased against staging-testing branch of staging driver development
tree
Fabio Falzoi (2):
Staging: rts5208
Define the helper function rtsx_enable_pcie_intr to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 95 +++--
1 file changed, 48
Use dev_dbg with %*ph format specifier and print_hex_dump_bytes to dump memory
instead of relying on custom macro.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 5 +++--
drivers/staging/rts5208/rtsx_chip.c | 6 --
drivers/staging/rts5208/rtsx_scsi.c | 7
of print_hex_dump_bytes
Changes in v3:
* defined rtsx_hex_dump as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output only if DEBUG is defined
Fabio Falzoi (2):
Staging: rts5208: Use dev_dbg and print_hex_dump_bytes to dump memory
Staging: rts5208
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git
of print_hex_dump_bytes
Changes in v3:
* defined rtsx_hex_dump as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output only if DEBUG is defined
Fabio Falzoi (2):
Staging: rts5208: Use dev_dbg and print_hex_dump_bytes to dump memory
Staging: rts5208
Use dev_dbg with %*ph format specifier and print_hex_dump_bytes to dump memory
instead of relying on custom macro.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/ms.c| 5 +++--
drivers/staging/rts5208/rtsx_chip.c | 6 --
drivers/staging/rts5208
On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote:
> Documentation/printk-formats.txt
>
> Raw buffer as a hex string:
> %*ph00 01 02 ... 3f
> %*phC 00:01:02: ... :3f
> %*phD 00-01-02- ... -3f
> %*phN 000102 ... 3f
>
> For printing a small buffers (up
On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote:
Documentation/printk-formats.txt
Raw buffer as a hex string:
%*ph00 01 02 ... 3f
%*phC 00:01:02: ... :3f
%*phD 00-01-02- ... -3f
%*phN 000102 ... 3f
For printing a small buffers (up to 64
Use dev_dbg macro to control tracing verbosity through dynamic debug facility.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/debug.h | 43 ---
drivers/staging/rts5208/ms.c | 102 +
drivers/staging/rts5208/rtsx.c | 6 +-
drivers
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208
Use dev_dbg with %*ph format specifier to dump memory instead of relying
on custom macro.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 4 ++--
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
drivers/staging/rts5208/rtsx_scsi.c | 7 +++
drivers/staging/rts5208/sd.c
Remove all debug printks used just to mark when we enter a function.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 24
drivers/staging/rts5208/rtsx_scsi.c | 4
2 files changed, 28 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b
of pr_debug
* use dev_dbg with %*ph modifier instead of print_hex_dump_bytes
Changes in v3:
* defined rtsx_hex_dump as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output only if DEBUG is defined
Fabio Falzoi (4):
Staging: rts5208
of pr_debug
* use dev_dbg with %*ph modifier instead of print_hex_dump_bytes
Changes in v3:
* defined rtsx_hex_dump as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output only if DEBUG is defined
Fabio Falzoi (4):
Staging: rts5208
Remove all debug printks used just to mark when we enter a function.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/ms.c| 24
drivers/staging/rts5208/rtsx_scsi.c | 4
2 files changed, 28 deletions(-)
diff --git a/drivers
Use dev_dbg with %*ph format specifier to dump memory instead of relying
on custom macro.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/ms.c| 4 ++--
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
drivers/staging/rts5208/rtsx_scsi.c | 7 +++
drivers
Use dev_dbg macro to control tracing verbosity through dynamic debug facility.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/debug.h | 43 ---
drivers/staging/rts5208/ms.c | 102 +
drivers/staging/rts5208/rtsx.c
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git
Use dev_dbg with %*ph format specifier to dump memory instead of relying
on custom macro.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 4 ++--
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
drivers/staging/rts5208/rtsx_scsi.c | 7 +++
drivers/staging/rts5208/sd.c
as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output only if DEBUG is defined
Fabio Falzoi (3):
Staging: rts5208: Replace custom macro with dev_dbg
Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory
Staging: rts5208
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git
as a static inline function to avoid checkpatch errors
Changes in v2:
* defined rtsx_hex_dump macro to produce output only if DEBUG is defined
Fabio Falzoi (3):
Staging: rts5208: Replace custom macro with dev_dbg
Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory
Staging: rts5208
Use dev_dbg with %*ph format specifier to dump memory instead of relying
on custom macro.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/ms.c| 4 ++--
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
drivers/staging/rts5208/rtsx_scsi.c | 7 +++
drivers
Fix an incorrect use of the %d format specifier in dev_err that caused a
warning.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 4f5f7a3
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208
Use print_hex_dump_bytes to have memory properly dumped only when
DEBUG is defined.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 4 ++--
drivers/staging/rts5208/rtsx_chip.c | 4 ++--
drivers/staging/rts5208/rtsx_scsi.c | 9 -
drivers/staging/rts5208/sd.c
only if DEBUG is defined
Fabio Falzoi (4):
Staging: rts5208: Replace custom macro with pr_debug
Staging: rts5208: Replace custom macro with print_hex_dump_bytes
Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option
Staging: rts5208: Fix a format specifier for dev_err
drivers/staging/rts5208
1 - 100 of 162 matches
Mail list logo