It's required for the core fs/namespace.c and many other basic features.
CC: "Eric W. Biederman"
Signed-off-by: Guan Xuetao
Signed-off-by: Fengguang Wu
---
arch/unicore32/Kconfig |1 +
1 file changed, 1 insertion(+)
--- linux.orig/arch/unicore32/Kconfig 2012-08-17 11:
It's required for the core fs/namespace.c and many other basic features.
Acked-by: Lennox Wu
Signed-off-by: Fengguang Wu
---
arch/score/Kconfig |1 +
1 file changed, 1 insertion(+)
--- linux.orig/arch/score/Kconfig 2012-08-17 11:13:49.184134240 +0800
+++ linux/arch/score/Kc
On Sat, Aug 18, 2012 at 06:44:57AM +1000, NeilBrown wrote:
> On Fri, 17 Aug 2012 22:25:26 +0800 Fengguang Wu
> wrote:
>
> > [CC md list]
> >
> > On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote:
> > > On Fri, Aug 17, 2012 at 02:09:15
On Mon, Aug 20, 2012 at 06:49:52PM -0700, John Stultz wrote:
> On 08/20/2012 06:40 PM, Fengguang Wu wrote:
> >On Mon, Aug 20, 2012 at 06:15:00PM -0700, John Stultz wrote:
> >>On 08/20/2012 06:10 PM, John Stultz wrote:
> >>>On 08/20/2012 06:04 PM, Fengguang Wu wrote:
&
On Mon, Aug 20, 2012 at 06:46:05PM -0700, John Stultz wrote:
> On 08/20/2012 06:31 PM, Fengguang Wu wrote:
> >On Mon, Aug 20, 2012 at 06:10:57PM -0700, John Stultz wrote:
> >>On 08/20/2012 06:04 PM, Fengguang Wu wrote:
> >>>Hi John,
> >>>
> >>
On Mon, Aug 20, 2012 at 06:15:00PM -0700, John Stultz wrote:
> On 08/20/2012 06:10 PM, John Stultz wrote:
> >On 08/20/2012 06:04 PM, Fengguang Wu wrote:
> >>Hi John,
> >>
> >>The below oops happens in v3.5..v3.6-rc2 and it's bisected down
> >&
On Mon, Aug 20, 2012 at 06:10:57PM -0700, John Stultz wrote:
> On 08/20/2012 06:04 PM, Fengguang Wu wrote:
> >Hi John,
> >
> >The below oops happens in v3.5..v3.6-rc2 and it's bisected down to commit
> >2a8c0883c ("time: Move xtime_nsec adjustment unde
On Mon, Aug 20, 2012 at 09:48:42AM +0900, Namjae Jeon wrote:
> 2012/8/19, Fengguang Wu :
> > On Sat, Aug 18, 2012 at 05:50:02AM -0400, Namjae Jeon wrote:
> >> From: Namjae Jeon
> >>
> >> This patch is based on suggestion by Wu Fengguang:
> >> https:
Hi Michael,
On Mon, Aug 20, 2012 at 05:20:35PM +0800, Michael Wang wrote:
> On 08/17/2012 09:49 PM, Fengguang Wu wrote:
>
> Hi, FengGuang
>
> native_smp_prepare_cpus has already disabled the preempt before
> reach __irq_alloc_descs(), and sleep in mutex_lock() cause the bu
On Sun, Aug 19, 2012 at 04:18:24PM +0200, Markus Trippelsdorf wrote:
> On 2012.08.19 at 22:02 +0800, Fengguang Wu wrote:
> > Hi,
> >
> > [ 38.650387] PCI host bridge to bus :00
> > [ 38.657920] pci_bus :00:
Hi,
[ 38.650387] PCI host bridge to bus :00
[ 38.657920] pci_bus :00: Force enabled HPET at 0x%lx
~~~
That "0x%lx" message should be emitted by one of the dev_printks in
arch/x86/kernel/quirks.c and I fail
> Could you test following patch ?
Yes, sure. Thanks for the quick fix! I should have reported it earlier
(so as to get it fixed earlier) once find the bisect will be time consuming..
Please be patient -- it will take 1-2 days to confirm the bug fix.
Thanks,
Fengguang
--
To unsubscribe from thi
On Sat, Aug 18, 2012 at 05:50:02AM -0400, Namjae Jeon wrote:
> From: Namjae Jeon
>
> This patch is based on suggestion by Wu Fengguang:
> https://lkml.org/lkml/2011/8/19/19
>
> kernel has mechanism to do writeback as per dirty_ratio and dirty_background
> ratio. It also maintains per task dirty
On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote:
> unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long
> dirty)
>
> Above function return type is unsigned long, but return value is
> kept in "u64 bdi_dirty".
> It can return incorrect value by type casting.
I don
On Sat, Aug 18, 2012 at 05:48:29AM -0400, Namjae Jeon wrote:
> There is no reason nr_pages_dirtied is argument anymore.
> because nr_pages_dirtied value from caller is not used in
> balance_dirty_pages_ratelimited_nr function.
Looks good to me. If the fs developers don't have problems with this,
I
On Fri, Aug 17, 2012 at 07:44:37AM -0700, Paul E. McKenney wrote:
> On Fri, Aug 17, 2012 at 10:02:40PM +0800, Fengguang Wu wrote:
> > On Fri, Aug 17, 2012 at 06:43:28AM -0700, Paul E. McKenney wrote:
> > > On Fri, Aug 17, 2012 at 06:06:35PM +0800, Fengguang Wu wrote:
[CC md list]
On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote:
> On Fri, Aug 17, 2012 at 02:09:15PM +0800, Fengguang Wu wrote:
> > Ted,
> >
> > I find ext4 write performance dropped by 3.3% on average in the
> > 3.6-rc1 merge window. xfs and btrfs are
On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote:
> On Fri, Aug 17, 2012 at 02:09:15PM +0800, Fengguang Wu wrote:
> > Ted,
> >
> > I find ext4 write performance dropped by 3.3% on average in the
> > 3.6-rc1 merge window. xfs and btrfs are fine.
>
On Fri, Aug 17, 2012 at 06:43:28AM -0700, Paul E. McKenney wrote:
> On Fri, Aug 17, 2012 at 06:06:35PM +0800, Fengguang Wu wrote:
> > Greetings,
> >
> > FYI, a lockdep warning:
>
> Certainly looks problematic!
>
> Any hint as to what version of the kernel produc
Hi Ted,
On Fri, Aug 17, 2012 at 09:15:58AM -0400, Theodore Ts'o wrote:
> Thanks Fengguang:
>
> For the record, I was able to find my own easy repro, last night using
> only a 220 meg partition:
>
> # mke2fs -t ext4 -b 1024 -J size=1 /dev/vdc
> # mount -t ext2 /dev/vdc /vdc
> # mkdir /vdc/a
> # c
On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote:
> Hi Bjørn,
>
> > -static const struct usb_device_id id_table[] __devinitconst = {
> > +static const struct usb_device_id id_table[] = {
>
> Good catch! It magically fixed the oops. So that id_table w
Hi Bjørn,
> -static const struct usb_device_id id_table[] __devinitconst = {
> +static const struct usb_device_id id_table[] = {
Good catch! It magically fixed the oops. So that id_table was
freed sometime with __devinitconst?
There are some more "usb_device_id .* __devinitconst" users in the sy
Ted,
I find ext4 write performance dropped by 3.3% on average in the
3.6-rc1 merge window. xfs and btrfs are fine.
Two machines are tested. The performance regression happens in the
lkp-nex04 machine, which is equipped with 12 SSD drives. lkp-st02 does
not see regression, which is equipped with H
On Thu, Aug 16, 2012 at 11:25:13AM -0400, Theodore Ts'o wrote:
> On Thu, Aug 16, 2012 at 07:10:51PM +0800, Fengguang Wu wrote:
> >
> > Here is the dmesg. BTW, it seems 3.5.0 don't have this issue.
>
> Fengguang,
>
> It sounds like you have a (at least fai
On Fri, Aug 17, 2012 at 10:44:37AM +0800, Ming Lei wrote:
> On Fri, Aug 17, 2012 at 10:29 AM, Fengguang Wu wrote:
>
> >
> > Something obviously wrong here:
> >
> > env->buflen == 12
> > env->envp_idx == 1627389952
> > e
> > --- tip.orig/drivers/base/core.c2012-08-17 08:48:07.101972082 +0800
> > +++ tip/drivers/base/core.c 2012-08-17 09:49:43.665912992 +0800
> > @@ -343,8 +343,11 @@ static ssize_t show_uevent(struct device
> > goto out;
> >
> > /* copy keys to file */
> > -
On Thu, Aug 16, 2012 at 10:27:11AM -0700, Greg KH wrote:
> On Wed, Jul 18, 2012 at 01:15:52PM +0800, Fengguang Wu wrote:
> > On Mon, Jul 16, 2012 at 06:33:42PM -0700, Greg Kroah-Hartman wrote:
> > > On Fri, Jul 13, 2012 at 04:46:16PM +0800, Fengguang Wu wrote:
> > >
On Sun, Aug 05, 2012 at 09:58:26AM -0700, Greg KH wrote:
> On Sun, Aug 05, 2012 at 10:59:38AM +0800, Fengguang Wu wrote:
> > Hi all,
> >
> > This line triggers an oops in kvm boot test:
> >
> > usb_match_id():
> > ==> 748 for (; id->idVen
et->xfrm.xfrm4_dst_ops = *afinfo->dst_ops;
> #if IS_ENABLED(CONFIG_IPV6)
> --
> 1.7.1
>
>
>
>
> On 2012年08月16日 15:37, Fengguang Wu wrote:
> >Hi Priyanka,
> >
> >The below warning shows up, probably related to this commit:
&
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2432,6 +2432,10 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode,
>
> /* the header must be checked already in ext4_ext_remove_space() */
> ext_debug("truncate since %u in leaf to %u\n", start, end);
> + if (!path[
On Wed, Aug 15, 2012 at 09:42:58AM -0400, Mark Salter wrote:
> On Wed, 2012-08-15 at 10:36 +0800, Fengguang Wu wrote:
> > > -#define L1_CACHE_BYTESL2_CACHE_BYTES
> > > +#define L1_CACHE_SHIFTL2_CACHE_SHIFT
> > > +#define L1_CACHE_BYTES(1 <&
On Tue, Aug 14, 2012 at 02:16:52PM -0700, Kees Cook wrote:
> On Thu, Aug 9, 2012 at 6:52 PM, Fengguang Wu wrote:
> > On Thu, Aug 09, 2012 at 06:39:34PM -0700, Kees Cook wrote:
> >> Hi,
> >>
> >> So, after taking a closer look at this, I cannot understand how
> -#define L1_CACHE_BYTESL2_CACHE_BYTES
> +#define L1_CACHE_SHIFTL2_CACHE_SHIFT
> +#define L1_CACHE_BYTES(1 << L2_CACHE_SHIFT)
Nitpick: the last line could better be:
+#define L1_CACHE_BYTES(1 << L1_CACHE_SHIFT)
Reviewed-by: Fenggua
On Tue, Aug 14, 2012 at 12:22:49PM -0400, Mark Salter wrote:
> On Tue, 2012-08-14 at 23:34 +0800, Fengguang Wu wrote:
> > Sorry I have no compilers for build testing these changes, however the
> > risk looks low and it's much better than to leave the arch broken,
> > con
Sorry I have no compilers for build testing these changes, however the
risk looks low and it's much better than to leave the arch broken,
considering that Eric will do atomic64_t in the core fs/namespace.c code.
CC: "Eric W. Biederman"
Signed-off-by: Fengguang Wu
---
A
Rationals from Eric:
So I just looked a little deeper and it appears architectures that do
not support atomic64_t are broken.
The generic atomic64 support came in 2009 to support the perf subsystem
with the expectation that all architectures would implement atomic64
support.
Furthermore upon ins
Signed-off-by: Fengguang Wu
---
arch/mn10300/Kconfig |1 +
1 file changed, 1 insertion(+)
--- linux.orig/arch/mn10300/Kconfig 2012-08-03 15:36:21.391560778 +0800
+++ linux/arch/mn10300/Kconfig 2012-08-14 22:53:14.751795832 +0800
@@ -8,6 +8,7 @@ config MN10300
select HAVE
On Mon, Aug 13, 2012 at 12:08:47PM -0700, Eric W. Biederman wrote:
> Fengguang Wu writes:
>
> > On Tue, Aug 14, 2012 at 01:55:16AM +0800, Fengguang Wu wrote:
> >> > >I'd suggest to fix it in m68k and make atomic64_t generally available.
> >> &
68k.
>
> Signed-off-by: Greg Ungerer
Signed-off-by: Fengguang Wu
Thanks for the complete solution!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majo
On Tue, Aug 14, 2012 at 01:55:16AM +0800, Fengguang Wu wrote:
> > >I'd suggest to fix it in m68k and make atomic64_t generally available.
> >
> > Fengguang in your testing on any architechtures is atomic64_t missing on
> > anything except some m68k subarchtechture
> >I'd suggest to fix it in m68k and make atomic64_t generally available.
>
> Fengguang in your testing on any architechtures is atomic64_t missing on
> anything except some m68k subarchtechtures?
Eric, it only complaints for m68k, among the architechtures the build
tests covered (alpha arm avr3
On Sun, Aug 12, 2012 at 11:56:45PM -0700, Eric W. Biederman wrote:
> Fengguang Wu writes:
>
> > Hi Geert,
> >
> > This is the build error I get, on Eric's userns tree.
> >
> > tree:
> > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/use
On Sun, Aug 12, 2012 at 04:47:31PM +0200, Geert Uytterhoeven wrote:
> Hi Fengguang,
>
> On Sun, Aug 12, 2012 at 4:23 PM, Fengguang Wu wrote:
> > This fixes build errors like:
> >
> > fs/namespace.c:2290:1: error: unknown type name 'atomic64_t'
>
struct mnt_namespace *alloc_mnt_ns(void)
2293 {
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/m68k 3.6.0-rc1 Kernel Configuration
#
CONFIG_M68K=y
CONFI
t
fs/namespace.c: In function 'alloc_mnt_ns':
fs/namespace.c:2299:2: error: implicit declaration of function
'atomic64_add_return' [-Werror=implicit-function-declaration]
Signed-off-by: Fengguang Wu
---
arch/m68k/Kconfig |1 +
1 file changed, 1 insertion(+)
--- linux.ori
f a function, the initializer list must
consist of constant expressions.
Cc:
Signed-off-by: Mel Gorman
Signed-off-by: Fengguang Wu
---
arch/alpha/include/asm/atomic.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:36
On Sun, Aug 12, 2012 at 01:33:09PM +1200, Michael Cree wrote:
> On 03/08/12 03:02, Fengguang Wu wrote:
> > On Thu, Jul 26, 2012 at 10:06:41AM -0700, Tony Luck wrote:
> >> On Tue, Jul 24, 2012 at 10:10 PM, James Bottomley
> >> wrote:
> >>>> Here i
We need to free up memory in this order:
free csrows[i]->channels[j]
free csrows[i]->channels
free csrows[i]
free csrows
Signed-off-by: Fengguang Wu
---
drivers/edac/edac_mc.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
--- linux.orig/drivers/edac/eda
tool, please only run it as normal user in a
backed up and chrooted test box. I personally run it inside an initrd.
If you are interested in reproducing this, I can send you the ready
made initrd in private email.
Thanks,
Fengguang
> On Thu, Jul 26, 2012 at 6:47 AM, Fengguan
On Thu, Aug 09, 2012 at 04:54:37PM -0700, Roland Dreier wrote:
> thanks for the report. I assume the system doesn't actually have ocrdma hw?
Yeah, it's a test boot inside KVM.
Thanks,
Fengguang
> - R.
> On Aug 9, 2012 3:00 AM, "Fengguang Wu" wrote:
>
> &g
}
> 429 kfree(mci->csrows[i]);
430 }
431 kfree(mci->csrows);
432 }
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu Intel Corporation
--
To unsubscribe f
On Tue, Aug 07, 2012 at 04:54:44PM +0200, Sasha Levin wrote:
> On 08/06/2012 08:34 AM, Al Viro wrote:
> > On Sat, Aug 04, 2012 at 12:59:31PM +0200, Sasha Levin wrote:
> >> Hi all,
> >>
> >> While fuzzing with trinity inside a KVM tools guest, using latest -next
> >> kernel, I've stumbled on the du
On Tue, Aug 07, 2012 at 07:39:55AM +0100, Al Viro wrote:
> On Tue, Aug 07, 2012 at 01:04:12PM +0800, Fengguang Wu wrote:
>
> > FYI, here is a different back trace on that commit.
> >
> > [3.255043] ==
> > [
On Tue, Aug 07, 2012 at 09:29:33AM -0400, Steven Rostedt wrote:
> On Wed, 2012-08-01 at 07:57 +0800, Fengguang Wu wrote:
> > >
> > > What was the next lines? I bet you it was "PASSED". Which means it did
> > > not fail. This is the second bug you found th
assed *const* struct spi_driver.
Signed-off-by: Fengguang Wu
---
drivers/tty/serial/ifx6x60.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/drivers/tty/serial/ifx6x60.c 2012-05-24 19:03:07.408430953
+0800
+++ linux/drivers/tty/serial/ifx6x60.c 2012-08-07 12:57:
Buffered write(2) is not directly tied to IO, so it's not suitable to
handle plug in generic_file_aio_write().
Note that plugging for O_SYNC writes is also removed. The user may pass
arbitrary @size arguments, which may be much larger than the preferable
I/O size, or may cross extent/device bounda
Hi all,
It seems this patch was silently forgotten, but the review comments have all
been addressed: the patch has been split into two pieces and tests show no
performance regressions (nor noticeable gains..).
Thanks to Damien for reminding me of the patch!
Thanks,
Fengguang
--
To unsubscribe f
Move unplugging for direct I/O from around ->direct_IO() down to
do_blockdev_direct_IO(). This implicitly adds plugging for direct
writes.
CC: Li Shaohua
Acked-by: Jeff Moyer
Signed-off-by: Wu Fengguang
---
fs/direct-io.c |5 +
mm/filemap.c |4
2 files changed, 5 insertions(
No behavior change, code generated by: scripts/coccicheck/api/ptr_ret.cocci
Signed-off-by: Fengguang Wu
---
fs/btrfs/volumes.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
--- linux.orig/fs/btrfs/volumes.c 2012-08-04 15:33:02.038203882 +0800
+++ linux/fs/btrfs/volumes.c
Fix a real bug caught by coccinelle.
fs/btrfs/delayed-inode.c:1013:1-11: second lock on line 1013
Signed-off-by: Fengguang Wu
---
fs/btrfs/delayed-inode.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux.orig/fs/btrfs/delayed-inode.c 2012-08-03 15:36:21.763560787 +0800
On Fri, Aug 03, 2012 at 11:37:53AM +0200, Jiri Slaby wrote:
> On 08/03/2012 03:46 AM, Fengguang Wu wrote:
> > Hi all,
>
> Hi,
>
> > The IRQ should be disabled somewhere in the path walk, which makes
> > the GFP_KERNEL allocation in uart_startup() no longer valid..
&
] [] __stack_chk_fail+0x2b/0x30
[ 23.185748] [] isdnloop_init+0xaf/0xb1
Signed-off-by: Fengguang Wu
---
drivers/isdn/isdnloop/isdnloop.c | 12
1 file changed, 12 deletions(-)
--- linux.orig/drivers/isdn/isdnloop/isdnloop.c 2012-08-03 16:39:08.543650310
+0800
+++ linux/drivers/isdn/isdnloop
On Thu, Aug 02, 2012 at 04:21:56PM -0700, David Miller wrote:
> From: Fengguang Wu
> Date: Thu, 2 Aug 2012 19:05:43 +0800
>
> > Fix a buffer overflow bug by removing the revision transform code.
> >
> > [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7
> >
izer to initialize the field enabled. A compound literal is not a
constant expression.
The location of the above statement isn't fully clear, but if a compound
literal occurs outside the body of a function, the initializer list must
consist of constant expressions.
Reported-by: Fengguang Wu
] [] __stack_chk_fail+0x2b/0x30
[ 23.185748] [] isdnloop_init+0xaf/0xb1
Signed-off-by: Fengguang Wu
---
drivers/isdn/isdnloop/isdnloop.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
--- linux.orig/drivers/isdn/isdnloop/isdnloop.c 2012-05-24 19:03:06.748430938
+0800
+++ linux
On Thu, Aug 02, 2012 at 01:57:36PM +0300, Dan Carpenter wrote:
> On Thu, Aug 02, 2012 at 06:44:56PM +0800, Fengguang Wu wrote:
> > [Add more CC]
> >
>
> That's not helpful... Resend the patch to netdev in a way that
> applies.
OK, sorry...
--
To unsubscribe
[Add more CC]
On Thu, Aug 02, 2012 at 12:01:58PM +0800, Fengguang Wu wrote:
> Remove the non-sense isdnloop revision transform code, so as to fix:
>
> [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7
> [ 22.097508] isdnloop: (loop0) virtual card added
> [ 22.174400] Ker
] [] __stack_chk_fail+0x2b/0x30
[ 23.185748] [] isdnloop_init+0xaf/0xb1
Signed-off-by: Fengguang Wu
---
drivers/isdn/isdnloop/isdnloop.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
--- linux.orig/drivers/isdn/isdnloop/isdnloop.c 2012-05-24 19:03:06.748430938
+0800
+++ linux
On Tue, Jul 31, 2012 at 05:18:11PM -0700, Paul E. McKenney wrote:
> On Tue, Jul 31, 2012 at 08:09:38PM -0400, Steven Rostedt wrote:
> > On Tue, 2012-07-31 at 16:57 -0700, Paul E. McKenney wrote:
> >
> > > > What was the next lines? I bet you it was "PASSED". Which means it did
> > > > not fail. Th
On Tue, Jul 31, 2012 at 07:51:39PM -0400, Steven Rostedt wrote:
> On Wed, 2012-08-01 at 07:43 +0800, Fengguang Wu wrote:
> > On Tue, Jul 31, 2012 at 09:13:39AM -0400, Steven Rostedt wrote:
> > > On Tue, 2012-07-31 at 15:50 +0300, Avi Kivity wrote:
> > > > On 07/31
On Tue, Jul 31, 2012 at 09:13:39AM -0400, Steven Rostedt wrote:
> On Tue, 2012-07-31 at 15:50 +0300, Avi Kivity wrote:
> > On 07/31/2012 03:43 PM, Steven Rostedt wrote:
>
> > That would be better. A hypervisor might be real-time capable (with
> > some effort kvm can do this), so we don't want to
On Tue, Jul 31, 2012 at 03:06:11PM +0200, Lars-Peter Clausen wrote:
> On 07/31/2012 02:55 PM, Fengguang Wu wrote:
> >>> The panic happens while trying to dereference the NULL indio_dev->buffer:
> >>>
> >>> 266 int iio_buffer_register(st
> > The panic happens while trying to dereference the NULL indio_dev->buffer:
> >
> > 266 int iio_buffer_register(struct iio_dev *indio_dev,
> > 267 const struct iio_chan_spec *channels,
> > 268 int num_channels)
> > 2
[CC kvm developers]
On Mon, Jul 30, 2012 at 11:45:05AM -0400, Steven Rostedt wrote:
> On Tue, 2012-07-24 at 17:07 +0800, Fengguang Wu wrote:
> > On Tue, Jul 24, 2012 at 05:03:30PM +0800, Fengguang Wu wrote:
>
> > And this warning shows up in one of the dozens of boots, for th
On Mon, Jul 30, 2012 at 11:39:12AM -0400, Steven Rostedt wrote:
> On Tue, 2012-07-24 at 17:03 +0800, Fengguang Wu wrote:
> > Hi Steven,
>
> Hi Fengguang,
>
> Just an FYI, It's best to send email to my rost...@goodmis.org account.
> I don't check my redhat
On Tue, Jul 31, 2012 at 05:13:26PM +0800, Fengguang Wu wrote:
> On Tue, Jul 31, 2012 at 09:58:15AM +0100, Al Viro wrote:
> > On Tue, Jul 31, 2012 at 04:38:39PM +0800, Fengguang Wu wrote:
> > > Hi Jan,
> > >
> > > Here is another warning for the fs fre
On Tue, Jul 31, 2012 at 09:58:15AM +0100, Al Viro wrote:
> On Tue, Jul 31, 2012 at 04:38:39PM +0800, Fengguang Wu wrote:
> > Hi Jan,
> >
> > Here is another warning for the fs freeze series.
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/g
Hi Linus,
The following changes since commit f8f5701bdaf9134b1f90e5044a82c66324d2073f:
Linux 3.5-rc1 (2012-06-02 18:29:26 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux.git
tags/writeback-proportions
for you to fetch changes up to 33
On Sun, Jul 29, 2012 at 02:00:03PM +0100, Alan Cox wrote:
> On Sun, 29 Jul 2012 20:40:22 +0800
> Fengguang Wu wrote:
>
> > Hi,
> >
> > This is probably a rather old bug, triggered while doing randconfig
> > boot tests in kvm:
>
> I'm not sure test
> > --- linux.orig/net/bridge/netfilter/ebtable_filter.c2012-07-29
> > 08:41:09.703759534 +0800
> > +++ linux/net/bridge/netfilter/ebtable_filter.c 2012-07-29
> > 08:41:14.255759643 +0800
> > @@ -100,9 +100,7 @@ static struct nf_hook_ops ebt_ops_filter
> > static int __net_init frame
gusmax_init+0xf/0xf
[6.194607] [] ? do_one_initcall+0x7f/0x12b
[6.194607] [] ? kernel_init+0x112/0x1a9
[6.194607] [] ? do_early_param+0x77/0x77
[6.194607] [] ? do_one_initcall+0x12b/0x12b
[6.194607] [] ? kernel_thread_helper+0x6/0xd
[6.210779] es1688: can't grab
-3: WARNING: PTR_RET can be used
net/ipv4/netfilter/iptable_raw.c:51:1-3: WARNING: PTR_RET can be used
net/ipv4/netfilter/iptable_security.c:70:1-3: WARNING: PTR_RET can be used
Signed-off-by: Fengguang Wu
---
net/bridge/netfilter/ebtable_filter.c |4 +---
net/bridge/netfilter/ebtable_nat.c
Reported by coccinelle:
drivers/tty/serial/pch_uart.c:979:1-14: alloc with no test, possible model on
line 994
Signed-off-by: Fengguang Wu
---
drivers/tty/serial/pch_uart.c |4
1 file changed, 4 insertions(+)
WARNING: this may be a superficial fix!
--- linux.orig/drivers/tty/serial
Open Source Technology Centre
Fengguang Wu Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Fix coccinelle warning (without behavior change):
drivers/block/floppy.c:2518:32-48: duplicated argument to & or |
Signed-off-by: Fengguang Wu
---
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 553f43a..0fcbe14 100644
--- a/drivers/block/floppy.c
+++ b/drivers/b
This will fix build errors:
block/blk-cgroup.c:609:2: error: unknown type name 'atomic64_t'
block/blk-cgroup.c:609:2: error: implicit declaration of function
'ATOMIC64_INIT' [-Werror=implicit-function-declaration]
Signed-off-by: Fengguang Wu
---
arch/xtensa/Kconfig |1
On Wed, Jul 25, 2012 at 05:19:40PM +0200, Julia Lawall wrote:
> I looked at it a bit more, and I think the timeout is the best solution.
> The big jump backwards is under an if, and the pattern tries to match an
> if up to a return, which tries to go across gotos. So I think it is just
> a patholo
On Wed, Jul 25, 2012 at 04:43:04PM +0200, Julia Lawall wrote:
> On Wed, 25 Jul 2012, Fengguang Wu wrote:
>
> > Hi Julia,
> >
> > On Wed, Jul 25, 2012 at 04:15:19PM +0200, Julia Lawall wrote:
> > > Do you use a timeout when you run Coccinelle You could put
> - select ACPI_WMI if ACPI
> + select ACPI_WMI if ACPI && !IA64
> select MXM_WMI if ACPI
Sorry, the MXM_WMI line should also be changed. Although MXM_WMI
depends on ACPI_WMI, "select" is dumb and will ignore that dependency..
Thanks,
Fengguang
---
From:
re
> are a lot of ifs in between. It seems possible that there is too much
> information, and it gets too slow. I will look further.
Ah OK, yeah this coccinelle case is a bit complex.
Thanks,
Fengguang
> On Wed, 25 Jul 2012, Fengguang Wu wrote:
>
> > Hi all,
> >
> &g
On Wed, Jul 25, 2012 at 01:18:39AM -0700, Joe Perches wrote:
> On Wed, 2012-07-25 at 16:06 +0800, Fengguang Wu wrote:
> > The macro name is too generic and conflicts with
> > snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.
>
> Is platform_name
Hi Hauke,
The coccinelle static checker emits these warnings:
drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and
execution via conditional on line 465
drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and
execution via conditional on line 539
It
Hi all,
This command seem to hang for ever on the current linus/master.
It happens only on mini_lock.cocci _and_ mm/shmem.c
I've updated coccinelle to its git release, however it didn't help..
% spatch -debug -D report -I /c/kernel-tests/src/linux/include -sp_file
/c/kernel-tests/src/linux/scri
Signed-off-by: Fengguang Wu
---
scripts/coccinelle/api/memdup_user.cocci |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/coccinelle/api/memdup_user.cocci
b/scripts/coccinelle/api/memdup_user.cocci
index 2efac28..2b131a8 100644
--- a/scripts/coccinelle/api
Andrew, will you accept this fix? It's obviously caused by a typo in
commit 1754aab9bb86.
On Sun, Jul 22, 2012 at 10:25:41AM +0800, Fengguang Wu wrote:
> arch/avr32/boards/atstk1000/atstk1002.c:100: error: 'num_partitions'
> undeclared here (not in a function)
>
> wh
The macro name is too generic and conflicts with
snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.
Signed-off-by: Fengguang Wu
---
(not sure if the previous sent was successful, so resend)
arch/ia64/include/asm/machvec.h |2 +-
arch/ia64/include/asm
I'm not sure if this is the best way, however it does fix the last 2
allmodconfig errors on IA64:
ERROR: "wmi_has_guid" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "wmi_evaluate_method" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
Signed-off-by: Fengguang
Well, this at least makes allmodconfig happy.
Proposed-by: David Howells
Signed-off-by: Fengguang Wu
---
arch/ia64/Kconfig |3 +--
arch/ia64/kvm/Kconfig |1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 8186ec5..310cf57
Fix build error on IA64:
ERROR: "mxm_wmi_supported" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
Signed-off-by: Fengguang Wu
---
include/linux/mxm-wmi.h |8
1 file changed, 8 insertions(+)
diff --git a/include/linux/mxm-wmi.h b/include/linux/mxm-wmi.h
index 617a29
On Tue, Jul 24, 2012 at 05:03:30PM +0800, Fengguang Wu wrote:
> Hi Steven,
>
> This looks like some old bug, so I directly report to you w/o trying
> to bisect it. It only happens on the attached i386 randconfig and
> happens in about half of the kvm boots.
>
> [1.3
1201 - 1300 of 1745 matches
Mail list logo
