Headphone/mic jack detection doesn't work on the Chromebook Pixel 2015.
These patches change the irq implementation to support polarity flipping.
With this series, plugging and unplugging the headphone jack switches
between headphones and speakers automatically, and headset microphones
are also
-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 173 ++
sound/soc/codecs/rt5677.h | 8 +-
2 files changed, 145 insertions(+), 36 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 87a92ba0d040b7
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 71
On Sun, Jun 16, 2019 at 10:56 AM Cezary Rojewski
wrote:
> On 2019-06-14 21:48, Fletcher Woodruff wrote:
> > +static irqreturn_t rt5677_irq(int unused, void *data)
> > +{
> > + struct rt5677_priv *rt5677 = data;
> > + int ret = 0, i, reg_irq, virq;
>
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 67
-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 170 ++
sound/soc/codecs/rt5677.h | 7 +-
2 files changed, 143 insertions(+), 34 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 87a92ba0d040b7
names first and fall back to the DT names on error.
With this patch, plugging and unplugging the headphone jack switches
between headphones and speakers automatically.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37
settings are controlling.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 60 ++-
sound/soc/codecs/rt5677.h | 6
2 files changed, 40 insertions(+), 26 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc
our own irq_chip.
v2:
- Split IRQ change into two patches: adding and fixing potential race
- Change config reading code to try both DT and ACPI style names
Ben Zhang (2):
ASoC: rt5677: clear interrupts by polarity flip
ASoC: rt5677: handle concurrent interrupts
Fletcher Woodruff (2
names first and fall back to the DT names on error.
With this patch, plugging and unplugging the headphone jack switches
between headphones and speakers automatically.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37
.
v2:
- Split IRQ change into two patches: adding and fixing potential race
- Change config reading code to try both DT and ACPI style names
Ben Zhang (2):
ASoC: rt5677: clear interrupts by polarity flip
ASoC: rt5677: handle concurrent interrupts
Fletcher Woodruff (2):
ASoC: rt5677
-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 170 ++
sound/soc/codecs/rt5677.h | 7 +-
2 files changed, 143 insertions(+), 34 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index b508fd9b7d4536
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 67
settings are controlling.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 60 ++-
sound/soc/codecs/rt5677.h | 6
2 files changed, 40 insertions(+), 26 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 67
-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 169 ++
sound/soc/codecs/rt5677.h | 7 +-
2 files changed, 142 insertions(+), 34 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 65bef50ded1151
settings are controlling.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 60 ++-
sound/soc/codecs/rt5677.h | 6
2 files changed, 40 insertions(+), 26 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc
names first and fall back to the DT names on error.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 9b7a1833d3316c
patches: adding and fixing potential race
- Change config reading code to try both DT and ACPI style names
Ben Zhang (2):
ASoC: rt5677: clear interrupts by polarity flip
ASoC: rt5677: handle concurrent interrupts
Fletcher Woodruff (2):
ASoC: rt5677: fall back to DT prop names on error
ASoC
. Inside the handler, we will need to
detect this, report the hotword event, and re-connect GPIO1 to the jack
detection irq.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 256 --
sound/soc/codecs/rt5677.h | 14 ++-
2
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 84
names first and fall back to the DT names on error.
With this patch, plugging and unplugging the headphone jack switches
between headphones and speakers automatically.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37
implement
our own irq_chip.
v2:
- Split IRQ change into two patches: adding and fixing potential race
- Change config reading code to try both DT and ACPI style names
Ben Zhang (2):
ASoC: rt5677: allow multiple interrupt sources
ASoC: rt5677: handle concurrent interrupts
Fletcher
potential race
- Change config reading code to try both DT and ACPI style names
Ben Zhang (1):
ASoC: rt5677: allow multiple interrupt sources
Fletcher Woodruff (2):
ASoC: rt5677: handle concurrent interrupts
ASoC: rt5677: fall back to DT prop names on error
sound/soc/codecs/rt5677.c | 346
. Inside the handler, we will need to
detect this, report the hotword event, and re-connect GPIO1 to the jack
detection irq.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 256 --
sound/soc/codecs/rt5677.h | 14 ++-
2
loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 84 +++
1 file
names first and fall back to the DT names on error.
With this patch, plugging and unplugging the headphone jack switches
between headphones and speakers automatically.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37
names first and fall back to the DT names on error.
With this patch, plugging and unplugging the headphone jack switches
between headphones and speakers automatically.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 84
On Thu, Apr 18, 2019 at 3:07 AM Mark Brown wrote:
>
> I only have patch 1 here...
Apologies, patches 2/3 were unchanged so I did not resend. I'll add
them to the chain.
both DT and ACPI style names
Ben Zhang (2):
ASoC: rt5677: allow multiple interrupt sources
ASoC: rt5677: handle concurrent interrupts
Fletcher Woodruff (1):
ASoC: rt5677: fall back to DT prop names on error
sound/soc/codecs/rt5677.c | 347 +++---
sound/soc
. Inside the handler, we will need to
detect this, report the hotword event, and re-connect GPIO1 to the jack
detection irq.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 257 --
sound/soc/codecs/rt5677.h | 14 ++-
2
On Mon, Apr 8, 2019 at 12:38 AM Mark Brown wrote:
> On Fri, Apr 05, 2019 at 02:42:55PM -0600, Fletcher Woodruff wrote:
>
> > This patch allows headphone plug detect and mic present
> > detect to be enabled at the same time. This patch implements
> > an irq_chip with irq
names first and fall back to the DT names on error.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 74 +++
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 6bff0df53c6c6b
.
Add a bounded loop to rt5677_irq that keeps checking interrupts until
none are seen, so that any interrupts that are signalled in that
interval are correctly handled.
Signed-off-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 84
-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 257 --
sound/soc/codecs/rt5677.h | 14 ++-
2 files changed, 204 insertions(+), 67 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 9b7a1833d3316c
ASoC: rt5677: handle concurrent interrupts
Fletcher Woodruff (1):
ASoC: rt5677: fall back to DT prop names on error
sound/soc/codecs/rt5677.c | 347 +++---
sound/soc/codecs/rt5677.h | 14 +-
2 files changed, 257 insertions(+), 104 deletions(-)
--
2.21.0.392
On Mon, Apr 1, 2019 at 11:02 PM Mark Brown wrote:
> regmap-irq should support active high/low, and if it doesn't it can't be
> a unique thing that only this device wants to implement so the common
> code should be improved.
The rt5677 driver needs its own irq regardless for hotword detection.
If
On Mon, Apr 1, 2019 at 11:06 PM Mark Brown wrote:
> On Mon, Apr 01, 2019 at 02:55:19PM -0600, Fletcher Woodruff wrote:
> > The rt5677 driver is using the wrong property names to read from ACPI.
> > Update the property names to match those from _DSD, so that the correct
>
and speakers automatically.
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 33380f82b7008f..1f725086cee39c 100644
--- a/sound/soc
-by: Ben Zhang
Signed-off-by: Fletcher Woodruff
---
sound/soc/codecs/rt5677.c | 261 --
sound/soc/codecs/rt5677.h | 14 +-
2 files changed, 208 insertions(+), 67 deletions(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 9b7a1833d3316c
41 matches
Mail list logo
