[PATCH stable-4.9.y] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
b3d42 ("Merge branch 'brport-flags'") which is why we default to enabling learning when the ports gets added as a bridge member. Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch") Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c

[PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-24 Thread Florian Fainelli
From: Florian Fainelli Hi Greg, Sasha, Jaakub and David, This patch series contains backports for a change that recently made it upstream as: commit f3f9be9c58085d11f4448ec199bf49dc2f9b7fb9 Merge: 18755e270666 f9b3827ee66c Author: Jakub Kicinski Date: Tue Feb 23 12:23:06 2021 -0800

Re: [PATCH 1/2] leds: bcm6328: improve write and read functions

2021-02-24 Thread Florian Fainelli
On 2/24/2021 9:36 AM, Pavel Machek wrote: > Hi! > Yeah, but ideally you should not be copying comments; there should be one central place which does it and does it right. >>> >>> I’m open to suggestions :). >>> Which central place would be a good place for you? >> >> I did consider cr

Re: [PATCH v2 0/2] leds: bcm63x8: improve read and write functions

2021-02-24 Thread Florian Fainelli
On 2/24/2021 7:54 AM, Álvaro Fernández Rojas wrote: > Hi Florian, > >> El 24 feb 2021, a las 16:45, Florian Fainelli >> escribió: >> >> >> >> On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote: >>> This code is proven to work in BMIPS BE/L

Re: [PATCH v2 0/2] leds: bcm63x8: improve read and write functions

2021-02-24 Thread Florian Fainelli
On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote: > This code is proven to work in BMIPS BE/LE and ARM BE/LE. > See bcm2835-rng and bcmgenet.c: > https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60 > https://github.com/to

Re: [PATCH v2 2/2] leds: bcm6358: improve write and read functions

2021-02-24 Thread Florian Fainelli
On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote: > This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in bcm2835-rng > and bcmgenet drivers. > Both should also be inline functions. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 1/2] leds: bcm6328: improve write and read functions

2021-02-24 Thread Florian Fainelli
On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote: > This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in bcm2835-rng > and bcmgenet drivers. > Both should also be inline functions. > > Signed-off-by: Álvaro Fernández Rojas Acked-by: Florian Fainelli -- Florian

Re: [PATCH] nand: brcmnand: fix OOB R/W with Hamming ECC

2021-02-23 Thread Florian Fainelli
On 2/22/2021 12:16 PM, Álvaro Fernández Rojas wrote: > Hamming ECC doesn't cover the OOB data, so reading or writing OOB shall > always be done without ECC enabled. > This is a problem when adding JFFS2 cleanmarkers to erased blocks. If JFFS2 > clenmarkers are added to the OOB with ECC enabled,

Re: [PATCH] mips: smp-bmips: fix CPU mappings

2021-02-23 Thread Florian Fainelli
set_cpu_possible(i, 1); > + set_cpu_present(i, 1); > } > - set_cpu_possible(i, 1); > - set_cpu_present(i, 1); > + } else { > + __cpu_number_map[0] = boot_cpu; > + __cpu_logical_map[0] = 0; > + set_cpu_possible(0, 1); > + set_cpu_possible(0, 1); Duplicate line, with that fixed: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 2/2] irqchip: add support for BCM6345 external interrupt controller

2021-02-23 Thread Florian Fainelli
ft = 4; This property is not documented in the binding, other than that: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: document BCM6345 external interrupt controller

2021-02-23 Thread Florian Fainelli
On 2/23/2021 12:43 PM, Álvaro Fernández Rojas wrote: > Document the binding for the BCM6345 external interrupt controller. > > Signed-off-by: Álvaro Fernández Rojas > Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 2/2] hwrng: bcm2835: add reset support

2021-02-23 Thread Florian Fainelli
On 2/23/2021 9:00 AM, Álvaro Fernández Rojas wrote: > BCM6368 devices need to reset the in order to generate true random numbers. > This is what BCM6368 produces without a reset: > root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000 > rngtest 6.10 > Copyright (c) 2004 by Henrique de Moraes Holschuh

Re: [PATCH 1/2] leds: bcm6328: improve write and read functions

2021-02-23 Thread Florian Fainelli
On 2/23/2021 1:05 AM, Álvaro Fernández Rojas wrote: > > >> El 23 feb 2021, a las 9:58, Pavel Machek escribió: >> >> Hi! >> > This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in > bcm2835-rng > and bcmgenet drivers. > Both should also be inline functions.

Re: [PATCH 1/2] dt-bindings: rng: bcm2835: document reset support

2021-02-23 Thread Florian Fainelli
On 2/23/2021 8:01 AM, Álvaro Fernández Rojas wrote: > Some devices may need to perform a reset before using the RNG, such as the > BCM6368. > > Signed-off-by: Álvaro Fernández Rojas Since the reset is unique to the 6368, you may want to make the property mandatory for the 6368 compatible stri

Re: [PATCH] watchdog: bcm7038_wdt: add big endian support

2021-02-22 Thread Florian Fainelli
On 2/22/2021 7:41 PM, Florian Fainelli wrote: > > > On 2/22/2021 2:24 PM, Guenter Roeck wrote: >> On Mon, Feb 22, 2021 at 10:48:09PM +0100, Álvaro Fernández Rojas wrote: >>> Hi Guenter, >>> >>>> El 22 feb 2021, a las 22:24, Guenter Roeck esc

Re: [PATCH] watchdog: bcm7038_wdt: add big endian support

2021-02-22 Thread Florian Fainelli
On 2/22/2021 2:24 PM, Guenter Roeck wrote: > On Mon, Feb 22, 2021 at 10:48:09PM +0100, Álvaro Fernández Rojas wrote: >> Hi Guenter, >> >>> El 22 feb 2021, a las 22:24, Guenter Roeck escribió: >>> >>> On 2/22/21 12:03 PM, Álvaro Fernández Rojas wrote: bcm7038_wdt can be used on bmips (bcm6

Re: [PATCH net v2 2/2] net: dsa: b53: Support setting learning on port

2021-02-22 Thread Florian Fainelli
On 2/22/2021 3:18 PM, Vladimir Oltean wrote: > On Mon, Feb 22, 2021 at 02:30:10PM -0800, Florian Fainelli wrote: >> diff --git a/drivers/net/dsa/b53/b53_regs.h b/drivers/net/dsa/b53/b53_regs.h >> index c90985c294a2..b2c539a42154 100644 >> --- a/drivers/net/dsa/b53/b53_re

[PATCH net v2 0/2] net: dsa: Learning fixes for b53/bcm_sf2

2021-02-22 Thread Florian Fainelli
o Fixes tag provided. I will be providing targeted stable backports that look a bit difference. Changes in v2: - added first patch - updated second patch to include BR_LEARNING check in br_flags_pre as a support bridge flag to offload Florian Fainelli (2): net: dsa: bcm_sf2: Wire-up br_fla

[PATCH net v2 2/2] net: dsa: b53: Support setting learning on port

2021-02-22 Thread Florian Fainelli
port 7 cannot be bridged, so its learning attribute will not change past its initial configuration. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 20 +++- drivers/net/dsa/b53/b53_regs.h | 1 + drivers/net/dsa/bcm_sf2.c| 15 +-- 3

[PATCH net v2 1/2] net: dsa: bcm_sf2: Wire-up br_flags_pre, br_flags and set_mrouter

2021-02-22 Thread Florian Fainelli
t;) Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 19 +++ drivers/net/dsa/b53/b53_priv.h | 8 drivers/net/dsa/bcm_sf2.c| 3 +++ 3 files changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/n

Re: [PATCH net] net: dsa: b53: Support setting learning on port

2021-02-22 Thread Florian Fainelli
On 2/22/2021 1:46 PM, Florian Fainelli wrote: > Add support for being able to set the learning attribute on port, and > make sure that the standalone ports start up with learning disabled. > > We can remove the code in bcm_sf2 that configured the ports learning > attribute beca

[PATCH net] net: dsa: b53: Support setting learning on port

2021-02-22 Thread Florian Fainelli
port 7 cannot be bridged, so its learning attribute will not change past its initial configuration. Signed-off-by: Florian Fainelli --- David, Jakub, This is submitted against "net" because this is technically a bug fix since ports should not have had learning enabled by default but giv

Re: [PATCH] irqchip/bcm-6345-l1: fix SMP support

2021-02-22 Thread Florian Fainelli
On 2/22/2021 12:13 PM, Álvaro Fernández Rojas wrote: > Some BCM6358 devices start with Core #1 instead of Core #0. > Apart from that, SMP is restricted to 1 CPU since BCM6358 has a shared TLB, > which makes it impossible for the current SMP support to start both CPUs. > > The problem is that sm

Re: [PATCH 4.9 00/49] 4.9.258-rc1 review

2021-02-22 Thread Florian Fainelli
gt; or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. On ARCH_BRCMST, 32-bit and 64-bit ARM: Tested-by: Florian Fainelli -- Florian

Re: [PATCH 5.4 00/13] 5.4.100-rc1 review

2021-02-22 Thread Florian Fainelli
gt; or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.4.y > and the diffstat can be found below. On ARCH_BRCMSTB with 32-bit ARM and 64-bit ARM kernels: Tested-by: Florian Fainelli -- Florian

Re: [PATCH 5.10 00/29] 5.10.18-rc1 review

2021-02-22 Thread Florian Fainelli
gt; or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.10.y > and the diffstat can be found below. On ARCH_BRCMSTB using 32-bit ARM and 64-bit ARM kernels: Tested-by: Florian Fainelli Thanks! -- Florian

Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

2021-02-21 Thread Florian Fainelli
successfully then reset. Signed-off-by: Sieng Piaw Liew Acked-by: Florian Fainelli Fixes: 4c59b0f5543d ("bcm63xx_enet: add BQL support") -- Florian

Re: [PATCH net-next] net: dsa: Fix dependencies with HSR

2021-02-19 Thread Florian Fainelli
On 2/19/2021 9:12 PM, Florian Fainelli wrote: > The core DSA framework uses hsr_is_master() which would not resolve to a > valid symbol if HSR is built-into the kernel and DSA is a module. > > Fixes: 18596f504a3e ("net: dsa: add support for offloading HSR") > Repor

[PATCH net-next] net: dsa: Fix dependencies with HSR

2021-02-19 Thread Florian Fainelli
The core DSA framework uses hsr_is_master() which would not resolve to a valid symbol if HSR is built-into the kernel and DSA is a module. Fixes: 18596f504a3e ("net: dsa: add support for offloading HSR") Reported-by: kernel test robot Signed-off-by: Florian Fainelli --- David, Ja

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-19 Thread Florian Fainelli
On 2/19/2021 7:53 AM, Greg Kroah-Hartman wrote: > On Fri, Feb 19, 2021 at 07:05:41AM -0800, Florian Fainelli wrote: >> >> >> On 2/19/2021 12:25 AM, Greg Kroah-Hartman wrote: >>> On Thu, Feb 18, 2021 at 12:16:50PM -0800, Scott Branden wrote: >>>> On

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-19 Thread Florian Fainelli
t 06:53:56PM +0100, Greg Kroah-Hartman wrote: >>>>> On Thu, Feb 18, 2021 at 09:21:13AM -0800, Florian Fainelli wrote: >>>>>> As a company, we are most likely shooting ourselves in the foot by not >>>>>> having a point of coordination with the Li

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
56PM +0100, Greg Kroah-Hartman wrote: >>>>> On Thu, Feb 18, 2021 at 09:21:13AM -0800, Florian Fainelli wrote: >>>>>> As a company, we are most likely shooting ourselves in the foot by >>>>>> not >>>>>> having a point of coordination

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 9:53 AM, Greg Kroah-Hartman wrote: > On Thu, Feb 18, 2021 at 09:21:13AM -0800, Florian Fainelli wrote: >> As a company, we are most likely shooting ourselves in the foot by not >> having a point of coordination with the Linux Foundation and key people >> lik

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/17/2021 11:48 AM, Scott Branden wrote: > Hi Greg, > > On 2021-02-17 1:40 a.m., Greg Kroah-Hartman wrote: >> On Tue, Jan 26, 2021 at 07:51:18PM +0100, Greg Kroah-Hartman wrote: >>> On Tue, Jan 26, 2021 at 10:30:16AM -0800, Scott Branden wrote: Hi Greg, On 2021-01-25 11:2

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 8:51 AM, Sasha Levin wrote: > On Wed, Feb 17, 2021 at 11:48:21AM -0800, Scott Branden wrote: >> On 2021-02-17 1:40 a.m., Greg Kroah-Hartman wrote: >>> Following up on this as I did not hear back from you.  Are you and/or >>> your company willing to help out with the testing of 5.10

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-18 Thread Florian Fainelli
On 2/18/2021 3:31 AM, Willy Tarreau wrote: > On Thu, Feb 18, 2021 at 08:43:48AM +0100, Greg Kroah-Hartman wrote: >> On Wed, Feb 17, 2021 at 11:48:21AM -0800, Scott Branden wrote: >>> Other difficulty with the LTS version is the frequency it is updated. > > What a stange statement! So basically

Re: [PATCH] net: ftgmac100: Support phyless operation

2021-02-17 Thread Florian Fainelli
On 2/17/2021 7:40 PM, William A. Kennington III wrote: > We have BMC to BMC connections that lack a PHY in between but don't > want to use the NC-SI state machinery of the kernel. Instead, > allow for an option to disable the phy detection and mdio logic. > > Signed-off-by: William A. Kenningto

[PATCH net-next] net: mdio: Remove of_phy_attach()

2021-02-17 Thread Florian Fainelli
We have no in-tree users, also update the sfp-phylink.rst documentation to indicate that phy_attach_direct() is used instead of of_phy_attach(). Signed-off-by: Florian Fainelli --- Documentation/networking/sfp-phylink.rst | 2 +- drivers/net/mdio/of_mdio.c | 30

Re: [PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-16 Thread Florian Fainelli
On 2/12/2021 11:11 AM, Florian Fainelli wrote: > As Dave reported: > > This seems to have unintended side effects. GIC interrupt 117 is shared > between the standard I2C controllers (i2c-bcm2835) and the l2-intc block > handling the HDMI I2C interrupts. > > There is not

[PATCH] tg3: Remove unused PHY_BRCM flags

2021-02-16 Thread Florian Fainelli
The tg3 driver tried to communicate towards the PHY driver whether it wanted RGMII in-band signaling enabled or disabled however there is nothing that looks at those flags in drivers/net/phy/broadcom.c so this does do not anything. Suggested-by: Vladimir Oltean Signed-off-by: Florian Fainelli

Re: [PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-14 Thread Florian Fainelli
On 2/13/2021 2:42 AM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 07:46:32PM -0800, Florian Fainelli wrote: >> BCM54210E/BCM50212E has been verified to work correctly with the >> auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it >> to the

[PATCH net-next v2 0/3] net: phy: broadcom: Cleanups and APD

2021-02-12 Thread Florian Fainelli
ual hardware - added a patch to remove a forward declaration - do additional flags cleanup Florian Fainelli (3): net: phy: broadcom: Avoid forward for bcm54xx_config_clock_delay() net: phy: broadcom: Remove unused flags net: phy: broadcom: Allow BCM54210E to configure APD drivers/net/

[PATCH net-next v2 2/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
driver private structure instead to store that flag instead of canibalizing one from phydev->dev_flags for that purpose. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 19 --- include/linux/brcmphy.h| 21 - 2 files changed, 24 insertions(+),

[PATCH net-next v2 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-12 Thread Florian Fainelli
when there is no energy on the cable. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 8 +--- include/linux/brcmphy.h| 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 3ce266ab521b

[PATCH net-next v2 1/3] net: phy: broadcom: Avoid forward for bcm54xx_config_clock_delay()

2021-02-12 Thread Florian Fainelli
Avoid a forward declaration by moving the callers of bcm54xx_config_clock_delay() below its body. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 74 +++--- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/net/phy

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Florian Fainelli wrote: > > > On 2/12/2021 5:11 PM, Vladimir Oltean wrote: >> On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: >>> When support for optionally disabling the TXC was introduced, bit 2 was >>> used to do tha

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:14 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 05:08:58PM -0800, Florian Fainelli wrote: >> That's right, tg3 drove a lot of the Broadcom PHY driver changes back >> then, I also would like to rework the way we pass flags towards PHY >> driver

Re: [PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
On 2/12/2021 5:11 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:20PM -0800, Florian Fainelli wrote: >> When support for optionally disabling the TXC was introduced, bit 2 was >> used to do that operation but the datasheet for 50610M from 2009 does >> not show b

Re: [PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
On 2/12/2021 4:56 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 12:57:19PM -0800, Florian Fainelli wrote: >> We have a number of unused flags defined today and since we are scarce >> on space and may need to introduce new flags in the future remove and >> shift eve

[PATCH net-next 2/3] net: phy: broadcom: Fix RXC/TXC auto disabling

2021-02-12 Thread Florian Fainelli
("tg3 / broadcom: Optionally disable TXC if no link") Signed-off-by: Florian Fainelli --- include/linux/brcmphy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index da7bf9dfef5b..3dd8203cf780 100644 --- a/inc

[PATCH net-next 1/3] net: phy: broadcom: Remove unused flags

2021-02-12 Thread Florian Fainelli
We have a number of unused flags defined today and since we are scarce on space and may need to introduce new flags in the future remove and shift every existing flag down into a contiguous assignment. No functional change. Signed-off-by: Florian Fainelli --- include/linux/brcmphy.h | 22

[PATCH net-next 3/3] net: phy: broadcom: Allow BCM54210E to configure APD

2021-02-12 Thread Florian Fainelli
BCM54210E/BCM50212E has been verified to work correctly with the auto-power down configuration done by bcm54xx_adjust_rxrefclk(), add it to the list of PHYs working. Signed-off-by: Florian Fainelli --- drivers/net/phy/broadcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

[PATCH net-next 0/3] net: phy: broadcom: APD improvements

2021-02-12 Thread Florian Fainelli
This patch series cleans up the brcmphy.h header and its numerous unused phydev->dev_flags, fixes the RXC/TXC clock disabling bit and allows the BCM54210E PHY to utilize APD. Thanks! Florian Fainelli (3): net: phy: broadcom: Remove unused flags net: phy: broadcom: Fix RXC/TXC auto disabl

Re: [PATCH v3 2/2] serial: 8250: Add new 8250-core based Broadcom STB driver

2021-02-12 Thread Florian Fainelli
On 2/12/2021 11:57 AM, Al Cooper wrote: > Add a UART driver for the new Broadcom 8250 based STB UART. The new > UART is backward compatible with the standard 8250, but has some > additional features. The new features include a high accuracy baud > rate clock system and DMA support. > > The driv

Re: [PATCH 5.10 00/54] 5.10.16-rc1 review

2021-02-12 Thread Florian Fainelli
gt; or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.10.y > and the diffstat can be found below. > > thanks, > > greg k-h Tested-by: Florian Fainelli On ARCH_BRCMSTB, 32-bit and 64-bit ARM, thanks! -- Florian

[PATCH] Revert "ARM: dts: bcm2711: Add the BSC interrupt controller"

2021-02-12 Thread Florian Fainelli
IRQ handler which is an interrupt flow and another driver like i2c-bcm2835 which uses an interrupt handler (although it specifies IRQF_SHARED). Simply revert this change for now which will mean that HDMI I2C will be polled, like it was before. Reported-by: Dave Stevenson Signed-off-by: Florian

Re: [PATCH 5.4 00/24] 5.4.98-rc1 review

2021-02-12 Thread Florian Fainelli
gt; or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.4.y > and the diffstat can be found below. On ARCH_BRCMSTB, 32-bit ARM and 64-bit ARM: Tested-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 06/10] net: dsa: act as passthrough for bridge port flags

2021-02-12 Thread Florian Fainelli
NOWN of > PORT_CTL0, which has the exact same bit index. I have left the > implementations separate though, for the only reason that the names are > different enough to confuse me, since I am not able to double-check with > a user manual. The multicast flooding setting for 6185 is in a different > register than for 6352 though. > > Signed-off-by: Vladimir Oltean > --- Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 07/10] net: dsa: felix: restore multicast flood to CPU when NPI tagger reinitializes

2021-02-12 Thread Florian Fainelli
rom the default > ocelot tagger towards ocelot-8021q and then again towards ocelot, > multicast flooding towards the CPU port module will be disabled. > > Fixes: e21268efbe26 ("net: dsa: felix: perform switch setup for tag_8021q") > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Florian Fainelli
they are forced to reject it during > the deferred BRIDGE_FLAGS attribute, where the rejection is currently > ignored. > > This patch also changes drivers to make use of the "mask" field for edge > detection when possible. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Florian Fainelli
layer higher than in > switchdev, which also allows us to silently ignore the offloading of > flags if that is ever needed in the future. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli I suppose the slight "loss" of information on which port failed the operation

Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Florian Fainelli
e would be no attempt to revert the partial state in > any way. Arguably, if the user changes more than one flag through the > same netlink command, this one _should_ be all or nothing, which means > it should be passed through switchdev as all or nothing. > > Signed-off-by: Vladimir

Re: [PATCH v4 net-next 1/9] net: switchdev: propagate extack to port attributes

2021-02-11 Thread Florian Fainelli
o Schimmel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES

2021-02-11 Thread Florian Fainelli
On 2/11/21 8:09 AM, Tong Zhang wrote: > FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are > not auto selected. > > ERROR: modpost: "__mdiobus_register" > [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! > ERROR: modpost: "mdiobus_unregister" > [drivers/n

Re: [PATCH v3 net-next 10/11] net: mscc: ocelot: offload bridge port flags to device

2021-02-10 Thread Florian Fainelli
earning > in ocelot_init_port. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Alexandre Belloni Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 09/11] net: mscc: ocelot: use separate flooding PGID for broadcast

2021-02-10 Thread Florian Fainelli
of > broadcast packets, to allow configuring it individually. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 06/11] net: dsa: kill .port_egress_floods overengineering

2021-02-10 Thread Florian Fainelli
_mrouter is created. > > Functionally speaking, we simply move the calls to .port_egress_floods > one step lower, in the two drivers that implement it: mv88e6xxx and b53, > so things should work just as before. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 04/11] net: dsa: configure proper brport flags when ports leave the bridge

2021-02-10 Thread Florian Fainelli
neric .port_bridge_flags. > > Previous attempts to code up this logic have been in the common bridge > layer, but as pointed out by Ido Schimmel, there are corner cases that > are missed when doing that: > https://patchwork.kernel.org/project/netdevbpf/patch/20210209151936.97382-5-olte...@gmail.com/ > > So, at least for now, let's leave DSA in charge of setting port flags > before and after the bridge join and leave. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 01/11] net: switchdev: propagate extack to port attributes

2021-02-10 Thread Florian Fainelli
o Schimmel Reviewed-by: Florian Fainelli -- Florian

Re: bcm2711_thermal: Kernel panic - not syncing: Asynchronous SError Interrupt

2021-02-10 Thread Florian Fainelli
On 2/10/2021 8:55 AM, Nicolas Saenz Julienne wrote: > Hi Robin, > > On Wed, 2021-02-10 at 16:25 +, Robin Murphy wrote: >> On 2021-02-10 13:15, Nicolas Saenz Julienne wrote: >>> [ Add Robin, Catalin and Florian in case they want to chime in ] >>> >>> Hi Juerg, thanks for the report! >>> >>>

Re: [PATCH v2 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2021-02-10 Thread Florian Fainelli
On 2/10/21 7:49 AM, Dave Stevenson wrote: > Hi Marc. > > On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote: >> >> Hi Maxime, >> >> On 2021-02-10 14:40, Maxime Ripard wrote: >>> Hi Dave, >>> >>> On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote: On Mon, 11 Jan 2021 at 14:23, Maxim

Re: [PATCH net-next] net: phy: introduce phydev->port

2021-02-10 Thread Florian Fainelli
On 2/10/21 3:20 AM, Michael Walle wrote: > > Am 2021-02-09 17:38, schrieb Michael Walle: >> --- a/drivers/net/phy/phy.c >> +++ b/drivers/net/phy/phy.c >> @@ -308,7 +308,7 @@ void phy_ethtool_ksettings_get(struct phy_device >> *phydev, >> if (phydev->interface == PHY_INTERFACE_MODE_MOCA) >>   

Re: [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name

2021-02-10 Thread Florian Fainelli
On 2/10/21 9:28 AM, Serge Semin wrote: > As the subject states this series is an attempt to harmonize the xHCI, > EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the > framework of the patchset [1]. > > Firstly as Krzysztof suggested we've deprecated a support of DWC USB3 > contr

Re: [PATCH net-next] net: phy: introduce phydev->port

2021-02-09 Thread Florian Fainelli
orting PORT_MII to either PORT_TP or PORT_FIBRE; > except for the genphy fallback driver. > > Suggested-by: Andrew Lunn > Signed-off-by: Michael Walle Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 07/11] net: dsa: kill .port_egress_floods overengineering

2021-02-09 Thread Florian Fainelli
On 2/9/21 12:37 PM, Vladimir Oltean wrote: > On Tue, Feb 09, 2021 at 05:19:32PM +0200, Vladimir Oltean wrote: >> From: Vladimir Oltean >> >> The bridge offloads the port flags through a single bit mask using >> switchdev, which among others, contains learning and flooding settings. >> >> The commi

[PATCH stable 4.9] mm: memcontrol: fix NULL pointer crash in test_clear_page_writeback()

2021-02-09 Thread Florian Fainelli
: Michal Hocko Cc: [4.6+] Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [gup...@codeaurora.org: Resolved merge conflicts] Signed-off-by: Prakash Gupta Signed-off-by: Florian Fainelli --- This patch is present in a downstream Android tree: https://source.mcwhirter.io/craige/bluec

[PATCH v2] Documentation/admin-guide: kernel-parameters: Update nohlt section

2021-02-09 Thread Florian Fainelli
;/"nohlt" parameters. Acked-by: Randy Dunlap Signed-off-by: Florian Fainelli --- Changes in v2: - used ';' after requires CONFIG_GENERIC_IDLE_POLL_SETUP (Randy) Documentation/admin-guide/kernel-parameters.txt | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff

[PATCH] Documentation/admin-guide: kernel-parameters: Update nohlt section

2021-02-08 Thread Florian Fainelli
;/"nohlt" parameters. Signed-off-by: Florian Fainelli --- Documentation/admin-guide/kernel-parameters.txt | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a10

Re: [PATCH] net: phy: broadcom: remove BCM5482 1000BX support

2021-02-08 Thread Florian Fainelli
On 2/8/21 1:35 PM, Michael Walle wrote: > It is nowhere used in the kernel. It also seems to be lacking the > proper fiber advertise flags. Remove it. > > Signed-off-by: Michael Walle Acked-by: Florian Fainelli -- Florian

Re: [PATCH] MAINTAINERS: rectify BROADCOM PMB (POWER MANAGEMENT BUS) DRIVER

2021-02-08 Thread Florian Fainelli
On 2/7/21 11:16 PM, Lukas Bulwahn wrote: > Commit 8bcac4011ebe ("soc: bcm: add PM driver for Broadcom's PMB") includes > a new MAINTAINERS section BROADCOM PMB (POWER MANAGEMENT BUS) DRIVER with > 'drivers/soc/bcm/bcm-pmb.c', but the file was actually added at > 'drivers/soc/bcm/bcm63xx/bcm-pmb.c'.

Re: [PATCH 5.4 00/65] 5.4.97-rc1 review

2021-02-08 Thread Florian Fainelli
t tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.4.y > and the diffstat can be found below. Tested-by: Florian Fainelli On ARCH_BRCMSTB using 32-bit ARM and 64-bit ARM kernels, no regressions observed, thanks! -- Florian

Re: [PATCH 4.9 00/43] 4.9.257-rc1 review

2021-02-08 Thread Florian Fainelli
t tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. Tested-by: Florian Fainelli On ARCH_BRCMSTB using 32-bit ARM and 64-bit ARM kernels, no regressions observed, thanks! -- Florian

Re: [PATCH 5.4 00/32] 5.4.96-rc1 review

2021-02-05 Thread Florian Fainelli
t tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-5.4.y > and the diffstat can be found below. > > thanks, > > greg k-h Tested-by: Florian Fainelli On ARCH_BRCMSTB with both ARM 32-bit and ARM 64-bit configurations, no regressions observed. -- Florian

Re: [RFC/PATCH 05/11] soc: bcm: bcm2835-power: Add support for BCM2711's ARSAN ASB

2021-02-05 Thread Florian Fainelli
On 2/5/21 5:52 AM, Nicolas Saenz Julienne wrote: > In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present > with the ISP and H264 bits, and V3D is in the same place in the new ASB > as the old one. > > Use the fact that 'pm->arsan_asb' is populated as a hint that we're on > BCM27

Re: [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE

2021-02-03 Thread Florian Fainelli
On 1/27/21 3:09 AM, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > FTRACE's function tracer currently doesn't always work on ARM with > MODULE_PLT option enabled. If the module is loaded too far, FTRACE's > code modifier cannot cope with introduced veneers and turns the > function tra

Re: [PATCH] MIPS: of: Introduce helper function to get DTB

2021-02-03 Thread Florian Fainelli
.c | 7 +++--- ^-- Acked-by: Florian Fainelli -- Florian

Re: [PATCH 04/21] rtc: brcmstb-waketimer: quiet maybe-unused variable warning

2021-02-02 Thread Florian Fainelli
On 2/2/21 3:22 AM, Alexandre Belloni wrote: > When CONFIG_OF is disabled then the matching table is not referenced. > > Signed-off-by: Alexandre Belloni Acked-by: Florian Fainelli -- Florian

Re: [PATCH 04/21] rtc: brcmstb-waketimer: quiet maybe-unused variable warning

2021-02-02 Thread Florian Fainelli
On 2/2/21 3:22 AM, Alexandre Belloni wrote: > When CONFIG_OF is disabled then the matching table is not referenced. > > Signed-off-by: Alexandre Belloni Acked-by: Florian Fainelli -- Florian smime.p7s Description: S/MIME Cryptographic Signature

Re: [GIT PULL 1/1] bcm2835-dt-next-2021-01-28

2021-02-01 Thread Florian Fainelli
On 1/28/21 6:50 AM, Nicolas Saenz Julienne wrote: > Hi Florian, > > The following changes since commit 5878b8087904a5827c3551698be83da1ccf84e11: > > ARM: dts: bcm2711: Add the BSC interrupt controller (2021-01-25 21:49:41 > +0100) > > are available in the Git repository at: > > https://git

[PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m

2021-01-30 Thread Florian Fainelli
: kernel test robot Signed-off-by: Florian Fainelli --- drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index e535f28a8028..c833ac08ea81 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig

[PATCH 1/2] powerpc/Kconfig: Fix unmet direct dependency on NET

2021-01-30 Thread Florian Fainelli
] Selected by [y]: - AKEBONO [=y] && PPC_47x [=y] WARNING: unmet direct dependencies detected for ETHERNET Depends on [n]: NETDEVICES [=y] && NET [=n] Selected by [y]: - AKEBONO [=y] && PPC_47x [=y] Reported-by: kernel test robot Signed-off-by: Florian Fainelli ---

[PATCH RESEND] ata: ahci_brcm: Add back regulators management

2021-01-29 Thread Florian Fainelli
to link up with attached hard drives. Fixes: c0cdf2ac4b5b ("ata: ahci_brcm: Fix AHCI resources management") Signed-off-by: Florian Fainelli --- drivers/ata/ahci_brcm.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/ata/ahci_brcm.c b/d

Re: [PATCH net-next 0/8] net: dsa: microchip: DSA driver support for LAN937x switch

2021-01-28 Thread Florian Fainelli
On 1/27/2021 10:41 PM, Prasanna Vengateshan wrote: > LAN937x is a Multi-Port 100BASE-T1 Ethernet Physical Layer switch > compliant with the IEEE 802.3bw-2015 specification. The device > provides 100 Mbit/s transmit and receive capability over a single > Unshielded Twisted Pair (UTP) cable. LAN

Re: [PATCH v7 1/2] ARM: PLT: Move struct plt_entries definition to header

2021-01-27 Thread Florian Fainelli
On 1/27/2021 3:09 AM, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > No functional change, later it will be re-used in several files. > > Signed-off-by: Alexander Sverdlin Tested-by: Florian Fainelli -- Florian

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Florian Fainelli
rays. Each entry contains 2 u16 values. > This change makes it easier to understand how the jam tables are used > and also makes it possible for a single function to handle all of them, > removing some duplicated code. > > Signed-off-by: Lorenzo Carletti Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH V2 1/1] net: dsa: rtl8366rb: standardize init jam tables

2021-01-27 Thread Florian Fainelli
On 1/27/2021 12:06 PM, Lorenzo Carletti wrote: > Many thanks for telling me that and for showing me how this works. > I find both very useful. > I'll be sure to follow the guidelines more carefully next time. One of those guidelines is no top-posting and make sure you use a plaintext format for

Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support

2021-01-27 Thread Florian Fainelli
d_module) from [] (SyS_finit_module+0x59/0x84) > [] (SyS_finit_module) from [] (ret_fast_syscall+0x1/0x18) > ---[ end trace e1b64ced7a89adcd ]--- > ftrace failed to modify [] 0xe9ef7006 > actual: 02:f0:3b:fa > ftrace record flags: 0 > (0) expected tramp: c0314265 > > Signed-off-by: Alexander Sverdlin Tested-by: Florian Fainelli -- Florian

Re: [PATCH] soc: bcm: brcmstb: Remove soc_is_brcmstb()

2021-01-27 Thread Florian Fainelli
On Wed, 20 Jan 2021 11:34:07 -0800, Florian Fainelli wrote: > We have no in tree or out of tree users of this function, remove it and > the header providing its prototype. > > Signed-off-by: Florian Fainelli > --- Applied to drivers/next, thanks! -- Florian

Re: [GIT PULL 3/4] bcm2835-defconfig-arm64-next-2021-01-25

2021-01-26 Thread Florian Fainelli
On 1/25/2021 1:01 PM, Nicolas Saenz Julienne wrote: > Hi Florian, > > The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: > > Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH v6 0/2] ARM: Implement MODULE_PLT support in FTRACE

2021-01-26 Thread Florian Fainelli
Hi Alexander, On 2/17/2020 6:09 AM, Alexander X Sverdlin wrote: > From: Alexander Sverdlin > > FTRACE's function tracer currently doesn't always work on ARM with > MODULE_PLT option enabled. If the module is loaded too far, FTRACE's > code modifier cannot cope with introduced veneers and turns t

<    1   2   3   4   5   6   7   8   9   10   >