Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-23 Thread Florian Fainelli
On 12/23/2020 1:11 PM, Jakub Kicinski wrote: > On Wed, 23 Dec 2020 22:00:44 +0100 Andrew Lunn wrote: >> On Wed, Dec 23, 2020 at 12:32:18PM -0800, Jakub Kicinski wrote: >>> On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote:

Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt

2020-12-22 Thread Florian Fainelli
On 12/22/2020 6:56 AM, Jim Quinlan wrote: > The SMC/HVC SCMI transport is modified to allow the completion of an SCMI > message to be indicated by an interrupt rather than the return of the smc > call. This accommodates the existing behavior of the BrcmSTB SCMI > "platform" whose SW is already

Re: [PATCH v4 1/2] dt-bindings: arm: Add optional interrupt to smc/hvc SCMI transport

2020-12-22 Thread Florian Fainelli
a message. > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian

Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the probe function

2020-12-21 Thread Florian Fainelli
vs_prepare_uninit()' in order > to avoid code duplication. This also makes the code more readable (IMHO). > > Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for > Broadcom STB SoCs") > Signed-off-by: Christophe JAILLET Acked-by: Florian Fa

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-21 Thread Florian Fainelli
On 12/21/2020 2:25 PM, Vladimir Oltean wrote: > On Mon, Dec 21, 2020 at 01:49:03PM -0800, Florian Fainelli wrote: >> On 12/18/2020 1:17 PM, Florian Fainelli wrote: >>>>>>>>> SYSTEMPORT Lite does not actually validate the frame length, so >>>>

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-21 Thread Florian Fainelli
On 12/18/2020 1:17 PM, Florian Fainelli wrote: >>>>>>> SYSTEMPORT Lite does not actually validate the frame length, so setting >>>>>>> a maximum number to the buffer size we allocate could work, but I don't >>>>>>> see a reas

Re: [RFC PATCH v2 0/8] Adding the Sparx5 Switch Driver

2020-12-20 Thread Florian Fainelli
On 12/16/2020 11:51 PM, Steen Hegelund wrote: > This series provides the Microchip Sparx5 Switch Driver > > The Sparx5 Carrier Ethernet and Industrial switch family delivers 64 > Ethernet ports and up to 200 Gbps of switching bandwidth. > > It provides a rich set of Ethernet switching features

Re: [RFC PATCH v2 1/8] dt-bindings: net: sparx5: Add sparx5-switch bindings

2020-12-20 Thread Florian Fainelli
On 12/16/2020 11:51 PM, Steen Hegelund wrote: > Document the Sparx5 switch device driver bindings > > Signed-off-by: Steen Hegelund > Signed-off-by: Lars Povlsen > --- [snip] > + max-speed: > +maxItems: 1 > +description: Bandwidth allocated to this port > +

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 1:14 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 01:08:58PM -0800, Florian Fainelli wrote: >> On 12/18/20 1:02 PM, Vladimir Oltean wrote: >>> On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: >>>> On 12/18/20 12:52 PM, Vladimir O

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 1:02 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: >> On 12/18/20 12:52 PM, Vladimir Oltean wrote: >>> On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote: >>>> On 12/18/20 12:24 PM, Vladimir

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 12:52 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 12:30:20PM -0800, Florian Fainelli wrote: >> On 12/18/20 12:24 PM, Vladimir Oltean wrote: >>> Hi Florian, >>> >>> On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote: >>&

Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 12:24 PM, Vladimir Oltean wrote: > Hi Florian, > > On Fri, Dec 18, 2020 at 09:38:43AM -0800, Florian Fainelli wrote: >> The driver is already allocating receive buffers of 2KiB and the >> Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE. >

[PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
The driver is already allocating receive buffers of 2KiB and the Ethernet MAC is configured to accept frames up to UMAC_MAX_MTU_SIZE. Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 1

Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.

2020-12-18 Thread Florian Fainelli
ady set > the enable bit to zero by appling inverted RNG_RBGEN_MASK. > > Signed-off-by: Matthias Brugger Acked-by: Florian Fainelli -- Florian

Re: [PATCH] dt-bindings: Fix JSON pointers

2020-12-18 Thread Florian Fainelli
vicetree/bindings/ -name "*.yaml"` > > Cc: Maxime Ripard > Cc: Vinod Koul > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Pavel Machek > Cc: "David S. Miller&qu

Re: [PATCH v3 6/6] ARM: dts: Add dts for RPi4b + Cirrus Logic Lochnagar2 + CS47L15

2020-12-17 Thread Florian Fainelli
On 12/17/20 7:41 AM, 'Richard Fitzgerald' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > This adds a devicetree configuration for Raspberry Pi 4b connected to > Cirrus Logic Lochnagar 2 audio development board and CS47L15 codec. > > The common (codec-independent) Lochnagar 2 configuration is separated

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-16 Thread Florian Fainelli
On 12/16/20 4:57 PM, Sven Van Asbroeck wrote: > Hi Andrew, > > On Wed, Dec 9, 2020 at 9:10 AM Andrew Lunn wrote: >> >> 9K is not a nice number, since for each allocation it probably has to >> find 4 contiguous pages. See what the performance difference is with >> 2K, 4K and 8K. If there is a big

Re: [RESEND PATCH v3 2/2] PCI: brcmstb: use reset/rearm instead of deassert/assert

2020-12-16 Thread Florian Fainelli
l calls in suspend/resume functions. > > Signed-off-by: Jim Quinlan This should probably deserve a Fixes tag as well: Fixes: 740d6c3708a9 ("PCI: brcmstb: Add control of rescal reset") Acked-by: Florian Fainelli Thanks! -- Florian

Re: [RESEND PATCH v3 1/2] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-12-16 Thread Florian Fainelli
y: Jim Quinlan Thanks a lot for fixing this Jim, given the reset lines are still mutually exclusive the single variable along with the 7216 versus another chip differentiation would still work, but I have no objection to the approach you have taken: Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Florian Fainelli
rns NETDEV_TX_OK when it frees a packet. >> >> Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") >> Suggested-by: Jakub Kicinski >> Signed-off-by: Vincent Stehlé >> Cc: David S. Miller >> Cc: Florian Fainelli > > Let me

Re: [PATCH 1/3] dt-bindings: phy: brcm,brcmstb-usb-phy: convert to the json-schema

2020-12-16 Thread Florian Fainelli
On 12/16/20 5:14 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Changes that require mentioning: > 1. interrupt-names >Name "wakeup" was changed to the "wake". It matches example and what >Linux driver looks for in the first place > 2. brcm,ipp and brcm,ioc >Both were described as

Re: [PATCH 2/3] dt-bindings: phy: brcm,brcmstb-usb-phy: add BCM4908 binding

2020-12-16 Thread Florian Fainelli
On 12/16/20 5:14 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > BCM4908 uses the same PHY and may require just slightly different > programming. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [PATCH 2/2] phy: phy-brcm-usb: specify init function format at struct level

2020-12-16 Thread Florian Fainelli
On 12/16/20 6:33 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > This is slightly cleaner solution that assures noone assings a wrong > function to the pointer. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [PATCH 3/3] phy: phy-brcm-usb: support BCM4908 binding

2020-12-16 Thread Florian Fainelli
On 12/16/20 5:14 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > BCM4908 seems to have slightly different registers but work when > programmed just like the STB one. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [PATCH 1/2] phy: phy-brcm-usb: improve getting OF matching data

2020-12-16 Thread Florian Fainelli
On 12/16/20 6:33 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > 1. Use of_device_get_match_data() helper to simplify the code > 2. Check for NULL as a good practice > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor

2020-12-15 Thread Florian Fainelli
On 12/15/2020 10:56 AM, Dmitry Osipenko wrote: > 15.12.2020 21:22, Florian Fainelli пишет: >> >> >> On 12/15/2020 8:53 AM, Dmitry Osipenko wrote: >>> 15.12.2020 19:40, Florian Fainelli пишет: >>>> >>>> >>>> On 12/15/2020 8:17 A

Re: [PATCH V2 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-15 Thread Florian Fainelli
On 12/14/2020 10:07 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > PMB originally comes from BCM63138 but can be also found on many other > chipsets (e.g. BCM4908). It's needed to power on and off SoC blocks like > PCIe, SATA, USB. > > Signed-off-by: Rafał Miłecki >From a driver perspec

Re: [PATCH V2 1/2] dt-bindings: power: document Broadcom's PMB binding

2020-12-15 Thread Florian Fainelli
On 12/14/2020 10:07 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Broadcom's PMB is power controller used for disabling and enabling SoC > devices. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor

2020-12-15 Thread Florian Fainelli
On 12/15/2020 8:53 AM, Dmitry Osipenko wrote: > 15.12.2020 19:40, Florian Fainelli пишет: >> >> >> On 12/15/2020 8:17 AM, Dmitry Osipenko wrote: >>> 15.12.2020 19:04, Florian Fainelli пишет: >>>> >>>> >>>> On 12/15/2020 5:52 AM,

Re: [PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor

2020-12-15 Thread Florian Fainelli
On 12/15/2020 8:17 AM, Dmitry Osipenko wrote: > 15.12.2020 19:04, Florian Fainelli пишет: >> >> >> On 12/15/2020 5:52 AM, Dmitry Osipenko wrote: >>> The tegra_uart_config of the DEBUG_LL code is now placed right at the >>> start of the .text section aft

Re: [PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor

2020-12-15 Thread Florian Fainelli
On 12/15/2020 5:52 AM, Dmitry Osipenko wrote: > The tegra_uart_config of the DEBUG_LL code is now placed right at the > start of the .text section after commit which enabled debug output in the > decompressor. Tegra devices are not booting anymore if DEBUG_LL is enabled > since tegra_uart_config

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-12-15 Thread Florian Fainelli
On 12/15/2020 5:19 AM, Bharat Gooty wrote: > Since the IOMMU is disabled and DMA engine is on 32-bit bus, We can not > give the complete DDR for the USB DMA. > So restricting the usable DAM size to 4GB. Thanks, can you make this a proper patch submission along with a Fixes: tag that is: Fixes:

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-12-15 Thread Florian Fainelli
On 12/14/2020 11:46 AM, Arnd Bergmann wrote: > On Mon, Dec 14, 2020 at 8:09 PM Ray Jui wrote: >> On 11/28/2020 1:58 AM, Arnd Bergmann wrote: >>> On Sat, Nov 28, 2020 at 5:53 AM Florian Fainelli >>> wrote: >>>> >>>> On Fri, 16 Oct 2020 17:08

Re: [PATCH 2/2] hwrng: iproc-rng200: Move enable/disable in separate function

2020-12-14 Thread Florian Fainelli
Since you are refactoring this into a new function, do you mind changing the variable to u32 to match the kernel code? With that fixed: Acked-by: Florian Fainelli Thanks! -- Florian

Re: [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block.

2020-12-14 Thread Florian Fainelli
; Fixes: c83d45d5685f ("hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver") > Signed-off-by: Matthias Brugger Acked-by: Florian Fainelli -- Florian

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-14 Thread Florian Fainelli
On 12/14/20 4:24 AM, Rafał Miłecki wrote: > On 11.12.2020 23:08, Florian Fainelli wrote: >> On 12/11/20 1:59 PM, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). >>> It's nee

Re: [PATCH v2 net-next 6/6] net: dsa: ocelot: request DSA to fix up lack of address learning on CPU port

2020-12-12 Thread Florian Fainelli
> > This patch addresses the issue by monitoring the addresses learnt by the > software bridge on eno0, and adding/deleting them as static FDB entries > on the CPU port accordingly. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 5/6] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-12-12 Thread Florian Fainelli
ridges spanning a DSA switch's ports, and both of them need to service > the same MAC address, then what will happen is that the migration of one > of those stations will trigger the deletion of the FDB entry from the > CPU port while it is still used by other bridge. That could be imp

Re: [PATCH v2 net-next 2/6] net: dsa: don't use switchdev_notifier_fdb_info in dsa_switchdev_event_work

2020-12-12 Thread Florian Fainelli
g done if added_by_user was false. Let's check for > that a lot earlier, and don't actually bother to schedule the worker > for nothing. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 3/6] net: dsa: move switchdev event implementation under the same switch/case statement

2020-12-12 Thread Florian Fainelli
vement also avoids a useless allocation / free of switchdev_work > on the untreated "default event" case. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 net-next 4/6] net: dsa: exit early in dsa_slave_switchdev_event if we can't program the FDB

2020-12-12 Thread Florian Fainelli
t; remain just in the software bridge. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] net: bcmgenet: Fix a resource leak in an error handling path in the probe functin

2020-12-12 Thread Florian Fainelli
On 12/12/2020 10:20 AM, Christophe JAILLET wrote: > If the 'register_netdev()' call fails, we must undo a previous > 'bcmgenet_mii_init()' call. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")> Signed-off-by: > Christophe JA

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Florian Fainelli
On 12/11/2020 1:59 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). > It's needed to power on and off SoC blocks like PCIe, SATA, USB. > > Signed-off-by: Rafał Miłecki This looks good to me, just a few nipicks below. [s

Re: [PATCH 2/2] soc: bcm: add PM driver for Broadcom's PMB

2020-12-11 Thread Florian Fainelli
On 12/11/20 1:59 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > PMB can be found on BCM4908 and many other chipsets (e.g. BCM63138). > It's needed to power on and off SoC blocks like PCIe, SATA, USB. > > Signed-off-by: Rafał Miłecki I will do a more thorough review tonight, however do you

Re: [PATCH v6 08/11] input: raspberrypi-ts: Release firmware handle when not needed

2020-12-11 Thread Florian Fainelli
On 12/11/20 8:47 AM, Nicolas Saenz Julienne wrote: > There is no use for the firmware interface after getting the touch > buffer address, so release it. > > Signed-off-by: Nicolas Saenz Julienne > Acked-by: Dmitry Torokhov Reviewed-by: Florian Fainelli -- Florian smime.p7s

Re: [PATCH] net/netconsole: Support VLAN for netconsole

2020-12-10 Thread Florian Fainelli
On 12/10/2020 2:07 AM, Libing Zhou wrote: > During kernel startup phase, current netconsole doesn’t support VLAN > since there is no VLAN interface setup already. > > This patch provides VLAN ID and PCP as optional boot/module parameters > to support VLAN environment, thus kernel startup log ca

Re: [PATCH 15/15] ARM: dts: bcm2711: Add the CEC interrupt controller

2020-12-10 Thread Florian Fainelli
axime Ripard Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 14/15] ARM: dts: bcm2711: Add the BSC interrupt controller

2020-12-10 Thread Florian Fainelli
On 12/10/2020 5:46 AM, Maxime Ripard wrote: > The BSC controllers used for the HDMI DDC have an interrupt controller > shared between both instances. Let's add it to avoid polling. > > Signed-off-by: Maxime Ripard Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms

2020-12-10 Thread Florian Fainelli
On 12/10/2020 5:46 AM, Maxime Ripard wrote: > The BCM2711 uses a number of instances of the bcmstb-l2 controller in its > display engine. Let's allow the driver to be enabled through KConfig. > > Signed-off-by: Maxime Ripard Acked-by: Florian Fainelli -- Florian

Re: [PATCH -next] thermal: broadcom: simplify the return expression of bcm2711_thermal_probe()

2020-12-10 Thread Florian Fainelli
On 12/10/2020 5:54 AM, Zheng Yongjun wrote: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding

2020-12-09 Thread Florian Fainelli
On 12/9/20 3:35 PM, Rob Herring wrote: > On Fri, Dec 04, 2020 at 05:39:14PM +0100, Rafał Miłecki wrote: >> On 04.12.2020 17:32, Florian Fainelli wrote: >>> On 12/4/2020 1:37 AM, Rafał Miłecki wrote: >>>> From: Rafał Miłecki >>>> >>>> Docu

Re: [PATCH net-next] net: dsa: simplify the return rtl8366_vlan_prepare()

2020-12-09 Thread Florian Fainelli
On 12/9/20 1:26 AM, Zheng Yongjun wrote: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 3/8] net: macb: add function to disable all macb clocks

2020-12-08 Thread Florian Fainelli
On 12/7/20 4:15 AM, Claudiu Beznea wrote: > Add function to disable all macb clocks. > > Signed-off-by: Claudiu Beznea > Suggested-by: Andrew Lunn > --- > drivers/net/ethernet/cadence/macb_main.c | 62 > > 1 file changed, 32 insertions(+), 30 deletions(-) > >

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-08 Thread Florian Fainelli
On 12/8/20 3:02 PM, Sven Van Asbroeck wrote: > Hi Andrew, > > On Tue, Dec 8, 2020 at 5:51 PM Andrew Lunn wrote: >> >>> >>> So I assumed that it's a PCIe dma bandwidth issue, but I could be wrong - >>> I didn't do any PCIe bandwidth measurements. >> >> Sometimes it is actually cache operations whi

Re: [PATCH v4 net-next 1/2] net: dsa: add optional stats64 support

2020-12-04 Thread Florian Fainelli
On 12/4/2020 6:56 AM, Oleksij Rempel wrote: > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel > Reviewed-by: Vladimir Oltean Andrew and myself ave you R-b-y for this change already can you carry it forward? -- Florian

[PATCH v2] dt-bindings: phy: Convert Broadcom SATA PHY to YAML

2020-12-04 Thread Florian Fainelli
Update the Broadcom SATA PHY Device Tree binding to a YAML format. Suggested-by: Vinod Koul Signed-off-by: Florian Fainelli --- Changes in v2: - fixed #phy-cells warning - fixed yamlling warnings .../bindings/phy/brcm,sata-phy.yaml | 148 ++ .../devicetree/bindings

Re: [PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller

2020-12-04 Thread Florian Fainelli
On 12/4/2020 1:37 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > This controller is responsible for OHCI, EHCI, XHCI and PHYs setup that > has to be handled in the proper order. > > One unusual thing about this controller is that is provides access to > the MDIO bus. There are two registe

Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 USB reset binding

2020-12-04 Thread Florian Fainelli
On 12/4/2020 1:37 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Document binding of block responsible for initializing USB controllers > (OHCI, EHCI, XHCI). > > Signed-off-by: Rafał Miłecki > --- > .../reset/brcm,bcm4908-usb-reset.yaml | 60 +++ > 1 file changed

Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports

2020-12-03 Thread Florian Fainelli
gt; Fixes: e66f840c08a23 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver") > Tested-by: Sven Van Asbroeck # ksz8795 > Signed-off-by: Sven Van Asbroeck Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 07/11] staging: vchiq: Release firmware handle on unbind

2020-12-02 Thread Florian Fainelli
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian smime.p7s De

Re: [PATCH v5 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind

2020-12-02 Thread Florian Fainelli
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 03/11] clk: bcm: rpi: Release firmware handle on unbind

2020-12-02 Thread Florian Fainelli
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 05/11] reset: raspberrypi: Release firmware handle on unbind

2020-12-02 Thread Florian Fainelli
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 04/11] gpio: raspberrypi-exp: Release firmware handle on unbind

2020-12-02 Thread Florian Fainelli
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne > Acked-by: Bartosz Golaszewski Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get()

2020-12-02 Thread Florian Fainelli
On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote: > It'll simplify the firmware handling for most consumers. > > Suggested-by: Bartosz Golaszewski > Signed-off-by: Nicolas Saenz Julienne Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v5 01/11] firmware: raspberrypi: Keep count of all consumers

2020-12-02 Thread Florian Fainelli
t - Get pointer to rpi_firmware structure. Is not removing this line going to create a kernel doc warning? With that fixed: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Florian Fainelli
On 12/2/2020 6:09 AM, Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 net-next 1/2] net: dsa: add optional stats64 support

2020-12-02 Thread Florian Fainelli
On 12/2/2020 6:09 AM, Oleksij Rempel wrote: > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel > Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 1/2] net: dsa: add optional stats64 support

2020-12-02 Thread Florian Fainelli
On 12/2/2020 4:07 AM, Oleksij Rempel wrote: > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 1/3] dt-bindings: net: fsl-fec add mdc/mdio bitbang option

2020-11-30 Thread Florian Fainelli
On 11/29/2020 3:04 PM, Andrew Lunn wrote: > On Sun, Nov 29, 2020 at 11:51:43PM +0100, Adrien Grassein wrote: >> Hi Andrew, >> >> Please find my answers below. >> >> Le dim. 29 nov. 2020 à 23:41, Andrew Lunn a écrit : >> >> On Sun, Nov 29, 2020 at 10:59:58PM +0100, Adrien Grassein wrote: >>

Re: [PATCH v2 2/6] PCI: brcmstb: Add control of EP voltage regulator(s)

2020-11-30 Thread Florian Fainelli
On 11/30/2020 1:11 PM, Jim Quinlan wrote: > Control of EP regulators by the RC is needed because of the chicken-and-egg > situation: although the regulator is "owned" by the EP and would be best > handled on its driver, the EP cannot be discovered and probed unless its > regulator is already tur

Re: [PATCH v2 3/6] PCI: brcmstb: Do not turn off regulators if EP can wake up

2020-11-30 Thread Florian Fainelli
On 11/30/2020 1:11 PM, Jim Quinlan wrote: > If any downstream device may wake up during S2/S3 suspend, we do not want > to turn off its power when suspending. > > Signed-off-by: Jim Quinlan Looks good to me, just one minor typo below: > +enum { > + TURN_OFF, /* Turn egulato

Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver

2020-11-30 Thread Florian Fainelli
t; so, prints out diagnostic info. > > Example output: > brcm-pcie 8b2.pcie: Error: Mem Acc: 32bit, Read, @0x3800 > brcm-pcie 8b2.pcie: Type: TO=0 Abt=0 UnspReq=1 AccDsble=0 BadAddr=0 > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 6/6] PCI: brcmstb: check return value of clk_prepare_enable()

2020-11-30 Thread Florian Fainelli
On 11/30/2020 1:11 PM, Jim Quinlan wrote: > The check was missing on PCIe resume. > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Fixes: 8195b7417018 ("PCI: brcmstb: Add suspend and resume pm_ops") -- Florian

Re: [PATCH v2 4/6] PCI: brcmstb: Give 7216 SOCs their own config type

2020-11-30 Thread Florian Fainelli
On 11/30/2020 1:11 PM, Jim Quinlan wrote: > This distinction is required for an imminent commit. > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian

Re: [PATCH 0/2] ARM/ARM64: Enable SCMI in default configurations

2020-11-28 Thread Florian Fainelli
On 11/9/2020 1:57 AM, Sudeep Holla wrote: > On Sun, Nov 08, 2020 at 08:42:26PM -0800, Florian Fainelli wrote: >> This patch series enables support for the ARM SCMI and the various >> drivers provided (cpufreq, clock, sensors, reset) since these are >> utilized by B

Re: [PATCH 2/2] reset: simple: add BCM4908 MISC PCIe reset controller support

2020-11-28 Thread Florian Fainelli
On 11/27/2020 3:14 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > It's a trivial reset controller. One register with bit per PCIe core. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-11-28 Thread Florian Fainelli
On Fri, 16 Oct 2020 17:08:32 +0800, Zhen Lei wrote: > The scripts/dtc/checks.c requires that the node have empty "dma-ranges" > property must have the same "#address-cells" and "#size-cells" values as > the parent node. Otherwise, the following warnings is reported: > > arch/arm64/boot/dts/broadc

Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's BCM4908 PCIe reset binding

2020-11-27 Thread Florian Fainelli
On 11/27/2020 3:14 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > BCM4908 was built using older PCIe hardware block that requires using > external reset block controlling PERST# signals. > > Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli -- Florian

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-27 Thread Florian Fainelli
On 11/27/2020 4:33 PM, Lukasz Majewski wrote: >> So why use DSA at all? What benefit does it bring you? Why not do the >> entire switch configuration from within FEC, or a separate driver very >> closely related to it? > > Mine rationale to use DSA and FEC: > - Make as little changes to FEC as

Re: [PATCH 01/25] soc: bcm: brcmstb: pm: pm-arm: Provide prototype for brcmstb_pm_s3_finish()

2020-11-27 Thread Florian Fainelli
On 11/26/2020 1:20 AM, Lee Jones wrote: > On Tue, 03 Nov 2020, Florian Fainelli wrote: > >> On Tue, 3 Nov 2020 15:28:14 +, Lee Jones wrote: >>> brcmstb_pm_s3_finish() cannot be made static because it is referenced >>> from brcmstb_pm_s3(), so let's

Re: [RFC 0/4] net: l2switch: Provide support for L2 switch on i.MX28 SoC

2020-11-25 Thread Florian Fainelli
On 11/25/2020 4:00 PM, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 12:24:55AM +0100, Lukasz Majewski wrote: >> This is the first attempt to add support for L2 switch available on some NXP >> devices - i.e. iMX287 or VF610. This patch set uses common FEC and DSA code. > > Interesting. I need to

Re: [PATCH] MIPS: No need to check CPU 0 in {loongson3,bmips,octeon}_cpu_disable()

2020-11-25 Thread Florian Fainelli
able(), > just remove them. > > Signed-off-by: Tiezhu Yang > --- > arch/mips/cavium-octeon/smp.c | 3 --- > arch/mips/kernel/smp-bmips.c | 3 --- For smp-bmips.c: Acked-by: Florian Fainelli -- Florian

[PATCH] dt-bindings: phy: Convert Broadcom SATA PHY to YAML

2020-11-21 Thread Florian Fainelli
Update the Broadcom SATA PHY Device Tree binding to a YAML format. Suggested-by: Vinod Koul Signed-off-by: Florian Fainelli --- This is based on phy/next and it depends on the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/commit/?h=next&am

Re: [GIT PULL 1/1] bcm2835-dt-next-2020-11-20

2020-11-20 Thread Florian Fainelli
On 11/20/2020 8:52 AM, Nicolas Saenz Julienne wrote: > Hi Florian, > > The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: > > Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/g

Re: [PATCH v2 00/10] Broadcom b53 YAML bindings

2020-11-20 Thread Florian Fainelli
On 11/11/2020 8:50 PM, Florian Fainelli wrote: > Hi, > > This patch series fixes the various Broadcom SoCs DTS files and the > existing YAML binding for missing properties before adding a proper b53 > switch YAML binding from Kurt. > > If this all looks good, given that

Re: [PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-20 Thread Florian Fainelli
r to the skb clone for TX > timestamping") Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RFC v2 5/5] net: stmmac: dwmac-meson8b: add support for the RGMII RX delay on G12A

2020-11-17 Thread Florian Fainelli
PRG_ETH1[19:16] register. > > Add support for validating the RGMII RX delay as well as configuring the > register accordingly on these platforms. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function

2020-11-17 Thread Florian Fainelli
ke it easier to read/understand even when adding > more logic in the future. > > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RFC v2 3/5] net: stmmac: dwmac-meson8b: use picoseconds for the RGMII RX delay

2020-11-17 Thread Florian Fainelli
lay-ns". > > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli Maybe also issue a warning when the 'amlogic,rx-delay-ns' property is found in addition to the 'amlogic,rgmii-rx-delay-ps'? Up to you how to manage existing DTBs being deployed. -- Florian

Re: [PATCH RFC v2 2/5] net: stmmac: dwmac-meson8b: fix enabling the timing-adjustment clock

2020-11-17 Thread Florian Fainelli
ndrew Lunn > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

2020-11-17 Thread Florian Fainelli
or "rgmii-id" the RX delay should be specified > - with "rgmii-id" or "rgmii-rxid" the RX delay is added by the PHY so > any configuration on the MAC side is ignored > - with "rmii" the RX delay is not applicable and any configuration is > ignored > > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-17 Thread Florian Fainelli
On 11/17/2020 5:45 AM, Andrew Lunn wrote: >>> Do you have the Marvell PHY driver either built-in or available as a >>> module? I suspect the problem is you don't. You will need the Marvell >>> PHY driver to correctly drive the PHY, you can't rely on the fallback >>> driver for SFPs. >> Correct.

[PATCH net v2] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Florian Fainelli
ed to that of the process configuring netpoll. Fixes: 04ff53f96a93 ("net: dsa: Add netconsole support") Tested-by: Vladimir Oltean Signed-off-by: Florian Fainelli --- Changes in v2: - added Vladimir's Tested-by tag - resubmit for the new patchwork to pick up the patch

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Florian Fainelli
On 11/16/20 4:12 PM, Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 04:04:49PM -0800, Jakub Kicinski wrote: >> On Tue, 17 Nov 2020 01:54:05 +0200 Vladimir Oltean wrote: >>> Yeah, I think Florian just wants netconsole to work in stable kernels, >>> which is a fair point. As for my 16-line patch th

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-16 Thread Florian Fainelli
On 11/16/20 3:27 PM, Vladimir Oltean wrote: > On Mon, Nov 16, 2020 at 03:13:47PM -0800, Jakub Kicinski wrote: >> On Tue, 17 Nov 2020 01:00:53 +0200 Vladimir Oltean wrote: >>> On Mon, Nov 16, 2020 at 02:35:44PM -0800, Jakub Kicinski wrote: On Tue, 17 Nov 2020 00:21:46 +0200 Vladimir Oltean wrot

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Florian Fainelli
On 11/16/20 3:06 PM, Florian Fainelli wrote: > On 10/20/20 6:12 PM, Jakub Kicinski wrote: >> On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote: >>> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote: >>>>> Completely crazy and outlandish id

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-11-16 Thread Florian Fainelli
On 10/20/20 6:12 PM, Jakub Kicinski wrote: > On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote: >> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote: >>>> Completely crazy and outlandish idea, I know, but what's wrong with >>>> doing

Re: [PATCH v2 0/2] phy: phy-brcm-sata: Allow configuration SATA AFE TX amplitude

2020-11-16 Thread Florian Fainelli
On 11/15/20 11:42 PM, Vinod Koul wrote: > On 22-10-20, 13:50, Florian Fainelli wrote: >> Hi Vinod, Kishon, >> >> This patch series allows the configuration of the Broadcom SATA PHY TX >> amplitude which may be required in order to meet specific tests. > > A

Re: [PATCH v2] net: lantiq: Wait for the GPHY firmware to be ready

2020-11-15 Thread Florian Fainelli
gt; Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Reviewed-by: Andrew Lunn > Signed-off-by: Martin Blumenstingl Reviewed-by: Florian Fainelli -- Florian

<    1   2   3   4   5   6   7   8   9   10   >