Re: [PATCH net] net: phy: smsc: add missed clk_disable_unprepare in smsc_phy_probe()

2020-11-14 Thread Florian Fainelli
On 11/14/2020 11:26 AM, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 19:23:59 +0800 Zhang Changzhong wrote: >> Add the missing clk_disable_unprepare() before return from >> smsc_phy_probe() in the error handling case. >> >> Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in

Re: [PATCH] phy: phy-bcm-ns-usb3: drop support for deprecated DT binding

2020-11-13 Thread Florian Fainelli
t; was updated to use MDIO layer. > > It should be really safe now to drop the old deprecated code. All Linux > stored DT files don't use it for 3,5 year. There is close to 0 chance > there is any bootloader with its own DTB using old the binding. > > Signed-off-by: Raf

Re: [PATCH] rtc: brcmstb-waketimer: Remove redundant null check before clk_disable_unprepare

2020-11-13 Thread Florian Fainelli
On 11/12/20 11:45 PM, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang Acked-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 3/3] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-11-12 Thread Florian Fainelli
On 11/9/2020 4:38 AM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 02:31:11PM +0200, Vladimir Oltean wrote: >> I need to sit on this for a while. How many DSA drivers do we have that >> don't do SA learning in hardware for CPU-injected packets? ocelot/felix >> and mv88e6xxx? Who else?

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-12 Thread Florian Fainelli
On 11/7/20 7:22 AM, Stefan Agner wrote: > Most architectures define MAX_PHYSMEM_BITS in asm/sparsemem.h and don't > include it in asm/pgtable.h. Include asm/sparsemem.h directly to get > the MAX_PHYSMEM_BITS define on all architectures. > > This fixes a crash when accessing zram on 32-bit ARM

Re: [PATCH 0/2] ARM/ARM64: Enable SCMI in default configurations

2020-11-12 Thread Florian Fainelli
On 11/9/20 1:57 AM, Sudeep Holla wrote: > On Sun, Nov 08, 2020 at 08:42:26PM -0800, Florian Fainelli wrote: >> This patch series enables support for the ARM SCMI and the various >> drivers provided (cpufreq, clock, sensors, reset) since these are >> utilized by Broadcom STB pl

[PATCH v2 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-11 Thread Florian Fainelli
'ethernet-ports' is a required property From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts | 3 --- arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts | 3 --- arch/arm/boot/dts

[PATCH v2 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name

2020-11-11 Thread Florian Fainelli
The register name should be "sgmii_config", not "sgmii", this is not a functional change since no code is currently looking for that register by name (or at all). Reviewed-by: Vladimir Oltean Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file

[PATCH v2 10/10] dt-bindings: net: dsa: b53: Add YAML bindings

2020-11-11 Thread Florian Fainelli
From: Kurt Kanzenbach Convert the b53 DSA device tree bindings to YAML in order to allow for automatic checking and such. Reviewed-by: Rob Herring Suggested-by: Florian Fainelli Signed-off-by: Kurt Kanzenbach --- .../devicetree/bindings/net/dsa/b53.txt | 149

[PATCH v2 09/10] ARM: dts: NSP: Provide defaults ports container node

2020-11-11 Thread Florian Fainelli
'ethernet-ports' is a required property From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi| 4 arch/arm/boot/dts/bcm958622hr.dts | 3 --- arch/arm/boot/dts/bcm958623hr.dts | 3 --- arch/arm

[PATCH v2 06/10] ARM: dts: NSP: Update ethernet switch node name

2020-11-11 Thread Florian Fainelli
'^(ethernet-)?switch(@.*)?$' From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Reviewed-by: Vladimir Oltean Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b

[PATCH v2 08/10] ARM: dts: NSP: Add a SRAB compatible string for each board

2020-11-11 Thread Florian Fainelli
/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm958522er.dts | 4 arch/arm/boot/dts/bcm958525er.dts | 4 arch/arm/boot/dts/bcm958525xmc.dts | 4 3 files changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/bcm958522er.dts b/arch/arm

[PATCH v2 03/10] ARM: dts: BCM5301X: Update Ethernet switch node name

2020-11-11 Thread Florian Fainelli
(@.*)?$' From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Reviewed-by: Vladimir Oltean Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm5301x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts

[PATCH v2 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node

2020-11-11 Thread Florian Fainelli
-by: Florian Fainelli --- arch/arm/boot/dts/bcm4709.dtsi | 4 arch/arm/boot/dts/bcm47094.dtsi | 4 arch/arm/boot/dts/bcm5301x.dtsi | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm4709.dtsi b/arch/arm/boot/dts/bcm4709.dtsi index e1bb8661955f

[PATCH v2 00/10] Broadcom b53 YAML bindings

2020-11-11 Thread Florian Fainelli
devices - updated strategy for NSP to tackle each board separately - provide both a ports {} container node and its #address-cells and #size-cells properties - renamed binding from b53.yaml to brcm,b53.yaml Florian Fainelli (9): dt-bindings: net: dsa: Extend switch nodes pattern dt-bindings

[PATCH v2 02/10] dt-bindings: net: dsa: Document sfp and managed properties

2020-11-11 Thread Florian Fainelli
The 'sfp' and 'managed' properties are commonly used to describe Ethernet switch ports connecting to SFP/SFF cages, describe these two properties as valid that we inherit from ethernet-controller.yaml. Acked-by: Rob Herring Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings

[PATCH v2 01/10] dt-bindings: net: dsa: Extend switch nodes pattern

2020-11-11 Thread Florian Fainelli
Upon discussion with Kurt, Rob and Vladimir it appears that we should be allowing ethernet-switch as a node name, update dsa.yaml accordingly. Reviewed-by: Vladimir Oltean Acked-by: Rob Herring Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 2 +- 1

Re: [RFC PATCH net-next 2/3] net: dsa: move switchdev event implementation under the same switch/case statement

2020-11-10 Thread Florian Fainelli
ent also avoids two useless allocation / free paths for > switchdev_work, which were difficult to avoid before, due to the code's > structure: > - on the untreated "default event" case. > - on the case where fdb_info->added_by_user is false. > > Signed-off-by: V

Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-10 Thread Florian Fainelli
On 11/10/2020 2:13 PM, Florian Fainelli wrote: > On 11/10/20 2:12 PM, Vladimir Oltean wrote: >> On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: >>> Provide an empty 'ports' container node with the correct #address-cells >>> and #size-cell

Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node

2020-11-10 Thread Florian Fainelli
On 11/10/20 2:48 PM, Vladimir Oltean wrote: > On Tue, Nov 10, 2020 at 02:40:43PM -0800, Florian Fainelli wrote: >> On 11/10/20 2:37 PM, Vladimir Oltean wrote: >>> On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote: >>>> Provide a default compatible stri

Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node

2020-11-10 Thread Florian Fainelli
On 11/10/20 2:37 PM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote: >> Provide a default compatible string which is based on the 58522 SRAB >> compatible, this allows us to have sane defaults and silences the >> following warnings:

Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-10 Thread Florian Fainelli
On 11/10/20 2:12 PM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: >> Provide an empty 'ports' container node with the correct #address-cells >> and #size-cells properties. This silences the following warning: >> >> arch/a

Re: [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node

2020-11-10 Thread Florian Fainelli
On 11/10/20 2:06 PM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 07:31:07PM -0800, Florian Fainelli wrote: >> Provide a default compatible string which is based on the 53010 SRAB >> compatible, this allows us to have sane defaults and silences the >> following warnings

Re: [PATCH v2 0/2] phy: phy-brcm-sata: Allow configuration SATA AFE TX amplitude

2020-11-10 Thread Florian Fainelli
On 10/22/20 1:50 PM, Florian Fainelli wrote: > Hi Vinod, Kishon, > > This patch series allows the configuration of the Broadcom SATA PHY TX > amplitude which may be required in order to meet specific tests. > > Thanks! > > Changes in v2: Vinod, Kishon, can this be

Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-10 Thread Florian Fainelli
On 11/10/2020 1:31 AM, Rafał Miłecki wrote: >  10.11.2020 04:31, Florian Fainelli wrote: >> Provide an empty 'ports' container node with the correct #address-cells >> and #size-cells properties. This silences the following warning: >> >> arch/arm/boot/dts/bc

Re: [PATCH 10/10] dt-bindings: net: dsa: b53: Add YAML bindings

2020-11-10 Thread Florian Fainelli
On 11/10/2020 5:21 AM, Kurt Kanzenbach wrote: > On Mon Nov 09 2020, Florian Fainelli wrote: >> From: Kurt Kanzenbach >> >> Convert the b53 DSA device tree bindings to YAML in order to allow >> for automatic checking and such. >> >> Suggested-by: F

[PATCH 02/10] dt-bindings: net: dsa: Document sfp and managed properties

2020-11-09 Thread Florian Fainelli
The 'sfp' and 'managed' properties are commonly used to describe Ethernet switch ports connecting to SFP/SFF cages, describe these two properties as valid that we inherit from ethernet-controller.yaml. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 4

[PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node

2020-11-09 Thread Florian Fainelli
,bcm58625-srab', 'brcm,bcm88312-srab'] 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm5301x.dtsi | 2 +- 1

[PATCH 06/10] ARM: dts: NSP: Update ethernet switch node name

2020-11-09 Thread Florian Fainelli
'^(ethernet-)?switch(@.*)?$' From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm

[PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node

2020-11-09 Thread Florian Fainelli
/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 09fd7e55c069..8453865d1439 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch

[PATCH 09/10] ARM: dts: NSP: Provide defaults ports container node

2020-11-09 Thread Florian Fainelli
'ethernet-ports' is a required property From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm

[PATCH 01/10] dt-bindings: net: dsa: Extend switch nodes pattern

2020-11-09 Thread Florian Fainelli
Upon discussion with Kurt, Rob and Vladimir it appears that we should be allowing ethernet-switch as a node name, update dsa.yaml accordingly. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name

2020-11-09 Thread Florian Fainelli
The register name should be "sgmii_config", not "sgmii", this is not a functional change since no code is currently looking for that register by name (or at all). Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-09 Thread Florian Fainelli
'ethernet-ports' is a required property From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm5301x.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts

[PATCH 00/10] Broadcom b53 YAML bindings

2020-11-09 Thread Florian Fainelli
through the upcoming Broadcom ARM SoC pull requests. Let me know if you would like those patches to be applied differently. Thanks! Florian Fainelli (9): dt-bindings: net: dsa: Extend switch nodes pattern dt-bindings: net: dsa: Document sfp and managed properties ARM: dts: BCM5301X: Update

[PATCH 03/10] ARM: dts: BCM5301X: Update Ethernet switch node name

2020-11-09 Thread Florian Fainelli
(@.*)?$' From schema: Documentation/devicetree/bindings/net/dsa/b53.yaml Signed-off-by: Florian Fainelli --- arch/arm/boot/dts/bcm5301x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi index ac3a99cf2079

[PATCH 10/10] dt-bindings: net: dsa: b53: Add YAML bindings

2020-11-09 Thread Florian Fainelli
From: Kurt Kanzenbach Convert the b53 DSA device tree bindings to YAML in order to allow for automatic checking and such. Suggested-by: Florian Fainelli Signed-off-by: Kurt Kanzenbach --- .../devicetree/bindings/net/dsa/b53.txt | 149 --- .../devicetree/bindings/net/dsa/b53

Re: [PATCH v2 02/13] ARM: dts: mmp2-olpc-xo-1-75: Delete #address-cells from ssp3

2020-11-09 Thread Florian Fainelli
On 7/18/2020 1:50 PM, Lubomir Rintel wrote: > On the XO-1.75, this node represents a bus interface that operates in slave > mode and thus is only able to accommodate a single subnode; no address > cells are necessary. > > The Documentation/devicetree/bindings/spi/spi-controller.yaml binding >

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-11-09 Thread Florian Fainelli
On 11/9/20 9:56 AM, Arnd Bergmann wrote: > On Mon, Nov 9, 2020 at 6:30 PM Florian Fainelli wrote: >> >> On 11/8/20 10:18 PM, Leizhen (ThunderTown) wrote: >>> Hi, everybody: >>> How do we deal with this problem? I updated the kernel to the latest an

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-11-09 Thread Florian Fainelli
On 11/8/20 10:18 PM, Leizhen (ThunderTown) wrote: > Hi, everybody: > How do we deal with this problem? I updated the kernel to the latest and > the problem still persists. > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j24 dtbs 2>err.txt > vim err.txt > >

Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl

2020-11-09 Thread Florian Fainelli
On Wed, 4 Nov 2020 15:29:52 -0500, Vivek Unune wrote: > Now that we have a pin controller, use that instead of manuplating the > mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux > > Signed-off-by: Vivek Unune > --- Applied to devicetree/next, thanks! -- Florian

Re: [PATCH v2 1/2] ARM: dts: BCM5301X: pinctrl - use correct driver and define mdio pins

2020-11-09 Thread Florian Fainelli
On 11/9/20 9:21 AM, Rafał Miłecki wrote: > On Wed, 4 Nov 2020 at 21:30, Vivek Unune wrote: >> BCM47094 version of pinmux uses different driver and supports mdio >> pinmux pins. Hence, use the correct driver and define the pins. >> >> Signed-off-by: Vivek Unune > > Subject and message are a bit

Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl

2020-11-09 Thread Florian Fainelli
On 11/9/2020 5:24 AM, Vivek Unune wrote: > On Wed, Nov 4, 2020 at 3:58 PM Vivek Unune wrote: >> >> On Wed, Nov 04, 2020 at 12:37:45PM -0800, Florian Fainelli wrote: >>> >>> >>> On 11/4/2020 12:29 PM, Vivek Unune wrote: >>>> Now that we

[PATCH 0/2] ARM/ARM64: Enable SCMI in default configurations

2020-11-08 Thread Florian Fainelli
to see those applied differently. Thanks! Florian Fainelli (2): ARM: multi_v7_defconfig: Enable ARM SCMI protocol and drivers arm64: defconfig: Enable ARM SCMI protocol and drivers arch/arm/configs/multi_v7_defconfig | 4 arch/arm64/configs/defconfig| 4 2 files changed, 8

[PATCH 2/2] arm64: defconfig: Enable ARM SCMI protocol and drivers

2020-11-08 Thread Florian Fainelli
Enable the ARM SCMI protocol and the common clock, cpufreq, reset and sensors drivers. Broadcom STB platforms (ARCH_BRCMSTB) implement SCMI to provide support for CPU frequency scaling, clock configuration and temperature and current sensors. Signed-off-by: Florian Fainelli --- arch/arm64

[PATCH 1/2] ARM: multi_v7_defconfig: Enable ARM SCMI protocol and drivers

2020-11-08 Thread Florian Fainelli
Enable the ARM SCMI protocol and the common clock, cpufreq and sensors drivers. Broadcom STB platforms (ARCH_BRCMSTB) implement SCMI to provide support for CPU frequency scaling, clock configuration and temperature and current sensors. Signed-off-by: Florian Fainelli --- arch/arm/configs

Re: [PATCH] PCI: brcmstb: Remove irq handler and data in one go

2020-11-08 Thread Florian Fainelli
On 11/8/2020 10:42 AM, Martin Kaiser wrote: > Replace the two separate calls for removing the irq handler and data with a > single irq_set_chained_handler_and_data() call. > > Signed-off-by: Martin Kaiser Acked-by: Florian Fainelli -- Florian

Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-07 Thread Florian Fainelli
On 11/7/2020 5:16 PM, Stefan Agner wrote: > On 2020-11-08 01:56, Andrew Morton wrote: >> On Sat, 7 Nov 2020 16:22:06 +0100 Stefan Agner wrote: >> >>> Most architectures define MAX_PHYSMEM_BITS in asm/sparsemem.h and don't >>> include it in asm/pgtable.h. Include asm/sparsemem.h directly to

Re: [PATCH] net/dsa: remove unused macros to tame gcc warning

2020-11-06 Thread Florian Fainelli
: warning: macro "BRCM_EG_RC_PROT_TERM" is not >> used [-Wunused-macros] >> net/dsa/tag_brcm.c:54:0: warning: macro "BRCM_EG_TC_SHIFT" is not used >> [-Wunused-macros] >> net/dsa/tag_brcm.c:52:0: warning: macro "BRCM_EG_RC_MAC_LEARN" is not

Re: [PATCH 2] Register read and writes tracing

2020-11-05 Thread Florian Fainelli
On 11/5/2020 6:56 PM, Prasad Sodagudi wrote: > This patch series adds register read/write event tracing > support. Qualcomm team tried upstreaming the register > trace buffer solution - [1] with pstore and dynamic debug > feature but that patch series didn't merge. I have followed > Steve

Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY

2020-11-04 Thread Florian Fainelli
On 11/3/2020 9:35 AM, Dan Murphy wrote: > Andrew > > On 11/3/20 11:18 AM, Andrew Lunn wrote: >> On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote: >>> Andrew >>> >>> On 10/30/20 3:15 PM, Andrew Lunn wrote: > +static int dp83td510_config_init(struct phy_device *phydev) > +{

Re: [PATCH net-next v3 1/4] ethtool: Add 10base-T1L link mode entries

2020-11-04 Thread Florian Fainelli
rent message level: 0x (0) > > Link detected: yes > > Signed-off-by: Dan Murphy Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl

2020-11-04 Thread Florian Fainelli
On 11/4/2020 12:29 PM, Vivek Unune wrote: > Now that we have a pin controller, use that instead of manuplating the > mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux I am a bit confused here as I thought the mux was intended to dynamically switch the pins in order to support

Re: [PATCH v2] ARM: dts: BCM5301X: Linksys EA9500 add fixed partitions

2020-11-03 Thread Florian Fainelli
On Sun, 1 Nov 2020 15:08:03 -0500, Vivek Unune wrote: > This router has dual paritions to store trx firmware image and > dual partitions for nvram. The second one in each of these cases acts > as a backup store. > > When tested with OpenWrt, the default partition parser causes two issues: > >

Re: [PATCH 13/23] mtd: nand: raw: brcmnand: brcmnand: Demote non-conformant kernel-doc headers

2020-11-03 Thread Florian Fainelli
cmnand_dma_run' > > Cc: Brian Norris > Cc: Kamal Dasu > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: linux-...@lists.infradead.org > Cc: bcm-kernel-feedback-l...@broadcom.com > Signed-off-by: Lee Jones Acked-by: Florian Fainelli -- Florian

Re: [PATCH v3 5/6] i2c: iproc: handle master read request

2020-11-03 Thread Florian Fainelli
On 11/2/2020 10:19 PM, Dhananjay Phadke wrote: > On Mon, 2 Nov 2020 09:24:32 +0530, Rayagonda Kokatanur wrote: > >> Handle single or multi byte master read request with or without >> repeated start. >> >> Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for >> slave mode")

Re: [PATCH 3/5] i2c: brcmstb: remove unnecessary CONFIG_PM_SLEEP

2020-11-03 Thread Florian Fainelli
On 10/29/2020 12:46 AM, Coiby Xu wrote: > SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu You need to annotate brcmstb_i2c_suspend and brcmstb_i2c_resume with __maybe_unused to avoid generating compiler warnings about unused functions with

Re: [PATCH 01/25] soc: bcm: brcmstb: pm: pm-arm: Provide prototype for brcmstb_pm_s3_finish()

2020-11-03 Thread Florian Fainelli
pm/pm-arm.c:395:14: warning: no previous prototype > for ‘brcmstb_pm_s3_finish’ [-Wmissing-prototypes] > > Cc: Florian Fainelli > Cc: bcm-kernel-feedback-l...@broadcom.com > Signed-off-by: Lee Jones > --- Applied to drivers/next, thanks! -- Florian

Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode

2020-11-02 Thread Florian Fainelli
On 11/2/2020 5:34 PM, Pavana Sharma wrote: >> How many times have i asked for you to add kerneldoc for this new >> value? How many times have you not done so? > > I have added kerneldoc comment for the new value added. > >> NACK. > >> If you don't understand a comment, please ask. > > Ok,

Re: [PATCH 1/2] ethernet: igb: Support PHY BCM5461S

2020-11-02 Thread Florian Fainelli
On 11/2/2020 3:13 PM, Paul Menzel wrote: > From: Jeffrey Townsend > > The BCM5461S PHY is used in switches. > > The patch is taken from Open Network Linux, and it was added there as > patch > > > packages/base/any/kernels/3.16+deb8/patches/driver-support-intel-igb-bcm5461X-phy.patch >

Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization

2020-11-02 Thread Florian Fainelli
'tmp' is now initialized properly. > > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller > driver") > Suggested-by: Rafał Miłecki > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian

Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword

2020-10-30 Thread Florian Fainelli
suggested. > > Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 > USB signals") Not sure if the Fixes: tag is entirely appropriate here, but sure, why not. > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Acked-by: Florian Fainelli -- Florian

Re: [PATCH 03/17] phy: broadcom: convert to devm_platform_ioremap_resource(_byname)

2020-10-29 Thread Florian Fainelli
On 10/28/2020 7:54 PM, Chunfeng Yun wrote: > Use devm_platform_ioremap_resource(_byname) to simplify code > > Cc: Al Cooper > Signed-off-by: Chunfeng Yun Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 5/5] net: mscc: ocelot: support L2 multicast entries

2020-10-28 Thread Florian Fainelli
me port > group (and therefore PGID), we need to reference-count the PGIDs. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli I believe you have the same gfp_t comment applicable here as in patch #4. -- Florian

Re: [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast

2020-10-28 Thread Florian Fainelli
o be GFP_ATOMIC per net/bridge/br_mdb.c::__br_mdb_notify, if this is a regular SWITCHDEV_OBJ_ID_MDB then GFP_KERNEL appears to be fine. Looks like this existed before, so that might have to be fixed separately. Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 2/5] net: mscc: ocelot: use ether_addr_copy

2020-10-28 Thread Florian Fainelli
On 10/28/2020 7:27 PM, Vladimir Oltean wrote: > Since a helper is available for copying Ethernet addresses, let's use it. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 3/5] net: mscc: ocelot: remove the "new" variable in ocelot_port_mdb_add

2020-10-28 Thread Florian Fainelli
On 10/28/2020 7:27 PM, Vladimir Oltean wrote: > It is Not Needed, a comment will suffice. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/5] net: mscc: ocelot: classify L2 mdb entries as LOCKED

2020-10-28 Thread Florian Fainelli
not subject to aging. For IPv6 multicast. > */ > > We don't want the permanent entries added with 'bridge mdb' to be > subject to aging. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH] RFC: net: phy: of phys probe/reset issue

2020-10-28 Thread Florian Fainelli
On 10/28/2020 12:32 PM, Grygorii Strashko wrote: > hi Andrew, > > On 23/10/2020 23:10, Andrew Lunn wrote: >>> Yes there is: have your Ethernet PHY compatible string be of the form >>> "ethernet." and then there is no need for such hacking. >>> of_get_phy_id() will parse that compatible

Re: [PATCH v4 2/3] Add phy interface for 5GBASER mode

2020-10-26 Thread Florian Fainelli
On 10/25/2020 10:58 PM, Pavana Sharma wrote: Signed-off-by: Pavana Sharma Please subject this patch properly with "net: phy: Add 5GBASER interface mode" and please also consider updating other files that are relevant here: Documentation/devicetree/bindings/net/ethernet-controller.yaml

Re: [PATCH v4 0/3] Add support for mv88e6393x family of Marvell.

2020-10-26 Thread Florian Fainelli
On 10/25/2020 10:52 PM, Pavana Sharma wrote: Hi, Thanks for the review. Following is the updated patchset. The 6393X family has MV88E6191X, MV88E6193X and MV88E6393X products listed in Gigabit Ethernet and Gigabit 10G+ Ethernet categories. There are no 6393 devices (without X) but there is

Re: [PATCH] ARM: dts: BCM5301X: Linksys EA9500 add fixed partitions

2020-10-26 Thread Florian Fainelli
On 10/26/2020 6:13 AM, Vivek Unune wrote: This router has dual paritions to store trx firmware image and dual partitions for nvram. The second one in each of these cases acts as a backup store. When tested with OpenWrt, the default partition parser causes two issues: 1. It labels both nvram

Re: [PATCH] RFC: net: phy: of phys probe/reset issue

2020-10-23 Thread Florian Fainelli
On 10/23/20 10:47 AM, Grygorii Strashko wrote: > Hi All, > > The main intention of this mail is to trigger discussion to find a proper > solution. All code is hackish and based on v5.9. > > Problem statement: > > There is an issue observed with MDIO OF PHYs discover/reset sequence in > case PHY

[PATCH v2 2/2] phy: phy-brcm-sata: Allow configuration SATA AFE TX amplitude

2020-10-22 Thread Florian Fainelli
Read the 'brcm,tx-amplitude-millivolt' property from Device Tree and propagate its value into the appropriate test transmit register to change the TX amplitude. Signed-off-by: Florian Fainelli --- drivers/phy/broadcom/phy-brcm-sata.c | 32 1 file changed, 32

[PATCH v2 0/2] phy: phy-brcm-sata: Allow configuration SATA AFE TX amplitude

2020-10-22 Thread Florian Fainelli
Hi Vinod, Kishon, This patch series allows the configuration of the Broadcom SATA PHY TX amplitude which may be required in order to meet specific tests. Thanks! Changes in v2: - rebased against phy/next - added Rob's Acked-by to the dt-binding patch Florian Fainelli (2): dt-bindings: phy

[PATCH v2 1/2] dt-bindings: phy: Allow defining the SATA AFE TX amplitude

2020-10-22 Thread Florian Fainelli
Document a new property which allows the selection of the SATA AFE TX amplitude in milli Volts. Possible values are 400, 500, 600 and 800mV. Acked-by: Rob Herring Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/phy/brcm-sata-phy.txt | 3 +++ 1 file changed, 3 insertions

Re: [PATCH 16/29] arm: dts: bcm5301x: Harmonize xHCI DT nodes name

2020-10-22 Thread Florian Fainelli
On 10/20/20 4:59 AM, Serge Semin wrote: > In accordance with the Generic xHCI bindings the corresponding node > name is suppose to comply with the Generic USB HCD DT schema, which > requires the USB nodes to have the name acceptable by the regexp: > "^usb(@.*)?" . Make sure the

Re: [PATCH 07/29] arm: dts: bcm53x: Harmonize EHCI/OHCI DT nodes name

2020-10-22 Thread Florian Fainelli
sure the "generic-ehci" and "generic-ohci"-compatible > nodes are correctly named. > > Signed-off-by: Serge Semin > Acked-by: Florian Fainelli Applied to devicetree/next after fixing up the subject to be: ARM: dts: BCM5310X: Harmonize EHCI/OHCI DT nodes

Re: [PATCH] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7

2020-10-22 Thread Florian Fainelli
On Wed, 14 Oct 2020 15:27:27 -0400, Vivek Unune wrote: > Add ports 5 and 7 which are connected to gmac cores 1 & 2. > These will be disabled for now. > > Signed-off-by: Vivek Unune > --- Applied to devicetree/next, thanks! -- Florian

Re: [PATCH] ARM: dts: BCM5301X: Linksys EA9500 add port 5 and port 7

2020-10-22 Thread Florian Fainelli
On 10/22/20 1:16 PM, Vivek Unune wrote: > On Wed, Oct 14, 2020 at 03:27:27PM -0400, Vivek Unune wrote: >> Add ports 5 and 7 which are connected to gmac cores 1 & 2. >> These will be disabled for now. >> >> Signed-off-by: Vivek Unune >> --- >> .../boot/dts/bcm47094-linksys-panamera.dts| 24

Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-22 Thread Florian Fainelli
On 10/22/20 5:37 AM, Vladimir Oltean wrote: > On Thu, Oct 22, 2020 at 12:54:52PM +0200, Kurt Kanzenbach wrote: >> On Wed Oct 21 2020, Florian Fainelli wrote: >>> On 10/21/2020 5:16 PM, Vladimir Oltean wrote: >>>> On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenb

Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-21 Thread Florian Fainelli
On 10/21/2020 5:16 PM, Vladimir Oltean wrote: On Wed, Oct 21, 2020 at 08:52:01AM +0200, Kurt Kanzenbach wrote: On Mon Oct 19 2020, Christian Eggers wrote: The node names should be switch. See dsa.yaml. +compatible = "microchip,ksz9477"; +reg = <0>; +

Re: [sched] c3a340f7e7: invalid_opcode:#[##]

2020-10-20 Thread Florian Fainelli
On 6/30/20 7:49 AM, Peter Zijlstra wrote: > On Tue, Jun 30, 2020 at 02:46:28PM +0200, Peter Zijlstra wrote: >> On Mon, Jun 29, 2020 at 08:31:27AM +0800, kernel test robot wrote: >>> Greeting, >>> >>> FYI, we noticed the following commit (built with gcc-4.9): >>> >>> commit:

Re: [PATCH] net: dsa: bcm_sf2: make const array static, makes object smaller

2020-10-20 Thread Florian Fainelli
12 3824 192 338288424 drivers/net/dsa/bcm_sf2.o > > After: >text data bss dec hex filename > 29670 3920 192 3378283f6 drivers/net/dsa/bcm_sf2.o > > (gcc version 10.2.0) > > Signed-off-by: Colin Ian King Acked-by: Florian Fainelli -- Florian

Re: [PATCH net] net: Have netpoll bring-up DSA management interface

2020-10-19 Thread Florian Fainelli
On 10/19/20 1:02 PM, Vladimir Oltean wrote: > On Mon, Oct 19, 2020 at 10:17:44AM -0700, Florian Fainelli wrote: >> These devices also do not utilize the upper/lower linking so the >> check about the netpoll device having upper is not going to be a >> problem. > > They

[PATCH net] net: Have netpoll bring-up DSA management interface

2020-10-19 Thread Florian Fainelli
restricted to that of the process configuring netpoll. Fixes: 04ff53f96a93 ("net: dsa: Add netconsole support") Signed-off-by: Florian Fainelli --- net/core/netpoll.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/net/core/netpoll.c b/net/

Re: [PATCH 0/3] net: dsa: move skb reallocation to dsa_slave_xmit

2020-10-17 Thread Florian Fainelli
On 10/16/2020 1:02 PM, Christian Eggers wrote: [snip] On Friday, 16 October 2020, 20:03:11 CEST, Jakub Kicinski wrote: FWIW if you want to avoid the reallocs you may want to set needed_tailroom on the netdev. I haven't looked for this yet. If this can really solve the tagging AND padding

Re: [PATCH net-next 1/3] net: dsa: don't pass cloned skb's to drivers xmit function

2020-10-17 Thread Florian Fainelli
On 10/16/2020 1:02 PM, Christian Eggers wrote: Ensure that the skb is not cloned and has enough tail room for the tail tag. This code will be removed from the drivers in the next commits. Signed-off-by: Christian Eggers --- [snip] + /* We have to pad he packet to the minimum

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-10-16 Thread Florian Fainelli
On 10/16/20 11:23 AM, Arnd Bergmann wrote: > On Fri, Oct 16, 2020 at 6:48 PM Florian Fainelli wrote: >> On 10/16/20 4:01 AM, Arnd Bergmann wrote: >>> On Fri, Oct 16, 2020 at 11:09 AM Zhen Lei >>> wrote: >>>> >>>> Suggested-by: Arnd Bergmann &

Re: [PATCH v2 1/2] arm64: dts: broadcom: clear the warnings caused by empty dma-ranges

2020-10-16 Thread Florian Fainelli
On 10/16/20 4:01 AM, Arnd Bergmann wrote: > On Fri, Oct 16, 2020 at 11:09 AM Zhen Lei wrote: >> >> The scripts/dtc/checks.c requires that the node have empty "dma-ranges" >> property must have the same "#address-cells" and "#size-cells" values as >> the parent node. Otherwise, the following

Re: [PATCH net] net: dsa: point out the tail taggers

2020-10-16 Thread Florian Fainelli
7 which were missing in the > original commit. > > Fixes: 7a6ffe764be3 [net] ("net: dsa: point out the tail taggers") > Signed-off-by: Christian Eggers Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3] Add support for mv88e6393x family of Marvell.

2020-10-15 Thread Florian Fainelli
On 10/15/2020 7:09 PM, Pavana Sharma wrote: The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family

Re: [PATCH 0/3] IRQ stack support for ARM

2020-10-15 Thread Florian Fainelli
On 10/15/20 1:59 PM, Nick Desaulniers wrote: > On Thu, Oct 8, 2020 at 1:30 AM Russell King - ARM Linux admin > wrote: >> >> On Thu, Oct 08, 2020 at 12:45:30PM +0530, Maninder Singh wrote: >>> Observed Stack Overflow on 8KB kernel stack on ARM specially >>> incase on network interrupts, which

Re: arm-smmu 5000000.iommu: Cannot accommodate DMA offset for IOMMU page tables

2020-10-15 Thread Florian Fainelli
On 10/15/20 12:48 AM, Christoph Hellwig wrote: > On Sun, Oct 11, 2020 at 05:53:37AM +1100, Stephen Rothwell wrote: >> Hi Naresh, >> >> Just adding Christoph and Jim to cc] > > Well, a Cc doesn't help on its own. Can you send an actual bug > report including the setup, warnings and error

Re: [PATCH net-next] net: ptp: get rid of IPV4_HLEN() and OFF_IHL macros

2020-10-15 Thread Florian Fainelli
On 10/14/20 8:36 PM, Richard Cochran wrote: > On Wed, Oct 14, 2020 at 01:58:05PM +0200, Christian Eggers wrote: >> Both macros are already marked for removal. > > I'm not sure what Daniel Borkmann meant by that comment, but ... > >> switch (type & PTP_CLASS_PMASK) { >> case

Re: [PATCH 07/20] dt-bindings: usb: xhci: Add Broadcom STB v2 compatible device

2020-10-15 Thread Florian Fainelli
f-by: Serge Semin Acked-by: Florian Fainelli -- Florian

Re: [PATCH 18/20] arch: dts: Fix EHCI/OHCI DT nodes name

2020-10-15 Thread Florian Fainelli
ies. > --- > arch/arm/boot/dts/bcm5301x.dtsi| 4 ++-- > arch/arm/boot/dts/bcm53573.dtsi| 4 ++-- Acked-by: Florian Fainelli -- Florian

Re: Use after free in bcm2835_spi_remove()

2020-10-14 Thread Florian Fainelli
f it was allocated as part of allocating the controller. > This framework feature is unfortunately quite error prone. Lukas, your patch works fine for me and is only two lines, so maybe better suited for stable. How about the attached patch? -- Florian From a4ee9da1ef09f9ddb04060e644b

Re: [PATCH 02/11] firmware: arm_scmi: hide protocols' private data

2020-10-14 Thread Florian Fainelli
On 10/14/20 8:05 AM, Cristian Marussi wrote: > Protocols private data were meant to be used exclusively by protocol code > but they are currently exposed through the handle, so available also to > SCMI drivers: move them away from handle into instance specific data and > provide internal helpers

Re: [PATCH 01/11] firmware: arm_scmi: review protocol registration interface

2020-10-14 Thread Florian Fainelli
On 10/14/20 8:05 AM, Cristian Marussi wrote: > Extend common protocol registration routines and provide some new generic > protocols' init/deinit helpers that tracks protocols' users and automatically > perform the proper initialization/de-initialization on demand. > > Convert all protocols to

<    1   2   3   4   5   6   7   8   9   10   >