[] (do_vfs_ioctl+0x4a0/0x560)
[] (do_vfs_ioctl) from [] (SyS_ioctl+0x4c/0x74)
[] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x30)
Signed-off-by: Frans Klaver
---
drivers/tty/serial/omap-serial.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/omap-serial.c b
On 23 September 2014 19:17:20 CEST, Peter Hurley
wrote:
>On 09/23/2014 04:24 AM, Frans Klaver wrote:
>> On Wed, Sep 17, 2014 at 02:13:03PM +0200, Frans Klaver wrote:
>>> On Wed, Sep 17, 2014 at 08:01:08AM -0400, Peter Hurley wrote:
>>>> On 09/16/2014 04:50 AM, Fr
On Wed, Sep 17, 2014 at 02:13:03PM +0200, Frans Klaver wrote:
> On Wed, Sep 17, 2014 at 08:01:08AM -0400, Peter Hurley wrote:
> > On 09/16/2014 04:50 AM, Frans Klaver wrote:
> > > On Mon, Sep 15, 2014 at 01:31:56PM -0400, Peter Hurley wrote:
> > >> On 09/15/201
On Wed, Sep 17, 2014 at 02:13:03PM +0200, Frans Klaver wrote:
On Wed, Sep 17, 2014 at 08:01:08AM -0400, Peter Hurley wrote:
On 09/16/2014 04:50 AM, Frans Klaver wrote:
On Mon, Sep 15, 2014 at 01:31:56PM -0400, Peter Hurley wrote:
On 09/15/2014 11:39 AM, Peter Hurley wrote:
On 09/15
On 23 September 2014 19:17:20 CEST, Peter Hurley pe...@hurleysoftware.com
wrote:
On 09/23/2014 04:24 AM, Frans Klaver wrote:
On Wed, Sep 17, 2014 at 02:13:03PM +0200, Frans Klaver wrote:
On Wed, Sep 17, 2014 at 08:01:08AM -0400, Peter Hurley wrote:
On 09/16/2014 04:50 AM, Frans Klaver wrote
] (ret_fast_syscall+0x0/0x30)
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/tty/serial/omap-serial.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index ae935ce..7d3f557 100644
Hi Greg,
Here's a couple of patches that fix a divison by zero in omap-serial.c. One's a
cleanup, the other the actual fix.
Thanks,
Frans
Frans Klaver (2):
tty: omap-serial: pull out calculation from baud_is_mode16
tty: omap-serial: fix a division by zero
drivers/tty/serial/omap-serial.c
To determine the correct divisor, we need to know the difference between
the desired baud rate and the actual baud rate. The calculation for this
difference is implemented twice within omap_serial_baud_is_mode16().
Pull out the calculation for easier maintenance.
Signed-off-by: Frans Klaver
On Tue, Sep 23, 2014 at 8:38 PM, Tony Lindgren t...@atomide.com wrote:
* Frans Klaver franskla...@gmail.com [140923 11:12]:
On 23 September 2014 19:17:20 CEST, Peter Hurley pe...@hurleysoftware.com
wrote:
I would've thought the first 2 patches had already been picked up
because
they fix
On Sun, Sep 21, 2014 at 10:41:00PM +0200, Sebastian Andrzej Siewior wrote:
> * Frans Klaver | 2014-09-17 12:28:12 [+0200]:
>
> >- Bone Black: Yocto poky, core-image-minimal
> > Login, "less file" locks up, doesn't show anything. I can exit using
> > Ctrl-
On Sun, Sep 21, 2014 at 10:41:00PM +0200, Sebastian Andrzej Siewior wrote:
* Frans Klaver | 2014-09-17 12:28:12 [+0200]:
- Bone Black: Yocto poky, core-image-minimal
Login, less file locks up, doesn't show anything. I can exit using
Ctrl-C.
So I have the same with my and the serial
Handle errors immediately in eeepc_register_rfkill_notifier and
eeepc_unregister_rfkill_notifier. This clears up the control flow for the
reader. It also removes unnecessary indentation.
Signed-off-by: Frans Klaver
---
This depends on the earlier eeepc cleanup series [1] to apply cleanly.
[1
Handle errors immediately in eeepc_register_rfkill_notifier and
eeepc_unregister_rfkill_notifier. This clears up the control flow for the
reader. It also removes unnecessary indentation.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
This depends on the earlier eeepc cleanup series [1
On 19 September 2014 19:25:38 CEST, Darren Hart wrote:
>On Wed, Sep 17, 2014 at 11:47:18PM +0200, Frans Klaver wrote:
>> Here's the second installment cleaning up some things in the eeepc
>laptop
>> driver.
>>
>> This depends on "eeepc-laptop: simplify parse_
On 19 September 2014 18:46:03 CEST, Darren Hart wrote:
>On Thu, Sep 18, 2014 at 07:01:25AM +0200, Frans Klaver wrote:
>> On 18 September 2014 00:06:52 CEST, Joe Perches
>wrote:
>> >On Wed, 2014-09-17 at 23:47 +0200, Frans Klaver wrote:
>> >> Correct inde
On 19 September 2014 18:46:03 CEST, Darren Hart dvh...@infradead.org wrote:
On Thu, Sep 18, 2014 at 07:01:25AM +0200, Frans Klaver wrote:
On 18 September 2014 00:06:52 CEST, Joe Perches j...@perches.com
wrote:
On Wed, 2014-09-17 at 23:47 +0200, Frans Klaver wrote:
Correct indentation and brace
On 19 September 2014 19:25:38 CEST, Darren Hart dvh...@infradead.org wrote:
On Wed, Sep 17, 2014 at 11:47:18PM +0200, Frans Klaver wrote:
Here's the second installment cleaning up some things in the eeepc
laptop
driver.
This depends on eeepc-laptop: simplify parse_arg().
For those
On 18 September 2014 00:07:53 CEST, Greg Kroah-Hartman
wrote:
>On Wed, Sep 17, 2014 at 11:47:23PM +0200, Frans Klaver wrote:
>> The disp attribute is write-only, but sysfs doesn't know this.
>Currently
>> show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi
&g
On 18 September 2014 00:06:52 CEST, Joe Perches wrote:
>On Wed, 2014-09-17 at 23:47 +0200, Frans Klaver wrote:
>> Correct indentation and brace usage to comply with
>> Documentation/CodingStyle.
>>
>> Signed-off-by: Frans Klaver
>> ---
>> drivers/platfor
v2
v1..v2:
- squash coding style fixes
- drop patch moving to file permission macros, in favor of
- move towards better sysfs api usage
- drop changes to existing sysfs return values
Frans Klaver (9):
eeepc-laptop: clean up coding style
eeepc-laptop: change sysfs function na
Device attributes are instantiated manually, while we have DEVICE_ATTR*
macros available to do much of the work for us. Let's use them.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 34 --
1 file changed, 4 insertions(+), 30 deletions
Correct indentation and brace usage to comply with
Documentation/CodingStyle.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc
The eeepc-laptop driver follows the function naming convention
_(), while the sysfs macros are built around the
convention _(). Rename the sysfs functions to the
convention used by sysfs. This makes it easier to use the available API
later on.
Signed-off-by: Frans Klaver
---
drivers/platform
Append _RW
to the name for readability.
Signed-off-by: Frans Klaver
---
Here we're sticking with -EIO as return values. It should be said that the
commit mentioned above did change the error value from -ENODEV to -EIO. I'm
still in two minds about whether the show_sys_acpi and store_sys_acpi shou
Pull out macros EEEPC_ACPI_STORE_FUNC and EEEPC_ACPI_SHOW_FUNC. These
macros define functions that call store_sys_acpi() and show_sys_acpi()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 12 +---
1 file
Pull out EEEPC_SENSOR_STORE_FUNC and EEEPC_SENSOR_SHOW_FUNC. These
macros define functions that call store_sys_hwmon() and show_sys_hwmon()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 12 +---
1 file
The result of set_acpi is left unchecked, but it may return errors. If
one occurs, send the error to the caller. There's no reason to lie about
it, if set_acpi fails.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
we can ignore values below
zero.
Check the result of get_acpi() right away. While at it, propagate the
error if we got one.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-lapto
-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index ba251bb..e93a54e 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b
On Wed, Sep 17, 2014 at 01:35:10PM -0700, Darren Hart wrote:
> On Wed, Sep 17, 2014 at 09:02:51PM +0200, Paul Bolle wrote:
> > parse_arg() has three possible return values:
> > -EINVAL if sscanf(), in short, fails;
> > zero if "count" is zero; and
> > "count" in all other cases
> >
>
On Wed, Sep 17, 2014 at 01:35:10PM -0700, Darren Hart wrote:
> On Wed, Sep 17, 2014 at 09:02:51PM +0200, Paul Bolle wrote:
> > parse_arg() has three possible return values:
> > -EINVAL if sscanf(), in short, fails;
> > zero if "count" is zero; and
> > "count" in all other cases
> >
>
On Wed, Sep 17, 2014 at 08:01:08AM -0400, Peter Hurley wrote:
> On 09/16/2014 04:50 AM, Frans Klaver wrote:
> > On Mon, Sep 15, 2014 at 01:31:56PM -0400, Peter Hurley wrote:
> >> On 09/15/2014 11:39 AM, Peter Hurley wrote:
> >>> On 09/15/2014 10:00 AM, Frans Kl
On Wed, Sep 17, 2014 at 12:34 PM, Henrique de Moraes Holschuh
wrote:
> On Tue, 16 Sep 2014, Darren Hart wrote:
>> - When reading and writing sysfs device attribute files, avoid dependency
>> on specific error codes wherever possible. This minimizes coupling to
>> the error handling
Hi,
Yesterday's testing was a bit messy. So here goes again.
On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/12/2014 12:28 PM, Frans Klaver wrote:
> > port config is 115200 8N1. I don't recall doing anything special. I
> > boot, login, less file
Hi,
Yesterday's testing was a bit messy. So here goes again.
On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
On 09/12/2014 12:28 PM, Frans Klaver wrote:
port config is 115200 8N1. I don't recall doing anything special. I
boot, login, less file and get a lock
On Wed, Sep 17, 2014 at 12:34 PM, Henrique de Moraes Holschuh
h...@hmh.eng.br wrote:
On Tue, 16 Sep 2014, Darren Hart wrote:
- When reading and writing sysfs device attribute files, avoid dependency
on specific error codes wherever possible. This minimizes coupling to
the error handling
On Wed, Sep 17, 2014 at 08:01:08AM -0400, Peter Hurley wrote:
On 09/16/2014 04:50 AM, Frans Klaver wrote:
On Mon, Sep 15, 2014 at 01:31:56PM -0400, Peter Hurley wrote:
On 09/15/2014 11:39 AM, Peter Hurley wrote:
On 09/15/2014 10:00 AM, Frans Klaver wrote:
At 3.6Mbaud, with slightly over
On Wed, Sep 17, 2014 at 01:35:10PM -0700, Darren Hart wrote:
On Wed, Sep 17, 2014 at 09:02:51PM +0200, Paul Bolle wrote:
parse_arg() has three possible return values:
-EINVAL if sscanf(), in short, fails;
zero if count is zero; and
count in all other cases
But count will
On Wed, Sep 17, 2014 at 01:35:10PM -0700, Darren Hart wrote:
On Wed, Sep 17, 2014 at 09:02:51PM +0200, Paul Bolle wrote:
parse_arg() has three possible return values:
-EINVAL if sscanf(), in short, fails;
zero if count is zero; and
count in all other cases
But count will
-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index ba251bb..e93a54e 100644
--- a/drivers/platform/x86
The result of set_acpi is left unchecked, but it may return errors. If
one occurs, send the error to the caller. There's no reason to lie about
it, if set_acpi fails.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 4 +++-
1 file changed, 3 insertions
values below
zero.
Check the result of get_acpi() right away. While at it, propagate the
error if we got one.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86
Pull out EEEPC_SENSOR_STORE_FUNC and EEEPC_SENSOR_SHOW_FUNC. These
macros define functions that call store_sys_hwmon() and show_sys_hwmon()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 12
Pull out macros EEEPC_ACPI_STORE_FUNC and EEEPC_ACPI_SHOW_FUNC. These
macros define functions that call store_sys_acpi() and show_sys_acpi()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 12
to the name for readability.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
Here we're sticking with -EIO as return values. It should be said that the
commit mentioned above did change the error value from -ENODEV to -EIO. I'm
still in two minds about whether the show_sys_acpi
The eeepc-laptop driver follows the function naming convention
action_attrname(), while the sysfs macros are built around the
convention attrname_action(). Rename the sysfs functions to the
convention used by sysfs. This makes it easier to use the available API
later on.
Signed-off-by: Frans
Correct indentation and brace usage to comply with
Documentation/CodingStyle.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers
Device attributes are instantiated manually, while we have DEVICE_ATTR*
macros available to do much of the work for us. Let's use them.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 34 --
1 file changed, 4 insertions
:
- squash coding style fixes
- drop patch moving to file permission macros, in favor of
- move towards better sysfs api usage
- drop changes to existing sysfs return values
Frans Klaver (9):
eeepc-laptop: clean up coding style
eeepc-laptop: change sysfs function names to API expectations
On 18 September 2014 00:06:52 CEST, Joe Perches j...@perches.com wrote:
On Wed, 2014-09-17 at 23:47 +0200, Frans Klaver wrote:
Correct indentation and brace usage to comply with
Documentation/CodingStyle.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc
On 18 September 2014 00:07:53 CEST, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Sep 17, 2014 at 11:47:23PM +0200, Frans Klaver wrote:
The disp attribute is write-only, but sysfs doesn't know this.
Currently
show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi
On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote:
>
> - When reading and writing sysfs device attribute files, avoid dependency
> on specific error codes wherever possible. This minimizes coupling to
> the error handling implemementation within the kernel.
>
> In general,
On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote:
> On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote:
> > On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver
> > wrote:
> > > On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote:
> >
On Tue, Sep 16, 2014 at 02:42:00PM +0200, Frans Klaver wrote:
> On Tue, Sep 16, 2014 at 11:05:40AM +0200, Frans Klaver wrote:
> > On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
> > > If there is nothing specific to the file you do less on I have no id
On Tue, Sep 16, 2014 at 11:05:40AM +0200, Frans Klaver wrote:
> On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
> > On 09/12/2014 12:28 PM, Frans Klaver wrote:
> > > port config is 115200 8N1. I don't recall doing anything special. I
> > > boo
On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver wrote:
> On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote:
>> On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote:
>> >
>> > This patch is fine as is. However, Greg has supported propogating the
&
On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/12/2014 12:28 PM, Frans Klaver wrote:
> > port config is 115200 8N1. I don't recall doing anything special. I
> > boot, login, less file and get a lock.
>
> So I booted my mini Debian 7.6 (b
On Mon, Sep 15, 2014 at 01:31:56PM -0400, Peter Hurley wrote:
> On 09/15/2014 11:39 AM, Peter Hurley wrote:
> > On 09/15/2014 10:00 AM, Frans Klaver wrote:
> >> At 3.6Mbaud, with slightly over 2Mbit/s data coming in, we see 1600 uart
> >> rx buffer overflows w
On Mon, Sep 15, 2014 at 01:31:56PM -0400, Peter Hurley wrote:
On 09/15/2014 11:39 AM, Peter Hurley wrote:
On 09/15/2014 10:00 AM, Frans Klaver wrote:
At 3.6Mbaud, with slightly over 2Mbit/s data coming in, we see 1600 uart
rx buffer overflows within 30 seconds. Threading the interrupt
On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
On 09/12/2014 12:28 PM, Frans Klaver wrote:
port config is 115200 8N1. I don't recall doing anything special. I
boot, login, less file and get a lock.
So I booted my mini Debian 7.6 (basic system + openssh) on my
On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com wrote:
On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote:
On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote:
This patch is fine as is. However, Greg has supported propogating the
error code
On Tue, Sep 16, 2014 at 11:05:40AM +0200, Frans Klaver wrote:
On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
On 09/12/2014 12:28 PM, Frans Klaver wrote:
port config is 115200 8N1. I don't recall doing anything special. I
boot, login, less file and get a lock
On Tue, Sep 16, 2014 at 02:42:00PM +0200, Frans Klaver wrote:
On Tue, Sep 16, 2014 at 11:05:40AM +0200, Frans Klaver wrote:
On Mon, Sep 15, 2014 at 06:42:04PM +0200, Sebastian Andrzej Siewior wrote:
If there is nothing specific to the file you do less on I have no idea
what else it could
On Tue, Sep 16, 2014 at 01:52:47PM -0700, Darren Hart wrote:
On Tue, Sep 16, 2014 at 01:54:25PM +0200, Frans Klaver wrote:
On Mon, Sep 15, 2014 at 11:55 PM, Frans Klaver franskla...@gmail.com
wrote:
On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote:
On Mon, Sep 15
On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote:
- When reading and writing sysfs device attribute files, avoid dependency
on specific error codes wherever possible. This minimizes coupling to
the error handling implemementation within the kernel.
In general, failures to
On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote:
> > On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote:
> > > In get_cpufv the return value of get_acpi is stored in the cpufv struct.
On Mon, Sep 15, 2014 at 01:00:07PM -0700, Darren Hart wrote:
> On Sat, Sep 13, 2014 at 01:06:46AM +0200, Frans Klaver wrote:
> > The disp attribute is write-only, but sysfs doesn't know this. Currently
> > show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call
On Mon, Sep 15, 2014 at 12:41:41PM -0700, Darren Hart wrote:
> On Sat, Sep 13, 2014 at 01:06:42AM +0200, Frans Klaver wrote:
> > Signed-off-by: Frans Klaver
>
> Hi Frans,
>
> Please merge the 3 coding style fixes into one patch. There is no functional
> change here, and
If the chosen baud rate is large enough (e.g. 3.5 megabaud), the
calculated n values in calculate_baud_abs_diff may become 0. This causes
a division by zero when calculating the difference between calculated
and desired baud rates. To prevent this, cap n on 1.
Signed-off-by: Frans Klaver
To determine the correct divisor, we need to know the difference between
the desired baud rate and the actual baud rate. The calculation for this
difference is implemented twice within omap_serial_baud_is_mode16().
Pull out the calculation for easier maintenance.
Signed-off-by: Frans Klaver
This makes hardware flow control availability configurable from the
device tree.
Signed-off-by: Frans Klaver
---
Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty/serial/omap-serial.c | 4
2 files changed, 5 insertions(+)
diff --git
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver
---
drivers/tty/serial/omap-serial.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 7d3f557..398139a 100644
ision by zero"
- use IRQ_ONESHOT for the threaded irq in "use threaded interrupt handler"
v1..v2
- centralize baud_is_mode16's calculation
- fix/unbreak an uninitialized variable in "use threaded interrupt handler"
- read has-hw-flow-control property in of_get_uart_port
- use IRQ_ONESHOT for the threaded irq in use threaded interrupt handler
v1..v2
- centralize baud_is_mode16's calculation
- fix/unbreak an uninitialized variable in use threaded interrupt handler
- read has-hw-flow-control property in of_get_uart_port_info
Frans Klaver (4):
tty: omap
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/tty/serial/omap-serial.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index
This makes hardware flow control availability configurable from the
device tree.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty/serial/omap-serial.c | 4
2 files changed, 5 insertions
To determine the correct divisor, we need to know the difference between
the desired baud rate and the actual baud rate. The calculation for this
difference is implemented twice within omap_serial_baud_is_mode16().
Pull out the calculation for easier maintenance.
Signed-off-by: Frans Klaver
If the chosen baud rate is large enough (e.g. 3.5 megabaud), the
calculated n values in calculate_baud_abs_diff may become 0. This causes
a division by zero when calculating the difference between calculated
and desired baud rates. To prevent this, cap n on 1.
Signed-off-by: Frans Klaver
On Mon, Sep 15, 2014 at 12:41:41PM -0700, Darren Hart wrote:
On Sat, Sep 13, 2014 at 01:06:42AM +0200, Frans Klaver wrote:
Signed-off-by: Frans Klaver franskla...@gmail.com
Hi Frans,
Please merge the 3 coding style fixes into one patch. There is no functional
change here, and each
On Mon, Sep 15, 2014 at 01:00:07PM -0700, Darren Hart wrote:
On Sat, Sep 13, 2014 at 01:06:46AM +0200, Frans Klaver wrote:
The disp attribute is write-only, but sysfs doesn't know this. Currently
show_sys_acpi() is mimicking sysfs behavior, if the underlying acpi call
should fail
On Mon, Sep 15, 2014 at 02:51:25PM -0700, Greg Kroah-Hartman wrote:
On Mon, Sep 15, 2014 at 02:49:02PM -0700, Darren Hart wrote:
On Sat, Sep 13, 2014 at 01:06:49AM +0200, Frans Klaver wrote:
In get_cpufv the return value of get_acpi is stored in the cpufv struct.
Right before this value
On Fri, Sep 12, 2014 at 04:28:51PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Sep 13, 2014 at 01:06:44AM +0200, Frans Klaver wrote:
> > Signed-off-by: Frans Klaver
> > ---
> > drivers/platform/x86/eeepc-laptop.c | 35
> > +--
> &
On Fri, Sep 12, 2014 at 04:28:51PM -0700, Greg Kroah-Hartman wrote:
On Sat, Sep 13, 2014 at 01:06:44AM +0200, Frans Klaver wrote:
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 35
+--
1 file changed, 5
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 982778f..702fcbb 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b
9/3/865
[2] https://lkml.org/lkml/2014/9/10/742
For those interested, a proper branch is available at:
https://github.com/fransklaver/linux wip/eeepc_cleanup_v1
Frans Klaver (13):
eeepc-laptop: coding style: fix indentation
eeepc-laptop: coding style: add curly braces around els
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 9d8dff9..f35d008 100644
--- a/drivers/platform/x86/eeepc-laptop.c
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 702fcbb..9d8dff9 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 35 +--
1 file changed, 5 insertions(+), 30 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index f35d008..8225b1e 100644
--- a/drivers
Pull out macros EEEPC_ACPI_STORE_FUNC and EEEPC_ACPI_SHOW_FUNC. These
macros define functions that call store_sys_acpi() and show_sys_acpi()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 12 +---
1 file
the
attribute, the system will at least keep its sanity.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index fbaa4d5..47488d3 100644
attribute, and declare the disp attribute with it. Sysfs makes sure
userspace can only write to disp at all times. This also means we can
back to propagating any errors from get_acpi().
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 8 ++--
1 file changed, 6 insertions(+), 2
Pull out EEEPC_SENSOR_STORE_FUNC and EEEPC_SENSOR_SHOW_FUNC. These
macros define functions that call store_sys_hwmon() and show_sys_hwmon()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 12 +---
1 file
we can ignore values below
zero.
Check the result of get_acpi() right away. While at it, propagate the
error if we got one.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-lapto
In show_available_cpufv, show_cpufv, and store_cpufv, errors from
get_cpufv are mapped to -ENODEV. To paint a clear picture to callers,
propagate the errors instead.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 16 ++--
1 file changed, 10 insertions(+), 6
s.
Signed-off-by: Frans Klaver
---
Changing ENODEV to ENXIO in acpi_setter_handle() probably requires some extra
work to get it working properly. I'd propose to dive into that after we finish
this series, or we drop this patch from the series and move the whole return
value issue into a separate
The result of set_acpi is left unchecked, but it may return errors. If
one occurs, send the error to the caller.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 90be993..982778f 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers
On Fri, Sep 12, 2014 at 11:51:22AM +0200, Sebastian Andrzej Siewior wrote:
> On 09/12/2014 11:40 AM, Frans Klaver wrote:
>
> > I'm not sure. I just reproduced this on a boneblack, using your uart_v9
> > branch.
> >
> >> This problem only pops-up if you use
On Fri, Sep 12, 2014 at 09:23:24AM +0200, Sebastian Andrzej Siewior wrote:
> On 09/11/2014 07:04 PM, Frans Klaver wrote:
> > On 11 September 2014 18:04:32 CEST, Sebastian Andrzej Siewior
> > wrote:
> >> On 09/11/2014 05:11 PM, Frans Klaver wrote:
> >>
> >&
On Fri, Sep 12, 2014 at 09:23:24AM +0200, Sebastian Andrzej Siewior wrote:
On 09/11/2014 07:04 PM, Frans Klaver wrote:
On 11 September 2014 18:04:32 CEST, Sebastian Andrzej Siewior
bige...@linutronix.de wrote:
On 09/11/2014 05:11 PM, Frans Klaver wrote:
I can still reproduce
801 - 900 of 999 matches
Mail list logo
