[PATCH] scsi: csiostor: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/scsi/csiostor/csio_wr.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/csiostor/csio_wr.c b/drivers/scsi/csiostor/csio_wr.c index 03

[PATCH] skd: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/block/skd_main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 7d3ad6c22ee5..996c38d03

[PATCH] scsi: esas2r: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/scsi/esas2r/esas2r_init.c | 13 - drivers/scsi/esas2r/esas2r_ioctl.c | 14 +- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/s

[PATCH] qed: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/net/ethernet/qlogic/qed/qed_rdma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/

[PATCH] media: cobalt: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/media/pci/cobalt/cobalt-driver.c | 38 ++-- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b/drivers/media/

[PATCH] cxgb4: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 6 ++ drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 9 +++-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/d

[PATCH] igc: Prefer pcie_capability_read_word()

2019-07-17 Thread Frederick Lawler
rd() calls with pcie_capability_read_word() and pcie_capability_write_word(). Signed-off-by: Frederick Lawler --- drivers/net/ethernet/intel/igc/igc_main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet

[PATCH v2 4/9] PCI/LINK: Prefix dmesg logs with PCIe service name

2019-05-02 Thread Frederick Lawler
bw_notification.c currently does not have any dmesg logs. As the service continues to expand in functionality, prefix logs anyways. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/bw_notification.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/pcie/bw_notification.c b

[PATCH v2 8/9] PCI: hotplug: Remove unnecessary dbg/err/info/warn() printk() wrappers

2019-05-02 Thread Frederick Lawler
Remove unnecessary deb/err/info/warn() printk() wrappers. Signed-off-by: Frederick Lawler --- drivers/pci/hotplug/pciehp.h | 9 - drivers/pci/hotplug/pciehp_core.c | 4 ++-- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci

[PATCH v2 3/9] PCI/PME: Prefix dmesg logs with PCIe service name

2019-05-02 Thread Frederick Lawler
Prefix dmesg logs with PCIe service name. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/pme.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index 54d593d10396..d6698423a6d6 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie

[PATCH v2 7/9] PCI: hotplug: Prefer CONFIG_DYNAMIC_DEBUG/DEBUG for dmesg logs

2019-05-02 Thread Frederick Lawler
, prefer pr/pci_dbg() for debug information, and reserve pciehp_debug for niche situations. Signed-off-by: Frederick Lawler --- drivers/pci/hotplug/pciehp.h | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index

[PATCH v2 5/9] PCI/AER: Prefix dmesg logs with PCIe service name

2019-05-02 Thread Frederick Lawler
Prefix dmesg logs with PCIe service name. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/aer.c| 10 +++--- drivers/pci/pcie/aer_inject.c | 6 -- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index

[PATCH v2 6/9] PCI: hotplug: Prefix dmesg logs with PCIe service name

2019-05-02 Thread Frederick Lawler
Prefix dmesg logs with PCIe service name. Signed-off-by: Frederick Lawler --- drivers/pci/hotplug/pciehp.h | 18 +- drivers/pci/hotplug/pciehp_core.c | 7 +-- drivers/pci/hotplug/pciehp_ctrl.c | 2 ++ drivers/pci/hotplug/pciehp_hpc.c | 4 +++- drivers/pci/hotplug

[PATCH v2 9/9] PCI: hotplug: Prefix ctrl_*() dmesg logs with pciehp slot name

2019-05-02 Thread Frederick Lawler
Remove current uses of "Slot(%s)" and then prefix ctrl_*() dmesg with pciehp slot name to include the slot name for all uses of ctrl_*() wrappers. Signed-off-by: Frederick Lawler --- drivers/pci/hotplug/pciehp.h | 12 --- drivers/pci/hotplug/pciehp_core.c | 9 +++-- d

[PATCH v2 2/9] PCI/DPC: Prefix dmesg logs with PCIe service name

2019-05-02 Thread Frederick Lawler
Prefix dmesg logs with PCIe service name. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/dpc.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index 7b77754a82de..934391c91c23

[PATCH v2 1/9] PCI/AER: Cleanup dmesg logs

2019-05-02 Thread Frederick Lawler
Cleanup dmesg logs. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/aer.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f8fc2114ad39..82eb45335b6f 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci

[PATCH v2 0/9] PCI: Use PCIe service name in dmesg logs

2019-05-02 Thread Frederick Lawler
-pci/20190308180149.gd214...@google.com/ Changes from v1: - Split dev_fmt() additions into own patches per service - Kept ctrl_*() wrappers and applied "Slot(%s)" prefix to messages - Attempted to leave no log gaps between patches Frederick Lawler (9): PCI/AER: Cleanup dmesg logs

Re: [PATCH 1/4] PCI: Replace dev_*() printk wrappers with pci_*() printk wrappers

2019-04-30 Thread Frederick Lawler
Bjorn, Bjorn Helgaas wrote on 4/28/19 7:52 PM: On Sun, Apr 28, 2019 at 07:02:58PM -0500, Bjorn Helgaas wrote: On Sat, Apr 27, 2019 at 02:13:01PM -0500, f...@fredlawl.com wrote: From: Frederick Lawler Replace remaining instances of dev_*() printk wrappers with pci_*() printk wrappers

Re: [PATCH 1/4] PCI: Replace dev_*() printk wrappers with pci_*() printk wrappers

2019-04-30 Thread Frederick Lawler
Andy, Andy Shevchenko wrote on 4/28/19 10:43 AM: On Sat, Apr 27, 2019 at 02:13:01PM -0500, f...@fredlawl.com wrote: From: Frederick Lawler Replace remaining instances of dev_*() printk wrappers with pci_*() printk wrappers. No functional change intended. - pci_printk

[PATCH] PCI/ASPM: Remove unused lists from struct pcie_link_state

2018-12-09 Thread Frederick Lawler
ASPM does not make use of the children or link LIST_HEADs declared in struct pcie_link_state and defined in alloc_pcie_link_state(). Therefore, remove these lists. No functional change intended. Signed-off-by: Frederick Lawler --- drivers/pci/pcie/aspm.c | 6 -- 1 file changed, 6 deletions

Re: [PATCH] PCI: Check whether bridges allow access to extended config space

2018-05-09 Thread Frederick Lawler
Hi, Gilles Buloz wrote: Here are full dmesg + lspci -vv + ... for the following cases : - 4.17-rc1_probe_failed_without_pcieaspmoff.txt : I get a broken PCI config at most boots, without pcie_aspm=off - 4.17-rc1_probe_ok_without_pcieaspmoff.txt : I get a correct PCI config at some boots, even

Re: [PATCH] PCI: Check whether bridges allow access to extended config space

2018-05-09 Thread Frederick Lawler
Hi, Gilles Buloz wrote: Here are full dmesg + lspci -vv + ... for the following cases : - 4.17-rc1_probe_failed_without_pcieaspmoff.txt : I get a broken PCI config at most boots, without pcie_aspm=off - 4.17-rc1_probe_ok_without_pcieaspmoff.txt : I get a correct PCI config at some boots, even