[PATCH] PCI: Restore PCI expansion ROM P2P prefetch window creation

2007-12-11 Thread Gary Hade
Restore PCI expansion ROM P2P prefetch window creation. This patch reverts previous "Avoid creating P2P prefetch window for expansion ROMs" change due to regressions that were spotted on some systems. Signed-off-by: Gary Hade <[EMAIL PROTECTED]> --- --- linux-2.6.24

[PATCH] PCI: Remove default PCI expansion ROM memory allocation

2007-12-11 Thread Gary Hade
mplemented in pcibios_assign_resources() [arch/x86/pci/i386.c] is unchanged. Signed-off-by: Gary Hade <[EMAIL PROTECTED]> --- --- linux-2.6.24-rc5/arch/x86/pci/common.c.orig 2007-12-11 09:59:13.0 -0800 +++ linux-2.6.24-rc5/arch/x86/pci/common.c 2007-12-11 11:27:35.0 -0800 @@ -109,6 +

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-12-11 Thread Gary Hade
On Mon, Nov 26, 2007 at 02:15:45PM -0800, Greg KH wrote: > On Mon, Nov 26, 2007 at 01:59:54PM -0800, Gary Hade wrote: > > Greg, > > Without a closer look at the code and the information I > > requested above I am not 100% certain that my expansion ROM > > allocation fix

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-12-11 Thread Gary Hade
On Mon, Nov 26, 2007 at 02:15:45PM -0800, Greg KH wrote: On Mon, Nov 26, 2007 at 01:59:54PM -0800, Gary Hade wrote: Greg, Without a closer look at the code and the information I requested above I am not 100% certain that my expansion ROM allocation fix is incomplete but it seems pretty

[PATCH] PCI: Restore PCI expansion ROM P2P prefetch window creation

2007-12-11 Thread Gary Hade
Restore PCI expansion ROM P2P prefetch window creation. This patch reverts previous Avoid creating P2P prefetch window for expansion ROMs change due to regressions that were spotted on some systems. Signed-off-by: Gary Hade [EMAIL PROTECTED] --- --- linux-2.6.24-rc5/drivers/pci/probe.c.orig

[PATCH] PCI: Remove default PCI expansion ROM memory allocation

2007-12-11 Thread Gary Hade
in pcibios_assign_resources() [arch/x86/pci/i386.c] is unchanged. Signed-off-by: Gary Hade [EMAIL PROTECTED] --- --- linux-2.6.24-rc5/arch/x86/pci/common.c.orig 2007-12-11 09:59:13.0 -0800 +++ linux-2.6.24-rc5/arch/x86/pci/common.c 2007-12-11 11:27:35.0 -0800 @@ -109,6 +109,19 @@ static void

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-05 Thread Gary Hade
On Wed, Dec 05, 2007 at 10:18:24AM -0500, Jun'ichi Nomura wrote: > Gary Hade wrote: > > On Tue, Dec 04, 2007 at 06:23:32PM -0500, Jun'ichi Nomura wrote: > >> Kernel always tries to. But it's best effort basis, IMO. > >> (Maybe your patch is going to fix that?)

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-05 Thread Gary Hade
On Wed, Dec 05, 2007 at 10:18:24AM -0500, Jun'ichi Nomura wrote: Gary Hade wrote: On Tue, Dec 04, 2007 at 06:23:32PM -0500, Jun'ichi Nomura wrote: Kernel always tries to. But it's best effort basis, IMO. (Maybe your patch is going to fix that?) If you are seeing the allocation failures

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Gary Hade
On Tue, Dec 04, 2007 at 06:23:32PM -0500, Jun'ichi Nomura wrote: > Hi Gary, > > Gary Hade wrote: > > On Tue, Dec 04, 2007 at 02:35:48PM -0500, Jun'ichi Nomura wrote: > >> On a system with PCI-to-PCI bridges, following errors are observed: > >> > >> PCI:

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Gary Hade
the kernel always tries to allocate memory for expansion ROMs which it also exports to user level. I have assumed that some drivers or user level apps may need to access this space. Is this not true? If this is due to my change, sorry for the trouble. Thanks, Gary -- Gary Hade System x Enablement IBM Li

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Gary Hade
which it also exports to user level. I have assumed that some drivers or user level apps may need to access this space. Is this not true? If this is due to my change, sorry for the trouble. Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Gary Hade
On Tue, Dec 04, 2007 at 06:23:32PM -0500, Jun'ichi Nomura wrote: Hi Gary, Gary Hade wrote: On Tue, Dec 04, 2007 at 02:35:48PM -0500, Jun'ichi Nomura wrote: On a system with PCI-to-PCI bridges, following errors are observed: PCI: Failed to allocate mem resource #8:[EMAIL PROTECTED

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-30 Thread Gary Hade
pci_slot debug=1 > # modprobe acpiphp debug=1 Someone else is using the system right now so I may not be able to do this until next week. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc -

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-30 Thread Gary Hade
debug=1 # modprobe acpiphp debug=1 Someone else is using the system right now so I may not be able to do this until next week. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscribe from

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-28 Thread Gary Hade
On Wed, Nov 28, 2007 at 04:02:38PM -0800, Kristen Carlson Accardi wrote: > On Wed, 28 Nov 2007 13:31:47 -0800 > Gary Hade <[EMAIL PROTECTED]> wrote: > > > FYI, the node contains 2 hotpluggable PCIe slots and 5 > > non-hotpluggable PCIe slots but 'pci_slot' only exp

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-28 Thread Gary Hade
On Tue, Nov 27, 2007 at 11:11:36AM -0800, Kristen Carlson Accardi wrote: > On Mon, 26 Nov 2007 19:04:54 -0800 > Gary Hade <[EMAIL PROTECTED]> wrote: > > > > Is this patchset appropriate for the -mm tree yet? > > > > I would defer to our illustrious maintain

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-28 Thread Gary Hade
On Tue, Nov 27, 2007 at 11:11:36AM -0800, Kristen Carlson Accardi wrote: On Mon, 26 Nov 2007 19:04:54 -0800 Gary Hade [EMAIL PROTECTED] wrote: Is this patchset appropriate for the -mm tree yet? I would defer to our illustrious maintainers on this one. :) Or do you think

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-28 Thread Gary Hade
On Wed, Nov 28, 2007 at 04:02:38PM -0800, Kristen Carlson Accardi wrote: On Wed, 28 Nov 2007 13:31:47 -0800 Gary Hade [EMAIL PROTECTED] wrote: FYI, the node contains 2 hotpluggable PCIe slots and 5 non-hotpluggable PCIe slots but 'pci_slot' only exposed the 2 hotpluggable slots

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-11-27 Thread Gary Hade
at I found that a second of the systems I'm > regularly dealing with also has similar problems. I'm just not normally > looking at the boot messages that closely. Sounds like I better get to work. :) Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-11-27 Thread Gary Hade
that has that patch backported. Thanks! I'd also like to note that I found that a second of the systems I'm regularly dealing with also has similar problems. I'm just not normally looking at the boot messages that closely. Sounds like I better get to work. :) Thanks, Gary -- Gary Hade System x

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-26 Thread Gary Hade
On Mon, Nov 26, 2007 at 03:22:53PM -0700, Alex Chiang wrote: > Hi Gary, Kenji-san, et. al, > > * Gary Hade <[EMAIL PROTECTED]>: > > > > Alex, What I was trying to suggest is a boot-time kernel > > option, not a kernel configuration option. The basic idea is &g

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-11-26 Thread Gary Hade
On Mon, Nov 26, 2007 at 02:15:45PM -0800, Greg KH wrote: > On Mon, Nov 26, 2007 at 01:59:54PM -0800, Gary Hade wrote: > > Greg, > > Without a closer look at the code and the information I > > requested above I am not 100% certain that my expansion ROM > > allocation fix

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-11-26 Thread Gary Hade
l that the possible regression that Jan reported is more important than the issue I was trying to solve feel free to remove the change until I can come up with something better. Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTE

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-11-26 Thread Gary Hade
with something better. Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc Jan PCI: Using ACPI for IRQ routing PCI: If a device doesn't work, try pci=routeirq. If it helps, post a report PCI

Re: Avoid creating P2P prefetch window for expansion ROMs

2007-11-26 Thread Gary Hade
On Mon, Nov 26, 2007 at 02:15:45PM -0800, Greg KH wrote: On Mon, Nov 26, 2007 at 01:59:54PM -0800, Gary Hade wrote: Greg, Without a closer look at the code and the information I requested above I am not 100% certain that my expansion ROM allocation fix is incomplete but it seems pretty

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-26 Thread Gary Hade
On Mon, Nov 26, 2007 at 03:22:53PM -0700, Alex Chiang wrote: Hi Gary, Kenji-san, et. al, * Gary Hade [EMAIL PROTECTED]: Alex, What I was trying to suggest is a boot-time kernel option, not a kernel configuration option. The basic idea is to give the user (with a single binary kernel

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-20 Thread Gary Hade
On Tue, Nov 20, 2007 at 02:04:02AM +, Matthew Garrett wrote: > On Mon, Nov 19, 2007 at 03:32:25PM -0800, Gary Hade wrote: > > > Alex, What I was trying to suggest is a boot-time kernel option, > > not a kernel configuration option. The basic idea is to give > >

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-20 Thread Gary Hade
On Tue, Nov 20, 2007 at 02:04:02AM +, Matthew Garrett wrote: On Mon, Nov 19, 2007 at 03:32:25PM -0800, Gary Hade wrote: Alex, What I was trying to suggest is a boot-time kernel option, not a kernel configuration option. The basic idea is to give the user (with a single binary kernel

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-19 Thread Gary Hade
oth PCI-X and PCIe adapters. Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-19 Thread Gary Hade
adapters. Thanks, Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-15 Thread Gary Hade
ng a PCI topology that appears similar to some of our systems. < snip > > Here is some dmesg and lspci -vt output in case you want to > double-check my work: Well, I didn't see any obvious warts but I'm pretty skilled at missing problems when looking at that kind of info. Thanks, G

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-15 Thread Gary Hade
to some of our systems. snip Here is some dmesg and lspci -vt output in case you want to double-check my work: Well, I didn't see any obvious warts but I'm pretty skilled at missing problems when looking at that kind of info. Thanks, Gary -- Gary Hade System x Enablement IBM Linux

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Gary Hade
On Tue, Nov 13, 2007 at 06:37:32PM -0700, Alex Chiang wrote: > Hi Gary, > > * Gary Hade <[EMAIL PROTECTED]>: > > On Tue, Nov 13, 2007 at 01:11:02PM -0700, Matthew Wilcox wrote: > > > On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote: > > > > Ok, ag

Re: [PATCH 0/5, v2] Physical PCI slot objects

2007-11-14 Thread Gary Hade
ing you haven't considered. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EM

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Gary Hade
On Wed, Nov 14, 2007 at 07:42:37AM -0700, Alex Chiang wrote: > Hi Gary, > > * Gary Hade <[EMAIL PROTECTED]>: > > > > I am not fundamentally opposed to this new capability but share > > the same concerns that Greg and others have expressed. So far, > > I ha

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Gary Hade
On Wed, Nov 14, 2007 at 07:42:37AM -0700, Alex Chiang wrote: Hi Gary, * Gary Hade [EMAIL PROTECTED]: I am not fundamentally opposed to this new capability but share the same concerns that Greg and others have expressed. So far, I have only tried the changes on one single node system

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Gary Hade
On Tue, Nov 13, 2007 at 06:37:32PM -0700, Alex Chiang wrote: Hi Gary, * Gary Hade [EMAIL PROTECTED]: On Tue, Nov 13, 2007 at 01:11:02PM -0700, Matthew Wilcox wrote: On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote: Ok, again, I want to see the IBM people sign off on this, after

Re: [PATCH 0/5, v2] Physical PCI slot objects

2007-11-14 Thread Gary Hade
was using and may not be able to get back on it until early next week. I think I will go ahead and send you the comments in response to your earlier message that I was going to hold off on until I tried your revised patches. It may contain something you haven't considered. Gary -- Gary Hade

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-13 Thread Gary Hade
expressed. So far, I have only tried the changes on one single node system (IBM x3850) but the below NAK-worthy result supports the idea that the changes need to be well and widely tested. Have you possibly considered a kernel option as a kinder and gentler way of introducing the changes?

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-13 Thread Gary Hade
node system (IBM x3850) but the below NAK-worthy result supports the idea that the changes need to be well and widely tested. Have you possibly considered a kernel option as a kinder and gentler way of introducing the changes? Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Gary Hade
use all 8 slots for bus 0. > and transparent bus under it only can copy 5 of them. Yea, with the current fixed size pci_bus resource array I believe you would need to increase PCI_BUS_NUM_RESOURCES from 8 to 11 for the transparent bridge child bus to get all 8 _CRS returned resources. Ga

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Gary Hade
cation certainly makes sense. Note that exposure to this issue is currently limited to those that use the 'pci=use_crs' kernel option. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscri

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Gary Hade
=use_crs' kernel option. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Gary Hade
PCI_BUS_NUM_RESOURCES from 8 to 11 for the transparent bridge child bus to get all 8 _CRS returned resources. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 [EMAIL PROTECTED] http://www.ibm.com/linux/ltc - To unsubscribe from this list: send the line unsubscribe