Re: [PATCH] perf tools: Fix JIT profiling on heap

2014-01-22 Thread Gaurav Jain
> On Jan 17, 2014, at 2:44 AM, "Namhyung Kim" wrote: > > Hi Gaurav, > >> On Thu, 16 Jan 2014 20:23:27 +, Gaurav Jain wrote: >> On 1/16/14, 9:37 AM, "Arnaldo Carvalho de Melo" >> wrote: >> Does perf support data mappings from perf map

Re: [PATCH] perf tools: Fix JIT profiling on heap

2014-01-16 Thread Gaurav Jain
On 1/16/14, 9:37 AM, "Arnaldo Carvalho de Melo" wrote: >Em Thu, Jan 16, 2014 at 10:49:31AM +0900, Namhyung Kim escreveu: >> Gaurav reported that perf cannot profile JIT program if it executes >> the code on heap. This was because current map__new() only handle JIT >> on anon mappings - extends i

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-15 Thread Gaurav Jain
Hi Namhyung, > On Jan 15, 2014, at 8:01 PM, "Namhyung Kim" wrote: > > Hi Gaurav, > >> On Wed, 15 Jan 2014 06:44:39 +, Gaurav Jain wrote: >> Hi Namhyung, >> >> >>> On 1/15/14, 12:46 AM, "Namhyung Kim" wrote: >>

Perf map file ownership check

2014-01-15 Thread Gaurav Jain
981c125 introduced a permission check on perf map files such that perf only loads the map file if it has ownership. Pekka mentioned that this prevents the perf tool from injecting arbitrary symbols from potentially malicious source. In our workload, the code generating the map file is running as

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-14 Thread Gaurav Jain
Hi Namhyung, On 1/15/14, 12:46 AM, "Namhyung Kim" wrote: >I'd like to take my ack back - it seems I missed some points. No worries, looks like the patch wasn’t well thought out. >On Tue, 14 Jan 2014 20:48:23 +, Gaurav Jain wrote: >> On 1/13/14, 11:54 AM, "

Re: [PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-14 Thread Gaurav Jain
On 1/13/14, 11:54 AM, "Don Zickus" wrote: >On Sat, Jan 11, 2014 at 08:32:14PM -0800, Gaurav Jain wrote: >> Anon records usually do not have the 'execname' entry. However if they >>are on >> the heap, the execname shows up as '[heap]'. The fix co

[PATCH] perf tools: Synthesize anon MMAP records on the heap

2014-01-11 Thread Gaurav Jain
This fixes JIT profiling for records on the heap. Signed-off-by: Gaurav Jain Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Don Zickus Cc: Arun Sharma --- tools/perf/util/event.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/