Re: [PATCH net-next 1/7] net: stmmac: set MSS for each tx DMA channel

Hi Niklas I had a look at this series that looks ok for me. Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> On 2/19/2018 6:11 PM, Niklas Cassel wrote: The DMA engine in dwmac4 can segment a large TSO packet to several smaller packets of (max) size Maximum Segment Size (MSS). T

Re: [PATCH net-next 1/7] net: stmmac: set MSS for each tx DMA channel

Hi Niklas I had a look at this series that looks ok for me. Acked-by: Giuseppe Cavallaro On 2/19/2018 6:11 PM, Niklas Cassel wrote: The DMA engine in dwmac4 can segment a large TSO packet to several smaller packets of (max) size Maximum Segment Size (MSS). The DMA engine fetches and saves

Re: [PATCH net-next v2] net: stmmac: Fix reception of Broadcom switches tags

). To be as little invasive as possible, this is only done for gmac1000 when the network device is DSA-enabled (netdev_uses_dsa() returns true). Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- Changes in v2: - fixed b

Re: [PATCH net-next v2] net: stmmac: Fix reception of Broadcom switches tags

). To be as little invasive as possible, this is only done for gmac1000 when the network device is DSA-enabled (netdev_uses_dsa() returns true). Signed-off-by: Florian Fainelli Acked-by: Giuseppe Cavallaro --- Changes in v2: - fixed build failure in dwmac4_core.c - updated dwmac100_core.c

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hello On 10/27/2017 11:05 AM, Jose Abreu wrote: I think we should take advantage of the fact that this is working and ready to be merged. Its just HW configuration but maybe it can serve as momentum for other drivers to also integrate this? Let me propose to have it now in the next-next.

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hello On 10/27/2017 11:05 AM, Jose Abreu wrote: I think we should take advantage of the fact that this is working and ready to be merged. Its just HW configuration but maybe it can serve as momentum for other drivers to also integrate this? Let me propose to have it now in the next-next.

Re: [PATCH] net: ethernet: stmmac: Convert timers to use

On 10/5/2017 2:50 AM, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Giuseppe Cavallaro <peppe.cavall...@st.com> Cc: Ale

Re: [PATCH] net: ethernet: stmmac: Convert timers to use

On 10/5/2017 2:50 AM, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: net

Re: [PATCH 3/3] net: stmmac: Make 'alloc_dma_[rt]x_desc_resources()' look even closer

.fr> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/s

Re: [PATCH 3/3] net: stmmac: Make 'alloc_dma_[rt]x_desc_resources()' look even closer

On 7/8/2017 9:46 AM, Christophe JAILLET wrote: 'alloc_dma_[rt]x_desc_resources()' functions look very close. Remove a useless initialization and use the same label name for error handling path in order to get them even closer. Signed-off-by: Christophe JAILLET Acked-by: Giuseppe Cavallaro

Re: [PATCH 2/3] net: stmmac: Fix error handling path in 'alloc_dma_tx_desc_resources()'

he JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/e

Re: [PATCH 2/3] net: stmmac: Fix error handling path in 'alloc_dma_tx_desc_resources()'

he JAILLET Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 4322fa4a13e8..07d486a70

Re: [PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc_resources()'

he JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/e

Re: [PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc_resources()'

he JAILLET Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 19bba6281dab..4322fa4a1

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

as...@axis.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ma

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

lly reaches the next last descriptor, which actually has the bit set, the DMA will hang. When the DMA hangs, we get a tx timeout, however, since stmmac does not do a complete reset of the IP in stmmac_tx_timeout, we end up in a state with completely hung TX. Signed-off-by: Niklas Cassel Acked-b

Re: Stmmac: fix for hw timestamp of GMAC 3 unit

Hi Mario thanks for your tests, and, at first glance, your patches seem to be sensible so, please, send the changes as patches for net.git kernel. Regards Peppe On 6/6/2017 12:11 AM, Mario Molitor wrote: Dear stmmac maintainer group, I have found an problem in stmmac driver of linux

Re: Stmmac: fix for hw timestamp of GMAC 3 unit

Hi Mario thanks for your tests, and, at first glance, your patches seem to be sensible so, please, send the changes as patches for net.git kernel. Regards Peppe On 6/6/2017 12:11 AM, Mario Molitor wrote: Dear stmmac maintainer group, I have found an problem in stmmac driver of linux

Re: [PATCH] net: ethernet: stmmac: Fix altr_tse_pcs SGMII Initialization

for this fix. Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c b/drivers/net/ethernet/stmicro/stmmac/al

Re: [PATCH] net: ethernet: stmmac: Fix altr_tse_pcs SGMII Initialization

On 5/31/2017 9:28 PM, thor.tha...@linux.intel.com wrote: From: Thor Thayer Fix NETDEV WATCHDOG timeout on startup by adding missing register writes that properly setup SGMII. Signed-off-by: Thor Thayer Thanks a lot for this fix. Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet

Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations

main.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>

Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations

file changed, 10 insertions(+), 12 deletions(-) Acked-by: Giuseppe Cavallaro

Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt

irq"; + interrupts = <24 23 22>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = []; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii"; Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>

Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt

+ interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = [0000]; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii"; Acked-by: Giuseppe Cavallaro

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

e used for a single packet, the field should be set to the sum of the buffers contained in: [ ... ... ], which should be equal to skb->len. Signed-off-by: Niklas Cassel <niklas.cas...@axis.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmm

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

should be set to the sum of the buffers contained in: [ ... ... ], which should be equal to skb->len. Signed-off-by: Niklas Cassel Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 6 +++--- drivers/net/ethernet/stmicro/stmmac/common.h

Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt

Hi Niklas On 4/10/2017 9:43 AM, Niklas Cassel wrote: From: Niklas Cassel The hardware has a LPI interrupt. There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding. i wonder if we could

Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt

Hi Niklas On 4/10/2017 9:43 AM, Niklas Cassel wrote: From: Niklas Cassel The hardware has a LPI interrupt. There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding. i wonder if we could improve the comments in

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

Hi Niklas patch looks ok for me, Alex any feedback? peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

Hi Niklas patch looks ok for me, Alex any feedback? peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 4/3/2017 3:12 PM, Joao Pinto wrote: Yes older cores do not support multiple queues and I tried to isolate the features not to affect older versions. ok so we are inline ;-) Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of influence? I do not think

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 4/3/2017 3:12 PM, Joao Pinto wrote: Yes older cores do not support multiple queues and I tried to isolate the features not to affect older versions. ok so we are inline ;-) Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of influence? I do not think

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 3/30/2017 6:42 PM, Joao Pinto wrote: Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 3/30/2017 6:42 PM, Joao Pinto wrote: Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

Hello Alex do you can check if this has to be done for ST platforms? I do not remember that it was necessary when build as module so I cannot expect this should be only for dwmac-sun8i. Regards peppe On 4/3/2017 11:14 AM, Corentin Labbe wrote: Thoses symbol will be needed for the

Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

Hello Alex do you can check if this has to be done for ST platforms? I do not remember that it was necessary when build as module so I cannot expect this should be only for dwmac-sun8i. Regards peppe On 4/3/2017 11:14 AM, Corentin Labbe wrote: Thoses symbol will be needed for the

Re: [PATCH v3 02/20] net: stmmac: add optional setup function

Hello Corentin On 4/3/2017 11:14 AM, Corentin Labbe wrote: Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe ---

Re: [PATCH v3 02/20] net: stmmac: add optional setup function

Hello Corentin On 4/3/2017 11:14 AM, Corentin Labbe wrote: Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote: Hello On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using in order for me to reproduce >in my side? Joao, you have a

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote: Hello On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using in order for me to reproduce >in my side? Joao, you have a

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Hello On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using in order for me to reproduce >in my side? Joao, you have a really powerful HW integration with multiple channels for

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Hello On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using in order for me to reproduce >in my side? Joao, you have a really powerful HW integration with multiple channels for

Re: linux-next-20170320 break stmmac on dwmac-sunxi

Hello Corentin yes, bisect process is really good approach to me. Pls give us more details. Recently the multi DMA channel logic has been added so it could be that something is needed to allow your platform to manage the new code. Or we introduced some regression. If I have some other idea, I

Re: linux-next-20170320 break stmmac on dwmac-sunxi

Hello Corentin yes, bisect process is really good approach to me. Pls give us more details. Recently the multi DMA channel logic has been added so it could be that something is needed to allow your platform to manage the new code. Or we introduced some regression. If I have some other idea, I

Re: linux-next-20170320 break stmmac on dwmac-sunxi

+ Joao please Joao, could you do a check if new changes have any impact on that? peppe On 3/20/2017 8:54 PM, Corentin Labbe wrote: Hello Just pushed next-20170320 to my boards and stmmac stop working on both intree dwmac-sunxi and my dev dwmac-sun8i. It seems that interrupts never fire, and

Re: linux-next-20170320 break stmmac on dwmac-sunxi

+ Joao please Joao, could you do a check if new changes have any impact on that? peppe On 3/20/2017 8:54 PM, Corentin Labbe wrote: Hello Just pushed next-20170320 to my boards and stmmac stop working on both intree dwmac-sunxi and my dev dwmac-sun8i. It seems that interrupts never fire, and

Re: [PATCH RFC] net: stmmac: unify registers dumps methods

regs" to "fill the reg_space used by ethtool". Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Thx I find it really useful, Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- .../net/ethernet

Re: [PATCH RFC] net: stmmac: unify registers dumps methods

regs" to "fill the reg_space used by ethtool". Signed-off-by: Corentin Labbe Thx I find it really useful, Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 10 +-- .../net/eth

Re: [PATCH 0/8] net: stmmac: misc patchs

On 2/15/2017 8:39 AM, Corentin Labbe wrote: Since all patch in v2 already hit linux-next, I just want to be sure, I can add "Acked-by and Reviewed-by" to thoses 8 new patchs ? Right I have just seen the V2 patches are in net-next. pls consider, for this set, my Acked-by: Giuseppe

Re: [PATCH 0/8] net: stmmac: misc patchs

On 2/15/2017 8:39 AM, Corentin Labbe wrote: Since all patch in v2 already hit linux-next, I just want to be sure, I can add "Acked-by and Reviewed-by" to thoses 8 new patchs ? Right I have just seen the V2 patches are in net-next. pls consider, for this set, my Acked-by: Giuseppe

Re: [PATCH 0/8] net: stmmac: misc patchs

Hello Corentin On 2/14/2017 8:54 PM, Corentin Labbe wrote: Hello This is a follow up of my previous stmmac serie which address some comment done in v2. I wonder if you can resend all the patches as V3 please add the Acked-by and Reviewed-by. This will help on final review and integration.

Re: [PATCH 0/8] net: stmmac: misc patchs

Hello Corentin On 2/14/2017 8:54 PM, Corentin Labbe wrote: Hello This is a follow up of my previous stmmac serie which address some comment done in v2. I wonder if you can resend all the patches as V3 please add the Acked-by and Reviewed-by. This will help on final review and integration.

Re: [PATCH v2 13/16] net: stmmac: print phy information

On 2/8/2017 9:31 AM, Corentin Labbe wrote: When a PHY is found, printing which one was found (and which type/model) is a good information to know. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/

Re: [PATCH v2 13/16] net: stmmac: print phy information

On 2/8/2017 9:31 AM, Corentin Labbe wrote: When a PHY is found, printing which one was found (and which type/model) is a good information to know. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +--- 1 file changed, 1

Re: [PATCH v2 08/16] net: stmmac: Use readl_poll_timeout

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The dwmac_dma_reset function use an open coded of readl_poll_timeout(). Replace the open coded handling with the proper function. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall.

Re: [PATCH v2 08/16] net: stmmac: Use readl_poll_timeout

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The dwmac_dma_reset function use an open coded of readl_poll_timeout(). Replace the open coded handling with the proper function. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 14

Re: [PATCH v2 10/16] net: stmmac: Correct the error message about invalid speed

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The message about invalid speed does not state 1000 as a valid speed. It is much simpler to said that the speed is invalid. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>

Re: [PATCH v2 10/16] net: stmmac: Correct the error message about invalid speed

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The message about invalid speed does not state 1000 as a valid speed. It is much simpler to said that the speed is invalid. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3

Re: [PATCH v2 04/16] net: stmmac: remove freesoftware address

On 2/8/2017 9:31 AM, Corentin Labbe wrote: This patch fix the checkpatch warning about free software address. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> just wonder if this should be sent separately for net-next instead of Anyway... Acked-by: Giuseppe Cavallaro <pep

Re: [PATCH v2 04/16] net: stmmac: remove freesoftware address

On 2/8/2017 9:31 AM, Corentin Labbe wrote: This patch fix the checkpatch warning about free software address. Signed-off-by: Corentin Labbe just wonder if this should be sent separately for net-next instead of Anyway... Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro

Re: [PATCH v2 02/16] net: stmmac: Remove the bus_setup function pointer

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The bus_setup function pointer is not used at all, this patch remove it. no longer used... Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall.

Re: [PATCH v2 02/16] net: stmmac: Remove the bus_setup function pointer

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The bus_setup function pointer is not used at all, this patch remove it. no longer used... Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Re: stmmac: GMAC_RGSMIIIS reports bogus values

Hello Alexey On 1/31/2017 2:24 PM, Alexey Brodkin wrote: Hi Giuseppe, On Tue, 2017-01-31 at 10:55 +0100, Giuseppe CAVALLARO wrote: On 1/27/2017 11:23 AM, Alexey Brodkin wrote: That's why my initial proposal was to ignore whatever we read from this register if we have MDIO bus instantiated

Re: stmmac: GMAC_RGSMIIIS reports bogus values

Hello Alexey On 1/31/2017 2:24 PM, Alexey Brodkin wrote: Hi Giuseppe, On Tue, 2017-01-31 at 10:55 +0100, Giuseppe CAVALLARO wrote: On 1/27/2017 11:23 AM, Alexey Brodkin wrote: That's why my initial proposal was to ignore whatever we read from this register if we have MDIO bus instantiated

Re: [PATCH 15/17] net: stmmac: remove dead code in stmmac_tx_clean

...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3

Re: [PATCH 15/17] net: stmmac: remove dead code in stmmac_tx_clean

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Since commit cf32deec16e4 ("stmmac: add tx_skbuff_dma to save descriptors used by PTP"), the struct dma_desc *p in stmmac_tx_clean was not used at all. This patch remove this dead code. Signed-off-by: Corentin Labbe Acked-by: Giuseppe

Re: [PATCH 03/17] net: stmmac: fix some typos in comments

On 1/31/2017 10:11 AM, Corentin Labbe wrote: This patch fix some typos in comments. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 6 +++--- drivers/

Re: [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout

On 1/31/2017 11:39 AM, Corentin Labbe wrote: On Tue, Jan 31, 2017 at 11:13:49AM +0100, Giuseppe CAVALLARO wrote: On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac_mdio_busy_wait() function do the same job than readl_poll_timeout(). So is is better to replace it. Signed-off-by: Corentin

Re: [PATCH 03/17] net: stmmac: fix some typos in comments

On 1/31/2017 10:11 AM, Corentin Labbe wrote: This patch fix some typos in comments. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 6 +++--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16

Re: [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout

On 1/31/2017 11:39 AM, Corentin Labbe wrote: On Tue, Jan 31, 2017 at 11:13:49AM +0100, Giuseppe CAVALLARO wrote: On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac_mdio_busy_wait() function do the same job than readl_poll_timeout(). So is is better to replace it. Signed-off-by: Corentin

Re: [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout

re SMA block is used if yes, pls consider my: Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 33 --- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmm

Re: [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout

consider my: Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 33 --- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

Re: [PATCH 01/17] net: stmmac: fix the typo on MAC_RNABLE_RX

On 1/31/2017 10:11 AM, Corentin Labbe wrote: the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/common.h| 2

Re: [PATCH 01/17] net: stmmac: fix the typo on MAC_RNABLE_RX

On 1/31/2017 10:11 AM, Corentin Labbe wrote: the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/common.h| 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 4 ++-- 2

Re: [PATCH 00/17] net: stmmac: misc fix

On 1/31/2017 11:23 AM, Joao Pinto wrote: Hi Peppe, Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: Hello Corentin On 1/31/2017 10:11 AM, Corentin Labbe wrote: Hello I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. This serie is the result of all minor

Re: [PATCH 00/17] net: stmmac: misc fix

On 1/31/2017 11:23 AM, Joao Pinto wrote: Hi Peppe, Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: Hello Corentin On 1/31/2017 10:11 AM, Corentin Labbe wrote: Hello I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. This serie is the result of all minor

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac driver run TX completion under NAPI but without checking the work done by the TX completion function. This patch add work/budget to the TX completion function. The visible effect is that it keep the driver longer under NAPI and boost

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac driver run TX completion under NAPI but without checking the work done by the TX completion function. This patch add work/budget to the TX completion function. The visible effect is that it keep the driver longer under NAPI and boost

Re: [PATCH 17/17] net: stmmac: replace unsigned by u32

On 1/31/2017 10:11 AM, Corentin Labbe wrote: checkpatch complains about two unsigned without type after. Since the value return is u32, it is simpler to replace it by u32 instead of "unsigned int" Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Gi

Re: [PATCH 17/17] net: stmmac: replace unsigned by u32

On 1/31/2017 10:11 AM, Corentin Labbe wrote: checkpatch complains about two unsigned without type after. Since the value return is u32, it is simpler to replace it by u32 instead of "unsigned int" Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/ne

Re: [PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The u64 x variable in sysfs_display_ring is unused. This patch remove it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> well spot Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/st

Re: [PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The u64 x variable in sysfs_display_ring is unused. This patch remove it. Signed-off-by: Corentin Labbe well spot Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 --- 1 file changed, 3 deletions

Re: [PATCH 14/17] net: stmmac: print phy information

On 1/31/2017 10:11 AM, Corentin Labbe wrote: When a PHY is found, printing which one was found (and which type/model) is a good information to know. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1

Re: [PATCH 14/17] net: stmmac: print phy information

On 1/31/2017 10:11 AM, Corentin Labbe wrote: When a PHY is found, printing which one was found (and which type/model) is a good information to know. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 12/17] net: stmmac: rename rx_crc to rx_crc_errors

Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 +- drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 +- drivers/

Re: [PATCH 12/17] net: stmmac: rename rx_crc to rx_crc_errors

Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 +- drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 +- drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 2 +- drivers/net

Re: [PATCH 10/17] net: stmmac: Correct the error message about invalid speed

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Add 1000 as a valid speed in the error message about invalid speed in stmmac_adjust_link() Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 10/17] net: stmmac: Correct the error message about invalid speed

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Add 1000 as a valid speed in the error message about invalid speed in stmmac_adjust_link() Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 11/17] net: stmmac: Rewrite two test against NULL value

On 1/31/2017 10:11 AM, Corentin Labbe wrote: This patch rewrite two test against NULL value with correct style. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Re: [PATCH 11/17] net: stmmac: Rewrite two test against NULL value

On 1/31/2017 10:11 AM, Corentin Labbe wrote: This patch rewrite two test against NULL value with correct style. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

On 1/31/2017 10:11 AM, Corentin Labbe wrote: As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing else. This patch replace ENOSYS by the more appropriate value EINVAL. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall.

Re: [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

On 1/31/2017 10:11 AM, Corentin Labbe wrote: As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing else. This patch replace ENOSYS by the more appropriate value EINVAL. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac

Re: [PATCH 06/17] net: stmmac: fix some code style problem

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Checkpatch complains about some code style problem on stmmac_mdio.c. This patch fix them. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/st

Re: [PATCH 06/17] net: stmmac: fix some code style problem

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Checkpatch complains about some code style problem on stmmac_mdio.c. This patch fix them. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 --- 1 file changed, 4 insertions

Re: [PATCH 02/17] net: stmmac: Remove the bus_setup function pointer

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The bus_setup function pointer is not used at all, this patch remove it. indeed this was used and documented on some previous kernels where some ST40/SH4 platforms (w/o DT). It's ok to remove it in the new MAC generation; I do not think that ST

Re: [PATCH 02/17] net: stmmac: Remove the bus_setup function pointer

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The bus_setup function pointer is not used at all, this patch remove it. indeed this was used and documented on some previous kernels where some ST40/SH4 platforms (w/o DT). It's ok to remove it in the new MAC generation; I do not think that ST

Re: [PATCH 00/17] net: stmmac: misc fix

Hello Corentin On 1/31/2017 10:11 AM, Corentin Labbe wrote: Hello I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. This serie is the result of all minor problem found in the stmmac driver. thank for this effort, many changes are to tidy up some part of the code so

Re: [PATCH 00/17] net: stmmac: misc fix

Hello Corentin On 1/31/2017 10:11 AM, Corentin Labbe wrote: Hello I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. This serie is the result of all minor problem found in the stmmac driver. thank for this effort, many changes are to tidy up some part of the code so

  1   2   3   4   >