Re: [PATCH] extcon: max77693: Add extra IRQF_ONESHOT

2019-07-26 Thread Gomonovych, Vasyl
Sorry, my bad, I have missed disabling place, and positive feedback for max in other thread and push me to send it. On Thu, Jul 25, 2019 at 9:23 AM Krzysztof Kozlowski wrote: > > On Thu, 25 Jul 2019 at 08:37, Vasyl Gomonovych wrote: > > > > Do not fire irq again until thread done > > This issue

Re: [PATCH v2] misc: mic: Use memdup_user() as a cleanup

2017-12-12 Thread Gomonovych, Vasyl
Hi, Thanks. Should I prepare fix patch only for missed label? Regards Vasyl. On Tue, Dec 12, 2017 at 12:49 PM, Greg KH wrote: > On Tue, Dec 12, 2017 at 11:40:58AM +0100, Vasyl Gomonovych wrote: >> Fix coccicheck warning which recommends to use memdup_user(): >> >> drivers/misc/mic/vop/vop_vringh

Re: [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR_ERR'

2017-12-07 Thread Gomonovych, Vasyl
Hi, Guys sorry for this idiotic piece of code. Yesterday after doc seq_file.txt read I did not catch real way of work there. And made this shit. Sorry. Regards Vasyl On Fri, Dec 8, 2017 at 12:26 AM, Al Viro wrote: > On Thu, Dec 07, 2017 at 11:23:26PM +, Al Viro wrote: >> On Fri, Dec 08, 201

Re: [PATCH] KVM: arm: Use PTR_ERR_OR_ZERO()

2017-12-04 Thread Gomonovych, Vasyl
Hi Christoffer It is just syntax sugar of course and in mentioned function context it looks harmonically because it is in the end of function return statement. But in context of around source files it is looks not so harmonically because existing code uses old approach. And this old approach is on

Re: [PATCH] VMCI: Use memdup_user() as a cleanup

2017-11-22 Thread Gomonovych, Vasyl
I am agree, I will change it. On Wed, Nov 22, 2017 at 4:55 PM, Joe Perches wrote: > On Wed, 2017-11-22 at 16:29 +0100, Vasyl Gomonovych wrote: >> Fix coccicheck warning which recommends to use memdup_user(): >> drivers/misc/vmw_vmci/vmci_host.c:757:11-18: WARNING opportunity for >> memdup_user >