Re: [RESEND v2] iommu/vt-d: Use passthrough mode for the Intel IPUs

2021-04-20 Thread Grant Grundler
U passthrough mode for Intel IPUs. > > I think a factor here is that the page tables aren't accessible by the IPU > firmware. Correct. At least not accessible through the system IOMMU. This is why Intel prefers the IPU to bypass the system IOMMU. cheers, grant > > > > > F

Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-06 Thread Grant Grundler
bout the "can do 2.5Gbps?" question by looking at the CDC Ethernet Networking Functional Descriptor (USBECM12) and other CDC specs. The spec feels like a "compatibility wrapper" to make a cellular modem look like an ethernet device. This statement in the ECM120.pdf I have suggests we can not determine media layer: The effect of a "reset" on the device physical layer is media-dependent and beyond the scope of this specification. cheers, grant

RE: [PATCH v2 0/7] perf arm-spe: Enable timestamp

2021-04-06 Thread Al Grant
> -Original Message- > From: Leo Yan > Sent: 03 April 2021 08:24 > To: Arnaldo Carvalho de Melo ; John Garry > ; Will Deacon ; Mathieu Poirier > ; James Clark ; Al Grant > ; Peter Zijlstra ; Ingo Molnar > ; Mark Rutland ; Alexander > Shishkin ; Jiri Ols

Re: [PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Grant Grundler
On Tue, Apr 6, 2021 at 12:09 AM Andrew Lunn wrote: > > On Mon, Apr 05, 2021 at 04:13:40PM -0700, Grant Grundler wrote: > > This series introduces support for USB network devices that report > > speed as a part of their protocol, not emulating an MII to be accessed > &g

Re: [PATCHv4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Grant Grundler
On Tue, Mar 30, 2021 at 2:17 AM Grant Grundler wrote: > > This series introduces support for USB network devices that report > speed as a part of their protocol, not emulating an MII to be accessed > over MDIO. > > v2: rebased on recent upstream changes > v3: incorpo

[PATCH net-next v4 3/4] net: cdc_ncm: record speed in status method

2021-04-05 Thread Grant Grundler
replaces the one recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 : "net: usb: cdc_ncm: don't spew notifications" v2: rebased on upstream v3: changed variable names v4: rewrote commit message Signed-off-by: Oliver Neukum Tested-by: Roland Dreier Signed-off-by: Gran

[PATCH net-next v4 4/4] net: cdc_ether: record speed in status method

2021-04-05 Thread Grant Grundler
framework to use the new functions to get link speed/state. User space can now get the most recent link speed/state using ethtool. v4: added to series since cdc_ether uses same notifications as cdc_ncm driver. Signed-off-by: Grant Grundler Reviewed-by: Andrew Lunn --- drivers/net/usb

[PATCH net-next v4 2/4] usbnet: add method for reporting speed without MII

2021-04-05 Thread Grant Grundler
on upstream v3: changed names and made clear which units are used v4: moved hunks to correct patch; rewrote commmit messages Signed-off-by: Oliver Neukum Tested-by: Roland Dreier Reviewed-by: Grant Grundler Tested-by: Grant Grundler Reviewed-by: Andrew Lunn --- drivers/net/usb/usbnet.c | 23

[PATCH net-next v4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings

2021-04-05 Thread Grant Grundler
rename the existing functions with _mii suffix. v2: rebased on changed upstream v3: changed names to clearly say that this does NOT use phylib v4: moved hunks to correct patch; reworded commmit messages Signed-off-by : Oliver Neukum Tested-by: Roland Dreier Reviewed-by: Grant Grundler Tested

[PATCH net-next v4 0/4] usbnet: speed reporting for devices without MDIO

2021-04-05 Thread Grant Grundler
This series introduces support for USB network devices that report speed as a part of their protocol, not emulating an MII to be accessed over MDIO. v2: rebased on recent upstream changes v3: incorporated hints on naming and comments v4: fix misplaced hunks; reword some commit messages; add

[PATCHv4 3/4] net: cdc_ncm: record speed in status method

2021-03-29 Thread Grant Grundler
replaces the one recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 : "net: usb: cdc_ncm: don't spew notifications" v2: rebased on upstream v3: changed variable names v4: rewrote commit message Signed-off-by: Oliver Neukum Tested-by: Roland Dreier Signed-off-by: Gran

[PATCHv4 4/4] net: cdc_ether: record speed in status method

2021-03-29 Thread Grant Grundler
From: Grant Grundler Until very recently, the usbnet framework only had support functions for devices which reported the link speed by explicitly querying the PHY over a MDIO interface. However, the cdc_ether devices send notifications when the link state or link speeds change and do not expose

[PATCHv4 2/4] usbnet: add method for reporting speed without MII

2021-03-29 Thread Grant Grundler
on upstream v3: changed names and made clear which units are used v4: moved hunks to correct patch; rewrote commmit messages Signed-off-by: Oliver Neukum Tested-by: Roland Dreier Reviewed-by: Grant Grundler Tested-by: Grant Grundler --- drivers/net/usb/usbnet.c | 23

[PATCHv4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings

2021-03-29 Thread Grant Grundler
rename the existing functions with _mii suffix. v2: rebased on changed upstream v3: changed names to clearly say that this does NOT use phylib v4: moved hunks to correct patch; reworded commmit messages Signed-off-by : Oliver Neukum Tested-by: Roland Dreier Reviewed-by: Grant Grundler Tested

[PATCHv4 0/4] usbnet: speed reporting for devices without MDIO

2021-03-29 Thread Grant Grundler
This series introduces support for USB network devices that report speed as a part of their protocol, not emulating an MII to be accessed over MDIO. v2: rebased on recent upstream changes v3: incorporated hints on naming and comments v4: fix misplaced hunks; reword some commit messages; add

[PATCH net-next] net: usb: log errors to dmesg/syslog

2021-03-06 Thread Grant Grundler
Errors in protocol should be logged when the driver aborts operations. If the driver can carry on and "humor" the device, then emitting the message as debug output level is fine. Signed-off-by: Grant Grundler --- drivers/net/usb/usbnet.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net-next] net: usb: cdc_ncm: emit dev_err on error paths

2021-03-06 Thread Grant Grundler
Several error paths in bind/probe code will only emit output using dev_dbg. But if we are going to fail the bind/probe, emit related output with "err" priority. Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH net] net: usb: cdc_ncm: don't spew notifications

2021-03-04 Thread Grant Grundler
On Wed, Jan 20, 2021 at 5:04 PM Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 03:38:32 + Hayes Wang wrote: > > Grant Grundler > > > Sent: Wednesday, January 20, 2021 9:12 AM > > > Subject: [PATCH net] net: usb: cdc_ncm: don't spew notifications > > >

RE: [PATCH V3 14/14] coresight: etm-perf: Add support for trace buffer format

2021-01-27 Thread Al Grant
> > +/* CoreSight PMU AUX buffer formats */ > > +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT 0x /* > Default for backward compatibility */ > > +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW 0x0100 /* > Raw format of the source */ > > Would CORESIGHT_FORMAT_ETR /

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
On Wed, Jan 20, 2021 at 1:05 AM Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote: > > > > Thanks for the patch, this looks like an improvement over: > > > > > > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected&q

[PATCH net] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
ink ... Chrome OS cannot support RTL8156 until this is fixed. Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ncm.c | 12 +++- include/linux/usb/usbnet.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c in

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
On Wed, Jan 20, 2021 at 12:55 AM Grant Grundler wrote: > > On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote: > > > > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote: > > > RTL8156 sends notifications about every 32ms. > > > Only display/log

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-19 Thread Grant Grundler
On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote: > > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote: > > RTL8156 sends notifications about every 32ms. > > Only display/log notifications when something changes. > > > > This issue has been repor

RE: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Al Grant
> From: Suzuki K Poulose > On 1/19/21 9:51 AM, Sai Prakash Ranjan wrote: > > Hi Al, > > > > On 2021-01-19 14:06, Al Grant wrote: > >> Hi Sai, > >> > >>> From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > >>>

RE: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2021-01-19 Thread Al Grant
Hi Sai, > From: saiprakash.ranjan=codeaurora@mg.codeaurora.org > Hi Mathieu, > > On 2021-01-19 01:53, Mathieu Poirier wrote: > > On Fri, Jan 15, 2021 at 11:16:24AM +0530, Sai Prakash Ranjan wrote: > >> Hello Mathieu, Suzuki > >> > >> On 2020-10-15 21:32, Mathieu Poirier wrote: > >> > On Thu,

Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote: > > RTL8156 sends notifications about every 32ms. > Only display/log notifications when something changes. > > This issue has been reported by others: > https://

Re: [PATCH 2/3] net: usb: log errors to dmesg/syslog

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote: > > Errors in protocol should be logged when the driver aborts operations. > If the driver can carry on and "humor" the device, then emitting > the message as debu

Re: [PATCH 1/3] net: usb: cdc_ncm: emit dev_err on error paths

2021-01-18 Thread Grant Grundler
+nic_swsd [adding per Realtek developer team request] On Sat, Jan 16, 2021 at 5:26 AM Grant Grundler wrote: > > Several error paths in bind/probe code will only emit > output using dev_dbg. But if we are going to fail the > bind/probe, emit related output with "err" pr

[PATCH 1/3] net: usb: cdc_ncm: emit dev_err on error paths

2021-01-15 Thread Grant Grundler
Several error paths in bind/probe code will only emit output using dev_dbg. But if we are going to fail the bind/probe, emit related output with "err" priority. Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletion

[PATCH 3/3] net: usb: cdc_ncm: don't spew notifications

2021-01-15 Thread Grant Grundler
ink ... Chrome OS cannot support RTL8156 until this is fixed. Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ncm.c | 12 +++- include/linux/usb/usbnet.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c in

[PATCH 2/3] net: usb: log errors to dmesg/syslog

2021-01-15 Thread Grant Grundler
Errors in protocol should be logged when the driver aborts operations. If the driver can carry on and "humor" the device, then emitting the message as debug output level is fine. Signed-off-by: Grant Grundler --- drivers/net/usb/usbnet.c | 2 +- 1 file changed, 1 insertion(+),

RE: [PATCH v2] drivers/perf: Enable PID_IN_CONTEXTIDR with SPE

2021-01-07 Thread Al Grant
> From: Mark Rutland > Sent: 06 January 2021 10:24 > To: James Clark > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > perf-us...@vger.kernel.org; w...@kernel.org; leo@linaro.org; Al Grant > ; John Garry ; Suzuki Poulose > ; Mathie

Re: [PATCH v1] spi: fix client driver breakages when using GPIO descriptors

2020-11-25 Thread Grant Likely
On 18/11/2020 11:40, Mark Brown wrote: On Wed, Nov 18, 2020 at 02:03:41AM +0100, Linus Walleij wrote: On Mon, Nov 16, 2020 at 10:06 PM Mark Brown wrote: I think the main push in the other direction has always been people who want to not have to write a driver at all and put absolutely

Re: [PATCH v1] spi: fix client driver breakages when using GPIO descriptors

2020-11-25 Thread Grant Likely
ing all predates my involvement so I don't know the thought process here. I dug out some details, let's see if Grant has some historical anecdotes to add. The usage document from back then doesn't really say what device properties should be encoded in the device tree and what should just be assigne

[PATCH] perf inject: correct event attribute sizes

2020-11-24 Thread Al Grant
When perf inject reads a perf.data file from an older version of perf, it writes event attributes into the output with the original size field, but lays them out as if they had the size currently used. Readers see a corrupt file. Update the size field to match the layout. Signed-off-by: Al Grant

[tip: perf/urgent] perf: correct SNOOPX field offset

2020-10-19 Thread tip-bot2 for Al Grant
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: f3d301c1f2f5676465cdf3259737ea19cc82731f Gitweb: https://git.kernel.org/tip/f3d301c1f2f5676465cdf3259737ea19cc82731f Author:Al Grant AuthorDate:Mon, 21 Sep 2020 21:46:37 +01:00 Committer

[tip: perf/urgent] perf: correct SNOOPX field offset

2020-10-19 Thread tip-bot2 for Al Grant
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 04de3266214453deb5f1d7849a66313e351af8cc Gitweb: https://git.kernel.org/tip/04de3266214453deb5f1d7849a66313e351af8cc Author:Al Grant AuthorDate:Mon, 21 Sep 2020 21:46:37 +01:00 Committer

Re: [net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio

2020-10-08 Thread Grant Likely
On 08/10/2020 15:47, Calvin Johnson wrote: Better place for of_mdio.c is drivers/net/mdio. Move of_mdio.c from drivers/of to drivers/net/mdio Signed-off-by: Calvin Johnson In-Principle-Acked-By: Grant Likely ... but I've not tested or compiled *anything*! g. --- MAINTAINERS

Re: [net-next PATCH v1 6/7] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2020-10-02 Thread Grant Likely
On 30/09/2020 17:04, Calvin Johnson wrote: Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Use helper function

Re: [net-next PATCH v1 1/7] Documentation: ACPI: DSD: Document MDIO PHY

2020-10-02 Thread Grant Likely
On 30/09/2020 17:37, Rafael J. Wysocki wrote: On Wed, Sep 30, 2020 at 6:05 PM Calvin Johnson wrote: Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. Describe properties "phy-handle" and "phy-mode". Signed-off-by: Calvin Johnson ---

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-10-02 Thread Grant Likely
On 30/09/2020 17:04, Calvin Johnson wrote: Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson --- drivers/net/phy/phy_device.c | 32 +++-

Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id()

2020-10-02 Thread Grant Likely
On 01/10/2020 05:00, Calvin Johnson wrote: On Wed, Sep 30, 2020 at 08:19:02PM +0200, Andrew Lunn wrote: On Wed, Sep 30, 2020 at 07:07:25PM +0100, Russell King - ARM Linux admin wrote: On Wed, Sep 30, 2020 at 06:34:40PM +0200, Andrew Lunn wrote: @@ -2866,7 +2888,15 @@

[PATCH] perf: correct SNOOPX field offset

2020-09-21 Thread Al Grant
tools: Add support for printing new mem_info encodings") Signed-off-by: Al Grant Reviewed-by: Andi Kleen --- include/uapi/linux/perf_event.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 07

Re: [PATCH v3 1/2] leds: is31fl319x: Add shutdown pin and generate a 5ms low pulse when startup

2020-09-11 Thread Grant Feng
Thanks for the info. Best regards,                                                 Grant On 2020-09-09 17:18, Pavel Machek wrote: On Tue 2020-08-25 16:22:05, Grant Feng wrote: generate a 5ms low pulse on shutdown pin when startup, then the chip becomes more stable in the complex EM

Re: [PATCH 1/1] of: properties of reserved-memory nodes

2020-09-10 Thread Grant Likely
On 10/09/2020 17:20, Heinrich Schuchardt wrote: The reusable and the no-map property are mutually exclusive. Clarify this in the documentation. Signed-off-by: Heinrich Schuchardt Acked-by: Grant Likely --- .../devicetree/bindings/reserved-memory/reserved-memory.txt| 3 +++ 1

Re: Apply from 2018? [V2,0/3] phy: qcom-ipq4019-usb: add new driver

2020-09-08 Thread Grant Grundler
Adding linux-...@vger.kernel.org since Andy's email in MAINTAINERs bounced. Using Matthew's personal email since his codeaurora email bounced. On Mon, Sep 7, 2020 at 11:35 PM Grant Grundler wrote: > > Alban, Andy, > Can you please apply this patch series from 2018 or please explain

Apply from 2018? [V2,0/3] phy: qcom-ipq4019-usb: add new driver

2020-09-08 Thread Grant Grundler
-documen.patch ... In 2018, Rob Herring reviewed (and approved): [V2,1/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document I've just reviewed 2/3 and 3/3. You can add to those: Reviewed-by: Grant Grundler I compared 3/3 with the DTS entries that were submitted (and I approved) to chromeos

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Al Grant
On 01/09/2020 16:02, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote

RE: [RFC PATCH v2] coresight: etm4x: Modify core-commit of cpu to avoid the overflow of HiSilicon ETM

2020-08-28 Thread Al Grant
Hi Mathieu and CS maintainers, > Hi Liu, > > On Wed, Aug 19, 2020 at 04:06:37PM +0800, Qi Liu wrote: > > When too much trace information is generated on-chip, the ETM will > > overflow, and cause data loss. This is a common phenomenon on ETM > > devices. > > > > But sometimes we do not want to

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Al Grant
On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE

Re: [PATCH] perf inject: correct event attribute sizes

2020-08-26 Thread Al Grant
On 26/08/2020 12:27, Mark Rutland wrote: On Wed, Aug 26, 2020 at 10:42:04AM +0100, Al Grant wrote: When perf inject reads a perf.data file from an older version of perf, it writes event attributes into the output with the original size field, but lays them out as if they had the size currently

[PATCH] perf inject: correct event attribute sizes

2020-08-26 Thread Al Grant
Signed-off-by: Al Grant tools/perf/util/header.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 9cf4efdcbbbd..762eb94bd532 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -3326,6 +3326,14 @@ int

[PATCH v3 1/2] leds: is31fl319x: Add shutdown pin and generate a 5ms low pulse when startup

2020-08-25 Thread Grant Feng
generate a 5ms low pulse on shutdown pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng --- drivers/leds/leds-is31fl319x.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers

[PATCH v3 2/2] DT: leds: Add an optional property named 'shutdown-gpios'

2020-08-25 Thread Grant Feng
The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree/bindings/leds/leds-is31fl319x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v3 2/2] leds: Add an optional property named 'shutdown-gpios'

2020-08-25 Thread Grant Feng
The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation

[PATCH v3 1/2] leds: is31fl32xx: Add shutdown pin and generate a 5ms low pulse when startup

2020-08-25 Thread Grant Feng
generate a 5ms low pulse on shutdown pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng --- drivers/leds/leds-is31fl32xx.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds

Re: [PATCH v2 2/2] leds: Add an optional property named 'sdb-gpios'

2020-08-25 Thread Grant Feng
On 2020-08-25 6:21, Rob Herring wrote: On Sat, Aug 08, 2020 at 11:37:31AM +0800, Grant Feng wrote: The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree

[PATCH] perf: correct SNOOPX field offset

2020-08-24 Thread Al Grant
perf_event.h has macros that define the field offsets in the data_src bitmask in perf records. The SNOOPX and REMOTE offsets were both 37. These are distinct fields, and the bitfield layout in perf_mem_data_src confirms that SNOOPX should be at offset 38. From: Al Grant include/uapi/linux

RE: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228

2020-08-11 Thread Grant Peltier
Ah, my apologies. Duly noted for the future. Thanks for catching it. Grant -Original Message- From: Guenter Roeck On Behalf Of Guenter Roeck Sent: Tuesday, August 11, 2020 12:17 PM To: Grant Peltier Cc: Grant Peltier ; linux-kernel@vger.kernel.org; Adam Vaughn Subject: Re: [PATCH

[PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228

2020-08-10 Thread Grant Peltier
Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported PMBus command. Signed-off-by: Grant Peltier --- drivers/hwmon/pmbus/isl68137.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c index

[PATCH v2 1/2] leds: is31fl319x: Add sdb pin and generate a 5ms low pulse when startup

2020-08-07 Thread Grant Feng
generate a 5ms low pulse on sdb pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng --- drivers/leds/leds-is31fl319x.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds

[PATCH v2 2/2] leds: Add an optional property named 'sdb-gpios'

2020-08-07 Thread Grant Feng
The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree/bindings/leds/leds-is31fl319x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v2 1/2] leds: is31fl32xx: Add sdb pin and generate a 5ms low pulse when startup

2020-08-07 Thread Grant Feng
generate a 5ms low pulse on sdb pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng --- drivers/leds/leds-is31fl32xx.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds

[PATCH v2 2/2] leds: Add an optional property named 'sdb-gpios'

2020-08-07 Thread Grant Feng
The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation

Re: [PATCH 1/2] leds: is31fl319x: Add sdb pin and generate a 5ms low pulse when startup

2020-08-07 Thread Grant Feng
Thanks for the review, I will rewrit it. Grant On 2020-08-06 23:00, Dan Murphy wrote: Grant On 8/6/20 1:21 AM, Grant Feng wrote: generate a 5ms low pulse on sdb pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng ---   drivers/leds

[PATCH 1/2] leds: is31fl319x: Add sdb pin and generate a 5ms low pulse when startup

2020-08-06 Thread Grant Feng
generate a 5ms low pulse on sdb pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng --- drivers/leds/leds-is31fl319x.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds

[PATCH 2/2] DT: leds: Add an optional property named 'sdb-gpios'

2020-08-06 Thread Grant Feng
The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree/bindings/leds/leds-is31fl319x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH] leds: Add an optional property named 'sdb-gpios'

2020-08-05 Thread Grant Feng
The chip enters hardware shutdown when the SDB pin is pulled low. The chip releases hardware shutdown when the SDB pin is pulled high. Signed-off-by: Grant Feng --- Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation

[PATCH v1] leds: is31fl32xx: Add sdb pin and generate a 5ms low pulse when startup

2020-08-03 Thread Grant Feng
generate a 5ms low pulse on sdb pin when startup, then the chip becomes more stable in the complex EM environment. Signed-off-by: Grant Feng --- drivers/leds/leds-is31fl32xx.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-is31fl32xx.c b

[PATCH] hid-input: Fix devices that return multiple bytes in battery report

2020-07-10 Thread Grant Likely
. The fix isn't particularly elegant, but it is simple and safe to backport to stable kernels. A further patch will follow to more elegantly handle battery reports that contain additional data. Signed-off-by: Grant Likely Cc: Darren Hart Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: sta

Dear Friend,

2020-06-10 Thread paul grant
.. your Date of birth.. your Marital Status. your Occupation. Thanks Mr Grant Paul Thanks Grant Paul

[PATCH v2 0/1] hwmon: (adt7475) Convert to use hwmon_device_register_with_groups()

2019-07-21 Thread Grant McEwan
necessary with new API. - Replaced goto eremove calls, with simple returns. - Removed .remove function. Grant McEwan (1): hwmon: (adt7475) Convert to use hwmon_device_register_with_groups() drivers/hwmon/adt7475.c | 146 ++-- 1 file changed, 50 insertions

[PATCH v2 1/1] hwmon: (adt7475) Convert to use hwmon_device_register_with_groups()

2019-07-21 Thread Grant McEwan
hwmon_device_register() is a deprecated function and produces a warning. Converting the driver to use the hwmon_device_register_with_groups() instead. Signed-off-by: Grant McEwan --- drivers/hwmon/adt7475.c | 146 ++-- 1 file changed, 50 insertions(+), 96

Re: Loan grant @affordable rate

2019-06-05 Thread Loan Grant
Hello Dear, We are a large Company based in Istanbul Turkey and we offers flexible loans and funding for all projects for as low as 2% interest rate per annum for a period of 5-15 yrs . We invite you to partner with us and benefit in our new Loan and Project funding program. We can approve

Re: [PATCH v2] tty/serial: Add a serial port simulator

2019-03-29 Thread Grant Edwards
pect to talk to a serial port which fail miserably when connected to a pty. -- Grant Edwards grant.b.edwardsYow! I had a lease on an at OEDIPUS COMPLEX back in gmail.com'81 ...

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Grant Grundler
On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee wrote: > > >-Original Message- > >From: Mark Brown > >Sent: Wednesday, November 28, 2018 1:50 AM > >To: Ryan Lee > >Cc: Liam Girdwood ; Jaroslav Kysela > >; Takashi Iwai ; Grant Grundler > >; Kun

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Grant Grundler
On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee wrote: > > >-Original Message- > >From: Mark Brown > >Sent: Wednesday, November 28, 2018 1:50 AM > >To: Ryan Lee > >Cc: Liam Girdwood ; Jaroslav Kysela > >; Takashi Iwai ; Grant Grundler > >; Kun

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
I just realized I had one more question... On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote: > > Hi Ryan! > > Just some questions inline - in general I like the reset function. > > On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee > wrote: > > > > Signed-off-b

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
I just realized I had one more question... On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote: > > Hi Ryan! > > Just some questions inline - in general I like the reset function. > > On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee > wrote: > > > > Signed-off-b

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
> { > struct max98373_priv *max98373 = dev_get_drvdata(dev); > > - regmap_write(max98373->regmap, > - MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET); > - usleep_range(1, 11000); > + max98373_reset(max98373, dev); > regcache_cache_only(max98373->regmap, false); > regcache_sync(max98373->regmap); > return 0; > -- > 2.7.4 > cheers, grant

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
> { > struct max98373_priv *max98373 = dev_get_drvdata(dev); > > - regmap_write(max98373->regmap, > - MAX98373_R2000_SW_RESET, MAX98373_SOFT_RESET); > - usleep_range(1, 11000); > + max98373_reset(max98373, dev); > regcache_cache_only(max98373->regmap, false); > regcache_sync(max98373->regmap); > return 0; > -- > 2.7.4 > cheers, grant

Re: [PATCH v1 1/5] drivercore: Revert "deferral race condition fix"

2018-11-14 Thread Grant Likely
On 11/11/2018 19:26, Rob Herring wrote: > On Sun, Nov 11, 2018 at 7:04 AM Andy Shevchenko > wrote: >> >> I seems Grant's mail delivery bounces messages. I delibirately reduced >> the Cc list for sake of ping Grant in case it would pass. > > That would be becau

Re: [PATCH v1 1/5] drivercore: Revert "deferral race condition fix"

2018-11-14 Thread Grant Likely
On 11/11/2018 19:26, Rob Herring wrote: > On Sun, Nov 11, 2018 at 7:04 AM Andy Shevchenko > wrote: >> >> I seems Grant's mail delivery bounces messages. I delibirately reduced >> the Cc list for sake of ping Grant in case it would pass. > > That would be becau

RE: Question: perf dso support for /proc/kallsyms

2018-11-02 Thread Al Grant
> root@debian:~/coresight_test# perf buildid-list > 0242d9154c78df1d8fe1d0512c36a236d0861a18 [kernel.kallsyms] > b8c89e8ba41a2ea486c66a50c29c60d38c34a759 /root/coresight_test/main > 26b12a9d1a54ed2b0478cb0203435b76aabab3fb /usr/lib/aarch64-linux-gnu/ld- > 2.27.so >

RE: Question: perf dso support for /proc/kallsyms

2018-11-02 Thread Al Grant
> root@debian:~/coresight_test# perf buildid-list > 0242d9154c78df1d8fe1d0512c36a236d0861a18 [kernel.kallsyms] > b8c89e8ba41a2ea486c66a50c29c60d38c34a759 /root/coresight_test/main > 26b12a9d1a54ed2b0478cb0203435b76aabab3fb /usr/lib/aarch64-linux-gnu/ld- > 2.27.so >

RE: Question: perf dso support for /proc/kallsyms

2018-11-02 Thread Al Grant
> Now I still don't understand how the dso/map support "/proc/kallsyms" and > have no idea to fix this issue, though I spent some time to look into it. The way this is supported is that at record time, pseudo mmap records are created for the kernel. But depending on permissions these might not

RE: Question: perf dso support for /proc/kallsyms

2018-11-02 Thread Al Grant
> Now I still don't understand how the dso/map support "/proc/kallsyms" and > have no idea to fix this issue, though I spent some time to look into it. The way this is supported is that at record time, pseudo mmap records are created for the kernel. But depending on permissions these might not

Re: drivers binding to device node with multiple compatible strings

2018-10-04 Thread Grant Likely
On 04/10/2018 10:32, Grant Likely wrote: On Fri, Sep 28, 2018 at 10:01 PM Li Yang wrote: On Fri, Sep 28, 2018 at 3:07 PM Rob Herring wrote: On Thu, Sep 27, 2018 at 5:25 PM Li Yang wrote: Hi Rob and Grant, Various device tree specs are recommending to include all the potential

Re: drivers binding to device node with multiple compatible strings

2018-10-04 Thread Grant Likely
On 04/10/2018 10:32, Grant Likely wrote: On Fri, Sep 28, 2018 at 10:01 PM Li Yang wrote: On Fri, Sep 28, 2018 at 3:07 PM Rob Herring wrote: On Thu, Sep 27, 2018 at 5:25 PM Li Yang wrote: Hi Rob and Grant, Various device tree specs are recommending to include all the potential

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote: > > On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > > > Note that this isn't causing a warning upstream, presumably due to an > > > impl

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown wrote: > > On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote: > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: > > > > Note that this isn't causing a warning upstream, presumably due to an > > > impl

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
[resending as plain/text - sorry] On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote: > > > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: >> >> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: >> > Commit ca917f9f

Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-07 Thread Grant Grundler
[resending as plain/text - sorry] On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler wrote: > > > > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown wrote: >> >> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote: >> > Commit ca917f9f

[PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-06 Thread Grant Grundler
f function 'usleep_range' [-Werror,-Wimplicit-function-declaration] usleep_range(1, 11000); ^ Including delay.h "fixes" this. Signed-off-by: Grant Grundler --- sound/soc/codecs/max98373.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/max98373.

[PATCH] ASoC: max98373: usleep_range() needs include/delay.h

2018-09-06 Thread Grant Grundler
f function 'usleep_range' [-Werror,-Wimplicit-function-declaration] usleep_range(1, 11000); ^ Including delay.h "fixes" this. Signed-off-by: Grant Grundler --- sound/soc/codecs/max98373.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/max98373.

Re: [PATCH] efi_stub: update documentation on dtb= parameter

2018-09-06 Thread Grant Likely
> On 6 Sep 2018, at 16:51, Jonathan Corbet wrote: > > On Wed, 5 Sep 2018 20:07:50 +0100 > Grant Likely wrote: > >> The dtb= parameter is no longer the primary mechanism for providing a >> devicetree to the kernel. Now either firmware or the boot selector (

Re: [PATCH] efi_stub: update documentation on dtb= parameter

2018-09-06 Thread Grant Likely
> On 6 Sep 2018, at 16:51, Jonathan Corbet wrote: > > On Wed, 5 Sep 2018 20:07:50 +0100 > Grant Likely wrote: > >> The dtb= parameter is no longer the primary mechanism for providing a >> devicetree to the kernel. Now either firmware or the boot selector (

Re: [PATCH] arm64: defconfig: enable EFI_ARMSTUB_DTB_LOADER

2018-09-05 Thread Grant Likely
On Wed, Sep 5, 2018 at 10:37 AM Ard Biesheuvel wrote: > On 4 September 2018 at 12:13, Grant Likely wrote: > > On Tue, Sep 4, 2018 at 7:24 AM Ard Biesheuvel > > wrote: > >> > >> On 2 September 2018 at 04:54, Olof Johansson wrote: > >> > On

Re: [PATCH] arm64: defconfig: enable EFI_ARMSTUB_DTB_LOADER

2018-09-05 Thread Grant Likely
On Wed, Sep 5, 2018 at 10:37 AM Ard Biesheuvel wrote: > On 4 September 2018 at 12:13, Grant Likely wrote: > > On Tue, Sep 4, 2018 at 7:24 AM Ard Biesheuvel > > wrote: > >> > >> On 2 September 2018 at 04:54, Olof Johansson wrote: > >> > On

Re: [PATCH] arm64: defconfig: enable EFI_ARMSTUB_DTB_LOADER

2018-09-05 Thread Grant Likely
On Wed, Sep 5, 2018 at 6:27 PM Scott Branden wrote: > > > > On 18-09-05 02:40 AM, Ard Biesheuvel wrote: > > On 4 September 2018 at 19:19, Scott Branden > > wrote: > >> Rather than introduce EFI_ARMSTUB_DTB_LOADER, why not have > >> the efistub use CONFIG_OF to determine whether it supports dtb=

  1   2   3   4   5   6   7   8   9   10   >