Re: [PATCH v3 1/2] of: Rename poweroff-source property to system-power-controller

2014-11-11 Thread Grant Likely
On Thu, 6 Nov 2014 14:23:02 + , Romain Perier romain.per...@gmail.com wrote: It reverts commit a4b4e0461ec5 (of: Add standard property for poweroff capability). As discussed on the mailing list, it makes more sense to rename back to the old established property name, without the vendor

[GIT PULL] Devicetree bug fix for v3.18

2014-11-08 Thread Grant Likely
) Devicetree bugfix for v3.18 One buffer overflow bug that shouldn't be left around. Grant Likely (1): of: Fix overflow bug in string property parsing functions drivers/of/base.c | 88

[GIT PULL] Devicetree bug fix for v3.18

2014-11-08 Thread Grant Likely
) Devicetree bugfix for v3.18 One buffer overflow bug that shouldn't be left around. Grant Likely (1): of: Fix overflow bug in string property parsing functions drivers/of/base.c | 88

Re: [PATCH v2 0/2] pinctrl: Intel Cherryview/Braswell support

2014-11-06 Thread Grant Likely
On Wed, Nov 5, 2014 at 10:15 PM, Rafael J. Wysocki wrote: > On Wednesday, November 05, 2014 09:46:14 PM Grant Likely wrote: >> On Tue, Nov 4, 2014 at 5:54 PM, Timur Tabi wrote: >> > On 11/04/2014 02:20 AM, Mika Westerberg wrote: >> >> >> >> Th

Re: [PATCH 3/5] of: Only call notifiers when node is attached

2014-11-06 Thread Grant Likely
On Thu, Nov 6, 2014 at 12:33 PM, Pantelis Antoniou wrote: > Hi Grant, > >> On Nov 5, 2014, at 23:39 , Grant Likely wrote: >> >> On Tue, 28 Oct 2014 22:33:51 +0200 >> , Pantelis Antoniou >> wrote: >>> Make sure we call notifier only when the node is

Re: [PATCH 4/5] of: Add old prop argument on OF_RECONFIG_UPDATE_PROPERTY

2014-11-06 Thread Grant Likely
On Wed, Nov 5, 2014 at 8:08 PM, Pantelis Antoniou wrote: > Hi Grant, > >> On Nov 5, 2014, at 22:01 , Grant Likely wrote: >> >> On Tue, 28 Oct 2014 22:33:52 +0200 >> , Pantelis Antoniou >> wrote: >>> The notifier now includes the old_prop argument whe

Re: [PATCH v2 0/2] pinctrl: Intel Cherryview/Braswell support

2014-11-06 Thread Grant Likely
On Wed, Nov 5, 2014 at 10:15 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, November 05, 2014 09:46:14 PM Grant Likely wrote: On Tue, Nov 4, 2014 at 5:54 PM, Timur Tabi ti...@codeaurora.org wrote: On 11/04/2014 02:20 AM, Mika Westerberg wrote: There is nothing like that yet

Re: [PATCH 4/5] of: Add old prop argument on OF_RECONFIG_UPDATE_PROPERTY

2014-11-06 Thread Grant Likely
On Wed, Nov 5, 2014 at 8:08 PM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Grant, On Nov 5, 2014, at 22:01 , Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 28 Oct 2014 22:33:52 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: The notifier now includes

Re: [PATCH 3/5] of: Only call notifiers when node is attached

2014-11-06 Thread Grant Likely
On Thu, Nov 6, 2014 at 12:33 PM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Hi Grant, On Nov 5, 2014, at 23:39 , Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 28 Oct 2014 22:33:51 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Make sure we call

Re: [PATCH v2 0/2] pinctrl: Intel Cherryview/Braswell support

2014-11-05 Thread Grant Likely
On Tue, Nov 4, 2014 at 5:54 PM, Timur Tabi wrote: > On 11/04/2014 02:20 AM, Mika Westerberg wrote: >> >> There is nothing like that yet in ACPI world but with the ACPI _DSD >> patches we are getting properties similar to DT which means that we can >> provide pinctrl bindings from ACPI systems as

Re: [PATCH 3/5] of: Only call notifiers when node is attached

2014-11-05 Thread Grant Likely
On Tue, 28 Oct 2014 22:33:51 +0200 , Pantelis Antoniou wrote: > Make sure we call notifier only when the node is attached. > When a detatched tree is being constructed we do not want the > notifiers to fire at all. The description does not match what the patch does. The patch moves the test

Re: [PATCH 5/5] of: of_reconfig_get_state_change() of notifier helper.

2014-11-05 Thread Grant Likely
On Tue, 28 Oct 2014 22:33:53 +0200 , Pantelis Antoniou wrote: > Introduce of_reconfig_get_state_change() which allows an of notifier > to query about device state changes. > > Signed-off-by: Pantelis Antoniou Applied, thanks. g. > --- > drivers/of/dynamic.c | 96 >

Re: [PATCH 4/5] of: Add old prop argument on OF_RECONFIG_UPDATE_PROPERTY

2014-11-05 Thread Grant Likely
On Tue, 28 Oct 2014 22:33:52 +0200 , Pantelis Antoniou wrote: > The notifier now includes the old_prop argument when updating > properties, propagate this API to changeset internals while > also retaining the old behaviour of retrieving the old_property > when NULL is passed. > > Signed-off-by:

Re: [PATCH 1/1] of/fdt: simplify early_init_dt_verify

2014-11-05 Thread Grant Likely
On Wed, Nov 5, 2014 at 12:49 AM, leizhen wrote: > On 2014/11/5 1:03, Bjorn Helgaas wrote: >> On Tue, Nov 4, 2014 at 9:20 AM, Grant Likely wrote: >>> On Tue, 28 Oct 2014 19:51:05 +0800 >>> , Zhen Lei >>> wrote: >>>> put off initial_boot_pa

Re: [PATCH 1/1] of/fdt: simplify early_init_dt_verify

2014-11-05 Thread Grant Likely
On Wed, Nov 5, 2014 at 12:49 AM, leizhen thunder.leiz...@huawei.com wrote: On 2014/11/5 1:03, Bjorn Helgaas wrote: On Tue, Nov 4, 2014 at 9:20 AM, Grant Likely grant.lik...@linaro.org wrote: On Tue, 28 Oct 2014 19:51:05 +0800 , Zhen Lei thunder.leiz...@huawei.com wrote: put off

Re: [PATCH 4/5] of: Add old prop argument on OF_RECONFIG_UPDATE_PROPERTY

2014-11-05 Thread Grant Likely
On Tue, 28 Oct 2014 22:33:52 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: The notifier now includes the old_prop argument when updating properties, propagate this API to changeset internals while also retaining the old behaviour of retrieving the old_property when NULL is

Re: [PATCH 5/5] of: of_reconfig_get_state_change() of notifier helper.

2014-11-05 Thread Grant Likely
On Tue, 28 Oct 2014 22:33:53 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Introduce of_reconfig_get_state_change() which allows an of notifier to query about device state changes. Signed-off-by: Pantelis Antoniou pantelis.anton...@konsulko.com Applied, thanks. g. ---

Re: [PATCH 3/5] of: Only call notifiers when node is attached

2014-11-05 Thread Grant Likely
On Tue, 28 Oct 2014 22:33:51 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Make sure we call notifier only when the node is attached. When a detatched tree is being constructed we do not want the notifiers to fire at all. The description does not match what the patch does.

Re: [PATCH v2 0/2] pinctrl: Intel Cherryview/Braswell support

2014-11-05 Thread Grant Likely
On Tue, Nov 4, 2014 at 5:54 PM, Timur Tabi ti...@codeaurora.org wrote: On 11/04/2014 02:20 AM, Mika Westerberg wrote: There is nothing like that yet in ACPI world but with the ACPI _DSD patches we are getting properties similar to DT which means that we can provide pinctrl bindings from ACPI

Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

2014-11-04 Thread Grant Likely
On Tue, Nov 4, 2014 at 10:54 PM, Rafael J. Wysocki wrote: > On Tuesday, November 04, 2014 05:06:40 PM Rafael J. Wysocki wrote: >> On Tuesday, November 04, 2014 02:48:40 PM Grant Likely wrote: >> > On Mon, Nov 3, 2014 at 9:52 PM, Rafael J. Wysocki >> > wrote: >>

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki wrote: >> I also found that this parser code doesn't correctly handle malformed >> (unterminated) string properties. It will overflow. The existing >> functions have the same problem, so it isn't something that you've >> added. I've got a fix,

Re: [PATCH] of: Fix padding in _OF_DECLARE macro definition

2014-11-04 Thread Grant Likely
On Thu, 2 Oct 2014 16:01:10 +0200 , Thierry Reding wrote: > From: Thierry Reding > > Signed-off-by: Thierry Reding Applied, thanks. g. > --- > include/linux/of.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/of.h b/include/linux/of.h > index

Re: [PATCH 1/1] of: Add a function to read 64-bit arrays

2014-11-04 Thread Grant Likely
On Fri, 3 Oct 2014 00:59:23 +0300 , Sakari Ailus wrote: > Implement of_property_read_u64_array() for reading 64-bit arrays. > > This is needed for e.g. reading the valid link frequencies in the smiapp > driver. > > Signed-off-by: Sakari Ailus A patch that adds this function is alread part

Re: [PATCH 4/4] of: Remove spaces before tabs

2014-11-04 Thread Grant Likely
On Wed, 22 Oct 2014 11:44:55 +0200 , Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven Applied all 4 patches. Thanks. g. > --- > drivers/of/base.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/of/base.c b/drivers/of/base.c >

Re: [PATCH 1/1] of/fdt: simplify early_init_dt_verify

2014-11-04 Thread Grant Likely
On Tue, 28 Oct 2014 19:51:05 +0800 , Zhen Lei wrote: > put off initial_boot_params = params; until all checks finished. If any check > failed, initial_boot_params is equal NULL, base upon bss segment initial > value. > > Signed-off-by: Zhen Lei Interesting. I received exactly the same patch

Re: [PATCH] of/fdt: Don't clear initial_boot_params if fdt_check_header() fails

2014-11-04 Thread Grant Likely
On Wed, 29 Oct 2014 12:15:00 -0600 , Bjorn Helgaas wrote: > If the device tree pointer is NULL, early_init_dt_verify() fails, leaving > initial_boot_params unchanged. If the device tree pointer is non-NULL but > invalid, early_init_dt_verify() again fails but this time it also clears >

Re: [PATCH 0/1] Compact interface for Device-Tree

2014-11-04 Thread Grant Likely
On Mon, 03 Nov 2014 16:06:03 +0100 , Arnd Bergmann wrote: > On Friday 31 October 2014 23:53:28 Rafael J. Wysocki wrote: > > On Saturday, November 01, 2014 05:13:45 AM Rob Herring wrote: > > > On Fri, Oct 31, 2014 at 6:59 AM, Gilad Avidov > > > wrote: > > > > > > > > Device-Tree compact API > >

Re: [PATCH] of: Request and map make argument name constant

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 18:27:25 +0200 , Matthias Brugger wrote: > This patch makes the name argument from of_io_request_and_map constant. > > Signed-off-by: Matthias Brugger Applied, thanks. g. > --- > drivers/of/address.c | 2 +- > include/linux/of_address.h | 4 ++-- > 2 files

Re: [PATCH 1/3] of/irq: Export of_irq_get()

2014-11-04 Thread Grant Likely
I think it makes sense if I take this via I2C to get the dependencies > for the later patches right? Agreed. Acked-by: Grant Likely > > > --- > > drivers/of/irq.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c &

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 23:15:50 +0200 , "Rafael J. Wysocki" wrote: > From: "Rafael J. Wysocki" > > Add a uniform interface by which device drivers can request device > properties from the platform firmware by providing a property name > and the corresponding data type. The purpose of it is to

Re: [PATCH v6 00/12] Add ACPI _DSD and unified device properties support

2014-11-04 Thread Grant Likely
s > > available > > from the device-properties branch of the linux-pm.git tree: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git > > device-properties > > > > Thanks! > > Crickets ... > > OK, so I'm taking the

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Grant Likely
On Tue, Nov 4, 2014 at 2:38 PM, Mika Westerberg wrote: > On Tue, Nov 04, 2014 at 02:18:26PM +0000, Grant Likely wrote: >> > - strncpy(chip->name, np->name, sizeof(chip->name)); >> > + strncpy(chip->name, "at25", sizeof(chip->name)); >>

Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

2014-11-04 Thread Grant Likely
On Mon, Nov 3, 2014 at 9:52 PM, Rafael J. Wysocki wrote: > On Monday, November 03, 2014 04:25:08 PM Rafael J. Wysocki wrote: >> On Sunday, November 02, 2014 08:49:37 PM Darren Hart wrote: >> > >> > On 11/1/14 4:11, Grant Likely wrote: >> > > On Tue, 28 Oct

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Grant Likely
changes behaviour of the driver. It's possibly not a problem, but it should be commented on and whether any due diligance has been done to make sure it there isn't anything that depends on it. Otherwise: Acked-by: Grant Likely > > - if (of_property_read_u32(np, "size", ) ==

[PATCH 1/2] of/unittest: Remove test devices after adding them

2014-11-04 Thread Grant Likely
-by: Grant Likely --- drivers/of/selftest.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/of/selftest.c b/drivers/of/selftest.c index bf7d99317a94..082bb2b6a5ad 100644 --- a/drivers/of/selftest.c +++ b/drivers/of/selftest.c

[PATCH 2/2] of/unittest: Rename selftest.c to unittest.c

2014-11-04 Thread Grant Likely
This is unit testing code. It should use that name because it makes more sense than 'selftest'. Rename the files to match and rename the config variable. Signed-off-by: Grant Likely --- drivers/of/Kconfig | 4 +- drivers/of/Makefile| 4

Re: [PATCH] of: Fix overflow bug in string property parsing functions

2014-11-04 Thread Grant Likely
On Tue, 04 Nov 2014 01:43:24 +0100 , "Rafael J. Wysocki" wrote: > On Monday, November 03, 2014 11:38:24 PM Grant Likely wrote: > > [cut] > > > diff --git a/include/linux/of.h b/include/linux/of.h > > index 6545e7aec7bb..3b3c6e849ae8 100644 > > --- a/in

[PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-04 Thread Grant Likely
/devices/... path will be affected. It isn't /supposed/ to do that, but if anyone complains then I'll add a default-off workaround option to put them back into the root. Signed-off-by: Grant Likely Cc: Rob Herring Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Benjamin Herrenschmidt --- drivers

[PATCH] of/platform: Move platform devices under /sys/devices/platform

2014-11-04 Thread Grant Likely
a fixed /sys/devices/... path will be affected. It isn't /supposed/ to do that, but if anyone complains then I'll add a default-off workaround option to put them back into the root. Signed-off-by: Grant Likely grant.lik...@linaro.org Cc: Rob Herring robh...@kernel.org Cc: Arnd Bergmann a...@arndb.de Cc

Re: [PATCH] of: Fix overflow bug in string property parsing functions

2014-11-04 Thread Grant Likely
On Tue, 04 Nov 2014 01:43:24 +0100 , Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, November 03, 2014 11:38:24 PM Grant Likely wrote: [cut] diff --git a/include/linux/of.h b/include/linux/of.h index 6545e7aec7bb..3b3c6e849ae8 100644 --- a/include/linux/of.h +++ b/include

[PATCH 2/2] of/unittest: Rename selftest.c to unittest.c

2014-11-04 Thread Grant Likely
This is unit testing code. It should use that name because it makes more sense than 'selftest'. Rename the files to match and rename the config variable. Signed-off-by: Grant Likely grant.lik...@linaro.org --- drivers/of/Kconfig | 4 +- drivers/of/Makefile

[PATCH 1/2] of/unittest: Remove test devices after adding them

2014-11-04 Thread Grant Likely
-by: Grant Likely grant.lik...@linaro.org --- drivers/of/selftest.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/of/selftest.c b/drivers/of/selftest.c index bf7d99317a94..082bb2b6a5ad 100644 --- a/drivers/of/selftest.c +++ b

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Grant Likely
. It's possibly not a problem, but it should be commented on and whether any due diligance has been done to make sure it there isn't anything that depends on it. Otherwise: Acked-by: Grant Likely grant.lik...@linaro.org - if (of_property_read_u32(np, size, val) == 0

Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

2014-11-04 Thread Grant Likely
On Mon, Nov 3, 2014 at 9:52 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, November 03, 2014 04:25:08 PM Rafael J. Wysocki wrote: On Sunday, November 02, 2014 08:49:37 PM Darren Hart wrote: On 11/1/14 4:11, Grant Likely wrote: On Tue, 28 Oct 2014 22:59:57 +0100 , Rafael J

Re: [PATCH v6 04/12] misc: at25: Make use of device property API

2014-11-04 Thread Grant Likely
On Tue, Nov 4, 2014 at 2:38 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Tue, Nov 04, 2014 at 02:18:26PM +, Grant Likely wrote: - strncpy(chip-name, np-name, sizeof(chip-name)); + strncpy(chip-name, at25, sizeof(chip-name)); This line changes behaviour of the driver

Re: [PATCH v6 00/12] Add ACPI _DSD and unified device properties support

2014-11-04 Thread Grant Likely
work on top of it. So, if there still are no comments by Sunday evening, I'll add this series to my linux-next branch with 3.19-rc1 as the target. Aside from the comments I've made elsewhere, you can add my acked by for the whole series. Acked-by: Grant Likely grant.lik...@linaro.org g

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 23:15:50 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Add a uniform interface by which device drivers can request device properties from the platform firmware by providing a property name and the corresponding

Re: [PATCH 1/3] of/irq: Export of_irq_get()

2014-11-04 Thread Grant Likely
...@ideasonboard.com I think it makes sense if I take this via I2C to get the dependencies for the later patches right? Agreed. Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/of/irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index

Re: [PATCH] of: Request and map make argument name constant

2014-11-04 Thread Grant Likely
On Tue, 21 Oct 2014 18:27:25 +0200 , Matthias Brugger matthias@gmail.com wrote: This patch makes the name argument from of_io_request_and_map constant. Signed-off-by: Matthias Brugger matthias@gmail.com Applied, thanks. g. --- drivers/of/address.c | 2 +-

Re: [PATCH 0/1] Compact interface for Device-Tree

2014-11-04 Thread Grant Likely
On Mon, 03 Nov 2014 16:06:03 +0100 , Arnd Bergmann a...@arndb.de wrote: On Friday 31 October 2014 23:53:28 Rafael J. Wysocki wrote: On Saturday, November 01, 2014 05:13:45 AM Rob Herring wrote: On Fri, Oct 31, 2014 at 6:59 AM, Gilad Avidov gavi...@codeaurora.org wrote:

Re: [PATCH] of/fdt: Don't clear initial_boot_params if fdt_check_header() fails

2014-11-04 Thread Grant Likely
On Wed, 29 Oct 2014 12:15:00 -0600 , Bjorn Helgaas bhelg...@google.com wrote: If the device tree pointer is NULL, early_init_dt_verify() fails, leaving initial_boot_params unchanged. If the device tree pointer is non-NULL but invalid, early_init_dt_verify() again fails but this time it also

Re: [PATCH 1/1] of/fdt: simplify early_init_dt_verify

2014-11-04 Thread Grant Likely
On Tue, 28 Oct 2014 19:51:05 +0800 , Zhen Lei thunder.leiz...@huawei.com wrote: put off initial_boot_params = params; until all checks finished. If any check failed, initial_boot_params is equal NULL, base upon bss segment initial value. Signed-off-by: Zhen Lei thunder.leiz...@huawei.com

Re: [PATCH 4/4] of: Remove spaces before tabs

2014-11-04 Thread Grant Likely
On Wed, 22 Oct 2014 11:44:55 +0200 , Geert Uytterhoeven geert+rene...@glider.be wrote: Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Applied all 4 patches. Thanks. g. --- drivers/of/base.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 1/1] of: Add a function to read 64-bit arrays

2014-11-04 Thread Grant Likely
On Fri, 3 Oct 2014 00:59:23 +0300 , Sakari Ailus sakari.ai...@iki.fi wrote: Implement of_property_read_u64_array() for reading 64-bit arrays. This is needed for e.g. reading the valid link frequencies in the smiapp driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi A patch that

Re: [PATCH] of: Fix padding in _OF_DECLARE macro definition

2014-11-04 Thread Grant Likely
On Thu, 2 Oct 2014 16:01:10 +0200 , Thierry Reding thierry.red...@gmail.com wrote: From: Thierry Reding tred...@nvidia.com Signed-off-by: Thierry Reding tred...@nvidia.com Applied, thanks. g. --- include/linux/of.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-04 Thread Grant Likely
On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: I also found that this parser code doesn't correctly handle malformed (unterminated) string properties. It will overflow. The existing functions have the same problem, so it isn't something that you've added. I've got

Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

2014-11-04 Thread Grant Likely
On Tue, Nov 4, 2014 at 10:54 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, November 04, 2014 05:06:40 PM Rafael J. Wysocki wrote: On Tuesday, November 04, 2014 02:48:40 PM Grant Likely wrote: On Mon, Nov 3, 2014 at 9:52 PM, Rafael J. Wysocki r...@rjwysocki.net wrote

[PATCH] of: Fix overflow bug in string property parsing functions

2014-11-03 Thread Grant Likely
in to reduce the churn on the header file. Signed-off-by: Grant Likely Cc: Rafael J. Wysocki Cc: Mika Westerberg Cc: Rob Herring Cc: Arnd Bergmann Cc: Darren Hart Cc: # v3.3+: Drop selftest hunks that don't apply --- I'd like to get this into v3.18 in the next week. Please shout if you have any

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-03 Thread Grant Likely
Hi Rafael, While reviewing and testing these patches I ran into serious bugs in the string parsers (in both the existing code and the new functions here). It took me a number of days, but I've got a fix now which I'll be posting shortly and I want to get into mainline right away. I'll cc you when

Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware

2014-11-03 Thread Grant Likely
Hi Rafael, While reviewing and testing these patches I ran into serious bugs in the string parsers (in both the existing code and the new functions here). It took me a number of days, but I've got a fix now which I'll be posting shortly and I want to get into mainline right away. I'll cc you when

[PATCH] of: Fix overflow bug in string property parsing functions

2014-11-03 Thread Grant Likely
in to reduce the churn on the header file. Signed-off-by: Grant Likely grant.lik...@linaro.org Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Cc: Mika Westerberg mika.westerb...@linux.intel.com Cc: Rob Herring robh...@kernel.org Cc: Arnd Bergmann a...@arndb.de Cc: Darren Hart darren.h...@intel.com Cc: sta

Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

2014-11-01 Thread Grant Likely
On Tue, 28 Oct 2014 22:59:57 +0100 , "Rafael J. Wysocki" wrote: > On Tuesday, October 28, 2014 01:15:27 PM Mika Westerberg wrote: > > acpi_dev_add_driver_gpios() makes it possible to set up mapping between > > properties and ACPI GpioIo resources in a driver, so we can take index > > parameter

Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties

2014-11-01 Thread Grant Likely
On Tue, 28 Oct 2014 22:59:57 +0100 , Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, October 28, 2014 01:15:27 PM Mika Westerberg wrote: acpi_dev_add_driver_gpios() makes it possible to set up mapping between properties and ACPI GpioIo resources in a driver, so we can take index

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-20 Thread Grant Likely
On Mon, Oct 20, 2014 at 4:19 PM, Arnd Bergmann wrote: > On Monday 20 October 2014 01:46:00 Rafael J. Wysocki wrote: >> >> > Something like: >> > >> > #define define_fwnode_accessors(__type, __devprop_type) \ >> > int device_property_read_##__type(struct device *dev, \ >> >

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-20 Thread Grant Likely
On Mon, 20 Oct 2014 01:46 +0200 , "Rafael J. Wysocki" wrote: > On Saturday, October 18, 2014 04:55:20 PM Grant Likely wrote: > > On Fri, 17 Oct 2014 14:14:53 +0200 > > , "Rafael J. Wysocki" > > wrote: > > > From: Rafael J. Wysocki

Re: [PATCH v5 03/12] ACPI: Allow drivers to match using Device Tree compatible property

2014-10-20 Thread Grant Likely
to point at some document that describes the semantics of the PRP0001 binding. g. > > If there is a need to distinguish from where the device is enumerated > (DT/ACPI) driver can check dev->of_node or ACPI_COMPATION(dev). > > Signed-off-by: Mika Westerberg > Reviewed-by: Grant Lik

Re: [PATCH v5 03/12] ACPI: Allow drivers to match using Device Tree compatible property

2014-10-20 Thread Grant Likely
at some document that describes the semantics of the PRP0001 binding. g. If there is a need to distinguish from where the device is enumerated (DT/ACPI) driver can check dev-of_node or ACPI_COMPATION(dev). Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Reviewed-by: Grant

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-20 Thread Grant Likely
On Mon, 20 Oct 2014 01:46 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: On Saturday, October 18, 2014 04:55:20 PM Grant Likely wrote: On Fri, 17 Oct 2014 14:14:53 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Add new

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-20 Thread Grant Likely
On Mon, Oct 20, 2014 at 4:19 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 20 October 2014 01:46:00 Rafael J. Wysocki wrote: Something like: #define define_fwnode_accessors(__type, __devprop_type) \ int device_property_read_##__type(struct device *dev, \

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-18 Thread Grant Likely
(struct fwnode_handle *fwnode, \ const char *propname, __type *val) \ { \ return fwnode_property_read_##__type##_array(fwnode, propname, val, 1) \ } define_fwnode_accessors(u8, DEV_PROP_U8); define_fwnode_accessors(u16, DEV_PROP_U16); define_fwnode_accessors(u32, DEV_PROP_U32); defin

Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Thu, 16 Oct 2014 16:55:56 +0200 , David Woodhouse wrote: > On Wed, 2014-10-15 at 17:43 +0200, Darren Hart wrote: > > > > So my objection here is that by keeping the of_* terms in the driver we > > are required to include of, although it does safely convert to returning > > NULL if !CONFIG_OF

Re: [PATCH v5 00/12] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Sat, 18 Oct 2014 00:50 +0200 , "Rafael J. Wysocki" wrote: > On Friday, October 17, 2014 08:04:52 PM Arnd Bergmann wrote: > > > > On October 17, 2014 2:01:33 PM CEST, "Rafael J. Wysocki" > > wrote: > > >Hi Everyone, > > > > > >Hving had a couple of chats with Grant and Arnd during LinuxCon

Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Wed, 15 Oct 2014 17:43:01 +0200 , Darren Hart wrote: > > > On 10/15/14 17:17, Mark Rutland wrote: > > On Wed, Oct 15, 2014 at 03:46:39PM +0100, Darren Hart wrote: > > >> Mark, what would you propose we do differently to enable this driver to > >> be firmware-type agnostic? > > > > For

Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Thu, 16 Oct 2014 16:55:56 +0200 , David Woodhouse wrote: > On Wed, 2014-10-15 at 17:43 +0200, Darren Hart wrote: > > > > So my objection here is that by keeping the of_* terms in the driver we > > are required to include of, although it does safely convert to returning > > NULL if !CONFIG_OF

Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Thu, 16 Oct 2014 16:55:56 +0200 , David Woodhouse dw...@infradead.org wrote: On Wed, 2014-10-15 at 17:43 +0200, Darren Hart wrote: So my objection here is that by keeping the of_* terms in the driver we are required to include of, although it does safely convert to returning NULL if

Re: [PATCH v5 00/12] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Sat, 18 Oct 2014 00:50 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday, October 17, 2014 08:04:52 PM Arnd Bergmann wrote: On October 17, 2014 2:01:33 PM CEST, Rafael J. Wysocki r...@rjwysocki.net wrote: Hi Everyone, Hving had a couple of chats with Grant and Arnd

Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Wed, 15 Oct 2014 17:43:01 +0200 , Darren Hart dvh...@linux.intel.com wrote: On 10/15/14 17:17, Mark Rutland wrote: On Wed, Oct 15, 2014 at 03:46:39PM +0100, Darren Hart wrote: Mark, what would you propose we do differently to enable this driver to be firmware-type agnostic?

Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

2014-10-18 Thread Grant Likely
On Thu, 16 Oct 2014 16:55:56 +0200 , David Woodhouse dw...@infradead.org wrote: On Wed, 2014-10-15 at 17:43 +0200, Darren Hart wrote: So my objection here is that by keeping the of_* terms in the driver we are required to include of, although it does safely convert to returning NULL if

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-18 Thread Grant Likely
, DEV_PROP_U8); define_fwnode_accessors(u16, DEV_PROP_U16); define_fwnode_accessors(u32, DEV_PROP_U32); define_fwnode_accessors(u64, DEV_PROP_U64); g. Suggested-by: Grant Likely grant.lik...@linaro.org Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- drivers/acpi/scan.c

Re: [RFC v3 PATCH 1/5] of: Add standard property for poweroff capability

2014-10-15 Thread Grant Likely
perty. > This patch adds support for a standard property "poweroff-source" > which marks the device as able to shutdown the system. > > Signed-off-by: Romain Perier Acked-by: Grant Likely And same for the documentation patches. g. > --- > include/linux/of.h |

Re: [RFC v3 PATCH 1/5] of: Add standard property for poweroff capability

2014-10-15 Thread Grant Likely
. This patch adds support for a standard property poweroff-source which marks the device as able to shutdown the system. Signed-off-by: Romain Perier romain.per...@gmail.com Acked-by: Grant Likely grant.lik...@linaro.org And same for the documentation patches. g. --- include/linux/of.h

Re: [PATCH 06/13] gpio / ACPI: Add support for _DSD device properties

2014-10-14 Thread Grant Likely
On Tue, 07 Oct 2014 02:15:18 +0200 , "Rafael J. Wysocki" wrote: > From: Mika Westerberg > > With release of ACPI 5.1 and _DSD method we can finally name GPIOs (and > other things as well) returned by _CRS. Previously we were only able to > use integer index to find the corresponding GPIO,

Re: [PATCH 03/13] ACPI: Allow drivers to match using Device Tree compatible property

2014-10-14 Thread Grant Likely
I_COMPATION(dev). > > Signed-off-by: Mika Westerberg > Signed-off-by: Rafael J. Wysocki Looks okay to me. Reviewed-by: Grant Likely > --- > drivers/acpi/property.c | 34 + > drivers/acpi/scan.c | 97 > +++-- &

Re: [PATCH 03/13] ACPI: Allow drivers to match using Device Tree compatible property

2014-10-14 Thread Grant Likely
). Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Looks okay to me. Reviewed-by: Grant Likely grant.lik...@linaro.org --- drivers/acpi/property.c | 34 + drivers/acpi/scan.c | 97

Re: [PATCH 06/13] gpio / ACPI: Add support for _DSD device properties

2014-10-14 Thread Grant Likely
On Tue, 07 Oct 2014 02:15:18 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: From: Mika Westerberg mika.westerb...@linux.intel.com With release of ACPI 5.1 and _DSD method we can finally name GPIOs (and other things as well) returned by _CRS. Previously we were only able to use integer

Re: [PATCH 01/13] ACPI: Add support for device specific properties

2014-10-13 Thread Grant Likely
the caller. > > [1] > http://www.uefi.org/sites/default/files/resources/_DSD-implementation-guide-toplevel.htm > [2] > http://www.uefi.org/sites/default/files/resources/_DSD-device-properties-UUID.pdf > > Reviewed-by: Hanjun Guo > Reviewed-by: Josh Triplett > Signe

Re: [PATCH 04/13] ACPI: Document ACPI device specific properties

2014-10-13 Thread Grant Likely
On Tue, 07 Oct 2014 02:14:06 +0200 , "Rafael J. Wysocki" wrote: > From: Mika Westerberg > > This document describes the data format and interfaces of ACPI device > specific properties. > > Signed-off-by: Mika Westerberg > Signed-off-by: Darren Hart > Signed-off-by: Rafael J. Wysocki > ---

Re: [PATCH 04/13] ACPI: Document ACPI device specific properties

2014-10-13 Thread Grant Likely
On Tue, 07 Oct 2014 02:14:06 +0200 , Rafael J. Wysocki r...@rjwysocki.net wrote: From: Mika Westerberg mika.westerb...@linux.intel.com This document describes the data format and interfaces of ACPI device specific properties. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com

Re: [PATCH 01/13] ACPI: Add support for device specific properties

2014-10-13 Thread Grant Likely
...@linux.intel.com Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com This patch seems fine. Reviewed-by: Grant Likely grant.lik...@linaro.org --- drivers/acpi/Makefile |1 drivers/acpi/internal.h |6 drivers/acpi/property.c | 364

Re: [RFC PATCH v2 1/4] regulator: Add helper function to get "poweroff-source" property

2014-10-11 Thread Grant Likely
On Fri, Oct 10, 2014 at 1:29 PM, PERIER Romain wrote: >> >> What I'm more concerned about is the semantics of the property. What >> do the generic code paths gain by standardizing this property? Is it >> expected that > > We really need to come up with a standard property for this and document >

Re: [RFC PATCH v2 1/4] regulator: Add helper function to get poweroff-source property

2014-10-11 Thread Grant Likely
On Fri, Oct 10, 2014 at 1:29 PM, PERIER Romain romain.per...@gmail.com wrote: What I'm more concerned about is the semantics of the property. What do the generic code paths gain by standardizing this property? Is it expected that We really need to come up with a standard property for this

[GIT PULL] Devicetree changes for v3.18

2014-10-10 Thread Grant Likely
. Gaurav Minocha (1): To remove non-ascii characters in of_selftest.txt Geert Uytterhoeven (1): of: Add vendor prefix for Sitronix Grant Likely (7): of: Fix NULL dereference in selftest removal code of/selftest: Test structure

Re: linux-next: error fetching the devicetree tree

2014-10-10 Thread Grant Likely
Hi Stephen, Yes, the server is down and being worked on. I've moved my tree to kernel.org. Here is the new URL: git://git.kernel.org/pub/scm/linux/kernel/git/glikely/linux.git g. On Tue, Oct 7, 2014 at 11:48 PM, Stephen Rothwell wrote: > Hi Grant, > > Fetching the devicetree tree this

Re: [RFC PATCH v2 1/4] regulator: Add helper function to get "poweroff-source" property

2014-10-10 Thread Grant Likely
On Tue, Oct 7, 2014 at 8:43 PM, PERIER Romain wrote: > This is not the final location, I have no idea exactly where I might > put this helper function. This is why I ask you your opinion (and > also, this is why that's a proposal) > > 2014-10-07 21:45 GMT+02:00 Romain Perier : >> Several drivers

Re: [RFC PATCH v2 1/4] regulator: Add helper function to get poweroff-source property

2014-10-10 Thread Grant Likely
On Tue, Oct 7, 2014 at 8:43 PM, PERIER Romain romain.per...@gmail.com wrote: This is not the final location, I have no idea exactly where I might put this helper function. This is why I ask you your opinion (and also, this is why that's a proposal) 2014-10-07 21:45 GMT+02:00 Romain Perier

Re: linux-next: error fetching the devicetree tree

2014-10-10 Thread Grant Likely
Hi Stephen, Yes, the server is down and being worked on. I've moved my tree to kernel.org. Here is the new URL: git://git.kernel.org/pub/scm/linux/kernel/git/glikely/linux.git g. On Tue, Oct 7, 2014 at 11:48 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Grant, Fetching the

[GIT PULL] Devicetree changes for v3.18

2014-10-10 Thread Grant Likely
. Gaurav Minocha (1): To remove non-ascii characters in of_selftest.txt Geert Uytterhoeven (1): of: Add vendor prefix for Sitronix Grant Likely (7): of: Fix NULL dereference in selftest removal code of/selftest: Test structure

[PATCH] of/selftest: Move hash table off stack to fix large frame size

2014-10-07 Thread Grant Likely
The new testcase that checks phandle consistency was using a hash table on the stack which made the frame size much large than it should be. Fix the problem by moving the hash table into the file scope. Signed-off-by: Grant Likely --- This patch applies on my devicetree/next branch, which I'm

Re: [PATCH] of: Eliminate of_allnodes list

2014-10-07 Thread Grant Likely
On Mon, Oct 6, 2014 at 2:56 PM, Rob Herring wrote: > On Mon, Oct 6, 2014 at 3:59 AM, Grant Likely wrote: >> The device tree structure is composed of two lists; the 'allnodes' list >> which is a singly linked list containing every node in the tree, and the >> child->par

Re: [PATCH] of: Eliminate of_allnodes list

2014-10-07 Thread Grant Likely
On Mon, Oct 6, 2014 at 2:56 PM, Rob Herring r...@kernel.org wrote: On Mon, Oct 6, 2014 at 3:59 AM, Grant Likely grant.lik...@linaro.org wrote: The device tree structure is composed of two lists; the 'allnodes' list which is a singly linked list containing every node in the tree, and the child

<    1   2   3   4   5   6   7   8   9   10   >