[GIT PULL] Char/Misc driver changes for 5.12-rc1

2021-02-24 Thread Greg KH
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git tags/char-misc-5.12-rc1 for you to fetch changes up to

[GIT PULL] Driver core / debugfs changes for 5.12-rc1

2021-02-24 Thread Greg KH
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-5.12-rc1 for you to fetch changes up to

Re: [PATCH v1 1/1] Kernel Config to make randomize_va_space read-only.

2021-02-24 Thread Greg KH
On Wed, Feb 24, 2021 at 03:53:37AM +, Lan Zheng (lanzheng) wrote: > From ba2ec52f170a8e69d6c44238bb578f9518a7e3b7 Mon Sep 17 00:00:00 2001 > > From: lanzheng You are still sending html email, which is rejected by the kernel mailing lists. And no need to cc: secur...@kernel.org, that is

Re: [PATCH] driver core: Use unbound workqueue for deferred probes

2021-02-24 Thread Greg KH
On Wed, Feb 24, 2021 at 05:25:49PM +0530, Yogesh Lal wrote: > Queue deferred driver probes on unbounded workqueue, to allow > scheduler better manage scheduling of long running probes. Really? What does this change and help? What is the visable affect of this patch? What problem does it solve?

Re: [RFC PATCH 09/12] drivers: base: reintroduce find_bus()

2021-02-24 Thread Greg KH
On Tue, Feb 23, 2021 at 09:13:26PM +0100, Enrico Weigelt, metux IT consult wrote: > On 13.02.21 11:20, Greg KH wrote: > > On Mon, Feb 08, 2021 at 11:22:00PM +0100, Enrico Weigelt, metux IT consult > > wrote: > > > --- > > > drivers/base/bus.c | 14 +++

Re: [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting

2021-02-23 Thread Greg KH
On Wed, Feb 24, 2021 at 09:41:01AM +0800, Xiaoming Ni wrote: > On 2021/2/23 21:00, Greg KH wrote: > > On Mon, Feb 22, 2021 at 10:11:37PM +0800, Xiaoming Ni wrote: > > > On 2021/2/22 20:09, Greg KH wrote: > > > > On Mon, Feb 22, 2021 at 06:54:06PM +0800, Xiaoming Ni wr

Re: [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting

2021-02-23 Thread Greg KH
On Mon, Feb 22, 2021 at 10:11:37PM +0800, Xiaoming Ni wrote: > On 2021/2/22 20:09, Greg KH wrote: > > On Mon, Feb 22, 2021 at 06:54:06PM +0800, Xiaoming Ni wrote: > > > On 2021/2/22 18:16, Greg KH wrote: > > > > On Mon, Feb 22, 2021 at 03:03:28PM +0800, Xiaoming Ni

Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup

2021-02-23 Thread Greg KH
On Mon, Feb 22, 2021 at 09:11:43PM +0800, Zhengyejian (Zetta) wrote: > > > On 2021/2/22 20:36, Greg KH wrote: > > On Mon, Feb 22, 2021 at 08:20:38PM +0800, Zhengyejian (Zetta) wrote: > > > > > > > > > On 2021/2/22 20:07, Greg KH wrote: > > &

Re: [PATCH] tty/serial:Remove superfluous "breaks"

2021-02-23 Thread Greg KH
On Tue, Feb 23, 2021 at 04:06:30PM +0800, dingsen...@163.com wrote: > From: dingsenjie > > Remove superfluous "breaks", as there is a "return" before them. > > Signed-off-by: dingsenjie > --- > drivers/tty/serial/imx.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git

Re: [PATCH 2/2] staging: rtl8192e: Change state information from u16 to u8

2021-02-22 Thread Greg KH
On Sun, Feb 21, 2021 at 10:27:21PM +0530, Atul Gopinathan wrote: > On Sun, Feb 21, 2021 at 02:08:26PM +0100, Greg KH wrote: > > On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote: > > > The "CcxRmState" field in struct "rtllib_network" is defined

Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 08:20:38PM +0800, Zhengyejian (Zetta) wrote: > > > On 2021/2/22 20:07, Greg KH wrote: > > On Mon, Feb 22, 2021 at 11:54:24AM +, Lee Jones wrote: > > > On Mon, 22 Feb 2021, Zheng Yejian wrote: > > > > > > >

Re: [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 06:54:06PM +0800, Xiaoming Ni wrote: > On 2021/2/22 18:16, Greg KH wrote: > > On Mon, Feb 22, 2021 at 03:03:28PM +0800, Xiaoming Ni wrote: > > > From: Thomas Gleixner > > > > > > commit ac31c7ff8624409ba3c4901df9237a616c187a5d

Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 11:54:24AM +, Lee Jones wrote: > On Mon, 22 Feb 2021, Zheng Yejian wrote: > > > From: Peter Zijlstra > > > > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. > > > > Both Geert and DaveJ reported that the recent futex commit: > > > > c1e2f0eaf015

Re: [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 03:03:28PM +0800, Xiaoming Ni wrote: > From: Thomas Gleixner > > commit ac31c7ff8624409ba3c4901df9237a616c187a5d upstream. This commit is already in the 4.9 tree. If the backport was incorrect, say that here, and describe what went wrong and why this commit fixes it.

Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote: > The driver also generates a `SYSGENID=%u` uevent containing the new > system generation counter/id value every time it changes. Unlike the > filesystem interface, the uevent has no synchronization guarantees > therefore it should

Re: [PATCH] vt: convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-22 Thread Greg KH
On Mon, Feb 22, 2021 at 04:48:49PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/tty/vt/vt.c:3909:8-16: WARNING: use scnprintf or sprintf. > ./drivers/tty/vt/vt.c:3917:8-16: WARNING: use scnprintf or sprintf Why? You say what you did, but there is no

Re: [PATCH v2] staging: wimax: Fix block comment style issue in stack.c

2021-02-21 Thread Greg KH
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "Block comments > use * on subsequent lines". That's not all this patch does, please be descriptive of what you really do and why you are doing it. thanks, greg k-h

Re: [PATCH 2/2] staging: rtl8192e: Change state information from u16 to u8

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote: > The "CcxRmState" field in struct "rtllib_network" is defined > as a u16 array of size 2 (so, 4 bytes in total). > > But the operations performed on this array throughout the code > base (in rtl8192e/) are all in byte size 2

Re: [PATCH] staging: wimax: Fix block comment style issue in stack.c

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "Block comments > use * on subsequent lines". > > Signed-off-by: Amrit Khera > --- > drivers/staging/wimax/stack.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > >

Re: [PATCH v1] Staging: rtl8192e: fix kconfig dependency on CRYPTO

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 12:22:43PM -0500, Julian Braha wrote: > >From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001 > From: Julian Braha > Date: Sat, 20 Feb 2021 12:07:30 -0500 > Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO Why is this all in the body

Re: [PATCH v2] staging: wimax: i2400m: add space before open parenthesis

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote: > netdev.c > > fixing style ERROR: space required before the open parenthesis '(' > > Signed-off-by: Rajesh Kumbhakar > --- > Changes in v2: > - Removed filename from commit message. filename is still in commit message :(

Re: [PATCH v3 01/02] staging: kpc2000: code style: fix alignment issues

2021-02-21 Thread Greg KH
me style warnings remain valid here and could be fixed by > another patch. > > v2: Edited changelog, as suggested by Greg KH > v3: Splitted patch in two parts, as suggested by Greg KH > You sent 2 different patches, that did different things, yet have the same exact subject line

Re: [PATCH] staging: hikey9xx: Fix space tab style warnings

2021-02-21 Thread Greg KH
On Fri, Feb 19, 2021 at 02:38:51PM +, Lee Gibson wrote: > This patch fixes the checkpatch warnings such as: > > hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs > > Signed-off-by: Lee Gibson > --- > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8 > 1 file changed, 4

Re: [PATCH] staging: wimax: i2400m: add space before open parenthesis

2021-02-20 Thread Greg KH
On Sat, Feb 20, 2021 at 05:58:35PM +0530, RajMAIN wrote: > > On 20-02-2021 16:42, Greg KH wrote: > > On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote: > > > netdev.c > > Why is this here? > > You mean that filename? I thought I should mention it.

Re: [PATCH] staging: wimax: i2400m: add space before open parenthesis

2021-02-20 Thread Greg KH
On Sat, Feb 20, 2021 at 02:48:16AM -0800, Rajesh Kumbhakar wrote: > netdev.c Why is this here?

Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote: > commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0 > Author: Julian Braha > Date: Fri Feb 19 17:02:24 2021 -0500 > > staging: rtl8192e: fix kconfig dependency on CRYPTO > > When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO

Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 02:50:53PM +, Kurt Manucredo wrote: > > > changes since previous version: > - change Subject line > - change commit message > - change commit message position to above signed-off-by This all goes below the --- line please. Please make a v3. thanks, greg k-h

Re: [PATCH v2] staging: fwserial: fix alignment of function parameters

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 04:21:12PM +0530, Prakash Dubey wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Prakash Dubey > --- > drivers/staging/fwserial/fwserial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "struct file_operations > should normally be const". > > Signed-off-by: Amrit Khera > --- > Changes in v2: > - Wrapped the commit description > - Build tested If you tested it, what

Re: [PATCH] staging: android: Fix const keyword style issue in ashmem.c

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 03:43:39PM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "struct file_operations should > normally be const". > > Signed-off-by: Amrit Khera > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] staging: vt6656: fixed a CamelCase coding style issue.

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 03:28:35PM +0530, Selvakumar Elangovan wrote: > This patch renames CamelCase macros uVar and uModulo into u_var and > u_module in device.h > > This issue was reported by checkpatch.pl > > Signed-off-by: Selvakumar Elangovan > --- > drivers/staging/vt6656/device.h | 8

Re: [PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > I was unable to align it right below the opening parenthesis, just by using > tabs. And when I did that with spaces, the checkpatch yelled at me for > using spaces. Any suggestions how to do this without using spaces? I am >

Re: [PATCH v2] staging: kpc2000: code style: fix alignment issues

2021-02-19 Thread Greg KH
On Fri, Feb 19, 2021 at 11:04:51AM +0300, Nikolay Kyx wrote: > This patch fixes the following checkpatch.pl warnings: > > WARNING: line length of 124 exceeds 100 columns > CHECK: Alignment should match open parenthesis That's two different things, please make this two different patches. thanks,

Re: [PATCH] staging: fwserial: match alignment with open parenthesis

2021-02-19 Thread Greg KH
On Thu, Feb 18, 2021 at 10:43:33PM +0300, Nikolay Kyx wrote: > fwserial.c: Why is this here? > fix CHECK: Alignment should match open parenthesis What does this mean? Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is

Re: [PATCH] staging: fwserial: Fix alignment of function parameters

2021-02-19 Thread Greg KH
On Thu, Feb 18, 2021 at 03:58:51PM +0530, Prakash Dubey wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Prakash Dubey > --- > drivers/staging/fwserial/fwserial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v2] staging: hikey9xx: fix styling issues

2021-02-19 Thread Greg KH
On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote: > In hi6421-spmi-pmic.c, there are some warnings and Check: > > "WARNING: please, no space before tabs" in lines 51,52,53 and 69. > "CHECK: Alignment should match open parenthesis" in lines 180 and 238. > > Signed-off-by: Alaa Emad

Re: [PATCH] staging: removed unnecessary debug message to fix coding style warning

2021-02-19 Thread Greg KH
On Sun, Feb 14, 2021 at 07:44:52PM +0530, Ashish Vara wrote: > From: Ashish Vara > > removed unnecessary out of memory message to fix coding style warning. > > Signed-off-by: Ashish Vara > --- > drivers/staging/gasket/gasket_page_table.c | 2 -- > 1 file changed, 2 deletions(-) Your subject

Re: [PATCH] staging: kpc2000: code style: fix alignment issues

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 11:28:14PM +0300, Nikolay Kyx wrote: > kpc2000_i2c.c: > fix WARNING: line length of 124 exceeds 100 columns > fix CHECK: Alignment should match open parenthesis > > kpc2000_spi.c: > fix CHECK: Alignment should match open parenthesis This changelog is a bit odd. Please

Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 07:50:27PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > The preferred coding style is: > if (!StaAddr) > return; > > thank you mr. dan carpenter > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1

Re: [PATCH] Staging: rtl8723bs: code-style fix

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 04:33:10PM +, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo > --- > > Checkpatch complains the constant needs to be on the right side of the > comparison. The preferred way is: > > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1

Re: [PATCH] staging: rtl8188eu: Align block comments

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 10:50:43PM +0530, Suryashankar Das wrote: > This patch fixes the checkpatch.pl warnings: > WARNING: Block comments use * on subsequent lines > WARNING: Block comments should align the * on each line > > Signed-off-by: Suryashankar Das > --- >

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 06:22:20PM +0530, Atul Gopinathan wrote: > On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote: > > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > > > On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote: > > >

Re: [PATCH v3 9/9] scsi: ufshpb: Make host mode parameters configurable

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 03:19:32PM +0200, Avri Altman wrote: > We can make use of this commit, to elaborate some more of the host > control mode logic, explaining what role play each and every variable. > > While at it, allow those parameters to be configurable. > > Signed-off-by: Avri Altman >

Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > On Thu, Feb 18, 2021 at 10:31:15AM +, Ian Abbott wrote: > > On 18/02/2021 08:44, Atul Gopinathan wrote: > > > Fix the following warning generated by sparse: > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: warning:

Re: pstore: fix compression

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 12:15:47PM +0100, Jiri Bohac wrote: > pstore_compress() and decompress_record() use a mistyped config option > name ("PSTORE_COMPRESSION" instead of "PSTORE_COMPRESS"). > As a result compression and decompressionm of pstore records is always > disabled. > > Use the correct

Re: [PATCH] staging: wimax/i2400m: don't change the endianness of one byte variable

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote: > It is wrong to change the endianness of a variable which has just one > byte size. > > Sparse warnings fixed: > drivers/staging//wimax/i2400m/control.c:452:17: warning: cast to restricted > __le32 >

Re: [PATCH] staging: vc04_services: Fixed address type mismatch in vchiq_arm.c

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 02:40:15PM +0530, Pritthijit Nath wrote: > This change fixes a sparse address type mismatch warning "incorrect type > in assignment (different address spaces)". > > Signed-off-by: Pritthijit Nath > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 09:04:42AM +, Marc Zyngier wrote: > On Thu, 18 Feb 2021 08:54:00 +, > Greg KH wrote: > > [...] > > > > > Wow, wait, you are removing a debugfs file _before_ debugfs is even > > > > initialized? Didn't ex

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Wed, Feb 17, 2021 at 08:57:17PM +0100, Michael Walle wrote: > Hi Greg, > > > There's no need to keep around a dentry pointer to a simple file that > > debugfs itself can look up when we need to remove it from the system. > > So simplify the code by deleting the variable and cleaning up the

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote: > Am 2021-02-18 08:31, schrieb Greg KH: > > On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote: > > > On Wed, 17 Feb 2021 20:10:50 +, > > > Michael Walle wrote: > > > > > >

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 08:47:15AM +, Marc Zyngier wrote: > On 2021-02-18 08:38, Greg KH wrote: > > On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote: > > > Am 2021-02-18 08:31, schrieb Greg KH: > > > > On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Z

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 09:27:09AM +0100, Michael Walle wrote: > Am 2021-02-18 08:31, schrieb Greg KH: > > On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote: > > > On Wed, 17 Feb 2021 20:10:50 +, > > > Michael Walle wrote: > > > > > >

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Wed, Feb 17, 2021 at 09:50:38PM +, Marc Zyngier wrote: > On Wed, 17 Feb 2021 20:10:50 +, > Michael Walle wrote: > > > > Am 2021-02-17 21:02, schrieb Marc Zyngier: > > > On 2021-02-17 19:57, Michael Walle wrote: > > >> Hi Greg, > > >> > > >>> There's no need to keep around a dentry

Re: [PATCH] staging: comedi: cast to (void __user *)

2021-02-18 Thread Greg KH
On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote: > Resolve the following sparse warning: > drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in > argument 1 (different address spaces) > drivers/staging//comedi/comedi_fops.c:2983:41:expected void [noderef]

Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain

2021-02-18 Thread Greg KH
On Wed, Feb 17, 2021 at 11:21:22PM +0100, Michael Walle wrote: > Am 2021-02-17 22:50, schrieb Marc Zyngier: > > On Wed, 17 Feb 2021 20:10:50 +, > > Michael Walle wrote: > > > > > > Am 2021-02-17 21:02, schrieb Marc Zyngier: > > > > On 2021-02-17 19:57, Michael Walle wrote: > > > >> Hi Greg,

Re: [PATCH] staging: comedi: cast to (unsigned int *)

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 11:40:00PM +0530, Atul Gopinathan wrote: > On Wed, Feb 17, 2021 at 06:35:15PM +0100, Greg KH wrote: > > On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote: > > > Resolve the following warning generated by sparse: > > > &g

Re: [PATCH] staging: comedi: cast to (unsigned int *)

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 10:29:08PM +0530, Atul Gopinathan wrote: > Resolve the following warning generated by sparse: > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in > assignment (different address spaces) > drivers/staging//comedi/comedi_fops.c:2956:23:expected

Re: [PATCH] staging: wlan-ng: Fixed incorrect type warning in p80211netdev.c

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 09:12:55PM +0530, Pritthijit Nath wrote: > This change fixes a sparse warning "incorrect type in argument 1 > (different address spaces)". > > Signed-off-by: Pritthijit Nath > --- > drivers/staging/wlan-ng/p80211netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] tty: fix when iov_iter_count() returns 0 in tty_write()

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 04:13:58PM +0100, Greg KH wrote: > On Wed, Feb 17, 2021 at 08:43:47PM +0600, Sabyrzhan Tasbolatov wrote: > > syzbot found WARNING in iov_iter_revert[1] when iov_iter_count() returns 0, > > therefore INT_MAX is passed to iov_iter_revert() causing > MAX_RW

Re: [PATCH] staging: gasket Fix comparision with Null

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 06:58:16PM +0530, mayanksu...@live.com wrote: > From: Mayank Suman > > The change was suggested by checkpatch.pl. What change? Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for a description of how to

Re: [PATCH] tty: fix when iov_iter_count() returns 0 in tty_write()

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 08:43:47PM +0600, Sabyrzhan Tasbolatov wrote: > syzbot found WARNING in iov_iter_revert[1] when iov_iter_count() returns 0, > therefore INT_MAX is passed to iov_iter_revert() causing > MAX_RW_COUNT > warning. > > static inline ssize_t do_tty_write() > { > .. > size_t

Re: [PATCH for 5.10 v2 0/5] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-17 Thread Greg KH
On Tue, Feb 16, 2021 at 03:24:34PM +0100, Stefano Garzarella wrote: > v1: > https://lore.kernel.org/stable/20210211162519.215418-1-sgarz...@redhat.com/ > > v2: > - backport the upstream patch and related patches needed > > Commit 65b709586e22 ("vdpa_sim: add get_config callback in >

Re: [PATCH v1 00/18] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 10:10:35AM +0100, Hans Verkuil wrote: > On 17/02/2021 09:36, Greg KH wrote: > > On Wed, Feb 17, 2021 at 09:28:09AM +0100, Benjamin Gaignard wrote: > >> > >> Le 17/02/2021 à 09:08, Greg KH a écrit : > >>> On Wed, Feb 17, 2021 at 09

Re: [PATCH v1 00/18] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 09:28:09AM +0100, Benjamin Gaignard wrote: > > Le 17/02/2021 à 09:08, Greg KH a écrit : > > On Wed, Feb 17, 2021 at 09:02:48AM +0100, Benjamin Gaignard wrote: > > > The IMX8MQ got two VPUs but until now only G1 has been enabled. > > > This se

Re: [PATCH v1 00/18] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-02-17 Thread Greg KH
On Wed, Feb 17, 2021 at 09:02:48AM +0100, Benjamin Gaignard wrote: > The IMX8MQ got two VPUs but until now only G1 has been enabled. > This series aim to add the second VPU (aka G2) and provide basic > HEVC decoding support. Why are you adding this directly to drivers/staging/media/ and not

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Greg KH
On Tue, Feb 16, 2021 at 07:50:49PM +, Min Li wrote: > > > > Yes, that line. > > > > The documentation should tell you how to do that, as per my patch bot: > > > > - This looks like a new version of a previously submitted patch, but you > > did not list below the --- line any changes from

Re: [PATCH] Staging: ks7010: ks_hostif: fixed parentheses coding style issue

2021-02-16 Thread Greg KH
On Tue, Feb 16, 2021 at 08:40:58PM +0530, Selvakumar Elangovan wrote: > Fixed a coding style issue. > > Signed-off-by: Selvakumar Elangovan > --- > drivers/staging/ks7010/ks_hostif.h | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git

Re: [PATCH] USB: serial: cp210x: add IDs for nLight Air Adapter, Acuity Brands, Inc.

2021-02-16 Thread Greg KH
On Tue, Feb 16, 2021 at 09:43:33AM -0500, Karan Singhal wrote: > Signed-off-by: Karan Singhal I know I can't take patches without any changelog text, maybe Johan is a bit nicer, but I hope not :) Please fi xup and at least say something here, perhaps the output of 'lsusb -v' for the device?

Re: [PATCH v2] vfs: prevent copy_file_range to copy across devices

2021-02-16 Thread Greg KH
On Tue, Feb 16, 2021 at 12:01:16PM +, Luis Henriques wrote: > "gre...@linuxfoundation.org" writes: > > > On Tue, Feb 16, 2021 at 11:17:34AM +, Luis Henriques wrote: > >> Amir Goldstein writes: > >> > >> > On Mon, Feb 15, 2021 at 8:57 PM Trond Myklebust > >> > wrote: > >> >> > >> >>

Re: [PATCH v5 1/2] bio: limit bio max size

2021-02-15 Thread Greg KH
On Tue, Feb 16, 2021 at 03:42:42PM +0900, Changheun Lee wrote: > > > > On Tue, Feb 16, 2021 at 11:00:32AM +0900, Changheun Lee wrote: > > > Please feedback to me if more modification is needed to apply. :) > > > > No context here :( > > > > I'm so sorry. I missed it. > > > bio size can grow

Re: [PATCH v5 1/2] bio: limit bio max size

2021-02-15 Thread Greg KH
On Tue, Feb 16, 2021 at 11:00:32AM +0900, Changheun Lee wrote: > Please feedback to me if more modification is needed to apply. :) No context here :(

[GIT PULL] Staging/IIO driver patches for 5.12-rc1

2021-02-15 Thread Greg KH
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.12-rc1 for you to fetch changes up to

[GIT PULL] USB / Thunderbolt driver changes for 5.12-rc1

2021-02-15 Thread Greg KH
The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3: Linux 5.11-rc7 (2021-02-07 13:57:38 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.12-rc1 for you to fetch changes up to

[GIT PULL] TTY / Serial driver changes for 5.12-rc1

2021-02-15 Thread Greg KH
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tags/tty-5.12-rc1 for you to fetch changes up to

Re: [PATCH for 5.10] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 04:03:21PM +0100, Stefano Garzarella wrote: > On Mon, Feb 15, 2021 at 03:32:19PM +0100, Greg KH wrote: > > On Thu, Feb 11, 2021 at 05:25:19PM +0100, Stefano Garzarella wrote: > > > Commit 65b709586e222fa6ffd4166ac7fdb5d5dad113ee upstream. > &

Re: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 05:02:50PM +0200, Alaa Emad wrote: > sorry ,i thought it needs to change the description so i resent . If so, then say what you changed below the --- line and make it a v2 patch, like the Documentation tells you to do, right? > please guide me how to fix this or it is

Re: [PATCH RFC 5/6] btrfs: sysfs: Add directory for read policies

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 02:35:35PM +, Michal Rostecki wrote: > On Sat, Feb 13, 2021 at 11:19:28AM +0100, Greg KH wrote: > > On Tue, Feb 09, 2021 at 09:30:39PM +0100, Michal Rostecki wrote: > > > From: Michal Rostecki > > > > > > Before this change,

Re: [PATCH resend] staging: hikey9xx: hi6421-spmi-pmic: fixing

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 04:36:52PM +0200, Alaa Emad wrote: > This patch fix the following issues in hi6421-spmi-pmic.c file: > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c:51: WARNING: please, no space > before tabs > drivers/staging/hikey9xx/hi6421-spmi-pmic.c:52: WARNING: please, no space >

Re: [PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-02-15 Thread Greg KH
On Fri, Feb 12, 2021 at 08:57:14AM +, Christophe Leroy wrote: > This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in > exception prolog stack check to fix build error") for kernel 5.10 > > It fixes the build failure on v5.10 reported by kernel test robot > and by David Michael. > >

Re: [PATCH for 5.10] vdpa_sim: fix param validation in vdpasim_get_config()

2021-02-15 Thread Greg KH
On Thu, Feb 11, 2021 at 05:25:19PM +0100, Stefano Garzarella wrote: > Commit 65b709586e222fa6ffd4166ac7fdb5d5dad113ee upstream. No, this really is not that commit, so please do not say it is. > Before this patch, if 'offset + len' was equal to > sizeof(struct virtio_net_config), the entire

Re: Patch "netfilter: nftables: fix possible UAF over chains from packet path in netns" has been added to the 4.19-stable tree

2021-02-15 Thread Greg KH
On Sun, Feb 14, 2021 at 11:29:55PM -0500, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > netfilter: nftables: fix possible UAF over chains from packet path in > netns > > to the 4.19-stable tree which can be found at: > >

Re: [GIT PULL v3] extcon next for v5.12

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 06:35:16PM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-next pull request for v5.12. I add detailed description of > this pull request on below. Please pull extcon with following updates. As 5.11 is now out, I can't take new things in my tree until 5.12-rc1

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-15 Thread Greg KH
On Mon, Feb 15, 2021 at 09:25:36AM +0800, Nicolas Boichat wrote: > On Mon, Feb 15, 2021 at 9:12 AM Ian Lance Taylor wrote: > > > > On Sun, Feb 14, 2021 at 4:38 PM Dave Chinner wrote: > > > > > > On Fri, Feb 12, 2021 at 03:54:48PM -0800, Darrick J. Wong wrote: > > > > On Sat, Feb 13, 2021 at

Re: [PATCH] usb: gadget: function: fix typo in f_printer.c

2021-02-14 Thread Greg KH
On Sun, Feb 14, 2021 at 07:35:25PM +0800, AristoChen wrote: > In line 824, it is trying to enable `out_ep`, so I > believe that in line 826, it should print `out_ep` > instead of `in_ep`. > > Signed-off-by: AristoChen Is this the name you use to sign legal documents? If not, please resend with

Re: [PATCH] scsi: ufs: sysfs: add is_ascii_output entry

2021-02-14 Thread Greg KH
On Wed, Feb 10, 2021 at 07:35:25PM -0800, Bart Van Assche wrote: > On 2/10/21 2:53 AM, Arthur Simchaev wrote: > > +static bool is_ascii_output = true; > > [ ... ] > > > static const char *ufschd_uic_link_state_to_string( > > enum uic_link_state state) > > { > > @@ -693,7

Re: [PATCH] Fix typo in f_printer.c

2021-02-14 Thread Greg KH
On Sun, Feb 14, 2021 at 05:40:25PM +0800, AristoChen wrote: > In line 824, it is trying to open `out_ep`, so > I believe in line 826, it should print `out_ep` > instead of `in_ep` > > Signed-off-by: AristoChen > --- > drivers/usb/gadget/function/f_printer.c | 2 +- > 1 file changed, 1

Re: [PATCH] fixed coding style warning

2021-02-14 Thread Greg KH
On Sun, Feb 14, 2021 at 01:48:06AM +0530, Ashish Vara wrote: > removed unnecessary out of memory message > > Signed-off-by: Ashish Vara > --- > drivers/staging/gasket/gasket_page_table.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_page_table.c >

Re: [RFC PATCH 09/12] drivers: base: reintroduce find_bus()

2021-02-13 Thread Greg KH
On Mon, Feb 08, 2021 at 11:22:00PM +0100, Enrico Weigelt, metux IT consult wrote: > --- > drivers/base/bus.c | 14 ++ > include/linux/device/bus.h | 2 ++ > 2 files changed, 12 insertions(+), 4 deletions(-) Um, no.

Re: [PATCH RFC 5/6] btrfs: sysfs: Add directory for read policies

2021-02-13 Thread Greg KH
On Tue, Feb 09, 2021 at 09:30:39PM +0100, Michal Rostecki wrote: > From: Michal Rostecki > > Before this change, raid1 read policy could be selected by using the > /sys/fs/btrfs/[fsid]/read_policy file. > > Change it to /sys/fs/btrfs/[fsid]/read_policies/policy. > > The motivation behing

Re: objtool segfault in 5.10 kernels with binutils-2.36.1

2021-02-13 Thread Greg KH
On Fri, Feb 12, 2021 at 05:51:45PM -0600, Josh Poimboeuf wrote: > On Thu, Feb 11, 2021 at 05:16:56PM +, Ken Moffat wrote: > > Hi, > > > > in 5.10 kernels up to and including 5.10.15 when trying to build the > > kernel for an x86_64 skylake using binutils-2.36.1, gcc-10.2 and > > glibic-2.33 I

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-13 Thread Greg KH
On Fri, Feb 12, 2021 at 07:06:17PM +, Min Li wrote: > > > > On Fri, Feb 12, 2021 at 03:44:52PM +, Min Li wrote: > > > > > > > > > > -set combomode > > > > > -get dpll's state > > > > > -get dpll's ffo > > > > > > > > > > This driver must work with Renesas MFD driver to access SMU > > > >

Re: [PATCH v2] kbuild: simplify access to the kernel's version

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 11:29:24AM -0500, Sasha Levin wrote: > Instead of storing the version in a single integer and having various > kernel (and userspace) code how it's constructed, export individual > (major, patchlevel, sublevel) components and simplify kernel code that > uses it. > > This

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 07:59:04AM -0800, Ian Lance Taylor wrote: > On Fri, Feb 12, 2021 at 7:45 AM Greg KH wrote: > > > > On Fri, Feb 12, 2021 at 07:33:57AM -0800, Ian Lance Taylor wrote: > > > On Fri, Feb 12, 2021 at 12:38 AM Greg KH > > > wrote: > > &

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 04:02:14PM +, Min Li wrote: > > > > xilinx_sdfec.c has: > > > > static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > > { > > return 0; > > } > > > > Which isn't even needed at all, but it is NOT trying to keep people from > >

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 03:44:52PM +, Min Li wrote: > > > > > > -set combomode > > > -get dpll's state > > > -get dpll's ffo > > > > > > This driver must work with Renesas MFD driver to access SMU through > > > I2C/SPI. > > > > > > Changes since v1: > > > -Provide more background for purpose

Re: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 03:39:03PM +, Min Li wrote: > > > + > > > + /* Only one open per device at a time */ > > > + if (!atomic_dec_and_test(>open_count)) { > > > + atomic_inc(>open_count); > > > + return -EBUSY; > > > > This does not do what you think it does, and does not

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 07:33:57AM -0800, Ian Lance Taylor wrote: > On Fri, Feb 12, 2021 at 12:38 AM Greg KH wrote: > > > > Why are people trying to use copy_file_range on simple /proc and /sys > > files in the first place? They can not seek (well most can not), so > >

Re: [PATCH] Fix space prohibited issue in fbtft-bus.c

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 04:58:33PM +0200, Alaa Emad wrote: > This change fixes a checkpatch error for "space prohibited before that close > parenthesis ')'" > > Signed-off-by: Alaa Emad > --- > certs/x509_revocation_list| 0 > drivers/staging/fbtft/fbtft-bus.c | 4 ++-- > 2 files

Re: [PATCH] staging: wimax/i2400m: fix some byte order issues found by sparse

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 08:00:25PM +0530, Anirudh Rayabharam wrote: > On Thu, Feb 11, 2021 at 09:35:27PM +0100, Greg KH wrote: > > On Fri, Feb 12, 2021 at 01:59:08AM +0530, Anirudh Rayabharam wrote: > > > Fix sparse byte-order warnings in the i2400m_bm_cmd_prepar

Re: [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated

2021-02-12 Thread Greg KH
On Fri, Feb 12, 2021 at 12:41:48PM +, Luis Henriques wrote: > Greg KH writes: > > > On Fri, Feb 12, 2021 at 12:05:14PM +, Luis Henriques wrote: > >> Greg KH writes: > >> > >> > On Fri, Feb 12, 2021 at 10:22:16AM +0200, Amir Goldstein wrote: &g

<    2   3   4   5   6   7   8   9   10   11   >