Re: [PATCH] staging: unisys: visornic: enhance visornic to use channel_interrupt

2021-01-27 Thread Greg KH
On Tue, Jan 12, 2021 at 04:25:40PM +0800, Song Chen wrote: > visornic uses timer to check the response queue and drain > it if needed periodically. On the other hand, visorbus > provides periodic work to serve such request, therefore, > timer should be replaced by channel_interrupt. > > Signed-off

Re: Linux 5.11-rc5

2021-01-27 Thread Greg KH
On Tue, Jan 26, 2021 at 10:45:10AM -0800, Linus Torvalds wrote: > On Tue, Jan 26, 2021 at 8:25 AM Mike Rapoport wrote: > > > > On Mon, Jan 25, 2021 at 09:46:19PM +, Chris Wilson wrote: > > > > > > CI does confirm that the revert of d3921cb8be29 brings the machines back > > > to life. > > > > I

Re: [PATCH] fnic: fixup patch to resolve stack frame issues

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 05:21:24PM -0800, Lee Duncan wrote: > From: Hannes Reinecke > > Commit 42ec15ceaea7 fixed a gcc issue with unused variables, but > introduced errors since it allocated an array of two u64-s but > then used more than that. Set the arrays to the proper size. > > Fixes: 42ec

Re: [PATCH v7 07/11] staging: vchiq: Release firmware handle on unbind

2021-01-26 Thread Greg KH
On Mon, Jan 18, 2021 at 01:32:40PM +0100, Nicolas Saenz Julienne wrote: > Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware > interface when unbinding the device. > > Signed-off-by: Nicolas Saenz Julienne > Reviewed-by: Florian Fainelli > --- > drivers/staging/vc04_servic

Re: [PATCH 1/4] This merely adds the missing synth parameter to all io functions.

2021-01-26 Thread Greg KH
On Mon, Jan 11, 2021 at 11:37:34PM +0100, Samuel Thibault wrote: > Signed-off-by: Samuel Thibault I can't take a patch without any changelog text :( Can you fix this up and resend the series? Sorry for the delay in reviewing this. greg k-h

Re: [PATCH v2 0/3] VMCI: Queue pair bug fixes

2021-01-26 Thread Greg KH
On Wed, Jan 20, 2021 at 08:32:04AM -0800, Jorgen Hansen wrote: > This series contains three bug fixes for the queue pair > implementation in the VMCI driver. > > v1 -> v2: > - format patches as a series > - use min_t instead of min to ensure size_t comparison > (issue pointed out by kernel

Re: [PATCH -next] usb: core: Remove unused including

2021-01-26 Thread Greg KH
On Mon, Jan 25, 2021 at 08:44:48PM +0800, Zou Wei wrote: > Fix the following versioncheck warning: > > drivers/usb/core/hcd.c:14:1: unused including > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/usb/core/hcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/dri

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 10:19:34AM -0600, Josh Poimboeuf wrote: > On Tue, Jan 26, 2021 at 10:15:52AM -0600, Justin Forbes wrote: > > On Tue, Jan 26, 2021 at 10:05 AM Peter Zijlstra > > wrote: > > > > > > On Tue, Jan 26, 2021 at 09:46:51AM -0600, Josh Poimboeuf wrote: > > > > On Tue, Jan 26, 2021

Re: [PATCH] Change 'addres' to 'address'.

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 12:53:48PM +0800, mateng wrote: > From: mateng > > Signed-off-by: mateng > --- > drivers/misc/vmw_vmci/vmci_queue_pair.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.h > b/drivers/misc/vmw_vmci/vmci_queu

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-26 Thread Greg KH
On Mon, Jan 25, 2021 at 03:27:55PM -0600, Josh Poimboeuf wrote: > On Tue, Jan 26, 2021 at 06:16:01AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 26, 2021 at 5:42 AM Josh Poimboeuf wrote: > > > > > > When building out-of-tree kernel modules, the build system doesn't > > > require the GCC version

Re: [PATCH -next] usb: gadget: Remove unused including

2021-01-26 Thread Greg KH
On Mon, Jan 25, 2021 at 08:41:32PM +0800, Zou Wei wrote: > Fix the following versioncheck warning: > > drivers/usb/gadget/udc/aspeed-vhub/hub.c:33:1: unused including > > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 - > 1 file chang

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-26 Thread Greg KH
On Mon, Jan 25, 2021 at 04:07:57PM -0600, Josh Poimboeuf wrote: > On Tue, Jan 26, 2021 at 06:44:35AM +0900, Masahiro Yamada wrote: > > > > If people use a different compiler, they must be > > > > prepared for any possible problem. > > > > > > > > Using different compiler flags for in-tree and out-o

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 08:51:55AM -0600, Josh Poimboeuf wrote: > On Tue, Jan 26, 2021 at 02:51:29PM +0100, Greg KH wrote: > > On Tue, Jan 26, 2021 at 06:44:44AM -0600, Justin Forbes wrote: > > > On Tue, Jan 26, 2021 at 2:21 AM Greg KH wrote: > > > > > > &g

Re: [PATCH 0/4] add xhci hooks for USB offload

2021-01-26 Thread Greg KH
On Fri, Jan 22, 2021 at 05:32:58PM +0200, Mathias Nyman wrote: > On 20.1.2021 12.04, Howard Yen wrote: > > On Tue, Jan 19, 2021 at 8:47 PM Mathias Nyman > > wrote: > >> > >> On 19.1.2021 12.10, Howard Yen wrote: > >>> To let the xhci driver support USB offload, add hooks for vendor to have > >>>

Re: [PATCH 01/12] docs: path-lookup: update follow_managed() part

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 03:24:32PM +0800, Fox Chen wrote: > No follow_managed() anymore, handle_mounts(), > traverse_mounts(), will do the job. > see commit: 9deed3ebca244663530782631834e706a86a8c8f When referencing commits in changelogs, please use the documented way, which for this one would be

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 06:44:44AM -0600, Justin Forbes wrote: > On Tue, Jan 26, 2021 at 2:21 AM Greg KH wrote: > > > > On Mon, Jan 25, 2021 at 04:07:57PM -0600, Josh Poimboeuf wrote: > > > On Tue, Jan 26, 2021 at 06:44:35AM +0900, Masahiro Yamada wrote: > > >

Re: [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 05:49:13PM +0800, Ray Chi wrote: > Currently, role init functions are used in dwc3 driver but > can't be called from kernel modules. > dwc3_host_init > dwc3_host_exit > dwc3_gadget_init > dwc3_gadget_exit > dwc3_event_buffers_setup > dwc3_event_buffers_cleanup >

Re: [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 08:14:02PM +0800, Ray Chi wrote: > On Tue, Jan 26, 2021 at 6:01 PM Greg KH wrote: > > > > On Tue, Jan 26, 2021 at 05:49:13PM +0800, Ray Chi wrote: > > > Currently, role init functions are used in dwc3 driver but > > > ca

Re: [PATCH] misc/vmw_vmci: fix typo

2021-01-26 Thread Greg KH
On Tue, Jan 26, 2021 at 04:40:10PM +0800, mateng wrote: > From: mateng > > change 'addres' to 'address' > > Signed-off-by: mateng > --- > drivers/misc/vmw_vmci/vmci_queue_pair.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.h >

Re: [STABLE BACKPORT v2 4.4.y, 4.9.y and 4.14.y] compiler.h: Raise minimum version of GCC to 5.1 for arm64

2021-01-25 Thread Greg KH
On Mon, Jan 25, 2021 at 01:24:25PM +, Will Deacon wrote: > commit dca5244d2f5b94f1809f0c02a549edf41ccd5493 upstream. > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > beyond the stack pointer, resulting in memory corruption if an interrupt > is taken after the stack

Re: [GIT PULL] Staging/IIO driver fixes for 5.11-rc5

2021-01-25 Thread Greg KH
On Sun, Jan 24, 2021 at 11:31:59AM -0800, Linus Torvalds wrote: > On Sun, Jan 24, 2021 at 4:58 AM Greg KH wrote: > > > > David Lechner (1): > > counter:ti-eqep: remove floor > > I'm not sure why that ti-eqep counter driver seems to be in your > "

Re: [PATCH v2] fbtft: add tearing signal detect

2021-01-25 Thread Greg KH
On Mon, Jan 25, 2021 at 04:44:12PM +0800, Carlis wrote: > From: "carlis.zhang_cp" I need a "real" name here, and in the signed-off-by: area as I do not think you sign documents with a "." and "_", right? thanks, greg k-h

Re: [PATCH v2] usb: typec: tcpci_maxim: remove redundant assignment

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 09:31:37PM +0800, angkery wrote: > From: Junlin Yang > > PTR_ERR(chip->tcpci) has been used as a return value, > it is not necessary to assign it to ret, so remove it. > And add terminating '\n' to the formats where missed too. > > Signed-off-by: Junlin Yang > --- > v2:

[GIT PULL] Char/Misc driver fixes for 5.11-rc5

2021-01-24 Thread Greg KH
The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git tags/char-misc-5.11-rc5 for you to fetch changes up to 31b08106

[GIT PULL] Staging/IIO driver fixes for 5.11-rc5

2021-01-24 Thread Greg KH
The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.11-rc5 for you to fetch changes up to a1bfb0ccf94d

[GIT PULL] Driver core fixes for 5.11-rc5

2021-01-24 Thread Greg KH
The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62: Linux 5.11-rc2 (2021-01-03 15:55:30 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-5.11-rc5 for you to fetch changes up to e020

[GIT PULL] TTY / Serial fixes for 5.11-rc5

2021-01-24 Thread Greg KH
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tags/tty-5.11-rc5 for you to fetch changes up to 17749851eb9ca2298e7c3

[GIT PULL] USB driver fixes for 5.11-rc5

2021-01-24 Thread Greg KH
The following changes since commit 7c53f6b671f4aba70ff15e1b05148b10d58c2837: Linux 5.11-rc3 (2021-01-10 14:34:50 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.11-rc5 for you to fetch changes up to ef02684c4e67d8c35ac83

Re: [PATCH v2 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 11:48:29AM +, Thokala, Srikanth wrote: > > > +{ > > > + struct pci_epf_bar *epf_bar; > > > + bool bar_fixed_64bit; > > > + int ret, i; > > > + > > > + for (i = BAR_0; i <= BAR_5; i++) { > > > + epf_bar = &epf->bar[i]; > > > + bar_fixed_64bit = !!(epc_feat

Re: [PATCH] trace: Fix race in trace_open and buffer resize call

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 03:26:33PM +0530, Gaurav Kohli wrote: > Below race can come, if trace_open and resize of You forgot to cc: stable, and put the git id that this patch is upstream...

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 03:27:25PM +0530, Gaurav Kohli wrote: > > > On 1/24/2021 8:51 AM, Steven Rostedt wrote: > > On Sat, 23 Jan 2021 22:03:27 +0530 > > Gaurav Kohli wrote: > > > > > > > Sure I will do, I have never posted on backport branches. Let me check > > > and post it. > > > > > > >

Re: [PATCH v2] PHY: Ingenic: Fixes: compile phy-ingenic-usb only if it was enabled

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 05:42:49PM +0800, Qiujun Huang wrote: > We should compile this driver only if we enable PHY_INGENIC_USB. > > Signed-off-by: Qiujun Huang > --- > v2: > Add a Fixes:tag and Cc linux-stable I don't see a Fixes: tag here :( This is not the correct way to submit patches for

Re: [PATCH v3 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-01-24 Thread Greg KH
On Sun, Jan 24, 2021 at 02:29:07PM +0800, Tianjia Zhang wrote: > In this scenario, there is no case where va_page is NULL, and > the error has been checked. The if condition statement here is > redundant, so remove the condition detection. > > Signed-off-by: Tianjia Zhang > --- > arch/x86/kernel

Re: Duplicate crash reports related with smsc75xx/smsc95xx and root cause analysis

2021-01-23 Thread Greg KH
On Sat, Jan 23, 2021 at 01:40:30PM +0800, 慕冬亮 wrote: > Dear kernel developers, > > I found that on the syzbot dashboard, “KMSAN: uninit-value in > smsc75xx_read_eeprom (2)” [1], > "KMSAN: uninit-value in smsc95xx_read_eeprom (2)" [2], "KMSAN: > uninit-value in smsc75xx_bind" [3], > "KMSAN: uninit-

Re: [PATCH v1] trace: Fix race in trace_open and buffer resize call

2021-01-22 Thread Greg KH
On Thu, Jan 21, 2021 at 03:37:32PM -0500, Steven Rostedt wrote: > On Thu, 21 Jan 2021 23:15:22 +0300 > Denis Efremov wrote: > > > On 1/21/21 10:09 PM, Steven Rostedt wrote: > > > On Thu, 21 Jan 2021 17:30:40 +0300 > > > Denis Efremov wrote: > > > > > >> Hi, > > >> > > >> This patch (CVE-2020-

Re: [PATCH v4] Fixes: misc: rtsx: init value of aspm_enabled

2021-01-22 Thread Greg KH
On Fri, Jan 22, 2021 at 09:55:44AM +, 吳昊澄 Ricky wrote: > > -Original Message- > > From: Greg KH > > Sent: Friday, January 22, 2021 4:28 PM > > To: 吳昊澄 Ricky > > Cc: a...@arndb.de; bhelg...@google.com; vaibhavgupt...@gmail.com; > > linux-kernel@vge

Re: [PATCH] scsi: megaraid_sas: remove redundant NULL check

2021-01-22 Thread Greg KH
On Fri, Jan 22, 2021 at 05:23:44PM +0800, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./drivers/scsi/megaraid/megaraid_sas_fusion.c:3924:3-8: WARNING: NULL > check before some freeing functions is not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > driver

Re: [PATCH v4] Fixes: misc: rtsx: init value of aspm_enabled

2021-01-22 Thread Greg KH
On Fri, Jan 22, 2021 at 04:19:06PM +0800, ricky...@realtek.com wrote: > From: Ricky Wu > > make sure ASPM state sync with pcr->aspm_enabled > init value pcr->aspm_enabled > > Cc: sta...@vger.kernel.org > Signed-off-by: Ricky Wu > --- > > v2: fixed conditions in v1 if-statement > v3: give descr

Re: [PATCH] objtool: Don't fail the kernel build on fatal errors

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 08:32:35AM +0100, György Andrasek wrote: > I'm rejecting both these morons as invalid. Please review everything they've > been doing lately. As Stephen said, please take this elsewhere, it does not belong on the Linux kernel mailing lists. greg k-h

Re: [PATCH v3] misc: rtsx: init value of aspm_enabled

2021-01-21 Thread Greg KH
On Fri, Jan 22, 2021 at 11:33:48AM +0800, ricky...@realtek.com wrote: > From: Ricky Wu > > v1: > make sure ASPM state sync with pcr->aspm_enabled > init value pcr->aspm_enabled > v2: > fixes conditions in v1 if-statement > v3: > more description for v1 and v2 > > Cc: sta...@vger.kernel.org > Sig

Re: [PATCH v3] misc: rtsx: init value of aspm_enabled

2021-01-21 Thread Greg KH
On Fri, Jan 22, 2021 at 11:33:48AM +0800, ricky...@realtek.com wrote: > From: Ricky Wu > > v1: > make sure ASPM state sync with pcr->aspm_enabled > init value pcr->aspm_enabled > v2: > fixes conditions in v1 if-statement > v3: > more description for v1 and v2 This needs to go below the --- line.

Re: [git pull] habanalabs fixes for 5.11-rc5

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 09:25:14PM +0200, Oded Gabbay wrote: > Hi Greg, > > This pull request contains three important bug fixes for 5.11-rc5. > One of the fixes prevent a possible host machine crash, another > one prevents random card reset and the third adds a missing > backward compatibility to

Re: "KMSAN: uninit-value in rt2500usb_bbp_read" and "KMSAN: uninit-value in rt2500usb_probe_hw" should be duplicate crash reports

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 04:47:37PM +0800, 慕冬亮 wrote: > Dear kernel developers, > > I found that on the syzbot dashboard, “KMSAN: uninit-value in > rt2500usb_bbp_read” [1] and "KMSAN: uninit-value in > rt2500usb_probe_hw" [2] should share the same root cause. > > ## Duplication > > The reasons fo

Re: [PATCH v2] misc: rtsx: init value of aspm_enabled

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 07:07:04PM +0800, ricky...@realtek.com wrote: > From: Ricky Wu > > make sure ASPM state sync with pcr->aspm_enabled > init value pcr->aspm_enabled > > Signed-off-by: Ricky Wu > --- > drivers/misc/cardreader/rtsx_pcr.c | 7 ++- > 1 file changed, 6 insertions(+), 1 de

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:52:46PM +0800, Dongliang Mu wrote: > In the function rt2500usb_register_read(_lock), reg is uninitialized > in some situation. Then KMSAN reports uninit-value at its first memory > access. To fix this issue, initialize reg with zero in the function > rt2500usb_register_re

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > On Thu, Jan 21, 2021 at 5:49 PM Greg KH wrote: > > > > On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > > > In the function rt2500usb_register_read(_lock), reg is uninitialized > > > in some sit

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:59:08PM +0800, 慕冬亮 wrote: > > > rt2x00usb_vendor_request_buff(rt2x00dev, USB_MULTI_READ, > > > USB_VENDOR_REQUEST_IN, offset, > > > ®, sizeof(reg)); > > > > Are you sure this is valid to call th

Re: [PATCH] misc: rtsx: init value of aspm_enabled

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 06:35:59PM +0800, ricky...@realtek.com wrote: > From: Ricky Wu > > make sure ASPM state sync with pcr->aspm_enabled > init value pcr->aspm_enabled > > Signed-off-by: Ricky Wu > --- > drivers/misc/cardreader/rtsx_pcr.c | 7 ++- > 1 file changed, 6 insertions(+), 1 de

Re: [PATCH] rt2x00: reset reg earlier in rt2500usb_register_read

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 05:20:26PM +0800, Dongliang Mu wrote: > In the function rt2500usb_register_read(_lock), reg is uninitialized > in some situation. Then KMSAN reports uninit-value at its first memory > access. To fix this issue, add one reg initialization in the function > rt2500usb_register_

Re: "possible deadlock in console_lock_spinning_enable" and "possible deadlock in console_unlock" should be duplicate crash behaviors

2021-01-21 Thread Greg KH
On Thu, Jan 21, 2021 at 01:37:05PM +0800, 慕冬亮 wrote: > Dear kernel developers, > > I found that on the syzbot dashboard, “possible deadlock in > console_lock_spinning_enable”[1] and "possible deadlock in > console_unlock"[2] should share the same root cause. > > The reasons for the above statemen

Re: [PATCH 3/3] libnvdimm/ioctl: Switch to cdev_register_queued()

2021-01-21 Thread Greg KH
On Wed, Jan 20, 2021 at 11:39:08AM -0800, Dan Williams wrote: > The ioctl implementation in libnvdimm is a case study in what can be > cleaned up when the cdev core handles synchronizing in-flight ioctls > with device removal. Switch to cdev_register_queued() which allows for > the ugly context loo

Re: [PATCH 1/3] cdev: Finish the cdev api with queued mode support

2021-01-21 Thread Greg KH
On Wed, Jan 20, 2021 at 11:38:57AM -0800, Dan Williams wrote: > -void cdev_del(struct cdev *p) > +void cdev_del(struct cdev *cdev) > { > - cdev_unmap(p->dev, p->count); > - kobject_put(&p->kobj); > + cdev_unmap(cdev->dev, cdev->count); > + kobject_put(&cdev->kobj); After Christoph

Re: [PATCH] rtsx: pci: fix device aspm state bug

2021-01-20 Thread Greg KH
On Thu, Jan 21, 2021 at 03:28:58PM +0800, ricky...@realtek.com wrote: > From: Ricky Wu > > changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() > make sure pcr->aspm_enabled to sync with aspm state Can you make this a bit more descriptive? > > BUG=b:175338107 > TEST=chromeos-kernel-5_4 Wha

Re: PING: [PATCH v5 0/2] misc: pvpanic: introduce capability & event attribute

2021-01-20 Thread Greg KH
On Mon, Jan 18, 2021 at 09:42:57AM +0800, zhenwei pi wrote: > Hi, Greg > > What's the next step I should take? I need some reviews by the people who will be doing the qemu portion of this, or someone else, please. thanks, greg k-h

Re: [PATCH v2 15/34] misc: xlink-pcie: Add XLink API interface

2021-01-20 Thread Greg KH
On Fri, Jan 08, 2021 at 01:25:41PM -0800, mgr...@linux.intel.com wrote: > From: Srikanth Thokala > > Provide interface for XLink layer to interact with XLink PCIe transport > layer on both local host and remote host. > > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Reviewed-by: Mark Gross > S

Re: [PATCH v2 09/34] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

2021-01-20 Thread Greg KH
On Fri, Jan 08, 2021 at 01:25:35PM -0800, mgr...@linux.intel.com wrote: > From: Srikanth Thokala > > Add PCIe EPF driver for local host (lh) to configure BAR's and other > HW resources. Underlying PCIe HW controller is a Synopsys DWC PCIe core. > > Cc: Derek Kiernan > Cc: Dragan Cvetic > Cc: A

Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-20 Thread Greg KH
On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote: > Hi, > > On 1/14/21 3:50 PM, Kyle Tso wrote: > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyle...@google.com > > > > "usb: typec: tcpm: AMS and Collision Avoidance" > > - removed the signed-off > > - modified the codin

Re: [STABLE BACKPORT 4.19.y and 5.14.y] compiler.h: Raise minimum version of GCC to 5.1 for arm64

2021-01-20 Thread Greg KH
On Mon, Jan 18, 2021 at 01:57:00PM +, Will Deacon wrote: > commit dca5244d2f5b94f1809f0c02a549edf41ccd5493 upstream. > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > beyond the stack pointer, resulting in memory corruption if an interrupt > is taken after the stack

Re: linux-next: manual merge of the usb tree with the usb.current tree

2021-01-20 Thread Greg KH
On Wed, Jan 20, 2021 at 01:06:03PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the usb tree got a conflict in: > > drivers/usb/gadget/udc/bdc/Kconfig > > between commit: > > ef02684c4e67 ("usb: bdc: Make bdc pci driver depend on BROKEN") > > from the usb.curren

Re: “KASAN: null-ptr-deref Write in event_handler” and "KASAN: null-ptr-deref Write in vhci_shutdown_connection" should share the same root cause.

2021-01-19 Thread Greg KH
On Wed, Jan 20, 2021 at 11:22:11AM +0800, 慕冬亮 wrote: > Dear kernel developers, > > I found that on the syzbot dashboard, “KASAN: null-ptr-deref Write in > event_handler”[1] and > "KASAN: null-ptr-deref Write in vhci_shutdown_connection" () should > share the same root cause. > > > The reasons fo

Re: [PATCH v2] kbuild: give the SUBLEVEL more room in KERNEL_VERSION

2021-01-19 Thread Greg KH
On Mon, Jan 18, 2021 at 02:54:53PM -0500, Sasha Levin wrote: > SUBLEVEL only has 8 bits of space, which means that we'll overflow it > once it reaches 256. > > Few of the stable branches will imminently overflow SUBLEVEL while > there's no risk of overflowing VERSION. > > Thus, give SUBLEVEL 8 mo

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 01:36:22PM +0100, Roger Pau Monné wrote: > Forgot to Cc stable for the Fixes tag. Doing it now. This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Re: [PATCH 0/4] add xhci hooks for USB offload

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 06:10:40PM +0800, Howard Yen wrote: > To let the xhci driver support USB offload, add hooks for vendor to have > customized behavior for the initialization, memory allocation, irq work, and > device context synchronization. Detail is in each patch commit message. > > Howar

Re: [PATCH 1/4] usb: host: add xhci hooks for USB offload

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 06:10:41PM +0800, Howard Yen wrote: > To enable supporting for USB offload, define "offload" in usb controller > node of device tree. "offload" value can be used to determine which type > of offload was been enabled in the SoC. > > For example: > > &usbdrd_dwc3 { > .

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 03:12:50PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > > This patch series adds support for UCI driver. UCI

Re: [PATCH 4/4] dt-bindings: usb: usb-xhci: add USB offload support

2021-01-19 Thread Greg KH
On Tue, Jan 19, 2021 at 06:10:44PM +0800, Howard Yen wrote: > Document USB offload support for usb-xhci. > > For example: > > &usbdrd_dwc3 { > ... > /* support usb offloading, 0: disabled, 1: audio */ > offload = <1>; > ... > }; > > Signed-off-by: Howard Yen > --- > Doc

Re: [PATCH] PM / devfreq: Add sysfs attributes to simple_ondemand governor

2021-01-18 Thread Greg KH
On Mon, Jan 18, 2021 at 05:56:06PM +, Lukasz Luba wrote: > > > On 1/18/21 5:17 PM, Greg KH wrote: > > On Fri, Jan 15, 2021 at 05:05:30PM +, Lukasz Luba wrote: > > > The simple_ondemand devfreq governor is used by quite a few devices, like > > > GPUs,

Re: [PATCH] PM / devfreq: Add sysfs attributes to simple_ondemand governor

2021-01-18 Thread Greg KH
On Fri, Jan 15, 2021 at 05:05:30PM +, Lukasz Luba wrote: > The simple_ondemand devfreq governor is used by quite a few devices, like > GPUs, DSPs, memory controllers, etc. It implements algorithm which tries > to predict the device frequency based on past statistics. There are two > tunables fo

Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION

2021-01-18 Thread Greg KH
On Mon, Jan 18, 2021 at 10:31:35AM -0500, Sasha Levin wrote: > On Mon, Jan 18, 2021 at 02:52:02PM +0100, Greg KH wrote: > > On Mon, Jan 18, 2021 at 08:39:59AM -0500, Sasha Levin wrote: > > > I think it would also affect code that doesn't do things based on > > > S

Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION

2021-01-18 Thread Greg KH
On Mon, Jan 18, 2021 at 08:39:59AM -0500, Sasha Levin wrote: > On Mon, Jan 18, 2021 at 10:24:33AM +0100, Greg KH wrote: > > On Mon, Jan 18, 2021 at 10:21:16AM +0100, Greg KH wrote: > > > On Sun, Jan 17, 2021 at 08:49:51PM -0500, Sasha Levin wrote: > > > > SUBLEVEL o

Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION

2021-01-18 Thread Greg KH
On Mon, Jan 18, 2021 at 07:27:51PM +0900, Masahiro Yamada wrote: > On Mon, Jan 18, 2021 at 6:21 PM Greg KH wrote: > > > > On Sun, Jan 17, 2021 at 08:49:51PM -0500, Sasha Levin wrote: > > > SUBLEVEL only has 8 bits of space, which means that we'll overflow

Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION

2021-01-18 Thread Greg KH
On Mon, Jan 18, 2021 at 10:21:16AM +0100, Greg KH wrote: > On Sun, Jan 17, 2021 at 08:49:51PM -0500, Sasha Levin wrote: > > SUBLEVEL only has 8 bits of space, which means that we'll overflow it > > once it reaches 256. > > > > Few of the stable branches will im

Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION

2021-01-18 Thread Greg KH
On Sun, Jan 17, 2021 at 08:49:51PM -0500, Sasha Levin wrote: > SUBLEVEL only has 8 bits of space, which means that we'll overflow it > once it reaches 256. > > Few of the stable branches will imminently overflow SUBLEVEL while > there's no risk of overflowing VERSION. > > Thus, give SUBLEVEL 8 mo

Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-17 Thread Greg KH
On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver leverages the uio_pdrv_genirq, it adds the uio_pdrv_genirq > platform device with the DFL devi

Re: PROBLEM: Firmware loader fallback mechanism no longer works with sendfile

2021-01-15 Thread Greg KH
On Tue, Jan 12, 2021 at 10:31:26AM -0800, Siddharth Gupta wrote: > > On 1/8/2021 6:44 AM, Greg KH wrote: > > On Thu, Jan 07, 2021 at 02:03:47PM -0800, Siddharth Gupta wrote: > > > On 1/6/2021 2:33 AM, Greg KH wrote: > > > > > > > Since the binary a

Re: [PATCH v2 3/5] docs: ABI: add /sys/kernel/error_report/ documentation

2021-01-15 Thread Greg KH
On Fri, Jan 15, 2021 at 04:26:21PM +0100, Alexander Potapenko wrote: > > sysfs is "one value per file" > What about existing interfaces that even export binary blobs through > sysfs (e.g. /sys/firmware, /sys/boot_params)? > What qualifies as a "value" in that case? binary files are fine as the ker

Re: [PATCH v2 0/3] Remove one more platform_device_add_properties() call

2021-01-15 Thread Greg KH
On Fri, Jan 15, 2021 at 04:01:37PM +0100, Greg KH wrote: > On Tue, Jan 12, 2021 at 12:49:14PM +0100, Greg KH wrote: > > On Mon, Jan 11, 2021 at 05:10:42PM +0300, Heikki Krogerus wrote: > > > Hi Felipe, Rafael, > > > > > > This is the second version of th

Re: [PATCH v2 0/3] Remove one more platform_device_add_properties() call

2021-01-15 Thread Greg KH
On Tue, Jan 12, 2021 at 12:49:14PM +0100, Greg KH wrote: > On Mon, Jan 11, 2021 at 05:10:42PM +0300, Heikki Krogerus wrote: > > Hi Felipe, Rafael, > > > > This is the second version of this series. There are no real changes, > > but I added the Tiger Lake ID patch to

Re: [PATCH v2 2/5] lib: add error_report_notify to collect debugging tools' reports

2021-01-15 Thread Greg KH
Minor comments, if in the future, you really do want to mess around in sysfs: On Fri, Jan 15, 2021 at 02:03:33PM +0100, Alexander Potapenko wrote: > diff --git a/lib/error_report_notify.c b/lib/error_report_notify.c > new file mode 100644 > index ..66176cd94ba0 > --- /dev/null > +++ b/

Re: [PATCH v2 3/5] docs: ABI: add /sys/kernel/error_report/ documentation

2021-01-15 Thread Greg KH
On Fri, Jan 15, 2021 at 02:03:34PM +0100, Alexander Potapenko wrote: > Add ABI documentation for files in /sys/kernel/error_report/ > > Requested-by: Andrew Morton > Cc: Andrew Morton > Cc: Andrey Konovalov > Cc: Dmitry Vyukov > Cc: Ingo Molnar > Cc: Marco Elver > Cc: Petr Mladek > Cc: Stev

Re: [PATCH] drivers/tty: Use bitwise instead of arithmetic operator for flags

2021-01-15 Thread Greg KH
On Fri, Jan 15, 2021 at 06:03:51PM +0800, Jiapeng Zhong wrote: > Fix the following coccicheck warning: > > ./drivers/tty/synclink_gt.c:4384:15-16: WARNING: sum of probable > bitmasks, consider | > ./drivers/tty/synclink_gt.c:4342:39-40: WARNING: sum of probable > bitmasks, consider | > ./drivers/t

Re: [PATCH v3] tty: make pl011 serial port driver support 485 mode

2021-01-14 Thread Greg KH
On Fri, Jan 15, 2021 at 02:32:39AM +, zhangqiumiao wrote: > On Thu, Jan 14, 2021 at 08:28:30PM +0800, zhangqiumi...@huawei.com wrote: > > From: Qiumiao Zhang > > > > make pl011 serial port support 485 mode full duplex communication > > > > Signed-off-by: Qiumiao Zhang > > --- > > Changes in

Re: [PATCH v3] tty: make pl011 serial port driver support 485 mode

2021-01-14 Thread Greg KH
On Thu, Jan 14, 2021 at 08:28:30PM +0800, zhangqiumi...@huawei.com wrote: > From: Qiumiao Zhang > > make pl011 serial port support 485 mode full duplex communication > > Signed-off-by: Qiumiao Zhang > --- > Changes in v3: > -Fix busy loop forever in pl011_tx_empty > -Move the definition of

Re: [PATCH v3] tty: make pl011 serial port driver support 485 mode

2021-01-14 Thread Greg KH
On Thu, Jan 14, 2021 at 05:07:33PM +0800, zhangqiumi...@huawei.com wrote: > From: Qiumiao Zhang > > make pl011 serial port support 485 mode full duplex communication > > --- > Changes in v3: > -Fix busy loop forever in pl011_tx_empty > -Move the definition of cr into uart_amba_port > -run

Re: [PATCH 0/3] Fix broken references at next-20210114 due to yaml conversion

2021-01-14 Thread Greg KH
On Thu, Jan 14, 2021 at 07:25:57AM +0100, Mauro Carvalho Chehab wrote: > Three new broken references were added between next-20210113 and > next-20210114, due to yaml conversion. > > Address them. > > Please add those patches at the same tree as the respective > conversion changesets were added

Re: linux-next: build warning after merge of the usb tree

2021-01-14 Thread Greg KH
On Thu, Jan 14, 2021 at 09:48:56AM +1100, Stephen Rothwell wrote: > Hi all, > > On Wed, 6 Jan 2021 13:12:25 +1100 Stephen Rothwell > wrote: > > > > After merging the usb tree, today's linux-next build (htmldocs) produced > > this warning: > > > > drivers/usb/dwc3/core.h:1259: warning: Function

Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote: > In general, device drivers should not be enabled by default. > > Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") > Signed-off-by: Geert Uytterhoeven > --- > drivers/net/usb/Kconfig | 1 - > 1 file chan

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 12:51:26PM +0100, Christoph Hellwig wrote: > On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -413,6 +413,7 @@ struct dev_links_info { > > > * @dm

Re: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls

2021-01-13 Thread Greg KH
On Tue, Jan 12, 2021 at 01:03:08PM -0800, Dan Williams wrote: > On Sun, Jan 10, 2021 at 7:06 AM Greg KH wrote: > > > > On Sat, Jan 09, 2021 at 01:49:42PM -0800, Dan Williams wrote: > > > On Sat, Jan 9, 2021 at 12:34 AM Greg KH > > > wrote: > > > &g

Re: [git pull] habanalabs fixes for 5.11-rc4

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 09:52:53AM +0200, Oded Gabbay wrote: > Hi Greg, > > This pull request contains three important bug fixes for 5.11-rc4. > Basically the driver won't work without the dma address fix, and > IMO the two other fixes are also improtant enough to be included > at this stage. >

Re: [PATCH v3 6/6] libnvdimm/namespace: Fix visibility of namespace resource attribute

2021-01-13 Thread Greg KH
On Tue, Jan 12, 2021 at 11:35:50PM -0800, Dan Williams wrote: > Legacy pmem namespaces lost support for the "resource" attribute when > the code was cleaned up to put the permission visibility in the > declaration. Restore this by listing 'resource' in the default > attributes. > > A new ndctl reg

Re: "UBSAN: shift-out-of-bounds in mceusb_dev_recv" should share the same root cause with "UBSAN: shift-out-of-bounds in mceusb_dev_printdata"

2021-01-12 Thread Greg KH
On Wed, Jan 13, 2021 at 01:04:44PM +0800, 慕冬亮 wrote: > Hi developers, > > I found that "UBSAN: shift-out-of-bounds in mceusb_dev_recv" and > "UBSAN: shift-out-of-bounds in mceusb_dev_printdata" should share the > same root cause. > The reason is that the PoCs after minimization has a high similari

Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver

2021-01-12 Thread Greg KH
On Tue, Jan 12, 2021 at 02:15:59PM +0200, Adrian Catangiu wrote: > +``read()``: > + Read is meant to provide the *new* system generation counter when a > + generation change takes place. The read operation blocks until the > + associated counter is no longer up to date, at which point the new >

Re: [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-12 Thread Greg KH
On Tue, Jan 12, 2021 at 12:57:28PM +0100, Hans de Goede wrote: > Hi, > > On 1/12/21 12:53 PM, Greg KH wrote: > > On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote: > >> This series include previous patch "[v4] AMS and Collision Avoidance&qu

Re: [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error

2021-01-12 Thread Greg KH
On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote: > This series include previous patch "[v4] AMS and Collision Avoidance" > https://lore.kernel.org/r/20201217030632.903718-1-kyle...@google.com > and two more patches "Protocol Error handling" and "Respond Wait if...". > > The patch "AMS and

Re: [PATCH v2 0/3] Remove one more platform_device_add_properties() call

2021-01-12 Thread Greg KH
On Mon, Jan 11, 2021 at 05:10:42PM +0300, Heikki Krogerus wrote: > Hi Felipe, Rafael, > > This is the second version of this series. There are no real changes, > but I added the Tiger Lake ID patch to this series in hope that it > will make your life a bit easier, assuming that Rafael will still p

Re: [PATCH] char_dev: replace cdev_map with an xarray

2021-01-12 Thread &#x27;Greg KH'
On Tue, Jan 12, 2021 at 10:00:25AM +, David Laight wrote: > From: Greg KH > > Sent: 12 January 2021 09:35 > > > > On Mon, Jan 11, 2021 at 08:58:18PM +, Matthew Wilcox wrote: > > > On Mon, Jan 11, 2021 at 06:05:13PM +0100, Christoph Hellwig wrote: > > &g

Re: [PATCH] char_dev: replace cdev_map with an xarray

2021-01-12 Thread Greg KH
On Mon, Jan 11, 2021 at 08:58:18PM +, Matthew Wilcox wrote: > On Mon, Jan 11, 2021 at 06:05:13PM +0100, Christoph Hellwig wrote: > > @@ -486,14 +491,22 @@ int cdev_add(struct cdev *p, dev_t dev, unsigned > > count) > > if (WARN_ON(dev == WHITEOUT_DEV)) > > return -EBUSY; > >

Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:36:29PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") > Ac

Re: [PATCH v2] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

2021-01-11 Thread Greg KH
On Tue, Jan 12, 2021 at 01:32:27PM +0800, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Signed-off-by: Cindy Lu > --- > drivers/vhost/vdpa.c | 2 +- > 1 file ch

<    5   6   7   8   9   10   11   12   13   14   >