RE: [PATCH] 8250_pci.c: Update NI specific devices class to multi serial

2019-01-28 Thread Guan Yung Tseng
> On Wed, Jan 23, 2019 at 5:18 PM Andy Shevchenko > wrote: > > > > On Mon, Jan 14, 2019 at 4:13 PM Guan Yung Tseng > > wrote: > > > > > > Modified NI devices class to PCI_CLASS_COMMUNICATION_MULTISERIAL. > > > The reason of doing this i

[PATCH] 8250_pci.c: Update NI specific devices class to multi serial

2019-01-23 Thread Guan Yung Tseng
> On Wed, Jan 23, 2019 at 5:18 PM Andy Shevchenko > wrote: > > > > On Mon, Jan 14, 2019 at 4:13 PM Guan Yung Tseng > > wrote: > > > > > > Modified NI devices class to PCI_CLASS_COMMUNICATION_MULTISERIAL. > > > The reason of doing this i

[PATCH v2] 8250_pci.c: Update NI specific devices class to multi serial

2019-01-22 Thread Guan Yung Tseng
On, Jan 14, 2019 at 10:10:05PM +0800, Guan Yung Tseng wrote: >> Modified NI devices class to PCI_CLASS_COMMUNICATION_MULTISERIAL. >> The reason of doing this is because all NI multi port serial cards >> use PCI_CLASS_COMMUNICATION_OTHER class and thus fail the >> serial_pc

[PATCH v2] 8250_pci.c: Update NI specific devices class to multi serial

2019-01-15 Thread Guan Yung Tseng
evice after we check black list"). Signed-off-by: Guan Yung Tseng --- Changes in v2: - added comment to pci_ni_probe function drivers/tty/serial/8250/8250_pci.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/s

[PATCH] 8250_pci.c: Update NI specific devices class to multi serial

2019-01-14 Thread Guan Yung Tseng
evice after we check black list"). Signed-off-by: Guan Yung Tseng --- drivers/tty/serial/8250/8250_pci.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 4986b4a..0949db1 100644 --- a/d

[PATCH v2] 8250_pci.c: Only check for communication class in serial_pci_guess_board

2019-01-11 Thread Guan Yung Tseng
se devices are correctly listed in serial_pci_tbl, we shouldn't need to check the PCI class IDs. This change relocates the class checking solely into "serial_pci_guess_board" where it had been before so that the class-check doesn't hinder initialization. Signed-off-by: Guan Yung Tsen

Re:[PATCH] 8250_pci.c: Only check for communication class in serial_pci_guess_board

2019-01-10 Thread Guan Yung Tseng
On Thu, Jan 10, 2019 at 04:12:12PM +0800, Guan Yung Tseng wrote: > Some multiport serial cards, such as the NI PXI-8430/2, NI PXI-8430/8, > and NI PXI-8432/4 use PCI_CLASS_COMMUNICATION_OTHER and this fail the > serial_pci_is_class_communication test added in the commit 7d8905d06405 &

[PATCH] 8250_pci.c: Only check for communication class in serial_pci_guess_board

2019-01-10 Thread Guan Yung Tseng
se devices are correctly listed in serial_pci_tbl, we shouldn't need to check the PCI class IDs. This change relocates the class checking solely into "serial_pci_guess_board" where it had been before so that the class-check doesn't hinder initialization. Signed-off-by: Guan Yung Tseng ---