Re: [PATCH V4 4/6] dt-bindings: csky: Add csky PMU bindings

2019-06-03 Thread Guo Ren
Reviewed-by: Guo Ren On Tue, Jun 4, 2019 at 10:25 AM Mao Han wrote: > > This patch adds the documentation to describe that how to add pmu node in > dts. > > Signed-off-by: Mao Han > Cc: Rob Herring > Cc: Guo Ren > --- > Documentation/devicetree

Re: [PATCH V4 2/6] csky: Add count-width property for csky pmu

2019-06-03 Thread Guo Ren
> be extend to 64 bits to avoid this, the extension bits base on the > count-width property from dts. > > Signed-off-by: Mao Han > Cc: Guo Ren > --- > arch/csky/kernel/perf_event.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a

Re: [PATCH V3 2/6] csky: Add reg-io-width property for csky pmu

2019-06-03 Thread Guo Ren
init_fn(_pmu); > } > > + if (!of_property_read_u32(node, "reg-io-width", _width)) { > + csky_pmu.sign_extend = 64 - cnt_width; 63? Please use count_width, see above. > + } else { > + csky_pmu.sign_extend = 16; Please define a macro for define DEFAULT_COUNT_WIDTH 48 and change the format like this: if (of_property_read_u32(node, "count-width", _pmu.count_width)) csky_pmu.count_width = DEFAULT_COUNT_WIDTH; Best Regards Guo Ren

Re: [PATCH RESEND 2/7] csky: entry: Remove unneeded need_resched() loop

2019-05-28 Thread Guo Ren
Thx Valentin, You are right, Approved. Best Regards Guo Ren On Tue, May 28, 2019 at 11:48:43AM +0100, Valentin Schneider wrote: > Since the enabling and disabling of IRQs within preempt_schedule_irq() > is contained in a need_resched() loop, we don't need the outer arch >

Re: [PATCH V3 2/2] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-21 Thread Guo Ren
Thx Marc, On Tue, May 21, 2019 at 09:54:18AM +0100, Marc Zyngier wrote: > On 21/05/2019 08:22, Guo Ren wrote: > > Hi Marc, > > ping ... Any problem ? > > Pinging me twice in four days for a patch posted in the middle of the > merge window is a problem, yes. In general,

Re: [PATCH V3 2/2] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-21 Thread Guo Ren
Hi Marc, ping ... Any problem ? Thx Guo Ren 于2019年5月13日周一 下午5:55写道: > > From: Guo Ren > > Support 4 triger types: > - IRQ_TYPE_LEVEL_HIGH > - IRQ_TYPE_LEVEL_LOW > - IRQ_TYPE_EDGE_RISING > - IRQ_TYPE_EDGE_FALLING > > Support 0-255 priority setting for ea

Re: [PATCH V2 4/7] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-11 Thread Guo Ren
Thx Marc, On Fri, May 10, 2019 at 07:12:18PM +0100, Marc Zyngier wrote: > On Fri, 10 May 2019 09:25:10 +0100, > Guo Ren wrote: > > > > Thx Marc, > > > > Sorry for late reply: > > > > On Mon, Feb 18, 2019 at 02:38:23PM +, Marc Zyngier wrote

Re: [PATCH V2 5/7] dt-bindings: interrupt-controller: Update csky mpintc

2019-05-10 Thread Guo Ren
Thx Marc, On Mon, Feb 18, 2019 at 02:28:45PM +, Marc Zyngier wrote: > On Mon, 18 Feb 2019 10:04:41 +0800 > guo...@kernel.org wrote: > > > From: Guo Ren > > > > Add trigger type and priority setting for csky,mpintc. > > > > Changelog: > > - c

Re: [PATCH V2 4/7] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-10 Thread Guo Ren
Thx Marc, Sorry for late reply: On Mon, Feb 18, 2019 at 02:38:23PM +, Marc Zyngier wrote: > On Mon, 18 Feb 2019 10:04:40 +0800 > guo...@kernel.org wrote: > > > From: Guo Ren > > > > Support 4 triger types: > > - IRQ_TYPE_LEVEL_HIGH > > - IRQ_TYP

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-29 Thread Guo Ren
On Mon, Apr 29, 2019 at 01:11:43PM -0700, Palmer Dabbelt wrote: > On Mon, 22 Apr 2019 08:44:30 PDT (-0700), guo...@kernel.org wrote: > >From: Guo Ren > > > >The current riscv linux implementation requires SOC system to support > >memory coherence between all I/O dev

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-26 Thread Guo Ren
etc that need write-combining to get > acceptable performance I agree dma_alloc_wc is necessary, and we need add another more attribute bit in PTE: _PAGE_BUF. Perhaps using _PAGE_BUF + _PAGE_CACHE are better then _PAGE_CONHENCY. > - you need to decide what is supposed to happen when there are > multiple conflicting mappings for the same physical address. ^ What's the mulitple confilcing mappings ? Best Regards Guo Ren

Re: [GIT PULL] csky fixes for v5.1-rc7

2019-04-26 Thread Guo Ren
Re-send when the merge window opens. Ok. Best Regards Guo Ren

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-24 Thread Guo Ren
LB translation in hardware and shadow page tables is for stage 2 translation. Shadow page tables care vmid not asid. If hardware don't support H-extension (MMU 2-stages translation), it's hard to accept for virtualization performance. I don't think hypervisor is a real scene for GLOBAL in PTE. Are there other scene for GLOBAL in PTE? Best Regards Guo Ren

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-23 Thread Guo Ren
very different, but there are only 10 attribute-bits for riscv (In fact we've wasted two bits to support huge RV32-pfn :P). So I think it is time to merge these two bits before hardware supports GLOBAL. Reserve them for future! Best Regards Guo Ren

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-23 Thread Guo Ren
On Tue, Apr 23, 2019 at 07:55:48AM +0200, Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 08:13:48AM +0800, Guo Ren wrote: > > > We should probably start a working group for this ASAP unless we can > > > get another working group to help taking care of it. > >

Re: [PATCH] riscv: Support non-coherency memory model

2019-04-22 Thread Guo Ren
> > size_t size, > > */ > > void __iomem *ioremap(phys_addr_t offset, unsigned long size) > > { > > - return __ioremap_caller(offset, size, PAGE_KERNEL, > > + return __ioremap_caller(offset, size, PAGE_KERNEL_COHERENCY, > > __builtin_return_address(0)); > > } > > EXPORT_SYMBOL(ioremap); > > I think ioremap is a different story, and should be a separate patch. Ok Best Regards Guo Ren

Re: [PATCH V5 0/2] csky: perf callchain dwarf support

2019-04-19 Thread Guo Ren
Nice Job, Maomao Signed-off: Guo Ren On Mon, Apr 15, 2019 at 05:17:28PM +0800, Mao Han wrote: > This patch set add perf DWARF unwinding support for C-SKY. > Including user registers/stack dump API, and libdw support. > > CC: Guo Ren > > Changes since v4: > - remove s

Re: [PATCH 1/1] csky: add page fault perf event support

2019-04-19 Thread Guo Ren
Looks good, nice Job, Maomao On Thu, Apr 18, 2019 at 02:20:40PM +0800, Mao Han wrote: > This patch add support for page fault count, major fault count > and minorfault count. Without this patch page faults are not > sampled for perf event. > > Performance counter stats for

Re: [PATCH v4 2/3] csky: Add support for perf registers sampling

2019-04-15 Thread Guo Ren
th unwind library > and the registers/user stack dump support. > + return ((long *)regs)[idx]; return (u64)*((u32 *)regs + idx); Best Regards Guo Ren

Re: [PATCH v4 3/3] csky: Add support for libdw

2019-04-15 Thread Guo Ren
egs8", "%regs9", "%sp", > + "%lr", > + /* r16 ~ r23 */ > + "%exregs0", "%exregs1", "%exregs2", "%exregs3", "%exregs4", > + "%exregs5", "%exregs6", "%exregs7", > + /* r24 ~ r31 */ > + "%exregs8", "%exregs9", "%exregs10", "%exregs11", "%exregs12", > + "%exregs13", "%exregs14", "%tls", > + "%pc", "%cc", "%hi", "%lo", NULL, NULL, NULL, NULL, > + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > + NULL, NULL, NULL, NULL, "%vr0", "%vr1", "%vr2", "%vr3", > + "%vr4", "%vr5", "%vr6", "%vr7", "%vr8", "%vr9", "%vr10", "%vr11", > + "%vr12", "%vr13", "%vr14", "%vr15", NULL, NULL, "%epc", Remove vr0-vr15 first. > +}; > +#else > +#define CSKY_MAX_REGS 70 > +const char *csky_dwarf_regs_table[CSKY_MAX_REGS] = { > + /* r0 ~ r8 */ > + "%sp", "%regs9", "%a0", "%a1", "%a2", "%a3", "%regs0", "%regs1", > + /* r9 ~ r15 */ > + "%regs2", "%regs3", "%regs4", "%regs5", "%regs6", "%regs7", "%regs8", > + "%lr", > + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > + "%vap", "%cc", "%vfp", "%epc", "%hi", "%lo", "%fr0", "%fr1", > + "%fr2", "%fr3", "%fr4", "%fr5", "%fr6", "%fr7", "%fr8", "%fr9", > + "%fr10", "%fr11", "%fr12", "%fr13", "%fr14", "%fr15", "%fr16", "%fr17", > + "%fr18", "%fr19", "%fr20", "%fr21", "%fr22", "%fr23", "%fr24", "%fr25", > + "%fr26", "%fr27", "%fr28", "%fr29", "%fr30", "%fr31" Please remove vap cc vfp hi lo fr0~fr31, current abiv1 linux couldn't suppport them. Best Regards Guo Ren

Re: [PATCH v4 2/3] csky: Add support for perf registers sampling

2019-04-14 Thread Guo Ren
d library > and the registers/user stack dump support. > > CC: Guo Ren > > Signed-off-by: Mao Han > --- > arch/csky/Kconfig | 2 ++ > arch/csky/include/uapi/asm/perf_regs.h | 51 > ++ > arch/csky/kernel/Makefile

Re: [PATCH v2] RISC-V: Implement ASID allocator

2019-04-08 Thread Guo Ren
SATP CSR > are not implemented on SiFive Unleashed board so we don't see any change > in performance. Can you tell me what is the test case ? Best Regards Guo Ren

Re: [PATCH v2 2/2] csky: add support for libdw

2019-04-02 Thread Guo Ren
); \ > + val;\ > +}) > + > + dwarf_regs[0] = REG(R0); > + dwarf_regs[1] = REG(R1); > + dwarf_regs[2] = REG(R2); > + dwarf_regs[3] = REG(R3); > + dwarf_regs[4] = REG(R4); > + dwarf_regs[5] = REG(R5); > + dwarf_regs[6] = REG(R6); > + dwarf_regs[7] = REG(R7); > + dwarf_regs[8] = REG(R8); > + dwarf_regs[9] = REG(R9); > + dwarf_regs[10] = REG(R10); > + dwarf_regs[11] = REG(R11); > + dwarf_regs[12] = REG(R12); > + dwarf_regs[13] = REG(R13); > + dwarf_regs[14] = REG(SP); > + dwarf_regs[15] = REG(LR); > + dwarf_regs[16] = REG(R16); > + dwarf_regs[17] = REG(R17); > + dwarf_regs[18] = REG(R18); > + dwarf_regs[19] = REG(R19); > + dwarf_regs[20] = REG(R20); > + dwarf_regs[21] = REG(R21); > + dwarf_regs[22] = REG(R22); > + dwarf_regs[23] = REG(R23); > + dwarf_regs[24] = REG(R24); > + dwarf_regs[25] = REG(R25); > + dwarf_regs[26] = REG(R26); > + dwarf_regs[27] = REG(R27); > + dwarf_regs[28] = REG(R28); > + dwarf_regs[29] = REG(R29); > + dwarf_regs[30] = REG(R30); > + dwarf_regs[31] = REG(TLS); > + dwarf_regs[32] = REG(PC); > + dwfl_thread_state_register_pc(thread, dwarf_regs[32]); > + > + return dwfl_thread_state_registers(thread, 0, PERF_REG_CSKY_MAX, > +dwarf_regs); > +} Try LIBUNWIND__ARCH_REG_ID, see: tools/perf/arch/arm64/util/unwind-libunwind.c Best Regards Guo Ren

Re: [PATCH] csky: fix syscall_get_arguments() and syscall_set_arguments()

2019-03-29 Thread Guo Ren
Thx Dmitry, It works for me. Tested-by: Guo Ren Acked-by: Guo Ren On Fri, Mar 29, 2019 at 08:12:30PM +0300, Dmitry V. Levin wrote: > C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1] > fields of struct pt_regs. > > Due to an off-by-one bug and a bu

Re: [PATCH] riscv: fix syscall_get_arguments() and syscall_set_arguments()

2019-03-29 Thread Guo Ren
oo. > > Yes of course. I mentioned both of these fixes in my reply to Linus. The BUG is from this commit before upstream: https://github.com/c-sky/csky-linux/commit/b167422869e6a76b31bda639413efa2ba7e60432#diff-cdc97efef2ab02d6828fa545698f9311 I reference the riscv code without my mind, thx for all. Best Regards Guo Ren

Re: [PATCH] csky: Update syscall_trace_enter/exit implementation

2019-03-25 Thread Guo Ren
On Mon, Mar 25, 2019 at 08:03:39PM +0800, guo...@kernel.org wrote: > From: Guo Ren > > Previous syscall_trace implementation couldn't support AUDITSYSCALL and > SYSCALL_TRACEPOINTS. Now we redesign it to support audit_syscall > and syscall_tracepoints just like other archs'.

Re: [PATCH] csky: Update syscall_trace_enter/exit implementation

2019-03-25 Thread Guo Ren
ifdef __KERNEL__ code in the uapi namespace, > it defeats the idea of uapi. Doesn't it belong to non-uapi > include/asm/ptrace.h namespace? Yes, I should move __KERNEL__ codes into arch/csky/include/asm/ptrace.h. But it'll be another patch for the modification. Any other problems? Best Regards Guo Ren

Re: [PATCH] arch:csky:mm/fault.c : Remove duplicate header

2019-03-24 Thread Guo Ren
Approved, thx. On Sat, Mar 23, 2019 at 05:25:17PM +0530, jagdsh.li...@gmail.com wrote: > From: Jagadeesh Pagadala > > Remove duplicate header which is included twice. > > Signed-off-by: Jagadeesh Pagadala > --- > arch/csky/mm/fault.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] csky: remove redundant generic-y

2019-03-22 Thread Guo Ren
Thx Masahiro, Approved and I'll add it into my tree. Best Regards Guo Ren On Fri, Mar 22, 2019 at 08:19:14PM +0900, Masahiro Yamada wrote: > Since commit 7c8bc297 ("kbuild: warn redundant generic-y"), > redundant generic-y is reported. I missed to delete this one. > >

Re: [PATCH 7/8] csky: Use latest system call ABI

2019-02-18 Thread Guo Ren
> @@ -2,8 +2,6 @@ > // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > #define __ARCH_WANT_SYS_CLONE > -#define __ARCH_WANT_SET_GET_RLIMIT Seems it's not related to y2038 issue. Is __ARCH_WANT_SET_GET_RLIMIT no use ? > -#define __ARCH_WANT_TIME32_SYSCALLS Best Regards Guo Ren

Re: [PATCH 01/10] irqchip/csky: Support csky,dh7k SOC intc driver

2019-02-14 Thread Guo Ren
On Thu, Feb 14, 2019 at 02:03:52PM +, Marc Zyngier wrote: > On Tue, 29 Jan 2019 12:24:20 +, > guo...@kernel.org wrote: > > > > From: Guo Ren > > > > C-SKY dh7k SOC use simple APB interrupt controller and most of driver's > > implementation codes co

Re: [GIT PULL] csky fixes for v5.0-rc6

2019-02-12 Thread Guo Ren
ngs: interrupt-controller: Update csky mpintc I just send these patches to the mail-list before, but not get Ack. I'll add Cc in these patches and resend them to the mail list. > > Generally, those should get merged through the respective subsystem > trees as listed in the linux/MAINTAINERS file. Ok, I'll remove them in this pull request. Best Regards Guo Ren

Re: [GIT PULL] csky fixes for v5.0-rc6

2019-02-11 Thread Guo Ren
at post-rc6 time. Ok, I'll remove: irqchip/csky: Support csky,dh7k SOC intc driver dt-bindings: csky,apb-intc: Add dh7k SOC support Best Regards Guo Ren

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-23 Thread Guo Ren
intainer to choose "PFN_DOW()" or > >">> PAGE_SHIFT". > > > >Also the same with "end_of_DRAM & max_low_pfn". > > PFN_DOWN makes sense to me, as that's what we're trying to do here (round a > physical address down to page frame number). Am a I misunderstanding > something? > No, you got it :) Best Regards Guo Ren

Re: [PATCH V2 2/2] dt-bindings: interrupt-controller: Update csky mpintc

2019-01-21 Thread Guo Ren
On Mon, Jan 21, 2019 at 08:12:15AM -0600, Rob Herring wrote: > On Fri, Jan 18, 2019 at 10:53 AM wrote: > > > > From: Guo Ren > > > > Add trigger type and priority setting for csky,mpintc. > > > > Signed-off-by: Guo Ren > > --- > > .../

Re: [PATCH] irqchip/irq-csky-mpintc: Add triger type and priority setting

2019-01-18 Thread Guo Ren
On Fri, Jan 18, 2019 at 09:32:03AM +, Marc Zyngier wrote: > On 18/01/2019 06:28, Guo Ren wrote: > > Thx Marc, > > > > On Thu, Jan 17, 2019 at 05:17:45PM +, Marc Zyngier wrote: > >> Hi Guo, > >> > >> On 15/01/2019 16:36, guo...@kernel.org w

Re: [PATCH] arch/csky/mm/fault.c: Remove duplicate header

2019-01-18 Thread Guo Ren
Thx Brajeswar, Reviewed-by: Guo Ren Acked-by: Guo Ren On Fri, Jan 18, 2019 at 03:21:52PM +0530, Brajeswar Ghosh wrote: > Remove linux/kernel.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > --- > arch/csky/mm/fault.c | 1 - > 1 file changed, 1 del

Re: [PATCH] csky/kernel/entry: Remove duplicate heade

2019-01-17 Thread Guo Ren
Thx Brajeswar, Tested-by: Guo Ren Acked-by: Guo Ren On Thu, Jan 17, 2019 at 08:00:04PM +0530, Brajeswar Ghosh wrote: > Remove duplicate headers which are included more than once > > Signed-off-by: Brajeswar Ghosh > --- > arch/csky/kernel/entry.S | 1 - > 1 file c

Re: [PATCH] irqchip/irq-csky-mpintc: Add triger type and priority setting

2019-01-17 Thread Guo Ren
Thx Marc, On Thu, Jan 17, 2019 at 05:17:45PM +, Marc Zyngier wrote: > Hi Guo, > > On 15/01/2019 16:36, guo...@kernel.org wrote: > > From: Guo Ren > > > > Support 4 triger types: > > - IRQ_TYPE_LEVEL_HIGH > > - IRQ_TYPE_LEVEL_LOW > > - IRQ_

Re: [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

2019-01-16 Thread Guo Ren
__func__, PAGE_SIZE, > + PAGE_SIZE); > + > set_pmd(pmd, __pmd(__pa(pte))); > BUG_ON(pte != pte_offset_kernel(pmd, > 0)); > } Looks good for me and panic is ok. Reviewed-by: Guo Ren

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Guo Ren
Hi Christoph, I use PFN_DOWN() every where as possible and seems it's a habit problem. So let risc-v maintainer to choose "PFN_DOW()" or ">> PAGE_SHIFT". Also the same with "end_of_DRAM & max_low_pfn". Best Regards Guo Ren On Tue, Jan 15, 2019 at 0

Re: [PATCH] riscv: fixup max_low_pfn with PFN_DOWN.

2019-01-15 Thread Guo Ren
On Tue, Jan 15, 2019 at 07:36:13AM -0800, Christoph Hellwig wrote: > On Sat, Jan 12, 2019 at 04:16:27PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > max_low_pfn should be pfn_size not byte_size. > > > > Signed-off-by: Guo Ren > > Signed-

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
On Thu, Jan 10, 2019 at 08:26:13AM -0500, Konstantin Ryabitsev wrote: > On Thu, Jan 10, 2019 at 04:02:03PM +0800, Guo Ren wrote: > > Can I take back this pull request and send a new pull request with > > https:// URLs ? > > It's not necessary at this point, as the pull req

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
On Thu, Jan 10, 2019 at 03:59:22AM -0800, Linus Torvalds wrote: > On Thu, Jan 10, 2019 at 12:11 AM Guo Ren wrote: > > > > This pull-request is wrong on the patch: > > "csky: fixup module relocation error with 807 & 860". > > diff --git a/arch/csky/ke

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
On Thu, Jan 10, 2019 at 12:22:46PM +0100, Arnd Bergmann wrote: > On Thu, Jan 10, 2019 at 9:11 AM Guo Ren wrote: > > > > Sorry Linus, > > > > This pull-request is wrong on the patch: > > "csky: fixup module relocation error with 807 & 860". > &g

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
; Please drop it if possible and I'll send another [GIT PULL]. Best Regards Guo Ren On Wed, Jan 09, 2019 at 10:49:57PM +0800, guo...@kernel.org wrote: > The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: > > Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) >

Re: [GIT PULL] csky fixup for linux-5.0-rc1

2019-01-10 Thread Guo Ren
Can I take back this pull request and send a new pull request with https:// URLs ? On Wed, Jan 09, 2019 at 01:29:55PM -0500, Konstantin Ryabitsev wrote: > On Wed, Jan 09, 2019 at 06:05:01PM +, pr-tracker-...@kernel.org wrote: > > The pull request you sent on Wed, 9 Jan 2019 22:49:57 +0800: >

Re: Linux 5.0-rc1 (test results)

2019-01-08 Thread Guo Ren
Thx Michal, On Tue, Jan 08, 2019 at 04:40:31PM +0100, Michal Hocko wrote: > On Tue 08-01-19 17:51:07, Guo Ren wrote: > [...] > > static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > > { > > pte_t *pte; > > unsigned long i; > > >

Re: Linux 5.0-rc1 (test results)

2019-01-08 Thread Guo Ren
E/sizeof(pte_t); i++) (pte + i)->pte_low = _PAGE_GLOBAL; return pte; } static inline struct page *pte_alloc_one(struct mm_struct *mm) { struct page *pte; pte = alloc_pages(GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_ZERO, 0); if (!pte) return NULL; if (!pgtable_page_ctor(pte)) { __free_page(pte); return NULL; } return pte; } Best Regards Guo Ren

Re: [PATCH] csky: fix refcount leak in setup_smp()

2018-12-27 Thread Guo Ren
continue; > + } > + > + of_node_put(node); If success, of_node_put ? > > if (cpu >= NR_CPUS) Here need a of_node_put()? > continue; Can you use for_each_of_cpu_node() for the patch? Thx Guo Ren

Re: [PATCH v6 07/27] elf-em.h: add EM_CSKY

2018-12-21 Thread Guo Ren
On Fri, Dec 21, 2018 at 05:35:52AM +0300, Dmitry V. Levin wrote: > Hi, > > On Fri, Dec 14, 2018 at 12:43:08PM +0800, Guo Ren wrote: > > Reviewed-by: Guo Ren > > Given that the whole series is going to be pinged for quite some > time yet, would you mind taking this patc

Re: [PATCH v6 08/27] csky: define syscall_get_arch()

2018-12-21 Thread Guo Ren
On Fri, Dec 21, 2018 at 05:36:41AM +0300, Dmitry V. Levin wrote: > Hi, > > On Fri, Dec 14, 2018 at 12:44:12PM +0800, Guo Ren wrote: > > Thx Dmitry, > > > > Reviewed-by: Guo Ren > > Given that the whole series is going to be pinged for quite some > time y

Re: [PATCH v6 08/27] csky: define syscall_get_arch()

2018-12-13 Thread Guo Ren
Thx Dmitry, Reviewed-by: Guo Ren On Thu, Dec 13, 2018 at 08:22:07PM +0300, Dmitry V. Levin wrote: > syscall_get_arch() is required to be implemented on all architectures > in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO > request. > > Cc: Guo Ren > Cc

Re: [PATCH v6 07/27] elf-em.h: add EM_CSKY

2018-12-13 Thread Guo Ren
Reviewed-by: Guo Ren On Thu, Dec 13, 2018 at 08:22:00PM +0300, Dmitry V. Levin wrote: > The uapi/linux/audit.h header is going to use EM_CSKY in order > to define AUDIT_ARCH_CSKY which is needed to implement > syscall_get_arch() which in turn is required to extend > the generi

Re: working toolchain for c-sky

2018-12-11 Thread Guo Ren
//gitlab.com/c-sky/buildroot/-/jobs/131973812/artifacts/browse/output/images/ See readme.txt for run. Best Regards Guo Ren

[GIT PULL] C-SKY update for 4.20-rc6

2018-12-05 Thread Guo Ren
Hi Linus, Please pull. Best Regards Guo Ren --> The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the git repository at: g...@github.com:c-sky/csky-linux.

[GIT PULL] C-SKY update for 4.20-rc6

2018-12-05 Thread Guo Ren
Hi Linus, Please pull. Best Regards Guo Ren --> The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the git repository at: g...@github.com:c-sky/csky-linux.

[PATCH 1/2] csky: bugfix tlb_get_pgd error.

2018-11-21 Thread Guo Ren
It's wrong and should be 0xa000. Now correct it to: return ((get_pgd() - PHYS_OFFSET) & ~1) + PAGE_OFFSET; Signed-off-by: Guo Ren --- arch/csky/include/asm/mmu_context.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/csky/include/asm/mmu_context.h b/arch/cs

[PATCH 1/2] csky: bugfix tlb_get_pgd error.

2018-11-21 Thread Guo Ren
It's wrong and should be 0xa000. Now correct it to: return ((get_pgd() - PHYS_OFFSET) & ~1) + PAGE_OFFSET; Signed-off-by: Guo Ren --- arch/csky/include/asm/mmu_context.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/csky/include/asm/mmu_context.h b/arch/cs

[PATCH] MAINTAINERS: add maintainer for C-SKY drivers

2018-11-05 Thread Guo Ren
There are two intc drivers and two clocksource drivers, also include related dt-bindings' documentations. Signed-off-by: Guo Ren --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f485597..fb7286a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH] MAINTAINERS: add maintainer for C-SKY drivers

2018-11-05 Thread Guo Ren
There are two intc drivers and two clocksource drivers, also include related dt-bindings' documentations. Signed-off-by: Guo Ren --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f485597..fb7286a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH V13 resend 2/4] dt-bindings: timer: C-SKY Multi-processor timer

2018-11-02 Thread Guo Ren
Dt-bingdings doc for C-SKY SMP system setting. Signed-off-by: Guo Ren Reviewed-by: Rob Herring --- Changelog: - Drop the interrupt-parent. --- --- .../devicetree/bindings/timer/csky,mptimer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation

[PATCH V13 resend 3/4] clocksource: add gx6605s SOC system timer

2018-11-02 Thread Guo Ren
. Signed-off-by: Guo Ren Cc: Daniel Lezcano Cc: Thomas Gleixner --- Changelog: - pass checkpatch.pl - Add COMIPLE_TEST in Kconfig - no cast is needed for "struct clock_event_device *ce = dev" - remove: extra space after (u64) - Add License and Copyright - Use timer-of framework - C

[PATCH V13 resend 2/4] dt-bindings: timer: C-SKY Multi-processor timer

2018-11-02 Thread Guo Ren
Dt-bingdings doc for C-SKY SMP system setting. Signed-off-by: Guo Ren Reviewed-by: Rob Herring --- Changelog: - Drop the interrupt-parent. --- --- .../devicetree/bindings/timer/csky,mptimer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation

[PATCH V13 resend 3/4] clocksource: add gx6605s SOC system timer

2018-11-02 Thread Guo Ren
. Signed-off-by: Guo Ren Cc: Daniel Lezcano Cc: Thomas Gleixner --- Changelog: - pass checkpatch.pl - Add COMIPLE_TEST in Kconfig - no cast is needed for "struct clock_event_device *ce = dev" - remove: extra space after (u64) - Add License and Copyright - Use timer-of framework - C

[PATCH V13 resend 1/4] clocksource: add C-SKY SMP timer

2018-11-02 Thread Guo Ren
The driver is for C-SKY SMP timer. It only support oneshot event and 32bit overflow for clocksource. Per cpu core has one timer and all timers share one clock-counter-input the same clocksource. This use mfcr instructions to access the regs. Signed-off-by: Guo Ren Cc: Daniel Lezcano Cc: Thomas

[PATCH V13 resend 4/4] dt-bindings: timer: gx6605s SOC timer

2018-11-02 Thread Guo Ren
Dt-bindings doc for gx6605s SOC's system timer. Signed-off-by: Guo Ren Reviewed-by: Rob Herring --- .../bindings/timer/csky,gx6605s-timer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/csky,gx6605s

[PATCH V13 resend 1/4] clocksource: add C-SKY SMP timer

2018-11-02 Thread Guo Ren
The driver is for C-SKY SMP timer. It only support oneshot event and 32bit overflow for clocksource. Per cpu core has one timer and all timers share one clock-counter-input the same clocksource. This use mfcr instructions to access the regs. Signed-off-by: Guo Ren Cc: Daniel Lezcano Cc: Thomas

[PATCH V13 resend 4/4] dt-bindings: timer: gx6605s SOC timer

2018-11-02 Thread Guo Ren
Dt-bindings doc for gx6605s SOC's system timer. Signed-off-by: Guo Ren Reviewed-by: Rob Herring --- .../bindings/timer/csky,gx6605s-timer.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/csky,gx6605s

[GIT PULL] fixup dtb Kbuild for C-SKY(csky) Port

2018-10-31 Thread Guo Ren
for linux-4.20-rc1 These patches are complementary to "C-SKY(csky) Port for Linux 4.20" and fixup dtb Kbuild to follow the new Devicetree dtb build rules. Link: https://lore.kernel.org/lkml/cabggisxiwaqn9qdqpfxewcckkgjfmzfvspgvuhqk7ob404-...@mail.gmail.com/ Signed-off-b

[GIT PULL] fixup dtb Kbuild for C-SKY(csky) Port

2018-10-31 Thread Guo Ren
for linux-4.20-rc1 These patches are complementary to "C-SKY(csky) Port for Linux 4.20" and fixup dtb Kbuild to follow the new Devicetree dtb build rules. Link: https://lore.kernel.org/lkml/cabggisxiwaqn9qdqpfxewcckkgjfmzfvspgvuhqk7ob404-...@mail.gmail.com/ Signed-off-b

Re: [GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-29 Thread Guo Ren
On Mon, Oct 29, 2018 at 11:54:26AM -0500, Rob Herring wrote: > On Fri, Oct 26, 2018 at 11:09 PM Guo Ren wrote: > > > > The following changes since commit 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d: > > > > Linux 4.19 (2018-10-22 07:37:37 +0100) > > > &

Re: [GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-29 Thread Guo Ren
On Mon, Oct 29, 2018 at 11:54:26AM -0500, Rob Herring wrote: > On Fri, Oct 26, 2018 at 11:09 PM Guo Ren wrote: > > > > The following changes since commit 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d: > > > > Linux 4.19 (2018-10-22 07:37:37 +0100) > > > &

Re: [PATCH V13 1/4] clocksource: add C-SKY SMP timer

2018-10-29 Thread Guo Ren
Guo Ren On Mon, Oct 15, 2018 at 01:07:41PM +0800, Guo Ren wrote: > The driver is for C-SKY SMP timer. It only support oneshot event > and 32bit overflow for clocksource. Per cpu core has one timer and > all timers share one clock-counter-input the same clocksource. > > This use mf

Re: [PATCH V13 1/4] clocksource: add C-SKY SMP timer

2018-10-29 Thread Guo Ren
Guo Ren On Mon, Oct 15, 2018 at 01:07:41PM +0800, Guo Ren wrote: > The driver is for C-SKY SMP timer. It only support oneshot event > and 32bit overflow for clocksource. Per cpu core has one timer and > all timers share one clock-counter-input the same clocksource. > > This use mf

Re: [GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-29 Thread Guo Ren
t we will not give up our mother tongue. RISC-V is a great ISA, and it will promote other ISAs to be more open. From ecology, diversity will make Linux more robust. We will continue to improve csky subsystem, and now is only the beginning. Best Regards Guo Ren

Re: [GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-29 Thread Guo Ren
t we will not give up our mother tongue. RISC-V is a great ISA, and it will promote other ISAs to be more open. From ecology, diversity will make Linux more robust. We will continue to improve csky subsystem, and now is only the beginning. Best Regards Guo Ren

[GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-26 Thread Guo Ren
g select. 590c7e6 csky: bugfix compile error with CONFIG_AUDIT 1989292 csky: revert some back with cleanup unistd.h f1454fe csky: cleanup unistd.h 5d2985f csky: cleanup Kconfig and Makefile. 423d97e csky: cancel subdirectories cae2af4 csky: use asm-generic/fcntl.h ----------

[GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-26 Thread Guo Ren
g select. 590c7e6 csky: bugfix compile error with CONFIG_AUDIT 1989292 csky: revert some back with cleanup unistd.h f1454fe csky: cleanup unistd.h 5d2985f csky: cleanup Kconfig and Makefile. 423d97e csky: cancel subdirectories cae2af4 csky: use asm-generic/fcntl.h ----------

Re: [PATCH V9 21/21] csky: support dword access for get_user_size()

2018-10-25 Thread Guo Ren
On Wed, Oct 24, 2018 at 08:17:47AM +0100, Arnd Bergmann wrote: > On Thu, Oct 18, 2018 at 9:57 AM Guo Ren wrote: > > > > On Thu, Oct 18, 2018 at 10:34:00AM +0200, Arnd Bergmann wrote: > > > On Thu, Oct 18, 2018 at 5:41 AM Guo Ren wrote: > > > > > > &g

Re: [PATCH V9 21/21] csky: support dword access for get_user_size()

2018-10-25 Thread Guo Ren
On Wed, Oct 24, 2018 at 08:17:47AM +0100, Arnd Bergmann wrote: > On Thu, Oct 18, 2018 at 9:57 AM Guo Ren wrote: > > > > On Thu, Oct 18, 2018 at 10:34:00AM +0200, Arnd Bergmann wrote: > > > On Thu, Oct 18, 2018 at 5:41 AM Guo Ren wrote: > > > > > > &g

Re: [PATCH V9 01/21] csky: Build infrastructure

2018-10-25 Thread Guo Ren
On Wed, Oct 24, 2018 at 11:53:05PM +0100, Arnd Bergmann wrote: > On Tue, Oct 23, 2018 at 1:08 AM Guo Ren wrote: > > > > Hi Arnd, > > > > Could you help me review the patch, seems the patch is skipped. > > ref: https://lkml.org/lkml/2018/10/16/224 > > Ah rig

Re: [PATCH V9 01/21] csky: Build infrastructure

2018-10-25 Thread Guo Ren
On Wed, Oct 24, 2018 at 11:53:05PM +0100, Arnd Bergmann wrote: > On Tue, Oct 23, 2018 at 1:08 AM Guo Ren wrote: > > > > Hi Arnd, > > > > Could you help me review the patch, seems the patch is skipped. > > ref: https://lkml.org/lkml/2018/10/16/224 > > Ah rig

Re: [PATCH V9 01/21] csky: Build infrastructure

2018-10-22 Thread Guo Ren
Hi Arnd, Could you help me review the patch, seems the patch is skipped. ref: https://lkml.org/lkml/2018/10/16/224 Thx On Tue, Oct 16, 2018 at 10:58:20AM +0800, Guo Ren wrote: > This patch adds Makefile, Kconfig for build infrastructure. > > Signed-off-by: Guo Ren > Cc: A

Re: [PATCH V9 01/21] csky: Build infrastructure

2018-10-22 Thread Guo Ren
Hi Arnd, Could you help me review the patch, seems the patch is skipped. ref: https://lkml.org/lkml/2018/10/16/224 Thx On Tue, Oct 16, 2018 at 10:58:20AM +0800, Guo Ren wrote: > This patch adds Makefile, Kconfig for build infrastructure. > > Signed-off-by: Guo Ren > Cc: A

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-21 Thread Guo Ren
Thx Peter, Your review has been a great help. On Sun, Oct 21, 2018 at 10:55:08PM +0200, Peter Zijlstra wrote: > On Tue, Oct 16, 2018 at 10:58:30AM +0800, Guo Ren wrote: > > + smp_mb(); > > + lock->tickets.owner++; > > WRITE_ONCE(lock->tickets.owner, lo

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-21 Thread Guo Ren
Thx Peter, Your review has been a great help. On Sun, Oct 21, 2018 at 10:55:08PM +0200, Peter Zijlstra wrote: > On Tue, Oct 16, 2018 at 10:58:30AM +0800, Guo Ren wrote: > > + smp_mb(); > > + lock->tickets.owner++; > > WRITE_ONCE(lock->tickets.owner, lo

Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings

2018-10-18 Thread Guo Ren
On Thu, Oct 18, 2018 at 09:31:35AM -0500, Rob Herring wrote: > On Tue, 16 Oct 2018 10:58:37 +0800, Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring

Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings

2018-10-18 Thread Guo Ren
On Thu, Oct 18, 2018 at 09:31:35AM -0500, Rob Herring wrote: > On Tue, 16 Oct 2018 10:58:37 +0800, Guo Ren wrote: > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob Herring

Re: [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port

2018-10-18 Thread Guo Ren
On Thu, Oct 18, 2018 at 10:36:45AM +0200, Arnd Bergmann wrote: > On Thu, Oct 18, 2018 at 6:11 AM Guo Ren wrote: > > > > On Wed, Oct 17, 2018 at 05:58:46PM +0200, Arnd Bergmann wrote: > > > On Tue, Oct 16, 2018 at 4:58 AM Guo Ren wrote: > > > > > > &

Re: [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port

2018-10-18 Thread Guo Ren
On Thu, Oct 18, 2018 at 10:36:45AM +0200, Arnd Bergmann wrote: > On Thu, Oct 18, 2018 at 6:11 AM Guo Ren wrote: > > > > On Wed, Oct 17, 2018 at 05:58:46PM +0200, Arnd Bergmann wrote: > > > On Tue, Oct 16, 2018 at 4:58 AM Guo Ren wrote: > > > > > > &

Re: [PATCH V9 21/21] csky: support dword access for get_user_size()

2018-10-18 Thread Guo Ren
On Thu, Oct 18, 2018 at 10:34:00AM +0200, Arnd Bergmann wrote: > On Thu, Oct 18, 2018 at 5:41 AM Guo Ren wrote: > > > > On Wed, Oct 17, 2018 at 05:44:17PM +0200, Arnd Bergmann wrote: > > > On Tue, Oct 16, 2018 at 5:33 AM Guo Ren wrote: > > > > > >

Re: [PATCH V9 21/21] csky: support dword access for get_user_size()

2018-10-18 Thread Guo Ren
On Thu, Oct 18, 2018 at 10:34:00AM +0200, Arnd Bergmann wrote: > On Thu, Oct 18, 2018 at 5:41 AM Guo Ren wrote: > > > > On Wed, Oct 17, 2018 at 05:44:17PM +0200, Arnd Bergmann wrote: > > > On Tue, Oct 16, 2018 at 5:33 AM Guo Ren wrote: > > > > > >

Re: [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:58:46PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 4:58 AM Guo Ren wrote: > > > > This is the 9th version patchset to add the Linux kernel port for > > C-SKY(csky) based on linux-4.19-rc3. > > > > There are only a few

Re: [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:58:46PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 4:58 AM Guo Ren wrote: > > > > This is the 9th version patchset to add the Linux kernel port for > > C-SKY(csky) based on linux-4.19-rc3. > > > > There are only a few

Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings

2018-10-17 Thread Guo Ren
On Thu, Oct 18, 2018 at 11:21:30AM +0800, Guo Ren wrote: > On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > > > This patch adds the documentation to describe that how to add cpu nodes in > >

Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings

2018-10-17 Thread Guo Ren
On Thu, Oct 18, 2018 at 11:21:30AM +0800, Guo Ren wrote: > On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > > > This patch adds the documentation to describe that how to add cpu nodes in > >

Re: [PATCH V9 21/21] csky: support dword access for get_user_size()

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:44:17PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:33 AM Guo Ren wrote: > > > > Support dword access for get_user_size and redesign put_user_size with > > the same style of get_user_size. It's Ok to use xxx_user_asm_common for >

Re: [PATCH V9 21/21] csky: support dword access for get_user_size()

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:44:17PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:33 AM Guo Ren wrote: > > > > Support dword access for get_user_size and redesign put_user_size with > > the same style of get_user_size. It's Ok to use xxx_user_asm_common for >

Re: [PATCH V9 18/21] dt-bindings: csky CPU Bindings

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:50:33PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:30 AM Guo Ren wrote: > > > > This patch adds the documentation to describe that how to add cpu nodes in > > dts for SMP. > > > > Signed-off-by: Guo Ren > > Cc: Rob H

<    1   2   3   4   5   6   7   8   9   10   >