Re: [PATCHv2 net] selftests: netfilter: Pass the family parameter to conntrack tool

On Tue, Jan 05, 2021 at 05:43:16PM +0800, Yi Chen wrote: > From: yiche > > Fixes: 619ae8e0697a6 ("selftests: netfilter: add test case for conntrack > helper assignment") > > Fix nft_conntrack_helper.sh fake fail: > conntrack tool need "-f ipv6" parameter to show out ipv6 traffic items. > sleep

Re: [PATCH v2 0/3] Extract run_kselftest.sh and generate stand-alone test list

On Mon, Sep 28, 2020 at 01:26:47PM -0700, Kees Cook wrote: > v2: > - update documentation > - include SPDX line in extracted script > v1: > https://lore.kernel.org/linux-kselftest/20200925234527.1885234-1-keesc...@chromium.org/ > I'm not sure if the doc update are all appropriate. Need others

Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

On Mon, Sep 28, 2020 at 01:06:15PM -0700, Kees Cook wrote: > > I'm really sorry to make this trouble. And I'm OK to revert the patch. > > I just a little wondering how do you generate this script. > > This issue is with which shell is used. I suspect your /bin/sh is full > /bin/bash, where as

Re: [PATCH 2/2] selftests/run_kselftest.sh: Make each test individually selectable

On Fri, Sep 25, 2020 at 04:45:27PM -0700, Kees Cook wrote: > Currently with run_kselftest.sh there is no way to choose which test > we could run. All the tests listed in kselftest-list.txt are all run > every time. This patch enhanced the run_kselftest.sh to make the test > collections (or tests)

Re: [PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

On Fri, Sep 25, 2020 at 02:16:14PM -0700, Kees Cook wrote: > On Fri, Sep 25, 2020 at 01:51:53PM +0530, Naresh Kamboju wrote: > > On Mon, 14 Sep 2020 at 07:53, Hangbin Liu wrote: > > > > > > Currently, after generating run_kselftest.sh, there is no way to choose > &g

[PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

"zram.sh" cd $ROOT } usage() { cat < $logfile; shift ;; -t | --tests ) TESTS=$2; shift 2 ;; -l | --list ) echo $TESTS; exit 0 ;; -h | --help ) usage; exit 0 ;; "" ) break;; * ) usage; exit 1;; esac done cd $B

[PATCHv4 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

"zram.sh" cd $ROOT } usage() { cat < $logfile; shift ;; -t | --tests ) TESTS=$2; shift 2 ;; -h | --help ) usage; exit 0;; "" ) break;; * ) usage; exit 1;; esac done cd $BASE_DIR ROOT=$PWD for folder in $TESTS; do

[PATCHv3] selftests/run_kselftest.sh: make each test individually selectable

"zram.sh" cd $ROOT } usage() { cat < $logfile; shift ;; -t | --tests ) TESTS=$2; shift 2 ;; -h | --help ) usage; exit 0;; "" ) break;; * ) usage; exit 1;; esac done cd $BASE_DIR ROOT=$PWD for folder in $TESTS; do f

Re: [PATCH] mld: fix memory leak in ipv6_mc_destroy_dev()

et/ipv6/mcast.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c > index 7e12d2114158..8cd2782a31e4 100644 > --- a/net/ipv6/mcast.c > +++ b/net/ipv6/mcast.c > @@ -2615,6 +2615,7 @@ void ipv6_mc_destroy_dev(struct inet6_dev *idev) > idev->mc_list = i->next; > > write_unlock_bh(>lock); > + ip6_mc_clear_src(i); > ma_put(i); > write_lock_bh(>lock); > } > -- > 2.17.1 > Acked-by: Hangbin Liu

[PATCH 5.4] selftests/bpf: fix goto cleanup label not defined

ftest to skeletons"). But this commit is too large and need more backports. To fix it, the easiest way is just use the current goto label 'close_prog'. Reported-by: kernel test robot Fixes: da43712a7262 ("selftests/bpf: Skip perf hw events test if the setup disabled it") Signed

Re: hard-coded limit on unresolved multicast route cache in ipv4/ipmr.c causes slow, unreliable creation of multicast routes on busy networks

On Tue, Dec 18, 2018 at 09:55:45PM -0800, David Miller wrote: > From: Sukumar Gopalakrishnan > Date: Wed, 19 Dec 2018 10:57:02 +0530 > > > Hi David, > > > > There are two patch for this issue: > >1) Your changes which removes cache_resolve_queue_len > > 2) Hangbin's changes which make

Re: [PATCH 4.9 41/51] fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied

On Sun, May 19, 2019 at 10:27:53PM +0200, Florian Westphal wrote: > Nathan Chancellor wrote: > > On Wed, May 15, 2019 at 12:56:16PM +0200, Greg Kroah-Hartman wrote: > > > From: Hangbin Liu > > > > > > [ Upstream commit e9919a24d3022f72bcadc407e73a6ef

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

On Wed, Feb 20, 2019 at 03:09:21PM +0200, Nikolay Aleksandrov wrote: > On 20/02/2019 14:48, Sebastian Gottschall wrote: > > *reminder* > > > [snip] > >    } > >    static void br_ip4_multicast_query(struct net_bridge *br, > >>> Is this also a problem in 4.20?  This patch went into

Re: linux-next: build failure in Linus' tree

On Sun, Oct 28, 2018 at 03:45:16PM -0700, Linus Torvalds wrote: > On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell > wrote: > > > > After merging the origin tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > linux-next is back! Wheee.. > > > 5a2de63fd1a5

Re: linux-next: build failure in Linus' tree

On Sun, Oct 28, 2018 at 03:45:16PM -0700, Linus Torvalds wrote: > On Sun, Oct 28, 2018 at 3:35 PM Stephen Rothwell > wrote: > > > > After merging the origin tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > linux-next is back! Wheee.. > > > 5a2de63fd1a5

Re: linux-next: Signed-off-by missing for commit in the net tree

On Fri, May 11, 2018 at 07:17:16AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed") > > is missing a Signed-off-by from its author. Opps, My bad. > After route cache is flushed via ipv4_sysctl_rtcache_flush(), we

Re: linux-next: Signed-off-by missing for commit in the net tree

On Fri, May 11, 2018 at 07:17:16AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 0e8411e426e2 ("ipv4: reset fnhe_mtu_locked after cache route flushed") > > is missing a Signed-off-by from its author. Opps, My bad. > After route cache is flushed via ipv4_sysctl_rtcache_flush(), we

Re: possible deadlock in smc_close_non_accepted

#syz fix: net/smc: simplify wait when closing listen socket

Re: possible deadlock in smc_close_non_accepted

#syz fix: net/smc: simplify wait when closing listen socket

Re: WARNING: kobject bug in br_add_if

On Thu, Apr 26, 2018 at 10:04:16AM +0200, Dmitry Vyukov wrote: > On Thu, Apr 26, 2018 at 8:13 AM, Hangbin Liu <liuhang...@gmail.com> wrote: > > On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote: > >> On Wed, Apr 11, 2018 at 5:15 PM, syzbot > &

Re: WARNING: kobject bug in br_add_if

On Thu, Apr 26, 2018 at 10:04:16AM +0200, Dmitry Vyukov wrote: > On Thu, Apr 26, 2018 at 8:13 AM, Hangbin Liu wrote: > > On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote: > >> On Wed, Apr 11, 2018 at 5:15 PM, syzbot > >> wrote: > >> > Hello,

Re: WARNING: kobject bug in br_add_if

On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote: > On Wed, Apr 11, 2018 at 5:15 PM, syzbot > wrote: > > Hello, > > > > syzbot hit the following crash on upstream commit > > 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31

Re: WARNING: kobject bug in br_add_if

On Wed, Apr 11, 2018 at 05:18:23PM +0200, Dmitry Vyukov wrote: > On Wed, Apr 11, 2018 at 5:15 PM, syzbot > wrote: > > Hello, > > > > syzbot hit the following crash on upstream commit > > 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) > > Merge branch

Re: [PATCH 3.2 086/126] igmp: do not remove igmp souce list info when set link down

2017-02-16 6:41 GMT+08:00 Ben Hutchings <b...@decadent.org.uk>: > 3.2.85-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Hangbin Liu <liuhang...@gmail.com> > > commit 24803f38a5c0b6c57ed800b47e695f9ce474bc3a ups

Re: [PATCH 3.2 086/126] igmp: do not remove igmp souce list info when set link down

2017-02-16 6:41 GMT+08:00 Ben Hutchings : > 3.2.85-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Hangbin Liu > > commit 24803f38a5c0b6c57ed800b47e695f9ce474bc3a upstream. > > In commit 24cf3af3fed5 ("igm