Len field is already set to zero, but not the from field which is sent as
0xfe00. This makes no sense, and may cause confuse server
implementations doing sanity checks (qemu-nbd is an example.)
Signed-off-by: Hani Benhabiles
---
Compared to v1:
* Zero the request structure instead
On Sun, May 25, 2014 at 02:11:13PM -0400, Paul Clements wrote:
> On Sun, May 25, 2014 at 6:18 AM, Hani Benhabiles wrote:
> > On Sun, May 18, 2014 at 10:11:13AM +0100, Hani Benhabiles wrote:
> >> On Fri, May 16, 2014 at 10:56:33PM -0400, Paul Clements wrote:
> >&g
On Sun, May 18, 2014 at 10:11:13AM +0100, Hani Benhabiles wrote:
> On Fri, May 16, 2014 at 10:56:33PM -0400, Paul Clements wrote:
> > Agreed. But better yet, the request structure should just be zeroed when
> > it's allocated.
> >
>
> It is already
On Sun, May 18, 2014 at 10:11:13AM +0100, Hani Benhabiles wrote:
On Fri, May 16, 2014 at 10:56:33PM -0400, Paul Clements wrote:
Agreed. But better yet, the request structure should just be zeroed when
it's allocated.
It is already initialized in __nbd_ioctl() with the blk_rq_init
On Sun, May 25, 2014 at 02:11:13PM -0400, Paul Clements wrote:
On Sun, May 25, 2014 at 6:18 AM, Hani Benhabiles kroo...@gmail.com wrote:
On Sun, May 18, 2014 at 10:11:13AM +0100, Hani Benhabiles wrote:
On Fri, May 16, 2014 at 10:56:33PM -0400, Paul Clements wrote:
Agreed. But better yet
Len field is already set to zero, but not the from field which is sent as
0xfe00. This makes no sense, and may cause confuse server
implementations doing sanity checks (qemu-nbd is an example.)
Signed-off-by: Hani Benhabiles h...@linux.com
---
Compared to v1:
* Zero the request
ffe00 after the left
shifts.)
This is the only (non-ugly / non-intrusive) way to do it afaict.
> --
> Paul
>
>
> On Fri, May 16, 2014 at 7:43 PM, Hani Benhabiles wrote:
>
> > Len field is already set to zero, but not the from field which is sent as
> >
after the left
shifts.)
This is the only (non-ugly / non-intrusive) way to do it afaict.
--
Paul
On Fri, May 16, 2014 at 7:43 PM, Hani Benhabiles kroo...@gmail.com wrote:
Len field is already set to zero, but not the from field which is sent as
0xfe00. This makes no sense
Len field is already set to zero, but not the from field which is sent as
0xfe00. This makes no sense, and may cause confuse server
implementations doing sanity checks (qemu-nbd is an example.)
Signed-off-by: Hani Benhabiles
---
drivers/block/nbd.c | 2 +-
1 file changed, 1
Len field is already set to zero, but not the from field which is sent as
0xfe00. This makes no sense, and may cause confuse server
implementations doing sanity checks (qemu-nbd is an example.)
Signed-off-by: Hani Benhabiles h...@linux.com
---
drivers/block/nbd.c | 2 +-
1 file
10 matches
Mail list logo
