Re: [PATCH 37/45] drivers: use req op accessor

2016-06-06 Thread Hannes Reinecke
d_blkdevs.c | 2 +- > drivers/nvme/host/core.c | 2 +- > drivers/nvme/host/nvme.h | 4 ++-- > drivers/scsi/sd.c | 25 ----- > 14 files changed, 43 insertions(+), 34 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com&g

Re: [PATCH 37/45] drivers: use req op accessor

2016-06-06 Thread Hannes Reinecke
c | 2 +- > drivers/nvme/host/nvme.h | 4 ++-- > drivers/scsi/sd.c | 25 - > 14 files changed, 43 insertions(+), 34 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Sto

Re: [PATCH 28/45] target: use bio op accessors

2016-06-06 Thread Hannes Reinecke
_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, > u32 sgl_nents, > goto fail; > > if (rw) > - bio->bi_rw |= REQ_WRITE; > + bio_set_

Re: [PATCH 28/45] target: use bio op accessors

2016-06-06 Thread Hannes Reinecke
ct se_cmd *cmd, struct scatterlist *sgl, > u32 sgl_nents, > goto fail; > > if (rw) > - bio->bi_rw |= REQ_WRITE; > + bio_set_op_attrs(bio, REQ_OP_WRITE, 0); >

Re: [PATCH 25/45] bcache: use bio op accessors

2016-06-06 Thread Hannes Reinecke
++--- > drivers/md/bcache/writeback.c | 4 ++-- > 7 files changed, 31 insertions(+), 28 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 25/45] bcache: use bio op accessors

2016-06-06 Thread Hannes Reinecke
- > 7 files changed, 31 insertions(+), 28 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF:

Re: [PATCH 24/45] dm: use bio op accessors

2016-06-06 Thread Hannes Reinecke
On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie <mchri...@redhat.com> > > Separate the op from the rq_flag_bits and have dm > set/get the bio using bio_set_op_attrs/bio_op. > > Signed-off-by: Mike Christie <mchri...@redhat.com> >

Re: [PATCH 24/45] dm: use bio op accessors

2016-06-06 Thread Hannes Reinecke
On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie > > Separate the op from the rq_flag_bits and have dm > set/get the bio using bio_set_op_attrs/bio_op. > > Signed-off-by: Mike Christie > Reviewed-by: Hannes Reinecke Cheers, Hannes --

Re: [PATCH 09/45] block discard: use bio set op accessor

2016-06-06 Thread Hannes Reinecke
ff-by: Mike Christie <mchri...@redhat.com> > --- > block/blk-lib.c| 13 +++-- > drivers/md/dm-thin.c | 2 +- > include/linux/blkdev.h | 3 ++- > 3 files changed, 10 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers

Re: [PATCH 09/45] block discard: use bio set op accessor

2016-06-06 Thread Hannes Reinecke
; --- > block/blk-lib.c| 13 +++-- > drivers/md/dm-thin.c | 2 +- > include/linux/blkdev.h | 3 ++- > 3 files changed, 10 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTea

Re: [PATCH 08/45] block, fs, mm, drivers: use bio set/get op accessors

2016-06-06 Thread Hannes Reinecke
@@ int __swap_writepage(struct page *page, struct > writeback_control *wbc, > ret = -ENOMEM; > goto out; > } > - bio->bi_rw = WRITE; > + bio_set_op_attrs(bio, REQ_OP_WRITE, 0); > if (wbc->sync_mode == WB_SYNC_ALL) >

Re: [PATCH 08/45] block, fs, mm, drivers: use bio set/get op accessors

2016-06-06 Thread Hannes Reinecke
> writeback_control *wbc, > ret = -ENOMEM; > goto out; > } > - bio->bi_rw = WRITE; > + bio_set_op_attrs(bio, REQ_OP_WRITE, 0); > if (wbc->sync_mode == WB_SYNC_ALL) > bio->bi_rw |= REQ_SYNC; >

Re: [PATCH 07/45] bcache: use op_is_write instead of checking for REQ_WRITE

2016-06-06 Thread Hannes Reinecke
- > drivers/md/bcache/request.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > (Could probably folded together with the two previous patches) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage &

Re: [PATCH 07/45] bcache: use op_is_write instead of checking for REQ_WRITE

2016-06-06 Thread Hannes Reinecke
; 2 files changed, 4 insertions(+), 4 deletions(-) > (Could probably folded together with the two previous patches) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 6

Re: [PATCH 05/45] block, drivers, cgroup: use op_is_write helper instead of checking for REQ_WRITE

2016-06-06 Thread Hannes Reinecke
re more involved. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 S

Re: [PATCH 02/45] block: add REQ_OP definitions and helpers

2016-06-06 Thread Hannes Reinecke
d helpers in this patch will be dropped > or updated. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 05/45] block, drivers, cgroup: use op_is_write helper instead of checking for REQ_WRITE

2016-06-06 Thread Hannes Reinecke
gned-off-by: Mike Christie > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smitha

Re: [PATCH 02/45] block: add REQ_OP definitions and helpers

2016-06-06 Thread Hannes Reinecke
ped > or updated. > > Signed-off-by: Mike Christie > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürn

Re: [PATCH 06/45] dm: use op_is_write instead of checking for REQ_WRITE

2016-06-06 Thread Hannes Reinecke
t be able to > detect a operation direction like writesame by testing if REQ_WRITE is > set. > > This has dm use the op_is_write helper which will do the right > thing. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- (Could probably be folded into t

Re: [PATCH 06/45] dm: use op_is_write instead of checking for REQ_WRITE

2016-06-06 Thread Hannes Reinecke
ion direction like writesame by testing if REQ_WRITE is > set. > > This has dm use the op_is_write helper which will do the right > thing. > > Signed-off-by: Mike Christie > --- (Could probably be folded into the previous patch) Reviewed-by: Hannes Reinecke

Re: [PATCH 01/45] block/fs/drivers: remove rw argument from submit_bio

2016-06-06 Thread Hannes Reinecke
bio fields. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUS

Re: [PATCH 01/45] block/fs/drivers: remove rw argument from submit_bio

2016-06-06 Thread Hannes Reinecke
ed-off-by: Mike Christie > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard,

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Hannes Reinecke
On 06/01/2016 03:43 PM, Christoph Hellwig wrote: > These patches look good on their own. They might be an easier sell > just as bio cleanups :) Fully agree. I've seen (some) improvements with those patches, so I'd prefer to have them. You can add: Tested-by: Hannes Reinecke <h...

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

2016-06-01 Thread Hannes Reinecke
On 06/01/2016 03:43 PM, Christoph Hellwig wrote: > These patches look good on their own. They might be an easier sell > just as bio cleanups :) Fully agree. I've seen (some) improvements with those patches, so I'd prefer to have them. You can add: Tested-by: Hannes Reinecke Cheers,

Re: [PATCH v2 2/3] /dev/dax, core: file operations and dax-mmap

2016-05-18 Thread Hannes Reinecke
On 05/18/2016 11:10 AM, Paul Mackerras wrote: > On Wed, May 18, 2016 at 10:07:19AM +0200, Hannes Reinecke wrote: >> On 05/18/2016 12:19 AM, Dan Williams wrote: >>> On Tue, May 17, 2016 at 3:57 AM, Johannes Thumshirn <jthumsh...@suse.de> >>> wrote: >>>

Re: [PATCH v2 2/3] /dev/dax, core: file operations and dax-mmap

2016-05-18 Thread Hannes Reinecke
On 05/18/2016 11:10 AM, Paul Mackerras wrote: > On Wed, May 18, 2016 at 10:07:19AM +0200, Hannes Reinecke wrote: >> On 05/18/2016 12:19 AM, Dan Williams wrote: >>> On Tue, May 17, 2016 at 3:57 AM, Johannes Thumshirn >>> wrote: >>>> On Sat, May 14, 2016

Re: [PATCH v2 2/3] /dev/dax, core: file operations and dax-mmap

2016-05-18 Thread Hannes Reinecke
l dax_dev > object. > Hmm. This is the same 'creative' RCU usage Mike Snitzer has been trying when trying to improve device-mapper performance. >From my understanding RCU is protecting the _pointer_, not the values of the structure pointed to. IOW we are guaranteed to have a valid pointer at an

Re: [PATCH v2 2/3] /dev/dax, core: file operations and dax-mmap

2016-05-18 Thread Hannes Reinecke
he new state of ->alive > when they start. Reference counts are protecting the actual dax_dev > object. > Hmm. This is the same 'creative' RCU usage Mike Snitzer has been trying when trying to improve device-mapper performance. >From my understanding RCU is protecting the _point

Re: [PATCH] NVMe: Only release requested regions

2016-05-10 Thread Hannes Reinecke
ff-by: Johannes Thumshirn <jthumsh...@suse.de> > --- > drivers/nvme/host/pci.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTea

Re: [PATCH] NVMe: Only release requested regions

2016-05-10 Thread Hannes Reinecke
ff-by: Johannes Thumshirn > --- > drivers/nvme/host/pci.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: Regression in v4.6-rc due to SCSI multipath change

2016-05-04 Thread Hannes Reinecke
o parse all possible VPD descriptors, for sure, so that is indeed a bug. I'm preparing a patch for decoding all possible VPD descriptors, too. Let's see who's first :-) Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: Regression in v4.6-rc due to SCSI multipath change

2016-05-04 Thread Hannes Reinecke
o parse all possible VPD descriptors, for sure, so that is indeed a bug. I'm preparing a patch for decoding all possible VPD descriptors, too. Let's see who's first :-) Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH] block: initialize hd_stuct's reference before assigning it

2016-05-03 Thread Hannes Reinecke
kobject_uevent(>kobj, KOBJ_ADD); > > - if (!hd_ref_init(p)) > - return p; > + return p; > > out_free_info: > free_part_info(p); > Suggested-by: Hannes Reinecke <h...@suse.com> Reviewed-by:

Re: [PATCH] block: initialize hd_stuct's reference before assigning it

2016-05-03 Thread Hannes Reinecke
nt(>kobj, KOBJ_ADD); > > - if (!hd_ref_init(p)) > - return p; > + return p; > > out_free_info: > free_part_info(p); > Suggested-by: Hannes Reinecke Reviewed-by: Hannes Reinecke :-) Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 1/1] [RFC] workqueue: fix ghost PENDING flag while doing MQ IO

2016-04-26 Thread Hannes Reinecke
o with Roman's mb patch for -stable fix but think > it'd be nice to have a separate patch to consolidate the paths which > clear PENDING and make them use xchg. If you can spin up a patch for > that, I'd be happy to apply it to wq/for-3.7. >

Re: [PATCH 1/1] [RFC] workqueue: fix ghost PENDING flag while doing MQ IO

2016-04-26 Thread Hannes Reinecke
o with Roman's mb patch for -stable fix but think > it'd be nice to have a separate patch to consolidate the paths which > clear PENDING and make them use xchg. If you can spin up a patch for > that, I'd be happy to apply it to wq/for-3.7. >

Re: [PATCH 1/3] hisi_sas: add device and slot alloc hw methods

2016-04-15 Thread Hannes Reinecke
com> > --- > drivers/scsi/hisi_sas/hisi_sas.h | 3 +++ > drivers/scsi/hisi_sas/hisi_sas_main.c | 11 +-- > 2 files changed, 12 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 1/3] hisi_sas: add device and slot alloc hw methods

2016-04-15 Thread Hannes Reinecke
scsi/hisi_sas/hisi_sas.h | 3 +++ > drivers/scsi/hisi_sas/hisi_sas_main.c | 11 +-- > 2 files changed, 12 insertions(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 2/3] hisi_sas: add slot_index_alloc_quirk_v2_hw()

2016-04-15 Thread Hannes Reinecke
++ > 1 file changed, 28 insertions(+) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr.

Re: [PATCH 3/3] hisi_sas: add alloc_dev_quirk_v2_hw()

2016-04-15 Thread Hannes Reinecke
hisi_sas/hisi_sas_v2_hw.c | 30 ++ > 1 file changed, 30 insertions(+) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUS

Re: [PATCH 2/3] hisi_sas: add slot_index_alloc_quirk_v2_hw()

2016-04-15 Thread Hannes Reinecke
hanged, 28 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J.

Re: [PATCH 3/3] hisi_sas: add alloc_dev_quirk_v2_hw()

2016-04-15 Thread Hannes Reinecke
+++ > 1 file changed, 30 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

2016-04-15 Thread Hannes Reinecke
> retry: > + err = 0; > retval = submit_rtpg(sdev, buff, bufflen, _hdr, pg->flags); > > if (retval) { > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

2016-04-15 Thread Hannes Reinecke
= 0; > retval = submit_rtpg(sdev, buff, bufflen, _hdr, pg->flags); > > if (retval) { > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688

Re: [PATCH 2/2] target: use new "dbroot" target attribute

2016-04-14 Thread Hannes Reinecke
--- > drivers/target/target_core_alua.c | 6 +++--- > drivers/target/target_core_pr.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networkin

Re: [PATCH 2/2] target: use new "dbroot" target attribute

2016-04-14 Thread Hannes Reinecke
/target_core_alua.c | 6 +++--- > drivers/target/target_core_pr.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCHv2 1/2] target: make target db location configurable

2016-04-14 Thread Hannes Reinecke
ssize_t read_bytes; > + struct file *fp; > + > + if (!list_empty(_tf_list)) { > + pr_err("db_root: cannot be changed: target drivers registered"); > + return -EINVAL; > + } Locking? Cheers, Hannes -- Dr. Hannes ReineckeTeaml

Re: [PATCHv2 1/2] target: make target db location configurable

2016-04-14 Thread Hannes Reinecke
struct file *fp; > + > + if (!list_empty(_tf_list)) { > + pr_err("db_root: cannot be changed: target drivers registered"); > + return -EINVAL; > + } Locking? Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking

Re: [PATCH 00/42] v5: separate operations from flags in the bio/request structs

2016-04-14 Thread Hannes Reinecke
is patchset was made against linux-next from today April 13 > (git tag next-20160413). > > I put a git tree here: > https://github.com/mikechristie/linux-kernel.git > The patches are in the op branch. > A round of applause for you. For the entire series: Reviewed-by: Hannes

Re: [PATCH 00/42] v5: separate operations from flags in the bio/request structs

2016-04-14 Thread Hannes Reinecke
is patchset was made against linux-next from today April 13 > (git tag next-20160413). > > I put a git tree here: > https://github.com/mikechristie/linux-kernel.git > The patches are in the op branch. > A round of applause for you. For the entire series: Reviewed-by:

Re: [PATCH v3 2/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal"

2016-03-31 Thread Hannes Reinecke
) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Re: [PATCH v3 2/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal"

2016-03-31 Thread Hannes Reinecke
On 03/31/2016 02:53 PM, Johannes Thumshirn wrote: > This reverts commit 90a88d6ef88edcfc4f644dddc7eef4ea41bccf8b. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/scsi_sysfs.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > Reviewed-by: Han

Re: [PATCH v3 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

2016-03-31 Thread Hannes Reinecke
i/scsi_device.h > +++ b/include/scsi/scsi_device.h > @@ -240,6 +240,7 @@ scmd_printk(const char *, const struct scsi_cmnd *, const > char *, ...); > enum scsi_target_state { > STARGET_CREATED = 1, > STARGET_RUNNING, > + STARGET_REMOVE, > STARGET_DEL, > }; &

Re: [PATCH v3 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

2016-03-31 Thread Hannes Reinecke
ude/scsi/scsi_device.h > @@ -240,6 +240,7 @@ scmd_printk(const char *, const struct scsi_cmnd *, const > char *, ...); > enum scsi_target_state { > STARGET_CREATED = 1, > STARGET_RUNNING, > + STARGET_REMOVE, > STARGET_DEL, > }; > > Reviewed-by:

Re: [PATCH v3 23/23] ncr5380: Call complete_cmd() for disconnected commands on bus reset

2016-03-23 Thread Hannes Reinecke
> + complete_cmd(instance, cmd); > } > INIT_LIST_HEAD(>disconnected); > > > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH v3 23/23] ncr5380: Call complete_cmd() for disconnected commands on bus reset

2016-03-23 Thread Hannes Reinecke
complete_cmd(instance, cmd); > } > INIT_LIST_HEAD(>disconnected); > > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeld

Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-23 Thread Hannes Reinecke
one system. > Michael tells me that 2 is also the best setting for his Atari Falcon. > > --- > drivers/scsi/atari_scsi.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes --

Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-23 Thread Hannes Reinecke
or his Atari Falcon. > > --- > drivers/scsi/atari_scsi.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH v3 14/23] ncr5380: Reduce max_lun limit

2016-03-23 Thread Hannes Reinecke
Michael Schmitz <schmitz...@gmail.com> > > --- > > Changed since v1: > - Reduce shost->max_lun limit instead of adding 'MAX_LUN' limit. > > --- > drivers/scsi/NCR5380.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Hannes Re

Re: [PATCH v3 14/23] ncr5380: Reduce max_lun limit

2016-03-23 Thread Hannes Reinecke
-- > > Changed since v1: > - Reduce shost->max_lun limit instead of adding 'MAX_LUN' limit. > > --- > drivers/scsi/NCR5380.c |2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v3 04/23] atari_NCR5380: Remove DMA_MIN_SIZE macro

2016-03-23 Thread Hannes Reinecke
wo core drivers. > > Signed-off-by: Finn Thain <fth...@telegraphics.com.au> > Tested-by: Michael Schmitz <schmitz...@gmail.com> > > --- > > Changes since v1: > - Retain MIN_DMA_SIZE macro in wrapper drivers. > Reviewed-by: Hannes Reinecke <h...@suse.com> Che

Re: [PATCH v3 04/23] atari_NCR5380: Remove DMA_MIN_SIZE macro

2016-03-23 Thread Hannes Reinecke
wo core drivers. > > Signed-off-by: Finn Thain > Tested-by: Michael Schmitz > > --- > > Changes since v1: > - Retain MIN_DMA_SIZE macro in wrapper drivers. > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH] scsi: fc: use get/put_unaligned64 for wwn access

2016-03-19 Thread Hannes Reinecke
with > gcc-5.3 before. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > --- > include/scsi/scsi_transport_fc.h | 15 +++---- > 1 file changed, 3 insertions(+), 12 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Rei

Re: [PATCH] scsi: fc: use get/put_unaligned64 for wwn access

2016-03-19 Thread Hannes Reinecke
th > gcc-5.3 before. > > Signed-off-by: Arnd Bergmann > --- > include/scsi/scsi_transport_fc.h | 15 +++---- > 1 file changed, 3 insertions(+), 12 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage

Re: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-15 Thread Hannes Reinecke
On 03/15/2016 04:27 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >> On 03/14/2016 05:27 AM, Finn Thain wrote: >>> This setting does not need to be conditional on Atari ST or TT. >>> >>> Without TCQ support, cmd_per_lun == 2 is

Re: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-15 Thread Hannes Reinecke
On 03/15/2016 04:27 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >> On 03/14/2016 05:27 AM, Finn Thain wrote: >>> This setting does not need to be conditional on Atari ST or TT. >>> >>> Without TCQ support, cmd_per_lun == 2 is

Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

2016-03-15 Thread Hannes Reinecke
On 03/15/2016 04:19 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S >>> NCR5380_read(RESET_PARITY_INTERRUPT_REG); >>> *data = d + c; >>> *count

Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

2016-03-15 Thread Hannes Reinecke
On 03/15/2016 04:19 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S >>> NCR5380_read(RESET_PARITY_INTERRUPT_REG); >>> *data = d + c; >>> *count

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: >>> vports = lpfc_create_vport_work_array(phba); >>> - if (vports != NULL) >>> + if (vports != NULL) { >>> for (i = 0; i <

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: >>> vports = lpfc_create_vport_work_array(phba); >>> - if (vports != NULL) >>> + if (vports != NULL) { >>> for (i = 0; i <

Re: [PATCH 3/3] megaraid_sas: add missing curly braces in ioctl handler

2016-03-14 Thread Hannes Reinecke
]) { > dma_free_coherent(>pdev->dev, > le32_to_cpu(kern_sge32[i].length), > kbuff_arr[i], > le32_to_cpu(kern_sge32[i].phys_addr)); > kbuff_

Re: [PATCH 3/3] megaraid_sas: add missing curly braces in ioctl handler

2016-03-14 Thread Hannes Reinecke
gt; dma_free_coherent(>pdev->dev, > le32_to_cpu(kern_sge32[i].length), > kbuff_arr[i], > le32_to_cpu(kern_sge32[i].phys_addr)); > kbuff_arr[i] = NULL;

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
lpfc_destroy_vport_work_array(phba, vports); > > lpfc_unblock_mgmt_io(phba); > return 0; > Nope. vports is only valid from within the indentation block, so it should be moved into it. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Network

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
work_array(phba, vports); > > lpfc_unblock_mgmt_io(phba); > return 0; > Nope. vports is only valid from within the indentation block, so it should be moved into it. Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 22/22] mac_scsi: Fix pseudo DMA implementation

2016-03-14 Thread Hannes Reinecke
<fth...@telegraphics.com.au> > > --- > drivers/scsi/NCR5380.h |2 > drivers/scsi/mac_scsi.c | 210 > ++-- > 2 files changed, 118 insertions(+), 94 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Ha

Re: [PATCH 22/22] mac_scsi: Fix pseudo DMA implementation

2016-03-14 Thread Hannes Reinecke
gt; --- > drivers/scsi/NCR5380.h |2 > drivers/scsi/mac_scsi.c | 210 > ++-- > 2 files changed, 118 insertions(+), 94 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 21/22] atari_scsi: Allow can_queue to be increased for Falcon

2016-03-14 Thread Hannes Reinecke
submitted whenever bus arbitration tells you so? But in the end it really looks like a real issue somewhere in the code, be it the driver or the block/scsi layer. Nevertheless, setting it to '1' is certainly the correct way here. Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -

Re: [PATCH 21/22] atari_scsi: Allow can_queue to be increased for Falcon

2016-03-14 Thread Hannes Reinecke
ls you so? But in the end it really looks like a real issue somewhere in the code, be it the driver or the block/scsi layer. Nevertheless, setting it to '1' is certainly the correct way here. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-14 Thread Hannes Reinecke
7, > + .cmd_per_lun= 2, > .use_clustering = DISABLE_CLUSTERING, > .cmd_size = NCR5380_CMD_SIZE, > }; _2_ ? Are you being overly cheeky here? I sincerely doubt the driver is capable of submitting two simultaneous commands ... Care to explain? Cheers, Ha

Re: [PATCH 20/22] atari_scsi: Set a reasonable default for cmd_per_lun

2016-03-14 Thread Hannes Reinecke
= 2, > .use_clustering = DISABLE_CLUSTERING, > .cmd_size = NCR5380_CMD_SIZE, > }; _2_ ? Are you being overly cheeky here? I sincerely doubt the driver is capable of submitting two simultaneous commands ... Care to explain? Cheers, Hannes -- Dr. Hann

Re: [PATCH 19/22] ncr5380: Update usage documentation

2016-03-14 Thread Hannes Reinecke
/g_NCR5380.txt | 17 ++- > Documentation/scsi/scsi-parameters.txt | 11 +++--- > drivers/scsi/g_NCR5380.c | 36 > - > 3 files changed, 16 insertions(+), 48 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes

Re: [PATCH 19/22] ncr5380: Update usage documentation

2016-03-14 Thread Hannes Reinecke
Documentation/scsi/scsi-parameters.txt | 11 +++--- > drivers/scsi/g_NCR5380.c | 36 > - > 3 files changed, 16 insertions(+), 48 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamle

Re: [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros

2016-03-14 Thread Hannes Reinecke
2 -- > drivers/scsi/dtc.c | 12 +++- > drivers/scsi/g_NCR5380.c |2 -- > drivers/scsi/pas16.c |1 - > drivers/scsi/t128.c |1 - > 8 files changed, 4 insertions(+), 32 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Han

Re: [PATCH 17/22] ncr5380: Remove remaining register storage qualifiers

2016-03-14 Thread Hannes Reinecke
se; > + unsigned char *d = *data; > unsigned char tmp; > int result = 0; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger

Re: [PATCH 18/22] ncr5380: Remove DONT_USE_INTR and AUTOPROBE_IRQ macros

2016-03-14 Thread Hannes Reinecke
/scsi/dtc.c | 12 +++- > drivers/scsi/g_NCR5380.c |2 -- > drivers/scsi/pas16.c |1 - > drivers/scsi/t128.c |1 - > 8 files changed, 4 insertions(+), 32 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTea

Re: [PATCH 17/22] ncr5380: Remove remaining register storage qualifiers

2016-03-14 Thread Hannes Reinecke
d = *data; > unsigned char tmp; > int result = 0; > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-14 Thread Hannes Reinecke
R = 0x%02x : ", icr); > for (i = 0; icrs[i].mask; ++i) > if (icr & icrs[i].mask) > - printk(",%s", icrs[i].name); > - printk("\nMODE: %02x ", mr); > + printk(KERN_CONT "%s, "

Re: [PATCH 16/22] ncr5380: Fix register decoding for debugging

2016-03-14 Thread Hannes Reinecke
; > for (i = 0; icrs[i].mask; ++i) > if (icr & icrs[i].mask) > - printk(",%s", icrs[i].name); > - printk("\nMODE: %02x ", mr); > + printk(KERN_CONT "%s, ", icrs[i].name); > + printk(KER

Re: [PATCH 15/22] dmx3191d: Drop max_sectors limit

2016-03-14 Thread Hannes Reinecke
elegraphics.com.au> > > --- > drivers/scsi/dmx3191d.c |1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 15/22] dmx3191d: Drop max_sectors limit

2016-03-14 Thread Hannes Reinecke
; --- > drivers/scsi/dmx3191d.c |1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90

Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit

2016-03-14 Thread Hannes Reinecke
=== > --- linux.orig/drivers/scsi/NCR5380.h 2016-03-14 15:26:45.0 +1100 > +++ linux/drivers/scsi/NCR5380.h 2016-03-14 15:26:48.0 +1100 > @@ -244,6 +244,8 @@ struct NCR5380_hostdata { > > #ifdef __KERNEL__ > > +#define MAX_LUN 7 &g

Re: [PATCH 13/22] ncr5380: Remove disused atari_NCR5380.c core driver

2016-03-14 Thread Hannes Reinecke
-- > drivers/scsi/atari_scsi.c| 11 > drivers/scsi/mac_scsi.c | 8 > drivers/scsi/sun3_scsi.c | 11 > 6 files changed, 4 insertions(+), 2699 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr

Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit

2016-03-14 Thread Hannes Reinecke
nux.orig/drivers/scsi/NCR5380.h 2016-03-14 15:26:45.0 +1100 > +++ linux/drivers/scsi/NCR5380.h 2016-03-14 15:26:48.0 +1100 > @@ -244,6 +244,8 @@ struct NCR5380_hostdata { > > #ifdef __KERNEL__ > > +#define MAX_LUN 7 > + > struct NCR5380_cmd

Re: [PATCH 13/22] ncr5380: Remove disused atari_NCR5380.c core driver

2016-03-14 Thread Hannes Reinecke
--- > drivers/scsi/atari_scsi.c| 11 > drivers/scsi/mac_scsi.c | 8 > drivers/scsi/sun3_scsi.c | 11 > 6 files changed, 4 insertions(+), 2699 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage &

Re: [PATCH 12/22] sun3_scsi: Adopt NCR5380.c core driver

2016-03-14 Thread Hannes Reinecke
> --- > drivers/scsi/NCR5380.c | 131 > +++ > drivers/scsi/sun3_scsi.c |8 +- > 2 files changed, 124 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Netwo

Re: [PATCH 12/22] sun3_scsi: Adopt NCR5380.c core driver

2016-03-14 Thread Hannes Reinecke
+ > drivers/scsi/sun3_scsi.c |8 +- > 2 files changed, 124 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 11/22] atari_scsi: Adopt NCR5380.c core driver

2016-03-14 Thread Hannes Reinecke
rs/scsi/NCR5380.c| 32 > drivers/scsi/atari_scsi.c |6 +++--- > 2 files changed, 35 insertions(+), 3 deletions(-) > Reviewd-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 11/22] atari_scsi: Adopt NCR5380.c core driver

2016-03-14 Thread Hannes Reinecke
rivers/scsi/atari_scsi.c |6 +++--- > 2 files changed, 35 insertions(+), 3 deletions(-) > Reviewd-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, M

Re: [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver

2016-03-14 Thread Hannes Reinecke
2 > drivers/scsi/t128.h |1 > 13 files changed, 152 insertions(+), 40 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 740

Re: [PATCH 10/22] ncr5380: Merge DMA implementation from atari_NCR5380 core driver

2016-03-14 Thread Hannes Reinecke
|1 > 13 files changed, 152 insertions(+), 40 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg G

<    3   4   5   6   7   8   9   10   11   12   >