On 03/12/2020 19:59, Sowjanya Komatineni wrote:
> Some CSI2 receivers support 8 data lanes.
>
> So, this patch updates CSI2 maximum data lanes to be 8.
>
> Signed-off-by: Sowjanya Komatineni
> ---
> drivers/media/platform/ti-vpe/cal-camerarx.c | 2 +-
> include/media/v4l2-fwnode.h
On 07/12/2020 10:06, Stanimir Varbanov wrote:
>
>
> On 12/2/20 1:12 PM, Hans Verkuil wrote:
>> On 24/11/2020 00:02, Stanimir Varbanov wrote:
>>> Add Content light level and Mastering display colour volume v4l2
>>> compounf controls, relevant payload structur
On 23/11/2020 18:40, Helen Koike wrote:
>
>
> On 11/23/20 12:46 PM, Tomasz Figa wrote:
>> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike
>> wrote:
>>>
>>> Hi Hans,
>>>
>>> Thank you for your review.
>>>
>>> On 9/9/20 9:2
On 03/12/2020 10:28, Mauro Carvalho Chehab wrote:
> Em Thu, 26 Nov 2020 06:36:17 -0300
> Ezequiel Garcia escreveu:
>
>> The H264 stateless controls is ready to be part
>> of the stable uAPI.
>>
>> Re-number the control IDs, move them to the newly
>> created stateless control class, and updates al
On 02/12/2020 22:46, Ezequiel Garcia wrote:
> On Wed, 2020-12-02 at 16:11 +0100, Hans Verkuil wrote:
>> Hi Ezequiel,
>>
>> Some small comments:
>>
>> On 30/11/2020 19:52, Ezequiel Garcia wrote:
>>> Typically, bitstreams are composed of one sequence he
On 02/12/2020 15:56, Neil Armstrong wrote:
> Hi Hans,
>
> On 02/12/2020 13:40, Hans Verkuil wrote:
>> On 17/11/2020 09:44, Neil Armstrong wrote:
>>> The GE2D is a 2D accelerator with various features like configurable blitter
>>> with alpha blending, frame rotatio
Hi Ezequiel,
Some small comments:
On 30/11/2020 19:52, Ezequiel Garcia wrote:
> Typically, bitstreams are composed of one sequence header NAL unit,
> followed by a number of picture header and picture coding extension
> NAL units. Each picture can be composed by a number of slices.
>
> Let's spl
Hi Martin, Maxime,
On 16/11/2020 13:56, Martin Cerveny wrote:
> First patch extends cedrus capability to all decoders
> because V3s missing MPEG2 decoder.
>
> Next two patches add system control node (SRAM C1) and
> next three patches add support for Cedrus VPU.
I've picked up patches 1, 4 and
On 09/11/2020 18:35, Stanimir Varbanov wrote:
> Make display delay and display delay enable MFC controls standard v4l
> controls. This will allow reuse of the controls for other decoder
> drivers. Also the new proposed controls are now codec agnostic because
> they could be used for any codec.
>
>
Hi Dikshita,
Just a few nitpicks, I'd have changed it myself, but since a new version is
needed anyway you might as well change it for next time :-)
On 18/11/2020 07:54, Dikshita Agarwal wrote:
> - Adds min/max qp controls for B frame for h264.
> - Adds min/max qp controls for I/P/B frames for he
On 01/12/2020 09:13, Dikshita Agarwal wrote:
> Long Term Reference (LTR) frames are the frames that are encoded
> sometime in the past and stored in the DPB buffer list to be used
> as reference to encode future frames.
> This change adds controls to enable this feature.
>
> Signed-off-by: Dikshit
On 23/11/2020 09:50, Dikshita Agarwal wrote:
> This control indicates the priority id to be applied
id -> ID
(ditto in the subject)
> to base layer.
>
> Signed-off-by: Dikshita Agarwal
> ---
> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +
> drivers/media/v4l2-core/v
On 18/11/2020 07:54, Dikshita Agarwal wrote:
> Add support for frame type specific min and max qp controls
> for encoder.
>
> Signed-off-by: Dikshita Agarwal
> ---
> drivers/media/platform/qcom/venus/core.h | 18 +
> drivers/media/platform/qcom/venus/venc.c | 21 ---
>
On 17/11/2020 09:44, Neil Armstrong wrote:
> The GE2D is a 2D accelerator with various features like configurable blitter
> with alpha blending, frame rotation, scaling, format conversion and colorspace
> conversion.
>
> The driver implements a Memory2Memory VB2 V4L2 streaming device permitting:
>
On 17/11/2020 09:44, Neil Armstrong wrote:
> The GE2D is a 2D accelerator with various features like configurable blitter
> with alpha blending, frame rotation, scaling, format conversion and colorspace
> conversion.
>
> The driver implements a Memory2Memory VB2 V4L2 streaming device permitting:
>
On 30/11/2020 10:08, Stanimir Varbanov wrote:
> Add a control to enable inserting of AUD NALU into encoded
> bitstream.
>
> Signed-off-by: Stanimir Varbanov
> ---
> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 5 +
> drivers/media/v4l2-core/v4l2-ctrls.c |
On 12/11/2020 04:05, Mirela Rabulea (OSS) wrote:
> From: Mirela Rabulea
>
> These are optional in struct v4l2_jpeg_header, so do not parse if
> not requested, save some time.
>
> Signed-off-by: Mirela Rabulea
> ---
> drivers/media/v4l2-core/v4l2-jpeg.c | 6 ++
> 1 file changed, 6 insertion
On 02/12/2020 11:35, Fabio Estevam wrote:
> Since 5.10-rc1 i.MX is a devicetree-only platform, so simplify the code
> by removing the unused non-DT support.
You forgot to Cc to linux-media. Please repost so it will end up
in the media patchwork!
Regards,
Hans
>
> Signed-off-by: Fabio E
On 19/10/2020 00:01, Rustam Kovhaev wrote:
> On Fri, Apr 19, 2019 at 07:36:05AM -0700, syzbot wrote:
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit:d34f9519 usb-fuzzer: main usb gadget fuzzer driver
>> git tree: https://github.com/google/kasan/tree/usb-fuzzer
>> co
On 24/11/2020 00:02, Stanimir Varbanov wrote:
> Add Content light level and Mastering display colour volume v4l2
> compounf controls, relevant payload structures and validation.
compounf -> compound
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 62
On 24/11/2020 00:02, Stanimir Varbanov wrote:
> Document Content light level and Mastering display colour volume.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../media/v4l/ext-ctrls-codec.rst | 71 +++
> 1 file changed, 71 insertions(+)
>
> diff --git a/Documentatio
On 09/11/2020 10:13, Martin Kepplinger wrote:
> As described in NXPs' linux tree, the imx8m SoC includes the same
> CSI bridge hardware that is part of imx7d. We should be able to
> use the "fsl,imx7-csi" driver for imx8m directly.
>
> Since ipuv3 is not relevant for imx8m, drop the build dependen
On 29/11/2020 04:15, Sergey Senozhatsky wrote:
> We need to always set ->need_cache_sync_on_prepare and
> ->need_cache_sync_on_finish when we initialize vb2 buffer.
>
> Currently these flags are set/adjusted only in V4L2's
> vb2_queue_or_prepare_buf(), which means that for the code
> paths that do
On 27/11/2020 15:30, Sergey Senozhatsky wrote:
> On (20/11/27 13:59), Hans Verkuil wrote:
>>
>> I think this needs a comment, basically explaining what you said in
>> the commit log. It's not obvious from the code that this is a
>> workaround.
>
> Something
On 27/11/2020 15:00, Naresh Kamboju wrote:
> FYI,
> you might have seen this problem, but for the record I am reporting here,
> Following test cases have been failing for a while on the mainline kernel.
> Please find crash log and git short between bad and good commit.
>
> List of failed test case
On 27/11/2020 10:41, Sergey Senozhatsky wrote:
> We need to always set ->need_cache_sync_on_prepare and
> ->need_cache_sync_on_finish when we initialize vb2 buffer.
>
> Currently these flags are set/adjusted only in V4L2's
> vb2_queue_or_prepare_buf(), which means that for the code
> paths that do
On 23/11/2020 15:40, Ezequiel Garcia wrote:
> Now that we've destaged the H264 stateless codec controls,
> and with all the pieces in place, update the documentation
> and move it to its own section.
>
> Signed-off-by: Ezequiel Garcia
> ---
> .../userspace-api/media/v4l/common.rst| 1 +
On 23/11/2020 15:40, Ezequiel Garcia wrote:
> Now that we've destaged the H264 stateless codec controls,
> and with all the pieces in place, update the documentation
> and move it to its own section.
>
> Signed-off-by: Ezequiel Garcia
> ---
> .../userspace-api/media/v4l/common.rst| 1 +
On 23/11/2020 15:39, Ezequiel Garcia wrote:
> The H264 stateless controls is ready to be part
> of the stable uAPI.
>
> Re-number the control IDs, move them to the newly
> created stateless control class, and updates all
> the drivers accordingly.
>
> Signed-off-by: Ezequiel Garcia
> ---
> driv
On 23/11/2020 15:39, Ezequiel Garcia wrote:
> Check that all the fields that correspond or are related
> to a H264 specification syntax element have legal values.
>
> Signed-off-by: Ezequiel Garcia
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 128 +++
> include/media/h2
On 20/11/2020 13:40, Tomasz Figa wrote:
> On Fri, Nov 20, 2020 at 9:24 PM Hans Verkuil wrote:
>>
>> On 20/11/2020 12:06, Tomasz Figa wrote:z
>>> Hi Helen,
>>>
>>> On Tue, Aug 04, 2020 at 04:29:39PM -0300, Helen Koike wrote:
>>>> Add documentat
On 20/11/2020 12:06, Tomasz Figa wrote:z
> Hi Helen,
>
> On Tue, Aug 04, 2020 at 04:29:39PM -0300, Helen Koike wrote:
>> Add documentation and update references in current documentation for the
>> Extended API.
>>
>
> Thank you for the patch. Please see my comments inline.
>
>> Signed-off-by: He
On 20/11/2020 11:51, Daniel Vetter wrote:
> On Fri, Nov 20, 2020 at 11:39 AM Hans Verkuil wrote:
>>
>> On 20/11/2020 10:18, Daniel Vetter wrote:
>>> On Fri, Nov 20, 2020 at 9:28 AM Hans Verkuil wrote:
>>>>
>>>> On 20/11/2020 09:06, Hans Verkuil
On 20/11/2020 10:18, Daniel Vetter wrote:
> On Fri, Nov 20, 2020 at 9:28 AM Hans Verkuil wrote:
>>
>> On 20/11/2020 09:06, Hans Verkuil wrote:
>>> On 19/11/2020 15:41, Daniel Vetter wrote:
>>>> The media model assumes that buffers are all preallocated, s
On 18/11/2020 19:46, Ezequiel Garcia wrote:
> Add a new control class to hold the stateless codecs controls
> that are ready to be moved out of staging.
>
> Signed-off-by: Ezequiel Garcia
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
> include/uapi/linux/v4l2-controls.h | 7 +++
>
On 18/11/2020 19:46, Ezequiel Garcia wrote:
> Check that all the fields that correspond or are related
> to a H264 specification syntax element have legal values.
>
> Signed-off-by: Ezequiel Garcia
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 83
> 1 file changed,
On 18/11/2020 19:46, Ezequiel Garcia wrote:
> For historical reasons, stateful codec controls are named
> as {}_MPEG_{}. While we can't at this point sanely
> change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
> we can least change the more meaningful macros such as classes
> ma
> In case someone wants to give this a test.
>
> Here's compliance output, with today's master branch:
>
> commit 11da65eee7a271bba3f21d8117cdac428fe3a91e (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Hans Verkuil
> Date: Sat Nov 14 13:41:14 2
On 20/11/2020 09:06, Hans Verkuil wrote:
> On 19/11/2020 15:41, Daniel Vetter wrote:
>> The media model assumes that buffers are all preallocated, so that
>> when a media pipeline is running we never miss a deadline because the
>> buffers aren't allocated or available.
Hubbard
> Acked-by: Mauro Carvalho Chehab
> Acked-by: Tomasz Figa
Acked-by: Hans Verkuil
Thanks!
Hans
> Signed-off-by: Daniel Vetter
> Cc: Jason Gunthorpe
> Cc: Pawel Osciak
> Cc: Marek Szyprowski
> Cc: Kyungmin Park
> Cc: Tomasz Figa
> Cc: Mauro C
ffects
> the zerocopy userptr usage enabled in 50ac952d2263 ("[media]
> videobuf2-dma-sg: Support io userptr operations on io memory").
>
> Acked-by: Tomasz Figa
Acked-by: Hans Verkuil
Thanks!
Hans
> Signed-off-by: Daniel Vetter
> Cc: Jason Gunthorpe
>
Nicolas, can you take a look at this with your codec knowledge?
Some other review comments below:
On 15/10/2020 13:05, Dikshita Agarwal wrote:
> This control indicates the priority id to be applied
> to base layer.
>
> Signed-off-by: Dikshita Agarwal
> ---
> Documentation/userspace-api/media/v
Hi Dikshita,
I'm happy with the controls themselves, but the documentation needs more work:
On 15/10/2020 13:01, Dikshita Agarwal wrote:
> LTR (Long Term Reference) frames are the frames that are encoded
> sometime in the past and stored in the DPB buffer list to be used
> as reference to encode
On 16/11/2020 13:07, Martin Cerveny wrote:
> Hello.
>
> On Mon, 16 Nov 2020, Martin Cerveny wrote:
>> On Mon, 16 Nov 2020, Hans Verkuil wrote:
>>> On 15/11/2020 19:59, Martin Cerveny wrote:
>>>> On Thu, 5 Nov 2020, Hans Verkuil wrote:
>>>>> On 1
On 15/11/2020 19:59, Martin Cerveny wrote:
> Hello.
>
> On Thu, 5 Nov 2020, Hans Verkuil wrote:
>
>> Hi Martin,
>>
>> On 12/09/2020 16:30, Martin Cerveny wrote:
>>> First patch extends cedrus capability to all decoders
>>> because V3s missing MP
On 13/11/2020 22:51, Ezequiel Garcia wrote:
> Now that we've destaged the H264 stateless codec controls,
> and with all the pieces in place, update the documentation
> and move it to its own section.
>
> Signed-off-by: Ezequiel Garcia
> ---
> .../userspace-api/media/v4l/common.rst| 1 +
On 13/11/2020 22:51, Ezequiel Garcia wrote:
> Now that H.264 stateless controls are solid, we can get it
> out of staging.
>
> Following some guidelines from Hans, this series creates a
> new stateless control class for the stable codec controls to land.
>
> While here, I'm including a patch from
On 13/11/2020 22:51, Ezequiel Garcia wrote:
> For historical reasons, stateful codec controls are named
> as {}_MPEG_{}. While we can't at this point sanely
> change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
> we can least change the more meaningful macros such as classes
> ma
On 12/11/2020 12:57, Ezequiel Garcia wrote:
> The H264 stateless control class is ready to be part
> of the stable uAPI.
>
> The control IDs and types are re-numbered and moved
> to a newly created stateless control class, and
> a new documentation section is created.
This patch needs to be split
On 12/11/2020 12:57, Ezequiel Garcia wrote:
> For historical reasons, stateful codec controls are named
> as {}_MPEG_{}. While we can't at this point sanely
> change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
> we can least change the more meaningful macros such as classes
> ma
On 06/11/2020 16:14, Maxime Ripard wrote:
> Hi,
>
> Here's an attempt to removing the dma_direct_set_offset calls we have in
> numerous drivers and move all those quirks into a global notifier as suggested
> by Robin.
For patches 4-7:
Acked-by: Hans Verkuil
It's fin
On 30/10/2020 15:37, Neil Armstrong wrote:
> The GE2D is a 2D accelerator with various features like configurable blitter
> with alpha blending, frame rotation, scaling, format conversion and colorspace
> conversion.
>
> The driver implements a Memory2Memory VB2 V4L2 streaming device permitting:
>
On 11/11/2020 13:41, Alexandre Courbot wrote:
> On Thu, Nov 5, 2020 at 11:05 PM Alexandre Courbot wrote:
>>
>> On Thu, Nov 5, 2020 at 10:12 PM Hans Verkuil
>> wrote:
>>>
>>> On 05/11/2020 13:52, Alexandre Courbot wrote:
>>>> On Th
On 21/09/2020 15:03, Dikshita Agarwal wrote:
> - Adds min/max qp controls for B frame for h264.
> - Adds min/max qp controls for I/P/B frames for hevc similar to h264.
> - Update valid range of mim/max qp for hevc to accommodate 10 bit.
>
> Signed-off-by: Dikshita Agarwal
> ---
> .../userspace-a
On 21/09/2020 15:04, Dikshita Agarwal wrote:
> Adds bitrate control for all coding layers for h264
> same as hevc.
>
> Signed-off-by: Dikshita Agarwal
> ---
> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 20
>
> drivers/media/v4l2-core/v4l2-ctrls.c
On 24/09/2020 19:42, Nicolas Dufresne wrote:
> Le lundi 21 septembre 2020 à 18:33 +0530, Dikshita Agarwal a écrit :
>> This series adds frame specific min/max qp controls for hevc and layer
>> wise bitrate control for h264.
>
> Any chance you could append your driver changes with this set ? I don'
On 09/11/2020 18:31, Stanimir Varbanov wrote:
> Document Content light level and Mastering display colour volume.
>
> Signed-off-by: Stanimir Varbanov
> ---
> .../media/v4l/ext-ctrls-codec.rst | 61 +++
> 1 file changed, 61 insertions(+)
>
> diff --git a/Documentatio
On 09/11/2020 18:31, Stanimir Varbanov wrote:
> Add Content light level and Mastering display colour volume v4l2
> compounf controls, relevant payload structures and validation.
Typo: compounf -> compound
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/v4l2-core/v4l2-ctrls.c | 61 ++
On 10/11/2020 10:38, Hans Verkuil wrote:
> On 09/11/2020 20:53, Nicolas Dufresne wrote:
>> Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit :
>>> Hello,
>>>
>>> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level
>>
On 09/11/2020 20:53, Nicolas Dufresne wrote:
> Le lundi 09 novembre 2020 à 19:31 +0200, Stanimir Varbanov a écrit :
>> Hello,
>>
>> This patchset adds two HDR10 HEVC v4l2 controls for Content Light Level
>> and Mastering display colour volume plus implenmentation in Venus encoder
>> driver.
>>
>> C
Hi Sowjanya,
On 27/10/2020 04:19, Sowjanya Komatineni wrote:
> Tegra VI/CSI hardware don't have native 8 lane capture support.
>
> Each CSI port has max 4 lanes only. So for x8 captures, consecutive
> ports are ganged up for left half and right half captures on to each
> x4 ports with buffer offs
On 27/10/2020 04:19, Sowjanya Komatineni wrote:
> V4L2 pixel format is incorrect for RGB888_1X24.
>
> This patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni
> ---
> drivers/staging/media/tegra-video/tegra210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driver
On 30/10/2020 12:22, Helen Koike wrote:
> All the items in the TODO list were addressed, uapi was reviewed,
> documentation written, checkpatch errors fixed, several bugs fixed.
>
> There is no big reason to keep this driver in staging, so move it out.
>
> Signed-off-by: Helen Koike
Mauro held
On 30/10/2020 12:22, Helen Koike wrote:
> From: Shunqian Zheng
>
> Add the Rockchip ISP1 specific processing parameter format
> V4L2_META_FMT_RK_ISP1_PARAMS and metadata format
> V4L2_META_FMT_RK_ISP1_STAT_3A for 3A.
>
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Jacob Chen
> Signed-off-by
Hi Martin,
On 12/09/2020 16:30, Martin Cerveny wrote:
> First patch extends cedrus capability to all decoders
> because V3s missing MPEG2 decoder.
>
> Next two patches add system control node (SRAM C1) and
> next three patches add support for Cedrus VPU.
>
> Tested on "Lichee Zero" V3s platform
On 05/11/2020 13:52, Alexandre Courbot wrote:
> On Thu, Nov 5, 2020 at 9:36 PM Hans Verkuil wrote:
>>
>> On 05/11/2020 13:21, Alexandre Courbot wrote:
>>> On Tue, Nov 3, 2020 at 6:48 PM Hans Verkuil
>>> wrote:
>>>>
>>>> On 03/11/2020 09:5
On 05/11/2020 13:21, Alexandre Courbot wrote:
> On Tue, Nov 3, 2020 at 6:48 PM Hans Verkuil wrote:
>>
>> On 03/11/2020 09:51, Alexandre Courbot wrote:
>>> Hi Hans,
>>>
>>> On Sat, Oct 31, 2020 at 12:09 AM Hans Verkuil
>>> wrote:
>
On 04/11/2020 14:27, Mirela Rabulea wrote:
> Hi Hans,
>
> On Wed, 2020-11-04 at 12:55 +0100, Hans Verkuil wrote:
>>
>> So please recompile v4l2-compliance from the git repo and retest. If
>> you find new failures, then you probably need to post a v5, otherwise
>&
On 04/11/2020 12:52, Hans Verkuil wrote:
> On 02/11/2020 04:08, Mirela Rabulea (OSS) wrote:
>> From: Mirela Rabulea
>>
>> Changes in v4:
>> The main change is using the common jpeg helpers in imx-jpeg
>> Summary of changes:
>> Patch 1, 2, 3, 5,
On 02/11/2020 04:08, Mirela Rabulea (OSS) wrote:
> From: Mirela Rabulea
>
> Changes in v4:
> The main change is using the common jpeg helpers in imx-jpeg
> Summary of changes:
> Patch 1, 2, 3, 5, 6 - no change
> Patch 4 - small update: VFL_TYPE_VIDEO-> VFL_TYPE_GRABBER and 2 typos
> Patch 7 - new
On 13/10/2020 16:56, Tomasz Figa wrote:
> On Tue, Oct 13, 2020 at 4:53 PM Stanimir Varbanov
> wrote:
>>
>>
>>
>> On 10/13/20 5:07 PM, Tomasz Figa wrote:
>>> On Tue, Oct 13, 2020 at 3:53 PM Stanimir Varbanov
>>> wrote:
On 10/13/20 4:40 PM, Tomasz Figa wrote:
> On Tue, Oct 1
On 03/11/2020 09:51, Alexandre Courbot wrote:
> Hi Hans,
>
> On Sat, Oct 31, 2020 at 12:09 AM Hans Verkuil
> wrote:
>>
>> On 22/10/2020 14:24, Alexandre Courbot wrote:
>>> do_poll()/do_select() seem to set the _qproc member of poll_table to
>>> NULL
On 22/10/2020 14:24, Alexandre Courbot wrote:
> do_poll()/do_select() seem to set the _qproc member of poll_table to
> NULL the first time they are called on a given table, making subsequent
> calls of poll_wait() on that table no-ops. This is a problem for mem2mem
> which calls poll_wait() on the
Maxime,
Are you OK with this series? It looks good to me.
Regards,
Hans
On 12/09/2020 16:30, Martin Cerveny wrote:
> First patch extends cedrus capability to all decoders
> because V3s missing MPEG2 decoder.
>
> Next two patches add system control node (SRAM C1) and
> next three patch
Thierry,
On 30/09/2020 05:02, Sowjanya Komatineni wrote:
> Tegra V4L2 driver has dependency on this host1x driver and currently
> host1x driver is allowed to build with COMPILE_TEST only on ARM and
> this also limits Tegra V4L2 driver building.
>
> So, this patch allows building host1x driver wit
On 19/10/2020 13:54, Defang Bo wrote:
> Similar to commit("media: v4l2-compat-ioctl32: prevent go past
> max size"} ,add max size check for count variable.
>
> Signed-off-by: Defang Bo
> ---
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On 09/10/2020 14:37, Yu Kuai wrote:
> if mtk_jpeg_clk_init() succeed, mtk_jpeg_probe() doesn't have a
> corresponding put_device(). Thus add put_device() in jump target to fix
> the exception handling for this function implementation.
>
> Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Mediate
On 30/10/2020 06:51, Helen Koike wrote:
> Hello,
>
> I think it is time to move this driver out of staging.
>
> Thanks all who contributed, specially to Dafna, who put a lot of
> effort addressing all the items in the TODO list, fixing bugs,
> cleaning the code, addressing past comments and testi
Hi Arnd,
On 06/10/2020 17:28, Hans Verkuil wrote:
> Hi Arnd,
>
> On 06/10/2020 17:14, Arnd Bergmann wrote:
>>
>> As you suggested earlier, I will resend the fixed series after -rc1
>> is out.
>
> Looking forward to that.
FYI: v5.10-rc1 was just merged into the
On 08/10/2020 16:02, Alexandre Courbot wrote:
> Hi Hans, thanks for taking the time to look at this!
>
> On Thu, Oct 8, 2020 at 10:12 PM Hans Verkuil wrote:
>>
>> On 08/10/2020 15:07, Hans Verkuil wrote:
>>> Hi Alexandre,
>>>
>>> On 04/10/2020 14:2
On 08/10/2020 15:07, Hans Verkuil wrote:
> Hi Alexandre,
>
> On 04/10/2020 14:22, Alexandre Courbot wrote:
>> The addition of MT8183 support added a dependency on the SCP remoteproc
>> module. However the initial patch used the "select" Kconfig directive,
>>
Hi Alexandre,
On 04/10/2020 14:22, Alexandre Courbot wrote:
> The addition of MT8183 support added a dependency on the SCP remoteproc
> module. However the initial patch used the "select" Kconfig directive,
> which may result in the SCP module to not be compiled if remoteproc was
> disabled. In su
Hi Arnd,
On 06/10/2020 17:14, Arnd Bergmann wrote:
> On Fri, Oct 2, 2020 at 4:32 PM Hans Verkuil wrote:
>> On 17/09/2020 17:28, Arnd Bergmann wrote:
>
>> While testing I found a lot of bugs. Below is a patch that sits on top
>> of your series and fixes all the bugs:
>
On 24/09/2020 10:18, Yu Kuai wrote:
> if of_find_device_by_node() succeed, mtk_vcodec_init_dec_pm() doesn't have
> a corresponding put_device(). Thus add jump target to fix the exception
> handling for this function implementation.
>
> Fixes: 590577a4e525 ("[media] vcodec: mediatek: Add Mediatek V
>
>>> media: vivid: Add support to the CSC API
>>>
>>> The CSC API (Colorspace conversion) allows userspace to try
>>> to configure the colorspace, transfer function, Y'CbCr/HSV encoding
>>> and the quantization for capture devices.
red, also when
in_compat_syscall()
- video_usercopy: err = v4l2_compat_put_array_args overwrote the original ioctl
err value.
Handle this correctly.
I've tested this as well with the y2038 compat mode (i686 with 64-bit time_t)
and that too works fine.
Regards,
Hans
Signed-off-by: Ha
t; vb2_buffer_done+0x208/0x2a0
>
> Fix it by removing the spurious v4l2_m2m_buf_done.
>
> Reported-by: Adrian Ratiu
> Fixes: 911ea8ec42dea ("media: v4l2-mem2mem: add v4l2_m2m_suspend,
> v4l2_m2m_resume")
> Signed-off-by: Ezequiel Garcia
Reviewed-by: Hans Verkuil
On 28/09/2020 15:53, Laurent Pinchart wrote:
> Hi Hans,
>
> On Mon, Sep 28, 2020 at 03:45:03PM +0200, Hans Verkuil wrote:
>> On 25/09/2020 20:30, Corentin Labbe wrote:
>>> Hello
>>>
>>> The zoran driver was removed in 5.3
>>> The main reason of t
Hi Corentin,
On 25/09/2020 20:30, Corentin Labbe wrote:
> Hello
>
> The zoran driver was removed in 5.3
> The main reason of the removing was lack of motivation to convert it to
> VB2
> Since I need it, I worked on bringing it back.
>
> So the plan to achieve it was:
> - clean up the coding styl
Hi Maxime,
Some comments below, this driver needs to be changed:
On 18/09/2020 16:24, Maxime Chevallier wrote:
> The Techwell video decoder supports PAL, NTSC and SECAM input formats,
> and outputs a BT.656 signal.
>
> This commit adds support for this device, based on an implementation
> made b
On 21/09/2020 22:21, Luca Ceresoli wrote:
> Documentation on how to call the subdev ops is currently in the middle of
> synchronous and asynchronous registration. Move it to a dedicated
> subsection after the registration methods.
>
> Also move the final paragraph "The advantage of using v4l2_subd
Hi Ezequiel,
On 21/09/2020 21:38, Ezequiel Garcia wrote:
> In preparation for making the interface public,
> document all the structures. Special care is taken to
> annotate those fields that depart from the H264 syntax.
>
> This commit only adds documentation and doesn't affect
> functionality i
On 22/05/2020 10:29, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.
>
> Also, call pm_runtime_put() and v4l2_fh_release() when sen
On 14/06/2020 01:08, wu000...@umn.edu wrote:
> From: Qiushi Wu
>
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus call pm_runtime_put_noidle()
> if pm_runtime_get_sync() fails.
>
> Fixes: b2f0d2724ba4 ("[media] vcodec: mediatek: Add Media
Hi Jean-Christophe,
I'll take this patch, but while reviewing it I noticed something else:
On 14/06/2020 05:31, wu000...@umn.edu wrote:
> From: Qiushi Wu
>
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code, causing incorrect ref count if
> pm_r
On 17/09/2020 12:19, Niklas Söderlund wrote:
> Hi Hans,
>
> On 2020-09-17 11:58:16 +0200, Hans Verkuil wrote:
>> On 17/09/2020 10:57, Hans Verkuil wrote:
>>> Hi Prabhakar,
>>>
>>> Can you rebase this patch? It no longer applies.
>>
>> Never mi
On 14/05/2020 17:39, Nicolas Dufresne wrote:
> As per spec, the CAPTURE resolution should be automatically set based on
> the OTUPUT resolution. This patch properly propagate width/height to the
> capture when the OUTPUT format is set and override the user provided
> width/height with configured OU
On 17/09/2020 10:57, Hans Verkuil wrote:
> Hi Prabhakar,
>
> Can you rebase this patch? It no longer applies.
Never mind, my mistake. When I was preparing this patch I also had this patch
applied:
https://patchwork.linuxtv.org/project/linux-media/patch/1595602732-25582-3-git-s
Hi Prabhakar,
Can you rebase this patch? It no longer applies.
Regards,
Hans
On 13/09/2020 20:16, Lad Prabhakar wrote:
> Enable YDS bit if bus_width and data_shift is set to 8 in parallel mode
> for MEDIA_BUS_FMT_UYVY8_2X8 format.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Biju D
Added Sylwester and Tomasz.
I'd like to have an Ack of a driver maintainer before merging.
Regards,
Hans
On 02/05/2020 21:40, Andriy Gelman wrote:
> From: Andriy Gelman
>
> As per V4L2 api, the final buffer should set V4L2_BUF_FLAG_LAST flag.
>
> Signed-off-by: Andriy Gelman
> ---
>
201 - 300 of 1153 matches
Mail list logo
