Re: [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY

ix by not returning IRQ_NONE if DRDY is set. > > Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle > multiple events") > > Signed-off-by: Leonard Crestez Thanks for catching it. Looks good to me. Acked-by: Harinath Nampally Thanks, Harinath On Wed, Jun 20,

Re: [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY

ix by not returning IRQ_NONE if DRDY is set. > > Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle > multiple events") > > Signed-off-by: Leonard Crestez Thanks for catching it. Looks good to me. Acked-by: Harinath Nampally Thanks, Harinath On Wed, Jun 20,

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

653 chip all other chips like mma845x and > > fxls8471 have single tap detection feature. > > Tested thoroughly using iio_event_monitor application on > > imx6ul-evk board which has fxls8471. > > > > Signed-off-by: Harinath Nampally <harinath...@gmail.com> >

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

653 chip all other chips like mma845x and > > fxls8471 have single tap detection feature. > > Tested thoroughly using iio_event_monitor application on > > imx6ul-evk board which has fxls8471. > > > > Signed-off-by: Harinath Nampally > > The use of an either

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

> This replaces the custom license information text with the appropriate > SPDX identifier. While the information here stays the same, it is easier > to read. > Signed-off-by: Martin Kepplinger <mart...@posteo.de> > Acked-by: Peter Meerwald-Stadler <pme...@pmeerw.net>

Re: [PATCH v2] iio: mma8452: replace license description with SPDX specifier

> This replaces the custom license information text with the appropriate > SPDX identifier. While the information here stays the same, it is easier > to read. > Signed-off-by: Martin Kepplinger > Acked-by: Peter Meerwald-Stadler Acked-by: Harinath Nampally On Sat, Nov 18, 2

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

Hi Martin, > But given your concerns, I would strip down this patch to only offer the > already documented "low_noise" and "low_power" modes. It wouldn't be > worth it to extend the ABI just because of this! OK then we can map 'low_noise' to high resolution mode. But I am afraid I can't test the

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

Hi Martin, > But given your concerns, I would strip down this patch to only offer the > already documented "low_noise" and "low_power" modes. It wouldn't be > worth it to extend the ABI just because of this! OK then we can map 'low_noise' to high resolution mode. But I am afraid I can't test the

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

653 chip all other chips like mma845x and > > fxls8471 have single tap detection feature. > > Tested thoroughly using iio_event_monitor application on > > imx6ul-evk board which has fxls8471. > > > > Signed-off-by: Harinath Nampally <harinath...@gmail.com>

Re: [PATCH] iio: accel: mma8452: Add single pulse/tap event detection

653 chip all other chips like mma845x and > > fxls8471 have single tap detection feature. > > Tested thoroughly using iio_event_monitor application on > > imx6ul-evk board which has fxls8471. > > > > Signed-off-by: Harinath Nampally > > --- > What tree is thi

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

Hi Martin, Thanks for publishing the patch. I will work on it, but unfortunately I can't promise anything before 11/27. Thanks, Harinath On Mon, Nov 6, 2017 at 2:19 AM, Martin Kepplinger wrote: > This adds the power_mode sysfs interface to the device as documented in >

Re: [PATCH] iio: mma8452: add power_mode sysfs configuration

Hi Martin, Thanks for publishing the patch. I will work on it, but unfortunately I can't promise anything before 11/27. Thanks, Harinath On Mon, Nov 6, 2017 at 2:19 AM, Martin Kepplinger wrote: > This adds the power_mode sysfs interface to the device as documented in > sysfs-bus-iio. > > --- >

[PATCH] iio: accel: mma8452: Add single pulse/tap event detection

iio_event_monitor application on imx6ul-evk board which has fxls8471. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 156 ++-- 1 file changed, 151 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/m

[PATCH] iio: accel: mma8452: Add single pulse/tap event detection

iio_event_monitor application on imx6ul-evk board which has fxls8471. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 156 ++-- 1 file changed, 151 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel

Re: [PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability

it for you to > make any necessary corrections and submit it after testing. > > Do we have a deal? Sure, sounds great! Thanks, Harinath On Sun, Nov 5, 2017 at 3:36 PM, Martin Kepplinger <mart...@posteo.de> wrote: > On 2017-11-05 19:00, Harinath Nampally wrote: >> Rename structs

Re: [PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability

it for you to > make any necessary corrections and submit it after testing. > > Do we have a deal? Sure, sounds great! Thanks, Harinath On Sun, Nov 5, 2017 at 3:36 PM, Martin Kepplinger wrote: > On 2017-11-05 19:00, Harinath Nampally wrote: >> Rename structs holding event configura

[PATCH v4 1/2] iio: accel: mma8452: Rename a struct for code readibility

Rename time step look up struct to generic name as the values in the look table are same for all the other events like pulse, transient etc. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- v4: Shorter subject line and better description in commit message drivers/iio/accel/m

[PATCH v4 1/2] iio: accel: mma8452: Rename a struct for code readibility

Rename time step look up struct to generic name as the values in the look table are same for all the other events like pulse, transient etc. Signed-off-by: Harinath Nampally --- v4: Shorter subject line and better description in commit message drivers/iio/accel/mma8452.c | 6 +++--- 1 file

[PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability

Rename structs holding event configuration registers to more appropriate names. This naming is consistent with the event config register names given in the mma845x and fxls8471 datasheets. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- v4: Shorter subject line and

[PATCH v4 0/2] Refactor event related code

Rename some struct names improve code readability. Harinath Nampally (2): iio: accel: mma8452: Rename a struct for code readibility iio: accel: mma8452: Rename config structs for readability drivers/iio/accel/mma8452.c | 16 1 file changed, 8 insertions(+), 8 deletions

[PATCH v4 2/2] iio: accel: mma8452: Rename config structs for readability

Rename structs holding event configuration registers to more appropriate names. This naming is consistent with the event config register names given in the mma845x and fxls8471 datasheets. Signed-off-by: Harinath Nampally --- v4: Shorter subject line and better description in commit message

[PATCH v4 0/2] Refactor event related code

Rename some struct names improve code readability. Harinath Nampally (2): iio: accel: mma8452: Rename a struct for code readibility iio: accel: mma8452: Rename config structs for readability drivers/iio/accel/mma8452.c | 16 1 file changed, 8 insertions(+), 8 deletions

Re: [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

> > On 2017-09-30 19:59, Jonathan Cameron wrote: > > > On Wed, 27 Sep 2017 08:52:54 +0200 > > > Martin Kepplinger <mart...@posteo.de> wrote: > > > > > >> Am 25.09.2017 12:40 schrieb Harinath Nampally: > > >>> Improves code r

Re: [PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

> > On 2017-09-30 19:59, Jonathan Cameron wrote: > > > On Wed, 27 Sep 2017 08:52:54 +0200 > > > Martin Kepplinger wrote: > > > > > >> Am 25.09.2017 12:40 schrieb Harinath Nampally: > > >>> Improves code readability, no impact on fun

Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Martin Kepplinger <mart...@posteo.de> wrote: > >> Am 25.09.2017 12:40 schrieb Harinath Nampally: >> > Improves code readability, no impact on functionality. >> > >> > Signed-off-by: Harinath Nampally <harinath...@gmail.com> >> >> Pl

Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

ote: > >> Am 25.09.2017 12:40 schrieb Harinath Nampally: >> > Improves code readability, no impact on functionality. >> > >> > Signed-off-by: Harinath Nampally >> >> Please make the headline shorter and put some of it in the git commit >> messag

[PATCH v3 0/3] Refactor event related code

Rename some struct names and function names to improve code readability. Harinath Nampally (3): iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names. iio: accel: mma8452: Rename time step look up struct to generic name

[PATCH v3 0/3] Refactor event related code

Rename some struct names and function names to improve code readability. Harinath Nampally (3): iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names. iio: accel: mma8452: Rename time step look up struct to generic name

[PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 6

[PATCH v3 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 6194169..3472e7e 100644

[PATCH v3 3/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma

[PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3

[PATCH v3 3/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -792,7 +792,7

[PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3472e7e..74b6221 100644 --- a/drivers

Re: [PATCH 0/3] Refactor event related code

ail right. Why not test sending it > privately > to yourself first? Sure will do, sorry for the convenience. Thanks, Harinath On Mon, Sep 25, 2017 at 6:11 AM, Martin Kepplinger <mart...@posteo.de> wrote: > Am 25.09.2017 12:07 schrieb Harinath Nampally: >> >> Rename

Re: [PATCH 0/3] Refactor event related code

ail right. Why not test sending it > privately > to yourself first? Sure will do, sorry for the convenience. Thanks, Harinath On Mon, Sep 25, 2017 at 6:11 AM, Martin Kepplinger wrote: > Am 25.09.2017 12:07 schrieb Harinath Nampally: >> >> Rename some struct names and fun

Re: [PATCH 4/4] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

Please disregard this patch set as this includes an unrelated patch '[PATCH 4/4] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.' On Mon, Sep 25, 2017 at 6:07 AM, Harinath Nampally <harinath...@gmail.com> wrote: > This patch adds following changes to su

Re: [PATCH 4/4] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

Please disregard this patch set as this includes an unrelated patch '[PATCH 4/4] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.' On Mon, Sep 25, 2017 at 6:07 AM, Harinath Nampally wrote: > This patch adds following changes to support tap feature: > - d

[PATCH 4/4] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

thoroughly using iio_event_monitor application on imx6ul-evk board. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 156 ++-- 1 file changed, 151 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma

[PATCH 4/4] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

thoroughly using iio_event_monitor application on imx6ul-evk board. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 156 ++-- 1 file changed, 151 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel

[PATCH 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3

[PATCH 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3472e7e..74b6221 100644 --- a/drivers

[PATCH 3/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma

[PATCH 3/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -792,7 +792,7

[PATCH 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 6

[PATCH 0/3] Refactor event related code

Rename some struct names and function names to improve code readability. Harinath Nampally (3): iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names. iio: accel: mma8452: Rename time step look up struct to generic name

[PATCH 1/3] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 6194169..3472e7e 100644

[PATCH 0/3] Refactor event related code

Rename some struct names and function names to improve code readability. Harinath Nampally (3): iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names. iio: accel: mma8452: Rename time step look up struct to generic name

[PATCH 2/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma

[PATCH 1/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3

[PATCH 2/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name.

-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 74b6221..43c3a6b 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -792,7 +792,7

[PATCH 1/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3472e7e..74b6221 100644 --- a/drivers

[PATCH 0/3] This patchset refactors event related functions

Harinath Nampally (3): Following 2 patches are for refactor: iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events. iio: accel: mma8452: Rename read/write event value callbacks to generic function name. Following patch

[PATCH 3/3] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

thoroughly using iio_event_monitor application on imx6ul-evk board. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 156 ++-- 1 file changed, 151 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma

[PATCH 0/3] This patchset refactors event related functions

Harinath Nampally (3): Following 2 patches are for refactor: iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events. iio: accel: mma8452: Rename read/write event value callbacks to generic function name. Following patch

[PATCH 3/3] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471.

thoroughly using iio_event_monitor application on imx6ul-evk board. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 156 ++-- 1 file changed, 151 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel

[PATCH] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 6

[PATCH] iio: accel: mma8452: Rename structs holding event configuration registers to more appropriate names.

Improves code readability, no impact on functionality. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 6194169..3472e7e 100644

[PATCH 0/2] This patchset is for fixes reported by checkpatch.pl

Please find the following patches: iio: accel: mma8452: Fix code style warning for symbolic permissions iio: accel: mma8452: Fix code style warning for unsigned int declarations drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.7.4

[PATCH 0/2] This patchset is for fixes reported by checkpatch.pl

Please find the following patches: iio: accel: mma8452: Fix code style warning for symbolic permissions iio: accel: mma8452: Fix code style warning for unsigned int declarations drivers/iio/accel/mma8452.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.7.4

[PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations

Replace 'unsigned' with 'unsigned int' to improve code readability. Issue found by checkpatch. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/d

[PATCH 1/2] iio: accel: mma8452: Fix code style warning

Replace symbolic permissions with octal permissions to improve code readability. Issue found by checkpatch. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio

[PATCH 2/2] iio: accel: mma8452: Fix code style warning for unsigned int declarations

Replace 'unsigned' with 'unsigned int' to improve code readability. Issue found by checkpatch. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c

[PATCH 1/2] iio: accel: mma8452: Fix code style warning

Replace symbolic permissions with octal permissions to improve code readability. Issue found by checkpatch. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

_accel_rising' to 'ev_trans_regs' and 'ev_regs_accel_falling' to 'ev_ff_mt_regs'. As Jon just applied this patch, I will cover this in my next patch set which fix the checkpatch.pl warnings in this file. Thanks, Hari On Sun, Sep 10, 2017 at 2:36 AM, Martin Kepplinger <mart...@posteo.de> wrote: &

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

gs' and 'ev_regs_accel_falling' to 'ev_ff_mt_regs'. As Jon just applied this patch, I will cover this in my next patch set which fix the checkpatch.pl warnings in this file. Thanks, Hari On Sun, Sep 10, 2017 at 2:36 AM, Martin Kepplinger wrote: > > On 2017-09-09 21:56, Harinath Nampally wrote

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

Sun, Sep 10, 2017 at 11:51 AM, Jonathan Cameron <ji...@kernel.org> wrote: > On Sun, 10 Sep 2017 08:36:43 +0200 > Martin Kepplinger <mart...@posteo.de> wrote: > >> On 2017-09-09 21:56, Harinath Nampally wrote: >> > This driver supports multiple devices lik

Re: [PATCH v6] iio: accel: mma8452: improvements to handle multiple events

Sun, Sep 10, 2017 at 11:51 AM, Jonathan Cameron wrote: > On Sun, 10 Sep 2017 08:36:43 +0200 > Martin Kepplinger wrote: > >> On 2017-09-09 21:56, Harinath Nampally wrote: >> > This driver supports multiple devices like mma8653, >> > mma8652,

[PATCH v6] iio: accel: mma8452: improvements to handle multiple events

channel type check in read/write event callbacks Changes since v1 -> v2 -Fix indentations -Remove unused fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally <har

[PATCH v6] iio: accel: mma8452: improvements to handle multiple events

channel type check in read/write event callbacks Changes since v1 -> v2 -Fix indentations -Remove unused fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally --- dr

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

nathan Cameron <ji...@kernel.org> wrote: > On Tue, 29 Aug 2017 23:01:16 -0400 > harinath Nampally <harinath...@gmail.com> wrote: > >> > We should never say "transient is for rising >> > direction" or "ff_mt is for falling direction". any com

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

nathan Cameron wrote: > On Tue, 29 Aug 2017 23:01:16 -0400 > harinath Nampally wrote: > >> > We should never say "transient is for rising >> > direction" or "ff_mt is for falling direction". any combination is fine. >> >> Ok I agree

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

logic in the form of pseudo-code. Thanks for your time On Tue, Aug 29, 2017 at 10:55 PM, harinath Nampally <harinath...@gmail.com> wrote: >> We should never say "transient is for rising >> direction" or "ff_mt is for falling direction". any combination is f

Re: [PATCH v5] iio: accel: mma8452: improvements to handle multiple events

logic in the form of pseudo-code. Thanks for your time On Tue, Aug 29, 2017 at 10:55 PM, harinath Nampally wrote: >> We should never say "transient is for rising >> direction" or "ff_mt is for falling direction". any combination is fine. > > Ok I agree that

[PATCH v5] iio: accel: mma8452: improvements to handle multiple events

k in read/write event callbacks Changes since v1 -> v2 -Fix indentations -Remove unused fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally <harinath...@gmail.co

[PATCH v5] iio: accel: mma8452: improvements to handle multiple events

k in read/write event callbacks Changes since v1 -> v2 -Fix indentations -Remove unused fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally --- drivers/iio/acc

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

> Am 23.08.2017 02:29 schrieb Harinath Nampally: > If rising: use transient OR ff_mt device-dependent like before. But now save > it in a simple flag, > whether transient registers are available. > Ok, is it good idea to add the flag to struct mma_chip_info like below? &g

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

> Am 23.08.2017 02:29 schrieb Harinath Nampally: > If rising: use transient OR ff_mt device-dependent like before. But now save > it in a simple flag, > whether transient registers are available. > Ok, is it good idea to add the flag to struct mma_chip_info like below? &g

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

If rising: use transient OR ff_mt device-dependent like before. But now save it in a simple flag, whether transient registers are available. Ok, is it good idea to add the flag to struct mma_chip_info like below? * @mma_scales:scale factors for converting register

Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

If rising: use transient OR ff_mt device-dependent like before. But now save it in a simple flag, whether transient registers are available. Ok, is it good idea to add the flag to struct mma_chip_info like below? * @mma_scales:scale factors for converting register

[PATCH v4] iio: accel: mma8452: improvements to handle multiple events

/write event callbacks Changes since v1 -> v2 -Fix indentations -Remove unused fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally <harinath...@gmail.com> -

[PATCH v4] iio: accel: mma8452: improvements to handle multiple events

/write event callbacks Changes since v1 -> v2 -Fix indentations -Remove unused fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma845

Re: [PATCH] iio: accel: mma8452: code improvements to handle more than one event

[PATCH V3]... (I think, I've lost track - but this needs to be in the patch title so we know which is latest. ok I will resend it with patch version and change history. This just missed my pull request for today anyway. There may be time for another pull towards the end of this week,

Re: [PATCH] iio: accel: mma8452: code improvements to handle more than one event

[PATCH V3]... (I think, I've lost track - but this needs to be in the patch title so we know which is latest. ok I will resend it with patch version and change history. This just missed my pull request for today anyway. There may be time for another pull towards the end of this week,

[PATCH] iio: accel: mma8452: code improvements to handle more than one event

without any conflicts. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 277 1 file changed, 123 insertions(+), 154 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index e

[PATCH] iio: accel: mma8452: code improvements to handle more than one event

without any conflicts. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 277 1 file changed, 123 insertions(+), 154 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index eb6e3dc..7bfc257 100644

[PATCH] iio: accel: mma8452: code improvements to handle more than one event

fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 272 +++- 1 file changed, 118 insert

[PATCH] iio: accel: mma8452: code improvements to handle more than one event

fields in mma8452_event_regs struct -Remove redundant return statement -Remove unrelated changes like checkpatch.pl warning fixes Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 272 +++- 1 file changed, 118 insertions(+), 154 deletions(-) diff

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

This patch fixes by detaching the event related information from chip_info struct, and based on channel type and event direction the corresponding event configuration registers are picked dynamically. Hence multiple events can be handled in read/write callbacks. which chip can have which

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

This patch fixes by detaching the event related information from chip_info struct, and based on channel type and event direction the corresponding event configuration registers are picked dynamically. Hence multiple events can be handled in read/write callbacks. which chip can have which

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

This patch fixes by detaching the event related information from chip_info struct, and based on channel type and event direction the corresponding event configuration registers are picked dynamically. Hence multiple events can be handled in read/write callbacks. which chip can have which

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

This patch fixes by detaching the event related information from chip_info struct, and based on channel type and event direction the corresponding event configuration registers are picked dynamically. Hence multiple events can be handled in read/write callbacks. which chip can have which

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

r this fix both Freefall and Transient events are handled by the driver without any conflicts. thanks, p. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio/accel/mma8452.c | 309 1 file changed, 141 insertions(+), 168 de

Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

r this fix both Freefall and Transient events are handled by the driver without any conflicts. thanks, p. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 309 1 file changed, 141 insertions(+), 168 deletions(-) diff --git a/d

[PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

. Changes are thoroughly tested on fxls8471 device on imx6UL Eval board using iio_event_monitor user space program. After this fix both Freefall and Transient events are handled by the driver without any conflicts. Signed-off-by: Harinath Nampally <harinath...@gmail.com> --- drivers/iio

[PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely.

. Changes are thoroughly tested on fxls8471 device on imx6UL Eval board using iio_event_monitor user space program. After this fix both Freefall and Transient events are handled by the driver without any conflicts. Signed-off-by: Harinath Nampally --- drivers/iio/accel/mma8452.c | 309

Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely.

AM, Martin Kepplinger wrote: On 2017-08-01 05:08, Harinath Nampally wrote: Thanks for doing that work. I have had it on my list for a long time and you seem to fix it. Although I'd happily review and possibly test it, unfortunately I can't do so before the week of August 21st. If this might g

Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely.

AM, Martin Kepplinger wrote: On 2017-08-01 05:08, Harinath Nampally wrote: Thanks for doing that work. I have had it on my list for a long time and you seem to fix it. Although I'd happily review and possibly test it, unfortunately I can't do so before the week of August 21st. If this might g

Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely.

On Mon, 31 Jul 2017 07:17:38 -0400 Harinath Nampally <harinath...@gmail.com> wrote: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific informati

Re: [PATCH] iio: accel: Bugfix to enbale and allow different events to work parallely.

On Mon, 31 Jul 2017 07:17:38 -0400 Harinath Nampally wrote: This driver supports multiple devices like mma8653, mma8652, mma8452, mma8453 and fxls8471. Almost all these devices have more than one event. Current driver design hardcodes the event specific information, so only one event can

  1   2   >