This is a simple wrapper around readl(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/misc
This is a simple wrapper around writel(), remove it.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/misc
These are simple wrappers around writel() and readl(). Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 30 +-
1 file changed, 9 insertions(+), 21 deletions
The mmio_base is an ioremap'ed memory resource. The normal memory
io functions should be used not the __raw_* versions.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 4 ++--
1 file chang
Use managed device resources to clean up the probe/remove.
Signed-off-by: H Hartley Sweeten
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Ryan Mallon
Cc: Matthieu Crapet
---
drivers/misc/ep93xx_pwm.c | 73 +--
1 file changed, 20 insertions(+), 53
This driver needs to be converted to the new PWM framework.
Before converting it clean up all the cruft,
H Hartley Sweeten (14):
misc/ep93xx_pwm: use managed device resources
misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io
misc/ep93xx_pwm: remove ep93xx_pwm_{write
spi->min_rate)
> return -EINVAL;
> }
> @@ -1046,6 +1036,7 @@ static int ep93xx_spi_probe(struct platform_device
> *pdev)
> master->bus_num = pdev->id;
> master->num_chipselect = info->num_chipselect;
> master
On Monday, May 20, 2013 7:51 AM, Lars-Peter Clausen wrote:
> free_irq() expects the same pointer that was passed to request_irq(),
> otherwise
> the IRQ is not freed.
> Cc: H Hartley Sweeten
> Signed-off-by: Lars-Peter Clausen
> ---
> drivers/input/keyboard/ep93xx_k
ot needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han
> ---
> drivers/misc/ep93xx_pwm.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-
On Thursday, May 09, 2013 2:05 PM, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "dma_free_coherent" [drivers/staging/comedi/comedi.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/staging/comedi/comedi.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven
> Cc: Ian Abbott
> Cc: Greg Kr
On Wednesday, April 24, 2013 12:56 AM, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/staging/comedi/drivers/ni_labpc.c: In function 'labpc_ai_cmd':
> drivers/staging/comedi/drivers/ni_labpc.c:980:9: error: imp
On Wednesday, April 24, 2013 12:56 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
Ugh.. powerpc probably has CONFIG_ISA_DMA_API but not
CONFIG_VIRT_TO_BUS.
I'm looking for a fix now.
Regards,
Hartley
--
ion that does not rely on delaying the work.
>
> Signed-off-by: Arnd Bergmann
> Cc: H Hartley Sweeten
> Cc: Ian Abbott
> Cc: Greg Kroah-Hartman
Reviewed-by: H Hartley Sweeten
Thanks,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
This driver now uses the module_pcmcia_driver() macro to supply the
init/exit code. The nsp_cs_{init,exit} prototypes should be removed.
Reported-by: kbuild test robot
Signed-off-by: H Hartley Sweeten
Cc: YOKOTA Hiroshi
Cc: "James E.J. Bottomley"
Cc: Greg Kroah-Hartman
C
On Wednesday, March 20, 2013 9:04 AM, Joe Perches wrote:
> On Wed, 2013-03-20 at 15:29 +, Al Viro wrote:
>> On Wed, Mar 20, 2013 at 03:47:53PM +0300, Dan Carpenter wrote:
>>
>>> The original code here needs to broken up into functions so it isn't
>>> squashed up against the 80 character limit.
On Friday, March 15, 2013 7:20 PM, Ryan Mallon wrote:
> On 16/03/13 12:03, H Hartley Sweeten wrote:
>
>> Remove the __init tag from ep93xxbl_probe() to fix the section
>> mismatch warning.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ryan Mallon
>>
Remove the __init tags from the ep93xxfb_calc_fbsize() and
ep93xxfb_alloc_videomem() functions to fix the section mismatch
warnings.
Use module_platform_driver() to remove the init/exit boilerplate.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Florian Tobias Schandinat
---
drivers
Fix a couple section mismatch warnings and convert two of the ep93xx
drivers to use module_platform_driver.
H Hartley Sweeten (3):
backlight: ep93xx_bl: fix section mismatch
video: ep93xx-fb.c: fix section mismatch and use module_platform_driver
misc: ep93xx_pwm.c: fix section mismatch and
Remove the __init tags from the ep93xx_pwm_probe() and
ep93xx_pwm_remove() functions to fix the section mismatch
warnings.
Use module_platform_driver() to remove the init/exit boilerplate.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
---
drivers
Remove the __init tag from ep93xxbl_probe() to fix the section
mismatch warning.
Signed-off-by: H Hartley Sweeten
Cc: Ryan Mallon
Cc: Richard Purdie
Cc: Florian Tobias Schandinat
---
drivers/video/backlight/ep93xx_bl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
533: warning: assignment makes pointer from integer
without a cast
Include to pickup the declaration of 'devm_ioremap'.
Signed-off-by: H Hartley Sweeten
Cc:
Cc: Florian Tobias Schandinat
Cc: Ryan Mallon
Cc: Damien Cassou
---
drivers/video/ep93xx-fb.c | 1 +
1 file changed, 1 inserti
On Thursday, March 14, 2013 6:58 AM, Arnd Bergmann wrote:
> On Thursday 14 March 2013, Fabio Porcedda wrote:
>> This patch converts the drivers to use the
>> module_platform_driver_probe() macro which makes the code smaller and
>> a bit simpler.
>>
>> Signed-off-by: Fabio Porcedda
>> Cc: Greg Kro
On Friday, March 15, 2013 2:41 AM, Ian Abbott wrote:
> On 2013-03-15 08:14, Kumar Amit Mehta wrote:
>> fix a missing end-of-statement by adding a semicolon.
>>
>> Signed-off-by: Kumar Amit Mehta
>> ---
>> drivers/staging/comedi/drivers/ni_atmio.c |2 +-
>> 1 file changed, 1 insertion(+), 1
On Thursday, March 14, 2013 12:33 PM, Geert Uytterhoeven wrote:
> On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman
> wrote:
>> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>>> m68k/allmodconfig:
>>>
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function
>>> ‘ni_isa
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
---
drivers/usb/host/sl811_cs.c | 15 +--
1 file changed, 1 insertion(+), 14
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-ser...@vger.kernel.org
---
drivers/tty/serial/8250/serial_cs.c | 14 +-
1 file changed
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/mmc/host/sdricoh_cs.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/mmc/host
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Add a comment in drivers/net/wireless/b43/pcmcia.c about why that
driver does not use the new macro.
Signed-off-by: H Hartley Sweeten
---
drivers/net/arcnet/com20020_cs.c
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--
sound/pcmcia/vx/vxpocket.c | 14 +-
2 files changed, 2 insertions
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
Cc: "Juergen E. Fischer"
Cc: "James E.J. Bottomley"
Cc: YOKOTA Hiroshi
Cc: linux-s...@vger.kernel.org
---
drivers/scsi/pcmcia
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/parport/parport_cs.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/parport/parport_cs.c b
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/isdn/hardware/avm/avm_cs.c | 14 +-
drivers/isdn/hisax/avma1_cs.c | 14 +-
drivers/isdn/hisax/elsa_cs.c
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/ata/pata_pcmcia.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/ata/pata_pcmcia.c b/drivers
Use the new module_pcmcia_driver() macro to remove the boilerplate
module init/exit code in the pcmcia drivers.
Signed-off-by: H Hartley Sweeten
---
drivers/bluetooth/bluecard_cs.c | 15 +--
drivers/bluetooth/bt3c_cs.c | 15 +--
drivers/bluetooth/btuart_cs.c | 15
Introduce a new helper macro to remove the module boilerplate code
in pcmcia drivers.
Use the new macro throughout the tree where possible.
H Hartley Sweeten (11):
pcmcia/ds.h: introduce helper for pcmcia_driver module boilerplate
drivers/ata: use module_pcmcia_driver() in pcmcia drivers
Introduce the module_pcmcia_driver() macro which is a convenience macro
for pcmcia driver modules. It is intended to be used by pcmcia drivers
with init/exit sections that do nothing but register/unregister the
pcmcia driver.
Signed-off-by: H Hartley Sweeten
---
include/pcmcia/ds.h | 12
On Monday, February 04, 2013 5:59 AM, Dan Carpenter wrote:
> On Sun, Feb 03, 2013 at 10:54:37PM +0100, Peter Huewe wrote:
>> Since data can only be 0x, 0x0035 or 0x0048 we can simply skip the
>> bit shifting and masking as data & 0xFF is always equal to data and
>> data & 0xFF00 is always 0.
>>
On Wednesday, January 30, 2013 4:04 AM, Ian Abbott wrote:
> One way is to enumerate the possible indices of the custom board array
> as a set of enum constants, initialize the custom board array using
> designated element initializers (indexed by the enum constants) and
> include the same enum c
27;s patch to enable comedi for
all architectures... :-)
Reviewed-by: H Hartley Sweeten
On Tuesday, January 29, 2013 4:42 PM, Peter Hüwe wrote:
> Hi,
>
> while analyzing the comedi drivers, I noticed that quite a lot of them use a
> more or less similar find_boardinfo function.
> The names and the exact implementation differ slightly, but in most cases it
> boils down to:
>
On Tuesday, January 22, 2013 3:40 PM, Peter Huewe wrote:
> (Almost) all comedi pci drivers have some wrapper for their
> pci_driver.remove function which simply calls comedi_pci_auto_unconfig
> which has the same function prototype as the wrapper.
>
> -> we can remove these wrappers and call comed
On Monday, January 21, 2013 2:25 PM, Peter Hüwe wrote:
>
> It's okay to drop my patches so you don't have to rebase.
>
> (I posted a version with the missing comma nevertheless)
Peter,
Your updated versions are ok. I'm about done with the rebase anyway.
Please make sure to at least compile test
On Monday, January 21, 2013 1:52 PM, Peter Huewe wrote:
> This patch adds the comedi_driver.name to pci_driver.name
> to the skel driver, so we can remove the workaround in drivers.c
>
> Signed-off-by: Peter Huewe
> ---
> drivers/staging/comedi/drivers/skel.c |1 +
> 1 files changed, 1 insert
ust about to post a rebase of the last part of my drivers.c
cleanup that included this and your 2/2 patch.
Oh well... Rebase again...
FWIW, for both patches.
Reviewed-by: H Hartley Sweeten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
On Saturday, January 12, 2013 7:11 PM, Peter Huewe wrote:
> This patch introduces a new macro 'module_comedi_pcmcia_driver'
> for comedi PCMCIA drivers which do not do anything special in module
> init/exit. This eliminates a lot of boilerplate.
>
> Adapted from 'module_comedi_pci_driver'
>
> Signe
On Monday, January 07, 2013 9:30 PM, Stephen Rothwell wrote:
> On Mon, 7 Jan 2013 20:27:30 -0800 Greg KH wrote:
>> On Tue, Jan 08, 2013 at 01:23:52PM +1100, Stephen Rothwell wrote:
>>> After merging the staging tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> dri
On Monday, January 07, 2013 3:40 PM, Greg KH wrote:
> On Sat, Jan 05, 2013 at 06:12:55PM +0400, Lijo Antony wrote:
>> Reduced line lengths to 80 chars by removing extra spaces.
>>
>> Signed-off-by: Lijo Antony
>> ---
>> .../staging/comedi/drivers/addi-data/addi_common.h | 20
>> ++
: H Hartley Sweeten
Cc: Jiri Kosina
---
drivers/hid/hid-a4tech.c | 13 +
drivers/hid/hid-apple.c| 19 +--
drivers/hid/hid-aureal.c | 13 +
drivers/hid/hid-axff.c | 14 +-
drivers/hid/hid-belkin.c | 13
These functions are not defined. Remove the extern declarations.
Signed-off-by: H Hartley Sweeten
Cc: Jiri Kosina
---
include/linux/hid.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/hid.h b/include/linux/hid.h
index d6c71a6..828726c 100644
--- a/include/linux/hid.h
Introduce the module_hid_driver macro which is a convenience macro
for HID driver modules similar to module_usb_driver. It is intended
to be used by drivers with init/exit sections that do nothing but
register/unregister the HID driver.
Signed-off-by: H Hartley Sweeten
Cc: Jiri Kosina
Introduce, and use, the helper macro module_hid_driver to allow removing
the init/exit boilerplate code from the HID drivers.
H Hartley Sweeten (3):
HID: introduce helper for hid_driver boilerplate
HID: hid.h: remove unused hid_generic_{init,exit} prototypes
HID: Use module_hid_driver macro
Hello all,
Another build failure with next-20121126:
CC security/integrity/evm/evm_secfs.o
In function 'copy_from_user',
inlined from 'evm_write_key' at security/integrity/evm/evm_secfs.c:71:
/home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:
error: call to 'co
Hello all,
I was just trying a allyesconfig build of next-20121126 and got this:
CC fs/cifs/cifs_debug.o
In function 'copy_from_user',
inlined from 'cifs_security_flags_proc_write' at fs/cifs/cifs_debug.c:593:
/home/bigguiness/src/git/linux-next/arch/x86/include/asm/uaccess_32.h:211:
On Thursday, November 15, 2012 9:28 AM, Arpith Easow Alexander wrote:
> On Tue, Nov 13, 2012 at 11:52:52AM -0800, Greg KH wrote:
>> So a macro called dbgcm tests a variable called dbgcm? Gotta love c at
>> times...
>>
>> Just delete the macro, and the variable, and call dev_dbg() directly
>> plea
On Monday, November 12, 2012 11:41 AM, Bjorn Helgaas wrote:
> On Mon, Nov 12, 2012 at 9:18 AM, H Hartley Sweeten wrote:
>> Does anyone know what the Kconfig option VIRT_TO_BUS does?
>> There are a number of "depends on" that option but it does not
>> seem to directl
Hello all,
Does anyone know what the Kconfig option VIRT_TO_BUS does?
There are a number of "depends on" that option but it does not
seem to directly enable any code in the kernel.
Thanks for any reply.
Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
On Wednesday, September 26, 2012 1:05 PM, Greg Kroah-Hartman wrote:
> On Wed, Sep 26, 2012 at 01:47:11PM -0500, H Hartley Sweeten wrote:
>> On Wednesday, September 26, 2012 10:57 AM, Greg Kroah-Hartman wrote:
>>> On Wed, Sep 26, 2012 at 10:56:06AM -0700, Greg Kroah-Hartman wrot
On Wednesday, September 26, 2012 10:57 AM, Greg Kroah-Hartman wrote:
> On Wed, Sep 26, 2012 at 10:56:06AM -0700, Greg Kroah-Hartman wrote:
>>
>> With 3.6 about to be released, I've now closed the 3.7 staging-next tree
>> for new features / cleanups. It's bug-fixes only now until 3.7-rc1 is
>> out
t;
> Signed-off-by: Arnd Bergmann
> Cc: Grant Likely
> Cc: Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Jeff Garzik (supporter:SERIAL ATA
> Cc: Vinod Koul
> Cc: Dan Williams
> Cc: Dmitry Torokhov (maintainer:INPUT
> Cc: Florian Tobias Schandinat
> Cc: Liam Girdwoo
Nothing in the comedi subsystem references this header file. It's
actually almost a straight copy of the addi_amcc_s5933.h file anyway.
Just remove the file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/amcc_s5933_58.h
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/addi_amcc_S5920.c | 195 -
.../comedi/drivers/addi-data/addi_amcc_S5920.h | 27 ---
.../comedi/drivers/addi-data/hwdrv_apci3200.c | 12 +-
3 files
The Makefile for the comedi subsystem does not compile this file
for any .config selection. This file would allow building one big
driver to support all the addi-data cards.
The addi-data drivers are a big enough mess as-is. Just remove this
file.
Signed-off-by: H Hartley Sweeten
Cc: Iam Abbott
Remove a couple of the addi-data files that are either not built under any
configuration or are unnecessary due to code duplication in another file.
H Hartley Sweeten (3):
staging: comedi: addi_apci_all.c: remove unused file
staging: comedi: amcc_s5933_58.h: remove unused file
staging
On Tuesday, September 04, 2012 11:34 AM, Greg KH wrote:
> On Mon, Aug 20, 2012 at 04:59:16PM -0700, H Hartley Sweeten wrote:
>> Convert all the comedi_subdevice pointer access from pointer
>> math to array access.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc:
The subdevice pointer math removal patch introduced a build error
in the s626 driver. Fix it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
Not sure how this got thru. The build error did not appear until
I did a clean make.
drivers/staging/comedi/drivers/s626.c
e_singlethread_workqueue("ep93xx_spid");
> if (!espi->wq) {
> dev_err(&pdev->dev, "unable to create workqueue\n");
> + error = -ENOMEM;
> goto fail_free_dma;
> }
> INIT_WORK(&espi->msg_work,
On Monday, August 20, 2012 2:51 PM, H Hartley Sweeten wrote:
> On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote:
>> On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
>>> + if (this_board->n_diochan) {
>>> + s = dev->subdevices
Convert the 'attach' message from a printk to a dev_info.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_test.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/come
the driver simple.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_test.c | 31 +---
1 file changed, 5 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_test.c
b/drivers/stag
This macro relies on a local variable having a specific name. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_test.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers
H Hartley Sweeten (3):
staging: comedi: comedi_test: remove devpriv macro
staging: comedi: comedi_test: remove boardinfo
staging: comedi: comedi_test: convert attach message to dev_info
drivers/staging/comedi/drivers/comedi_test.c | 61
1 file changed, 27
On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote:
> On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
>> +if (this_board->n_diochan) {
>> +s = dev->subdevices + subdev;
>
> This pointer math sucks still... I feel like the unread
Remove the function trace message in parport_intr_cancel() and the
"bogus irq..." message is parport_interrupt(). They are just added
noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 6 +-
1 file
Convert the printk messages in the 'attach' to dev_printk messages.
Consolidate the attach message into one message after the device
is attached.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 12 +
Use the 'dev->driver->driver_name' for the 'dev->board_name'. And use
the 'dev->board_name' for the resource name passed to request_region
and request_irq.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/come
This macro relies on a local variable having a specific name, Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers
H Hartley Sweeten (4):
staging: comedi: comedi_parport: remove devpriv macro
staging: comedi: comedi_parport: cleanup dev->board_name
staging: comedi: comedi_parport: cleanup 'attach' printk's
staging: comedi: comedi_parport: remove the printk noise
drivers/stag
This macro is only used in the MODULE_DESCRIPTION. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_bond.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers
This macro is not used in the file. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_bond.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_bond.c
b/drivers/staging/comedi
Remove the macros LOG_MSG, DEBUG, WARNING, and ERROR. Convert
the printk's into dev_printk format.
The DEBUG macro is not being used in the file so the module
parameter 'debug' can also be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
This macro relies on a local variable having a specific name.
Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_bond.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a
o name and driver name are identical we can simplify
this driver a bit bu just removing the boardinfo completely.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_bond.c | 27 ---
1 file changed, 27 deletion
H Hartley Sweeten (5):
staging: comedi: comedi_bond: remove boardinfo
staging: comedi: comedi_bond: remove devpriv macro
staging: comedi: comedi_bond: remove private printk macros
staging: comedi: comedi_bond: remove the STR macro
staging: comedi: comedi_bond: remove MODULE_NAME macro
This board has jumpers to set the board base address. These
jumpers are marked A5 through A9 and A5 is the least significant
bit of the address. This makes the address reqion for the board
32 bytes not 24.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
Fully document the register map and add namespace to all the
defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 129 ---
1 file changed, 75 insertions(+), 54 deletions(-)
diff --git a
but stub in the subdevice
information so it can easily be added.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 90 +++-
1 file changed, 61 insertions(+), 29 deletions(-)
diff --git a/drivers
This macro relies on a local variable having a specific name. Remove
it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
H Hartley Sweeten (4):
staging: comedi: aio_aio12_8: remove devpriv macro
staging: comedi: aio_aio12_8: add ai and ao only card versions
staging: comedi: aio_aio12_8: document the register map
staging: comedi: aio_aio12_8: fix i/o region size
drivers/staging/comedi/drivers/aio_aio12_8.c
The 'attach' function can fail between when the devpriv and
the comedi subdevices are allocated. If it does the 'detach'
will try to access unallocated memory when it goes thru the
subdevices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
dr
in that the s->type is
COMEDI_SUBD_DIO. Use that to know when to call the cleanup
for the 8255 subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 27 +++
1 file changed, 3 insertions(
Instead of calculating the number of subdevices in the 'attach'
simply add the number to the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 39 +---
1 file changed, 18
Remove all the boardinfo data that is simply '0'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 84
1 file changed, 84 deletions(-)
diff --git a/drivers/staging/come
Convert the boardinfo initialization to C99 format to make it
less error prone.
The struct diosubd_data information is not converted to C99 format
yet because some of it will be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function. Since the
driver does not require any external configuration options, and
the legacy 'attach' callback is now optional, remove it.
Signed-off-by: H Hart
These macros rely on a local variable having a specific name. Remove
them and use the comedi_board() helper to get the this_board pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 33
Remove the DPRINTK function trace messages and associated
PCI_DIO_EXTDEBUG define. These should not be in the final driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 13 -
1 file changed, 13 deletions
301 - 400 of 716 matches
Mail list logo
