[PATCH 8/9] x86: Unify argument names in signal_32|64.c

2008-02-08 Thread Harvey Harrison
prax/peax becomes pax. Change from int to unsigned long in X86_32. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/signal_32.c |9 - arch/x86/kernel/signal_64.c |4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/signal_32

[PATCH 3/9] x86: regparm(3) is mandatory, no need to annotate

2008-02-08 Thread Harvey Harrison
Functions in ptrace.c and signal_32.c were defined with __attribute(regparm(3)) which is unnecessary now that X86_32 must compile this way. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/ptrace.c|1 - arch/x86/kernel/signal_32.c |1 - 2 files changed, 0

[PATCH 1/9] x86: change most X86_32 pt_regs members to unsigned long

2008-02-08 Thread Harvey Harrison
All but ax and orig_ax can move with no changes. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/process_32.c |5 ++--- arch/x86/kernel/signal_32.c |4 ++-- include/asm-x86/ptrace.h | 28 ++-- 3 files changed, 18 insertions(+), 19

Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc

2008-02-08 Thread Harvey Harrison
On Fri, 2008-02-08 at 12:06 -0600, Paul Jackson wrote: Linus wrote: Please, when mentioning hex numbers, also do the one-liner shortlog. ... without _requiring_ people to be git users to get the gist of the matter, ok? Thanks for sticking up for us git-challenged contributors.

[PATCH 2/9] x86: make X86_32 pt_regs members unsigned long

2008-02-08 Thread Harvey Harrison
Similar to X86_64, move the 32 bit pt_regs to be unsigned long. Adopt the X86_64-style of casting orig_ax to long in the signal.c if statements when checking for =0. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/signal_32.c |4 ++-- include/asm-x86/ptrace.h|9

Re: [PATCH] fix sparse warning from include/linux/mmzone.h

2008-02-08 Thread Harvey Harrison
include/linux/mmzone.h:640:22: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Linus, something like the following? include/linux/mmzone.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/linux

[PATCH 2/2] x86: regparm(3) is mandatory, no need to annotate

2008-02-07 Thread Harvey Harrison
Functions in ptrace.c and signal_32.c were defined with __attribute(regparm(3)) which is unnecessary now that X86_32 must compile this way. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/ptrace.c|1 - arch/x86/kernel/signal_32.c |1 - 2 files chan

[PATCH 1/2] x86: make X86_32 pt_regs members unsigned long

2008-02-07 Thread Harvey Harrison
Similar to X86_64, move the 32 bit pt_regs to be unsigned long. Adopt the X86_64-style of casting orig_ax to long in the signal.c if statements when checking for >=0. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/signal_32.c |4 ++-- include/asm-x86

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread Harvey Harrison
On Thu, 2008-02-07 at 19:07 -0600, James Bottomley wrote: > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: > > On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: > > > Quite a bit of this is fixing things broken previously (the advansys fix > > >

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread Harvey Harrison
On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: > Quite a bit of this is fixing things broken previously (the advansys fix > is still pending resolution, but I'll send it as an -rc fix when we have > it). There's the final elimination of all drivers that are esp based > but don't use

[PATCH] fix sparse warning from include/linux/mmzone.h

2008-02-07 Thread Harvey Harrison
dat->node_zones)/sizeof(struct zone) Which can be expensive if struct zone is not a power of two. Instead, just calculate the offsets rather than the index in the array. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- This shows up > 30 times in an x86 allyesconfig, would be

Re: [PATCH 2/8] Add interface for queuing work on a specific CPU

2008-02-07 Thread Harvey Harrison
On Thu, 2008-02-07 at 10:49 +0100, Jens Axboe wrote: > On Thu, Feb 07 2008, Andrew Morton wrote: > > On Thu, 7 Feb 2008 10:18:59 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> > > > --- > > > include/linux/workqueue.h |1 + > > >

Re: [PATCH 2/8] Add interface for queuing work on a specific CPU

2008-02-07 Thread Harvey Harrison
On Thu, 2008-02-07 at 10:49 +0100, Jens Axboe wrote: On Thu, Feb 07 2008, Andrew Morton wrote: On Thu, 7 Feb 2008 10:18:59 +0100 Jens Axboe [EMAIL PROTECTED] wrote: Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- include/linux/workqueue.h |1 + kernel/workqueue.c|

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread Harvey Harrison
On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: Quite a bit of this is fixing things broken previously (the advansys fix is still pending resolution, but I'll send it as an -rc fix when we have it). There's the final elimination of all drivers that are esp based but don't use the

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-07 Thread Harvey Harrison
On Thu, 2008-02-07 at 19:07 -0600, James Bottomley wrote: On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: Quite a bit of this is fixing things broken previously (the advansys fix is still pending resolution, but I'll

[PATCH 1/2] x86: make X86_32 pt_regs members unsigned long

2008-02-07 Thread Harvey Harrison
Similar to X86_64, move the 32 bit pt_regs to be unsigned long. Adopt the X86_64-style of casting orig_ax to long in the signal.c if statements when checking for =0. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/signal_32.c |4 ++-- include/asm-x86/ptrace.h|9

[PATCH 2/2] x86: regparm(3) is mandatory, no need to annotate

2008-02-07 Thread Harvey Harrison
Functions in ptrace.c and signal_32.c were defined with __attribute(regparm(3)) which is unnecessary now that X86_32 must compile this way. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/ptrace.c|1 - arch/x86/kernel/signal_32.c |1 - 2 files changed, 0

Re: [PATCH 1/3] x86: sparse warning in cpufreq/powernow-k8.c

2008-02-06 Thread Harvey Harrison
On Wed, 2008-02-06 at 23:35 -0500, Dave Jones wrote: > On Wed, Feb 06, 2008 at 04:07:47PM -0800, Harvey Harrison wrote: > > Nested per_cpu accessors will shadow the internal __ptr variable. Use > > a temporary first_core variable. > > > > arch/x86/kernel/cpu/c

[PATCH 2/3] x86: sparse warning in efi.c

2008-02-06 Thread Harvey Harrison
arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared. Should it be static? Yes, it should. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/efi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/efi.c b/ar

[PATCH 3/3] x86: sparse error in efi_32.c

2008-02-06 Thread Harvey Harrison
/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/efi_32.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/efi_32.c b/arch/x86/

[PATCH 1/3] x86: sparse warning in cpufreq/powernow-k8.c

2008-02-06 Thread Harvey Harrison
-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c index 5affe91..e64eee0 100644 --- a/arch/x86/kern

Re: feature-removal-schedule.txt is getting out of date again

2008-02-06 Thread Harvey Harrison
On Wed, 2008-02-06 at 20:54 +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > On Wednesday 06 February 2008, Robert P. J. Day wrote: > > > > yes, i realize i'm sounding like a broken record but, once again, > > Documentation/feature-removal-schedule.txt is slipping out of date WRT > > items

Re: feature-removal-schedule.txt is getting out of date again

2008-02-06 Thread Harvey Harrison
On Wed, 2008-02-06 at 20:54 +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > On Wednesday 06 February 2008, Robert P. J. Day wrote: > > > > yes, i realize i'm sounding like a broken record but, once again, > > Documentation/feature-removal-schedule.txt is slipping out of date WRT > > items

Re: feature-removal-schedule.txt is getting out of date again

2008-02-06 Thread Harvey Harrison
On Wed, 2008-02-06 at 20:54 +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 06 February 2008, Robert P. J. Day wrote: yes, i realize i'm sounding like a broken record but, once again, Documentation/feature-removal-schedule.txt is slipping out of date WRT items that are now

[PATCH 1/3] x86: sparse warning in cpufreq/powernow-k8.c

2008-02-06 Thread Harvey Harrison
-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c index 5affe91..e64eee0 100644 --- a/arch/x86/kernel/cpu

[PATCH 2/3] x86: sparse warning in efi.c

2008-02-06 Thread Harvey Harrison
arch/x86/kernel/efi.c:57:12: warning: symbol 'efi_phys' was not declared. Should it be static? Yes, it should. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/efi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/efi.c b/arch/x86

[PATCH 3/3] x86: sparse error in efi_32.c

2008-02-06 Thread Harvey Harrison
/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/efi_32.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/efi_32.c b/arch/x86/kernel

Re: [PATCH 1/3] x86: sparse warning in cpufreq/powernow-k8.c

2008-02-06 Thread Harvey Harrison
On Wed, 2008-02-06 at 23:35 -0500, Dave Jones wrote: On Wed, Feb 06, 2008 at 04:07:47PM -0800, Harvey Harrison wrote: Nested per_cpu accessors will shadow the internal __ptr variable. Use a temporary first_core variable. arch/x86/kernel/cpu/cpufreq/powernow-k8.c:1239:9: warning

[PATCH 7/8] x86: fix sparse warning in topology.c

2008-02-05 Thread Harvey Harrison
arch/x86/kernel/topology.c:56:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/topology.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c

[PATCH 8/8] x86: fix sparse warnings in acpi/bus.c

2008-02-05 Thread Harvey Harrison
? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/acpi/bus.c |7 +-- include/asm-x86/acpi.h |4 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 1b4cf98..9bbde6d 100644 --- a/drivers/acpi/bus.c

[PATCH 6/8] x86: sparse warnings in pageattr.c

2008-02-05 Thread Harvey Harrison
Adjust the definition of lookup_address to take an unsigned long level argument. Adjust callers in xen/mmu.c that pass in a dummy variable. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/mm/pageattr.c|8 +--- arch/x86/xen/mmu.c|6 +++--- include/a

[PATCH 5/8] x86: sparse warning in therm_throt.c

2008-02-05 Thread Harvey Harrison
arch/x86/kernel/cpu/mcheck/therm_throt.c:121:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/therm_throt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/cpu/

[PATCH 4/8] x86: trivial sparse/checkpatch in quirks.c

2008-02-05 Thread Harvey Harrison
/quirks.c:393:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/quirks.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c

[PATCH 2/8] x86: fix sparse warnings in powernow-k8.c

2008-02-05 Thread Harvey Harrison
: symbol 'lo' shadows an earlier one arch/x86/kernel/cpu/cpufreq/powernow-k8.c:824:14: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/

[PATCH 3/8] x86: dubious one-bit signed bitfield in cpuidle.h

2008-02-05 Thread Harvey Harrison
-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison

[PATCH 1/8] x86: fix sparse error in traps_32.c

2008-02-05 Thread Harvey Harrison
arch/x86/kernel/traps_32.c:1193:31: error: dubious one-bit signed bitfield This was being used to ensure the proper alignment of the FXSAVE/FXRSTOR data. This would create a sparse error in the _correct_ cases, hiding further warnings. Use BUILD_BUG_ON instead. Signed-off-by: Harvey Harrison

[PATCH 1/8] x86: fix sparse error in traps_32.c

2008-02-05 Thread Harvey Harrison
arch/x86/kernel/traps_32.c:1193:31: error: dubious one-bit signed bitfield This was being used to ensure the proper alignment of the FXSAVE/FXRSTOR data. This would create a sparse error in the _correct_ cases, hiding further warnings. Use BUILD_BUG_ON instead. Signed-off-by: Harvey Harrison

[PATCH 2/8] x86: fix sparse warnings in powernow-k8.c

2008-02-05 Thread Harvey Harrison
: symbol 'lo' shadows an earlier one arch/x86/kernel/cpu/cpufreq/powernow-k8.c:824:14: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel

[PATCH 3/8] x86: dubious one-bit signed bitfield in cpuidle.h

2008-02-05 Thread Harvey Harrison
-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison

[PATCH 4/8] x86: trivial sparse/checkpatch in quirks.c

2008-02-05 Thread Harvey Harrison
/quirks.c:393:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/quirks.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c index 3cd7a2d

[PATCH 5/8] x86: sparse warning in therm_throt.c

2008-02-05 Thread Harvey Harrison
arch/x86/kernel/cpu/mcheck/therm_throt.c:121:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/cpu/mcheck/therm_throt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck

[PATCH 6/8] x86: sparse warnings in pageattr.c

2008-02-05 Thread Harvey Harrison
Adjust the definition of lookup_address to take an unsigned long level argument. Adjust callers in xen/mmu.c that pass in a dummy variable. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/mm/pageattr.c|8 +--- arch/x86/xen/mmu.c|6 +++--- include/asm-x86

[PATCH 7/8] x86: fix sparse warning in topology.c

2008-02-05 Thread Harvey Harrison
arch/x86/kernel/topology.c:56:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/topology.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/topology.c b/arch/x86/kernel/topology.c index

[PATCH 8/8] x86: fix sparse warnings in acpi/bus.c

2008-02-05 Thread Harvey Harrison
? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- drivers/acpi/bus.c |7 +-- include/asm-x86/acpi.h |4 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 1b4cf98..9bbde6d 100644 --- a/drivers/acpi/bus.c +++ b

[PATCH] x86: dubious one-bit signed bitfield in cpuidle.h

2008-02-04 Thread Harvey Harrison
-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison

[PATCH] x86: fix sparse warnings in powernow-k8.c

2008-02-04 Thread Harvey Harrison
: symbol 'lo' shadows an earlier one arch/x86/kernel/cpu/cpufreq/powernow-k8.c:824:14: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/

[PATCH] x86: fix sparse error in traps_32.c

2008-02-04 Thread Harvey Harrison
arch/x86/kernel/traps_32.c:1193:31: error: dubious one-bit signed bitfield This was being used to ensure the proper alignment of the FXSAVE/FXRSTOR data. This would create a sparse error in the _correct_ cases, hiding further warnings. Use BUILD_BUG_ON instead. Signed-off-by: Harvey Harrison

[PATCH 1/2] kvm: move address_mask define to static function

2008-02-04 Thread Harvey Harrison
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 7958600..649e14d 100644 --- a/arch/x86/kvm/x86_emu

[PATCH 2/2] kvm: replace more defines with functions

2008-02-04 Thread Harvey Harrison
register_address register_address_increment jmp_rel Have a struct decode_cache parameter added instead of having 'c' in the macro. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 92 ++-- 1 files chang

[PATCH 1/2] kvm: move address_mask define to static function

2008-02-04 Thread Harvey Harrison
Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kvm/x86_emulate.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 7958600..649e14d 100644 --- a/arch/x86/kvm/x86_emulate.c

[PATCH 2/2] kvm: replace more defines with functions

2008-02-04 Thread Harvey Harrison
register_address register_address_increment jmp_rel Have a struct decode_cache parameter added instead of having 'c' in the macro. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kvm/x86_emulate.c | 92 ++-- 1 files changed, 46 insertions

[PATCH] x86: dubious one-bit signed bitfield in cpuidle.h

2008-02-04 Thread Harvey Harrison
-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/longhaul.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield CHECK arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c include/linux/cpuidle.h:82:17: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison

[PATCH] x86: fix sparse error in traps_32.c

2008-02-04 Thread Harvey Harrison
arch/x86/kernel/traps_32.c:1193:31: error: dubious one-bit signed bitfield This was being used to ensure the proper alignment of the FXSAVE/FXRSTOR data. This would create a sparse error in the _correct_ cases, hiding further warnings. Use BUILD_BUG_ON instead. Signed-off-by: Harvey Harrison

[PATCH] x86: fix sparse warnings in powernow-k8.c

2008-02-04 Thread Harvey Harrison
: symbol 'lo' shadows an earlier one arch/x86/kernel/cpu/cpufreq/powernow-k8.c:824:14: originally declared here Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel

[PATCH] x86: trivial sparse/checkpatch in quirks.c

2008-02-03 Thread Harvey Harrison
/quirks.c:393:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- The remaining checkpatch errors are false positives. arch/x86/kernel/quirks.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ar

[PATCH] x86: sparse fixes for kvm/x86.c

2008-02-03 Thread Harvey Harrison
ops' was not declared. Should it be static? Drop the return statements: arch/x86/kvm/x86.c:2764:2: warning: returning void-valued expression arch/x86/kvm/x86.c:2830:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86

[PATCH] x86: sparse warnings in pageattr.c

2008-02-03 Thread Harvey Harrison
Adjust the definition of lookup_address to take an unsigned long level argument. Adjust callers in xen/mmu.c that pass in a dummy variable. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, sorry for missing this hunk in my previous signedness fixes for lookup_address. arch/

[PATCH] x86: sparse warnings in pageattr.c

2008-02-03 Thread Harvey Harrison
Adjust the definition of lookup_address to take an unsigned long level argument. Adjust callers in xen/mmu.c that pass in a dummy variable. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Ingo, sorry for missing this hunk in my previous signedness fixes for lookup_address. arch/x86/mm

[PATCH] x86: sparse fixes for kvm/x86.c

2008-02-03 Thread Harvey Harrison
' was not declared. Should it be static? Drop the return statements: arch/x86/kvm/x86.c:2764:2: warning: returning void-valued expression arch/x86/kvm/x86.c:2830:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kvm/x86.c | 36

[PATCH] x86: trivial sparse/checkpatch in quirks.c

2008-02-03 Thread Harvey Harrison
/quirks.c:393:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- The remaining checkpatch errors are false positives. arch/x86/kernel/quirks.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/x86

Re: [PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Harvey Harrison
Don't redeclare p, use a new variable q. kernel/cpuset.c:824:23: warning: symbol 'p' shadows an earlier one kernel/cpuset.c:746:21: originally declared here kernel/cpuset.c:1272:52: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Paul

[PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Harvey Harrison
-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/cpuset.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/cpuset.c b/kernel/cpuset.c index cfaf641..fdbac43 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -821,7 +821,7 @@ static int update_cpumask(struct

[PATCH] jbd/jbd2: sparse warnings in revoke.c, journal.c

2008-02-02 Thread Harvey Harrison
as NULL pointer fs/jbd2/journal.c:2012:17: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/jbd/journal.c |4 ++-- fs/jbd/revoke.c |4 ++-- fs/jbd2/journal.c | 12 ++-- fs/jbd2/revoke.c |4 ++-- 4 files chang

[PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault()

2008-02-02 Thread Harvey Harrison
out before hitting kprobe_running(). Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/linux/kprobes.h | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h index e5ecb1e..e099426

[PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

2008-02-02 Thread Harvey Harrison
. This uncovered a possible bug in the s390 version as that purely copied the x86 version unconditionally passing 14 as the trapnr rather than the error_code parameter. s390 is changed to pass error_code in this patch. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, 1/2 is low risk, 2/2 ha

Re: [PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

2008-02-02 Thread Harvey Harrison
The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- How about I actually send the patch that worked this time? Sorry

[PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

2008-02-02 Thread Harvey Harrison
The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, this is a fairly dumb patch, but works-for-me(tm) ar

Re: [PATCH] AMD Thermal Interrupt Support

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 16:10 -0800, Andrew Morton wrote: > On Thu, 17 Jan 2008 17:06:33 -0800 "Russell Leidich" <[EMAIL PROTECTED]> > wrote: > > > > Here's the hopefully-final version of the patch, which I have just > > > tested on Intel and AMD. > > Curious. This just broke. > > i386

Re: [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 01:05 -0800, Jeremy Fitzhardinge wrote: > > -#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte)) > - > -#define __pmd_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x)) > -#define __pud_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x)) > +extern void

Re: [PATCH 2/3] x86: add function prototype to vm86.h

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote: > Harvey Harrison 写道: > > Global functions should include their prototypes. > > > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > > --- > > include/asm-x86/vm86.h |1 + > >

[PATCH] x86: remove final FASTCALL() uses

2008-02-02 Thread Harvey Harrison
A few snuck back in to x86. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/asm-x86/highmem.h |4 ++-- include/asm-x86/hw_irq_32.h |2 +- include/asm-x86/system.h|4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/asm-x86/highm

[PATCH] x86: remove final FASTCALL() uses

2008-02-02 Thread Harvey Harrison
A few snuck back in to x86. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- include/asm-x86/highmem.h |4 ++-- include/asm-x86/hw_irq_32.h |2 +- include/asm-x86/system.h|4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/asm-x86/highmem.h b

Re: [PATCH 2/3] x86: add function prototype to vm86.h

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 16:14 +0800, Li Zefan wrote: Harvey Harrison 写道: Global functions should include their prototypes. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- include/asm-x86/vm86.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include

Re: [PATCH 1 of 7] x86: convert pgalloc_64.h from macros to inlines

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 01:05 -0800, Jeremy Fitzhardinge wrote: -#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte)) - -#define __pmd_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x)) -#define __pud_free_tlb(tlb,x) tlb_remove_page((tlb),virt_to_page(x)) +extern void

Re: [PATCH] AMD Thermal Interrupt Support

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 16:10 -0800, Andrew Morton wrote: On Thu, 17 Jan 2008 17:06:33 -0800 Russell Leidich [EMAIL PROTECTED] wrote: Here's the hopefully-final version of the patch, which I have just tested on Intel and AMD. Curious. This just broke. i386 allmodconfig:

[PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

2008-02-02 Thread Harvey Harrison
The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Andrew, this is a fairly dumb patch, but works-for-me(tm) arch/x86

Re: [PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

2008-02-02 Thread Harvey Harrison
The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- How about I actually send the patch that worked this time? Sorry about

[PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

2008-02-02 Thread Harvey Harrison
. This uncovered a possible bug in the s390 version as that purely copied the x86 version unconditionally passing 14 as the trapnr rather than the error_code parameter. s390 is changed to pass error_code in this patch. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Andrew, 1/2 is low risk, 2/2 has been

[PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault()

2008-02-02 Thread Harvey Harrison
out before hitting kprobe_running(). Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- include/linux/kprobes.h | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h index e5ecb1e..e099426 100644 --- a/include

[PATCH] jbd/jbd2: sparse warnings in revoke.c, journal.c

2008-02-02 Thread Harvey Harrison
as NULL pointer fs/jbd2/journal.c:2012:17: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- fs/jbd/journal.c |4 ++-- fs/jbd/revoke.c |4 ++-- fs/jbd2/journal.c | 12 ++-- fs/jbd2/revoke.c |4 ++-- 4 files changed, 12

[PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Harvey Harrison
-by: Harvey Harrison [EMAIL PROTECTED] --- kernel/cpuset.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/cpuset.c b/kernel/cpuset.c index cfaf641..fdbac43 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -821,7 +821,7 @@ static int update_cpumask(struct cpuset

Re: [PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Harvey Harrison
Don't redeclare p, use a new variable q. kernel/cpuset.c:824:23: warning: symbol 'p' shadows an earlier one kernel/cpuset.c:746:21: originally declared here kernel/cpuset.c:1272:52: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Paul, used

[PATCH 1/3] x86: add include to cpu/intel.c

2008-02-01 Thread Harvey Harrison
Fixes sparse warning: arch/x86/kernel/cpu/intel.c:48:15: warning: symbol 'ppro_with_ram_bug' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/intel.c |1 + include/asm-x86/bugs.h |2 +- 2 files changed, 2 inse

[PATCH 3/3] x86: small sparse fix in process_32.c

2008-02-01 Thread Harvey Harrison
arch/x86/kernel/process_32.c:254:43: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/process_32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/process_32.c b/arch/x86/

[PATCH 2/3] x86: add function prototype to vm86.h

2008-02-01 Thread Harvey Harrison
Global functions should include their prototypes. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/asm-x86/vm86.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/asm-x86/vm86.h b/include/asm-x86/vm86.h index a5edf51..b72b9a6 100644 --- a/inclu

[PATCH 1/2] x86: add cpu init function defintions to cpu.h

2008-02-01 Thread Harvey Harrison
: symbol 'umc_init_cpu' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/common.c | 10 -- arch/x86/kernel/cpu/cpu.h|9 + 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/x86/kern

[PATCH 2/2] x86: add cpu mtrr init function definitions to mtrr.h

2008-02-01 Thread Harvey Harrison
: warning: symbol 'cyrix_init_mtrr' was not declared. Should it be static? arch/x86/kernel/cpu/mtrr/centaur.c:218:12: warning: symbol 'centaur_init_mtrr' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mtrr/main.c |4

Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 10:06 -0800, H. Peter Anvin wrote: > Ingo Molnar wrote: > > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > >>case 1: > >> - *(unsigned char *)s = pattern; > >> + *(unsigned

Re: Are Section mismatches out of control?

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 03:03 -0800, Andrew Morton wrote: > On Fri, 1 Feb 2008 11:47:18 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > James said in a related posting that the Section mismatch > > warnings were getting out of control. > > eh. They're easy - the build system tells you about

[PATCH] x86: fixes for lookup_address args

2008-02-01 Thread Harvey Harrison
Signedness mismatches in level argument. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, my other patch changing lookup_address was truncated and missed the other call sites, here's the rest. You can either fold this into that patch or apply separately. arch/x86/kernel/ef

Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 11:56 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > case 1: > > - *(unsigned char *)s = pattern; > > + *(unsigned char *)s = pattern & 0xff; >

[PATCH] x86: Remove long dead cyrix mtrr code

2008-02-01 Thread Harvey Harrison
cyrix_arr_init was #if 0 all the way back to at least v2.6.12. This was the only place where arr3_protected was set to anything but zero. Eliminate this variable. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mtrr/cyrix.c

[PATCH] x86: fix sparse warnings in cpu/common.c

2008-02-01 Thread Harvey Harrison
:362:30: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/cpu/common.c:362:30:expected unsigned int *ebx arch/x86/kernel/cpu/common.c:362:30:got int * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/common.c

[PATCH] x86: make early_console static in early_printk.c

2008-02-01 Thread Harvey Harrison
Not necessary to expose it, also fixes sparse warning. arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/early_printk.c |2 +- 1 files changed, 1 inse

[PATCH] x86: make early_console static in early_printk.c

2008-02-01 Thread Harvey Harrison
Not necessary to expose it, also fixes sparse warning. arch/x86/kernel/early_printk.c:196:16: warning: symbol 'early_console' was not declared. Should it be static? Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/early_printk.c |2 +- 1 files changed, 1 insertions

[PATCH] x86: fix sparse warnings in cpu/common.c

2008-02-01 Thread Harvey Harrison
/common.c:353:10:got int *noident arch/x86/kernel/cpu/common.c:362:30: warning: incorrect type in argument 3 (different signedness) arch/x86/kernel/cpu/common.c:362:30:expected unsigned int *ebx arch/x86/kernel/cpu/common.c:362:30:got int *noident Signed-off-by: Harvey Harrison [EMAIL

[PATCH] x86: Remove long dead cyrix mtrr code

2008-02-01 Thread Harvey Harrison
cyrix_arr_init was #if 0 all the way back to at least v2.6.12. This was the only place where arr3_protected was set to anything but zero. Eliminate this variable. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/cpu/mtrr/cyrix.c | 107

Re: [PATCH] x86: sparse errors from string_32.h

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 11:56 +0100, Ingo Molnar wrote: * Harvey Harrison [EMAIL PROTECTED] wrote: case 1: - *(unsigned char *)s = pattern; + *(unsigned char *)s = pattern 0xff; i've applied your fix - but wouldnt it be cleaner to just

[PATCH] x86: fixes for lookup_address args

2008-02-01 Thread Harvey Harrison
Signedness mismatches in level argument. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Ingo, my other patch changing lookup_address was truncated and missed the other call sites, here's the rest. You can either fold this into that patch or apply separately. arch/x86/kernel/efi_64.c

Re: Are Section mismatches out of control?

2008-02-01 Thread Harvey Harrison
On Fri, 2008-02-01 at 03:03 -0800, Andrew Morton wrote: On Fri, 1 Feb 2008 11:47:18 +0100 Sam Ravnborg [EMAIL PROTECTED] wrote: James said in a related posting that the Section mismatch warnings were getting out of control. eh. They're easy - the build system tells you about them!

<    1   2   3   4   5   6   7   8   >