On Tue, 2008-01-08 at 16:48 -0800, Harvey Harrison wrote:
Small step towards unifying traps_32|64.c. No functional
changes. Pull out a small helper from an if() statement
in die().
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, I know this will have checkpatch problems, doing
Small step towards unifying traps_32|64.c. No functional
changes. Pull out a small helper from an if() statement
in die().
Marked as __kprobes as eventually we will want to call this
from do_page_fault similar to how X86_64 does it.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch
Use the fixup_exception() helper instead of the open-coded
search_extable() users.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, this depends on my patch in x86.git unifying extable.c that
introduces fixup_exception() to X86_64.
arch/x86/kernel/traps_64.c | 47
()/oops_end(). Small whitespace change in
traps_64.c for easier comparison between the two.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/traps_32.c | 137 +++-
arch/x86/kernel/traps_64.c | 11 +--
2 files changed, 76 insertions
.
This uncovered a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter.
powerpc:
Tested-by: Ananth N Mavinakayanahalli [EMAIL PROTECTED]
X86-64
Acked-by: Masami Hiramatsu [EMAIL PROTECTED]
Signed-off-by: Harvey
On Wed, 2008-01-09 at 07:14 +0100, Heiko Carstens wrote:
+/*
+ * If it is a kprobe pagefault we can not be premptible so return before
Missing 'e' in preemptible.
OK.
However, the old code you removed had a lot of preempt_disable/enable calls
that you removed. Hope you checked that
a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, update to my previous patch, with relevant (I hope)
maintainers CC'd. Patch a
a possible bug in the s390 version as that purely
copied the x86 version unconditionally passing 14 as the trapnr
rather than the error_code parameter.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Andrew, update to my previous patch, with relevant (I hope)
maintainers CC'd. Patch against
On Thu, 2008-01-03 at 12:35 +0530, Ananth N Mavinakayanahalli wrote:
> On Wed, Jan 02, 2008 at 08:05:14PM -0800, Harvey Harrison wrote:
>
> Thanks for the cleanup...
>
> ...
>
> > diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c
> > index a2273d4..f2e
On Thu, 2008-01-03 at 12:35 +0530, Ananth N Mavinakayanahalli wrote:
On Wed, Jan 02, 2008 at 08:05:14PM -0800, Harvey Harrison wrote:
Thanks for the cleanup...
...
diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c
index a2273d4..f2e909b 100644
--- a/arch/x86/mm/fault_32.c
-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Andrew, this came up when discussing some x86 fault unification
work, figured you were the right person to feed this through.
At least the diffstat says I did something right. Patch against
current Linus tree.
arch/avr32/mm/fault.c
On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote:
> Hi Harvey,
>
> Harvey Harrison wrote:
> > Currently the notify_page_fault helper is used to test it the page
> > fault was caused by a kprobe causing an early return from do_page_fault.
> >
> &
Begin to unify do_page_fault(), easy code movement first.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, Alexey Dobriyan noticed an obvious typo CONFIG_x86_64 in
the previous version, this is a fixed patch.
arch/x86/mm/fault_32.c | 38 +-
On Thu, 2008-01-03 at 04:45 +0300, Alexey Dobriyan wrote:
> On Wed, Jan 02, 2008 at 05:01:02PM -0800, Harvey Harrison wrote:
> > Begin to unify do_page_fault(), easy code movement first.
> >
> > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
> > ---
Begin to unify do_page_fault(), easy code movement first.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, similar to the kprobes unification patches I did, it gets a bit
uglier before it gets better ;-)
arch/x86/mm/fault_32.c | 38 +-
ar
for preemption. The idea for this comes from a patch
by Quentin Barnes to kprobes.c
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, this may not be functionally equivalent, feel free to yank it out
if there is any trouble, but from what I've seen it should be OK.
Did you eve
Use the force_sig_info_fault helper from X86_32 in X86_64.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c |2 +-
arch/x86/mm/fault_64.c | 31 ++-
2 files changed, 19 insertions(+), 14 deletions(-)
diff --git a/arch/x86/mm/fa
Move X86_32 only get_segment_eip to X86_64
Move X86_64 only is_errata93 to X86_32
Change X86_32 loop in is_prefetch to highlight the differences
between them. Fold the logic from __is_prefetch in as well on
X86_32.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/faul
We get die() from kdebug.h, no need for forward declaration.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/mm/fault_32.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c
index bfb0917..870b561
We get die() from kdebug.h, no need for forward declaration.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c
index bfb0917..870b561 100644
Move X86_32 only get_segment_eip to X86_64
Move X86_64 only is_errata93 to X86_32
Change X86_32 loop in is_prefetch to highlight the differences
between them. Fold the logic from __is_prefetch in as well on
X86_32.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c
Use the force_sig_info_fault helper from X86_32 in X86_64.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |2 +-
arch/x86/mm/fault_64.c | 31 ++-
2 files changed, 19 insertions(+), 14 deletions(-)
diff --git a/arch/x86/mm/fault_32.c
for preemption. The idea for this comes from a patch
by Quentin Barnes to kprobes.c
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, this may not be functionally equivalent, feel free to yank it out
if there is any trouble, but from what I've seen it should be OK.
Did you ever find
On Thu, 2008-01-03 at 04:45 +0300, Alexey Dobriyan wrote:
On Wed, Jan 02, 2008 at 05:01:02PM -0800, Harvey Harrison wrote:
Begin to unify do_page_fault(), easy code movement first.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, similar to the kprobes unification patches I
Begin to unify do_page_fault(), easy code movement first.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, Alexey Dobriyan noticed an obvious typo CONFIG_x86_64 in
the previous version, this is a fixed patch.
arch/x86/mm/fault_32.c | 38 +-
arch
On Wed, 2008-01-02 at 21:36 -0500, Masami Hiramatsu wrote:
Hi Harvey,
Harvey Harrison wrote:
Currently the notify_page_fault helper is used to test it the page
fault was caused by a kprobe causing an early return from do_page_fault.
Change the name of the helper to is_kprobe_fault
-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Andrew, this came up when discussing some x86 fault unification
work, figured you were the right person to feed this through.
At least the diffstat says I did something right. Patch against
current Linus tree.
arch/avr32/mm/fault.c | 21
Just a few nitpicks. I need to look closer at the reenter_kprobe
changes, but it looks like this should lead to clearer flow than
before. The whole !p/kprobe_running() differences were pretty
twisty before.
On Wed, 2008-01-02 at 01:10 +0530, Abhishek Sagar wrote:
> Thanks for pointing me to the
Just a few nitpicks. I need to look closer at the reenter_kprobe
changes, but it looks like this should lead to clearer flow than
before. The whole !p/kprobe_running() differences were pretty
twisty before.
On Wed, 2008-01-02 at 01:10 +0530, Abhishek Sagar wrote:
Thanks for pointing me to the
On Sat, 2007-12-29 at 23:04 -0800, H. Peter Anvin wrote:
> Masami Hiramatsu wrote:
> > Hi Harvey,
> >
> > Harvey Harrison wrote:
> >> Fold some small ifdefs into a helper function.
> >>
> >> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]&g
On Sat, 2007-12-29 at 23:04 -0800, H. Peter Anvin wrote:
Masami Hiramatsu wrote:
Hi Harvey,
Harvey Harrison wrote:
Fold some small ifdefs into a helper function.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Masami, Ingo, I had this left in some unsent kprobes unification
out: only returns ret
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Masami, noticed a small bug in the previous version in the !p
case when the breakpoint was the kernel's. Please review this
version.
arch/x86/kernel/kprobes.c
Make the control flow of kprobe_handler more obvious.
Collapse the separate if blocks/gotos with if/else blocks
this unifies the duplication of the check for a breakpoint
instruction race with another cpu.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Masami, please have
Make the control flow of kprobe_handler more obvious.
Collapse the separate if blocks/gotos with if/else blocks
this unifies the duplication of the check for a breakpoint
instruction race with another cpu.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Masami, please have a look at this, I
out: only returns ret
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Masami, noticed a small bug in the previous version in the !p
case when the breakpoint was the kernel's. Please review this
version.
arch/x86/kernel/kprobes.c | 60 +
1
and add useful
comment from X86_32. Use these defines in X86_32 where obvious.
- Unify comments between 32|64 bit
- Small ifdef movement for CONFIG_KPROBES in notify_page_fault()
- Introduce X86_64 only case statement
No Functional Changes.
Signed-off-by: Harvey Harrison <[EMAIL PROTEC
and add useful
comment from X86_32. Use these defines in X86_32 where obvious.
- Unify comments between 32|64 bit
- Small ifdef movement for CONFIG_KPROBES in notify_page_fault()
- Introduce X86_64 only case statement
No Functional Changes.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch
Move #ifdef around function definiton into the function and
unconditionally return on X86_32. Saves an ifdef from the
one callsite.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, Masami, final leftovers from some unsent kprobes unification work.
Net reduction of one #ifdef s
Fold some small ifdefs into a helper function.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Masami, Ingo, I had this left in some unsent kprobes unification
work. Depends on your tastes, but does reduce ifdefs and is a bit
better about self-documenting the REX prefix on X86_64.
Fold some small ifdefs into a helper function.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Masami, Ingo, I had this left in some unsent kprobes unification
work. Depends on your tastes, but does reduce ifdefs and is a bit
better about self-documenting the REX prefix on X86_64.
If I
Move #ifdef around function definiton into the function and
unconditionally return on X86_32. Saves an ifdef from the
one callsite.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Ingo, Masami, final leftovers from some unsent kprobes unification work.
Net reduction of one #ifdef section
On Thu, 2007-12-20 at 18:30 -0800, Andrew Morton wrote:
> On Wed, 12 Dec 2007 15:38:26 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Andrew, I'm not sure who is best to hit with these final dribs and
> > drabs removing fastcall. Once all of these have hit Lin
On Thu, 2007-12-20 at 18:30 -0800, Andrew Morton wrote:
On Wed, 12 Dec 2007 15:38:26 -0800 Harvey Harrison [EMAIL PROTECTED] wrote:
Andrew, I'm not sure who is best to hit with these final dribs and
drabs removing fastcall. Once all of these have hit Linus' tree
I will send a final patch
__always_inline on some static functions was to ensure they ended
up in the .kprobes.text section. Mark this explicitly.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/kprobes.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ar
On Tue, 2007-12-18 at 23:43 -0500, Masami Hiramatsu wrote:
> Harvey Harrison wrote:
> > On Tue, 2007-12-18 at 08:50 -0500, Masami Hiramatsu wrote:
> >> Hi Harvey,
> >>
> >> Thank you for cleaning this up.
> >>
> >> Harvey Harrison wrote:
On Tue, 2007-12-18 at 08:50 -0500, Masami Hiramatsu wrote:
> Hi Harvey,
>
> Thank you for cleaning this up.
>
> Harvey Harrison wrote:
> > Subject: [PATCH] x86: kprobes leftover cleanups
> >
> > Eliminate __always_inline, all of these static functions are
> &
>From 5be3fc6a0e28d82a05487a8fb1a86532fb0ad4e8 Mon Sep 17 00:00:00 2001
From: Harvey Harrison <[EMAIL PROTECTED]>
Date: Tue, 18 Dec 2007 03:58:10 -0800
Subject: [PATCH] x86: unify module_{32|64}.h
This adds one case to the MODULE_PROC_FAMILY block testing
for X86_64. There are no n
This adds one case to the MODULE_PROC_FAMILY block testing
for X86_64. There are no new things defined on X86_64 than
there were before.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/module.h| 83 +-
include/a
On Tue, 2007-12-18 at 12:29 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Sorry I missed an ifdef in this patch in the following hunk:
>
> could you resend your kprobes cleanups against current x86.git? They
> have been conceptually ack
On Tue, 2007-12-18 at 12:19 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > Use the fixup_exception() helper in fault_64.c
>
> thanks, applied.
>
> > This is only appropriate if CONFIG_PNP_BIOS cannot be set on X86_64,
> >
Use the fixup_exception() helper in fault_64.c
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
This is only appropriate if CONFIG_PNP_BIOS cannot be set on
X86_64, which looks to be the case, but needs confirmation.
arch/x86/mm/fault_64.c |5 +
1 files changed, 1 insertions
Introduce fixup_exception() on X86_64 and use it in kprobes to
eliminate an #ifdef.
Only X86_64 needs search_extable() due to a stepping bug.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/kprobes.c | 12 +
arch/x86/mm/Makefile_32 |2 +-
arch/
Introduce fixup_exception() on X86_64 and use it in kprobes to
eliminate an #ifdef.
Only X86_64 needs search_extable() due to a stepping bug.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/kprobes.c | 12 +
arch/x86/mm/Makefile_32 |2 +-
arch/x86/mm
Use the fixup_exception() helper in fault_64.c
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
This is only appropriate if CONFIG_PNP_BIOS cannot be set on
X86_64, which looks to be the case, but needs confirmation.
arch/x86/mm/fault_64.c |5 +
1 files changed, 1 insertions(+), 4
On Tue, 2007-12-18 at 12:19 +0100, Ingo Molnar wrote:
* Harvey Harrison [EMAIL PROTECTED] wrote:
Use the fixup_exception() helper in fault_64.c
thanks, applied.
This is only appropriate if CONFIG_PNP_BIOS cannot be set on X86_64,
which looks to be the case, but needs confirmation
On Tue, 2007-12-18 at 12:29 +0100, Ingo Molnar wrote:
* Harvey Harrison [EMAIL PROTECTED] wrote:
Sorry I missed an ifdef in this patch in the following hunk:
could you resend your kprobes cleanups against current x86.git? They
have been conceptually acked by Masami. This cuts out
This adds one case to the MODULE_PROC_FAMILY block testing
for X86_64. There are no new things defined on X86_64 than
there were before.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
include/asm-x86/module.h| 83 +-
include/asm-x86/module_32
From 5be3fc6a0e28d82a05487a8fb1a86532fb0ad4e8 Mon Sep 17 00:00:00 2001
From: Harvey Harrison [EMAIL PROTECTED]
Date: Tue, 18 Dec 2007 03:58:10 -0800
Subject: [PATCH] x86: unify module_{32|64}.h
This adds one case to the MODULE_PROC_FAMILY block testing
for X86_64. There are no new things defined
On Tue, 2007-12-18 at 08:50 -0500, Masami Hiramatsu wrote:
Hi Harvey,
Thank you for cleaning this up.
Harvey Harrison wrote:
Subject: [PATCH] x86: kprobes leftover cleanups
Eliminate __always_inline, all of these static functions are
only called once. Minor whitespace cleanup
On Tue, 2007-12-18 at 23:43 -0500, Masami Hiramatsu wrote:
Harvey Harrison wrote:
On Tue, 2007-12-18 at 08:50 -0500, Masami Hiramatsu wrote:
Hi Harvey,
Thank you for cleaning this up.
Harvey Harrison wrote:
Subject: [PATCH] x86: kprobes leftover cleanups
Eliminate
__always_inline on some static functions was to ensure they ended
up in the .kprobes.text section. Mark this explicitly.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/kprobes.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Replacement for the last patch in the kprobes series I just sent.
arch/x86/kernel/kprobes.c | 45 +
1 files changed, 21 insertions(+), 24 deletions(-)
diff --git a/arch/x86/kernel/kprob
On Mon, 2007-12-17 at 18:14 -0500, Masami Hiramatsu wrote:
> Hi Harvey,
>
> Harvey Harrison wrote:
> > On Mon, 2007-12-17 at 16:52 -0500, Masami Hiramatsu wrote:
> >> Hi Harvey,
> >> Before porting, could you tell me what differences are important
Sorry I missed an ifdef in this patch in the following hunk:
@@ -183,6 +185,9 @@ retry:
}
switch (opcode & 0xf0) {
+#ifdef X86_64
+ case 0x40:
+ goto retry; /* REX prefix is boostable */
case 0x60:
if (0x63 < opcode && opcode < 0x67)
On Mon, 2007-12-17 at 16:52 -0500, Masami Hiramatsu wrote:
> Hi Harvey,
> Before porting, could you tell me what differences are important
> to you? We can discuss about it.
>
> > I just sent out a series of 4 patches equivalent to your patches 1-4/6
> > but based on my already unified
On Mon, 2007-12-17 at 16:28 -0500, Masami Hiramatsu wrote:
> Hi Harvey,
> If you mention about a relative jump which is inserted by
> resume_execution(), I think you might misunderstand that relative jump.
>
> The size of that relative jump, which will be embedded by kprobe-booster, is
>
- Rewrite register saving/restoring code
Based on patch from Masami Hiramatsu <[EMAIL PROTECTED]>
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Sorry Ingo, I based my other 4/4 off the patch that had the one incorrect
ifdef around trampoline_probe_handler. This is based o
cf) case.to X86_64
- Fold jmp absolute (0xea) handling into iret/ret/lret handling
Based on patch from Masami Hiramatsu <[EMAIL PROTECTED]>
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/kprobes.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(
- Rewrite register saving/restoring code
Based on patch from Masami Hiramatsu <[EMAIL PROTECTED]>
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/kprobes.c | 104 +
1 files changed, 58 insertions(+), 46 deletions(-)
- Use jprobe_saved_regs instead getting it from stack.
(Especially on x86-64, it may get incorrect data, because
pt_regs can not be get by using container_of(rsp))
- Change the type of stack pointer to unsigned long *.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kern
Based on X86_32, mostly by un-ifdeffing code.
Based on patch from Masami Hiramatsu <[EMAIL PROTECTED]>
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/kernel/kprobes.c | 57 +++--
include/asm-x86/kprobes.h | 12 +-
On Mon, 2007-12-17 at 17:06 +0100, Ingo Molnar wrote:
> * Masami Hiramatsu <[EMAIL PROTECTED]> wrote:
>
> > > cool! Please Cc: lkml and Harvey as well so that there's less
> > > overlap in unification work - Harvey spent quite some time unifying
> > > and cleaning up the kprobes code during the
On Mon, 2007-12-17 at 19:52 +0530, Srikar Dronamraju wrote:
> * Ingo Molnar <[EMAIL PROTECTED]> [2007-12-15 14:12:04]:
>
>
> Hi Ingo, Harvey
>
> In file include/asm-x86/kprobes_32.h
> typedef u8 kprobe_opcode_t;
> hence sizeof(kprobe_opcode_t) turns out to be 1.
>
> Hence
>
>
On Mon, 2007-12-17 at 17:33 +0100, Ingo Molnar wrote:
> * Masami Hiramatsu <[EMAIL PROTECTED]> wrote:
>
> > Hello all,
> >
> > I developed a series of patches which unifies kprobes code on x86 and
> > introduces boosters on x86-64. These patches can be applied to
> > 2.6.24-rc4-mm1.
> >
> >
On Mon, 2007-12-17 at 17:33 +0100, Ingo Molnar wrote:
* Masami Hiramatsu [EMAIL PROTECTED] wrote:
Hello all,
I developed a series of patches which unifies kprobes code on x86 and
introduces boosters on x86-64. These patches can be applied to
2.6.24-rc4-mm1.
The purpose of this
On Mon, 2007-12-17 at 19:52 +0530, Srikar Dronamraju wrote:
* Ingo Molnar [EMAIL PROTECTED] [2007-12-15 14:12:04]:
Hi Ingo, Harvey
In file include/asm-x86/kprobes_32.h
typedef u8 kprobe_opcode_t;
hence sizeof(kprobe_opcode_t) turns out to be 1.
Hence
memcpy(p-ainsn.insn, p-addr,
On Mon, 2007-12-17 at 17:06 +0100, Ingo Molnar wrote:
* Masami Hiramatsu [EMAIL PROTECTED] wrote:
cool! Please Cc: lkml and Harvey as well so that there's less
overlap in unification work - Harvey spent quite some time unifying
and cleaning up the kprobes code during the past week.
jprobe_saved_regs instead getting it from stack.
(Especially on x86-64, it may get incorrect data, because
pt_regs can not be get by using container_of(rsp))
- Change the type of stack pointer to unsigned long *.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/kprobes.c |8
Based on X86_32, mostly by un-ifdeffing code.
Based on patch from Masami Hiramatsu [EMAIL PROTECTED]
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/kprobes.c | 57 +++--
include/asm-x86/kprobes.h | 12 +
2 files changed
(0xea) handling into iret/ret/lret handling
Based on patch from Masami Hiramatsu [EMAIL PROTECTED]
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/kprobes.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch
- Rewrite register saving/restoring code
Based on patch from Masami Hiramatsu [EMAIL PROTECTED]
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
arch/x86/kernel/kprobes.c | 104 +
1 files changed, 58 insertions(+), 46 deletions(-)
diff --git
- Rewrite register saving/restoring code
Based on patch from Masami Hiramatsu [EMAIL PROTECTED]
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Sorry Ingo, I based my other 4/4 off the patch that had the one incorrect
ifdef around trampoline_probe_handler. This is based on your fixed one
On Mon, 2007-12-17 at 16:28 -0500, Masami Hiramatsu wrote:
Hi Harvey,
If you mention about a relative jump which is inserted by
resume_execution(), I think you might misunderstand that relative jump.
The size of that relative jump, which will be embedded by kprobe-booster, is
5-bytes(not 1
On Mon, 2007-12-17 at 16:52 -0500, Masami Hiramatsu wrote:
Hi Harvey,
Before porting, could you tell me what differences are important
to you? We can discuss about it.
I just sent out a series of 4 patches equivalent to your patches 1-4/6
but based on my already unified kprobes.c/h, You
Sorry I missed an ifdef in this patch in the following hunk:
@@ -183,6 +185,9 @@ retry:
}
switch (opcode 0xf0) {
+#ifdef X86_64
+ case 0x40:
+ goto retry; /* REX prefix is boostable */
case 0x60:
if (0x63 opcode opcode 0x67)
On Mon, 2007-12-17 at 18:14 -0500, Masami Hiramatsu wrote:
Hi Harvey,
Harvey Harrison wrote:
On Mon, 2007-12-17 at 16:52 -0500, Masami Hiramatsu wrote:
Hi Harvey,
Before porting, could you tell me what differences are important
to you? We can discuss about it.
I've already ported
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
---
Replacement for the last patch in the kprobes series I just sent.
arch/x86/kernel/kprobes.c | 45 +
1 files changed, 21 insertions(+), 24 deletions(-)
diff --git a/arch/x86/kernel/kprobes.c b/arch
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Dave, this is the remainder of the FASTCALL/fastcall removal
patch that is not already in your tree.
Generated against net-2.6.25.git
drivers/net/ns83820.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff
X86_32 was the last user of the FASTCALL/fastcall macros, now that it
uses regparm(3) by default, these macros expand to nothing.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Dave, this is a wrap-up of my patch in your net-2.6.25.git with
the build breakage fix from Andrew
Mostly space after comma, one space after if.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/local.h | 17 -
1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/include/asm-x86/local.h b/include/asm-x86/local.h
index f5677e2..f852c62
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/local.h| 148 ++-
include/asm-x86/local_32.h | 150
include/asm-x86/local_64.h | 134 ---
3
Use the shorter +m form rather than =m and m.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/local_64.h | 30 ++
1 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/include/asm-x86/local_64.h b/include/asm-x86/local_64.h
Handle the use of long on X86_32 and quad on X86_64
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/asm.h | 12
include/asm-x86/local.h|2 ++
include/asm-x86/local_32.h | 18 +-
include/asm-x86/local_64.h
Common prefix from both files moved to local.h
Change __inline__ to inline
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
Ingo, this is the revised series with fixed asm incorporating
HPA's comments.
include/asm-x86/local.h| 19 +--
include/asm-x86/loca
On Sun, 2007-12-16 at 15:48 -0800, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> >
> > Do you have a stylistic preference between these two options:
> >
> > Option 1) Rely on CPP string constant concatenation
> >
> > // possibly include trailing space h
On Sun, 2007-12-16 at 14:48 -0800, H. Peter Anvin wrote:
> Ingo Molnar wrote:
> > * Harvey Harrison <[EMAIL PROTECTED]> wrote:
> >
> >> No differences except for the defintion of local_add_return on X86_64.
> >> The X86_32 version is just fine as it is pr
On Sun, 2007-12-16 at 10:18 -0800, H. Peter Anvin wrote:
> Harvey Harrison wrote:
> > Introduce macros to deal with X86_32 using longs and X86_64
> > using quads. Small comment fixes to make files match.
> >
> > #define local_read(l) atomic_long_read(&(l)
One section collecting all constant defines. Ifdef the asm
blocks for X86_32/64.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/kexec.h| 169 +++-
include/asm-x86/kexec_32.h | 99 --
include/a
No differences except for the defintion of local_add_return on
X86_64. The X86_32 version is just fine as it is protected with
ifdef CONFIG_M386 so use it directly.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/local.h
Introduce macros to deal with X86_32 using longs and X86_64
using quads. Small comment fixes to make files match.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
include/asm-x86/local.h| 17 +
include/asm-x86/local_32.h | 28 ++--
i
601 - 700 of 799 matches
Mail list logo
