Re: [f2fs-dev] [PATCH 1/2] f2fs: check only data or node for summary

2016-07-05 Thread He YunLei
On 2016/6/11 5:01, Jaegeuk Kim wrote: We can check data or node types only for gc, since we allocate different type of data/node blocks in a different logs occasionally. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [f2fs-dev] [PATCH 1/2] f2fs: check only data or node for summary

2016-07-05 Thread He YunLei
On 2016/6/11 5:01, Jaegeuk Kim wrote: We can check data or node types only for gc, since we allocate different type of data/node blocks in a different logs occasionally. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [f2fs-dev] [PATCH 1/4] f2fs: propagate error given by f2fs_find_entry

2016-05-26 Thread He YunLei
On 2016/5/27 8:25, Jaegeuk Kim wrote: If we get ENOMEM or EIO in f2fs_find_entry, we should stop right away. Otherwise, for example, we can get duplicate directory entry by ->chash and ->clevel. Signed-off-by: Jaegeuk Kim --- fs/f2fs/dir.c| 23 ---

Re: [f2fs-dev] [PATCH 1/4] f2fs: propagate error given by f2fs_find_entry

2016-05-26 Thread He YunLei
On 2016/5/27 8:25, Jaegeuk Kim wrote: If we get ENOMEM or EIO in f2fs_find_entry, we should stop right away. Otherwise, for example, we can get duplicate directory entry by ->chash and ->clevel. Signed-off-by: Jaegeuk Kim --- fs/f2fs/dir.c| 23 --- fs/f2fs/inline.c |

Re: [f2fs-dev] [PATCH 1/2] f2fs: use atomic variable for total_extent_tree

2015-12-29 Thread He YunLei
On 2015/12/22 11:38, Jaegeuk Kim wrote: It would be better to use atomic variable for total_extent_tree. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c| 5 +++-- fs/f2fs/extent_cache.c | 8 fs/f2fs/f2fs.h | 2 +- fs/f2fs/node.c | 3 ++- fs/f2fs/shrinker.c

Re: [f2fs-dev] [PATCH 1/2] f2fs: use atomic variable for total_extent_tree

2015-12-29 Thread He YunLei
On 2015/12/22 11:38, Jaegeuk Kim wrote: It would be better to use atomic variable for total_extent_tree. Signed-off-by: Jaegeuk Kim --- fs/f2fs/debug.c| 5 +++-- fs/f2fs/extent_cache.c | 8 fs/f2fs/f2fs.h | 2 +- fs/f2fs/node.c | 3 ++-

Re: [f2fs-dev] [PATCH 2/2] f2fs: speed up shrinking extent tree entries

2015-12-22 Thread He YunLei
On 2015/12/22 13:20, Chao Yu wrote: Hi Jaegeuk, We should update _zombie_tree whenever removing unreferenced extent tree during shrinking: - f2fs_shrink_extent_tree if (!atomic_read(>refcount)) { ... atomic_dec(>total_ext_tree); atomic_dec(>total_zombie_tree);

Re: [f2fs-dev] [PATCH 2/2] f2fs: speed up shrinking extent tree entries

2015-12-22 Thread He YunLei
On 2015/12/22 13:20, Chao Yu wrote: Hi Jaegeuk, We should update _zombie_tree whenever removing unreferenced extent tree during shrinking: - f2fs_shrink_extent_tree if (!atomic_read(>refcount)) { ... atomic_dec(>total_ext_tree); atomic_dec(>total_zombie_tree);

Re: [f2fs-dev] [PATCH 2/3] f2fs: add a tracepoint for background gc

2015-10-10 Thread He YunLei
On 2015/10/6 6:43, Jaegeuk Kim wrote: This patch introduces a tracepoint to monitor background gc behaviors. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c| 3 +++ include/trace/events/f2fs.h | 28 2 files changed, 31 insertions(+) diff --git

Re: [f2fs-dev] [PATCH 2/3] f2fs: add a tracepoint for background gc

2015-10-10 Thread He YunLei
On 2015/10/6 6:43, Jaegeuk Kim wrote: This patch introduces a tracepoint to monitor background gc behaviors. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c| 3 +++ include/trace/events/f2fs.h | 28 2 files changed, 31

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-16 Thread He YunLei
On 2015/9/16 18:15, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, September 16, 2015 5:21 AM To: Chao Yu Cc: linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] f2fs: enhance

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-16 Thread He YunLei
On 2015/9/16 18:15, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, September 16, 2015 5:21 AM To: Chao Yu Cc: linux-f2fs-de...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] f2fs: enhance

Re: [RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time

2014-10-11 Thread He YunLei
On 2014/10/9 2:10, Tony Lindgren wrote: * He YunLei [141007 18:43]: Thanks for your review and I am really appreciated it, but in our arm platform, we haven't custom initcall levels for other drivers. Although deferred probe helps other drivers to register well, we are also confused

Re: [RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time

2014-10-11 Thread He YunLei
On 2014/10/9 2:10, Tony Lindgren wrote: * He YunLei heyun...@huawei.com [141007 18:43]: Thanks for your review and I am really appreciated it, but in our arm platform, we haven't custom initcall levels for other drivers. Although deferred probe helps other drivers to register well, we are also

Re: [RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time

2014-10-07 Thread He YunLei
On 2014/9/30 1:54, Tony Lindgren wrote: * He YunLei [140929 03:32]: On our arm platform, some modules (e.g. I2C bus driver) will use the pinctrl-single driver to configure the SoC pin, but pinctrl-single driver uses module_init time, that makes some modules initialize ahead the pinctrl-single

Re: [RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time

2014-10-07 Thread He YunLei
On 2014/9/30 1:54, Tony Lindgren wrote: * He YunLei heyun...@huawei.com [140929 03:32]: On our arm platform, some modules (e.g. I2C bus driver) will use the pinctrl-single driver to configure the SoC pin, but pinctrl-single driver uses module_init time, that makes some modules initialize ahead

[RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time

2014-09-29 Thread He YunLei
On our arm platform, some modules (e.g. I2C bus driver) will use the pinctrl-single driver to configure the SoC pin, but pinctrl-single driver uses module_init time, that makes some modules initialize ahead the pinctrl-single and fail to register. This patch promotes the initialization

[RFC PATCH] pinctrl: pinctrl-single.c: init pinctrl single at arch_initcall time

2014-09-29 Thread He YunLei
On our arm platform, some modules (e.g. I2C bus driver) will use the pinctrl-single driver to configure the SoC pin, but pinctrl-single driver uses module_init time, that makes some modules initialize ahead the pinctrl-single and fail to register. This patch promotes the initialization