Re: [PATCH RESEND v4] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

019-10-03 18:13, Jason Baron wrote: > >>>>> On 9/30/19 7:55 AM, Roman Penyaev wrote: > >>>>>> On 2019-09-28 04:29, Andrew Morton wrote: > >>>>>>> On Wed, 25 Sep 2019 09:56:03 +0800 hev wrote: > >>>>>>>

Re: [PATCH RESEND v2] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

Hi, On Tue, Sep 24, 2019 at 11:19 PM Jason Baron wrote: > > > > On 9/24/19 10:06 AM, Heiher wrote: > > Hi, > > > > On Mon, Sep 23, 2019 at 11:34 PM Jason Baron wrote: > >> > >> > >> > >> On 9/20/19 12:00 PM, Jason Bar

Re: [PATCH RESEND v2] fs/epoll: Remove unnecessary wakeups of nested epoll that in ET mode

Hi, On Mon, Sep 23, 2019 at 11:34 PM Jason Baron wrote: > > > > On 9/20/19 12:00 PM, Jason Baron wrote: > > On 9/19/19 5:24 AM, hev wrote: > >> From: Heiher > >> > >> Take the case where we have: > >> > >> t0 > >&

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

Hi, On Fri, Sep 6, 2019 at 1:48 AM Jason Baron wrote: > > > > On 9/5/19 1:27 PM, Roman Penyaev wrote: > > On 2019-09-05 11:56, Heiher wrote: > >> Hi, > >> > >> On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: > >>> > >>> Hi, >

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

Hi, On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: > > Hi, > > I created an epoll wakeup test project, listed some possible cases, > and any other corner cases needs to be added? > > https://github.com/heiher/epoll-wakeup/blob/master/README.md > > On Wed, Sep 4, 201

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

Hi, I created an epoll wakeup test project, listed some possible cases, and any other corner cases needs to be added? https://github.com/heiher/epoll-wakeup/blob/master/README.md On Wed, Sep 4, 2019 at 10:02 PM Heiher wrote: > > Hi, > > On Wed, Sep 4, 2019 at 8:02 PM Jason

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

Hi, On Wed, Sep 4, 2019 at 8:02 PM Jason Baron wrote: > > > > On 9/4/19 5:57 AM, Roman Penyaev wrote: > > On 2019-09-03 23:08, Jason Baron wrote: > >> On 9/2/19 11:36 AM, Roman Penyaev wrote: > >>> Hi, > >>> > >>> This is indeed a bug. (quick side note: could you please remove efd[1] > >>> from

Re: Why the edge-triggered mode doesn't work for epoll file descriptor?

Hello, Thank you reply. On Mon, Aug 26, 2019 at 2:22 PM Eric Wong wrote: > > Heiher wrote: > > Hello, > > > > I've added a pipe file descriptor (fd1) to an epoll (fd3) with > > EPOLLOUT in edge-triggered mode, and then added the fd3 to another > > epoll (fd4

Re: Why the edge-triggered mode doesn't work for epoll file descriptor?

On Sun, Aug 18, 2019 at 12:36 AM Heiher wrote: > > Hello, > > I've added a pipe file descriptor (fd1) to an epoll (fd3) with > EPOLLOUT in edge-triggered mode, and then added the fd3 to another > epoll (fd4) with EPOLLIN in edge-triggered too. > > Next, waiting for fd4 w

Why the edge-triggered mode doesn't work for epoll file descriptor?

Hello, I've added a pipe file descriptor (fd1) to an epoll (fd3) with EPOLLOUT in edge-triggered mode, and then added the fd3 to another epoll (fd4) with EPOLLIN in edge-triggered too. Next, waiting for fd4 without timeout. When fd1 to be writable, i think epoll_wait(fd4, ...) only return once,

Re: [PATCH 3.18 45/52] MIPS: memset.S: Fix clobber of v1 in last_fixup

Hi, Now I understand, thank you explain. On Mon, Apr 23, 2018 at 5:36 PM, Matt Redfearn <matt.redfe...@mips.com> wrote: > > > On 23/04/18 08:16, Heiher wrote: >> >> Hi, >> >> IIRC, The v1 is a temporary register, value is not preserved across >> fu

Re: [PATCH 3.18 45/52] MIPS: memset.S: Fix clobber of v1 in last_fixup

Hi, Now I understand, thank you explain. On Mon, Apr 23, 2018 at 5:36 PM, Matt Redfearn wrote: > > > On 23/04/18 08:16, Heiher wrote: >> >> Hi, >> >> IIRC, The v1 is a temporary register, value is not preserved across >> function calls. > > >

Re: [PATCH 3.18 45/52] MIPS: memset.S: Fix clobber of v1 in last_fixup

Hi, IIRC, The v1 is a temporary register, value is not preserved across function calls. I don't see any functions that generated by compiler to restore values of v1 after clobbered it. On Sun, Apr 22, 2018 at 9:54 PM, Greg Kroah-Hartman wrote: > 3.18-stable review

Re: [PATCH 3.18 45/52] MIPS: memset.S: Fix clobber of v1 in last_fixup

Hi, IIRC, The v1 is a temporary register, value is not preserved across function calls. I don't see any functions that generated by compiler to restore values of v1 after clobbered it. On Sun, Apr 22, 2018 at 9:54 PM, Greg Kroah-Hartman wrote: > 3.18-stable review patch. If anyone has any