On Tue, Jun 09, 2020 at 04:57:40PM -0700, Prashant Malani wrote:
> Hi Rob,
>
> Thanks again for the comments and feedback. Kindly see responses inline:
>
> (Trimming unrelated text from thread):
>
> On Tue, Jun 09, 2020 at 02:30:11PM -0600, Rob Herring wrote:
> > On Fri, May 29, 2020 at 5:30 PM
On Tue, May 26, 2020 at 10:26:23AM +0200, Rafael J. Wysocki wrote:
> On Tue, May 26, 2020 at 7:58 AM Greg Kroah-Hartman
> wrote:
> >
> > On Mon, May 25, 2020 at 03:49:01PM -0700, Dmitry Torokhov wrote:
> > > On Sun, May 24, 2020 at 8:34 AM Greg Kroah-Hartman
> > > wrote:
> > > >
> > > > It is pos
> Cc: stable
> Cc: Andy Shevchenko
> Cc: Brendan Higgins
> Cc: Dmitry Torokhov
> Cc: Heikki Krogerus
> Cc: Petr Mladek
> Cc: Rafael J. Wysocki
> Cc: Randy Dunlap
> Cc: Rasmus Villemoes
> Cc: Sakari Ailus
> Cc: Sergey Senozhatsky
> Cc: Steven Rosted
On Tue, May 19, 2020 at 10:19:03PM +0200, Christian Lamparter wrote:
> Hello,
>
> On Tue, May 19, 2020 at 1:45 PM Heikki Krogerus
> wrote:
> > On Wed, May 06, 2020 at 11:30:22AM +0530, Vinod Koul wrote:
> > > From: Christian Lamparter
> > >
> > > Th
hen they are finished, continue with secondary node if available.
>
> Signed-off-by: Andy Shevchenko
FWIW:
Reviewed-by: Heikki Krogerus
> ---
> drivers/base/property.c | 13 +++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/pro
On Tue, May 19, 2020 at 05:31:30PM +0530, Vinod Koul wrote:
> Hi Heikki
>
> On 19-05-20, 14:45, Heikki Krogerus wrote:
> > Hi guys,
> >
> > On Wed, May 06, 2020 at 11:30:22AM +0530, Vinod Koul wrote:
> > > From: Christian Lamparter
> > >
> >
Hi guys,
On Wed, May 06, 2020 at 11:30:22AM +0530, Vinod Koul wrote:
> From: Christian Lamparter
>
> This add a new driver for renesas xhci which is basically a firmware
> loader for uPD720201 and uPD720202 w/o ROM. The xhci-pci driver will
> invoke this driver for loading/unloading on relevant
Hi Prashant,
> I just realized, the issue I initially pointed out would apply to the
> connect message too, i.e I'm not sure if "normal" orientation setting
> handles the case where port orientation is reversed correctly.
> Overall, I am not sure that re-using the typec_orientations[] string
> lis
On Wed, May 13, 2020 at 04:14:51PM -0700, Randy Dunlap wrote:
> On 5/13/20 2:30 PM, Brendan Higgins wrote:
> > On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus
> > wrote:
> >>
> >> In the function kobject_cleanup(), kobject_del(kobj) is
> >> called
ot;software node: Simplify software_node_release()
function"")
Cc: Brendan Higgins
Cc: Randy Dunlap
Suggested-by: "Rafael J. Wysocki"
Signed-off-by: Heikki Krogerus
---
lib/kobject.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a
#x27;s
> document here.
>
> Link: https://www.ti.com/lit/an/slva843a/slva843a.pdf
>
> With this change its possible to use the USB role-switch API to detect and
> notify role-switches to downstream consumers.
>
> Tested with a ChipIdea controller on a Qualcomm MSM8939.
>
>
Hi Prashant,
On Mon, May 11, 2020 at 10:57:19AM -0700, Prashant Malani wrote:
> Hi Heikki,
>
> Thanks a lot for looking into this. Kindly see my response inline:
>
> On Mon, May 11, 2020 at 04:32:02PM +0300, Heikki Krogerus wrote:
> > On Fri, May 08, 2020 at 02:18:44PM +
Hi guys,
On Mon, May 11, 2020 at 01:46:35PM -0700, Prashant Malani wrote:
> Hi Rob,
>
> Thank you for reviewing the patch. Kindly see my comments inline:
>
> On Mon, May 11, 2020 at 02:28:00PM -0500, Rob Herring wrote:
> > On Wed, Apr 22, 2020 at 03:22:39PM -0700, Prashant Malani wrote:
> > > Ad
On Fri, May 08, 2020 at 02:18:44PM +0300, Heikki Krogerus wrote:
> Hi Prashant,
>
> On Thu, May 07, 2020 at 03:40:41PM -0700, Prashant Malani wrote:
> > > +static int sbu_orientation(struct pmc_usb_port *port)
> > > +{
> > > + if (port->sbu_o
Hi,
On Thu, May 07, 2020 at 10:59:38PM +0100, Bryan O'Donoghue wrote:
> @@ -452,6 +471,7 @@ static int tps6598x_probe(struct i2c_client *client)
> {
> struct typec_capability typec_cap = { };
> struct tps6598x *tps;
> + struct fwnode_handle *fwnode;
> u32 status;
> u32
On Thu, May 07, 2020 at 10:47:33PM +0100, Bryan O'Donoghue wrote:
> Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
> setting.
>
> Cc: Heikki Krogerus
> Cc: Greg Kroah-Hartman
> Cc: Nikolaus Voss
> Cc: Andy Shevchenko
> Cc: Gustavo A. R.
ing, explicitly define a field for the
> HPD_HIGH mode data bit.
>
> Signed-off-by: Prashant Malani
> Fixes: 6701adfa9693 ("usb: typec: driver for Intel PMC mux control")
> Reviewed-by: Benson Leung
Acked-by: Heikki Krogerus
> ---
>
> Changes in v3:
>
Hi,
On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote:
> V2:
> - Put myself down as sole schema maintainer as suggested - Andy
> - Fixed whitespace typo - Andy
> - Removed ifdef and of_match_ptr() - Andy
>
> V1:
> This simple series adds DT binding yaml and a DT lookup table for th
Hi Prashant,
On Thu, May 07, 2020 at 03:40:41PM -0700, Prashant Malani wrote:
> > +static int sbu_orientation(struct pmc_usb_port *port)
> > +{
> > + if (port->sbu_orientation)
> > + return port->sbu_orientation - 1;
> > +
> > + return port->orientation - 1;
> > +}
> > +
> > +static
Adding documentation that describes how the PMC mux-agent
function is described in the ACPI tables.
Signed-off-by: Heikki Krogerus
---
.../firmware-guide/acpi/intel-pmc-mux.rst | 153 ++
1 file changed, 153 insertions(+)
create mode 100644 Documentation/firmware-guide/acpi
an be used. When the property exists, the
driver always sets the SBU orientation according to the
property value, and when it's not set, the driver uses the
cable plug orientation with SBU.
And with static HSL orientation, "hsl-orientation" device
property can be used in the same wa
I will be maintaining the Intel PMC mux control driver.
Signed-off-by: Heikki Krogerus
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2926327e4976..5a7b0205397b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17590,6 +17590,13 @@ F
RS
file in the last patch.
Let me know if you want me to change anything.
thanks,
Heikki Krogerus (4):
usb: typec: Add typec_find_orientation()
usb: typec: mux: intel_pmc_mux: Support for static SBU/HSL orientation
usb: typec: Add firmware documentation for the Intel PMC mux control
MAINTA
Function that converts orientation string into orientation
value.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 36
include/linux/usb/typec.h | 1 +
2 files changed, 25 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/typec/class.c
PD_HIGH, the HPD_HIGH field in the Alternate Mode request “mode_data”
> field (bit 14) should also be set. Ensure the bit is correctly handled
> while issuing the Alternate Mode request.
>
> Signed-off-by: Prashant Malani
> Fixes: 6701adfa9693 ("usb: typec: driver for Intel PMC
On Wed, Oct 23, 2019 at 08:01:26AM -0700, Guenter Roeck wrote:
> On Wed, Oct 23, 2019 at 05:29:00PM +0300, Heikki Krogerus wrote:
> > On Wed, Oct 23, 2019 at 06:44:39AM -0700, Guenter Roeck wrote:
> > > On 10/23/19 1:32 AM, Heikki Krogerus wrote:
> > > > +Guenter
&
On Wed, Oct 23, 2019 at 06:44:39AM -0700, Guenter Roeck wrote:
> On 10/23/19 1:32 AM, Heikki Krogerus wrote:
> > +Guenter
> >
> > On Tue, Oct 22, 2019 at 04:59:24PM +0800, Puma Hsu wrote:
> > > Export the Type-C connector orientation so that user space
s-class-typec
> +++ b/Documentation/ABI/testing/sysfs-class-typec
> @@ -108,6 +108,17 @@ Contact: Heikki Krogerus
>
> Description:
> Revision number of the supported USB Type-C specification.
>
> +What:/sys/class/typec//connector_orientation
&
On Wed, Oct 16, 2019 at 03:58:50PM +0300, Heikki Krogerus wrote:
> On Wed, Oct 16, 2019 at 11:43:14AM +0800, pumahsu wrote:
> > Export the Type-C cc orientation so that user space can
> > get this information.
>
> For what do you need this information in user space? I&
s-class-typec
> b/Documentation/ABI/testing/sysfs-class-typec
> index d7647b258c3c..419f952c991d 100644
> --- a/Documentation/ABI/testing/sysfs-class-typec
> +++ b/Documentation/ABI/testing/sysfs-class-typec
> @@ -108,6 +108,13 @@ Contact: Heikki Krogerus
>
> Description:
On Thu, Oct 10, 2019 at 02:16:23PM +0300, Heikki Krogerus wrote:
> In any case, do we leave this series as it is now, or should I add two
> patches to it - one that just removes device_connection_add/remove
> functions without any other changes, and another patch that remov
On Thu, Oct 10, 2019 at 11:32:23AM +0200, Hans de Goede wrote:
> Hi,
>
> On 10-10-2019 10:31, Heikki Krogerus wrote:
> > On Tue, Oct 08, 2019 at 05:02:04PM +0300, Heikki Krogerus wrote:
> > > On Tue, Oct 08, 2019 at 03:59:23PM +0200, Hans de Goede wrote:
> > > >
On Tue, Oct 08, 2019 at 05:02:04PM +0300, Heikki Krogerus wrote:
> On Tue, Oct 08, 2019 at 03:59:23PM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 08-10-2019 14:25, Heikki Krogerus wrote:
> > > Hi Hans,
> > >
> > > Fixed the compiler warning in
cy USB_ROLE_SWITCH for TYPEC_HD3SS3220.
>
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port
> controller")
> Reported-by: Hulk Robot
> Signed-off-by: Mao Wenan
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/Kconfig |
On Tue, Oct 08, 2019 at 03:59:23PM +0200, Hans de Goede wrote:
> Hi,
>
> On 08-10-2019 14:25, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > Fixed the compiler warning in this version. No other changes.
> >
> > The original cover letter:
> >
> &
Adding description for the device_is_available member which
was missing, and fixing the description of the member
property_read_int_array.
Signed-off-by: Heikki Krogerus
---
include/linux/fwnode.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/fwnode.h b
tle helper
usb_role_switch_find_by_fwnode() that uses
class_find_device_by_fwnode() to find the role switches.
thanks,
Heikki Krogerus (2):
usb: roles: Add usb_role_switch_find_by_fwnode()
extcon: axp288: Remove the build-in connection description
drivers/extcon/extcon-axp
Getting handle to the USB role switch by first finding its
software fwnode.
Signed-off-by: Heikki Krogerus
---
drivers/extcon/extcon-axp288.c | 38 --
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon
Simple wrapper function that searches USB role switches with
class_find_device_by_fwnode().
Signed-off-by: Heikki Krogerus
---
drivers/usb/roles/class.c | 21 +
include/linux/usb/role.h | 3 +++
2 files changed, 24 insertions(+)
diff --git a/drivers/usb/roles/class.c b
On Sun, Oct 06, 2019 at 09:37:25PM +0200, Hans de Goede wrote:
> Hi,
>
> On 01-10-2019 12:51, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > That AXP288 extcon driver is the last that uses build-in connection
> > description. I'm replacing it with a code tha
On Thu, Oct 03, 2019 at 10:51:38PM +0200, Hans de Goede wrote:
> Hi,
>
> On 03-10-2019 22:37, John Stultz wrote:
> > On Thu, Oct 3, 2019 at 2:25 AM Hans de Goede wrote:
> > > On 03-10-2019 01:16, John Stultz wrote:
> > > > From: Yu Chen
> > > >
> > > > This patch adds notifier for drivers want
On Thu, Oct 03, 2019 at 10:56:24PM +0200, Hans de Goede wrote:
> Hi,
>
> On 03-10-2019 22:45, John Stultz wrote:
> > On Thu, Oct 3, 2019 at 4:26 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Wed, Oct 02, 2019 at 11:16:16PM +, John Stultz wrote:
> > > > From: Yu Chen
> > > >
> > > > This
d the role switches.
thanks,
Heikki Krogerus (2):
usb: roles: Add usb_role_switch_find_by_fwnode()
extcon: axp288: Remove the build-in connection description
drivers/extcon/extcon-axp288.c | 38 --
drivers/usb/roles/class.c | 21 +++
inc
Getting handle to the USB role switch by first finding its
software fwnode.
Signed-off-by: Heikki Krogerus
---
drivers/extcon/extcon-axp288.c | 38 --
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon
Simple wrapper function that searches USB role switches with
class_find_device_by_fwnode().
Signed-off-by: Heikki Krogerus
---
drivers/usb/roles/class.c | 21 +
include/linux/usb/role.h | 3 +++
2 files changed, 24 insertions(+)
diff --git a/drivers/usb/roles/class.c b
annot create duplicate filename
'/devices/pci:00/:00:15.0/i2c_designware.0/i2c-0/i2c-INT3515-tps6598x.0'
Fixes: 2336dfadfb1e ("platform/x86: i2c-multi-instantiate: Allow to have same
slaves")
Cc: sta...@vger.kernel.org
Signed-off-by: Heikki Krogerus
---
drive
On Thu, Sep 19, 2019 at 06:48:32PM +0800, Kyle Tso wrote:
> Ping! Anyone still reviewing this patch?
> I have another change related to AMS.
> I will group them as a set and re-send it.
Please rebase resend the patch. It does not apply any more.
thanks,
--
heikki
On Tue, Sep 17, 2019 at 10:45:07PM +0300, Yauhen Kharuzhy wrote:
> Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
> hardware has TypeC connector and register related devices described as
> I2C connections in the _CRS resource.
>
> There is at least one hardware (Lenovo Yoga Book
On Wed, Sep 11, 2019 at 07:17:52PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> > On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> &g
On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> fd3f7275826f ("software node: Initialize the return value in
> software_node_find_by_name()")
>
> Fixes tag
>
> Fixes: 1666faedb567 ("software node: Add
> software_node_get_reference_args()")
>
On Fri, Sep 06, 2019 at 03:40:43PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 06, 2019 at 02:17:44PM +0300, Heikki Krogerus wrote:
> > On Thu, Sep 05, 2019 at 09:38:07PM -0700, Dmitry Torokhov wrote:
> > > It is possible to store references to software nodes in the same
Hi,
On Thu, Sep 05, 2019 at 09:38:08PM -0700, Dmitry Torokhov wrote:
> Now that static device properties allow defining reference properties
> together with all other types of properties, instead of managing them
> separately, let's adjust the driver.
>
> Signed-off-by: Dmitry Torokhov
> ---
>
On Thu, Sep 05, 2019 at 09:38:07PM -0700, Dmitry Torokhov wrote:
> It is possible to store references to software nodes in the same fashion as
> other static properties, so that users do not need to define separate
> structures:
>
> const struct software_node gpio_bank_b_node = {
> .name = "
elect REGMAP_I2C to fix this.
>
> Reported-by: Hulk Robot
> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery
> controllers")
> Signed-off-by: YueHaibing
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/Kconfig | 1 +
> 1 file changed
Hi Sakari,
On Mon, Sep 02, 2019 at 04:57:26PM +0300, Sakari Ailus wrote:
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index 951e7efd47c23..a4a0f5b80bad3 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -515,6 +515,25 @@ static int software_node_read_string_
e.
Reviewed-by: Heikki Krogerus ---
> drivers/base/swnode.c| 4 ++--
> include/linux/property.h | 3 ++-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index a7cb41812cfda..951e7efd47c23 100644
> --- a/driver
672f7 ("drivers: base: Introducing software nodes to the
> firmware node framework")
> Signed-off-by: Sakari Ailus
Reviewed-by: Heikki Krogerus
> ---
> drivers/base/swnode.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> dif
Carpenter
Signed-off-by: Heikki Krogerus
---
drivers/base/swnode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index 82dd69d72a64..3566079fa87d 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -722,7 +722,7 @@ st
Hi,
The patches now have a bit better commit messages (hopefully).
Rafael should take these since the patches that these fix are
in his tree.
thanks,
Heikki Krogerus (2):
software node: Initialize the return value in
software_node_to_swnode()
software node: Initialize the return value
ed-by: Dan Carpenter
Signed-off-by: Heikki Krogerus
---
drivers/base/swnode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index 024d3f54a8d6..82dd69d72a64 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -
On Fri, Aug 30, 2019 at 08:32:24AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 29, 2019 at 04:21:14PM +0300, Heikki Krogerus wrote:
> > Hi,
> >
> > Both potentially unitialized variable errors.
> >
> > Heikki Krogerus (2):
> > software node: Fix us
reported by smatch:
drivers/base/swnode.c:656 software_node_find_by_name() error: uninitialized
symbol 'swnode'.
drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol
'swnode'.
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
Signed-off
On Thu, Aug 29, 2019 at 04:21:16PM +0300, Heikki Krogerus wrote:
> reported by smatch:
> drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized
> symbol 'swnode'.
>
> Fixes: 80488a6b1d3c ("software node: Add support for static node descriptors&
reported by smatch:
drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol
'swnode'.
Fixes: 80488a6b1d3c ("software node: Add support for static node descriptors")
Cc: sta...@vger.kernel.org
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
S
Hi,
Both potentially unitialized variable errors.
Heikki Krogerus (2):
software node: Fix use of potentially uninitialized variable
software node: Fix use of potentially uninitialized variable
drivers/base/swnode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.23.0.rc1
reported by smatch:
drivers/base/swnode.c:656 software_node_find_by_name() error: uninitialized
symbol 'swnode'.
Reported-by: kbuild test robot
Reported-by: Dan Carpenter
Signed-off-by: Heikki Krogerus
---
drivers/base/swnode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
On Tue, Aug 27, 2019 at 01:54:18PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 02:49:18PM +0300, Heikki Krogerus wrote:
> > Matching function that compares every UUID in an array to a
> > given UUID with guid_equal().
> >
> > Signed-off-by: Heik
Matching function that compares every UUID in an array to a
given UUID with guid_equal().
Signed-off-by: Heikki Krogerus
---
Hi,
I don't have a user for these helpers, but since they are pretty
trivial, I figured that might as well propose them in any case.
Though, I think there was som
Since guid_t is the recommended data type for UUIDs in
kernel (and I guess uuid_le is meant to be ultimately
replaced with it), it should be made available here as
well.
Signed-off-by: Heikki Krogerus
---
scripts/mod/file2alias.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts
The driver for the Intel USB role mux now always supplies
software node for the role switch, so no longer checking
that, and never creating separate node for the role switch.
>From now on using software_node_find_by_name() function to
get the handle to the USB role switch.
Signed-off-by: Hei
Function that searches software nodes by node name.
Signed-off-by: Heikki Krogerus
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
Reviewed-by: Andy Shevchenko
---
drivers/base/swnode.c| 37 +
include/linux/property.h | 4
2 files changed, 41
the switch.
Signed-off-by: Heikki Krogerus
---
.../usb/roles/intel-xhci-usb-role-switch.c| 27 ++-
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c
b/drivers/usb/roles/intel-xhci-usb-role-switch.c
index
/3. I never properly destroyed the software
node when the mux was removed. That leak is now also fixed.
thanks,
Heikki Krogerus (3):
software node: Add software_node_find_by_name()
usb: roles: intel_xhci: Supplying software node for the role mux
platform/x86: intel_cht_int33fe: Use new API t
On Fri, Aug 16, 2019 at 04:45:50PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 16, 2019 at 1:45 PM Heikki Krogerus
> wrote:
> >
> > The primary purpose for this node will be to allow linking
> > the users of the switch to it. The users will be for example
> > USB Typ
e descriptor is copied during switch
registration in any case, so we don't need to store it in the driver.
I also noticed a bug in 2/3. I never properly destroyed the software
node when the mux was removed. That leak is now also fixed.
thanks,
Heikki Krogerus (3):
software node: Add softwa
The driver for the Intel USB role mux now always supplies
software node for the role switch, so no longer checking
that, and never creating separate node for the role switch.
>From now on using software_node_find_by_name() function to
get the handle to the USB role switch.
Signed-off-by: Hei
Function that searches software nodes by node name.
Signed-off-by: Heikki Krogerus
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
---
drivers/base/swnode.c| 37 +
include/linux/property.h | 4
2 files changed, 41 insertions(+)
diff --git a
the switch.
Signed-off-by: Heikki Krogerus
---
.../usb/roles/intel-xhci-usb-role-switch.c| 23 ++-
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c
b/drivers/usb/roles/intel-xhci-usb-role-switch.c
index
On Thu, Aug 15, 2019 at 03:55:40PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 15, 2019 at 2:32 PM Heikki Krogerus
> wrote:
> >
> > Function that searches software nodes by node name.
>
> > +/**
> > + * software_node_find_by_name - Find software node by na
Hi,
This helper makes it much more easier to access "external" nodes.
thanks,
Heikki Krogerus (3):
software node: Add software_node_find_by_name()
usb: roles: intel_xhci: Supplying software node for the role mux
platform/x86: intel_cht_int33fe: Use new API to gain access to th
the switch.
Signed-off-by: Heikki Krogerus
---
drivers/usb/roles/intel-xhci-usb-role-switch.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/roles/intel-xhci-usb-role-switch.c
b/drivers/usb/roles/intel-xhci-usb-role-switch.c
index 277de96181f9
The driver for the Intel USB role mux now always supplies
software node for the role switch, so no longer checking
that, and never creating separate node for the role switch.
>From now on using software_node_find_by_name() function to
get the handle to the USB role switch.
Signed-off-by: Hei
Function that searches software nodes by node name.
Signed-off-by: Heikki Krogerus
---
drivers/base/swnode.c| 35 +++
include/linux/property.h | 4
2 files changed, 39 insertions(+)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index
Hi,
> +real_role = cdsn3_real_role_switch_get(cdns->dev);
> +
> +current_role = role;
> +dev_dbg(cdns->dev, "Switching role");
> +
> +ret = cdns3_role_start(cdns, real_role);
> +if (ret) {
> +/* Back to
On Mon, Jul 29, 2019 at 10:31:04AM -0700, Guenter Roeck wrote:
> On Mon, Jul 29, 2019 at 05:04:57PM +0300, Heikki Krogerus wrote:
> > Hi,
> >
> > On Wed, Jul 24, 2019 at 09:30:37PM -0700, Guenter Roeck wrote:
> > > TCPM may receive PD messages associat
On Mon, Jul 29, 2019 at 03:15:32PM +0200, Dmitry Torokhov wrote:
> On Mon, Jul 29, 2019 at 03:07:15PM +0300, Heikki Krogerus wrote:
> > On Sat, Jul 13, 2019 at 12:52:58AM -0700, Dmitry Torokhov wrote:
> > > It is helpful to know what device, if any, a software node is tied to, so
Hi Dmitry,
On Sat, Jul 13, 2019 at 12:52:59AM -0700, Dmitry Torokhov wrote:
> Now that static device properties understand notion of child nodes, let's
> teach gpiolib to tie such children and machine GPIO descriptor tables.
> We will continue using a single table for entire device, but instead of
On Sat, Jul 13, 2019 at 12:52:58AM -0700, Dmitry Torokhov wrote:
> It is helpful to know what device, if any, a software node is tied to, so
> let's store a pointer to the device in software node structure. Note that
> children software nodes will inherit their parent's device pointer, so we
> do n
r to propagate to tps6598x_block_write(), so add
> the const qualifier there to avoid the warning.
>
> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery
> controllers")
> Signed-off-by: Nikolaus Voss
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/tps
ntrollers")
> Signed-off-by: Nikolaus Voss
Shouldn't this be applied to the stable trees as well?
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/tps6598x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tps6598x.c b/d
On Fri, Jun 28, 2019 at 10:12:35AM +0200, Nikolaus Voss wrote:
> 1. Portinfo bit field is 3 bits wide, not 2 bits. This led to
>a wrong driver configuration for some tps6598x configurations.
>
> 2. Writing 4CC commands with tps6598x_write_4cc() already has
>a pointer arg, don't reference i
Hi Chunfeng,
On Tue, Jun 11, 2019 at 04:44:39PM +0800, Chunfeng Yun wrote:
> Due to the requirement of usb-connector.txt binding, the old way
> using extcon to support USB Dual-Role switch is now deprecated
> when use Type-B connector.
> This patch introduces a driver of Type-B connector which typ
> Cc: "Rafael J. Wysocki"
> Cc: Heikki Krogerus
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Suzuki K Poulose
Acked-by: Heikki Krogerus
> ---
> drivers/usb/roles/class.c | 8 +---
> drivers/usb/typec/class.c | 8 +---
> include/linux/devi
Hi,
On Tue, Jun 11, 2019 at 09:44:23PM +0300, Andy Shevchenko wrote:
> +Cc: Heikki.
> Heikki, can you help here with swnodes?
>
> On Sat, Jun 1, 2019 at 5:17 PM Enrico Weigelt, metux IT consult
> wrote:
> >
> > Hi folks,
> >
> >
> > I'm looking for a way to inject fwnode data from a platform dri
Hi Pawel,
On Mon, Jun 10, 2019 at 06:33:29AM +, Pawel Laszczak wrote:
> >> +static ssize_t cdns3_mode_write(struct file *file,
> >> + const char __user *ubuf,
> >> + size_t count, loff_t *ppos)
> >> +{
> >> + struct seq_file *s = file->privat
Hi,
On Wed, May 29, 2019 at 03:43:44PM +0800, Chunfeng Yun wrote:
> From: Heikki Krogerus
>
> The fwnode_connection_find_match() function is exactly the
> same as device_connection_find_match(), except it takes
> struct fwnode_handle as parameter instead of struct device.
> Th
On Wed, Jun 05, 2019 at 11:03:49AM +0100, Pawel Laszczak wrote:
> diff --git a/drivers/usb/cdns3/debugfs.c b/drivers/usb/cdns3/debugfs.c
> new file mode 100644
> index ..dfcbeb5e14f8
> --- /dev/null
> +++ b/drivers/usb/cdns3/debugfs.c
> @@ -0,0 +1,173 @@
> +// SPDX-License-Identifier: G
represents the connector also on Intel CHT.
This makes it possible replace the fusb302 specific device
properties which were deprecated with the common USB
connector properties that tcpm.c is able to use directly.
Signed-off-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Reviewed-by: Hans de Goede
There is no reason why we should limit the use of
fwnode_get_named_child_node() to data nodes only.
Signed-off-by: Heikki Krogerus
Tested-by: Hans de Goede
---
drivers/acpi/property.c | 26 --
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi
Device property "fcs,max-sink-microwatt" is not used in
fusb302.c, so dropping it.
Signed-off-by: Heikki Krogerus
Reviewed-by: Andy Shevchenko
Reviewed-by: Hans de Goede
Tested-by: Hans de Goede
---
drivers/platform/x86/intel_cht_int33fe.c | 1 -
1 file changed, 1 deletion(-)
di
401 - 500 of 1317 matches
Mail list logo
