diferently, and also not catching the case where userspace
provides a bigger length and bytesused then the underlying buffer.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
Hello,
As discussed on
https://patchwork.linuxtv.org/project/linux-media/patch/gh5kef5bkeel3o6b2dkgc2dfagu9klj
Hi Laurent,
On 3/25/21 7:53 AM, Laurent Pinchart wrote:
Hi Helen,
On Wed, Mar 24, 2021 at 09:17:11PM -0300, Helen Koike wrote:
Always use dmabuf size when considering the length of the buffer.
Discard userspace provided length.
Fix length check error in _verify_length(), which was handling
provides a bigger length and bytesused then the underlying buffer.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
Hello,
As discussed on
https://patchwork.linuxtv.org/project/linux-media/patch/gh5kef5bkeel3o6b2dkgc2dfagu9klj...@4ax.com/
This patch also helps the conversion layer
then the underlying buffer.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
Hello,
As discussed on
https://patchwork.linuxtv.org/project/linux-media/patch/gh5kef5bkeel3o6b2dkgc2dfagu9klj...@4ax.com/
This patch also helps the conversion layer of the Ext API patchset,
where we are not exposing
Since we always use the size of the underlying buffer for dmabuf, remove
the size parameter from the attach_dmabuf() callback.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
drivers/media/common/videobuf2/videobuf2-core.c | 2 +-
drivers/media/common/videobuf2/videobuf2-dma
Hi Hans,
Thank you for your comment, please see my reply below.
On 2/23/21 9:35 AM, Hans Verkuil wrote:
Hi Helen,
On 14/01/2021 19:07, Helen Koike wrote:
This is part of the multiplanar and singleplanar unification process.
v4l2_ext_pix_format is supposed to work for both cases.
We also add
On 2/17/21 3:22 PM, Hans Verkuil wrote:
On 17/02/2021 19:11, Helen Koike wrote:
The script was trying to load vivid and run some commands on top of it
even when $vivid = 0.
Wrap all vivid code under $vivid variable.
Signed-off-by: Helen Koike
---
contrib/test/test-media | 66
The script was trying to load vivid and run some commands on top of it
even when $vivid = 0.
Wrap all vivid code under $vivid variable.
Signed-off-by: Helen Koike
---
contrib/test/test-media | 66 -
1 file changed, 33 insertions(+), 33 deletions(-)
diff
hy_config = *config;
+ dsi->lane_mbps = div_u64(config->hs_clk_rate, 1000 * 1000 * 1);
+
+ return 0;
+}
+
+static int dw_mipi_dsi_dphy_power_on(struct phy *phy)
+{
+ struct dw_mipi_dsi_rockchip *dsi = phy_get_drvdata(phy);
+ int i, ret;
It seems "i" coul
Hello,
On 1/14/21 3:07 PM, Helen Koike wrote:
> Hello,
>
> This is v6 of the Extended API for formats and buffers (see below the new
> API).
>
> The new API comes for free for old drivers through the conversion layer, which
> is independent of vb2.
>
> I completly
On 1/25/21 6:31 AM, Hans Verkuil wrote:
> On 14/01/2021 19:01, Helen Koike wrote:
>> sizeimage field should be set to zero for unused planes, even when
>> v4l2_pix_format_mplane.num_planes is smaller then the index of planes.
>
> then -> than
Ack.
>
>&
YUV 4:4:4 is not subsampled, fix this in the docs.
Fixes: da785536e007 ("media: doc: pixfmt-yuv: Move all semi-planar YUV formats
to common file")
Signed-off-by: Helen Koike
---
Changes in v2:
- s/No sub-sampling/The chroma plane is not subsampled/ (Laurent)
- Fixed description
On 1/25/21 10:57 AM, Helen Koike wrote:
>
>
> On 1/23/21 6:56 AM, Laurent Pinchart wrote:
>> Hi Helen,
>>
>> Thank you for the patch.
>>
>> On Fri, Jan 22, 2021 at 03:27:23PM -0300, Helen Koike wrote:
>>> YUV 4:4:4 is not subsampled, fix this
On 1/23/21 6:56 AM, Laurent Pinchart wrote:
> Hi Helen,
>
> Thank you for the patch.
>
> On Fri, Jan 22, 2021 at 03:27:23PM -0300, Helen Koike wrote:
>> YUV 4:4:4 is not subsampled, fix this in the docs.
>>
>> Fixes: da785536e007 ("media: doc: pixfmt-yuv
YUV 4:4:4 is not subsampled, fix this in the docs.
Fixes: da785536e007 ("media: doc: pixfmt-yuv: Move all semi-planar YUV formats
to common file")
Signed-off-by: Helen Koike
---
Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst | 4 ++--
1 file changed, 2 insertions(+), 2
-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
- Update with new format and buffer structs
- duplicate v4l2_ioctl_ops for touch devices.
Changes in v4:
- Update with new format and buffer structs
- Rebased on top of media/master (post 5.8-rc1)
Changes in v3:
- Rebased on top
Add documentation and update references in current documentation for the
Extended API.
Signed-off-by: Helen Koike
---
Changes in v6:
- Update note saying ext_api should be used for new applications on
newer kernels (Tomasz and Hans)
- Fix typos pointed in v5 (Hand and Tomasz)
- Change order
Simplify Multi/Single planer API handling by converting to v4l2_ext_pix_format.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
- Update with new format and buffer structs
Changes in v4:
- Update with new format and buffer structs
- Rebased on top of media/master
Just a new version of v4l2_fill_mbus_format() and v4l2_fill_ext_pix_format()
to deal with the new v4l2_ext_pix_format struct.
This is needed to convert the VIMC driver to the EXT_FMT/EXT_BUF iocts.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
- Rename
Add vb2 ext hooks and call vb2_set_pixelformat().
This allows more flexibility with buffer handling.
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch to exemplify how drivers would easily support features from Ext Buf
---
drivers/media/test-drivers/vimc/vimc-capture.c | 3 +++
1 file
oad() into color planes
when a single memory buffer is used.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
This patch is based on original "media: videobuf2: Expose helpers to implement
the _ext_fmt and _ext_buf hooks"
- This patch was complet
Add vb2 ext hooks and call vb2_set_pixelformat().
This allows more flexibility with buffer handling.
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch to exemplify how drivers would easily support features from Ext Buf
---
drivers/media/test-drivers/vivid/vivid-core.c| 2 ++
drivers
of the
v4l2_buffer object, making it undependent of this struct.
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch
---
.../media/common/videobuf2/videobuf2-v4l2.c | 176 ++
1 file changed, 97 insertions(+), 79 deletions(-)
diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2
in the reserved area if needed or
use the Request API to collect more metadata information from the
frame.
Signed-off-by: Hans Verkuil
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
This patch was completely refactored, and based on previous version from
Hans and Boris
the
_ext_ hooks.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
The main change here was fixing the conversion, so planes reflects color
planes,
and to implement this properly I made major refactors compared to the previous
version.
- struct
Add normalization to pixelformats, so we can fallback to it when using
Ext API, and eliminating the handling of two variantes (M and non-M
formats).
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch
---
drivers/media/v4l2-core/v4l2-common.c | 16
include/media/v4l2
sed;
union {
__u32 mmap_offset;
__u64 userptr;
__s32 dmabuf_fd;
} m;
__u32 reserved[6];
};
Helen Koike (11):
media: v4l2-common: add normalized pixelformat field to struct
v4l2_format_info
media: v4l2: Extend pixe
Print capabilities field from struct v4l2_create_buffers for better
debugging.
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2
request_fd is validated under media_request_get_by_fd() just below this
check. Thus remove it.
Suggested-by: Tomasz Figa
Signed-off-by: Helen Koike
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/common/videobuf2
sizeimage field should be set to zero for unused planes, even when
v4l2_pix_format_mplane.num_planes is smaller then the index of planes.
Signed-off-by: Helen Koike
---
I caught this with v4l2-compliance, which throws an error if we dirty
planes, even if invalid, so I would like to make
On 11/20/20 10:20 AM, Hans Verkuil wrote:
> On 20/11/2020 13:40, Tomasz Figa wrote:
>> On Fri, Nov 20, 2020 at 9:24 PM Hans Verkuil wrote:
>>>
>>> On 20/11/2020 12:06, Tomasz Figa wrote:z
>>>> Hi Helen,
>>>>
>>>> On Tue,
Just minor things.
Add capabilities to v4l_print_create_buffers(), clarify docs and remove
a redundant check.
Helen Koike (3):
media: v4l2-ioctl: print capabilities in v4l_print_create_buffers()
media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when
to set to zero
media
Hi Tomasz,
On 12/21/20 12:13 AM, Tomasz Figa wrote:
> On Thu, Dec 17, 2020 at 10:20 PM Helen Koike
> wrote:
>>
>> Hi Tomasz,
>>
>> Thanks for your comments, I have a few questions below.
>>
>> On 12/16/20 12:13 AM, Tomasz Figa wrote:
>>> On Tu
Hi Tomasz,
Thanks for your comments, I have a few questions below.
On 12/16/20 12:13 AM, Tomasz Figa wrote:
> On Tue, Dec 15, 2020 at 11:37 PM Helen Koike
> wrote:
>>
>> Hi Tomasz,
>>
>> On 12/14/20 7:46 AM, Tomasz Figa wrote:
>>> On Fri, Dec 4,
Hi Tomasz,
On 12/14/20 7:46 AM, Tomasz Figa wrote:
> On Fri, Dec 4, 2020 at 4:52 AM Helen Koike wrote:
>>
>> Hi,
>>
>> Please see my 2 points below (about v4l2_ext_buffer and another about
>> timestamp).
>>
>> On 12/3/20 12:11 PM, Hans Verkuil wrot
Hi Tomasz,
Thank you for your comments,
On 12/14/20 7:36 AM, Tomasz Figa wrote:
> On Tue, Nov 24, 2020 at 5:33 AM Helen Koike wrote:
>>
>> Hi Tomasz,
>>
>>
>> On 11/20/20 8:14 AM, Tomasz Figa wrote:
>>> Hi Helen,
>>>
>>> On Tue, Au
Hi Tomasz,
Thank you for your comments,
On 12/14/20 5:52 AM, Tomasz Figa wrote:
> Hi Helen,
>
> On Tue, Aug 04, 2020 at 04:29:35PM -0300, Helen Koike wrote:
>> The VB2 layer is used by a lot of drivers. Patch it to support the
>> _EXT_PIX_FMT and _EXT_BUF ioctls in ord
Hi,
Please see my 2 points below (about v4l2_ext_buffer and another about
timestamp).
On 12/3/20 12:11 PM, Hans Verkuil wrote:
> On 23/11/2020 18:40, Helen Koike wrote:
>>
>>
>> On 11/23/20 12:46 PM, Tomasz Figa wrote:
>>> On Tue, Nov 24, 2020 at 12:08 AM Helen K
te this code.
>
> Signed-off-by: Dan Carpenter
Since the debugfs_create_*() functions already check the parent
with IS_ERR(), this looks good to me.
Acked-by: Helen Koike
Thanks
Helen
> ---
> v2: Fix subject
>
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 4
Hi Dan,
On 12/1/20 11:27 AM, Dan Carpenter wrote:
> On Mon, Nov 30, 2020 at 11:20:05AM -0300, Helen Koike wrote:
>> Hi Dan,
>>
>> Thank you for your patch.
>>
>> On 11/30/20 9:53 AM, Dan Carpenter wrote:
>>> The debugfs_create_dir() function never return
Hi Dan,
Thank you for your patch.
On 11/30/20 9:53 AM, Dan Carpenter wrote:
> The debugfs_create_dir() function never returns NULLs. It's not supposed
> to checked for errors in the normal case and there is no need to check
> in this function so let's just delete this dead code.
>
>
Hello,
On 8/4/20 4:29 PM, Helen Koike wrote:
> Hello,
>
> This is v5 of the Extended API for formats and buffers, which introduces
> the following new ioctls:
>
> int ioctl(int fd, VIDIOC_G_EXT_PIX_FMT, struct v4l2_ext_pix_format *argp)
> int ioctl(int fd, VIDIOC_
Hi Peilin,
On 11/26/20 9:21 AM, Peilin Ye wrote:
> Fix 4 typos under drivers/media/platform/rockchip/rkisp1/ found by
> checkpatch, including the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macro
> definitions.
>
> Signed-off-by: Peilin Ye
Thanks
Acked-by: Helen Koike
> ---
Hi Tomasz,
On 11/20/20 8:14 AM, Tomasz Figa wrote:
> Hi Helen,
>
> On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote:
>> From: Hans Verkuil
>>
>> Those extended buffer ops have several purpose:
>> 1/ Fix y2038 issues by converting the timestamp into
On 11/23/20 12:46 PM, Tomasz Figa wrote:
> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike
> wrote:
>>
>> Hi Hans,
>>
>> Thank you for your review.
>>
>> On 9/9/20 9:27 AM, Hans Verkuil wrote:
>>> Hi Helen,
>>>
>>> Again I'm ju
Hi Hans,
Thank you for your review.
On 9/9/20 9:27 AM, Hans Verkuil wrote:
> Hi Helen,
>
> Again I'm just reviewing the uAPI.
>
> On 04/08/2020 21:29, Helen Koike wrote:
>> From: Hans Verkuil
>>
>> Those extended buffer ops have several purpose:
>
h
> most closely matches the cr50 i2c protocol behavior.
>
> Cc: Helen Koike
> Signed-off-by: Duncan Laurie
> [swb...@chromium.org: Depend on i2c even if it's a module, replace
> boilier plate with SPDX tag, drop asm/byteorder.h include, simplify
> return from probe]
&g
Hi Alexandre,
Thanks for your review.
On 8/14/20 4:49 AM, Alexandre Courbot wrote:
> On Wed, Aug 5, 2020 at 4:32 AM Helen Koike wrote:
>>
>> This is part of the multiplanar and singleplanar unification process.
>> v4l2_ext_pix_format is supposed to work for both cas
On 11/19/20 7:08 AM, Helen Koike wrote:
> Hi Tomasz,
>
> On 11/19/20 2:45 AM, Tomasz Figa wrote:
>> On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote:
>>> Hi Tomasz,
>>>
>>> On 10/2/20 4:49 PM, Tomasz Figa wrote:
>>>> Hi Hel
On 8/4/20 4:29 PM, Helen Koike wrote:
> Add documentation and update references in current documentation for the
> Extended API.
>
> Signed-off-by: Helen Koike
> ---
> Changes in v5:
> - new patch
>
> .../userspace-api/media/v4l/buffer.rst| 5 +
>
Hi Tomasz,
On 11/19/20 2:45 AM, Tomasz Figa wrote:
> On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote:
>> Hi Tomasz,
>>
>> On 10/2/20 4:49 PM, Tomasz Figa wrote:
>>> Hi Helen,
>>>
>>> On Tue, Aug 04, 2020 at 04:29:33PM -030
Hi Stephen,
On 11/18/20 2:32 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the v4l-dvb tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> Documentation/output/videodev2.h.rst:6: WARNING: undefined label:
> v4l2-meta-fmt-rk-isp1-params (if the link has no caption
(if the link has no caption the label must
precede a section header)
Fixes: df22026aebd8 ("media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer
format")
Signed-off-by: Helen Koike
Reported-by: Stephen Rothwell
---
Documentation/admin-guide/media/rkisp1.rst
Hi Tomasz,
On 10/2/20 4:49 PM, Tomasz Figa wrote:
> Hi Helen,
>
> On Tue, Aug 04, 2020 at 04:29:33PM -0300, Helen Koike wrote:
>> This is part of the multiplanar and singleplanar unification process.
>> v4l2_ext_pix_format is supposed to work for both cases.
>>
mp_stop_timeout or sp_stop_timeout will
be incremented.
Fixes: 37db540bb9d1f ("media: staging: rkisp1: cap: refactor enable/disable
stream to allow multistreaming")
Signed-off-by: Helen Koike
---
drivers/staging/media/rkisp1/rkisp1-capture.c | 4 ++--
1 file changed, 2 insertions(+), 2
x.io/2Csk
> v4l2-compliance -v -d /dev/video0 -s10
http://ix.io/2Csq
> v4l2-compliance -v -d /dev/video1 -s10
http://ix.io/2Css
Helen Koike (1):
media: rockchip: rkisp1: destage Rockchip ISP1 driver
Shunqian Zheng (1):
media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format
...
From: Shunqian Zheng
Add the Rockchip ISP1 specific processing parameter format
V4L2_META_FMT_RK_ISP1_PARAMS and metadata format
V4L2_META_FMT_RK_ISP1_STAT_3A for 3A.
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen Koike
Reviewed-by: Laurent Pinchart
---
Hello
/devicetree/bindings/media/rockchip-isp1.yaml
Fields of MAINTAINERS file sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
[dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging]
Acked-by: Rob
On 11/4/20 3:45 PM, Maxime Ripard wrote:
> On Wed, Nov 04, 2020 at 01:38:08PM -0300, Helen Koike wrote:
>>
>>
>> On 11/4/20 8:17 AM, Paul Kocialkowski wrote:
>>> Hi,
>>>
>>> On Mon 02 Nov 20, 10:21, Maxime Ripard wrote:
>>>>
On 11/4/20 8:17 AM, Paul Kocialkowski wrote:
> Hi,
>
> On Mon 02 Nov 20, 10:21, Maxime Ripard wrote:
>> On Fri, Oct 30, 2020 at 07:45:18PM -0300, Helen Koike wrote:
>>> On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
>>>> The A31 MIPI CSI-2 controller
Hi Paul,
On 11/4/20 8:11 AM, Paul Kocialkowski wrote:
> Hi Helen,
>
> On Fri 30 Oct 20, 19:44, Helen Koike wrote:
>> Hi Paul,
>>
>> I have some comments through the series, I hope this helps.
>
> Thanks for your comments :)
>
>> On 10/23/20 2:45 PM
Hello,
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> The Allwinner A31 D-PHY supports both Rx and Tx modes. While the latter
> is already supported and used for MIPI DSI this adds support for the
> former, to be used with MIPI CSI-2.
>
> This implementation is inspired by the Allwinner BSP
Hi Paul,
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> Both 10 and 12-bit Bayer formats are stored aligned as 16-bit values
> in memory, not unaligned 10 or 12 bits.
>
> Since the current code for retreiving the bpp is used only to
> calculate the memory storage size of the picture (which is
Hi Paul,
I have some comments through the series, I hope this helps.
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> This series introduces support for MIPI CSI-2, with the A31 controller that is
> found on most SoCs (A31, V3s and probably V5) as well as the A83T-specific
> controller. While the
Hi Paul,
On 10/23/20 2:45 PM, Paul Kocialkowski wrote:
> The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 controller
> found on Allwinner SoCs such as the A31 and V3/V3s.
>
> It is a standalone block, connected to the CSI controller on one side
> and to the MIPI D-PHY block on the other.
sensor->lanes, cfg);
> - phy_set_mode(sensor->dphy, PHY_MODE_MIPI_DPHY);
> + phy_set_mode_ext(cdev->dphy, PHY_MODE_MIPI_DPHY,
> + PHY_MIPI_DPHY_SUBMODE_RX);
>From rkisp1 pov, looks good to me
Acked-by: Helen Koike
Regards,
He
rkisp1 was moved out of staging, update MAINTAINERS file accordingly.
Signed-off-by: Helen Koike
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9e23b20eb2a21..6691c5d3e974b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
s://patchwork.linuxtv.org/project/linux-media/patch/20201020193850.1460644-2-helen.ko...@collabora.com/
You can also see all of them applied in this branch:
https://gitlab.collabora.com/koike/linux/-/tree/rockchip/isp/destage
Thanks
Helen
Helen Koike (2):
media: rockchip: rkisp1: destage Roc
All the items in the TODO list were addressed, uapi was reviewed,
documentation written, checkpatch errors fixed, several bugs fixed.
There is no big reason to keep this driver in staging, so move it out.
Signed-off-by: Helen Koike
---
.../media/v4l/pixfmt-meta-rkisp1.rst | 2
From: Shunqian Zheng
Add the Rockchip ISP1 specific processing parameter format
V4L2_META_FMT_RK_ISP1_PARAMS and metadata format
V4L2_META_FMT_RK_ISP1_STAT_3A for 3A.
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen Koike
Reviewed-by: Laurent Pinchart
---
Hello
Hi Dafna,
On 10/26/20 2:50 PM, Dafna Hirschfeld wrote:
> Hi,
>
>
> Am 19.10.20 um 18:04 schrieb Helen Koike:
>> Allow streaming from self picture path and main picture path at the same
>> time.
>>
>> Take care for s_stream() callbacks to not be called twice.
All the items in the TODO list were addressed, uapi was reviewed,
documentation written, checkpatch errors fixed, several bugs fixed.
There is no big reason to keep this driver in staging, so move it out.
Signed-off-by: Helen Koike
---
.../media/v4l/pixfmt-meta-rkisp1.rst | 2
.@collabora.com/
You can also see all of them applied in this branch:
https://gitlab.collabora.com/koike/linux/-/tree/rockchip/isp/destage
Thanks
Helen
Helen Koike (1):
media: rockchip: rkisp1: destage Rockchip ISP1 driver
Shunqian Zheng (1):
media: videodev2.h, v4l2-ioctl: add
From: Shunqian Zheng
Add the Rockchip ISP1 specific processing parameter format
V4L2_META_FMT_RK_ISP1_PARAMS and metadata format
V4L2_META_FMT_RK_ISP1_STAT_3A for 3A.
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen Koike
Reviewed-by: Laurent Pinchart
---
Hello
Hi Rob,
On 10/20/20 12:14 PM, Rob Herring wrote:
> On Wed, Oct 14, 2020 at 11:46 AM Helen Koike
> wrote:
>>
>> Hi Rob,
>>
>> Thnaks for your reply.
>>
>> On 9/22/20 11:24 AM, Rob Herring wrote:
>>> On Wed, Jul 22, 2020 at 9:56 AM Helen Ko
From: Shunqian Zheng
RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi
Verified with:
make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
Signed-off-by: Helen
-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../Documentation/devicetree/bindings/media/rockchip-isp1.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
b/drivers
From: Eddie Cai
Enable ISP and camera sensor ov2685 and ov5695 for Scarlet Chromebook
Verified with:
make ARCH=arm64 dtbs_check
Signed-off-by: Shunqian Zheng
Signed-off-by: Eddie Cai
Signed-off-by: Tomasz Figa
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
.../boot/dts
Organize properties order in dt-bindings to move it out of staging.
On top: compatible, reg and interrupts.
Then alphabetical order, then properties starting with '#'.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../bindings/media/rockchip-isp1.yaml
Move rkisp1 bindings to Documentation/devicetree/bindings/media
Verified with:
make ARCH=arm64 dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../devicetree/bindings
The Rockchip ISP bindings was moved out of staging.
Update MAINTAINERS file with the new path.
Fields sorted according to output of
./scripts/parse-maintainers.pl --input=MAINTAINERS --output=MAINTAINERS
--order
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
MAINTAINERS | 2 ++
1
hclk_isp1_wrapper
aclk_isp0_wrapper
aclk_isp0_noc
hclk_isp0
hclk_isp0_wrapper
hclk_isp0_noc
pclkin_isp1_wrapper
Signed-off-by: Helen Koike
Reviewed-by: Tomasz Figa
---
Changes in V6:
- Define clocks in the top
Add missing required items in Rockchip ISP1 dt-bindings example for
a complete i2c node.
Drop unit address to Fix error:
/example-0/parent/i2c@ff16: node has a unit name, but no reg or ranges
property
Remove unecessary fields for the example.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Add missing required nodes in json-schema yaml file for
Rockchip ISP1 dt-bindings.
Signed-off-by: Helen Koike
Acked-by: Rob Herring
Reviewed-by: Tomasz Figa
---
.../devicetree/bindings/media/rockchip-isp1.yaml | 8
1 file changed, 8 insertions(+)
diff --git
a/drivers
, as sugested by Johan Jonker in v1,
before moving them out of staging.
Eddie Cai (1):
arm64: dts: rockchip: add isp and sensors for Scarlet
Helen Koike (7):
media: staging: dt-bindings: rkisp1: add missing required nodes
media: staging: dt-bindings: rkisp1: drop i2c unit address
media:
-by: Helen Koike
---
Hello,
Since we didn't reach an agreement on the helpers in the core[1], I'm
sending this patch to fix this limitation only for rkisp1.
[1]
https://patchwork.linuxtv.org/project/linux-media/cover/20200415013044.1778572-1-helen.ko...@collabora.com/
If we decide to add
Hello,
On 10/16/20 3:11 PM, Helen Koike wrote:
>
>
> On 10/16/20 11:28 AM, Dafna Hirschfeld wrote:
>> Hi,
>>
>> Am 15.10.20 um 21:57 schrieb Helen Koike:
>>> Allow streaming from self picture path and main picture path at the same
>>> tim
Hi Tomasz.
On 10/16/20 11:53 AM, Tomasz Figa wrote:
> On Fri, Oct 16, 2020 at 4:28 PM Dafna Hirschfeld
> wrote:
>>
>> Hi,
>>
>> Am 15.10.20 um 21:57 schrieb Helen Koike:
>>> Allow streaming from self picture path and main picture path at the same
&
On 10/16/20 11:28 AM, Dafna Hirschfeld wrote:
> Hi,
>
> Am 15.10.20 um 21:57 schrieb Helen Koike:
>> Allow streaming from self picture path and main picture path at the same
>> time.
>>
>> Take care for s_stream() callbacks to not be called twice.
>>
.
Remove multistreaming item from the TODO list.
Signed-off-by: Helen Koike
---
Hello,
Since we didn't reach an agreement on the helpers in the core[1], I'm
sending this patch to fix this limitation only for rkisp1.
[1]
https://patchwork.linuxtv.org/project/linux-media/cover
Thank you Tomasz and Robin for your comments,
On 10/14/20 1:43 PM, Tomasz Figa wrote:
> On Wed, Oct 14, 2020 at 6:27 PM Helen Koike wrote:
>>
>> Hi Tomasz,
>>
>> On 9/26/20 10:00 AM, Tomasz Figa wrote:
>>> Hi Helen,
>>>
>>> On Wed, Jul 22,
Hi Rob,
Thnaks for your reply.
On 9/22/20 11:24 AM, Rob Herring wrote:
> On Wed, Jul 22, 2020 at 9:56 AM Helen Koike wrote:
>>
>> aclk_isp_wrap is a child of aclk_isp, and hclk_isp_wrap is a child of
>> hclk_isp, thus we can remove parents from the list.
>>
>>
Hi Tomasz,
On 9/26/20 10:00 AM, Tomasz Figa wrote:
> Hi Helen,
>
> On Wed, Jul 22, 2020 at 12:55:32PM -0300, Helen Koike wrote:
>> From: Shunqian Zheng
>>
>> RK3399 has two ISPs, but only isp0 was tested.
>> Add isp0 node in rk3399 dtsi
>>
>>
Hi Hans,
On 9/9/20 8:41 AM, Hans Verkuil wrote:
> Hi Helen,
>
> Some review comments, concentrating on the uAPI.
>
> On 04/08/2020 21:29, Helen Koike wrote:
>> This is part of the multiplanar and singleplanar unification process.
>> v4l2_ext_pix_format is supp
Add Dafna Hirschfeld to rkisp1 maintainers list
Signed-off-by: Helen Koike
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index deaafb617361c..3deb954b2bb5d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14858,6 +14858,7 @@ F: include/linux
t; Hi Dafna,
>>>>
>>>> On 28/07/2020 15:00, Dafna Hirschfeld wrote:
>>>>>
>>>>>
>>>>> On 28.07.20 14:07, Dafna Hirschfeld wrote:
>>>>>> Hi
>>>>>>
>>>>>> On 28.07.
On 8/4/20 4:29 PM, Helen Koike wrote:
> Hello,
>
> This is v5 of the Extended API for formats and buffers, which introduces
> the following new ioctls:
>
> int ioctl(int fd, VIDIOC_G_EXT_PIX_FMT, struct v4l2_ext_pix_format *argp)
> int ioctl(int fd, VIDIOC_
Brezillon
Signed-off-by: Helen Koike
---
Changes in v5:
- migrate memory from v4l2_ext_buffer to v4l2_ext_plane
- return mem_offset to struct v4l2_ext_plane
- change sizes and reorder fields to avoid holes in the struct and make
it the same for 32 and 64 bits
Changes in v4:
- Use
Add documentation and update references in current documentation for the
Extended API.
Signed-off-by: Helen Koike
---
Changes in v5:
- new patch
.../userspace-api/media/v4l/buffer.rst| 5 +
.../userspace-api/media/v4l/common.rst| 1 +
.../userspace-api/media/v4l/dev
Just a new version of v4l2_fill_mbus_format() and v4l2_fill_ext_pix_format()
to deal with the new v4l2_ext_pix_format struct.
This is needed to convert the VIMC driver to the EXT_FMT/EXT_BUF iocts.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v4:
- Add helper
1 - 100 of 459 matches
Mail list logo
