Re: [PATCH net-next v9] virtio_net: Support RX hash XDP hint

2024-04-17 Thread Heng Qi
-by: Heng Qi Thanks. --- Changes from v8: - move max table macro out of uAPI Changes from v7: - use table lookup for rss hash type Changes from v6: - fix a coding style issue Changes from v5: - Preservation of the hash value has been dropped, following the conclusion from discussions

Re: [PATCH net-next v8] virtio_net: Support RX hash XDP hint

2024-04-16 Thread Heng Qi
在 2024/4/16 下午2:19, Liang Chen 写道: The RSS hash report is a feature that's part of the virtio specification. Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost (still a work in progress as per [1]) support this feature. While the capability to obtain the RSS hash has

Re: [PATCH v4] vp_vdpa: don't allocate unused msix vectors

2024-04-09 Thread Heng Qi
vp_modern_config_vector(mdev, msix_vec); vp_vdpa->config_irq = irq; return 0; Reviewed-by: Heng Qi

Re: [PATCH net v3] virtio_net: Do not send RSS key if it is not supported

2024-04-03 Thread Heng Qi
: * Got some good feedback from and Xuan Zhuo and Heng Qi, and reworked the rejection path. --- drivers/net/virtio_net.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index c22d1118

Re: [PATCH net v3] virtio_net: Do not send RSS key if it is not supported

2024-03-31 Thread Heng Qi
el.org Cc: qemu-de...@nongnu.org Signed-off-by: Breno Leitao --- Changelog: V2: * Moved from creating a valid packet, by rejecting the request completely V3: * Got some good feedback from and Xuan Zhuo and Heng Qi, and reworked the rejection path. --- drivers/net/virtio_net.c |

Re: [PATCH net v2 1/2] virtio_net: Do not set rss_indir if RSS is not supported

2024-03-28 Thread Heng Qi
her has_rss or has_rss_hash_report is available, but, it should only be set if has_rss is set. On the virtnet_set_rxfh(), return an invalid command if the request has indirection table set, but virtnet does not support RSS. Suggested-by: Heng Qi Signed-off-by: Breno Leitao --- drivers/

Re: [PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-26 Thread Heng Qi
ems to work better. Or squash them into one patch. Apart from these and Xuan's comments. For series:         Reviewed-by: Heng Qi Regards, Heng if (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE && rxfh->hfunc != ETH_RSS_HASH_TOP) return -EOPNOTSUPP;

Re: [PATCH] virtio_net: Do not send RSS key if it is not supported

2024-03-25 Thread Heng Qi
_indirection_table_length)); +   } + +   if (vi->has_rss || vi->has_rss_hash_report) {     vi->rss_key_size =     virtio_cread8(vdev, offsetof(struct virtio_net_config, rss_max_key_size)); Regards, Heng @Heng Qi Could you help us? Thanks. if (

Re: [RFC PATCH 0/2] net: provides dim profile fine-tuning channels

2024-03-14 Thread Heng Qi
在 2024/3/15 上午2:49, Jakub Kicinski 写道: On Thu, 14 Mar 2024 21:09:31 +0800 Heng Qi wrote: The NetDIM library provides excellent acceleration for many modern network cards. However, the default profiles of DIM limits its maximum capabilities for different NICs, so providing a channel through

[RFC PATCH 1/2] net: add sysfs attributes for customized dim profile management

2024-03-14 Thread Heng Qi
ponse: "Profile is default and not customized by the device." Signed-off-by: Heng Qi --- Documentation/ABI/testing/sysfs-class-net | 17 +++ include/linux/dim.h | 7 ++ include/linux/netdevice.h | 35 ++ lib/dim/net_dim.c

[RFC PATCH 0/2] net: provides dim profile fine-tuning channels

2024-03-14 Thread Heng Qi
The NetDIM library provides excellent acceleration for many modern network cards. However, the default profiles of DIM limits its maximum capabilities for different NICs, so providing a channel through which the NIC can be custom configured is necessary. Please review, thank you very much! Heng

[RFC PATCH 2/2] virtio-net: support net sysfs to fine-tune dim profile

2024-03-14 Thread Heng Qi
Virtio-net has different types of back-end device implementations. In order to effectively optimize the dim library's gains for different device implementations, let's use the interface provided by net-sysfs to fine-tune the profile list. Signed-off-by: Heng Qi --- drivers/net/virtio_net.c | 64

Re: [PATCH v2 2/3] virtio_net: Add missing virtio header in skb for XDP_PASS

2024-01-24 Thread Heng Qi
在 2024/1/24 下午4:57, Liang Chen 写道: For the XDP_PASS scenario of the XDP path, the skb constructed with xdp_buff does not include the virtio header. Adding the virtio header information back when creating the skb. Signed-off-by: Liang Chen --- drivers/net/virtio_net.c | 6 ++ 1 file

Re: [PATCH] virtio_net: Support RX hash XDP hint

2024-01-22 Thread Heng Qi
Hi Liang Chen, 在 2024/1/22 下午6:22, Liang Chen 写道: The RSS hash report is a feature that's part of the virtio specification. Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost (still a work in progress as per [1]) support this feature. While the capability to obtain the RSS