Re: [PATCH v1 6/7] mfd: lpc_ich: Add support for pinctrl in non-ACPI system

2021-04-13 Thread Henning Schild
Am Mon, 12 Apr 2021 20:34:45 +0300 schrieb Andy Shevchenko : > On Mon, Apr 12, 2021 at 07:16:53PM +0200, Henning Schild wrote: > > Am Mon, 12 Apr 2021 19:59:05 +0300 > > schrieb Andy Shevchenko : > > > On Mon, Apr 12, 2021 at 06:40:01PM +0200, Henning Schild wrot

Re: [PATCH v1 6/7] mfd: lpc_ich: Add support for pinctrl in non-ACPI system

2021-04-12 Thread Henning Schild
Am Mon, 12 Apr 2021 19:51:42 +0300 schrieb Andy Shevchenko : > On Mon, Apr 12, 2021 at 06:01:06PM +0200, Henning Schild wrote: > > Am Mon, 8 Mar 2021 14:20:19 +0200 > > schrieb Andy Shevchenko : > > > > > From: Tan Jui Nee > > > > > >

Re: [PATCH v1 6/7] mfd: lpc_ich: Add support for pinctrl in non-ACPI system

2021-04-12 Thread Henning Schild
Am Mon, 12 Apr 2021 19:59:05 +0300 schrieb Andy Shevchenko : > On Mon, Apr 12, 2021 at 06:40:01PM +0200, Henning Schild wrote: > > Tan or Andy, > > > > maybe you can point me to a user of that patch. I guess there might > > be an out-of-tree driver or userland c

Re: [PATCH v1 6/7] mfd: lpc_ich: Add support for pinctrl in non-ACPI system

2021-04-12 Thread Henning Schild
it for inspiration. A driver will likely be GPL anyways. regards, Henning Am Mon, 12 Apr 2021 18:01:06 +0200 schrieb Henning Schild : > Am Mon, 8 Mar 2021 14:20:19 +0200 > schrieb Andy Shevchenko : > > > From: Tan Jui Nee > > > > Add support for non-ACPI systems, such as system

Re: [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-04-12 Thread Henning Schild
Am Mon, 12 Apr 2021 09:06:10 -0700 schrieb Guenter Roeck : > On 4/12/21 8:35 AM, Henning Schild wrote: > > Am Thu, 1 Apr 2021 18:15:41 +0200 > > schrieb "Enrico Weigelt, metux IT consult" : > > > >> On 29.03.21 19:49, Henning Schild wrote: > >&g

Re: [PATCH v1 6/7] mfd: lpc_ich: Add support for pinctrl in non-ACPI system

2021-04-12 Thread Henning Schild
Am Mon, 8 Mar 2021 14:20:19 +0200 schrieb Andy Shevchenko : > From: Tan Jui Nee > > Add support for non-ACPI systems, such as system that uses > Advanced Boot Loader (ABL) whereby a platform device has to be created > in order to bind with pin control and GPIO. > > At the moment, Intel Apollo

Re: [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-04-12 Thread Henning Schild
Am Thu, 1 Apr 2021 18:15:41 +0200 schrieb "Enrico Weigelt, metux IT consult" : > On 29.03.21 19:49, Henning Schild wrote: > > Hi, > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an

Re: [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-04-12 Thread Henning Schild
Am Thu, 1 Apr 2021 14:04:51 +0300 schrieb Andy Shevchenko : > On Thu, Apr 1, 2021 at 1:44 PM Henning Schild > wrote: > > > > Am Wed, 31 Mar 2021 18:40:23 +0300 > > schrieb Andy Shevchenko : > > > > > On Tue, Mar 30, 2021 at 6:33 PM Henning Schild > &g

Re: [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-04-12 Thread Henning Schild
Am Thu, 1 Apr 2021 14:04:51 +0300 schrieb Andy Shevchenko : > On Thu, Apr 1, 2021 at 1:44 PM Henning Schild > wrote: > > > > Am Wed, 31 Mar 2021 18:40:23 +0300 > > schrieb Andy Shevchenko : > > > > > On Tue, Mar 30, 2021 at 6:33 PM Henning Schild > &g

Re: [PATCH v3 0/4] add device drivers for Siemens Industrial PCs

2021-04-12 Thread Henning Schild
Am Wed, 7 Apr 2021 13:36:40 +0200 schrieb Hans de Goede : > Hi, > > On 3/29/21 7:49 PM, Henning Schild wrote: > > changes since v2: > > > > - remove "simatic-ipc" prefix from LED names > > - fix style issues found in v2, mainly LED driver > &

Re: [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-04-06 Thread Henning Schild
Am Thu, 1 Apr 2021 18:15:41 +0200 schrieb "Enrico Weigelt, metux IT consult" : > On 29.03.21 19:49, Henning Schild wrote: > > Hi, > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an

Re: [PATCH v1 3/7] PCI: New Primary to Sideband (P2SB) bridge support library

2021-04-06 Thread Henning Schild
Am Fri, 2 Apr 2021 15:09:12 +0200 schrieb "Enrico Weigelt, metux IT consult" : > On 09.03.21 09:42, Henning Schild wrote: > > > The device will respond to MMIO while being hidden. I am afraid > > nothing stops a collision, except for the assumption that the BIOS

Re: [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-04-01 Thread Henning Schild
Am Wed, 31 Mar 2021 18:40:23 +0300 schrieb Andy Shevchenko : > On Tue, Mar 30, 2021 at 6:33 PM Henning Schild > wrote: > > Am Tue, 30 Mar 2021 15:41:53 +0300 > > schrieb Andy Shevchenko : > > > On Tue, Mar 30, 2021 at 3:35 PM Henning Schild > > > wrote:

Re: [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-30 Thread Henning Schild
Am Tue, 30 Mar 2021 15:41:53 +0300 schrieb Andy Shevchenko : > On Tue, Mar 30, 2021 at 3:35 PM Henning Schild > wrote: > > Am Tue, 30 Mar 2021 15:15:16 +0300 > > schrieb Andy Shevchenko : > > > On Tue, Mar 30, 2021 at 2:58 PM Henning Schild > > > wrote:

Re: [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-30 Thread Henning Schild
Am Tue, 30 Mar 2021 15:15:16 +0300 schrieb Andy Shevchenko : > On Tue, Mar 30, 2021 at 2:58 PM Henning Schild > wrote: > > Am Tue, 30 Mar 2021 14:04:35 +0300 > > schrieb Andy Shevchenko : > > > On Mon, Mar 29, 2021 at 8:59 PM Henning Schild > > > wrote

Re: [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-30 Thread Henning Schild
Am Tue, 30 Mar 2021 14:04:35 +0300 schrieb Andy Shevchenko : > On Mon, Mar 29, 2021 at 8:59 PM Henning Schild > wrote: > > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an earlier commit.

Re: [PATCH v3 0/4] add device drivers for Siemens Industrial PCs

2021-03-29 Thread Henning Schild
more work for everyone. regards, Henning Am Mon, 29 Mar 2021 19:49:24 +0200 schrieb Henning Schild : > changes since v2: > > - remove "simatic-ipc" prefix from LED names > - fix style issues found in v2, mainly LED driver > - fix OEM specific dmi code, and remove magic

[PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-29 Thread Henning Schild
This driver adds initial support for several devices from Siemens. It is based on a platform driver introduced in an earlier commit. Signed-off-by: Henning Schild Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 11 ++ drivers/watchdog/Makefile | 1 + drivers

[PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-29 Thread Henning Schild
This driver adds initial support for several devices from Siemens. It is based on a platform driver introduced in an earlier commit. Signed-off-by: Henning Schild --- drivers/leds/Kconfig | 3 + drivers/leds/Makefile | 3 + drivers/leds/simple/Kconfig

[PATCH v3 0/4] add device drivers for Siemens Industrial PCs

2021-03-29 Thread Henning Schild
y that we can easily add more devices and more platform drivers later. Internally we have some more code for hardware monitoring, more leds, watchdogs etc. This will follow some day. Henning Schild (4): platform/x86: simatic-ipc: add main driver for Siemens devices leds: simatic-ipc-

[PATCH v3 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-29 Thread Henning Schild
-off-by: Henning Schild --- drivers/platform/x86/Kconfig | 12 ++ drivers/platform/x86/Makefile | 3 + drivers/platform/x86/simatic-ipc.c| 169 ++ .../platform_data/x86/simatic-ipc-base.h | 29 +++ include/linux/platform_data

[PATCH v3 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-03-29 Thread Henning Schild
Fixes: ad0d315b4d4e ("platform/x86: pmc_atom: Add Siemens SIMATIC ...") Tested-by: Michael Haener Signed-off-by: Henning Schild --- drivers/platform/x86/pmc_atom.c | 57 + 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/drivers/platfo

Re: [PATCH v2 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-29 Thread Henning Schild
Am Mon, 15 Mar 2021 08:10:25 -0700 schrieb Guenter Roeck : > On 3/15/21 2:57 AM, Henning Schild wrote: > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an earlier commit. > > > > Si

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-27 Thread Henning Schild
Am Sat, 27 Mar 2021 12:16:23 +0100 schrieb Henning Schild : > Am Thu, 18 Mar 2021 11:25:10 +0100 > schrieb "Enrico Weigelt, metux IT consult" : > > > On 15.03.21 10:57, Henning Schild wrote: > > > > Hi, > > > > > diff --git a/drivers/leds/s

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-27 Thread Henning Schild
Am Thu, 18 Mar 2021 11:25:10 +0100 schrieb "Enrico Weigelt, metux IT consult" : > On 15.03.21 10:57, Henning Schild wrote: > > Hi, > > > diff --git a/drivers/leds/simple/simatic-ipc-leds.c > > b/drivers/leds/simple/simatic-ipc-leds.c new file mode 100644 &g

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-27 Thread Henning Schild
Am Mon, 15 Mar 2021 12:19:15 +0100 schrieb Pavel Machek : > > > + struct led_classdev cdev; > > > +}; > > > + > > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > > + {1 << 15, "simatic-ipc:green:" LED_FUNCTION_STATUS "-1" }, > > > + {1 << 7, "simatic-ipc:yellow:"

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-27 Thread Henning Schild
Am Thu, 18 Mar 2021 12:38:53 +0100 schrieb "Enrico Weigelt, metux IT consult" : > On 15.03.21 12:19, Pavel Machek wrote: > > > But I still don't like the naming. simantic-ipc: prefix is > > useless. Having 6 status leds is not good, either. > > Do we have some standard naming policy those

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-26 Thread Henning Schild
Am Mon, 15 Mar 2021 12:48:19 +0200 schrieb Andy Shevchenko : > On Mon, Mar 15, 2021 at 11:57 AM Henning Schild > wrote: > > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an earlier commit.

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-26 Thread Henning Schild
Am Thu, 18 Mar 2021 12:45:01 +0100 schrieb Hans de Goede : > Hi, > > On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: > > On 17.03.21 21:03, Hans de Goede wrote: > > > > Hi, > > > >>> It just identifies the box and tells subsequent drivers which one > >>> it is, which watchdog

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-23 Thread Henning Schild
Am Thu, 18 Mar 2021 13:40:58 +0100 schrieb Alexander Dahl : > Hei hei, > > > Enrico Weigelt, metux IT consult hat am 18.03.2021 > > 11:27 geschrieben: > > > > > > On 15.03.21 11:48, Andy Shevchenko wrote: > > > > Hi, > > > > > I have a question, why we can't provide a GPIO driver which

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-17 Thread Henning Schild
Am Mon, 15 Mar 2021 12:31:11 +0200 schrieb Andy Shevchenko : > On Mon, Mar 15, 2021 at 12:02 PM Henning Schild > wrote: > > > > This mainly implements detection of these devices and will allow > > secondary drivers to work on such machines. > > > > The ident

Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C

2021-03-16 Thread Henning Schild
> > Thanks for all effort! > Reviewed-by: Andy Shevchenko > after addressing the below comments. > > > Signed-off-by: Johannes Hahn > > Signed-off-by: Claudius Heine > > > Signed-off-by: Henning Schild Claudius, just remove that. I guess just add yo

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Henning Schild
of sch56xx but that is still rough and i thought i ask before we potentially duplicate work. groetjes, Henning Am Mon, 15 Mar 2021 19:01:13 +0100 schrieb Hans de Goede : > Hi, > > On 3/15/21 6:00 PM, Henning Schild wrote: > > Am Mon, 15 Mar 2021 17:31:49 +0100 > >

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 17:31:49 +0100 schrieb Hans de Goede : > Hi, > > On 3/15/21 3:58 PM, Henning Schild wrote: > > Introduce a global variable to remember the matching entry for later > > printing. Also having a callback allows to stop matching after the > > fir

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 12:31:11 +0200 schrieb Andy Shevchenko : > On Mon, Mar 15, 2021 at 12:02 PM Henning Schild > wrote: > > > > This mainly implements detection of these devices and will allow > > secondary drivers to work on such machines. > > > > The ident

Re: [PATCH v2 0/4] add device drivers for Siemens Industrial PCs

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 12:55:13 +0200 schrieb Andy Shevchenko : > On Mon, Mar 15, 2021 at 12:12 PM Henning Schild > wrote: > > > > changes since v1: > > > > - fixed lots of style issues found in v1 > > - (debug) printing > > - header ordering > &

[PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Henning Schild
Introduce a global variable to remember the matching entry for later printing. Also having a callback allows to stop matching after the first hit. Signed-off-by: Henning Schild --- drivers/platform/x86/pmc_atom.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 12:19:15 +0100 schrieb Pavel Machek : > > > + struct led_classdev cdev; > > > +}; > > > + > > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > > + {1 << 15, "simatic-ipc:green:" LED_FUNCTION_STATUS "-1" }, > > > + {1 << 7, "simatic-ipc:yellow:"

Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 11:19:24 +0100 schrieb Hans de Goede : > Hi, > > On 3/15/21 11:14 AM, Henning Schild wrote: > > Am Mon, 15 Mar 2021 10:57:10 +0100 > > schrieb Henning Schild : > > > >> Siemens industrial PCs unfortunately can not always be prop

Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 10:57:10 +0100 schrieb Henning Schild : > Siemens industrial PCs unfortunately can not always be properly > identified the way we used to. An earlier commit introduced code that > allows proper identification without looking at DMI strings that could > differ base

[PATCH v2 0/4] add device drivers for Siemens Industrial PCs

2021-03-15 Thread Henning Schild
patch. It is all structured in a way that we can easily add more devices and more platform drivers later. Internally we have some more code for hardware monitoring, more leds, watchdogs etc. This will follow some day. Henning Schild (4): platform/x86: simatic-ipc: add main driver for Siemens

[PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-15 Thread Henning Schild
-off-by: Henning Schild --- drivers/platform/x86/Kconfig | 12 ++ drivers/platform/x86/Makefile | 3 + drivers/platform/x86/simatic-ipc.c| 168 ++ .../platform_data/x86/simatic-ipc-base.h | 29 +++ include/linux/platform_data

[PATCH v2 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-15 Thread Henning Schild
This driver adds initial support for several devices from Siemens. It is based on a platform driver introduced in an earlier commit. Signed-off-by: Henning Schild --- drivers/watchdog/Kconfig | 11 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/simatic-ipc-wdt.c

[PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-03-15 Thread Henning Schild
Fixes: ad0d315b4d4e ("platform/x86: pmc_atom: Add Siemens SIMATIC ...") Tested-by: Michael Haener Signed-off-by: Henning Schild --- drivers/platform/x86/pmc_atom.c | 47 +++-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/platfo

[PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-15 Thread Henning Schild
This driver adds initial support for several devices from Siemens. It is based on a platform driver introduced in an earlier commit. Signed-off-by: Henning Schild --- drivers/leds/Kconfig | 3 + drivers/leds/Makefile | 3 + drivers/leds/simple/Kconfig

Re: [PATCH v1 3/7] PCI: New Primary to Sideband (P2SB) bridge support library

2021-03-13 Thread Henning Schild
Am Mon, 8 Mar 2021 14:20:16 +0200 schrieb Andy Shevchenko : > From: Jonathan Yong > > There is already one and at least one more user is coming which > requires an access to Primary to Sideband bridge (P2SB) in order to > get IO or MMIO bar hidden by BIOS. Create a library to access P2SB > for

Re: [rfc, PATCH v1 0/7] PCI: introduce p2sb helper

2021-03-13 Thread Henning Schild
expected. Tested-by: Henning Schild Henning > Here is the series to deduplicate existing users and provide > a generic way for new comers. > > It also includes a patch to enable GPIO controllers on Apollo Lake > when it's used with ABL bootloader w/o ACPI support. > > P

Re: [PATCH v1 3/7] PCI: New Primary to Sideband (P2SB) bridge support library

2021-03-09 Thread Henning Schild
Am Mon, 8 Mar 2021 19:42:21 -0600 schrieb Bjorn Helgaas : > On Mon, Mar 08, 2021 at 09:16:50PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 12:52:12PM -0600, Bjorn Helgaas wrote: > > > On Mon, Mar 08, 2021 at 02:20:16PM +0200, Andy Shevchenko wrote: > > > > From: Jonathan Yong >

Re: [PATCH 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-08 Thread Henning Schild
Am Wed, 3 Mar 2021 15:21:05 +0100 schrieb Henning Schild : > Hi, > > thanks for the fast and thorough review! > > Am Tue, 2 Mar 2021 10:38:19 -0800 > schrieb Guenter Roeck : > > > On 3/2/21 8:33 AM, Henning Schild wrote: > > > From: Henning Schild &

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-08 Thread Henning Schild
Am Fri, 5 Mar 2021 19:44:57 +0200 schrieb Andy Shevchenko : > On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko > wrote: > > > > On Fri, Mar 5, 2021 at 6:47 PM Henning Schild > > wrote: > > > Am Fri, 5 Mar 2021 17:42:42 +0200 > > > schrieb Andy Shevchen

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-06 Thread Henning Schild
Am Sat, 6 Mar 2021 13:54:53 +0100 schrieb Henning Schild : > Am Fri, 5 Mar 2021 19:25:55 +0100 > schrieb Henning Schild : > > > Am Wed, 3 Mar 2021 21:56:15 +0100 > > schrieb Henning Schild : > > > > > Am Wed, 3 Mar 2021 21:48:21 +0100 > > > schri

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-06 Thread Henning Schild
Am Fri, 5 Mar 2021 19:25:55 +0100 schrieb Henning Schild : > Am Wed, 3 Mar 2021 21:56:15 +0100 > schrieb Henning Schild : > > > Am Wed, 3 Mar 2021 21:48:21 +0100 > > schrieb Henning Schild : > > > > > Am Wed, 3 Mar 2021 20:31:34 +0100 > > >

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-05 Thread Henning Schild
Am Wed, 3 Mar 2021 21:56:15 +0100 schrieb Henning Schild : > Am Wed, 3 Mar 2021 21:48:21 +0100 > schrieb Henning Schild : > > > Am Wed, 3 Mar 2021 20:31:34 +0100 > > schrieb Pavel Machek : > > > > > Hi! > > > > > > &g

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Henning Schild
Am Fri, 5 Mar 2021 17:42:42 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede > wrote: > > On 3/4/21 11:11 AM, Andy Shevchenko wrote: > > > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > > > wrote: > > ... > > >

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Henning Schild
Am Fri, 5 Mar 2021 17:46:08 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 9:52 PM Henning Schild > wrote: > > Am Thu, 4 Mar 2021 12:11:12 +0200 > > schrieb Andy Shevchenko : > > > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > > > wrote:

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Henning Schild
Am Thu, 4 Mar 2021 12:11:12 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > wrote: > > > > From: Henning Schild > > > > This mainly implements detection of these devices and will allow > > secondary drivers to work on such

Re: [PATCH 0/4] add device drivers for Siemens Industrial PCs

2021-03-04 Thread Henning Schild
Am Thu, 4 Mar 2021 12:20:22 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 12:19 PM Andy Shevchenko > wrote: > > On Thu, Mar 4, 2021 at 9:29 AM Henning Schild > > wrote: > > > I have given a few comments here and there, so please check the > &g

Re: [PATCH 0/4] add device drivers for Siemens Industrial PCs

2021-03-04 Thread Henning Schild
Thanks Andy, Am Thu, 4 Mar 2021 12:19:44 +0200 schrieb Andy Shevchenko : > On Thu, Mar 4, 2021 at 9:29 AM Henning Schild > wrote: > > > This series adds support for watchdogs and leds of several x86 > > devices from Siemens. > > > > It is structured with a

Re: [PATCH 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-04 Thread Henning Schild
Am Thu, 4 Mar 2021 10:27:07 +0200 schrieb Andy Shevchenko : > On Tuesday, March 2, 2021, Henning Schild > wrote: > > > From: Henning Schild > > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform drive

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Henning Schild
Am Wed, 3 Mar 2021 21:48:21 +0100 schrieb Henning Schild : > Am Wed, 3 Mar 2021 20:31:34 +0100 > schrieb Pavel Machek : > > > Hi! > > > > > > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > > > > + {1 << 15, "si

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Henning Schild
Am Wed, 3 Mar 2021 20:31:34 +0100 schrieb Pavel Machek : > Hi! > > > > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > > > + {1 << 15, "simatic-ipc:green:run-stop"}, > > > > + {1 << 7, "simatic-ipc:yellow:run-stop"}, > > > > + {1 << 14, "simatic-ipc:red:error"},

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Henning Schild
Am Wed, 3 Mar 2021 18:40:40 +0100 schrieb Pavel Machek : > Hi! > > > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > > > index 2a698df9da57..c15e1e3c5958 100644 > > > > --- a/drivers/leds/Makefile > > > > +++ b/drivers/leds/Makefile > > > > @@ -93,6 +93,7 @@

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Henning Schild
Am Tue, 2 Mar 2021 21:54:52 +0100 schrieb Pavel Machek : > Hi! > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an earlier commit. > > Ok. > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile > > index

Re: [PATCH 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-03 Thread Henning Schild
Hi, thanks for the fast and thorough review! Am Tue, 2 Mar 2021 10:38:19 -0800 schrieb Guenter Roeck : > On 3/2/21 8:33 AM, Henning Schild wrote: > > From: Henning Schild > > > > This driver adds initial support for several devices from Siemens. > > It is

Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-03 Thread Henning Schild
Hi Pavel, thanks for looking into this. Am Tue, 2 Mar 2021 21:54:52 +0100 schrieb Pavel Machek : > Hi! > > > This driver adds initial support for several devices from Siemens. > > It is based on a platform driver introduced in an earlier commit. > > Ok. > > > diff --git

[PATCH 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-03-02 Thread Henning Schild
From: Henning Schild Siemens industrial PCs unfortunately can not always be properly identified the way we used to. An earlier commit introduced code that allows proper identification without looking at DMI strings that could differ based on product branding. Switch over to that proper way

[PATCH 0/4] add device drivers for Siemens Industrial PCs

2021-03-02 Thread Henning Schild
From: Henning Schild This series adds support for watchdogs and leds of several x86 devices from Siemens. It is structured with a platform driver that mainly does identification of the machines. It might trigger loading of the actual device drivers by attaching devices to the platform bus

[PATCH 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-02 Thread Henning Schild
From: Henning Schild This driver adds initial support for several devices from Siemens. It is based on a platform driver introduced in an earlier commit. Signed-off-by: Gerd Haeussler Signed-off-by: Henning Schild --- drivers/watchdog/Kconfig | 11 ++ drivers/watchdog/Makefile

[PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-02 Thread Henning Schild
From: Henning Schild This mainly implements detection of these devices and will allow secondary drivers to work on such machines. The identification is DMI-based with a vendor specific way to tell them apart in a reliable way. Drivers for LEDs and Watchdogs will follow to make use

[PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-02 Thread Henning Schild
From: Henning Schild This driver adds initial support for several devices from Siemens. It is based on a platform driver introduced in an earlier commit. Signed-off-by: Gerd Haeussler Signed-off-by: Henning Schild --- drivers/leds/Kconfig| 11 ++ drivers/leds/Makefile

Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

2020-11-18 Thread Henning Schild
We are trying to reach out to Epson to find valid IDs, but will do that off-list for now. In the meantime we will propose just the I2C patches, without ACPI. We have Werner Zeh here, who pushed the coreboot change. In coreboot nobody objected, maybe they have not been aware of the processes or

Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

2020-11-16 Thread Henning Schild
Am Mon, 16 Nov 2020 16:46:31 +0200 schrieb Andy Shevchenko : > On Thu, Nov 12, 2020 at 02:07:33PM +0100, Claudius Heine wrote: > > From: Johannes Hahn > > > > This allows the RX6110 driver to be automatically assigned to the > > right device on the I2C bus. > > Before adding new ACPI ID, can

Re: [PATCH 0/2] Adding I2C support to RX6110 RTC

2020-11-06 Thread Henning Schild
Am Fri, 6 Nov 2020 08:59:08 +0100 schrieb Alexandre Belloni : > On 06/11/2020 08:40:34+0100, Henning Schild wrote: > > Hi, > > > > Am Thu, 5 Nov 2020 23:14:51 +0100 > > schrieb Alexandre Belloni : > > > > > Hello Claudius! > > > > >

Re: [PATCH 0/2] Adding I2C support to RX6110 RTC

2020-11-06 Thread Henning Schild
Hi, Am Thu, 5 Nov 2020 23:14:51 +0100 schrieb Alexandre Belloni : > Hello Claudius! > > It has been a while ;) > > On 04/11/2020 11:26:27+0100, Claudius Heine wrote: > > Hi, > > > > this patch introduces I2C support to the RX6110 RTC driver and also > > adds an ACPI identifier to it. > > > >

Re: [PATCH v2] scripts: builddeb: allow customization of "Depends:" fields

2017-12-04 Thread Henning Schild
Hi, this is a simpler version that allows just the customization of "Depends:", as requested by Ben. It addresses the security issues Jim mentioned by not using eval anymore. Henning Am Mon, 4 Dec 2017 17:48:08 +0100 schrieb Henning Schild <henning.sch...@siemens.com>: >

Re: [PATCH v2] scripts: builddeb: allow customization of "Depends:" fields

2017-12-04 Thread Henning Schild
Hi, this is a simpler version that allows just the customization of "Depends:", as requested by Ben. It addresses the security issues Jim mentioned by not using eval anymore. Henning Am Mon, 4 Dec 2017 17:48:08 +0100 schrieb Henning Schild : > The debian packages coming out of &

[PATCH v2] scripts: builddeb: allow customization of "Depends:" fields

2017-12-04 Thread Henning Schild
for all packages. All the new variables are optional. Signed-off-by: Henning Schild <henning.sch...@siemens.com> --- scripts/package/builddeb | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index b4f0f2b3f8d2..079bd4c4aea9 100755 --- a/sc

[PATCH v2] scripts: builddeb: allow customization of "Depends:" fields

2017-12-04 Thread Henning Schild
for all packages. All the new variables are optional. Signed-off-by: Henning Schild --- scripts/package/builddeb | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index b4f0f2b3f8d2..079bd4c4aea9 100755 --- a/scripts/package/builddeb +++ b/scri

Re: [PATCH] builddeb: introduce variables for control-file customization

2017-12-04 Thread Henning Schild
Am Fri, 1 Dec 2017 18:47:38 + schrieb Ben Hutchings <b...@decadent.org.uk>: > On Fri, 2017-12-01 at 19:34 +0100, Henning Schild wrote: > > Am Fri, 1 Dec 2017 16:51:12 + > > schrieb Ben Hutchings <b...@decadent.org.uk>: > > > > > On Fri, 2017-

Re: [PATCH] builddeb: introduce variables for control-file customization

2017-12-04 Thread Henning Schild
Am Fri, 1 Dec 2017 18:47:38 + schrieb Ben Hutchings : > On Fri, 2017-12-01 at 19:34 +0100, Henning Schild wrote: > > Am Fri, 1 Dec 2017 16:51:12 + > > schrieb Ben Hutchings : > > > > > On Fri, 2017-12-01 at 15:56 +, Henning Schild wrote: > >

Re: [PATCH] builddeb: introduce variables for control-file customization

2017-12-01 Thread Henning Schild
Am Fri, 1 Dec 2017 16:51:12 + schrieb Ben Hutchings <b...@decadent.org.uk>: > On Fri, 2017-12-01 at 15:56 +, Henning Schild wrote: > > The debian packages coming out of "make *deb-pkg" lack some critical > > information in the control-files e.g. the &qu

Re: [PATCH] builddeb: introduce variables for control-file customization

2017-12-01 Thread Henning Schild
Am Fri, 1 Dec 2017 16:51:12 + schrieb Ben Hutchings : > On Fri, 2017-12-01 at 15:56 +0000, Henning Schild wrote: > > The debian packages coming out of "make *deb-pkg" lack some critical > > information in the control-files e.g. the "Depends:" field. If one

Re: [PATCH v2] docs: fix location of document that got moved

2017-11-28 Thread Henning Schild
Hi Alexander, could you please have a look at that patch. Henning Am Wed, 20 Sep 2017 20:02:04 +0200 schrieb Henning Schild <henn...@hennsch.de>: > commit 9d85025b0418 ("docs-rst: create an user's manual book") > renamed the document mentioned in the header. Adju

Re: [PATCH v2] docs: fix location of document that got moved

2017-11-28 Thread Henning Schild
Hi Alexander, could you please have a look at that patch. Henning Am Wed, 20 Sep 2017 20:02:04 +0200 schrieb Henning Schild : > commit 9d85025b0418 ("docs-rst: create an user's manual book") > renamed the document mentioned in the header. Adjust the link to > point

Re: [PATCH] builddeb: introduce variables for control-file customization

2017-11-28 Thread Henning Schild
Am Mon, 27 Nov 2017 16:57:58 -0700 schrieb Jim Davis <jim.ep...@gmail.com>: > On Mon, Nov 27, 2017 at 9:13 AM, Henning Schild > <henning.sch...@siemens.com> wrote: > > The debian packages coming out of "make *deb-pkg" lack some critical > > informatio

Re: [PATCH] builddeb: introduce variables for control-file customization

2017-11-28 Thread Henning Schild
Am Mon, 27 Nov 2017 16:57:58 -0700 schrieb Jim Davis : > On Mon, Nov 27, 2017 at 9:13 AM, Henning Schild > wrote: > > The debian packages coming out of "make *deb-pkg" lack some critical > > information in the control-files e.g. the "Depends:" field. If o

[PATCH] builddeb: introduce variables for control-file customization

2017-11-27 Thread Henning Schild
ot; \ KDEB_OPTS_LIBC_HEADERS="-DMaintainer='root@machine' -v42" \ bindeb-pkg Signed-off-by: Henning Schild <henning.sch...@siemens.com> Signed-off-by: Konrad Schwarz <konrad.schw...@siemens.com> --- scripts/package/builddeb | 19 +-- 1 file change

[PATCH] builddeb: introduce variables for control-file customization

2017-11-27 Thread Henning Schild
ot; \ KDEB_OPTS_LIBC_HEADERS="-DMaintainer='root@machine' -v42" \ bindeb-pkg Signed-off-by: Henning Schild Signed-off-by: Konrad Schwarz --- scripts/package/builddeb | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/scripts/package/builddeb

Re: [PATCH v2] docs: fix location of document that got moved

2017-11-15 Thread Henning Schild
Adding kernel-janitors to the list, maybe some of you will pick it up. Henning Am Wed, 20 Sep 2017 20:02:04 +0200 schrieb Henning Schild <henn...@hennsch.de>: > commit 9d85025b0418 ("docs-rst: create an user's manual book") > renamed the document mentioned in the h

Re: [PATCH v2] docs: fix location of document that got moved

2017-11-15 Thread Henning Schild
Adding kernel-janitors to the list, maybe some of you will pick it up. Henning Am Wed, 20 Sep 2017 20:02:04 +0200 schrieb Henning Schild : > commit 9d85025b0418 ("docs-rst: create an user's manual book") > renamed the document mentioned in the header. Adjust the link to >

[PATCH v2] docs: fix location of document that got moved

2017-09-20 Thread Henning Schild
commit 9d85025b0418 ("docs-rst: create an user's manual book") renamed the document mentioned in the header. Adjust the link to point to the right place. Signed-off-by: Henning Schild <henn...@hennsch.de> --- fs/binfmt_misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[PATCH v2] docs: fix location of document that got moved

2017-09-20 Thread Henning Schild
commit 9d85025b0418 ("docs-rst: create an user's manual book") renamed the document mentioned in the header. Adjust the link to point to the right place. Signed-off-by: Henning Schild --- fs/binfmt_misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfm

Re: [PATCH] docs: fix location of document that got moved

2017-09-11 Thread Henning Schild
Ping Am Fri, 1 Sep 2017 21:57:21 +0200 schrieb Henning Schild <henn...@hennsch.de>: > 9d85025b0418 renamed the document mentioned in the header. Adjust the > link to point to the right place. > > Signed-off-by: Henning Schild <henn...@hennsch.de> > --- > fs/b

Re: [PATCH] docs: fix location of document that got moved

2017-09-11 Thread Henning Schild
Ping Am Fri, 1 Sep 2017 21:57:21 +0200 schrieb Henning Schild : > 9d85025b0418 renamed the document mentioned in the header. Adjust the > link to point to the right place. > > Signed-off-by: Henning Schild > --- > fs/binfmt_misc.c | 3 ++- > 1 file changed, 2 inse

[PATCH] docs: fix location of document that got moved

2017-09-01 Thread Henning Schild
9d85025b0418 renamed the document mentioned in the header. Adjust the link to point to the right place. Signed-off-by: Henning Schild <henn...@hennsch.de> --- fs/binfmt_misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c

[PATCH] docs: fix location of document that got moved

2017-09-01 Thread Henning Schild
9d85025b0418 renamed the document mentioned in the header. Adjust the link to point to the right place. Signed-off-by: Henning Schild --- fs/binfmt_misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c index f4718098ac31..b0cc07fbadef

Re: [3/8] x86/tsc: Store and check TSC ADJUST MSR

2017-01-30 Thread Henning Schild
On Mon, 30 Jan 2017 11:20:25 +0100 Thomas Gleixner <t...@linutronix.de> wrote: > Henning, > > On Fri, 27 Jan 2017, Henning Schild wrote: > > > > did you by any chance look into TSC synchronization by adjusting the > > absolute value (MSR_IA32_TSC) as well? As

Re: [3/8] x86/tsc: Store and check TSC ADJUST MSR

2017-01-30 Thread Henning Schild
On Mon, 30 Jan 2017 11:20:25 +0100 Thomas Gleixner wrote: > Henning, > > On Fri, 27 Jan 2017, Henning Schild wrote: > > > > did you by any chance look into TSC synchronization by adjusting the > > absolute value (MSR_IA32_TSC) as well? As far as i have seen Linux &

Re: [3/8] x86/tsc: Store and check TSC ADJUST MSR

2017-01-27 Thread Henning Schild
Thomas, did you by any chance look into TSC synchronization by adjusting the absolute value (MSR_IA32_TSC) as well? As far as i have seen Linux did that a long time ago and eventually it was stopped because it caused more harm than good.

Re: [3/8] x86/tsc: Store and check TSC ADJUST MSR

2017-01-27 Thread Henning Schild
Thomas, did you by any chance look into TSC synchronization by adjusting the absolute value (MSR_IA32_TSC) as well? As far as i have seen Linux did that a long time ago and eventually it was stopped because it caused more harm than good.

  1   2   >