[PATCH] usb: gadget: udc: use USB API functions rather than constants

2014-08-23 Thread Himangi Saraogi
num(epd) @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/usb/gadget/udc/r8a66597-udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH] usb: gadget: udc: use USB API functions rather than constants

2014-08-23 Thread Himangi Saraogi
usb_endpoint_descriptor *epd; @@ - (epd-bmAttributes \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/usb/gadget/udc/r8a66597-udc.c | 6 +++--- 1 file changed, 3 insertions

[PATCH] af_decnet: Use time_after_eq

2014-08-20 Thread Himangi Saraogi
_eq(jiffies, E1+E2*E3) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/decnet/af_decnet.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index ae011b4..25733d5 100644 --- a/net/decnet/af_decnet.c +++ b/net/dec

[PATCH] decnet: Use time_after_eq

2014-08-20 Thread Himangi Saraogi
_eq(jiffies, E1+E2) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/decnet/dn_timer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/decnet/dn_timer.c b/net/decnet/dn_timer.c index d9c150c..1d330fd 100644 --- a/net/decnet/dn_timer.c +++ b/net/decnet/dn_time

[PATCH] ipconfig: Use time_before

2014-08-20 Thread Himangi Saraogi
E1+E2) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/ipv4/ipconfig.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 5bbef4f..648fa14 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4/ipconfig.c @@ -262,7 +26

[PATCH] dn_dev: Use time_before

2014-08-20 Thread Himangi Saraogi
ore(jiffies, E1+E2) ) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/decnet/dn_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index 3b726f3..4400da7 100644 --- a/net/decnet/dn_dev.c +++ b/net/decnet/dn_dev.c @@ -4

[PATCH] dn_dev: Use time_before

2014-08-20 Thread Himangi Saraogi
, E1+E2) ) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- net/decnet/dn_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index 3b726f3..4400da7 100644 --- a/net/decnet/dn_dev.c

[PATCH] ipconfig: Use time_before

2014-08-20 Thread Himangi Saraogi
+E2) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- net/ipv4/ipconfig.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 5bbef4f..648fa14 100644 --- a/net/ipv4/ipconfig.c +++ b

[PATCH] decnet: Use time_after_eq

2014-08-20 Thread Himangi Saraogi
, E1+E2) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- net/decnet/dn_timer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/decnet/dn_timer.c b/net/decnet/dn_timer.c index d9c150c..1d330fd 100644 --- a/net/decnet

[PATCH] af_decnet: Use time_after_eq

2014-08-20 Thread Himangi Saraogi
(jiffies, E1+E2*E3) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- net/decnet/af_decnet.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index ae011b4..25733d5 100644 --- a/net

[PATCH] isdn/bas_gigaset: use USB API functions rather than constants

2014-08-16 Thread Himangi Saraogi
This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Himangi

[PATCH] isdn/bas_gigaset: use USB API functions rather than constants

2014-08-16 Thread Himangi Saraogi
This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd-bEndpointAddress \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Himangi Saraogi

[PATCH] isdn/gigaset: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Himangi

[PATCH] orinoco_usb: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
(epd) && usb_endpoint_dir_out(epd)) + usb_endpoint_is_bulk_out(epd) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/wireless/orinoco/orinoco_usb.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/orinoco/orinoco_

[PATCH] rc-core: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
struct usb_endpoint_descriptor *epd; @@ - ((epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) != - \(USB_ENDPOINT_XFER_INT\|3\)) + !usb_endpoint_xfer_int(epd) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/media/rc/streamzap.c | 6 ++ 1 file changed, 2 insertions(+

[PATCH] radio-si470x-usb: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
usb_endpoint_is_int_in(epd) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/media/radio/si470x/radio-si470x-usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio-si47

[PATCH] media/rc/imon.c: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
This patch introduces the use of the function usb_endpoint_type. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Himangi

[PATCH] media/rc/imon.c: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
This patch introduces the use of the function usb_endpoint_type. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd-bmAttributes \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Signed-off-by: Himangi Saraogi

[PATCH] radio-si470x-usb: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/media/radio/si470x/radio-si470x-usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/radio/si470x/radio-si470x-usb.c b/drivers/media/radio/si470x/radio

[PATCH] rc-core: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
usb_endpoint_descriptor *epd; @@ - ((epd-bmAttributes \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) != - \(USB_ENDPOINT_XFER_INT\|3\)) + !usb_endpoint_xfer_int(epd) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/media/rc/streamzap.c | 6 ++ 1 file

[PATCH] orinoco_usb: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
)) + usb_endpoint_is_bulk_out(epd) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/wireless/orinoco/orinoco_usb.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b

[PATCH] isdn/gigaset: use USB API functions rather than constants

2014-08-15 Thread Himangi Saraogi
This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ - (epd-bEndpointAddress \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Himangi Saraogi

[PATCH] Drivers: ide: Remove typedef atiixp_ide_timing

2014-08-14 Thread Himangi Saraogi
tdres; @@ coccinelle.tdres = td; @@ type tn1.td; identifier tf.tdres; @@ -typedef struct + tdres { ... } -td ; @@ type tn1.td; identifier tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/ide/atiixp.c | 8 1 file changed, 4 inse

[PATCH] Drivers: ide: Remove typedef atiixp_ide_timing

2014-08-14 Thread Himangi Saraogi
; @@ coccinelle.tdres = td; @@ type tn1.td; identifier tf.tdres; @@ -typedef struct + tdres { ... } -td ; @@ type tn1.td; identifier tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/ide/atiixp.c | 8

[PATCH] Bluetooth: bluecard_cs.c: Remove typedef bluecard_info_t

2014-08-13 Thread Himangi Saraogi
the case: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/bluetooth/bluecard_cs.c | 35 ++- 1 file changed, 18 insertions(+), 17

[PATCH] bluetooth/dtl1_cs: Remove typedefs nsh_t and dtl1_info_t

2014-08-13 Thread Himangi Saraogi
the case for dtl1_info_t and a similar patch finds the nsh_t case: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/bluetooth/dtl1_cs.c | 36

[PATCH] bluetooth/btuart_cs: Remove typedef btuart_info_t

2014-08-13 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/bluetooth/btuart_cs.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions

[PATCH] IB/qib: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/infiniband/hw/qib/qib_init.c | 4 +--- 1 file

[PATCH] drivers/bluetooth: Remove typedef bt3c_info_t

2014-08-13 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/bluetooth/bt3c_cs.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff

[PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- Not compile tested. arch/powerpc/platforms/pseries

[PATCH] ARM: integrator: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- arch/arm/mach-integrator/impd1.c | 4 +--- 1 file

[PATCH] drivers/net/wireless: Remove typedef local_info_t

2014-08-13 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/wireless/atmel_cs.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

[PATCH] net/udp_offload: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/ipv4/udp_offload.c | 4 +--- 1 file changed, 1

[PATCH] net/udp_offload: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- net/ipv4

[PATCH] drivers/net/wireless: Remove typedef local_info_t

2014-08-13 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/wireless/atmel_cs.c | 22 +++--- 1 file changed, 11

[PATCH] ARM: integrator: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- arch/arm/mach

[PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- Not compile

[PATCH] drivers/bluetooth: Remove typedef bt3c_info_t

2014-08-13 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/bluetooth/bt3c_cs.c | 27 ++- 1 file changed, 14

[PATCH] IB/qib: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers

[PATCH] bluetooth/btuart_cs: Remove typedef btuart_info_t

2014-08-13 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/bluetooth/btuart_cs.c | 27 ++- 1 file changed

[PATCH] bluetooth/dtl1_cs: Remove typedefs nsh_t and dtl1_info_t

2014-08-13 Thread Himangi Saraogi
the case for dtl1_info_t and a similar patch finds the nsh_t case: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers

[PATCH] Bluetooth: bluecard_cs.c: Remove typedef bluecard_info_t

2014-08-13 Thread Himangi Saraogi
the case: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/bluetooth/bluecard_cs.c | 35 ++- 1

[PATCH] rtlwifi: btcoexist: adjust double test

2014-08-12 Thread Himangi Saraogi
Rewrite a duplicated test to test the correct value The Coccinelle semantic patch that finds this problem is: // @@ expression E; @@ ( * E || ... || E | * E && ... && E ) // Signed-off-by: Himangi Saraogi --- In file drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c, th

[PATCH] rtlwifi: btcoexist: adjust double test

2014-08-12 Thread Himangi Saraogi
Rewrite a duplicated test to test the correct value The Coccinelle semantic patch that finds this problem is: // smpl @@ expression E; @@ ( * E || ... || E | * E ... E ) // /smpl Signed-off-by: Himangi Saraogi himangi...@gmail.com --- In file drivers/staging/rtl8192ee/btcoexist

[PATCH] NFC: st21nfcb: drop kfree of devm_kzalloc's data

2014-08-10 Thread Himangi Saraogi
Using kfree to free data allocated with devm_kzalloc causes double frees. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression x; @@ x = devm_kzalloc(...) ... ?-kfree(x); // Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/nfc/st21nfcb

[PATCH] usb: phy: drop kfree of devm_kzalloc's data

2014-08-10 Thread Himangi Saraogi
Using kfree to free data allocated with devm_kzalloc causes double frees. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression x; @@ x = devm_kzalloc(...) ... ?-kfree(x); // Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/usb/phy/phy-gpio

[PATCH] drivers: net: davinci_cpdma: drop devm_kfree of devm_kzalloc'd data

2014-08-10 Thread Himangi Saraogi
devm_kfree should not have to be explicitly used. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression x,d; @@ x = devm_kzalloc(...) ... ?-devm_kfree(d,x); // Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/ethernet/ti/davinci_cpdma.c

[PATCH] wan: wanxl: Remove typedefs from struct names

2014-08-10 Thread Himangi Saraogi
tifier tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- To send to: Krzysztof Halasa ,net...@vger.kernel.org,linux-kernel@vger.kernel.org drivers/net/wan/wanxl.c | 63 + 1 file changed, 32 insertions(

[PATCH] wan: wanxl: Remove typedefs from struct names

2014-08-10 Thread Himangi Saraogi
tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- To send to: Krzysztof Halasa k...@pm.waw.pl,net...@vger.kernel.org,linux-kernel@vger.kernel.org drivers/net/wan/wanxl.c | 63

[PATCH] drivers: net: davinci_cpdma: drop devm_kfree of devm_kzalloc'd data

2014-08-10 Thread Himangi Saraogi
devm_kfree should not have to be explicitly used. The Coccinelle semantic patch that fixes this problem is as follows: // smpl @@ expression x,d; @@ x = devm_kzalloc(...) ... ?-devm_kfree(d,x); // /smpl Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law

[PATCH] usb: phy: drop kfree of devm_kzalloc's data

2014-08-10 Thread Himangi Saraogi
Using kfree to free data allocated with devm_kzalloc causes double frees. The Coccinelle semantic patch that fixes this problem is as follows: // smpl @@ expression x; @@ x = devm_kzalloc(...) ... ?-kfree(x); // /smpl Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall

[PATCH] NFC: st21nfcb: drop kfree of devm_kzalloc's data

2014-08-10 Thread Himangi Saraogi
Using kfree to free data allocated with devm_kzalloc causes double frees. The Coccinelle semantic patch that fixes this problem is as follows: // smpl @@ expression x; @@ x = devm_kzalloc(...) ... ?-kfree(x); // /smpl Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall

[PATCH] clk: st: remove null pointer dereference

2014-08-09 Thread Himangi Saraogi
points to err0. This problem was found using the following Coccinelle semantic match: // @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 // Signed-off-by: Hima

[PATCH] hdlc: Remove typedefs from struct names

2014-08-09 Thread Himangi Saraogi
tifier tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- To send to: Krzysztof Halasa ,net...@vger.kernel.org,linux-kernel@vger.kernel.org drivers/net/wan/hdlc_fr.c | 63 --- 1 file changed, 32 insertions(

[PATCH] airo_cs: Remove typedef local_info_t

2014-08-09 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/wireless/airo_cs.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff

[PATCH] mfd: menelaus: remove null pointer dereference

2014-08-09 Thread Himangi Saraogi
with. This problem was found using the following Coccinelle semantic match: // @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 // Signed-off-by: Himangi Saraogi Ac

[PATCH] atmel: Remove typedef atmel_priv_ioctl

2014-08-09 Thread Himangi Saraogi
; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/wireless/atmel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/atmel.c b/drivers/net/wireless/atmel.c index 1fe41af..9183f1c 100644 --- a/drivers

[PATCH] com20020_cs: Remove typedef com20020_dev_t

2014-08-09 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- To send to: net...@vger.kernel.org,linux-kernel@vger.kernel.org drivers/net/arcnet/com20020_cs.c | 16

[PATCH] ethernet: amd: Remove typedef local_info_t

2014-08-09 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/ethernet/xircom/xirc2ps_cs.c | 40 1 file changed, 20 insertions(+), 20

[PATCH] ethernet: amd: Remove typedef local_info_t

2014-08-09 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/ethernet/xircom/xirc2ps_cs.c | 40

[PATCH] com20020_cs: Remove typedef com20020_dev_t

2014-08-09 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- To send to: net...@vger.kernel.org,linux-kernel@vger.kernel.org drivers/net

[PATCH] atmel: Remove typedef atmel_priv_ioctl

2014-08-09 Thread Himangi Saraogi
; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/wireless/atmel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/atmel.c b/drivers/net/wireless/atmel.c index

[PATCH] mfd: menelaus: remove null pointer dereference

2014-08-09 Thread Himangi Saraogi
with. This problem was found using the following Coccinelle semantic match: // smpl @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E-f ... when any return ...; } else S3 // /smpl Signed-off-by: Himangi Saraogi

[PATCH] airo_cs: Remove typedef local_info_t

2014-08-09 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/wireless/airo_cs.c | 25 + 1 file changed

[PATCH] hdlc: Remove typedefs from struct names

2014-08-09 Thread Himangi Saraogi
tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- To send to: Krzysztof Halasa k...@pm.waw.pl,net...@vger.kernel.org,linux-kernel@vger.kernel.org drivers/net/wan/hdlc_fr.c | 63

[PATCH] clk: st: remove null pointer dereference

2014-08-09 Thread Himangi Saraogi
-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- Not compile tested. drivers/clk/st/clkgen-mux.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/clk/st/clkgen-mux.c b/drivers/clk/st/clkgen-mux.c index 79dc40b..385b3d0

[PATCH] drivers/net: Remove typedef axnet_dev_t

2014-08-07 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/ethernet/8390/axnet_cs.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions

[PATCH] drivers/net: Remove typedefs pcnet_dev_t and hw_info_t

2014-08-07 Thread Himangi Saraogi
detects the cases: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/ethernet/8390/pcnet_cs.c | 68 ++-- 1 file changed, 34

[PATCH] drivers/net: ethernet: Remove typedef for struct and enum

2014-08-07 Thread Himangi Saraogi
Coccinelle semantic patch detects the case for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/ethernet/fujitsu/fmvj18x_cs.c | 34

[PATCH] dm9000: Remove typedef board_info_t

2014-08-07 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net/ethernet/davicom/dm9000.c | 92 +-- 1 file changed, 46 insertions(+), 46

[PATCH] pcie-gadget-spear: use devm_ functions

2014-08-07 Thread Himangi Saraogi
to make sure the devm_*() routine declarations are unambiguously available. The initial call to platform_get_resource is moved down to the introduced call to devm_ioremap_resource that uses its result. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- Not compile tested due

[PATCH] wireless: wlcore: Use devm_kzalloc

2014-08-07 Thread Himangi Saraogi
This patch introduces the use of devm_kzalloc and does away with the kfrees in the probe and remove functions. Also, a couple of labels and the initial assignment of the ret variable in the probe function are removed. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/net

[PATCH] wireless: wlcore: Use devm_kzalloc

2014-08-07 Thread Himangi Saraogi
This patch introduces the use of devm_kzalloc and does away with the kfrees in the probe and remove functions. Also, a couple of labels and the initial assignment of the ret variable in the probe function are removed. Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall

[PATCH] pcie-gadget-spear: use devm_ functions

2014-08-07 Thread Himangi Saraogi
to make sure the devm_*() routine declarations are unambiguously available. The initial call to platform_get_resource is moved down to the introduced call to devm_ioremap_resource that uses its result. Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr

[PATCH] dm9000: Remove typedef board_info_t

2014-08-07 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/ethernet/davicom/dm9000.c | 92

[PATCH] drivers/net: ethernet: Remove typedef for struct and enum

2014-08-07 Thread Himangi Saraogi
Coccinelle semantic patch detects the case for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/ethernet/fujitsu

[PATCH] drivers/net: Remove typedefs pcnet_dev_t and hw_info_t

2014-08-07 Thread Himangi Saraogi
detects the cases: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/ethernet/8390/pcnet_cs.c | 68

[PATCH] drivers/net: Remove typedef axnet_dev_t

2014-08-07 Thread Himangi Saraogi
: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/net/ethernet/8390/axnet_cs.c | 26 +- 1 file

[PATCH] pcmcia/vrc4171: Remove typedefs for enums and struct

2014-08-06 Thread Himangi Saraogi
-like. The following Coccinelle semantic patch detects the cases for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/pcmcia/vrc4171_card.c | 30

[PATCH] xfs: Remove typedef xfs_uu_t

2014-08-06 Thread Himangi Saraogi
Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- fs/xfs/uuid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c index b83f76b..1f21d8f 100644 --- a/fs/xfs/uuid.c +++ b/fs/xfs/uuid.c @@ -18,13 +18,13 @@ #include /* IRIX interpre

[PATCH] pcmcia: Remove typedef in structs and emum

2014-08-06 Thread Himangi Saraogi
Coccinelle semantic patch detects the cases for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/pcmcia/i82365.c | 36

[PATCH] nfs: Remove typedef nfs_readdir_descriptor_t

2014-08-06 Thread Himangi Saraogi
struct tdres ) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- fs/nfs/dir.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 7e17687..ba5bb19 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@

[PATCH] x86: mtrr/cyrix.c : Remove typedef arr_state_t

2014-08-06 Thread Himangi Saraogi
Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- arch/x86/kernel/cpu/mtrr/cyrix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/cyrix.c b/arch/x86/kernel/cpu/mtrr/cyrix.c index 9e451b0..5e8d57d 100644 --- a/arch/x86/kernel/cpu/mtrr/c

[PATCH] fs/befs/btree.c: Remove typedef befs_btree_node

2014-08-06 Thread Himangi Saraogi
tdres; @@ coccinelle.tdres = td; @@ type tn1.td; identifier tf.tdres; @@ -typedef struct + tdres { ... } -td ; @@ type tn1.td; identifier tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- fs/befs/btree.

[PATCH] sound: oss: Remove typedefs wanc_info and wavnc_port_info

2014-08-06 Thread Himangi Saraogi
{ ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- sound/oss/waveartist.c | 157 - 1 file changed, 89 insertions(+), 68 deletions(-) diff --git a/sound/oss/waveartist.c b/sound/oss

[PATCH] sound: oss: uart401: Remove typedef uart401_devc

2014-08-06 Thread Himangi Saraogi
tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- sound/oss/uart401.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/sound/oss/uart401.c b/sound/oss/uart401.c index 62b8869..279bc56 100644 --- a/sound

[PATCH] pcmcia: Remove typedef tuple_flags

2014-08-06 Thread Himangi Saraogi
; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/pcmcia/cistpl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c index 884a984..0a4c165 100644 --- a/drivers/pcmcia

[PATCH] pcmcia: Remove typedef tuple_flags

2014-08-06 Thread Himangi Saraogi
; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/pcmcia/cistpl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c index 884a984

[PATCH] sound: oss: uart401: Remove typedef uart401_devc

2014-08-06 Thread Himangi Saraogi
tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- sound/oss/uart401.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/sound/oss/uart401.c b/sound/oss/uart401.c

[PATCH] sound: oss: Remove typedefs wanc_info and wavnc_port_info

2014-08-06 Thread Himangi Saraogi
{ ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- sound/oss/waveartist.c | 157 - 1 file changed, 89 insertions(+), 68 deletions(-) diff

[PATCH] fs/befs/btree.c: Remove typedef befs_btree_node

2014-08-06 Thread Himangi Saraogi
; @@ coccinelle.tdres = td; @@ type tn1.td; identifier tf.tdres; @@ -typedef struct + tdres { ... } -td ; @@ type tn1.td; identifier tf.tdres; @@ -td + struct tdres Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- fs/befs/btree.c | 53

[PATCH] x86: mtrr/cyrix.c : Remove typedef arr_state_t

2014-08-06 Thread Himangi Saraogi
-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- arch/x86/kernel/cpu/mtrr/cyrix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/cyrix.c b/arch/x86/kernel/cpu/mtrr/cyrix.c index 9e451b0..5e8d57d 100644

[PATCH] nfs: Remove typedef nfs_readdir_descriptor_t

2014-08-06 Thread Himangi Saraogi
tdres ) Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- fs/nfs/dir.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 7e17687..ba5bb19 100644 --- a/fs

[PATCH] xfs: Remove typedef xfs_uu_t

2014-08-06 Thread Himangi Saraogi
-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- fs/xfs/uuid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c index b83f76b..1f21d8f 100644 --- a/fs/xfs/uuid.c +++ b/fs/xfs/uuid.c @@ -18,13 +18,13

[PATCH] pcmcia: Remove typedef in structs and emum

2014-08-06 Thread Himangi Saraogi
Coccinelle semantic patch detects the cases for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- drivers/pcmcia

[PATCH] pcmcia/vrc4171: Remove typedefs for enums and struct

2014-08-06 Thread Himangi Saraogi
-like. The following Coccinelle semantic patch detects the cases for struct type: @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr

[PATCH] sound/oss/pss: Remove typedefs pss_mixerdata and pss_confdata

2014-08-05 Thread Himangi Saraogi
; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- sound/oss/pss.c | 46 -- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/sound/oss/pss.c b/sound/oss/pss.c index 145e36b

[PATCH] sound/oss/opl3: Remove typedef opl_devinfo

2014-08-05 Thread Himangi Saraogi
This typedef is unnecessary and should just be removed as they are never used. The following Coccinelle semantic patch detects the case. @tn@ identifier i; type td; @@ -typedef struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked

[PATCH] netfilter: h323: Remove typedefs from structs

2014-08-05 Thread Himangi Saraogi
{ ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/netfilter/nf_conntrack_h323_asn1.c | 110 +- net/netfilter/nf_conntrack_h323_types.c | 346 2 files changed, 234 insertions

[PATCH] netfilter: h323: Remove typedefs from structs

2014-08-05 Thread Himangi Saraogi
{ ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- net/netfilter/nf_conntrack_h323_asn1.c | 110 +- net/netfilter/nf_conntrack_h323_types.c | 346

  1   2   3   4   5   6   >