Re: [PATCH] mmc: sdhci-xenon: kill xenon_clean_phy()

On 2017/5/16 14:17, Jisheng Zhang wrote: > Currently, the xenon_clean_phy() is only used for freeing phy_params. > The phy_params is allocated by devm_kzalloc(), there's no need to free > is explicitly. > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Thanks for the f

Re: [PATCH] mmc: sdhci-xenon: kill xenon_clean_phy()

On 2017/5/16 14:17, Jisheng Zhang wrote: > Currently, the xenon_clean_phy() is only used for freeing phy_params. > The phy_params is allocated by devm_kzalloc(), there's no need to free > is explicitly. > > Signed-off-by: Jisheng Zhang Thanks for the fix. Acked-by Hu Ziji B

Re: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > -- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji <huz...@marvell.com> >> >> Marvell Xenon SDHC can support eMMC/

Re: [PATCH v7 06/13] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

Hi Rob, On 2017/4/4 0:19, Rob Herring wrote: > -- > On Thu, Mar 30, 2017 at 05:22:58PM +0200, Gregory CLEMENT wrote: >> From: Hu Ziji >> >> Marvell Xenon SDHC can support eMMC/SD/SDIO. >> Add Xeno

Re: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller

therefore sdhci_start_signal_voltage_switch() is skipped. Currently, Xenon driver directly checks if Vqmmc regulator is provided. Skip sdhci_start_signal_voltage_switch() if Vqmmc is fixed. In my own opinion, it is more direct and clear, than checking eMMC card type. Thank you. Best regards, Hu Ziji > Thanks. >

Re: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller

therefore sdhci_start_signal_voltage_switch() is skipped. Currently, Xenon driver directly checks if Vqmmc regulator is provided. Skip sdhci_start_signal_voltage_switch() if Vqmmc is fixed. In my own opinion, it is more direct and clear, than checking eMMC card type. Thank you. Best regards, Hu Ziji > Thanks. >