Re: exfatprogs-1.0.3 version released

2020-07-01 Thread Hyunchul Lee
Hello Sedat, For v1.0.3 and later releases, we can provide tar.xz tarballs, hashes and detached signatures. But is there a reason why hashes are required despite the signature? We will let you know when it's done. Thanks. Regards, Hyunchul 2020년 6월 30일 (화) 오후 7:16, Sedat Dilek 님이 작성: > > On

[PATCH v2] exfat: call sync_filesystem for read-only remount

2020-06-15 Thread Hyunchul Lee
have a chance to commit metadata and vfs invalidates page caches in a block device. Signed-off-by: Hyunchul Lee --- Changes from v1: - Does not check the return value of sync_filesystem to allow to change from "rw" to "ro" even when this function fails. - Add the detailed exp

Re: [PATCH 2/2] exfat: allow to change some mount options for remount

2020-06-14 Thread Hyunchul Lee
2020년 6월 15일 (월) 오전 9:18, Namjae Jeon 님이 작성: > > > Allow to change permission masks, allow_utime, errors. But ignore other > > options. > > > > Signed-off-by: Hyunchul Lee > > --- > > fs/exfat/super.c | 40 +--- &g

Re: [PATCH 1/2] exfat: call sync_filesystem for read-only remount

2020-06-14 Thread Hyunchul Lee
device. I will put this explanation in a commit message. > > > > Signed-off-by: Hyunchul Lee > > --- > > fs/exfat/super.c | 19 +++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/fs/exfat/super.c b/fs/exfat/super.c index > > e65

[PATCH 1/2] exfat: call sync_filesystem for read-only remount

2020-06-12 Thread Hyunchul Lee
We need to commit dirty metadata and pages to disk before remounting exfat as read-only. This fixes a failure in xfstests generic/452 Signed-off-by: Hyunchul Lee --- fs/exfat/super.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/fs/exfat/super.c b/fs/exfat/super.c

[PATCH 2/2] exfat: allow to change some mount options for remount

2020-06-12 Thread Hyunchul Lee
Allow to change permission masks, allow_utime, errors. But ignore other options. Signed-off-by: Hyunchul Lee --- fs/exfat/super.c | 40 +--- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/fs/exfat/super.c b/fs/exfat/super.c index 61c6cf240c19

[PATCH v3] f2fs: add nowait aio support

2018-03-08 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> This patch adds nowait aio support[1]. Return EAGAIN if any of the following checks fail for direct I/O: - i_rwsem is not lockable - Blocks are not allocated at the write location And xfstests generic/471 is passed. [1]: 6be96d "Introduce

[PATCH v3] f2fs: add nowait aio support

2018-03-08 Thread Hyunchul Lee
From: Hyunchul Lee This patch adds nowait aio support[1]. Return EAGAIN if any of the following checks fail for direct I/O: - i_rwsem is not lockable - Blocks are not allocated at the write location And xfstests generic/471 is passed. [1]: 6be96d "Introduce RWF_N

[PATCH v2] f2fs: add nowait aio support

2018-03-07 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> This patch adds nowait aio support[1]. Return EAGAIN if any of the following checks fail for direct I/O: - i_rwsem is not lockable - Blocks are not allocated at the write location And xfstests generic/471 is passed. [1]: 6be96d "Introduce

[PATCH v2] f2fs: add nowait aio support

2018-03-07 Thread Hyunchul Lee
From: Hyunchul Lee This patch adds nowait aio support[1]. Return EAGAIN if any of the following checks fail for direct I/O: - i_rwsem is not lockable - Blocks are not allocated at the write location And xfstests generic/471 is passed. [1]: 6be96d "Introduce RWF_N

[PATCH] f2fs: add nowait aio support

2018-03-01 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> This patch adds nowait aio support[1]. Return EAGAIN if any of the following checks fail for direct I/O: - i_rwsem is not lockable - Blocks are not allocated at the write location And xfstests generic/471 is passed. [1]: 6be96d "Introduce

[PATCH] f2fs: add nowait aio support

2018-03-01 Thread Hyunchul Lee
From: Hyunchul Lee This patch adds nowait aio support[1]. Return EAGAIN if any of the following checks fail for direct I/O: - i_rwsem is not lockable - Blocks are not allocated at the write location And xfstests generic/471 is passed. [1]: 6be96d "Introduce RWF_N

[PATCH v2 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Add the 'whint_mode' mount option that controls which write hints are passed down to block layer. There are "off" and "user-based" mode. The default mode is "off". 1) whint_mode=off. F2FS only passes down WRITE_LIFE_NOT_

[PATCH v2 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee Add the 'whint_mode' mount option that controls which write hints are passed down to block layer. There are "off" and "user-based" mode. The default mode is "off". 1) whint_mode=off. F2FS only passes down WRITE_LIFE_NOT_SET. 2) whint_mode=user-

[PATCH v2 3/3] f2fs: Add the 'whint_mode' mount option to f2fs documentation

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Signed-off-by: Hyunchul Lee <cheol@lge.com> --- Documentation/filesystems/f2fs.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt index 13c2ff0..41

[PATCH v2 3/3] f2fs: Add the 'whint_mode' mount option to f2fs documentation

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee Signed-off-by: Hyunchul Lee --- Documentation/filesystems/f2fs.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt index 13c2ff0..414a160 100644 --- a/Documentation/filesystems/f2fs.txt +++ b

[PATCH v2 2/3] f2fs: support passing down write hints to block layer with F2FS policy

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes down write hints with its policy. * whint_mode=fs-based. F2FS passes down hints with its policy. User F2FS

[PATCH v2 2/3] f2fs: support passing down write hints to block layer with F2FS policy

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes down write hints with its policy. * whint_mode=fs-based. F2FS passes down hints with its policy. User F2FS Block

[PATCH v2 0/3] f2fs: support passing down write hints to block layer

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Changes since version 1: - Set 'whint_mode' to off if 'active_logs' is two or four - Minor fixes suggested by Chao This set implements passing down write hints to block layer with the following mapping. This mapping equals the conclusion from disc

[PATCH v2 0/3] f2fs: support passing down write hints to block layer

2018-01-30 Thread Hyunchul Lee
From: Hyunchul Lee Changes since version 1: - Set 'whint_mode' to off if 'active_logs' is two or four - Minor fixes suggested by Chao This set implements passing down write hints to block layer with the following mapping. This mapping equals the conclusion from discussion in the link, https

Re: [f2fs-dev] [PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-28 Thread Hyunchul Lee
On 01/26/2018 11:10 AM, Chao Yu wrote: > On 2018/1/26 7:46, Hyunchul Lee wrote: >> On 01/25/2018 05:01 PM, Chao Yu wrote: >>> Hi Hyunchul, >>> >>> On 2018/1/25 10:47, Hyunchul Lee wrote: >>>> Hi Chao, >>>> >>>> On 01/25/20

Re: [f2fs-dev] [PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-28 Thread Hyunchul Lee
On 01/26/2018 11:10 AM, Chao Yu wrote: > On 2018/1/26 7:46, Hyunchul Lee wrote: >> On 01/25/2018 05:01 PM, Chao Yu wrote: >>> Hi Hyunchul, >>> >>> On 2018/1/25 10:47, Hyunchul Lee wrote: >>>> Hi Chao, >>>> >>>> On 01/25/20

Re: [f2fs-dev] [PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-25 Thread Hyunchul Lee
On 01/25/2018 05:01 PM, Chao Yu wrote: > Hi Hyunchul, > > On 2018/1/25 10:47, Hyunchul Lee wrote: >> Hi Chao, >> >> On 01/25/2018 12:32 AM, Chao Yu wrote: >>> On 2018/1/22 18:49, Hyunchul Lee wrote: >>>> From: Hyunchul Lee <cheol@l

Re: [f2fs-dev] [PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-25 Thread Hyunchul Lee
On 01/25/2018 05:01 PM, Chao Yu wrote: > Hi Hyunchul, > > On 2018/1/25 10:47, Hyunchul Lee wrote: >> Hi Chao, >> >> On 01/25/2018 12:32 AM, Chao Yu wrote: >>> On 2018/1/22 18:49, Hyunchul Lee wrote: >>>> From: Hyunchul Lee >>>> >

Re: [f2fs-dev] [PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-24 Thread Hyunchul Lee
Hi Chao, On 01/25/2018 12:32 AM, Chao Yu wrote: > On 2018/1/22 18:49, Hyunchul Lee wrote: >> From: Hyunchul Lee <cheol@lge.com> >> >> Add the 'whint_mode' mount option that controls which write >> hints are passed down to block layer. There are "off"

Re: [f2fs-dev] [PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-24 Thread Hyunchul Lee
Hi Chao, On 01/25/2018 12:32 AM, Chao Yu wrote: > On 2018/1/22 18:49, Hyunchul Lee wrote: >> From: Hyunchul Lee >> >> Add the 'whint_mode' mount option that controls which write >> hints are passed down to block layer. There are "off" and >> "user

[PATCH 2/3] f2fs: support passing down write hints to block layer with F2FS policy

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes down write hints with its policy. * whint_mode=fs-based. F2FS passes down hints with its policy. User F2FS

[PATCH 2/3] f2fs: support passing down write hints to block layer with F2FS policy

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes down write hints with its policy. * whint_mode=fs-based. F2FS passes down hints with its policy. User F2FS Block

[PATCH 0/3] f2fs: support passing down write hints to block layer

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> This set implements passing down write hints to block layer with the following mapping. This mapping equals the conclusion from discussion in the link, https://sourceforge.net/p/linux-f2fs/mailman/message/36170969/ But there are two exceptio

[PATCH 3/3] f2fs: Add the 'whint_mode' mount option to f2fs documentation

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Signed-off-by: Hyunchul Lee <cheol@lge.com> --- Documentation/filesystems/f2fs.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt index 13c2ff0..41

[PATCH 0/3] f2fs: support passing down write hints to block layer

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee This set implements passing down write hints to block layer with the following mapping. This mapping equals the conclusion from discussion in the link, https://sourceforge.net/p/linux-f2fs/mailman/message/36170969/ But there are two exceptions. (1) the 'iohint_mode' mount

[PATCH 3/3] f2fs: Add the 'whint_mode' mount option to f2fs documentation

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee Signed-off-by: Hyunchul Lee --- Documentation/filesystems/f2fs.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/filesystems/f2fs.txt b/Documentation/filesystems/f2fs.txt index 13c2ff0..414a160 100644 --- a/Documentation/filesystems/f2fs.txt +++ b

[PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Add the 'whint_mode' mount option that controls which write hints are passed down to block layer. There are "off" and "user-based" mode. The default mode is "off". 1) whint_mode=user-based. F2FS tries to p

[PATCH 1/3] f2fs: support passing down write hints given by users to block layer

2018-01-22 Thread Hyunchul Lee
From: Hyunchul Lee Add the 'whint_mode' mount option that controls which write hints are passed down to block layer. There are "off" and "user-based" mode. The default mode is "off". 1) whint_mode=user-based. F2FS tries to pass down hints given by user

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-27 Thread Hyunchul Lee
Hi Jaegeuk, On 12/28/2017 12:26 PM, Jaegeuk Kim wrote: > On 12/23, Chao Yu wrote: >> On 2017/12/15 10:06, Jaegeuk Kim wrote: >>> On 12/14, Hyunchul Lee wrote: >>>> Hi Jaegeuk, >>>> >>>> I need your comment about the fs_iohint mount option. &

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-27 Thread Hyunchul Lee
Hi Jaegeuk, On 12/28/2017 12:26 PM, Jaegeuk Kim wrote: > On 12/23, Chao Yu wrote: >> On 2017/12/15 10:06, Jaegeuk Kim wrote: >>> On 12/14, Hyunchul Lee wrote: >>>> Hi Jaegeuk, >>>> >>>> I need your comment about the fs_iohint mount option. &

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-17 Thread Hyunchul Lee
Hi Jaegeuk, Agreed. If Chao agrees with this policy, I will implement it. Thanks for the comment. On 12/15/2017 11:06 AM, Jaegeuk Kim wrote: > On 12/14, Hyunchul Lee wrote: >> Hi Jaegeuk, >> >> I need your comment about the fs_iohint mount option. >> >> a) w/

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-17 Thread Hyunchul Lee
Hi Jaegeuk, Agreed. If Chao agrees with this policy, I will implement it. Thanks for the comment. On 12/15/2017 11:06 AM, Jaegeuk Kim wrote: > On 12/14, Hyunchul Lee wrote: >> Hi Jaegeuk, >> >> I need your comment about the fs_iohint mount option. >> >> a) w/

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-13 Thread Hyunchul Lee
for users, and LIFE_SHORT and LIFE_EXTREME is converted to different hints by F2FS. Thanks. On 12/12/2017 11:45 AM, Chao Yu wrote: > Hi Hyunchul, > > On 2017/12/12 10:15, Hyunchul Lee wrote: >> Hi Chao, >> >> On 12/11/2017 10:15 PM, Chao Yu wrote: >>> Hi

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-13 Thread Hyunchul Lee
for users, and LIFE_SHORT and LIFE_EXTREME is converted to different hints by F2FS. Thanks. On 12/12/2017 11:45 AM, Chao Yu wrote: > Hi Hyunchul, > > On 2017/12/12 10:15, Hyunchul Lee wrote: >> Hi Chao, >> >> On 12/11/2017 10:15 PM, Chao Yu wrote: >>> Hi

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-11 Thread Hyunchul Lee
Hi Chao, On 12/11/2017 10:15 PM, Chao Yu wrote: > Hi Hyunchul, > > On 2017/12/1 16:28, Hyunchul Lee wrote: >> Hi Chao, >> >> On 11/30/2017 04:06 PM, Chao Yu wrote: >>> Hi Hyunchul, >>> >>> On 2017/11/28 8:23, Hyunchul

Re: [f2fs-dev] [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-11 Thread Hyunchul Lee
Hi Chao, On 12/11/2017 10:15 PM, Chao Yu wrote: > Hi Hyunchul, > > On 2017/12/1 16:28, Hyunchul Lee wrote: >> Hi Chao, >> >> On 11/30/2017 04:06 PM, Chao Yu wrote: >>> Hi Hyunchul, >>> >>> On 2017/11/28 8:23, Hyunchul Lee wrote: >>

Re: [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-01 Thread Hyunchul Lee
Hi Jaegeuk, On 12/01/2017 04:28 PM, Jaegeuk Kim wrote: > On 11/30, Chao Yu wrote: >> On 2017/11/28 8:23, Hyunchul Lee wrote: >>> From: Hyunchul Lee <cheol@lge.com> >>> >>> This implements which hint is passed down to block layer >>> for da

Re: [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-01 Thread Hyunchul Lee
Hi Jaegeuk, On 12/01/2017 04:28 PM, Jaegeuk Kim wrote: > On 11/30, Chao Yu wrote: >> On 2017/11/28 8:23, Hyunchul Lee wrote: >>> From: Hyunchul Lee >>> >>> This implements which hint is passed down to block layer >>> for datas from th

Re: [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-01 Thread Hyunchul Lee
Hi Chao, On 11/30/2017 04:06 PM, Chao Yu wrote: > Hi Hyunchul, > > On 2017/11/28 8:23, Hyunchul Lee wrote: >> From: Hyunchul Lee <cheol@lge.com> >> >> This implements which hint is passed down to block layer >> for datas from the sp

Re: [PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-12-01 Thread Hyunchul Lee
Hi Chao, On 11/30/2017 04:06 PM, Chao Yu wrote: > Hi Hyunchul, > > On 2017/11/28 8:23, Hyunchul Lee wrote: >> From: Hyunchul Lee >> >> This implements which hint is passed down to block layer >> for datas from the specific segment type. >> &g

[PATCH v2] f2fs: apply write hints to select the type of segment for direct write

2017-11-27 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> When blocks are allocated for direct write, select the type of segment using the kiocb hint. But if an inode has FI_NO_ALLOC, use the inode hint. Signed-off-by: Hyunchul Lee <cheol@lge.com> --- v2: - Add a new member, m_seg_ty

[PATCH 2/2] f2fs: pass down write hints to block layer for direct write

2017-11-27 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> This implements which hint is passed down to block layer for direct write. (allocated file hintsegment type) io hint -- WRITE_LIFE_SHORT HOT_DATAWRITE_LIFE_

[PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-11-27 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> This implements which hint is passed down to block layer for datas from the specific segment type. segment type hints - COLD_NODE & COLD_DATAWRITE_LIFE_EXTREME

[PATCH 1/2] f2fs: pass down write hints to block layer for bufferd write

2017-11-27 Thread Hyunchul Lee
From: Hyunchul Lee This implements which hint is passed down to block layer for datas from the specific segment type. segment type hints - COLD_NODE & COLD_DATAWRITE_LIFE_EXTREME WARM_

[PATCH v2] f2fs: apply write hints to select the type of segment for direct write

2017-11-27 Thread Hyunchul Lee
From: Hyunchul Lee When blocks are allocated for direct write, select the type of segment using the kiocb hint. But if an inode has FI_NO_ALLOC, use the inode hint. Signed-off-by: Hyunchul Lee --- v2: - Add a new member, m_seg_type to struct f2fs_map_blocks. - Assign the segment type

[PATCH 2/2] f2fs: pass down write hints to block layer for direct write

2017-11-27 Thread Hyunchul Lee
From: Hyunchul Lee This implements which hint is passed down to block layer for direct write. (allocated file hintsegment type) io hint -- WRITE_LIFE_SHORT HOT_DATAWRITE_LIFE_MEDIUM WRITE_LIFE_EXTREME

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-19 Thread Hyunchul Lee
On 11/18/2017 03:53 AM, Jaegeuk Kim wrote: > ... >>>>>>>>>>>>>>>>> From: Hyunchul Lee <cheol@lge.com> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-19 Thread Hyunchul Lee
On 11/18/2017 03:53 AM, Jaegeuk Kim wrote: > ... >>>>>>>>>>>>>>>>> From: Hyunchul Lee >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Using write hi

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-15 Thread Hyunchul Lee
On 11/16/2017 12:58 PM, Jaegeuk Kim wrote: > On 11/16, Chao Yu wrote: >> On 2017/11/16 8:56, Hyunchul Lee wrote: >>> >>> On 11/16/2017 01:27 AM, Jaegeuk Kim wrote: >>>> On 11/14, Chao Yu wrote: >>>>> On 2017/11/14 12:20, Jaegeuk Kim wrote: >

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-15 Thread Hyunchul Lee
On 11/16/2017 12:58 PM, Jaegeuk Kim wrote: > On 11/16, Chao Yu wrote: >> On 2017/11/16 8:56, Hyunchul Lee wrote: >>> >>> On 11/16/2017 01:27 AM, Jaegeuk Kim wrote: >>>> On 11/14, Chao Yu wrote: >>>>> On 2017/11/14 12:20, Jaegeuk Kim wrote: >

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-15 Thread Hyunchul Lee
On 11/16/2017 01:27 AM, Jaegeuk Kim wrote: > On 11/14, Chao Yu wrote: >> On 2017/11/14 12:20, Jaegeuk Kim wrote: >>> On 11/13, Hyunchul Lee wrote: >>>> On 11/13/2017 10:59 AM, Chao Yu wrote: >>>>> On 2017/11/13 9:35, Hyunchul Lee wrote:

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-15 Thread Hyunchul Lee
On 11/16/2017 01:27 AM, Jaegeuk Kim wrote: > On 11/14, Chao Yu wrote: >> On 2017/11/14 12:20, Jaegeuk Kim wrote: >>> On 11/13, Hyunchul Lee wrote: >>>> On 11/13/2017 10:59 AM, Chao Yu wrote: >>>>> On 2017/11/13 9:35, Hyunchul Lee wrote:

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-12 Thread Hyunchul Lee
On 11/13/2017 10:59 AM, Chao Yu wrote: > On 2017/11/13 9:35, Hyunchul Lee wrote: >> On 11/13/2017 10:26 AM, Chao Yu wrote: >>> On 2017/11/13 8:24, Hyunchul Lee wrote: >>>> On 11/10/2017 03:42 PM, Chao Yu wrote: >>>>> On 2017/11/10 8:23, Hyunchul Lee wro

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-12 Thread Hyunchul Lee
On 11/13/2017 10:59 AM, Chao Yu wrote: > On 2017/11/13 9:35, Hyunchul Lee wrote: >> On 11/13/2017 10:26 AM, Chao Yu wrote: >>> On 2017/11/13 8:24, Hyunchul Lee wrote: >>>> On 11/10/2017 03:42 PM, Chao Yu wrote: >>>>> On 2017/11/10 8:23, Hyunchul Lee wro

Re: [f2fs-dev] [RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write

2017-11-12 Thread Hyunchul Lee
On 11/13/2017 10:24 AM, Chao Yu wrote: > On 2017/11/13 8:07, Hyunchul Lee wrote: >> On 11/11/2017 09:38 AM, Chao Yu wrote: >>> On 2017/11/9 13:51, Hyunchul Lee wrote: >>>> From: Hyunchul Lee <cheol@lge.com> >>>> >>>> S

Re: [f2fs-dev] [RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write

2017-11-12 Thread Hyunchul Lee
On 11/13/2017 10:24 AM, Chao Yu wrote: > On 2017/11/13 8:07, Hyunchul Lee wrote: >> On 11/11/2017 09:38 AM, Chao Yu wrote: >>> On 2017/11/9 13:51, Hyunchul Lee wrote: >>>> From: Hyunchul Lee >>>> >>>> Select the type of the segment using

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-12 Thread Hyunchul Lee
On 11/13/2017 10:26 AM, Chao Yu wrote: > On 2017/11/13 8:24, Hyunchul Lee wrote: >> On 11/10/2017 03:42 PM, Chao Yu wrote: >>> On 2017/11/10 8:23, Hyunchul Lee wrote: >>>> Hello, Chao >>>> >>>> On 11/09/2017 06:12 PM, Chao Yu wrote: >

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-12 Thread Hyunchul Lee
On 11/13/2017 10:26 AM, Chao Yu wrote: > On 2017/11/13 8:24, Hyunchul Lee wrote: >> On 11/10/2017 03:42 PM, Chao Yu wrote: >>> On 2017/11/10 8:23, Hyunchul Lee wrote: >>>> Hello, Chao >>>> >>>> On 11/09/2017 06:12 PM, Chao Yu wrote: >

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-12 Thread Hyunchul Lee
On 11/10/2017 03:42 PM, Chao Yu wrote: > On 2017/11/10 8:23, Hyunchul Lee wrote: >> Hello, Chao >> >> On 11/09/2017 06:12 PM, Chao Yu wrote: >>> On 2017/11/9 13:51, Hyunchul Lee wrote: >>>> From: Hyunchul Lee <cheol@lge.com> >>>> >

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-12 Thread Hyunchul Lee
On 11/10/2017 03:42 PM, Chao Yu wrote: > On 2017/11/10 8:23, Hyunchul Lee wrote: >> Hello, Chao >> >> On 11/09/2017 06:12 PM, Chao Yu wrote: >>> On 2017/11/9 13:51, Hyunchul Lee wrote: >>>> From: Hyunchul Lee >>>> >>>> Using

Re: [f2fs-dev] [RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write

2017-11-12 Thread Hyunchul Lee
On 11/11/2017 09:38 AM, Chao Yu wrote: > On 2017/11/9 13:51, Hyunchul Lee wrote: >> From: Hyunchul Lee <cheol@lge.com> >> >> Select the type of the segment using write hints, when blocks are >> allocated for direct write. >> >> There are

Re: [f2fs-dev] [RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write

2017-11-12 Thread Hyunchul Lee
On 11/11/2017 09:38 AM, Chao Yu wrote: > On 2017/11/9 13:51, Hyunchul Lee wrote: >> From: Hyunchul Lee >> >> Select the type of the segment using write hints, when blocks are >> allocated for direct write. >> >> There are unhandled corner cases. Hint

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-09 Thread Hyunchul Lee
Hello, Chao On 11/09/2017 06:12 PM, Chao Yu wrote: > On 2017/11/9 13:51, Hyunchul Lee wrote: >> From: Hyunchul Lee <cheol@lge.com> >> >> Using write hints[1], applications can inform the life time of the data >> written to devices. and this[2] reported that t

Re: [RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-09 Thread Hyunchul Lee
Hello, Chao On 11/09/2017 06:12 PM, Chao Yu wrote: > On 2017/11/9 13:51, Hyunchul Lee wrote: >> From: Hyunchul Lee >> >> Using write hints[1], applications can inform the life time of the data >> written to devices. and this[2] reported that the write hints patch

[RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write

2017-11-08 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Select the type of the segment using write hints, when blocks are allocated for direct write. There are unhandled corner cases. Hints are not applied in in-place update. And if the blocks of a file is not pre-allocated because of the invalid user

[RFC PATHC 2/2] f2fs: apply write hints to select the type of segment for direct write

2017-11-08 Thread Hyunchul Lee
From: Hyunchul Lee Select the type of the segment using write hints, when blocks are allocated for direct write. There are unhandled corner cases. Hints are not applied in in-place update. And if the blocks of a file is not pre-allocated because of the invalid user buffer, CURSEG_WARM_DATA

[RFC PATHC 1/2] f2fs: apply write hints to select the type of segments for buffered write

2017-11-08 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Write hints helps F2FS to determine which type of segments would be selected for buffered write. This patch implements the mapping from write hints to segment types as shown below. hints segmen

[RFC PATHC 1/2] f2fs: apply write hints to select the type of segments for buffered write

2017-11-08 Thread Hyunchul Lee
From: Hyunchul Lee Write hints helps F2FS to determine which type of segments would be selected for buffered write. This patch implements the mapping from write hints to segment types as shown below. hints segment type - WRITE_LIFE_SHORT

[RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-08 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Using write hints[1], applications can inform the life time of the data written to devices. and this[2] reported that the write hints patch decreased writes in NAND by 25%. This hints help F2FS to determine the followings. 1) the segment types

[RFC PATCH 0/2] apply write hints to select the type of segments

2017-11-08 Thread Hyunchul Lee
From: Hyunchul Lee Using write hints[1], applications can inform the life time of the data written to devices. and this[2] reported that the write hints patch decreased writes in NAND by 25%. This hints help F2FS to determine the followings. 1) the segment types where the data will be written

[PATCH] ubi: Remove ubi_io_is_bad call from scan_peb

2017-09-25 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> When erase count and volume identifier headers are read, ubi_io_is_bad is called. So instead of calling ubi_io_is_bad from scan_peb, use the result. this patch reduces the attach time by about 15% in my environment. ARMv7 1GHZ based board, 66.8M

[PATCH] ubi: Remove ubi_io_is_bad call from scan_peb

2017-09-25 Thread Hyunchul Lee
From: Hyunchul Lee When erase count and volume identifier headers are read, ubi_io_is_bad is called. So instead of calling ubi_io_is_bad from scan_peb, use the result. this patch reduces the attach time by about 15% in my environment. ARMv7 1GHZ based board, 66.8MiB MTD partition

[PATCH v3] ubifs: Change gfp flags in page allocation for bulk read

2017-06-13 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> In low memory situations, page allocations for bulk read can kill applications for reclaiming memory, and print an failure message when allocations are failed. Because bulk read is just an optimization, we don't have to do these and can stop page alloc

[PATCH v3] ubifs: Change gfp flags in page allocation for bulk read

2017-06-13 Thread Hyunchul Lee
From: Hyunchul Lee In low memory situations, page allocations for bulk read can kill applications for reclaiming memory, and print an failure message when allocations are failed. Because bulk read is just an optimization, we don't have to do these and can stop page allocations. Though

[PATCH v2] ubifs: Change gfp flags in page allocation for bulk read

2017-06-13 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> In low memory situations, page allocations for bulk read can kill applications for reclaiming memory, and print an failure message when allocations are failed. Because bulk read is just an optimization, we don't have to do these and can stop page alloc

[PATCH v2] ubifs: Change gfp flags in page allocation for bulk read

2017-06-13 Thread Hyunchul Lee
From: Hyunchul Lee In low memory situations, page allocations for bulk read can kill applications for reclaiming memory, and print an failure message when allocations are failed. Because bulk read is just an optimization, we don't have to do these and can stop page allocations. Though

[PATCH] ubifs: Change gfp flags in page allocation for bulk read

2017-06-13 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> Use readahead_gfp_mask for gfp flags when allocating pages. This set additional flags which are __GFP_NORETRY and __GFP_NOWARN. So OOMs and a failure message can be avoided. And we should remove __GFP_FS from flags to prevent from calling ubifs_wri

[PATCH] ubifs: Change gfp flags in page allocation for bulk read

2017-06-13 Thread Hyunchul Lee
From: Hyunchul Lee Use readahead_gfp_mask for gfp flags when allocating pages. This set additional flags which are __GFP_NORETRY and __GFP_NOWARN. So OOMs and a failure message can be avoided. And we should remove __GFP_FS from flags to prevent from calling ubifs_writepage during page reclaim

Re: [PATCH] ubifs: Add freeze support

2017-05-29 Thread Hyunchul Lee
On Mon, May 29, 2017 at 10:42:37AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 29.05.2017 um 04:24 schrieb Hyunchul Lee: > >>> This is just broken. First ubifs should still properly propagate > >>> the errors, and second freezing/unfreezing read only file

Re: [PATCH] ubifs: Add freeze support

2017-05-29 Thread Hyunchul Lee
On Mon, May 29, 2017 at 10:42:37AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 29.05.2017 um 04:24 schrieb Hyunchul Lee: > >>> This is just broken. First ubifs should still properly propagate > >>> the errors, and second freezing/unfreezing read only file

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
and I missed the following case. in some embedded systems, clean-up for shutdown should be fast. during this clean-up, freeze file system to guarantee integrity. umount with MNT_DETACH is not suitable because of not killing tasks. On Mon, May 29, 2017 at 10:18:34AM +0900, Hyunchul Lee wrote

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
and I missed the following case. in some embedded systems, clean-up for shutdown should be fast. during this clean-up, freeze file system to guarantee integrity. umount with MNT_DETACH is not suitable because of not killing tasks. On Mon, May 29, 2017 at 10:18:34AM +0900, Hyunchul Lee wrote

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
Hi, Richard. On Mon, May 29, 2017 at 09:43:46AM +0900, Hyunchul Lee wrote: > On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote: > > > +static int ubifs_freeze_super(struct super_block *sb) > > > +{ > > > + struct ubifs_info *c =

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
Hi, Richard. On Mon, May 29, 2017 at 09:43:46AM +0900, Hyunchul Lee wrote: > On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote: > > > +static int ubifs_freeze_super(struct super_block *sb) > > > +{ > > > + struct ubifs_info *c =

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
Hi, Richard. On Fri, May 26, 2017 at 11:52:42AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 26.05.2017 um 01:30 schrieb Hyunchul Lee: > > From: Hyunchul Lee <cheol@lge.com> > > > > for un/freeze support, implement freeze_super and un/

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
Hi, Richard. On Fri, May 26, 2017 at 11:52:42AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 26.05.2017 um 01:30 schrieb Hyunchul Lee: > > From: Hyunchul Lee > > > > for un/freeze support, implement freeze_super and un/freeze_fs > > of super_operations.

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote: > > +static int ubifs_freeze_super(struct super_block *sb) > > +{ > > + struct ubifs_info *c = sb->s_fs_info; > > + int err; > > + > > + dbg_gen("starting"); > > + /* freeze_super always succeeds if file system is in

Re: [PATCH] ubifs: Add freeze support

2017-05-28 Thread Hyunchul Lee
On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote: > > +static int ubifs_freeze_super(struct super_block *sb) > > +{ > > + struct ubifs_info *c = sb->s_fs_info; > > + int err; > > + > > + dbg_gen("starting"); > > + /* freeze_super always succeeds if file system is in

[PATCH] ubifs: Add freeze support

2017-05-25 Thread Hyunchul Lee
From: Hyunchul Lee <cheol@lge.com> for un/freeze support, implement freeze_super and un/freeze_fs of super_operations. ubifs_freeze_super just calls freeze_super. because freeze_super always succeeds if file system is read-only, UBIFS errors should be checked. if there are errors,

[PATCH] ubifs: Add freeze support

2017-05-25 Thread Hyunchul Lee
From: Hyunchul Lee for un/freeze support, implement freeze_super and un/freeze_fs of super_operations. ubifs_freeze_super just calls freeze_super. because freeze_super always succeeds if file system is read-only, UBIFS errors should be checked. if there are errors, UBIFS is switched to read

Re: [PATCH 4/6] ubifs: Maintain a parent pointer

2017-05-22 Thread Hyunchul Lee
Hi Richard, On Mon, May 22, 2017 at 10:45:08AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 22.05.2017 um 06:30 schrieb Hyunchul Lee: > >> + if (move) > >> + old_inode_ui->parent_inum = new_dir->i_ino; > >> + > >>err = u

Re: [PATCH 4/6] ubifs: Maintain a parent pointer

2017-05-22 Thread Hyunchul Lee
Hi Richard, On Mon, May 22, 2017 at 10:45:08AM +0200, Richard Weinberger wrote: > Hyunchul, > > Am 22.05.2017 um 06:30 schrieb Hyunchul Lee: > >> + if (move) > >> + old_inode_ui->parent_inum = new_dir->i_ino; > >> + > >>err = u

Re: [PATCH 4/6] ubifs: Maintain a parent pointer

2017-05-21 Thread Hyunchul Lee
Hi Richard, On Sun, May 21, 2017 at 10:20:49PM +0200, Richard Weinberger wrote: > The new feature UBIFS_FLG_PARENTPOINTER allows looking > up the parent. Usually the Linux VFS walks down the filesystem > and no parent pointers are needed. But when a filesystem > is exportable via NFS such a

Re: [PATCH 4/6] ubifs: Maintain a parent pointer

2017-05-21 Thread Hyunchul Lee
Hi Richard, On Sun, May 21, 2017 at 10:20:49PM +0200, Richard Weinberger wrote: > The new feature UBIFS_FLG_PARENTPOINTER allows looking > up the parent. Usually the Linux VFS walks down the filesystem > and no parent pointers are needed. But when a filesystem > is exportable via NFS such a

  1   2   >