Describe AUTOFS_EXP_FORCED in addition to AUTOFS_EXP_IMMEDIATE in the
description of the AUTOFS_DEV_IOCTL_EXPIRE_CMD ioctl.
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs-mount-control.txt |6 --
Documentation/filesystems/autofs.txt |5 +
2 files
Add a idescription of the "ignore" pseudo mount option that can be
used to provide a generic indicator to applications that the mount
entry should be ignored when displaying mount information.
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs.txt | 15 +
Update the description of AUTOFS_EXP_LEAVES to cover its possible
future use with amd format mount maps.
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs.txt |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/filesystems/autofs.txt
b
A "strictexpire" mount option has been added to the autofs file
system.
It is meant to be used in cases where a GUI continually accesses
or an application frquently scans an automount directory tree
causing an accumulation of otherwise unused mounts.
Signed-off-by: Ian Kent
---
Doc
Alter a few word usages in Documentation/filesystems/autofs.txt
and correct some spelling mistakes.
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs.txt | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/Documentation/filesystems
On Wed, 2019-02-20 at 14:26 +0100, Christian Brauner wrote:
> On Wed, Feb 20, 2019 at 10:46:24AM +0800, Ian Kent wrote:
> > On Fri, 2019-02-15 at 16:07 +, David Howells wrote:
> > > Implement a kernel container object such that it contains the following
> > &g
On Tue, 2019-02-19 at 19:46 -0800, James Bottomley wrote:
> On Wed, 2019-02-20 at 11:04 +0800, Ian Kent wrote:
> > On Tue, 2019-02-19 at 18:20 -0800, James Bottomley wrote:
> > > On Tue, 2019-02-19 at 23:06 +, David Howells wrote:
> > > > James Bottomley wrote:
&
On Tue, 2019-02-19 at 18:20 -0800, James Bottomley wrote:
> On Tue, 2019-02-19 at 23:06 +, David Howells wrote:
> > James Bottomley wrote:
> >
> > > I thought we got agreement years ago that containers don't exist in
> > > Linux as a single entity: they're currently a collection of cgroups
>
On Fri, 2019-02-15 at 16:07 +, David Howells wrote:
> Implement a kernel container object such that it contains the following
> things:
>
> (1) Namespaces.
>
> (2) A root directory.
>
> (3) A set of processes, including one designated as the 'init' process.
Yeah, I think a name other tha
prior to 8th February 2019 used
pipe2(p, O_NONBLOCK|O_CLOEXEC)
and thus (inadvertently) set this flag.
Signed-off-by: NeilBrown
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autofs_i.h
index
On Mon, 2019-02-11 at 10:37 +1100, NeilBrown wrote:
> autofs does not expect the pipe it is given
> to have O_NONBLOCK set - specifically if __kernel_write()
> in autofs_write() returns -EAGAIN, this is treated
> as a fatal error and the pipe is closed.
>
> For safety autofs should, therefore, cle
Fix checkpatch.sh WARNING about the use of seq_printf() to print simple
strings in autofs_show_options(), use seq_puts() in this case.
Signed-off-by: Ian Kent
---
fs/autofs/inode.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/autofs/inode.c b/fs/autofs
On Tue, 2019-01-29 at 20:58 -0800, Andrew Morton wrote:
> On Wed, 30 Jan 2019 10:07:15 +0800 Ian Kent wrote:
>
> > On Tue, 2019-01-29 at 17:16 -0800, Andrew Morton wrote:
> > > On Sat, 12 Jan 2019 08:00:40 +0800 Ian Kent wrote:
> > >
> > > > Add an a
On Wed, 2019-01-30 at 04:18 +, Al Viro wrote:
> On Wed, Jan 30, 2019 at 10:44:15AM +0800, Ian Kent wrote:
>
> > Al,
> >
> > On a different note the above request also raised another
> > question about statvfs(3) automount behaviour.
> >
> > In glib
On Wed, 2019-01-30 at 10:07 +0800, Ian Kent wrote:
> On Tue, 2019-01-29 at 17:16 -0800, Andrew Morton wrote:
> > On Sat, 12 Jan 2019 08:00:40 +0800 Ian Kent wrote:
> >
> > > Add an autofs file system mount option that can be used to provide
> > > a generic i
On Tue, 2019-01-29 at 17:16 -0800, Andrew Morton wrote:
> On Sat, 12 Jan 2019 08:00:40 +0800 Ian Kent wrote:
>
> > Add an autofs file system mount option that can be used to provide
> > a generic indicator to applications that the mount entry should be
> > ignor
Add an autofs file system mount option that can be used to provide
a generic indicator to applications that the mount entry should be
ignored when displaying mount information.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |1 +
fs/autofs/inode.c|9
In autofs_fill_super() on error of get inode/make root dentry the
return should be ENOMEM as this is the only failure case of the
called functions.
Signed-off-by: Ian Kent
---
fs/autofs/inode.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/autofs/inode.c b/fs
: Pan Bian
Acked-by: Ian Kent
---
fs/autofs/expire.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c
index d441244b79df..28d9c2b1b3bb 100644
--- a/fs/autofs/expire.c
+++ b/fs/autofs/expire.c
@@ -596,7 +596,6 @@ int autofs_expire_run
On Tue, 2018-12-18 at 13:09 -0800, Andrew Morton wrote:
> On Tue, 18 Dec 2018 19:34:57 +0800 Ian Kent wrote:
>
> > > See
> > >
https://www.ozlabs.org/~akpm/mmotm/broken-out/autofs-fix-possible-inode-leak-in-autofs_fill_super.patch
> > >
> > > I
On Tue, 2018-12-18 at 14:19 +0100, Dmitry Vyukov wrote:
> On Tue, Dec 18, 2018 at 1:42 PM Ian Kent wrote:
> >
> > On Tue, 2018-12-18 at 13:27 +0100, Dmitry Vyukov wrote:
> > > On Tue, Dec 18, 2018 at 12:35 PM Ian Kent wrote:
> > > >
> > > > O
On Tue, 2018-12-18 at 13:27 +0100, Dmitry Vyukov wrote:
> On Tue, Dec 18, 2018 at 12:35 PM Ian Kent wrote:
> >
> > On Tue, 2018-12-18 at 18:42 +0800, Ian Kent wrote:
> > > On Mon, 2018-12-17 at 07:21 +, Al Viro wrote:
> > > > On Sun, Dec 16, 20
On Tue, 2018-12-18 at 13:01 +0200, Amir Goldstein wrote:
> On Tue, Dec 18, 2018 at 12:43 PM Ian Kent wrote:
> >
> > On Mon, 2018-12-17 at 07:21 +, Al Viro wrote:
> > > On Sun, Dec 16, 2018 at 10:11:04PM -0800, syzbot wrote:
> > > > Hello,
> > > &
On Tue, 2018-12-18 at 18:42 +0800, Ian Kent wrote:
> On Mon, 2018-12-17 at 07:21 +, Al Viro wrote:
> > On Sun, Dec 16, 2018 at 10:11:04PM -0800, syzbot wrote:
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD
hrough inode eviction) since then...
Sorry Al, that's my bad.
See
https://www.ozlabs.org/~akpm/mmotm/broken-out/autofs-fix-possible-inode-leak-in-autofs_fill_super.patch
I think this will fix it, I'll forward it to Andrew if you agree:
autofs - fix handling of d_make_root() return in
On Mon, 2018-11-26 at 09:58 +0800, Pan Bian wrote:
> The function autofs_expire_run calls dput(dentry) to drop the reference
> count of dentry. However, dentry is read via autofs_dentry_ino(dentry)
> after that. This may result in a use-free-bug. The patch drops the
> reference count of dentry only
On Fri, 2018-11-23 at 15:29 -0800, Andrew Morton wrote:
> On Fri, 23 Nov 2018 18:41:50 +0800 Ian Kent wrote:
>
> > Al Viro made some suggestions to improve the implementation
> > of commit 0633da48f0 "fix autofs_sbi() does not check super
> > block type".
> &
dating the last use on path
walk access).
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |1 +
fs/autofs/inode.c|8 +++-
fs/autofs/root.c |5 -
include/uapi/linux/auto_fs.h |2 +-
4 files changed, 13 insertions(+), 3 deletions(-)
diff
Change the super block info. catatonic setting to be part of a
flags bit field.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |7 +--
fs/autofs/dev-ioctl.c |4 ++--
fs/autofs/inode.c |4 ++--
fs/autofs/root.c | 11 ++-
fs/autofs/waitq.c | 10
There is no check at all for a failure to allocate the root inode
in autofs_fill_super(), handle it.
Signed-off-by: Ian Kent
---
fs/autofs/inode.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c
index 846c052569dd
The parse_options() function uses a long list of parameters, most
of which are present in the super block info structure already.
The mount parameters set in parse_options() options don't require
cleanup so using the super block info struct directly is simpler.
---
fs/autofs/inode.c | 55 ++
ommon case where it isn't
needed.
So it's sufficient to do this in the ioctl code only.
Also the check in the ioctl code is needlessly complex.
Signed-off-by: Ian Kent
Cc: Al Viro
---
fs/autofs/autofs_i.h |3 +--
fs/autofs/dev-ioctl.c | 25 +++--
fs/autofs/init
- improve file system verification for ioctl case.
- fix potential inode leak in mount code.
- add "strictexpire" autofs mount option.
v2 changes:
- fix compile error.
- deffer some of the mount option re-factoring to try and
avoid any conflicts with linux-next.
---
Ian Kent (5):
e wrong git tree, please drop us a note to help
> improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Ian-Kent/autofs-improve-ioctl-sbi-checks/20181114-021150
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> rep
dating the last use on path
walk accesses).
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |1 +
fs/autofs/inode.c| 13 -
fs/autofs/root.c |5 -
include/uapi/linux/auto_fs.h |2 +-
4 files changed, 18 insertions(+), 3 deletions(-)
di
Change the super block info. catatonic setting to be part of a
flags bit field.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |7 +--
fs/autofs/dev-ioctl.c |4 ++--
fs/autofs/inode.c |4 ++--
fs/autofs/root.c | 11 ++-
fs/autofs/waitq.c | 10
There is no check at all for a failure to allocate the root inode
in autofs_fill_super(), handle it.
Signed-off-by: Ian Kent
---
fs/autofs/inode.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c
index 846c052569dd
Use a structure to hold parsed parameters to simplify the
autofs_parse_options() function call.
Also seperate option parsing and applying the options into
seperate functions.
Signed-off-by: Ian Kent
---
fs/autofs/inode.c | 193 -
1 file
Move the allocation and initialisation of the super block
info struct to its own function.
Signed-off-by: Ian Kent
---
fs/autofs/inode.c | 46 ++
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c
ommon case where it isn't
needed.
So it's sufficient to do this in the ioctl code only.
Also the check in the ioctl code is needlessly complex.
Signed-off-by: Ian Kent
Cc: Al Viro
---
fs/autofs/autofs_i.h |3 +--
fs/autofs/dev-ioctl.c | 25 +++--
fs/autofs/init
Hi all,
It's time for a release, autofs-5.1.5.
A few changes of note are:
With the deprecation of the fedfs-utils package it was necessary
to add a couple of binaries from that package for fedfs users to
give them time to migrate away from using fedfs. The binaries
included in autofs are fedfs-m
On Mon, 2018-08-27 at 02:03 +0100, Al Viro wrote:
> On Mon, Aug 20, 2018 at 04:37:09PM +0800, Ian Kent wrote:
> > The autofs_sbi() inline function does not check the super block
> > magic number to verify it has been given an autofs super block.
>
> IMO it's the wrong w
The autofs_sbi() inline function does not check the super block
magic number to verify it has been given an autofs super block.
Reported-by: syzbot+87c3c541582e56943...@syzkaller.appspotmail.com
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |4 +++-
fs/autofs/inode.c|1 -
2 files
On Wed, 2018-07-25 at 08:48 -0700, Casey Schaufler wrote:
> On 7/24/2018 10:39 PM, Ian Kent wrote:
> > On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote:
> > > On 7/24/2018 9:00 AM, David Howells wrote:
> > > > Casey Schaufler wrote:
> > >
On Tue, 2018-07-24 at 11:57 -0700, Casey Schaufler wrote:
> On 7/24/2018 9:00 AM, David Howells wrote:
> > Casey Schaufler wrote:
> >
> > > > (1) Mount topology and reconfiguration change events.
> > >
> > > With the possibility of unprivileged mounting you're going to have to
> > > address acc
On Mon, 2018-07-23 at 09:31 -0700, Casey Schaufler wrote:
> On 7/23/2018 8:25 AM, David Howells wrote:
> > Hi Al,
> >
> > Here's a set of patches to add a general variable-length notification queue
> > concept and to add sources of events for:
>
> Overall I approve. The interface is a bit clunky.
On Thu, 2018-07-05 at 16:58 -0700, Andrew Morton wrote:
> On Tue, 03 Jul 2018 14:45:15 +0800 Ian Kent wrote:
>
> > Initial patch contributed by Tomas Bortoli.
> >
> > The autofs subsystem does not check that the "path" parameter is
> > present for a
ctl command.
To solve it, modify validate_dev_ioctl() function to check that a
path has been provided for ioctl commands that require it.
Signed-off-by: Tomas Bortoli
Signed-off-by: Ian Kent
Reported-by: syzbot+60c837b428dc84e83...@syzkaller.appspotmail.com
---
fs/autofs/dev-ioctl.c | 22 +
On Tue, 2018-07-03 at 07:48 +0200, Dmitry Vyukov wrote:
> On Tue, Jul 3, 2018 at 3:34 AM, Ian Kent wrote:
> > On Mon, 2018-07-02 at 14:15 +0200, Dmitry Vyukov wrote:
> > > On Mon, Jul 2, 2018 at 1:55 PM, tomas wrote:
> > > > Yes, thanks. Please u
t;
> from the original bug report. This this help to keep automatic testing
> process running.
Umm ... should I include this email address on the actual cc when
submitting the patch?
>
> Thanks
>
>
> >
> > On 07/02/2018 12:20 PM, Ian Kent wrote:
> > &
s a dumb mistake.
I'll send it to Andrew Morton, after some fairly simple sanity testing,
with both our Signed-off-by added.
>
> Tomas
>
>
> On 07/02/2018 03:42 AM, Ian Kent wrote:
> > On Mon, 2018-07-02 at 09:10 +0800, Ian Kent wrote:
> > > On Mon, 2018-07
On Mon, 2018-07-02 at 09:10 +0800, Ian Kent wrote:
> On Mon, 2018-07-02 at 00:04 +0200, tomas wrote:
> > Hi,
> >
> > I've looked into this issue found by Syzbot and I made a patch:
> >
> > https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f
On Mon, 2018-07-02 at 00:04 +0200, tomas wrote:
> Hi,
>
> I've looked into this issue found by Syzbot and I made a patch:
>
> https://syzkaller.appspot.com/bug?id=d03abd8b42847f7f69b1d1d7f97208ae425b1163
Umm ... oops!
Thanks for looking into this Tomas.
>
>
> The autofs subsystem does not ch
autofs_expire_direct() isn't used outside of fs/autofs/expire.c
so make it static.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |3 ---
fs/autofs/expire.c |8
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autofs_i.h
ORCED flag to allow implemention of the feature
and bump the protocol version so user space can check if it's
implemented if needed.
Signed-off-by: Ian Kent
---
fs/autofs/expire.c | 62 ++
include/uapi/linux/auto_fs.h |8 +++--
2 fi
Make the usage of the expire flags consistent by naming
the expire flags the same as it is named in the version
5 miscelaneous ioctl parameters and only check the bit
flags when needed.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |2 +-
fs/autofs/expire.c | 61
autofs_expire_indirect() isn't used outside of fs/autofs/expire.c
so make it static.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |3 ---
fs/autofs/expire.c |8
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/autofs/autofs_i.h b/fs/autofs/autof
walks or during expire so jiffies can be used
directly and the global variable "now" removed.
Signed-off-by: Ian Kent
---
fs/autofs/expire.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c
index b332d3f6e730..
rather
than remove the expire leaves functionality.
Signed-off-by: Ian Kent
---
fs/autofs/expire.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c
index 295feec10ea6..41855cdc5630 100644
--- a/fs/autofs/expire.c
+++ b/fs/autofs/expire.c
Andrew,
Very sorry, clearly I have already sent this to you.
Unfortunately I didn't stop this in time, please ignore.
On Tue, 2018-06-19 at 10:50 +0800, Ian Kent wrote:
> Depending on how it is configured the autofs user space daemon can
> leave in use mounts mounted at exit and re
emove directories and symlinks which can be a problem
at restart, as described above.
So return EACCES in the directory, symlink and unlink methods if the
autofs file system is catatonic.
Signed-off-by: Ian Kent
---
fs/autofs/root.c | 33 ++---
1 file change
On Fri, 2018-06-15 at 08:06 +0800, Ian Kent wrote:
Opps, missing Signed-off-by, please add it!
> Depending on how it is configured the autofs user space daemon can
> leave in use mounts mounted at exit and re-connect to them at start
> up. But for this to work best the state of the au
Depending on how it is configured the autofs user space daemon can
leave in use mounts mounted at exit and re-connect to them at start
up. But for this to work best the state of the autofs file system
needs to be left intact over the restart.
Also, at system shutdown, mounts in an autofs file syst
On Fri, 2018-06-01 at 09:35 +0800, Ian Kent wrote:
> On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote:
> > On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote:
> >
> > > > I actually had an alternative approach that I tried out successfully
> > > > bu
On Thu, 2018-05-31 at 17:13 -0700, Andrew Morton wrote:
> On Wed, 30 May 2018 17:18:55 +0800 Ian Kent wrote:
>
> > > I actually had an alternative approach that I tried out successfully
> > > but discarded as being too different from the original code. Just for
> &g
On Wed, 2018-05-30 at 10:41 +0200, Arnd Bergmann wrote:
> On Wed, May 30, 2018 at 2:48 AM, Ian Kent wrote:
> > On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote:
> > > The autofs4 implementation is just a redirect to autofs now, but that
> > > also means we can
On Tue, 2018-05-29 at 11:46 +0200, Arnd Bergmann wrote:
> The autofs4 implementation is just a redirect to autofs now, but that
> also means we can't have both built into the same kernel:
>
> fs/autofs/inode.o: In function `autofs_new_ino':
> inode.c:(.text+0x1b8): multiple definition of `autofs_n
On Mon, 2018-05-28 at 12:39 +0800, Ian Kent wrote:
> On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote:
> > On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote:
> > > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot
> > > wrote:
> > >
> > > &g
On Mon, 2018-05-28 at 12:13 +0800, Ian Kent wrote:
> On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote:
> > On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot wrote:
> >
> > > Hi Andrey,
> > >
> > > I love your patch! Yet something to improve:
&g
On Fri, 2018-05-25 at 20:48 -0700, Andrew Morton wrote:
> On Sat, 26 May 2018 11:31:35 +0800 kbuild test robot wrote:
>
> > Hi Andrey,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on mmotm/master]
> > [cannot apply to v4.17-rc6]
> > [if your patch is appli
tion to it. It
also results in AUTOFS4_FS being removed from .config for any
setting of AUTOFS_FS except n.
Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise
awareness of the change to smooth the transition.
Signed-off-by: Ian Kent
Reported-by: Randy Dunlap
Tested-by: Rand
On 21/05/18 10:08, Randy Dunlap wrote:
> On 05/20/2018 06:04 PM, Ian Kent wrote:
>> Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile
>> failure.
>>
>> It isn't possible to unset one if the other is set because it
>> introduces a circular de
prohibit autoloading of
the autofs module which need to be changed.
Add a comment about this to "possible changes" section of the
autofs4 module help.
Signed-off-by: Ian Kent
---
fs/autofs4/Kconfig |6 ++
1 file changed, 6 insertions(+)
diff --git a/fs/autofs4/Kconfig b/fs/autof
entry which should call attention
to it. It also results in AUTOFS4_FS being removed from .config
for any setting of AUTOFS_FS except n.
Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise
awareness of the change to smooth the transition.
Signed-off-by: Ian Kent
Cc: Randy Dunla
On 21/05/18 08:43, Ian Kent wrote:
>>>
>>> It looks like adding:
>>> depends on AUTOFS_FS = n && AUTOFS_FS != m
>>
>> Hi. Is there a typo on the line above?
LOL, but your point is what does the AUTOFS_FS != m do!
The answer should be no
On 19/05/18 00:22, Randy Dunlap wrote:
> On 05/17/2018 11:09 PM, Ian Kent wrote:
>> On 18/05/18 12:38, Ian Kent wrote:
>>> On 18/05/18 12:23, Randy Dunlap wrote:
>>>> On 05/17/2018 08:50 PM, Ian Kent wrote:
>>>>> On 18/05/18 08:21, Randy Dunlap wro
On 18/05/18 12:38, Ian Kent wrote:
> On 18/05/18 12:23, Randy Dunlap wrote:
>> On 05/17/2018 08:50 PM, Ian Kent wrote:
>>> On 18/05/18 08:21, Randy Dunlap wrote:
>>>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote:
>>>>> The mm-of-the-moment s
On 18/05/18 12:23, Randy Dunlap wrote:
> On 05/17/2018 08:50 PM, Ian Kent wrote:
>> On 18/05/18 08:21, Randy Dunlap wrote:
>>> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote:
>>>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to
>>&g
On 18/05/18 08:21, Randy Dunlap wrote:
> On 05/17/2018 04:26 PM, a...@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2018-05-17-16-26 has been uploaded to
>>
>>http://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> http://www.ozlabs
Remove includes that aren't needed from autofs (and fs/compat_ioctl.c).
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h |2 +-
fs/autofs/dev-ioctl.c | 13 -
fs/autofs/inode.c |6 +-
fs/autofs/root.c |6 --
fs/autofs/waitq.c |4 ---
On 14/05/18 11:15, Al Viro wrote:
> On Mon, May 14, 2018 at 11:03:50AM +0800, Ian Kent wrote:
>> The autofs module has long since been removed so there's no need to have
>> two separate include files for autofs.
>
> Umm... Why does fs/compat_ioctl.c need either include
Copy source files from the autofs4 directory to the autofs directory.
Signed-off-by: Ian Kent
---
fs/autofs/autofs_i.h | 273 ++
fs/autofs/dev-ioctl.c | 761
fs/autofs/expire.c| 632 +
fs/autofs/init.c
Update naming within autofs source to be consistent by changing occurrences
of autofs4 to autofs.
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h | 88
fs/autofs4/dev-ioctl.c | 18 ++-
fs/autofs4/expire.c| 132 ---
fs/autofs4/init.c | 12
Update Kconfig and add a depricated warning.
Signed-off-by: Ian Kent
---
fs/autofs4/Kconfig | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
index 44727bf18297..53bc592a250d 100644
--- a/fs/autofs4
Finally remove autofs4 references in the filesystems documentation.
Signed-off-by: Ian Kent
---
Documentation/filesystems/00-INDEX |4 ++--
Documentation/filesystems/autofs-mount-control.txt |8
Documentation/filesystems/autofs.txt | 10
Create Makefile and Kconfig for autofs module.
Signed-off-by: Ian Kent
---
fs/Kconfig |1 +
fs/Makefile|1 +
fs/autofs/Kconfig | 20
fs/autofs/Makefile |7 +++
4 files changed, 29 insertions(+)
create mode 100644 fs/autofs/Kconfig
create
There are two files in Documentation/filsystems that should now
use autofs rather than autofs4 in their names.
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs-mount-control.txt | 407 +++
Documentation/filesystems/autofs.txt | 529
Delete the now unused autofs4 module files.
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h | 273 --
fs/autofs4/dev-ioctl.c | 761 ---
fs/autofs4/expire.c| 632
fs/autofs4/init.c | 48 --
fs
Update the autofs entry in MAINTAINERS to reflect the rename of
autofs4 to autofs.
Signed-off-by: Ian Kent
---
MAINTAINERS |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 58b9861ccf99..6189ff91fda7 100644
--- a/MAINTAINERS
+++ b
The autofs module has long since been removed so there's no need to have
two separate include files for autofs.
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h |2
fs/compat_ioctl.c |1
include/uapi/linux/auto_fs.h |
Update Makefile to build from source in fs/autofs instead of
fs/autofs4.
Signed-off-by: Ian Kent
---
fs/autofs4/Makefile |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/Makefile b/fs/autofs4/Makefile
index a811c1f7d9ab..417dd726d9ef 100644
--- a/fs/autofs4
On 01/04/18 14:21, Andrei Vagin wrote:
> On Sun, Apr 01, 2018 at 10:01:41AM +0800, Ian Kent wrote:
>> On 01/04/18 09:31, Ian Kent wrote:
>>> On 31/03/18 10:28, Andrei Vagin wrote:
>>>> In "autofs4: use wait_event_killable", wait_event_interruptible()
On 01/04/18 09:31, Ian Kent wrote:
> On 31/03/18 10:28, Andrei Vagin wrote:
>> In "autofs4: use wait_event_killable", wait_event_interruptible() was
>> replaced by wait_event_killable(), but in this case we have to use
>> wake_up() instead of wake_up_interrupt
an be multiple
waiters for a mount, they all should be woken up when the daemon signals
mount completion.
>
> Cc: Matthew Wilcox
> Cc: Ian Kent
> Cc: Andrew Morton
> Cc: Stephen Rothwell
> Signed-off-by: Andrei Vagin
> ---
> fs/autofs4/waitq.c | 2 +-
> 1 file change
On 20/03/18 03:25, David Rientjes wrote:
> On Mon, 19 Mar 2018, Matthew Wilcox wrote:
>
>> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
>> index a0c57c37fa21..c160e9b3aa0f 100644
>> --- a/fs/autofs4/waitq.c
>> +++ b/fs/autofs4/waitq.c
>> @@ -19,9 +19,6 @@
>> */
>> static autofs_wqt_t au
ere.
Predates is an understatement, this is really, really old code.
Do I need to forward this to Al or Andrew?
>
> Signed-off-by: Matthew Wilcox
Signed-off-by: Ian Kent
> ---
> fs/autofs4/waitq.c | 27 +--
> 1 file changed, 1 insertion(+), 26 deleti
On 21/12/17 09:09, NeilBrown wrote:
> 8<---
> Subject: use_hostname_for_mounts shouldn't prevent selection among replica
>
> If several replicas have been specified for a mount point, and
> use_hostname_for_mount is set to "yes", the selection between
> these replicas is curren
On 03/01/18 06:14, NeilBrown wrote:
> On Thu, Dec 21 2017, Ian Kent wrote:
>
>> On 21/12/17 19:06, Ian Kent wrote:
>>> On 21/12/17 09:09, NeilBrown wrote:
>>>> On Wed, Dec 20 2017, Ian Kent wrote:
>>>>
>>>>> On 20/12/17 13:5
On 21/12/17 19:06, Ian Kent wrote:
> On 21/12/17 09:09, NeilBrown wrote:
>> On Wed, Dec 20 2017, Ian Kent wrote:
>>
>>> On 20/12/17 13:52, Ian Kent wrote:
>>>> On 20/12/17 11:29, NeilBrown wrote:
>>>>>
>>>>> Hi Ian,
>>>&g
On 21/12/17 09:09, NeilBrown wrote:
> On Wed, Dec 20 2017, Ian Kent wrote:
>
>> On 20/12/17 13:52, Ian Kent wrote:
>>> On 20/12/17 11:29, NeilBrown wrote:
>>>>
>>>> Hi Ian,
>>>> I've been looking at:
>>>>
>>>
101 - 200 of 724 matches
Mail list logo
