Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause wrote: > This removes unused goto labels in decode crush map functions related > to error paths due to them never being used on any error path for these > particular functions in the file, osdmap.c. > > Signed-off-by: Nicholas Krause > --- >

Re: [PATCH] ceph:Remove unused goto labels in decode crush map functions

On Fri, Oct 2, 2015 at 9:48 PM, Nicholas Krause wrote: > This removes unused goto labels in decode crush map functions related > to error paths due to them never being used on any error path for these > particular functions in the file, osdmap.c. > > Signed-off-by: Nicholas

Re: [PATCH 33/39] rbd: drop null test before destroy functions

On Sun, Sep 13, 2015 at 3:15 PM, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > x =

Re: [PATCH 33/39] rbd: drop null test before destroy functions

On Sun, Sep 13, 2015 at 3:15 PM, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { >

size_t and related types on mn10300

On Thu, Sep 10, 2015 at 10:57 AM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: 22dc312d56ba077db27a9798b340e7d161f1df05 > commit: 5f1c79a71766ba656762636936edf708089bdb14 [12335/12685] libceph: check > data_len in

size_t and related types on mn10300

On Thu, Sep 10, 2015 at 10:57 AM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: 22dc312d56ba077db27a9798b340e7d161f1df05 > commit: 5f1c79a71766ba656762636936edf708089bdb14 [12335/12685] libceph:

[PATCH] sysctl: fix int -> unsigned long assignments in INT_MIN case

v/scsi/logging_level # cat /proc/sys/dev/scsi/logging_level -18446744071562067968 Cast to unsigned long before negation - that way we first sign-extend and then negate an unsigned, which is well defined. With this: # cat /proc/sys/dev/scsi/logging_level -2147483648 Signed-off-by: Ilya D

Re: [PATCH] sysctl: Fix conversion of INT_MIN for LP64 systems

On Sat, Jul 11, 2015 at 10:35 AM, Robert Xiao wrote: > On LP64 systems, reading a sysctl file containing an INT_MIN (-2147483648) > could incorrectly show -18446744071562067968 due to an incorrect conversion > in do_proc_dointvec_conv. This patch fixes the edge case by converting to > unsigned

Re: [PATCH] sysctl: Fix conversion of INT_MIN for LP64 systems

On Sat, Jul 11, 2015 at 10:35 AM, Robert Xiao b...@cs.cmu.edu wrote: On LP64 systems, reading a sysctl file containing an INT_MIN (-2147483648) could incorrectly show -18446744071562067968 due to an incorrect conversion in do_proc_dointvec_conv. This patch fixes the edge case by converting to

[PATCH] sysctl: fix int - unsigned long assignments in INT_MIN case

/logging_level # cat /proc/sys/dev/scsi/logging_level -18446744071562067968 Cast to unsigned long before negation - that way we first sign-extend and then negate an unsigned, which is well defined. With this: # cat /proc/sys/dev/scsi/logging_level -2147483648 Signed-off-by: Ilya Dryomov

Re: linux-next: manual merge of the vfs tree with the ceph tree

On Fri, Jun 26, 2015 at 4:17 AM, Stephen Rothwell wrote: > Hi Al, > > Today's linux-next merge of the vfs tree got a conflict in: > > fs/ceph/dir.c > > between commit: > > fdd4e15838e5 ("ceph: rework dcache readdir") > > from the ceph tree and commit: > > dc3f4198eac1 ("make

Re: linux-next: manual merge of the vfs tree with the ceph tree

On Fri, Jun 26, 2015 at 4:17 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Al, Today's linux-next merge of the vfs tree got a conflict in: fs/ceph/dir.c between commit: fdd4e15838e5 (ceph: rework dcache readdir) from the ceph tree and commit: dc3f4198eac1 (make

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Wed, Jun 17, 2015 at 6:04 AM, juncheng bai wrote: > Hi. > Yeah, you are right, use the default max_segments, the request size can > be the object size, because the bi_phys_segments of bio could be recount, > there's just a possibility. > > I want to fully understand the bi_phys_segments, hope

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Wed, Jun 17, 2015 at 6:04 AM, juncheng bai baijunch...@unitedstack.com wrote: Hi. Yeah, you are right, use the default max_segments, the request size can be the object size, because the bi_phys_segments of bio could be recount, there's just a possibility. I want to fully understand the

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 8:22 PM, nick wrote: > > > On 2015-06-16 01:16 PM, Ilya Dryomov wrote: >> On Tue, Jun 16, 2015 at 8:07 PM, nick wrote: >>> >>> >>> On 2015-06-16 12:47 PM, Ilya Dryomov wrote: >>>> On Tue, Jun 16, 2015 at 7:18 PM

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 8:07 PM, nick wrote: > > > On 2015-06-16 12:47 PM, Ilya Dryomov wrote: >> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: >>> Ilya, >>> That's fine I do have a unrelated question through. I have over 90 patches >>> lying around in

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 7:57 PM, nick wrote: > > > On 2015-06-16 12:47 PM, Ilya Dryomov wrote: >> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: >>> Ilya, >>> That's fine I do have a unrelated question through. I have over 90 patches >>> lying around in

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 7:18 PM, nick wrote: > Ilya, > That's fine I do have a unrelated question through. I have over 90 patches > lying around in terms of cleanups/ > fixes and need help getting them merged. Should I just resend them or wait > until the end of this merge window. Are all of

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov wrote: > On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote: >> This makes the function, crush_ln static now due to having >> only one caller in its own definition and declaration file >> of mapper.c >> >&g

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Tue, Jun 16, 2015 at 5:14 PM, juncheng bai wrote: > > > On 2015/6/16 21:30, Ilya Dryomov wrote: >> >> On Tue, Jun 16, 2015 at 2:57 PM, juncheng bai >> wrote: >>> >>> >>> >>> On 2015/6/16 16:37, Ilya Dryomov wrote: >>&

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Tue, Jun 16, 2015 at 2:57 PM, juncheng bai wrote: > > > On 2015/6/16 16:37, Ilya Dryomov wrote: >> >> On Tue, Jun 16, 2015 at 6:28 AM, juncheng bai >> wrote: >>> >>> >>> >>> On 2015/6/15 22:27, Ilya Dryomov wrote: >>&

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Tue, Jun 16, 2015 at 6:28 AM, juncheng bai wrote: > > > On 2015/6/15 22:27, Ilya Dryomov wrote: >> >> On Mon, Jun 15, 2015 at 4:23 PM, juncheng bai >> wrote: >>> >>> >>> >>> On 2015/6/15 21:03, Ilya Dryomov wrote: >>&

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Tue, Jun 16, 2015 at 2:57 PM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/16 16:37, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 6:28 AM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/15 22:27, Ilya Dryomov wrote: On Mon, Jun 15, 2015 at 4:23 PM, juncheng

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Tue, Jun 16, 2015 at 5:14 PM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/16 21:30, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 2:57 PM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/16 16:37, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 6:28 AM, juncheng

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov idryo...@gmail.com wrote: On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause xerofo...@gmail.com wrote: This makes the function, crush_ln static now due to having only one caller in its own definition and declaration file of mapper.c Signed-off

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 8:07 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups/ fixes and need help getting them merged. Should I just resend them or wait until the end of this merge window.

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 8:22 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 01:16 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 8:07 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 16, 2015 at 7:57 PM, nick xerofo...@gmail.com wrote: On 2015-06-16 12:47 PM, Ilya Dryomov wrote: On Tue, Jun 16, 2015 at 7:18 PM, nick xerofo...@gmail.com wrote: Ilya, That's fine I do have a unrelated question through. I have over 90 patches lying around in terms of cleanups

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Tue, Jun 16, 2015 at 6:28 AM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/15 22:27, Ilya Dryomov wrote: On Mon, Jun 15, 2015 at 4:23 PM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/15 21:03, Ilya Dryomov wrote: On Mon, Jun 15, 2015 at 2:18 PM, juncheng

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Mon, Jun 15, 2015 at 4:23 PM, juncheng bai wrote: > > > On 2015/6/15 21:03, Ilya Dryomov wrote: >> >> On Mon, Jun 15, 2015 at 2:18 PM, juncheng bai >> wrote: >>> >>> From 6213215bd19926d1063d4e01a248107dab8a899b Mon Sep 17 00:00:00 2001 >>

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Mon, Jun 15, 2015 at 2:18 PM, juncheng bai wrote: > From 6213215bd19926d1063d4e01a248107dab8a899b Mon Sep 17 00:00:00 2001 > From: juncheng bai > Date: Mon, 15 Jun 2015 18:34:00 +0800 > Subject: [PATCH] storage:rbd: make the size of request is equal to the > size of the object > > ensures

Re: [PATCH 1/1 linux-next] ceph: use standard Opt_err

On Sun, Jun 14, 2015 at 12:05 PM, Fabian Frederick wrote: > > >> On 08 June 2015 at 09:49 Ilya Dryomov wrote: >> >> >> On Fri, Jun 5, 2015 at 10:12 PM, Fabian Frederick wrote: >> > ceph used -1 for the last match_table_t option. >> > Use

Re: [PATCH 1/1 linux-next] ceph: use standard Opt_err

On Sun, Jun 14, 2015 at 12:05 PM, Fabian Frederick f...@skynet.be wrote: On 08 June 2015 at 09:49 Ilya Dryomov idryo...@gmail.com wrote: On Fri, Jun 5, 2015 at 10:12 PM, Fabian Frederick f...@skynet.be wrote: ceph used -1 for the last match_table_t option. Use Opt_err enum like other FS

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Mon, Jun 15, 2015 at 2:18 PM, juncheng bai baijunch...@unitedstack.com wrote: From 6213215bd19926d1063d4e01a248107dab8a899b Mon Sep 17 00:00:00 2001 From: juncheng bai baijunch...@unitedstack.com Date: Mon, 15 Jun 2015 18:34:00 +0800 Subject: [PATCH] storage:rbd: make the size of request is

Re: [PATCH RFC] storage:rbd: make the size of request is equal to the, size of the object

On Mon, Jun 15, 2015 at 4:23 PM, juncheng bai baijunch...@unitedstack.com wrote: On 2015/6/15 21:03, Ilya Dryomov wrote: On Mon, Jun 15, 2015 at 2:18 PM, juncheng bai baijunch...@unitedstack.com wrote: From 6213215bd19926d1063d4e01a248107dab8a899b Mon Sep 17 00:00:00 2001 From: juncheng

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote: > This makes the function, crush_ln static now due to having > only one caller in its own definition and declaration file > of mapper.c > > Signed-off-by: Nicholas Krause > --- > net/ceph/crush/mapper.c | 2 +- > 1 file changed, 1

Re: [PATCH] crush:Make the function crush_ln static

On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause xerofo...@gmail.com wrote: This makes the function, crush_ln static now due to having only one caller in its own definition and declaration file of mapper.c Signed-off-by: Nicholas Krause xerofo...@gmail.com --- net/ceph/crush/mapper.c | 2 +-

Re: [PATCH 1/1 linux-next] ceph: use standard Opt_err

On Fri, Jun 5, 2015 at 10:12 PM, Fabian Frederick wrote: > ceph used -1 for the last match_table_t option. > Use Opt_err enum like other FS > > match_token() is based on the pattern (NULL) > so behavior should remain the same. > > Signed-off-by: Fabian Frederick > --- > This is untested. If this

Re: [PATCH 1/1 linux-next] ceph: use standard Opt_err

On Fri, Jun 5, 2015 at 10:12 PM, Fabian Frederick f...@skynet.be wrote: ceph used -1 for the last match_table_t option. Use Opt_err enum like other FS match_token() is based on the pattern (NULL) so behavior should remain the same. Signed-off-by: Fabian Frederick f...@skynet.be --- This

Re: [PATCH] libceph: use kvfree() in ceph_put_page_vector()

On Mon, Jun 1, 2015 at 5:36 PM, Geliang Tang wrote: > Use kvfree() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > net/ceph/pagevec.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c > index 096d914..d4f5f22

Re: [PATCH] libceph: use kvfree() in ceph_put_page_vector()

On Mon, Jun 1, 2015 at 5:36 PM, Geliang Tang geliangt...@163.com wrote: Use kvfree() instead of open-coding it. Signed-off-by: Geliang Tang geliangt...@163.com --- net/ceph/pagevec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

On Mon, May 25, 2015 at 6:08 PM, Christoph Hellwig wrote: > On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote: >> I'm not Alex, but yeah, we have all the clone/split machinery and so we >> can handle a spanning case just fine. I think rbd_merge_bvec() exists >>

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig wrote: > On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: >> From: Kent Overstreet >> >> As generic_make_request() is now able to handle arbitrarily sized bios, >> it's no longer necessary for each individual block driver to define its

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

On Mon, May 25, 2015 at 6:08 PM, Christoph Hellwig h...@lst.de wrote: On Mon, May 25, 2015 at 06:02:30PM +0300, Ilya Dryomov wrote: I'm not Alex, but yeah, we have all the clone/split machinery and so we can handle a spanning case just fine. I think rbd_merge_bvec() exists to make sure we

Re: [PATCH v4 08/11] block: kill merge_bvec_fn() completely

On Mon, May 25, 2015 at 5:04 PM, Christoph Hellwig h...@lst.de wrote: On Fri, May 22, 2015 at 11:18:40AM -0700, Ming Lin wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual

Re: randconfig build error with next-20150421, in net/ceph

On Tue, Apr 21, 2015 at 7:21 PM, Sage Weil wrote: > On Tue, 21 Apr 2015, Guenter Roeck wrote: >> On Tue, Apr 21, 2015 at 08:10:44AM -0700, Jim Davis wrote: >> > Building with the attached random configuration file, >> > >> > ERROR: "__divdi3" [net/ceph/libceph.ko] undefined! >> >> Commit 7321f19d

Re: randconfig build error with next-20150421, in net/ceph

On Tue, Apr 21, 2015 at 7:21 PM, Sage Weil s...@newdream.net wrote: On Tue, 21 Apr 2015, Guenter Roeck wrote: On Tue, Apr 21, 2015 at 08:10:44AM -0700, Jim Davis wrote: Building with the attached random configuration file, ERROR: __divdi3 [net/ceph/libceph.ko] undefined! Commit 7321f19d

Re: [trivial PATCH] osdmap.h: Add missing format newlines

On Mon, Mar 23, 2015 at 11:35 PM, Joe Perches wrote: > To avoid possible interleaving, add missing '\n' to formats. Applied. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [trivial PATCH] osdmap.h: Add missing format newlines

On Mon, Mar 23, 2015 at 11:35 PM, Joe Perches j...@perches.com wrote: To avoid possible interleaving, add missing '\n' to formats. Applied. Thanks, Ilya -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 1/1 linux-next] ceph: use %zu for size_t display

On Sat, Jan 3, 2015 at 8:02 PM, Fabian Frederick wrote: > Fixes the following 32-bit compilation warning: > fs/ceph/addr.c:1419:2: warning: format '%lu' expects argument of type > 'long unsigned int', but argument 5 has type 'size_t' [-Wformat=] > > Signed-off-by: Fabian Frederick > --- >

Re: [PATCH] block: rbd.c: Remove unused function

On Thu, Jan 1, 2015 at 7:58 PM, Rickard Strandqvist wrote: > Remove the function copy_token() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/block/rbd.c | 30

Re: [PATCH 1/1 linux-next] ceph: use %zu for size_t display

On Sat, Jan 3, 2015 at 8:02 PM, Fabian Frederick f...@skynet.be wrote: Fixes the following 32-bit compilation warning: fs/ceph/addr.c:1419:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' [-Wformat=] Signed-off-by: Fabian Frederick

Re: [PATCH] block: rbd.c: Remove unused function

On Thu, Jan 1, 2015 at 7:58 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function copy_token() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] net: ceph: ceph_strings.c: Remove unused function

On Sat, Dec 20, 2014 at 3:34 PM, Rickard Strandqvist wrote: > Remove the function ceph_pool_op_name() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. It's part of pool op infrastructure and I'd rather we use it in monc_show()

Re: [PATCH] net: ceph: armor.c: Remove unused function

On Sun, Dec 21, 2014 at 1:36 AM, Rickard Strandqvist wrote: > Remove the function ceph_armor() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. It's ceph_unarmor()'s counterpart - so same as for "[PATCH] net: ceph: crypto.c:

Re: [PATCH] net: ceph: crypto.c: Remove some unused functions

On Sat, Dec 20, 2014 at 7:52 PM, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > ceph_encrypt() ceph_decrypt() ceph_crypto_key_encode() > > This was partially found by using a static code analysis program called > cppcheck. I'd like to keep this stuff even if

Re: [PATCH] ceph: Use %zu to format size_t in ceph_fill_inline_data()

On Sun, Dec 21, 2014 at 1:56 PM, Geert Uytterhoeven wrote: > On 32-bit, where size_t is unsigned int: > > fs/ceph/addr.c: In function ‘ceph_fill_inline_data’: > fs/ceph/addr.c:1419: warning: format ‘%lu’ expects type ‘long unsigned int’, > but argument 10 has type ‘size_t’ > > Signed-off-by:

Re: [PATCH] ceph: Use %zu to format size_t in ceph_fill_inline_data()

On Sun, Dec 21, 2014 at 1:56 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On 32-bit, where size_t is unsigned int: fs/ceph/addr.c: In function ‘ceph_fill_inline_data’: fs/ceph/addr.c:1419: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 10 has type ‘size_t’

Re: [PATCH] net: ceph: crypto.c: Remove some unused functions

On Sat, Dec 20, 2014 at 7:52 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Removes some functions that are not used anywhere: ceph_encrypt() ceph_decrypt() ceph_crypto_key_encode() This was partially found by using a static code analysis program called cppcheck. I'd

Re: [PATCH] net: ceph: armor.c: Remove unused function

On Sun, Dec 21, 2014 at 1:36 AM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function ceph_armor() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It's ceph_unarmor()'s counterpart - so same as for

Re: [PATCH] net: ceph: ceph_strings.c: Remove unused function

On Sat, Dec 20, 2014 at 3:34 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function ceph_pool_op_name() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It's part of pool op infrastructure and I'd

Re: [PATCH 1/1] block-rbd: Delete a check before ceph_put_snap_context()

On Mon, Dec 1, 2014 at 1:23 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 Dec 2014 11:18:21 +0100 > > The ceph_put_snap_context() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was

Re: [PATCH 1/1] block-rbd: Delete a check before ceph_put_snap_context()

On Mon, Dec 1, 2014 at 1:23 PM, SF Markus Elfring elfr...@users.sourceforge.net wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 1 Dec 2014 11:18:21 +0100 The ceph_put_snap_context() function tests whether its argument is NULL and then returns immediately. Thus the test

Re: ceph: Deletion of unnecessary checks before two function calls

On Mon, Nov 3, 2014 at 4:27 PM, SF Markus Elfring wrote: >> dput() also checks for NULL argument, but the check is wrapped into >> unlikely(), which is why I presume it wasn't picked up. It would be >> great if you could improve your coccinelle script to handle >> {un,}likely() as well. > >

Re: [PATCH 1/1] ceph: Deletion of unnecessary checks before two function calls

On Sun, Nov 2, 2014 at 5:20 PM, SF Markus Elfring wrote: > The functions ceph_put_snap_context() and iput() test whether their argument > is NULL and then return immediately. Thus the test around the call > is not needed. > > This issue was detected by using the Coccinelle software. > >

Re: [PATCH 1/1] ceph: Deletion of unnecessary checks before two function calls

On Sun, Nov 2, 2014 at 5:20 PM, SF Markus Elfring elfr...@users.sourceforge.net wrote: The functions ceph_put_snap_context() and iput() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle

Re: ceph: Deletion of unnecessary checks before two function calls

On Mon, Nov 3, 2014 at 4:27 PM, SF Markus Elfring elfr...@users.sourceforge.net wrote: dput() also checks for NULL argument, but the check is wrapped into unlikely(), which is why I presume it wasn't picked up. It would be great if you could improve your coccinelle script to handle

Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply()

On Sat, Oct 25, 2014 at 1:12 PM, Fabian Frederick wrote: > > >> On 23 October 2014 at 18:25 Ilya Dryomov wrote: >> >> >> On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick wrote: >> > osdmap_epoch is redundant with reassert_epoch and unused. &g

Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply()

On Sat, Oct 25, 2014 at 1:12 PM, Fabian Frederick f...@skynet.be wrote: On 23 October 2014 at 18:25 Ilya Dryomov ilya.dryo...@inktank.com wrote: On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick f...@skynet.be wrote: osdmap_epoch is redundant with reassert_epoch and unused. Signed-off

Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply()

On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick wrote: > osdmap_epoch is redundant with reassert_epoch and unused. > > Signed-off-by: Fabian Frederick > --- > net/ceph/osd_client.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c > index

Re: [PATCH 1/1 net-next] libceph: remove unused variable in handle_reply()

On Thu, Oct 23, 2014 at 8:15 PM, Fabian Frederick f...@skynet.be wrote: osdmap_epoch is redundant with reassert_epoch and unused. Signed-off-by: Fabian Frederick f...@skynet.be --- net/ceph/osd_client.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ceph/osd_client.c

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick wrote: > > > On 10/09/2014 02:16 PM, Fabian Frederick wrote: >> Fix some coccinelle warnings: >> fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 > > >> - bool wake = 0; >> + bool wake = false; > > FWIW, that message is backwards: it

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

On Fri, Oct 10, 2014 at 1:16 AM, Fabian Frederick wrote: > Fix some coccinelle warnings: > fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 > fs/ceph/caps.c:2401:6-15: WARNING: Assignment of bool to 0/1 > fs/ceph/caps.c:2402:6-17: WARNING: Assignment of bool to 0/1 >

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

On Fri, Oct 10, 2014 at 1:16 AM, Fabian Frederick f...@skynet.be wrote: Fix some coccinelle warnings: fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2401:6-15: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2402:6-17: WARNING: Assignment of bool to 0/1

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick dan.m...@inktank.com wrote: On 10/09/2014 02:16 PM, Fabian Frederick wrote: Fix some coccinelle warnings: fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1 - bool wake = 0; + bool wake = false; FWIW, that message is backwards:

Re: [PATCH 1/1 linux-next] libceph: remove redundant declaration

On Wed, Oct 1, 2014 at 12:07 AM, Fabian Frederick wrote: > ceph_release_page_vector was defined twice in libceph.h > > Signed-off-by: Fabian Frederick > --- > include/linux/ceph/libceph.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/ceph/libceph.h

Re: [PATCH 1/1 linux-next] libceph: remove redundant declaration

On Wed, Oct 1, 2014 at 12:07 AM, Fabian Frederick f...@skynet.be wrote: ceph_release_page_vector was defined twice in libceph.h Signed-off-by: Fabian Frederick f...@skynet.be --- include/linux/ceph/libceph.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/ceph/libceph.h

Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, Sep 10, 2014 at 4:30 PM, Ilya Dryomov wrote: > On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches wrote: >> Use the more common pr_warn. >> >> Other miscellanea: >> >> o Coalesce formats >> o Realign arguments >> >> Signed-off-by:

Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches wrote: > Use the more common pr_warn. > > Other miscellanea: > > o Coalesce formats > o Realign arguments > > Signed-off-by: Joe Perches > --- > net/ceph/ceph_common.c | 15 +-- > net/ceph/messenger.c | 19 ++- >

Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches wrote: > Use the more common pr_warn. > > Other miscellanea: > > o Coalesce formats > o Realign arguments > > Signed-off-by: Joe Perches > --- > net/ceph/ceph_common.c | 15 +-- > net/ceph/messenger.c | 19 ++- >

Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches j...@perches.com wrote: Use the more common pr_warn. Other miscellanea: o Coalesce formats o Realign arguments Signed-off-by: Joe Perches j...@perches.com --- net/ceph/ceph_common.c | 15 +-- net/ceph/messenger.c | 19

Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches j...@perches.com wrote: Use the more common pr_warn. Other miscellanea: o Coalesce formats o Realign arguments Signed-off-by: Joe Perches j...@perches.com --- net/ceph/ceph_common.c | 15 +-- net/ceph/messenger.c | 19

Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, Sep 10, 2014 at 4:30 PM, Ilya Dryomov ilya.dryo...@inktank.com wrote: On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches j...@perches.com wrote: Use the more common pr_warn. Other miscellanea: o Coalesce formats o Realign arguments Signed-off-by: Joe Perches j...@perches.com --- net

Re: [RFC][PATCH 0/7] nested sleeps, fixes and debug infra

On Tue, Aug 5, 2014 at 5:06 PM, Peter Zijlstra wrote: > On Tue, Aug 05, 2014 at 12:33:16PM +0400, Ilya Dryomov wrote: >> On Mon, Aug 4, 2014 at 2:30 PM, Peter Zijlstra wrote: >> > Hi, >> > >> > Ilya recently tripped over a nested sleep which made Ingo sugg

Re: [RFC][PATCH 0/7] nested sleeps, fixes and debug infra

On Tue, Aug 5, 2014 at 5:06 PM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 05, 2014 at 12:33:16PM +0400, Ilya Dryomov wrote: On Mon, Aug 4, 2014 at 2:30 PM, Peter Zijlstra pet...@infradead.org wrote: Hi, Ilya recently tripped over a nested sleep which made Ingo suggest we

Re: [RFC][PATCH 0/7] nested sleeps, fixes and debug infra

On Mon, Aug 4, 2014 at 2:30 PM, Peter Zijlstra wrote: > Hi, > > Ilya recently tripped over a nested sleep which made Ingo suggest we should > have debug checks for that. So I did some, see patch 7. Of course that > triggered a whole bunch of fail the instant I tried to boot my machine. > > With

Re: [RFC][PATCH 0/7] nested sleeps, fixes and debug infra

On Mon, Aug 4, 2014 at 2:30 PM, Peter Zijlstra pet...@infradead.org wrote: Hi, Ilya recently tripped over a nested sleep which made Ingo suggest we should have debug checks for that. So I did some, see patch 7. Of course that triggered a whole bunch of fail the instant I tried to boot my

Re: [PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point"

On Fri, Aug 1, 2014 at 5:27 PM, Peter Zijlstra wrote: > On Fri, Aug 01, 2014 at 04:56:27PM +0400, Ilya Dryomov wrote: >> I'm going to fix up rbd_request_fn(), but I want to make sure >> I understand this in full. >> >> - Previously the danger of calling blo

Re: [PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point"

On Thu, Jul 31, 2014 at 6:39 PM, Peter Zijlstra wrote: > On Thu, Jul 31, 2014 at 04:30:52PM +0200, Mike Galbraith wrote: >> On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote: >> >> > Smells like maybe current->state != TASK_RUNNING >> >> Bingo >> >> [ 1200.851004] kjournald D

Re: [PATCH] locking/mutexes: Revert locking/mutexes: Add extra reschedule point

On Thu, Jul 31, 2014 at 6:39 PM, Peter Zijlstra pet...@infradead.org wrote: On Thu, Jul 31, 2014 at 04:30:52PM +0200, Mike Galbraith wrote: On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote: Smells like maybe current-state != TASK_RUNNING Bingo [ 1200.851004] kjournald D

Re: [PATCH] locking/mutexes: Revert locking/mutexes: Add extra reschedule point

On Fri, Aug 1, 2014 at 5:27 PM, Peter Zijlstra pet...@infradead.org wrote: On Fri, Aug 01, 2014 at 04:56:27PM +0400, Ilya Dryomov wrote: I'm going to fix up rbd_request_fn(), but I want to make sure I understand this in full. - Previously the danger of calling blocking primitives on the way

Re: [PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point"

On Thu, Jul 31, 2014 at 6:30 PM, Mike Galbraith wrote: > On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote: > >> Smells like maybe current->state != TASK_RUNNING It just triggered for me too, took longer than usual. Sorry for the churn Peter, this was really confusing. Onto finding the

Re: [PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point"

On Thu, Jul 31, 2014 at 5:13 PM, Peter Zijlstra wrote: > On Thu, Jul 31, 2014 at 04:37:29PM +0400, Ilya Dryomov wrote: > >> This didn't make sense to me at first too, and I'll be happy to be >> proven wrong, but we can reproduce this with rbd very reliably under >>

Re: [PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point"

On Thu, Jul 31, 2014 at 3:57 PM, Peter Zijlstra wrote: > On Thu, Jul 31, 2014 at 02:16:37PM +0400, Ilya Dryomov wrote: >> This reverts commit 34c6bc2c919a55e5ad4e698510a2f35ee13ab900. >> >> This commit can lead to deadlocks by way of what at a high level >> appears to

[PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point"

and made everything disappear, which is why it hasn't been looked into until now. Revert makes the problem go away, confirmed by our users. Cc: Peter Zijlstra Cc: sta...@vger.kernel.org # 3.15 Signed-off-by: Ilya Dryomov --- kernel/locking/mutex.c |7 --- 1 file changed, 7 deletions(-) d

[PATCH] locking/mutexes: Revert locking/mutexes: Add extra reschedule point

and made everything disappear, which is why it hasn't been looked into until now. Revert makes the problem go away, confirmed by our users. Cc: Peter Zijlstra pet...@infradead.org Cc: sta...@vger.kernel.org # 3.15 Signed-off-by: Ilya Dryomov ilya.dryo...@inktank.com --- kernel/locking/mutex.c |7

Re: [PATCH] locking/mutexes: Revert locking/mutexes: Add extra reschedule point

On Thu, Jul 31, 2014 at 3:57 PM, Peter Zijlstra pet...@infradead.org wrote: On Thu, Jul 31, 2014 at 02:16:37PM +0400, Ilya Dryomov wrote: This reverts commit 34c6bc2c919a55e5ad4e698510a2f35ee13ab900. This commit can lead to deadlocks by way of what at a high level appears to look like

Re: [PATCH] locking/mutexes: Revert locking/mutexes: Add extra reschedule point

On Thu, Jul 31, 2014 at 5:13 PM, Peter Zijlstra pet...@infradead.org wrote: On Thu, Jul 31, 2014 at 04:37:29PM +0400, Ilya Dryomov wrote: This didn't make sense to me at first too, and I'll be happy to be proven wrong, but we can reproduce this with rbd very reliably under higher than usual

Re: [PATCH] locking/mutexes: Revert locking/mutexes: Add extra reschedule point

On Thu, Jul 31, 2014 at 6:30 PM, Mike Galbraith umgwanakikb...@gmail.com wrote: On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote: Smells like maybe current-state != TASK_RUNNING It just triggered for me too, took longer than usual. Sorry for the churn Peter, this was really confusing.

<    1   2   3   4   5   6   >