Re: [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests

/exynos_mixer.o: in > function `mixer_bind': > exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent' > > Reported-by: kernel test robot > Signed-off-by: Krzysztof Kozlowski Picked it up. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/Kconfig | 3 ++- &

Re: [PATCH 14/18] drm/exynos: Consolidate IOMMU mapping code

y: Robin Murphy > > --- > This is a cheeky revert of 07dc3678bacc ("drm/exynos: Fix cleanup of > IOMMU related objects"), plus removal of the remaining arm_iommu_* > references on top. Thanks for cleanup. Acked-by: Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos5433

Re: [PATCH v7 07/36] drm: exynos: use common helper for a scatterlist contiguity check

20. 6. 19. 오후 7:36에 Marek Szyprowski 이(가) 쓴 글: > Use common helper for checking the contiguity of the imported dma-buf. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 23 +++ &g

Re: [PATCH v7 08/36] drm: exynos: fix common struct sg_table related issues

ways, hides references to the > nents and orig_nents entries, making the code robust, easier to follow > and copy/paste safe. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 +- > 1 file

Re: [PATCH v2] drm/exynos: fix ref count leak in mic_pre_enable

Navid Emamdoost > --- > Changes in v2: > - reuse the unlock label and call pm_runtime_put_noidle Picked it up. Thanks, Inki Dae > --- > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH] drm/exynos: fix ref count leak in mic_pre_enable

goto turn_off; How about just calling pm_runtime_put_noidle()? if (ret < 0) { pm_runtime_put_noidle(mic->dev); goto unlock; } Thanks, Inki Dae > > mic_set_path(mic, 1); > >

Re: [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure

20. 5. 21. 오후 11:22에 Tamseel Shams 이(가) 쓴 글: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. Picked it up. Thanks, Inki Dae > > Signed-off-by: Tamseel Shams > --- &g

Re: [PATCH v2] drm/exynos: Remove dev_err() on platform_get_irq() failure

Hi Tamseel, Same patch[1] has been merged. So could you re-post this patch after rebasing it on top of exynos-drm-next branch? After rebase, only g2d part would be valid. Thanks, Inki Dae [1] https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next

Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in error handling path in probe function

20. 5. 16. 오후 7:57에 Christophe JAILLET 이(가) 쓴 글: > 'exynos_dsi_parse_dt()' takes a reference to 'dsi->in_bridge_node'. > This must be released in the error handling path. Picked it up. Thanks, Inki Dae > > In order to do that, add an error handling path and move the > 'e

Re: [PATCH] drm/exynos: dsi: Remove bridge node reference in error handling path in probe function

dle the error simply. dsi->in_bridge_node is accessed in bind function and the probe function is called before the bind call. Could you rework and post it again? Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 28 ++--- > 1 file changed,

Re: ERROR: "vmf_insert_mixed" [drivers/gpu/drm/exynos/exynosdrm.ko] undefined!

bot > > All errors (new ones prefixed by >>): > >>> ERROR: "vmf_insert_mixed" [drivers/gpu/drm/exynos/exynosdrm.ko] undefined! With below patch I think the build error reported already will be fixed, https://patchwork.kernel.org/patch/11035147/ Thanks, Inki Dae &g

Re: [PATCH 1/6] include/drm: color_mgmt: Add enum labels

n't see why above two types are needed. Is there any case that the range checking behavior should be different according to the color space? And even if there is that case, I think you have to put DRM_COLOR_RANG_MAX under DRM_COLOR_FULL_RANGE. Thanks, Inki Dae > }; > > int drm_plane_create_color_properties(struct drm_plane *plane, >

Re: [PATCH 1/3] drm/exynos: rotator: Add support for s5pv210

Applied. Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 23 + > 1 file changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > index a820a68429b9..

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018년 07월 25일 17:11에 Andrzej Hajda 이(가) 쓴 글: > On 24.07.2018 09:49, Inki Dae wrote: >> Hi, >> >> 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >>> When adding support for peripheral out bridges, the "bridge" name >>> becomes imprecise as it refe

Re: [PATCH v3 1/9] drm/exynos: rename "bridge_node" to "mic_bridge_node"

2018년 07월 25일 17:11에 Andrzej Hajda 이(가) 쓴 글: > On 24.07.2018 09:49, Inki Dae wrote: >> Hi, >> >> 2018년 06월 19일 17:19에 Maciej Purski 이(가) 쓴 글: >>> When adding support for peripheral out bridges, the "bridge" name >>> becomes imprecise as it refe

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018년 03월 29일 16:00에 Greg KH 이(가) 쓴 글: > On Thu, Mar 29, 2018 at 03:39:54PM +0900, Inki Dae wrote: >> 2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: >>> On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: >>>> Really thanks for doing this. :) There would be many

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018년 03월 29일 16:00에 Greg KH 이(가) 쓴 글: > On Thu, Mar 29, 2018 at 03:39:54PM +0900, Inki Dae wrote: >> 2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: >>> On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: >>>> Really thanks for doing this. :) There would be many

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: > On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: >> Really thanks for doing this. :) There would be many users who use >> Linux-3.18 for their products yet. > > For new products? They really should not be. The kernel

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: > On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: >> Really thanks for doing this. :) There would be many users who use >> Linux-3.18 for their products yet. > > For new products? They really should not be. The kernel

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

d field. > > I noticed an extra bug while testing it, but the bug also hits upstream, > and should be backported all the way down all stable/LTS versions. > So, I'll send it the usual way, after merging upsream. Really thanks for doing this. :) There would be many users who use Linux

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

d field. > > I noticed an extra bug while testing it, but the bug also hits upstream, > and should be backported all the way down all stable/LTS versions. > So, I'll send it the usual way, after merging upsream. Really thanks for doing this. :) There would be many users who use Linux

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

Hi Sylwester, 2018년 03월 09일 20:52에 Sylwester Nawrocki 이(가) 쓴 글: > Hi Inki, > > On 03/09/2018 03:40 AM, Inki Dae wrote: >> 2018년 03월 08일 02:27에 Sylwester Nawrocki 이(가) 쓴 글: >>> This property is required for specifying link between the HDMI IP block >>&

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

Hi Sylwester, 2018년 03월 09일 20:52에 Sylwester Nawrocki 이(가) 쓴 글: > Hi Inki, > > On 03/09/2018 03:40 AM, Inki Dae wrote: >> 2018년 03월 08일 02:27에 Sylwester Nawrocki 이(가) 쓴 글: >>> This property is required for specifying link between the HDMI IP block >>&

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

this property to hdmi device node which is bound by HDMI driver of Exynos DRM. As we talked about this at other email thread, seems this property is required mandatorily for Odroid XU3/4 board which uses Exynos5422. There may be something I'm missing so could you let me know how this property is required? Thanks, Inki Dae > status = "disabled"; > }; > >

Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node

which is bound by HDMI driver of Exynos DRM. As we talked about this at other email thread, seems this property is required mandatorily for Odroid XU3/4 board which uses Exynos5422. There may be something I'm missing so could you let me know how this property is required? Thanks, Inki Dae > status = "disabled"; > }; > >

Re: [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask

t; -#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK((0xff < 13) | (0xff < > 0)) > +#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK((0xff << 13) | (0xff > << 0)) > Oops. Picked it up. Thanks, Inki Dae > /* Real input DMA size register */ > #define EXYNOS_CIREAL_ISIZE_AUTOLOAD_ENABLE (1 << 31) >

Re: [PATCH 2/4] drm/exynos: fix comparison to bitshift when dealing with a mask

CIIMGEFF_PAT_CBCR_MASK((0xff < 13) | (0xff < > 0)) > +#define EXYNOS_CIIMGEFF_PAT_CBCR_MASK((0xff << 13) | (0xff > << 0)) > Oops. Picked it up. Thanks, Inki Dae > /* Real input DMA size register */ > #define EXYNOS_CIREAL_ISIZE_AUTOLOAD_ENABLE (1 << 31) >

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

, it will work just fine with > monotonic times as long as the application only looks at the > relative values between two events. > > Link: https://patchwork.kernel.org/patch/10038593/ > Cc: Tobias Jakobi <tjak...@math.uni-bielefeld.de> > Signed-off-by: Arnd Bergmann <

Re: [PATCH] [v2] drm/exynos: g2d: use monotonic timestamps

, it will work just fine with > monotonic times as long as the application only looks at the > relative values between two events. > > Link: https://patchwork.kernel.org/patch/10038593/ > Cc: Tobias Jakobi > Signed-off-by: Arnd Bergmann Picked it up. Thanks, Inki Dae >

Re: [RFC 1/2] arm: cacheflush syscall: process only pages that are in the memory

ing the > cache flushing function (__do_cache_op()). > > The point is that if __do_cache_op() faults, it will enter > do_page_fault(), which will try to take the mmap_sem again, causing > a deadlock. I'm not sure but seems this patch tries to do cache-flush only in-memory pages. So I think the page fault wouldn't happen becasue flush_cache_user_range function returns always 0. Thanks, Inki Dae >

Re: [RFC 1/2] arm: cacheflush syscall: process only pages that are in the memory

ing the > cache flushing function (__do_cache_op()). > > The point is that if __do_cache_op() faults, it will enter > do_page_fault(), which will try to take the mmap_sem again, causing > a deadlock. I'm not sure but seems this patch tries to do cache-flush only in-memory pages. So I think the page fault wouldn't happen becasue flush_cache_user_range function returns always 0. Thanks, Inki Dae >

Re: [PATCH 03/19] drm/exynos: Use the alpha format helper

2018년 01월 09일 19:56에 Maxime Ripard 이(가) 쓴 글: > Now that the core has a drm format helper to tell if a format embeds an > alpha component in it, let's use it. > > Cc: Inki Dae <inki@samsung.com> > Cc: Joonyoung Shim <jy0922.s...@samsung.com> > Cc: Kyungmin P

Re: [PATCH 03/19] drm/exynos: Use the alpha format helper

2018년 01월 09일 19:56에 Maxime Ripard 이(가) 쓴 글: > Now that the core has a drm format helper to tell if a format embeds an > alpha component in it, let's use it. > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Kyungmin Park > Cc: Seung-Woo Kim > Signed-off-by: Maxime Rip

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

will call > of_drm_find_bridge on dsi->bridge_node which was put earlier (point 2.). > Right. This is a problem. How about moving of_drm_find_bridge function call to probe and keeping drm_bridge_attach call in bind for cleanup? Seems it doesn't need to call of_drm_find_bridge function

Re: [PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

will call > of_drm_find_bridge on dsi->bridge_node which was put earlier (point 2.). > Right. This is a problem. How about moving of_drm_find_bridge function call to probe and keeping drm_bridge_attach call in bind for cleanup? Seems it doesn't need to call of_drm_find_bridge function

Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally. Thanks, Inki Dae > > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos

Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing

of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally. Thanks, Inki Dae > > Signed-off-by: Hoegeun Kwon > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- > 1 f

Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal

ki, > > This patch seems to have been forgotten... :) Yeah, forgot this. Merged. Thanks, Inki Dae > > Changes for V2: > > - Checked for rebase 4.12-rc2 > > Best regards, > Hoegeun > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 > 1 file changed, 4 in

Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal

Yeah, forgot this. Merged. Thanks, Inki Dae > > Changes for V2: > > - Checked for rebase 4.12-rc2 > > Best regards, > Hoegeun > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/exyno

Re: [PATCH] arm64: dts: exynos: Remove the te-gpios property in the TM2 boards

ts/exynos/exynos5433-tm2.dts > @@ -60,7 +60,6 @@ > vci-supply = <_reg>; > reset-gpios = < 0 GPIO_ACTIVE_LOW>; > enable-gpios = < 5 GPIO_ACTIVE_HIGH>; > - te-gpios = < 3 GPIO_ACTIVE_HIGH>; Reviewed-by: Inki Dae <inki@samsung.com> Thanks, Inki Dae > }; > }; > >

Re: [PATCH] arm64: dts: exynos: Remove the te-gpios property in the TM2 boards

-60,7 +60,6 @@ > vci-supply = <_reg>; > reset-gpios = < 0 GPIO_ACTIVE_LOW>; > enable-gpios = < 5 GPIO_ACTIVE_HIGH>; > - te-gpios = < 3 GPIO_ACTIVE_HIGH>; Reviewed-by: Inki Dae Thanks, Inki Dae > }; > }; > >

Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on TM2e board

display mode that matches the type. So add the check code for s6e3ha2 >> compatibility and s6e3hf2 type and select the drm_display_mode of >> default and edge type. >> >> Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> > Reviewed-by: Andrzej Hajda <a.ha...@sa

Re: [PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on TM2e board

display mode that matches the type. So add the check code for s6e3ha2 >> compatibility and s6e3hf2 type and select the drm_display_mode of >> default and edge type. >> >> Signed-off-by: Hoegeun Kwon > Reviewed-by: Andrzej Hajda Reviewed-by: Inki Dae Thanks, Inki Dae

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski <k...@kernel.org> wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae <inki@samsung.com> wrote: >>> Merged. >> >> Hi, >> >> I do n

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae wrote: >>> Merged. >> >> Hi, >> >> I do not see the tag (with DT patches) merge

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski <k...@kernel.org> wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae <inki@samsung.com> wrote: >>> Merged. >> >> Hi, >> >> I do n

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

2017년 04월 05일 00:38에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Mar 28, 2017 at 11:38 AM, Krzysztof Kozlowski wrote: >> On Tue, Mar 28, 2017 at 11:26 AM, Inki Dae wrote: >>> Merged. >> >> Hi, >> >> I do not see the tag (with DT patches) merge

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

Merged. Thanks, Inki Dae 2017년 03월 22일 10:36에 Hoegeun Kwon 이(가) 쓴 글: > Hi inki, > > Could you check the this patch? > For reference, patch 1/5 and 2/5 have already been applied to Krzysztof tree. > > Best regards, > Hoegeun > > > On 03/08/2017 01:54 PM, Hoegeun

Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function

Merged. Thanks, Inki Dae 2017년 03월 22일 10:36에 Hoegeun Kwon 이(가) 쓴 글: > Hi inki, > > Could you check the this patch? > For reference, patch 1/5 and 2/5 have already been applied to Krzysztof tree. > > Best regards, > Hoegeun > > > On 03/08/2017 01:54 PM, Hoegeun

Re: [PATCH] drm/exynos: Print kernel pointers in a restricted form

Merged. Thanks, Inki Dae 2017년 03월 15일 03:38에 Krzysztof Kozlowski 이(가) 쓴 글: > Printing raw kernel pointers might reveal information which sometimes we > try to hide (e.g. with Kernel Address Space Layout Randomization). Use > the "%pK" format so these pointers will be hidd

Re: [PATCH] drm/exynos: Print kernel pointers in a restricted form

Merged. Thanks, Inki Dae 2017년 03월 15일 03:38에 Krzysztof Kozlowski 이(가) 쓴 글: > Printing raw kernel pointers might reveal information which sometimes we > try to hide (e.g. with Kernel Address Space Layout Randomization). Use > the "%pK" format so these pointers will be hidd

Re: [RESEND] drm/exynos: Remove support for Exynos4415 (SoC not supported anymore)

Merged. Thanks. 2017년 03월 12일 03:04에 Krzysztof Kozlowski 이(가) 쓴 글: > Support for Exynos4415 is going away because there are no internal nor > external users. > > Since commit 46dcf0ff0de3 ("ARM: dts: exynos: Remove exynos4415.dtsi"), > the platform cannot be instantiated so remove also the

Re: [RESEND] drm/exynos: Remove support for Exynos4415 (SoC not supported anymore)

Merged. Thanks. 2017년 03월 12일 03:04에 Krzysztof Kozlowski 이(가) 쓴 글: > Support for Exynos4415 is going away because there are no internal nor > external users. > > Since commit 46dcf0ff0de3 ("ARM: dts: exynos: Remove exynos4415.dtsi"), > the platform cannot be instantiated so remove also the

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

Hello David, Thanks for report. 2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) > Result of operator '|' is always true if one operand is non-zero. Did you > intend to use '&'? > Right. this is

Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ?

Hello David, Thanks for report. 2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) > Result of operator '|' is always true if one operand is non-zero. Did you > intend to use '&'? > Right. this is

Re: [PATCH v3 4/7] drm/exynos/hdmi: add bridge support

2017년 02월 03일 15:38에 Inki Dae 이(가) 쓴 글: > > > 2017년 02월 01일 17:29에 Andrzej Hajda 이(가) 쓴 글: >> On TM2/TM2e platforms HDMI output is connected to MHL bridge >> SiI8620. To allow configure UltraHD modes on the bridge >> and to eliminate unsupported modes this b

Re: [PATCH v3 4/7] drm/exynos/hdmi: add bridge support

2017년 02월 03일 15:38에 Inki Dae 이(가) 쓴 글: > > > 2017년 02월 01일 17:29에 Andrzej Hajda 이(가) 쓴 글: >> On TM2/TM2e platforms HDMI output is connected to MHL bridge >> SiI8620. To allow configure UltraHD modes on the bridge >> and to eliminate unsupported modes this b

Re: [PATCH v3 4/7] drm/exynos/hdmi: add bridge support

0; > + if (hdata->bridge) { > + encoder->bridge = hdata->bridge; > + hdata->bridge->encoder = encoder; > + ret = drm_bridge_attach(encoder->dev, hdata->bridge); arguments of drm_bridge_attach function has been change

Re: [PATCH v3 4/7] drm/exynos/hdmi: add bridge support

f (hdata->bridge) { > + encoder->bridge = hdata->bridge; > + hdata->bridge->encoder = encoder; > + ret = drm_bridge_attach(encoder->dev, hdata->bridge); arguments of drm_bridge_attach function has been changed so fixed it - trivial

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

t;> >>>>>>> [ Unknown signature status ] >>>>>>> On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >>>>>>>> On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>>>>>>

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

; On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >>>>>>>> On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>>>>>> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >>>>>>>>>> >>&g

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

;> On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >>>>>>> On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>>>>> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >>>>>>>>> >>>>>>>

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >>>>> Thierry Reding writes: >>>>> >>>>>> [ Unknown signature status ] >>>>>> On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >>>>>

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

Dear Thierry, 2017년 02월 01일 23:44에 Thierry Reding 이(가) 쓴 글: > On Wed, Feb 01, 2017 at 08:48:30AM +0900, Inki Dae wrote: >> >> >> 2017년 02월 01일 06:31에 Thierry Reding 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >>>> Thierr

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

Dear Thierry, 2017년 02월 01일 23:44에 Thierry Reding 이(가) 쓴 글: > On Wed, Feb 01, 2017 at 08:48:30AM +0900, Inki Dae wrote: >> >> >> 2017년 02월 01일 06:31에 Thierry Reding 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >>>> Th

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017년 02월 01일 17:12에 Andrzej Hajda 이(가) 쓴 글: > On 01.02.2017 08:44, Inki Dae wrote: >> >> 2017년 02월 01일 16:34에 Andrzej Hajda 이(가) 쓴 글: >>> On 01.02.2017 08:31, Inki Dae wrote: >>>> 2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: >>>>> In some pl

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017년 02월 01일 17:12에 Andrzej Hajda 이(가) 쓴 글: > On 01.02.2017 08:44, Inki Dae wrote: >> >> 2017년 02월 01일 16:34에 Andrzej Hajda 이(가) 쓴 글: >>> On 01.02.2017 08:31, Inki Dae wrote: >>>> 2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: >>>>> In some pl

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017년 02월 01일 16:34에 Andrzej Hajda 이(가) 쓴 글: > On 01.02.2017 08:31, Inki Dae wrote: >> >> 2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: >>> In some platforms there is attached another device to the end of HDMI. >>> The patch adds support for it. >> Andrzej,

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017년 02월 01일 16:34에 Andrzej Hajda 이(가) 쓴 글: > On 01.02.2017 08:31, Inki Dae wrote: >> >> 2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: >>> In some platforms there is attached another device to the end of HDMI. >>> The patch adds support for it. >> Andrzej,

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: > In some platforms there is attached another device to the end of HDMI. > The patch adds support for it. Andrzej, can you clarify what bridge device can be attached and actually is now attached to the end of HDMI? And I wonder if we have the device

Re: [PATCH 4/7] drm/exynos/hdmi: add bridge support

2017년 01월 20일 15:52에 Andrzej Hajda 이(가) 쓴 글: > In some platforms there is attached another device to the end of HDMI. > The patch adds support for it. Andrzej, can you clarify what bridge device can be attached and actually is now attached to the end of HDMI? And I wonder if we have the device

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

ote: >>>> On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >>>>>> >>>>>> >>>>>> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>>&

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >>>>> On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >>>>>> >>>>>> >>>>>> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>>>>>> Dear Thierry

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 20:30 GMT+09:00 Krzysztof Kozlowski <k...@kernel.org>: > On Tue, Jan 31, 2017 at 12:37 PM, Inki Dae <daei...@gmail.com> wrote: >> 2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski <k...@kernel.org>: >>> On Tue, Jan 31, 2017 at 11:34 AM, I

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 20:30 GMT+09:00 Krzysztof Kozlowski : > On Tue, Jan 31, 2017 at 12:37 PM, Inki Dae wrote: >> 2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski : >>> On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae wrote: >>>> >>>> >>>> 2017년 01월 31일 18:

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski <k...@kernel.org>: > On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae <inki@samsung.com> wrote: >> >> >> 2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae <inki

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski : > On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae wrote: >> >> >> 2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: >>> On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae wrote: >>>> >>>> >>>&

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae <inki@samsung.com> wrote: >> >> >> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>> Dear Thierry, >>> >>> Could you please review this patc

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글: > On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae wrote: >> >> >> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>> Dear Thierry, >>> >>> Could you please review this patch? >> >> Thierry, I t

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 31일 17:54에 Thierry Reding 이(가) 쓴 글: > On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >> >> >> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>> Dear Thierry, >>> >>> Could you please review this patch? >> >> Thierry

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 31일 17:54에 Thierry Reding 이(가) 쓴 글: > On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >> >> >> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: >>> Dear Thierry, >>> >>> Could you please review this patch? >> >> Thierry

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: > Dear Thierry, > > Could you please review this patch? Thierry, I think this patch has been reviewed enough but no comment from you. Seems you are busy. I will pick up this. Thanks. > > Best Regards, > Hoegeun Kwon > > On 01/11/2017 03:33 PM,

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: > Dear Thierry, > > Could you please review this patch? Thierry, I think this patch has been reviewed enough but no comment from you. Seems you are busy. I will pick up this. Thanks. > > Best Regards, > Hoegeun Kwon > > On 01/11/2017 03:33 PM,

Re: [PATCH 1/3] drm/exynos/decon5433: do not disable video after reset

Applied including other two patches. Thanks. 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > decon_commit is called just after reset so video is disabled anyway. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- > 1 file

Re: [PATCH 1/3] drm/exynos/decon5433: do not disable video after reset

Applied including other two patches. Thanks. 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > decon_commit is called just after reset so video is disabled anyway. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 2 -- > 1 file changed, 2 deletions(-) > >

Re: [PATCH 0/3] Fix DECON_UPDATE for TV

Hi Andrzej, 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > This is my final fight with DECON_UPDATE issues (I hope). My two previous > patches > fixed problems on panel path, this patchset fixes also TV path. > The root cause of all evil was in incorrect DECON_CMU programming. > >

Re: [PATCH 0/3] Fix DECON_UPDATE for TV

Hi Andrzej, 2017년 01월 17일 23:15에 Andrzej Hajda 이(가) 쓴 글: > Hi Inki, > > This is my final fight with DECON_UPDATE issues (I hope). My two previous > patches > fixed problems on panel path, this patchset fixes also TV path. > The root cause of all evil was in incorrect DECON_CMU programming. > >

Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang >>

Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: > On 11.01.2017 07:33, Hoegeun Kwon wrote: >> From: Hyungwon Hwang >> >> This patch add the panel device tree node for S6E3HA2 display >> controller to TM2 dts. >> >> Signed-off-by: Hyungwon Hwang >> Signed-off-by: Andrzej Hajda >> Signed-off-by:

Re: [PATCH v7 1/4] drm/exynos: mic: Add mode_set callback function

Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get

Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > The OF graph is not necessary because the panel is a child of > dsi. therefore, the parse_dt function of dsi does not need to > check the remote_node connected to the panel. and the whole > parse_dt function should be refactored

Re: [PATCH v7 1/4] drm/exynos: mic: Add mode_set callback function

Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > Before applying the patch, used the of_get_videomode function to > parse the display-timings in the panel which is the child driver > of dsi in the devicetree. this is wrong. So removed the > of_get_videomode and fixed to get

Re: [PATCH v7 2/4] drm/exynos: mic: Fix parse_dt function

Applied. Thanks. 2017년 01월 05일 19:20에 Hoegeun Kwon 이(가) 쓴 글: > The OF graph is not necessary because the panel is a child of > dsi. therefore, the parse_dt function of dsi does not need to > check the remote_node connected to the panel. and the whole > parse_dt function should be refactored

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 09일 18:53에 Andrzej Hajda 이(가) 쓴 글: > On 09.01.2017 10:19, Inki Dae wrote: >> >> 2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: >>> On 06.01.2017 09:36, Inki Dae wrote: >>>> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>>

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 09일 18:53에 Andrzej Hajda 이(가) 쓴 글: > On 09.01.2017 10:19, Inki Dae wrote: >> >> 2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: >>> On 06.01.2017 09:36, Inki Dae wrote: >>>> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>>

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: > On 06.01.2017 09:36, Inki Dae wrote: >> >> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>> Hi Inki, >>> >>> Thanks for the reply, but... >>> >>>>>> +static const str

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 09일 16:37에 Andrzej Hajda 이(가) 쓴 글: > On 06.01.2017 09:36, Inki Dae wrote: >> >> 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >>> Hi Inki, >>> >>> Thanks for the reply, but... >>> >>>>>> +static const str

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: > Hi Inki, > > Thanks for the reply, but... > +static const struct drm_display_mode default_mode = { + .clock = 222372, + .hdisplay = 1440, + .hsync_start = 1440 + 1, + .hsync_end = 1440 + 1 + 1, + .htotal = 1440 + 1

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: > Hi Inki, > > Thanks for the reply, but... > +static const struct drm_display_mode default_mode = { + .clock = 222372, + .hdisplay = 1440, + .hsync_start = 1440 + 1, + .hsync_end = 1440 + 1 + 1, + .htotal = 1440 + 1

Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

es valid for both > the boards? We don't need to consider tm2e board with two reasones, 1. there is no tm2e board support in mainline 2. the panel on tm2 would be a little bit different from one on tm2e Thanks, Inki Dae > > Andi > >

  1   2   3   4   >